Hello Sandeep,
Yes, please apply the patch.
Regards
--
Delio
On 22/06/2010, at 16:27, Paulraj, Sandeep wrote:
>
>
>>>
>>> Not testing the txp and rxp pointers in the loop was a significant
>>> gain for me and pipe-lining the TX and RX operations is going to be
>>> a little trickier, but giv
On 22/06/2010, at 10:29, Nick Thompson wrote:
> On 21/06/10 19:38, Delio Brignoli wrote:
>> Hello Nick,
>>
>> On 21/06/2010, at 11:27, Nick Thompson wrote:
>>> The following restructuring and optimisations increase the SPI
>>> read performance from 1.3
Hello Nick,
On 21/06/2010, at 11:27, Nick Thompson wrote:
> The following restructuring and optimisations increase the SPI
> read performance from 1.3MiB/s (on da850) to 2.87MiB/s (on da830):
Using this patch I get 2.21MiB/s on my L138 EVM (da850), quite
an improvement! I would like to see how m
Hello Nick,
On 17/06/2010, at 17:02, Nick Thompson wrote:
> On 01/06/10 12:36, Delio Brignoli wrote:
>> I have updated this patch based on the comments [1] by Wolfgang Denk and
>> removed unused variables.
>> [1][http://lists.denx.de/pipermail/u-boot/2010-May/071728.ht
Thank you Sandeep.
--
Delio
On 07/06/2010, at 23:17, Paulraj, Sandeep wrote:
>> Checkpatch returned 4 errors.
>>
>> Please fix and resubmit
>>
>> Thanks,
>> Sandeep
>
> I fixed them myself.
>
> Pushed to u-boot-ti
___
U-Boot mailing list
U-Boot@list
module. On LogicPD OMAP-L138 EVM,
SPI read throughput goes up from ~0.8Mbyte/s to ~1.3Mbyte/s. Tested with a
2Mbyte image file.
Remove unused variables in the spi_xfer() function.
Signed-off-by: Delio Brignoli
Tested-by: Ben Gardiner
---
drivers/spi/davinci_spi.c | 69
Hello Sekhar,
On 01/06/2010, at 12:18, Nori, Sekhar wrote:
[...]
> Considering this, can you please accept the change Wolfgang
> is asking for for so this useful patch can move forward?
Yes, I am fine applying the changes Wolfgang requested.
I have been busy working on other stuff, hence the dela
Hello Wolfgang,
On 24/05/2010, at 22:48, Wolfgang Denk wrote:
> In message <15866eae-624b-4850-b10f-78ab99e3a...@audioscience.com> you wrote:
>>
>> On 21/05/2010, at 15:13, Wolfgang Denk wrote:
+ *rxp = buf_reg_val & 0xFF;
+ rxp++;
Hello Wolfgang,
On 21/05/2010, at 15:13, Wolfgang Denk wrote:
>> +*rxp = buf_reg_val & 0xFF;
>> +rxp++;
>> +}
>
> Please change into:
>
> if (rxp)
> *rxp++ = buf_
Hello Sekhar,
I resubmitted the patch a few days ago (13th of May) with the changes you
requested. Please ack it, so it can be applied.
Thanks
--
Delio
On 18/05/2010, at 14:25, Nori, Sekhar wrote:
> On Thu, May 13, 2010 at 18:27:51, Delio Brignoli wrote:
>> Reduce the number of reads
Hello Sekhar,
On 18/05/2010, at 14:25, Nori, Sekhar wrote:
> The patch looks good to me.
>
> Can you please publish some sort of numbers in the
> patch description indicating the performance improvement
> achieved?
will do.
> A minor nit below:
[...]
>> + if((o_cnt == (len -
was tested on a LogicPD Zoom™ OMAP-L138 eXperimenter Kit
(da850_omapl138_evm_config).
--
Delio
>> Signed-off-by: Delio Brignoli
>> ---
>> drivers/spi/davinci_spi.c | 67 +++-
>>
>> 1 files changed, 35 insertions(+), 32 deleti
Reduce the number of reads per byte transferred on the BUF register from 2 to 1
and
take advantage of the TX buffer in the SPI module.
Signed-off-by: Delio Brignoli
---
drivers/spi/davinci_spi.c | 67 +++-
1 files changed, 35 insertions(+), 32
Hello Sekhar,
Thank you for the advice below and sorry for the late reply; I have been
offline for a week and I am catching up with my correspondence only now.
El 26/04/2010, a las 13:56, Nori, Sekhar escribió:
[...]
> The only delays being configured in the driver are the
> chip-select hold time
On 24/04/2010, at 11:42 AM, Wolfgang Denk wrote:
> In message you wrote:
>>
>> OK, so reducing the number of reads from registers and writes to RAM
>> should improve performance. To you knowledge, would enabling the
>> cache for davinci da850 break anything in U-Boot?
>
> No, except that it shou
Hello Wolfgang,
On 24/04/2010, at 10:29 AM, Wolfgang Denk wrote:
> please mind the NetiQuette and restrict your line length to some 70
> charatcers or so. Thanks.
Will do, thanks.
> Everything is slow as caches are not enabled.
OK, so reducing the number of reads from registers and writes to R
Hello Sekhar,
I am working on reducing boot time on an L138 EVM and SPI flash transfer speed
is currently the worst offender. U-Boot transfers from the SPI flash at
0.6Mbytes/s, this a lot slower than I would expect for a 50MHz SPI clock. Using
a scope we found that the chip select is active th
17 matches
Mail list logo
