[PATCH v2 7/7] doc: board/qualcomm: update docs for new u-boot.mbn target

2025-06-02 Thread Casey Connolly
Update the build docs to describe building the u-boot.mbn target explicitly for some boards. Additionally add a new "signing" page to describe the purpose of mkmbn and the MBN format. Signed-off-by: Casey Connolly --- doc/board/qualcomm/index.rst | 1 + doc/board/qualcomm/rb3gen

[PATCH v2 4/7] binman: add support for building Qualcomm signed MBN ELF images

2025-06-02 Thread Casey Connolly
Implement support for building u-boot.mbn files using the new mkmbn tool. Signed-off-by: Casey Connolly --- tools/binman/btool/mkmbn.py | 29 +++ tools/binman/etype/u_boot_mbn.py | 51 2 files changed, 80 insertions(+) diff

[PATCH v2 1/7] binman: add $(srctree)/tools to toolpath

2025-06-02 Thread Casey Connolly
Not all tools need building, look in the srctree toolpath as well as the objtree. Signed-off-by: Casey Connolly --- Makefile | 5 + 1 file changed, 5 insertions(+) diff --git a/Makefile b/Makefile index f88684947ee55fbc28768eeae159432649cc9ec6..719f7f6ba5161f9ae08fcfeec21b45629ef4bb3e

[PATCH v2 2/7] binman: support building binman dtb when OF_UPSTREAM is enabled

2025-06-02 Thread Casey Connolly
Since binman DTB files are not upstream they are kept in the U-Boot dts dirs, this means they will not be built when building with OF_UPSTREAM enabled. Resolve this by adding a rule to build the binman DTB if both conditions are met. Signed-off-by: Casey Connolly --- dts/Makefile | 19

[PATCH v2 6/7] configs: qualcomm: use mkmbn and stop creating ELF files

2025-06-02 Thread Casey Connolly
. Signed-off-by: Casey Connolly --- configs/qcm6490_defconfig | 4 configs/qcom_ipq9574_mmc_defconfig | 1 - configs/qcs9100_defconfig | 12 3 files changed, 17 deletions(-) diff --git a/configs/qcm6490_defconfig b/configs/qcm6490_defconfig index

[PATCH v2 3/7] tools: add mkmbn tool for Qualcomm

2025-06-02 Thread Casey Connolly
/mkmbn.py u-boot.bin The resulting u-boot.mbn will have the correct load address and can be directly flashed to the board from the bootROM with edl.py [1]: https://github.com/msm8916-mainline/qtestsign Signed-off-by: Casey Connolly --- tools/mkmbn | 1 + tools/qcom/mk

[PATCH v2 5/7] configs: qualcomm: use fragments for debug UART

2025-06-02 Thread Casey Connolly
The QCM6490 and QCS9100 targets always enable debug UART, but this is not really optimal for typical users. Move these debug UART options to config fragments so that they aren't enabled by default. Signed-off-by: Casey Connolly --- board/qualcomm/debug-qcm6490.config | 5 + board/qua

[PATCH v2 0/7] Qualcomm: teach the build system to emit signed ELF images

2025-06-02 Thread Casey Connolly
c: u-boot-q...@groups.io Cc: Varadarajan Narayanan Cc: Balaji Selvanathan Cc: Aswin Murugan Signed-off-by: Casey Connolly --- Changes in v2: - Reworked to use binman with a plugin to build the u-boot.mbn file - Added some fixes for binman to work with OF_UPSTREAM and with tools in the sr

Re: [PATCH v4 0/5] Enable env in SCSI

2025-05-29 Thread Casey Connolly
For all except the doc: commit Acked-by: Casey Connolly On 5/13/25 11:17, Varadarajan Narayanan wrote: The qcs9100 based Ride platforms have UFS as their primary storage. Hence add support to U-Boot env framework to be able to save and retrieve the environment from UFS. The environment will

Re: [PATCH v4 5/5] configs: qcs9100: Enable env in SCSI

2025-05-29 Thread Casey Connolly
On 5/20/25 16:32, Varadarajan Narayanan via groups.io wrote: Enable CONFIG_ENV_IS_IN_SCSI to store environment variables in SCSI. Set env variables partition UUID as seen in qcs9100 based boards. Signed-off-by: Varadarajan Narayanan Reviewed-by: Casey Connolly > --- v3

Re: [PATCH v4 4/5] doc: board/qualcomm: document iq9 building and flashing

2025-05-29 Thread Casey Connolly
On 5/20/25 16:32, Varadarajan Narayanan via groups.io wrote: The steps are similar to other boards. Minor difference in the way environment variables are stored. Signed-off-by: Varadarajan Narayanan This is superseded by https://lore.kernel.org/u-boot/20250521094442.3522036-2-balaji.selva

Re: [PATCH 00/10] efi: Move some efi-loader code into a new shared dir

2025-05-28 Thread Casey Connolly
On 5/23/25 16:06, Tom Rini wrote: On Fri, May 23, 2025 at 02:06:35PM +0100, Simon Glass wrote: Some functions provided in lib/efi_loader are actually useful for the app as well. This series refactors the Kconfig and directories a little so that code is easier to share. As a starting point,

Re: [PATCH v4 24/28] board: google: Add board_debug_uart_init() for Trogdor

2025-05-28 Thread Casey Connolly
) port for the AP. This is enough to get the early debug console working on boards like Lazor, but it should work for all Google Trogdor boards. Signed-off-by: Stephen Boyd Reviewed-by: Casey Connolly Would you be willing to add a MAINTAINERS file here for the trogdor specific bits? Kind

Re: [PATCH v4 07/28] serial: msm-geni: Enable SE clk in probe

2025-05-28 Thread Casey Connolly
Hi Stephen, On 5/24/25 00:58, Stephen Boyd wrote: Enable the serial engine clk in probe so that this driver can work on platforms that don't already initialize the clk for this device before this driver runs. This fixes a problem I see on Coreboot platforms like Trogdor where the UART hardware i

Re: [PATCH 00/27] x86: efi: Various app improvements to support bootstd

2025-05-28 Thread Casey Connolly
> base-commit: 42c99ae5bebcecc7b734865c8077c4bf9275e78a $ git branch --all --contains 42c99ae5bebcecc7b734865c8077c4bf9275e78a remotes/sjg/HEAD -> sjg/master remotes/sjg/master remotes/sjg/appc So just totally ignoring the exact same feedback again... Why are these patches on the list? Th

Re: [PATCH 0/5] Qualcomm: teach the build system to emit signed ELF images

2025-05-22 Thread Casey Connolly
On 5/22/25 21:51, Tom Rini wrote: On Thu, May 22, 2025 at 10:39:38PM +0200, Casey Connolly wrote: With several new Qualcomm platforms appearing on the mailing list, all of which build U-Boot as an ELF, sign it, and then flash it to some partition on the board, we're getting a l

[PATCH 5/5] doc: board/qualcomm: update docs for new u-boot.mbn target

2025-05-22 Thread Casey Connolly
Update the build docs to describe building the u-boot.mbn target explicitly for some boards. Additionally add a new "signing" page to describe the purpose of mkmbn and the MBN format. Signed-off-by: Casey Connolly --- doc/board/qualcomm/index.rst | 1 + doc/board/qualcomm/rb3gen

[PATCH 4/5] configs: qualcomm: use mkmbn and stop creating ELF files

2025-05-22 Thread Casey Connolly
. Signed-off-by: Casey Connolly --- configs/qcm6490_defconfig | 4 configs/qcom_ipq9574_mmc_defconfig | 1 - configs/qcs9100_defconfig | 12 3 files changed, 17 deletions(-) diff --git a/configs/qcm6490_defconfig b/configs/qcm6490_defconfig index

[PATCH 3/5] configs: qualcomm: use fragments for debug UART

2025-05-22 Thread Casey Connolly
The QCM6490 and QCS9100 targets always enable debug UART, but this is not really optimal for typical users. Move these debug UART options to config fragments so that they aren't enabled by default. Signed-off-by: Casey Connolly --- board/qualcomm/debug-qcm6490.config | 5 + board/qua

[PATCH 2/5] Makefile: add u-boot.mbn target for mach-snapdragon

2025-05-22 Thread Casey Connolly
Wrap the new mkmbn tool so that the signed U-Boot MBN file is a standard build target. $ make DEVICE_TREE=qcom/qcs6490-rb3gen2 u-boot.mbn Signed-off-by: Casey Connolly --- Makefile | 3 +++ arch/arm/mach-snapdragon/Makefile | 8 2 files changed, 11 insertions

[PATCH 1/5] tools: add mkmbn tool for Qualcomm

2025-05-22 Thread Casey Connolly
/mkmbn.py u-boot.bin The resulting u-boot.mbn will have the correct load address and can be directly flashed to the board from the bootROM with edl.py [1]: https://github.com/msm8916-mainline/qtestsign Signed-off-by: Casey Connolly --- tools/qcom/mkmbn/cert.py| 158 +++ too

[PATCH 0/5] Qualcomm: teach the build system to emit signed ELF images

2025-05-22 Thread Casey Connolly
d be super useful. [1]: https://github.com/msm8916-mainline/qtestsign To: Tom Rini To: Neil Armstrong To: Sumit Garg Cc: u-boot@lists.denx.de Cc: u-boot-q...@groups.io Cc: Varadarajan Narayanan Cc: Balaji Selvanathan Cc: Aswin Murugan Signed-off-by: Casey Connolly --- Casey Connolly (5):

Re: [PATCH v3 1/6] doc: board: qualcomm: document Dragonwing board building/flashing

2025-05-22 Thread Casey Connolly
Hi Balaji, On 5/21/25 10:44, Balaji Selvanathan wrote: Introducing documentation support for Qualcomm Dragonwing series boards. Documents the build and flashing steps. Thanks for adding this! Signed-off-by: Balaji Selvanathan --- v3: - No changes to this patch in v3 v2: - This file is new

Re: [PATCH v3 6/6] configs: add qcs8300_defconfig

2025-05-22 Thread Casey Connolly
Please update the commit title, "qcom_qcs8300_defconfig" Kind regards, On 5/21/25 10:44, Balaji Selvanathan wrote: Introduce a defconfig for QCS8300 based boards. Signed-off-by: Balaji Selvanathan --- v3: - No changes to this patch in v3 v2: - Renamed from "qcs8300_defconfig" to "qcom_qcs830

Re: [PATCH 2/4] iommu: qcom-smmu: Introduce sc7180 compatible string

2025-05-20 Thread Casey Connolly
On 5/20/25 15:25, George Chan via B4 Relay wrote: From: George Chan Add basic compatible string for sc7180 family soc. Signed-off-by: Vitalii Skorkin Co-developed-by: George Chan Signed-off-by: George Chan Reviewed-by: Casey Connolly --- drivers/iommu/qcom-hyp-smmu.c | 1 + 1

Re: [PATCH] qcom_defconfig: Enable AUTOBOOT_KEYED support

2025-05-13 Thread Casey Connolly
Hi Sumit, On 5/12/25 08:01, Sumit Garg wrote: On Fri, May 09, 2025 at 04:54:43PM +0200, Stephan Gerhold wrote: On Fri, May 09, 2025 at 12:45:20PM +0200, Casey Connolly wrote: On 5/8/25 12:32, Sumit Garg wrote: From: Sumit Garg When debug serial port isn't connected, it is at least rep

Re: [PATCH v1 0/6] Introduce support for QCS8300 SoC based IQ8 Series Platform

2025-05-09 Thread Casey Connolly
Hi Balaji, On 5/8/25 13:19, Balaji Selvanathan wrote: These patches introduce the initial support code needed for the QTI QCS8300 SoC based IQ8 Series Platform. Thanks for this series, it's great to see support for this new platform. Given you're introducing a new defconfig, please update do

Re: [PATCH] button: qcom-pmic: allow to specify code in devicetree

2025-05-09 Thread Casey Connolly
ot; property and override statically defined button code & label based on that. [1] https://elixir.bootlin.com/linux/v6.15-rc3/source/arch/ arm64/boot/dts/qcom/sdm630-sony-xperia-nile.dtsi#L263 Signed-off-by: Alexey Minnekhanov Signed-off-by: Alexey Minnekhanov Reviewed-by: Cas

Re: [PATCH v1 4/6] phy: qcom: Enable QMP UFS PHY driver for QCS8300

2025-05-09 Thread Casey Connolly
On 5/8/25 13:19, Balaji Selvanathan wrote: Enable QMP phy for QCS8300, referenced from Linux. Signed-off-by: Balaji Selvanathan Reviewed-by: Casey Connolly > --- drivers/phy/qcom/phy-qcom-qmp-ufs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/phy/qcom/phy-qcom-qmp-uf

Re: [PATCH v1 6/6] configs: add qcs8300_defconfig

2025-05-09 Thread Casey Connolly
Hi Balaji, On 5/8/25 13:19, Balaji Selvanathan wrote: Introduce a defconfig for QCS8300 based boards. Signed-off-by: Balaji Selvanathan --- configs/qcs8300_defconfig | 21 + 1 file changed, 21 insertions(+) create mode 100644 configs/qcs8300_defconfig diff --git a/con

Re: [PATCH v1 6/6] configs: add qcs8300_defconfig

2025-05-09 Thread Casey Connolly
On 5/8/25 13:19, Balaji Selvanathan wrote: Introduce a defconfig for QCS8300 based boards. Signed-off-by: Balaji Selvanathan --- configs/qcs8300_defconfig | 21 + 1 file changed, 21 insertions(+) create mode 100644 configs/qcs8300_defconfig diff --git a/configs/qcs8

Re: [PATCH v1 1/1] gpio: msm_gpio: return correct value for gpio read

2025-05-09 Thread Casey Connolly
off-by: Aswin Murugan Reviewed-by: Casey Connolly > --- drivers/gpio/msm_gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/msm_gpio.c b/drivers/gpio/msm_gpio.c index 6783fc756f4..7de332c66ae 100644 --- a/drivers/gpio/msm_gpio.c +++ b/drivers/gpio/msm_

Re: [PATCH] qcom_defconfig: Enable AUTOBOOT_KEYED support

2025-05-09 Thread Casey Connolly
ation. Anyhow, this is a sensible enough workaround if nobody wants to look into GENI... Reviewed-by: Casey Connolly > Reported-by: Dmitry Baryshkov Signed-off-by: Sumit Garg --- configs/qcom_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configs/qcom_defconfig b/conf

Re: [PATCH v1 2/6] dts: qcs8300-ride-u-boot.dtsi: Add memory entry to bootup

2025-05-09 Thread Casey Connolly
On 5/8/25 13:19, Balaji Selvanathan wrote: Added the memory entry to bootup. Signed-off-by: Balaji Selvanathan Woof we need to get the SMEM parsing sorted... Reviewed-by: Casey Connolly --- arch/arm/dts/qcs8300-ride-u-boot.dtsi | 19 +++ 1 file changed, 19

Re: [PATCH v1 5/6] qcom_defconfig: Enable QCS8300 clock driver

2025-05-09 Thread Casey Connolly
mp;& cp defconfig configs/qcom_defconfig" It's fine if there's some other changes. But this needs to be in the right order. With that Reviewed-by: Casey Connolly CONFIG_CLK_QCOM_SDM845=y CONFIG_CLK_QCOM_SM6115=y CONFIG_CLK_QCOM_SM8150=y -- Casey (she/they)

Re: [PATCH v1 3/6] clk/qcom: qcs8300: Add GCC clock driver for QCS8300

2025-05-09 Thread Casey Connolly
+= clock-qcm2290.o obj-$(CONFIG_CLK_QCOM_QCS404) += clock-qcs404.o obj-$(CONFIG_CLK_QCOM_SA8775P) += clock-sa8775p.o +obj-$(CONFIG_CLK_QCOM_QCS8300) += clock-qcs8300.o Same here With that: Reviewed-by: Casey Connolly obj-$(CONFIG_CLK_QCOM_SC7280) += clock-sc7280.o obj-$(CONFIG_CLK_QCO

Re: [PATCH v3 1/4] disk: part: implement generic function part_get_info_by_uuid()

2025-05-09 Thread Casey Connolly
On 5/8/25 07:23, Varadarajan Narayanan wrote: On Wed, May 07, 2025 at 01:47:40PM +0200, Casey Connolly wrote: Hi Varadarajan, On 5/7/25 13:28, Varadarajan Narayanan wrote: Add function to search for a partition by UUID as partition names may not be unique. Signed-off-by: Varadarajan

Re: [PATCH v3 4/4] configs: qcs9100: Enable env in SCSI

2025-05-07 Thread Casey Connolly
Hi Varadarajan, On 5/7/25 13:28, Varadarajan Narayanan wrote: Enable CONFIG_ENV_IS_IN_SCSI to store environment variables in SCSI. Set env variables partition UUID as seen in qcs9100 based boards. Signed-off-by: Varadarajan Narayanan --- v3: s/CONFIG_SCSI_ENV_PART/CONFIG_SCSI_ENV_PART_UUID ---

Re: [PATCH v3 2/4] scsi: Implement get_blk() function

2025-05-07 Thread Casey Connolly
On 5/7/25 13:28, Varadarajan Narayanan wrote: Add a function to obtain the block device for SCSI. Signed-off-by: Varadarajan Narayanan --- v3: * s/scsi_get_blk/scsi_get_blk_by_uuid * s/partition_name/uuid --- drivers/scsi/scsi-uclass.c | 30 ++ include/scs

Re: [PATCH v3 1/4] disk: part: implement generic function part_get_info_by_uuid()

2025-05-07 Thread Casey Connolly
Hi Varadarajan, On 5/7/25 13:28, Varadarajan Narayanan wrote: Add function to search for a partition by UUID as partition names may not be unique. Signed-off-by: Varadarajan Narayanan --- disk/part.c| 37 + include/part.h | 20 2

Re: [PATCH v2 0/4] Qualcomm: expand capsule update support

2025-05-06 Thread Casey Connolly
On 5/6/25 09:13, Sumit Garg wrote: Hi Casey, On Fri, Apr 11, 2025 at 05:03:33PM +0200, Caleb Connolly wrote: The initial capsule update support only worked on the RB3 Gen 2 and made a lot of assumptions specific to that board. Implement the logic necessary to update U-Boot no matter where i

Re: [PATCH v2 1/2] sysreset: Implement PSCI based reset to EDL mode for QCOM SoCs

2025-05-05 Thread Casey Connolly
On 5/5/25 07:26, Varadarajan Narayanan wrote: On Fri, May 02, 2025 at 02:32:52PM +0200, Casey Connolly wrote: Hi Varadarajan, You have almost entirely ignored my feedback on the previous revision. Sorry. Since you had said "For now I'm fine with this new sysreset-qcom.c driver&q

Re: [PATCH v2 0/4] Qualcomm: expand capsule update support

2025-05-02 Thread Casey Connolly
On 5/2/25 14:37, Sumit Garg wrote: On Fri, May 02, 2025 at 02:16:53PM +0200, Casey Connolly wrote: Hi Sumit, On 5/2/25 12:50, Sumit Garg wrote: Hi Casey On Fri, Apr 11, 2025 at 05:03:33PM +0200, Caleb Connolly wrote: The initial capsule update support only worked on the RB3 Gen 2 and

Re: [PATCH v2 1/2] sysreset: Implement PSCI based reset to EDL mode for QCOM SoCs

2025-05-02 Thread Casey Connolly
Hi Varadarajan, You have almost entirely ignored my feedback on the previous revision. If there's some technical disagreement or you don't understand my feedback then please let me know (in private if you prefer). This approach is fundamentally wrong, full of layering violations and totally

Re: [PATCH v2 0/4] Qualcomm: expand capsule update support

2025-05-02 Thread Casey Connolly
Hi Sumit, On 5/2/25 12:50, Sumit Garg wrote: Hi Casey On Fri, Apr 11, 2025 at 05:03:33PM +0200, Caleb Connolly wrote: The initial capsule update support only worked on the RB3 Gen 2 and made a lot of assumptions specific to that board. Implement the logic necessary to update U-Boot no matter

Re: [PATCH 0/3] board: dragonboard410c: More fixes for U-Boot v2025.07

2025-04-28 Thread Casey Connolly
send a fixup PR, also hoping to get a few more things in.> Signed-off-by: Stephan Gerhold Reviewed-by: Casey Connolly > --- Stephan Gerhold (3): board: dragonboard410c: Fix button cmd name board: dragonboard410c: Drop custom reduced malloc size board: dragonboard4

Re: [PATCH v1 2/3] sysreset: Implement PSCI based reset to EDL mode for QCOM SoCs

2025-04-28 Thread Casey Connolly
On 4/10/25 14:02, Varadarajan Narayanan wrote: Add SYSRESET_EDL to sysreset_t and handle the different SYSRESET_xxx requests in sysreset_qcom-psci.c. To be honest, I'm not really excited about this. Copying the entire PSCI reset code and polluting the global sysreset reason enum with entire

Re: [PATCH v1 1/3] mach-snapdragon: Do not define reset_cpu() if SYSRESET is enabled

2025-04-28 Thread Casey Connolly
Hi Varadarajan, Please rebase on U-Boot master. On 4/10/25 14:02, Varadarajan Narayanan wrote: If CONFIG_SYSRESET is enabled, the reset_cpu() function defined in arch/arm/mach-snapdragon/board.c conflicts with the definition of reset_cpu() in drivers/sysreset/sysreset-uclass.c resulting in dupl

Re: [PATCH 0/3] u-boot chain-loading LineageOS bootimg

2025-04-28 Thread Casey Connolly
Hi George, Thanks a lot for the series, it's super exciting to see support for booting Android on top of U-Boot :D On 4/27/25 13:25, George Chan via B4 Relay wrote: This is a series of patches to enable chainloading LineageOS on qcom SOC. First patch is to workaround kernel/ramdisk invalid a

Re: [PATCH v2 0/6] clk: qcom: apq8016: Clock fixes for U-Boot v2025.07

2025-04-24 Thread Casey Connolly
Reviewed-by: Casey Connolly Thanks!> --- Changes in v2: - Rename BRANCH_CLK() -> GATE_CLK_POLLED() and clarify with comment (Casey) - Add R-b tags from Neil (I assumed the rename is minor enough to keep them) - Link to v1: https://lore.kernel.org/r/20250422-apq8016-clock-fixes2-v1-0-bfc

Re: [PATCH v3] watchdog: qcom: introduce qcom-wdt driver

2025-04-23 Thread Casey Connolly
Hi Paul, Thanks for making it through the process :D LGTM. Kind regards, On 4/23/25 04:19, Paul Sajna wrote: From: Casey Connolly Some Qualcomm device vendors decide to turn the watchdog on in the bootloader, resulting in the device being reset if it isn't petted every ~30 se

Re: [PATCH v2 0/2] watchdog: qcom: introduce qcom-wdt driver

2025-04-22 Thread Casey Connolly
r Qualcomm devices. Some devices, including one I have been spending a lot of time with, the LG G7 ThinQ (codename judyln, arch sdm845) will reset within 30 seconds if the watchdog is not serviced. I have tested this patch from Casey Connolly that is over a year old and has not yet been upstreame

Re: [PATCH v2 2/2] watchdog: qcom: improve driver with more functionality

2025-04-22 Thread Casey Connolly
a7ce31ef811c717fd16700aa7d984a000763a93e..88e5fc7906825ac258393495682a75a5010473b0 100644 --- a/drivers/watchdog/qcom-wdt.c +++ b/drivers/watchdog/qcom-wdt.c @@ -4,12 +4,14 @@ * Copyright (c) Linaro Ltd. 2024 * * Authors: - * Caleb Connolly + * Casey Connolly + * Paul Sajna * * Derived from linux/drivers

Re: [PATCH 4/6] clk: qcom: Allow polling for clock status in qcom_gate_clk_en()

2025-04-22 Thread Casey Connolly
On 4/22/25 12:54, Stephan Gerhold wrote: GATE_CLK() in its current state is unsafe: A simple write to the clock enable register does not guarantee that the clock is immediately running. Without polling the clock status, we may issue writes to registers before the necessary clocks start running

[PATCH] mailmap: update my name and email

2025-04-15 Thread Casey Connolly
Update my name and email address Signed-off-by: Casey Connolly --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index 85086602cd50..717daa9adc4a 100644 --- a/.mailmap +++ b/.mailmap @@ -34,8 +34,9 @@ Bhargava Sreekantappa Gayathri Bin Meng Boris