[PATCH] drivers/mtd/ubispl/ubispl.c: limit copy size

2025-08-04 Thread Benedikt Spranger
uninitialized at that point and overwritten later. Limit the copied bytes to the VID header size. Signed-off-by: Benedikt Spranger Reported-by: Andrew Goodbody --- drivers/mtd/ubispl/ubispl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/ubispl/ubispl.c b/drivers/mtd

Re: Smatch report for ubispl

2025-08-01 Thread Benedikt Spranger
out SPL code here. How are you shure that the suggestion of your tool is correct? Can your tool handle code which interacts with flat mamory without any memory management? And last but not least how is UBI_FM_MAX_BLOCKS configured? Regards Benedikt Spranger

Re: [PATCH 0/5] collected fallout of porting an ATSAMA5D27 based board

2024-10-21 Thread Benedikt Spranger
Am Mon, 21 Oct 2024 08:03:35 +0200 schrieb Alexander Dahl : > Hello Benedikt, > > Am Fri, Oct 18, 2024 at 04:19:08PM +0200 schrieb Benedikt Spranger: > > On Fri, 18 Oct 2024 15:11:20 +0200 > > Alexander Dahl wrote: > > > > Hello Alexander, > > > &g

[PATCH 5/5] mtd: nand: raw: atmel_nand: Add missing nand_scan_ident()

2024-10-18 Thread Benedikt Spranger
In board_nand_init() the used NAND flash is not evaluated. This left vital parts of internal structures uninitialized and SPL NAND flash access is broken. Add the missing nand_scan_ident() to board_nand_init(). Signed-off-by: Benedikt Spranger Reviewed-by: John Ogness --- drivers/mtd/nand/raw

[PATCH 4/5] mtd: nand: Update NAND manufacturer Ids

2024-10-18 Thread Benedikt Spranger
Align manufacturer Ids with the Id list from Linux kernel v6.11. While at it, sort the entries in alphabetical order. Signed-off-by: Benedikt Spranger Reviewed-by: John Ogness --- drivers/mtd/nand/raw/nand_ids.c | 22 -- include/linux/mtd/rawnand.h | 23

[PATCH 3/5] mtd: nand: raw: Fix potential NULL pointer dereference

2024-10-18 Thread Benedikt Spranger
nand_menufacture_desc and remove the checks entirely. Signed-off-by: Benedikt Spranger Reviewed-by: John Ogness --- drivers/mtd/nand/raw/nand_base.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c index 4401bdcdb90

[PATCH 0/5] collected fallout of porting an ATSAMA5D27 based board

2024-10-18 Thread Benedikt Spranger
d it after spending a couple of days debugging it: brilliant! regards Benedikt Spranger Benedikt Spranger (5): tiny-printf: Handle NULL pointer argument to %s drivers/mtd/ubispl/ubispl.c: Fix error message mtd: nand: raw: Fix potential NULL pointer dereference mtd: nand: U

[PATCH 2/5] drivers/mtd/ubispl/ubispl.c: Fix error message

2024-10-18 Thread Benedikt Spranger
The bad CRC error message has transposed characters, which render the output useless: "bad CRC at record 213: #08x, not #08x" instead of "bad CRC at record 213: #, not #4be31f4d" Fix the error message. Signed-off-by: Benedikt Spranger Reviewed-by: John Ogness ---

[PATCH 1/5] tiny-printf: Handle NULL pointer argument to %s

2024-10-18 Thread Benedikt Spranger
A NULL pointer argument to %s causes a NULL pointer dereference in the fixed width numerical printout code, since p is overwritten with NULL. In case of %s width is 0. Check width before dereferencing the pointer. Signed-off-by: Benedikt Spranger Reviewed-by: John Ogness --- lib/tiny-printf.c

[PATCH 0/5] collected fallout of porting an ATSAMA5D2 based board

2024-10-18 Thread Benedikt Spranger
d it after spending a couple of days debugging it: brilliant! regards Benedikt Spranger Benedikt Spranger (5): tiny-printf: Handle NULL pointer argument to %s drivers/mtd/ubispl/ubispl.c: Fix error message mtd: nand: raw: Fix potential NULL pointer dereference mtd: nand: Update NAND ma

[PATCH 3/4] sunxi: pmic_bus: Add DM I2C support

2020-05-29 Thread Benedikt Spranger
Add support for U-Boot DM. Signed-off-by: Benedikt Spranger Reviewed-by: Kurt Kanzenbach --- arch/arm/mach-sunxi/pmic_bus.c | 20 1 file changed, 20 insertions(+) diff --git a/arch/arm/mach-sunxi/pmic_bus.c b/arch/arm/mach-sunxi/pmic_bus.c index 091c59331b..8ecd037528

[PATCH 2/4] i2c: mvtwsi: Add Allwinner sun4i compatible

2020-05-29 Thread Benedikt Spranger
Add the compatible string for the Allwinner A10 i2c controller. Signed-off-by: Benedikt Spranger Reviewed-by: Kurt Kanzenbach --- drivers/i2c/mvtwsi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i2c/mvtwsi.c b/drivers/i2c/mvtwsi.c index d3cc9b9d83..57cd442eee 100644 --- a

[PATCH 4/4] common: Add LX TestBox checks

2020-05-29 Thread Benedikt Spranger
and use the appropriate device tree file. Signed-off-by: Benedikt Spranger Reviewed-by: Kurt Kanzenbach --- arch/arm/mach-sunxi/Kconfig | 15 board/sunxi/board.c | 47 + configs/Lamobo_R1_defconfig | 1 + 3 files changed, 63 insertions

[PATCH 0/4] Add support for LX TestBox

2020-05-29 Thread Benedikt Spranger
The Testbox board is an open hardware enhancement for the Lamobo R1 router board. The Testbox board is used in the CI-RT project to manage devices under test (https://ci-rt.linutronix.de). Add support for the LX TestBox. Benedikt Spranger (4): sunxi: pmic_bus: Refactor pmic_bus_read() and

[PATCH 1/4] sunxi: pmic_bus: Refactor pmic_bus_read() and pmic_bus_write()

2020-05-29 Thread Benedikt Spranger
Unify I2C calls to ease the driver model conversion. Signed-off-by: Benedikt Spranger Reviewed-by: Kurt Kanzenbach --- arch/arm/mach-sunxi/pmic_bus.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/arch/arm/mach-sunxi/pmic_bus.c b/arch/arm