Re: [PATCH 1/3] mux: Kconfig: Add Kconfig options for MUX_MMIO

On 20/03/25 12:00, Anurag Dutta wrote: > Add Kconfig options for MUX_MMIO so that it can be enabled > in SPL stage. > > Signed-off-by: Anurag Dutta > --- > drivers/mux/Kconfig | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/mux/Kconfig b/drivers/mux/Kconfig > index

[PATCH 1/3] mux: Kconfig: Add Kconfig options for MUX_MMIO

Add Kconfig options for MUX_MMIO so that it can be enabled in SPL stage. Signed-off-by: Anurag Dutta --- drivers/mux/Kconfig | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/mux/Kconfig b/drivers/mux/Kconfig index f15ee4f833f..2b95eb02177 100644 --- a/drivers/mux/Kconfig +

[PATCH 3/3] configs: j721e_evm_a72_defconfig: Enable MUX_MMIO at SPL

MUX_MMIO is required in SPL stage in order to boot hyperflash successfully. Add configs to enable MUX_MMIO in SPL stage. Signed-off-by: Anurag Dutta --- configs/j721e_evm_a72_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/j721e_evm_a72_defconfig b/configs/j721e_evm_a72_def

[PATCH 2/3] configs: j7200_evm_a72_defconfig: Enable MUX_MMIO at SPL

MUX_MMIO is required in SPL stage in order to boot hyperflash successfully. Add configs to enable MUX_MMIO in SPL stage. Signed-off-by: Anurag Dutta --- configs/j7200_evm_a72_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/j7200_evm_a72_defconfig b/configs/j7200_evm_a72_def

[PATCH] arm: mach-k3: k3-ddr.h: Include spl.h

Include spl.h to avoid definition errors in custom builds. Fixes: commit bc07851897bd ("board: ti: Pull redundant DDR functions to a common location and Fixup DDR size when ECC is enabled") Signed-off-by: Neha Malcom Francis --- arch/arm/mach-k3/include/mach/k3-ddr.h | 2 ++ 1 file changed, 2 i

[PATCH 40/52] expo: Begin implementation of a text editor

It is useful to be able to edit text, e.g. to allow the user to edit the environment or the command-line arguments for the OS. Add the beginnings of an implementation. Future work is needed to finish this: keypress handling and scrolling. For now it just displays the text. Signed-off-by: Simon Gl

Re: [PATCH 00/52] expo: Various features and improvements

Hi Tom, On Wed, 19 Mar 2025 at 15:57, Tom Rini wrote: > > On Wed, Mar 19, 2025 at 03:54:05PM +0100, Simon Glass wrote: > > > This series collects together some new features for expo to make it more > > useful for boot menus: > > > > - measurement and display of multi-line text objects > > - inter

Re: [PATCH] arm64: Fix page permissions for platforms running at EL2

Hi Ilias, On Wed, 19 Mar 2025 at 16:22, Ilias Apalodimas wrote: > > Hi Simon, > > On Wed, 19 Mar 2025 at 17:04, Simon Glass wrote: > > > > Hi Ilias, > > > > On Wed, 19 Mar 2025 at 08:22, Ilias Apalodimas > > wrote: > > > > > > We currently set both and print both PXN and UXN bits when removing

Re: [PATCH] binman: Fill in most of the imx8mimage and imx8mcst tests

On 3/20/25 4:40 AM, Simon Glass wrote: Hi Marek, On Thu, 20 Mar 2025 at 00:54, Marek Vasut wrote: On 3/12/25 1:41 AM, Fabio Estevam wrote: Hi Marek, On Fri, Mar 7, 2025 at 2:42 AM Marek Vasut wrote: So what should we do about this particular patch ? Should this be applied ? Rebased ? Up

Re: 回复: 回复: 回复: 回复: 回复: [PATCH v4 04/20] firmware: scmi: add pin control protocol support to SCMI agent

On 3/20/25 3:28 AM, Alice Guo (OSS) wrote: Hello Alice, - Basically duplicate the mechanism in 7940a93eb977 ("net: phy: Iterate over both registered PHYs and struct phy_driver linker list"), call it e.g. U_BOOT_SCMI_DRIVER() - Switch SCMI drivers to use U_BOOT_SCMI_DRIVER , have each one list

Re: [PATCH 3/6] test: Add a test for strim()

Hi Tom, On Wed, 19 Mar 2025 at 16:38, Tom Rini wrote: > > On Wed, Mar 19, 2025 at 03:04:16PM +, Simon Glass wrote: > > Hi Tom, > > > > On Wed, 19 Mar 2025 at 15:24, Tom Rini wrote: > > > > > > On Wed, Mar 19, 2025 at 12:59:05PM +0100, Simon Glass wrote: > > > > > > > This function trims whit

Re: [PATCH v5 38/46] boot: Consider non-bootable partitions

Hi Tom, On Wed, 19 Mar 2025 at 16:40, Tom Rini wrote: > > On Wed, Mar 19, 2025 at 03:03:49PM +, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 18 Mar 2025 at 16:53, Tom Rini wrote: > > > > > > On Tue, Mar 18, 2025 at 03:24:02PM +, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Tue

Re: [PATCH 09/17] test/py: Add a test image for Ubuntu

Hi Tom, On Wed, 19 Mar 2025 at 16:35, Tom Rini wrote: > > On Wed, Mar 19, 2025 at 03:04:28PM +, Simon Glass wrote: > > Hi Tom, > > > > On Wed, 19 Mar 2025 at 15:52, Tom Rini wrote: > > > > > > On Wed, Mar 19, 2025 at 03:38:03PM +0100, Simon Glass wrote: > > > > > > > Add an extlinux image th

Re: [PATCH] binman: Fill in most of the imx8mimage and imx8mcst tests

Hi Marek, On Thu, 20 Mar 2025 at 00:54, Marek Vasut wrote: > > On 3/12/25 1:41 AM, Fabio Estevam wrote: > > Hi Marek, > > > > On Fri, Mar 7, 2025 at 2:42 AM Marek Vasut wrote: > > > >> So what should we do about this particular patch ? > >> > >> Should this be applied ? Rebased ? Updated somehow

RE: [resend v2 00/19] Add Cadence NAND Driver support

Sure. Let me ask management if I can lend any board to you to work with. I will let you know if we have the extra board. Dinesh From: Michael Nazzareno Trimarchi Sent: Monday, 17 March 2025 2:11 pm To: Maniyam, Dinesh Cc: u-boot@lists.denx.de; Marek ; Simon ; Tom Rini ; Dario Binacchi ; Johan

[PATCH v1 08/11] usb: gadget: amlogic: implement ADNL protocol

This adds support for ADNL (Amlogic DowNLoad) protocol. This protocol is supported by some Amlogic SoCs (a1, s4, c1, с2, sc2, t7, etc) in BootRom code (e.g. it is already supported in "out of the box" mode). It has similar goals as fastboot - upload and update firmware images on the device. Differe

[PULL] u-boot-sh/next

Renesas RZ/G2L USB support, remaining RAVB ethernet fix and KSZ9031 LED errata fix for next. The following changes since commit 8bc3542384e3a1219e5ffb62b79d16dddc1b1fb9: Merge patch series "pxe: Precursor series for supporting read_all() in extlinux / PXE" (2025-03-18 13:12:51 -0600) are avai

Re: [PATCH 1/4] cpu: imx8_cpu: Print Speed grade if IMX_THERMAL or IMX_TMU

On 3/19/25 8:13 PM, Adam Ford wrote: On Tue, Mar 18, 2025 at 9:13 PM Marek Vasut wrote: On 3/19/25 2:42 AM, Adam Ford wrote: Much of the data that is display by imx8_cpu.c is also displayed from arch/arm/mach-imx/cpu.c, except the speed grade and temperature unless the SoC is an i.MX9. Expand

[PATCH] usb: dwc3: gadget: Fix match_ep callback for NXP UUU tool

The UUU tool excepts the interrupt-in endpoint to be ep1in, otherwise it crashes. This is a result of the previous hard-coded EP setup in drivers/usb/gadget/epautoconf.c which did special-case EP allocation for SPL builds, and which was since converted to this callback, but without the special-case

[PATCH 21/52] expo: Split bootflow_menu_run() into two pieces

Split the starting piece of this function into bootflow_menu_start() and the polling part into bootflow_menu_poll() so that it is possible for the caller to be in control of the event loop. Move the expo_destroy() call into the caller. Signed-off-by: Simon Glass --- boot/bootflow_menu.c | 86 +

[PATCH 1/3] pwm: ti: am33xx: Enable Auxiliary PWM using eCAP

In am33xx SOC[1], enhanced capture (eCAP) supports auxiliary PWM (APWM). This series adds the PWM driver support for the APWM feature for eCAP on AM33xx. eCAP HW also supports the capture mode. Currently, this driver only supports APWM. This is based on the Linux kernel driver -> drivers/pwm/pwm-

[PATCH 3/3] arm: dts: am335x: Add nodes for lcdc, panel and backlight

For AM335x EVM[1], enable nodes required to enable the support for LCD and PWM backlight. This is required for the splash screen support. [1] AM335x EVM - https://www.ti.com/tool/TMDXEVM3358 Signed-off-by: Sukrut Bellary --- arch/arm/dts/am335x-evm.dts | 15 ++- 1 file changed, 14 i

[PATCH v1 04/11] usb: gadget: amlogic: common code for Amlogic flashing commands

Amlogic has Optimus and ADNL protocols to update firmware image. Both are operatable by special commands and such commands use same approaches, so let's implement such code before implementing both protocols. Signed-off-by: Arseniy Krasnov --- cmd/meson/gadget.c | 183 +++

[PATCH v1 01/11] arch: arm: meson: sm: add commands to reboot device in different modes

From: Vladimir Mitrofanov There are several commands to reboot device in specific mode (cold, normal, etc.), these commands helps to enter flashing mode and set boot source device: 1) MESON_SMC_CMD_BL1_FIRST_BOOT_SRC_SET This command tells BL1 that it must load BL2 from USB data path. It is

[PATCH v1 00/11] Amlogic: ADNL and Optimus protocols support

This patchset adds support of two Amlogic firmware burning protocols: ADNL and Optimus. Each protocol is supported on the following SoC: axg, g12a, g12b, sm1 - Optimus. a1, s4, a5, c1, c2, c3, sc2, t3, t7, p1 - ADNL. Both work in fastboot manner, but significant feature is that they are supported

[PATCH 3/3] arm: mach-k3: Make K3_LOAD_SYSFW and SYS_K3_SPL_ATF default enabled

These two symbols are always selected by default for R5 builds. These symbols already depend on R5 builds, so make it default at their definition to remove select/imply at each board target site. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am62ax/Kconfig | 4 arch/arm/mach-k3/am62p

[PATCH 1/3] arm: mach-k3: Remove undefined Kconfig symbols BOARD and SPL_BOARD

These are not defined nor used, they seem to be leftover or a typo, remove them. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am62ax/Kconfig | 2 -- arch/arm/mach-k3/am64x/Kconfig | 2 -- 2 files changed, 4 deletions(-) diff --git a/arch/arm/mach-k3/am62ax/Kconfig b/arch/arm/mach-k3/am62ax

[PATCH v1] board: verdin-am62: remove spl_perform_fixups

From: Stefan Eichenberger spl_perform_fixups is redundant in the current implementation. SPLs call dram_init during spl_enable_cache in arch/arm/mach-k3/common.c. In U-Boot, dram_init and dram_init_banksize are automatically called in init_sequence_f. Therefore, SPLs and U-Boot always determine t

Re: [PATCH 2/3] efi_loader: binary_run: register an initrd

Understood, thanks! v2 sent. Best, Adriano El mié, 19 mar 2025 a las 12:30, Ilias Apalodimas (< ilias.apalodi...@linaro.org>) escribió: > On Wed, 19 Mar 2025 at 15:02, Adriano Córdova wrote: > > > > Hi Ilias, > > > > Ok, I will change that in a v2. > > Ok i'll have a look at that > > > As a que

Re: [PATCH V3 01/10] clk: imx6q: Properly handle imx6qp ECSPI clk_sels

On Wed, Mar 19, 2025 at 1:39 PM Adam Ford wrote: > Sorry about all the noise. > > I think I forgot to type 'git add' before the "git commit --amend" so > the fix didn't get applied, but because the same file was shown in the > commit message, it looked like the fix was in place. I'll have to > c

[PATCH] arm: mach-k3: j721e: Split out J7200 SoC support from J721e

Currently in j721e_init.c we check which firewalls to remove using the board configuration (e.g CONFIG_TARGET_J721E_R5_EVM). We do this as J721e and J7200 have different IP and firewalls but use the same SoC definition (SOC_K3_J721E) even though they are different SoCs. The idea was they would be

Re: [PATCH V3 01/10] clk: imx6q: Properly handle imx6qp ECSPI clk_sels

On Tue, Mar 18, 2025 at 8:42 PM Adam Ford wrote: > + if (of_machine_is_compatible("fsl,imx6qp") Missing closing parenthesis. > - clk_dm(IMX6QDL_CLK_ECSPI_ROOT, > - imx_clk_divider("ecspi_root", "pll3_60m", base + 0x38, 19, 6)); > + if (of_machine_is_compatible("fs

Re: [PATCH V3 01/10] clk: imx6q: Properly handle imx6qp ECSPI clk_sels

On Wed, Mar 19, 2025 at 12:27 PM Fabio Estevam wrote: > > On Wed, Mar 19, 2025 at 1:39 PM Adam Ford wrote: > > > Sorry about all the noise. > > > > I think I forgot to type 'git add' before the "git commit --amend" so > > the fix didn't get applied, but because the same file was shown in the > >

Re: [PATCH 00/24] clk: Add clk_resolve_parent_clk() and fix up iMX clock drivers

On Wed, Mar 19, 2025 at 6:42 AM Fabio Estevam wrote: > > On Wednesday, March 19, 2025 00:23 -03, Marek Vasut wrote: > > > Sigh, get maintainers missed Fabio, sorry, +CCed now. I noticed that Fabio was being left off too when I sent some stuff. adam > > > > Fabio, do you want me to resend this w

Re: [PATCH V3 01/10] clk: imx6q: Properly handle imx6qp ECSPI clk_sels

On Wed, Mar 19, 2025 at 11:15 AM Fabio Estevam wrote: > > On Tue, Mar 18, 2025 at 8:42 PM Adam Ford wrote: > > > + if (of_machine_is_compatible("fsl,imx6qp") > > Missing closing parenthesis. > > > - clk_dm(IMX6QDL_CLK_ECSPI_ROOT, > > - imx_clk_divider("ecspi_root", "pll3_

Re: [PATCH] clk/qcom: sdm845: add missing USB3 clocks

(GCC_CFG_NOC_USB3_SEC_AXI_CLK, 0x05030, 0x0001), GATE_CLK(GCC_QUPV3_WRAP0_S0_CLK,0x5200c, 0x0400), GATE_CLK(GCC_QUPV3_WRAP0_S1_CLK,0x5200c, 0x0800), --- base-commit: 69fb899133b6c374eff11b13482371bec6898a01 change-id: 20250319-sdm845-usb

Re: [PATCH] arm64: versal2: Disable debug console

On 3/13/25 13:28, Michal Simek wrote: Platforms can use uart0, uart1, dcc or even any other console that's why disable debug console. It should be used for debugging purpose only. Signed-off-by: Michal Simek --- configs/amd_versal2_virt_defconfig | 6 -- 1 file changed, 6 deletions(-

[PATCH 39/52] expo: Support object alignment

Add support for left, right and centred alignment for text, in the horizontal dimension. Also support top, bottom and centred in the vertical dimension, for the text object as a whole. Alignment is not yet implemented for images. It has no meaning for menus. A textline object uses a text object i

[PATCH 05/52] video: truetype: Fill in the measured line

Create a measured line for the (single) line of text. Signed-off-by: Simon Glass --- drivers/video/console_truetype.c | 36 +++- test/dm/video.c | 13 +++- 2 files changed, 38 insertions(+), 11 deletions(-) diff --git a/drivers/video/console

Re: [PATCH 09/17] test/py: Add a test image for Ubuntu

Hi Tom, On Wed, 19 Mar 2025 at 15:52, Tom Rini wrote: > > On Wed, Mar 19, 2025 at 03:38:03PM +0100, Simon Glass wrote: > > > Add an extlinux image that contains a few Ubuntu entries. > > > > Increase the number of sandbox-USB-hub ports to permit this. > > > > Signed-off-by: Simon Glass > > I don

Re: [PATCH] log: Add helpers for calling log_msg_ret() et al

Hi Simon On 3/19/25 4:03 PM, Simon Glass wrote: Hi Quentin, On Wed, 19 Mar 2025 at 13:04, Quentin Schulz wrote: Hi Simon, On 3/19/25 12:49 PM, Simon Glass wrote: Logging of function return-values is used very frequently in U-Boot now. Add a few helper macros to make it less verbose to use.

[PATCH] clk/qcom: sdm845: add missing USB3 clocks

, 0x0001), GATE_CLK(GCC_QUPV3_WRAP0_S0_CLK,0x5200c, 0x0400), GATE_CLK(GCC_QUPV3_WRAP0_S1_CLK,0x5200c, 0x0800), --- base-commit: 69fb899133b6c374eff11b13482371bec6898a01 change-id: 20250319-sdm845-usb-clocks-9b794fd89522 Best regards, -- Sam

Re: [PATCH v5 38/46] boot: Consider non-bootable partitions

On Wed, Mar 19, 2025 at 03:03:49PM +, Simon Glass wrote: > Hi Tom, > > On Tue, 18 Mar 2025 at 16:53, Tom Rini wrote: > > > > On Tue, Mar 18, 2025 at 03:24:02PM +, Simon Glass wrote: > > > Hi Tom, > > > > > > On Tue, 18 Mar 2025 at 15:04, Tom Rini wrote: > > > > > > > > On Sat, Mar 15, 20

Re: [PATCH 3/6] test: Add a test for strim()

On Wed, Mar 19, 2025 at 03:04:16PM +, Simon Glass wrote: > Hi Tom, > > On Wed, 19 Mar 2025 at 15:24, Tom Rini wrote: > > > > On Wed, Mar 19, 2025 at 12:59:05PM +0100, Simon Glass wrote: > > > > > This function trims whitespace from the start and end of a string. Add a > > > test for it. > > >

Re: [PATCH 6/6] lib: Provide a signed version of simple_itoa()

On Wed, Mar 19, 2025 at 03:04:00PM +, Simon Glass wrote: > Hi Tom, > > On Wed, 19 Mar 2025 at 15:20, Tom Rini wrote: > > > > On Wed, Mar 19, 2025 at 01:12:30PM +0100, Heinrich Schuchardt wrote: > > > Am 19. März 2025 12:59:08 MEZ schrieb Simon Glass : > > > >In some cases we want to show a si

Re: [PATCH 09/17] test/py: Add a test image for Ubuntu

On Wed, Mar 19, 2025 at 03:04:28PM +, Simon Glass wrote: > Hi Tom, > > On Wed, 19 Mar 2025 at 15:52, Tom Rini wrote: > > > > On Wed, Mar 19, 2025 at 03:38:03PM +0100, Simon Glass wrote: > > > > > Add an extlinux image that contains a few Ubuntu entries. > > > > > > Increase the number of sand

Re: [PATCH] serial: Setup default base and frequency for Versal platforms

On 3/13/25 13:23, Michal Simek wrote: Add useful default debug uart values for all Versal platforms to simplify and speed up debug uart enabling. The similar change has been done for Zynq/ZynqMP by commit ad55d99e3cc3 ("serial: Setup serial base and freq for zynq/zynqmp"). Signed-off-by: Mich

Re: [PATCH v2 1/2] xilinx: Allow alternative boot strategies in zynq-common.h

On 3/12/25 16:36, Mike Looijmans wrote: Allow config headers that include zynq-common.h to provide their own (distro) boot strategies. This is implemented by skipping the section when BOOT_ENV has already been defined. Signed-off-by: Mike Looijmans --- Changes in v2: Avoid #ifdef nesting (

Re: [PATCH] arm64: Fix page permissions for platforms running at EL2

Hi Simon, On Wed, 19 Mar 2025 at 17:04, Simon Glass wrote: > > Hi Ilias, > > On Wed, 19 Mar 2025 at 08:22, Ilias Apalodimas > wrote: > > > > We currently set both and print both PXN and UXN bits when removing > > execution for pages. This happens even in the existing per platform > > definitions

Re: [PATCH 2/3] efi_loader: binary_run: register an initrd

On Wed, 19 Mar 2025 at 15:02, Adriano Córdova wrote: > > Hi Ilias, > > Ok, I will change that in a v2. Ok i'll have a look at that > As a question: in here it is a U-Boot routine the one that is doing the > memcpy of the initrd, the one implemented in the load_file2 protocol, the OS > never kn

[PATCH 22/52] expo: Split bootflow_menu_new() into two pieces

Split the iteration piece of this function into bootflow_menu_add_all() so that it is possible for the caller to be in control of adding items to the menu. Move the expo_destroy() call into the caller. Signed-off-by: Simon Glass --- boot/bootflow_menu.c | 31 +++ in

[PATCH 32/52] expo: Move text-rendering into its own function

The code to render text is quite long, so put it in its own function. Signed-off-by: Simon Glass --- boot/scene.c | 95 +--- 1 file changed, 53 insertions(+), 42 deletions(-) diff --git a/boot/scene.c b/boot/scene.c index bf56f4341aa..1e68c17c386

[PATCH] arm: dts: k3: Remove leftover file after OF_UPSTREAM

The file k3-am62a7.dtsi is part of upstream DT and should have been removed when migrating to OF_UPSTREAM but must have been missed. Do this here. Signed-off-by: Andrew Davis --- arch/arm/dts/k3-am62a7.dtsi | 104 1 file changed, 104 deletions(-) delete mode

[PATCH 04/52] video: Begin support for measuring multiple lines of text

Update the vidconsole API so that measure() can measure multiple lines of text. This will make it easier to implement multi-line fields in expo. Tidy up the function comments while we are here. Signed-off-by: Simon Glass --- boot/scene.c | 2 +- drivers/video/console_true

Re: [PATCH 6/6] lib: Provide a signed version of simple_itoa()

Hi Tom, On Wed, 19 Mar 2025 at 15:20, Tom Rini wrote: > > On Wed, Mar 19, 2025 at 01:12:30PM +0100, Heinrich Schuchardt wrote: > > Am 19. März 2025 12:59:08 MEZ schrieb Simon Glass : > > >In some cases we want to show a signed value to the user without needing > > >to use the full printf() implem

[PATCH 34/52] expo: Allow strings to be editable

In some cases dynamic text is needed, e.g. for a menu countdown. Add a function which handles this, allowing the caller to take control of the text that is shown on each render. Signed-off-by: Simon Glass --- boot/expo.c | 21 + include/expo.h | 17 +

Re: [PATCH] log: Add helpers for calling log_msg_ret() et al

Hi Simon, On 3/19/25 12:49 PM, Simon Glass wrote: Logging of function return-values is used very frequently in U-Boot now. Add a few helper macros to make it less verbose to use. It turns out that the log_ret() variants are not so useful, since it is not obviously where the error is coming from

[PATCH 10/52] test: video: Export the video-checking functions

We want to check the display contents in expo tests, so move the two needed functions to a new header file. Rename them to have a video_ prefix. Signed-off-by: Simon Glass --- include/test/video.h | 45 +++ test/dm/video.c | 179 ++- 2 file

[PATCH 24/52] expo: Rename scene_dim to scene_obj_bbox

At present we assume that each object is a simple box and that it fills the whole box. This is quite limiting for text objects, which we may want to centre within the box. We need a position within the box where drawing starts. Rename the scene_dim struct to indicate that it is a bounding box. S

Re: [PATCH 6/6] lib: Provide a signed version of simple_itoa()

Hi Heinrich, On Wed, 19 Mar 2025 at 13:12, Heinrich Schuchardt wrote: > > Am 19. März 2025 12:59:08 MEZ schrieb Simon Glass : > >In some cases we want to show a signed value to the user without needing > >to use the full printf() implementation. Add a new version of the > >simple_itoa() function

Re: [PATCH v4 10/14] dm: usb: move bus initialization into new static function usb_init_bus()

Hi Jerome, On Wed, 19 Mar 2025 at 11:44, Jerome Forissier wrote: > > Hello Marek, > > On 3/18/25 13:20, Marek Vasut wrote: > > On 3/18/25 11:46 AM, Jerome Forissier wrote: > >> To prepare for the introduction of threads in the USB initialization > >> sequence, move code out of usb_init() into a n

Re: [PATCH] log: Add helpers for calling log_msg_ret() et al

Hi Quentin, On Wed, 19 Mar 2025 at 13:04, Quentin Schulz wrote: > > Hi Simon, > > On 3/19/25 12:49 PM, Simon Glass wrote: > > Logging of function return-values is used very frequently in U-Boot now. > > Add a few helper macros to make it less verbose to use. > > > > It turns out that the log_ret(

Re: [PATCH v5 38/46] boot: Consider non-bootable partitions

Hi Tom, On Tue, 18 Mar 2025 at 16:53, Tom Rini wrote: > > On Tue, Mar 18, 2025 at 03:24:02PM +, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 18 Mar 2025 at 15:04, Tom Rini wrote: > > > > > > On Sat, Mar 15, 2025 at 02:25:58PM +, Simon Glass wrote: > > > > > > > Any 'bootable' flag in a

[PATCH 52/52] expo: Drop the special theme code for bootflow_menu

The expo now has all that is needed to apply a suitable theme, so drop this unnecessary code. Any further tweaks can be added to the generic expo code. Signed-off-by: Simon Glass --- boot/bootflow_menu.c | 43 --- test/boot/bootflow.c | 2 +- 2 files cha

Re: [PATCH 00/52] expo: Various features and improvements

On Wed, Mar 19, 2025 at 03:54:05PM +0100, Simon Glass wrote: > This series collects together some new features for expo to make it more > useful for boot menus: > > - measurement and display of multi-line text objects > - internal alignment for objects (e.g. centred text) > - editable strings in

[PATCH 51/52] expo: Set up menu fully in bootflow_menu_start()

Apply the theme, calculate dimensions, highlight the menu and arrange the scene correctly, so that everything is ready to go when the expo is rendered. Signed-off-by: Simon Glass --- boot/bootflow_menu.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/boo

[PATCH 49/52] expo: Update bootflow_menu_poll() to return a sequence ID

Rather than returning a bootflow, return the index of the bootflow. This will allow callers to do their own translation to bootflows or some other data structure. Also return a special code when the user tries to move the pointer, so that the caller can cancel the boot-menu timeout, if this is in

[PATCH 50/52] expo: Split setting up the menu from adding items

Some callers may wish to add items later as they are discovered. Split the setup code into its own function, to permit this. Signed-off-by: Simon Glass --- boot/bootflow_menu.c | 24 ++-- include/bootflow.h | 15 +++ 2 files changed, 37 insertions(+), 2 deletio

[PATCH 47/52] expo: Provide a way to position things relative to display

It is often necessary to centre objects within the display area. Add a special position value to indicate this. Signed-off-by: Simon Glass --- boot/scene.c | 5 + include/expo.h | 6 ++ 2 files changed, 11 insertions(+) diff --git a/boot/scene.c b/boot/scene.c index 02494fff603..7acd

[PATCH 48/52] expo: Improve the visual appearance of the menu

The menu is currently quite basic. Make use of some recently added features in expo, to: - Show proper prompts - Highlight the current item - Centre text - Use multi-line text instead of two independent lines - Put a box around the items Signed-off-by: Simon Glass --- boot/bootflow_internal.h

Re: [PATCH 3/6] test: Add a test for strim()

On Wed, Mar 19, 2025 at 12:59:05PM +0100, Simon Glass wrote: > This function trims whitespace from the start and end of a string. Add a > test for it. > > Signed-off-by: Simon Glass > --- > > test/lib/string.c | 31 +++ > 1 file changed, 31 insertions(+) This got m

[PATCH 46/52] expo: Drop the render from expo_poll()

Within tests it is useful to be able to control rendering of the expo. Drop the automatic call to expo_render() within expo_poll() and adjust its callers to handle this instead. Signed-off-by: Simon Glass --- boot/cedit.c | 1 + boot/expo.c| 2 -- cmd/bootflow.c | 1 + include/expo.h | 9

[PATCH 44/52] expo: Support highlighting menu items

Expo normally uses a pointer to show the current item. Add support for highlighting as well, since this makes it easier for the user to see the current item. Signed-off-by: Simon Glass --- boot/cedit.c | 1 + boot/scene.c | 31 +-- boot/scene_menu.c | 14 +

[PATCH 42/52] expo: Drop the gap between groups of menu items

The gap is intended to separate options which are on different bootdevs, but most of the time there is only one. So drop this gap. Keep the code around in case it becomes useful to have it in the style, or based on some other mechanism. Signed-off-by: Simon Glass --- boot/bootflow_menu.c | 3 +

[PATCH 38/52] expo: Implement a box

It is useful to be able to draw a box around elements in the menu. Add support for an unfilled box with a selectable thickness. Note that there is no support for selecting the colour for any expo objects yet. Signed-off-by: Simon Glass --- boot/cedit.c | 5 + boot/scene.c

[PATCH 37/52] expo: Support white-on-black in the theme

Allow this setting to be controlled from the theme. Signed-off-by: Simon Glass --- boot/expo.c | 4 1 file changed, 4 insertions(+) diff --git a/boot/expo.c b/boot/expo.c index a0be1404f1c..4e855f60d84 100644 --- a/boot/expo.c +++ b/boot/expo.c @@ -277,6 +277,7 @@ int expo_apply_theme(str

Re: [PATCH 1/5] cmd: fuse: Remove custom string functions

On Wed, Mar 19, 2025 at 02:17:10PM +0530, Harsha Vardhan V M wrote: > Remove custom string functions and replace them with normal string > functions. Remove the custom strtou32 and replace it with > simple_strtoul. > > Signed-off-by: Harsha Vardhan V M Reviewed-by: Tom Rini -- Tom signatur

[PATCH 35/52] expo: Check the screen contents after rendering

Make sure that the screen contents are as expected when a scene has been rendered. Signed-off-by: Simon Glass --- test/boot/expo.c | 4 1 file changed, 4 insertions(+) diff --git a/test/boot/expo.c b/test/boot/expo.c index a50e9f721de..ba60267f00c 100644 --- a/test/boot/expo.c +++ b/test/

[PATCH 01/52] video: Make white-on-black a video-device property

The CONFIG_WHITE_ON_BLACK setting is hard-coded at build-time. It is useful to be able to control this when showing menus. Create a property to hold this information, using the CONFIG as the initial value. Signed-off-by: Simon Glass --- boot/expo.c | 2 +- boot/scene.c

[PATCH 33/52] expo: Tidy up scene_txt_render()

Add an early return if there is no string. Move all declarations to the top of the function. Signed-off-by: Simon Glass --- boot/scene.c | 46 ++ 1 file changed, 22 insertions(+), 24 deletions(-) diff --git a/boot/scene.c b/boot/scene.c index 1e68c17

[PATCH 31/52] expo: Create a struct for generic text attributes

In preparation for adding more text types, refactor the common fields into a new structure. This will allow common code to be used. Signed-off-by: Simon Glass --- boot/cedit.c | 2 +- boot/scene.c | 63 --- boot/scene_menu.c | 12 ++

[PATCH 30/52] expo: Line up all menu objects

At present labels are lined up vertically. Do the same with keys and descriptions, since it looks nicer. Signed-off-by: Simon Glass --- boot/scene_menu.c | 22 ++ test/boot/expo.c | 30 ++ 2 files changed, 44 insertions(+), 8 deletions(-) diff -

[PATCH 28/52] expo: Make bounding-box calculation more flexible

In some cases it is useful to obtain more than just two bounding boxes from a menu, e.g. to line up all descriptions vertically. Use an array to obtain bounding-box information and calculate it separately for each item. Signed-off-by: Simon Glass --- boot/scene.c | 61

[PATCH 29/52] expo: Support setting the size and bounds of an object

Add a function to allow the size of an object to be set independently of its position. Also add a function to permit the object's bounding box to be set independently of its dimensions. Signed-off-by: Simon Glass --- boot/scene.c | 29 + include/expo.h | 24 ++

[PATCH 25/52] expo: Rename x and y in struct scene_obj_bbox

These coordinates are the top left values, so rename them to x0 and y0 in preparation for changing the width and height to x1 and y1 Signed-off-by: Simon Glass --- boot/scene.c | 24 ++-- boot/scene_menu.c | 8 +++ boot/scene_textline.c | 16 ++--- incl

[PATCH 27/52] expo: Separate dimensions from the bounding box

At present each object has a width and height and the bounding box is implicit in that. This is not flexible enough to handle objects which are larger than their contents might need. For example, when centring a text object we might want to have it stretch across the whole width of the display eve

[PATCH 26/52] expo: Use an abuf to hold strings

It is more convenient to put strings in an abuf so they can easily be resized. Adjust the struct accordingly. Signed-off-by: Simon Glass --- boot/expo.c| 4 ++-- include/expo.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/boot/expo.c b/boot/expo.c index ba052df93

[PATCH 23/52] expo: Allow adding a single bootflow to a menu

Refactor bootflow_menu_add_all() to call a new bootflow_menu_add() to add each of its bootflows. Move the last_bootdev value into struct menu_priv to make this work. Signed-off-by: Simon Glass --- boot/bootflow_menu.c | 102 --- include/bootflow.h | 1

[PATCH 20/52] expo: Adjust how menu items are highlighted

At present when the user moves to a new menu item, the menu code handles this immediately. This means it is not possible to use an expo action to effect the same change. Update this so that EXPOACT_POINT_ITEM is handled in cedit_do_action(). Expand the test to cover this. Signed-off-by: Simon Gl

[PATCH 18/52] expo: Test some cedit actions

Refactor the action-processing code into a new cedit_do_action() function so we can call it from a test. Check moving to a new field and opening the menu, to ensure that rendering is correct. Signed-off-by: Simon Glass --- boot/cedit.c | 75 ++-

[PATCH 17/52] expo: Move cedit-state fields into expo

Move the boolean flags into struct expo so that the state can be maintained over function calls. Signed-off-by: Simon Glass --- boot/cedit.c | 17 - include/expo.h | 4 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/boot/cedit.c b/boot/cedit.c index 9bae

[PATCH 15/52] expo: Destroy the cedit expo when done

Once 'cedit run' is completed, destroy the expo so that a fresh one is used for any future editing. Signed-off-by: Simon Glass --- cmd/cedit.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cmd/cedit.c b/cmd/cedit.c index b0eca7b4daf..2e15b063462 100644 --- a/cmd/cedit.c +++ b/cmd/cedit.

[PATCH 16/52] expo: Create a rendering test for cedit

Add a test to check that the cedit renders as expected. Signed-off-by: Simon Glass --- test/boot/cedit.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/test/boot/cedit.c b/test/boot/cedit.c index 4d1b99bc2ea..df191a09f89 100644 --- a/test/boot/cedit.c +++ b/test

[PATCH 12/52] video: Add a function to draw a rectangle

Provide a way to draw an unfilled box of a certain width. This is useful for grouping menu items together. Add a comment showing how to see the copy-framebuffer, for testing. Signed-off-by: Simon Glass --- drivers/video/video-uclass.c | 36 include/video.h

[PATCH 14/52] expo: Add a function to poll for input

Both bootflow_menu and cedit use similar logic to poll an expo. Move this into the expo library so the code can be shared. Update bootflow_menu_run() to return -EPIPE when the user quits without choosing anything, since -EAGAIN is ambiguous and elsewhere means that there is no input yet. Signed-o

[PATCH 08/52] video: Add a way to write a partial string to the console

When writing multiple lines of text we need to be able to control which text goes on each line. Add a new vidconsole_put_stringn() function to help with this. Signed-off-by: Simon Glass --- drivers/video/vidconsole-uclass.c | 13 ++--- include/video_console.h | 17

[PATCH 07/52] video: truetype: Support a limit on the width of a line

Expo needs to be able to word-wrap lines so that they are displayed as the user expects. Add a limit on the width of each line and support this in the measurement algorithm. Add a log category to truetype while we are here. Signed-off-by: Simon Glass --- boot/scene.c | 2

[PATCH 06/52] video: truetype: Support newlines in the measured string

It is useful to be able to embed newline characters in the string and have the text measured into multiple lines. Add support for this. Signed-off-by: Simon Glass --- drivers/video/console_truetype.c | 25 - include/video_console.h | 4 test/dm/video.c

[PATCH 02/52] sandbox: Select white-on-black

Use white on black for the expo menu as it is easier on the eyes. Signed-off-by: Simon Glass --- arch/sandbox/dts/test.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts index caec8c8fd01..2087c91285c 100644 --- a/arch/sandbox/dts/test.

[PATCH 00/52] expo: Various features and improvements

This series collects together some new features for expo to make it more useful for boot menus: - measurement and display of multi-line text objects - internal alignment for objects (e.g. centred text) - editable strings in text fields - new 'box' object to draw a rectangle - highlighting of menu

  1   2   >