Add unit tests for the library functions.
Signed-off-by: Heinrich Schuchardt
Acked-by: Ilias Apalodimas
---
v2:
no change
---
lib/string.c | 2 +-
test/lib/string.c | 40
2 files changed, 41 insertions(+), 1 deletion(-)
diff --git a/lib/st
Using strstr() instead of strnstr() creates a security concern.
Fixes: 1c41a7afaa15 ("net: lwip: build lwIP")
Signed-off-by: Heinrich Schuchardt
Reviewed-by: Jerome Forissier
---
v2:
no change
---
lib/lwip/u-boot/arch/cc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --gi
Implement library function strnstr().
Implement strstr() using strnstr().
Sort the includes.
Signed-off-by: Heinrich Schuchardt
---
v2:
no change
---
include/linux/string.h | 3 +++
lib/string.c | 49 +-
2 files changed, 37 insertions(+)
Using strstr() instead of strnstr() creates a security concern.
* Implement missing library function strnstr() and add unit tests.
* Use it for lwIP.
* Fix function find_option() which is used to find the TFTP blocksize.
v2:
New patch for find_option()
Heinrich Schuchardt (4):
net: lwi
Find_option() is used to retrieve the block size value in an option
acknowledgment in response to a request containing a block size option
according to RFC2348.
The format of an OACK response is described in RFC2347 as
+---+---~~---+---+---~~---+---+---~~---+---+---~~---+---+
| opc | opt1
On Fri, Jan 31, 2025 at 02:00:07PM -0600, Tom Rini wrote:
> Hey,
>
> Can you please confirm that this test currently functions on your
> platforms? And then can we please enable it in
> https://source.denx.de/u-boot/u-boot-test-hooks as both a functional
> example, and testing of the SPI framework
On Fri, Jan 31, 2025 at 04:04:20PM -0600, Tom Rini wrote:
> Given how files are searched and parsed,
> py/travis-ci/u_boot_boardenv_sifive_unleashed_spi-nor_qemu.py was not
> being used due to the dash in the name. Use an underbar for consistency.
>
> Signed-off-by: Tom Rini
> ---
> ..._unleash
On Thu, Jan 30, 2025 at 12:54:52PM -0700, Simon Glass wrote:
> Hi Heinrich,
>
> On Thu, 30 Jan 2025 at 01:32, Heinrich Schuchardt wrote:
> >
> > On 1/30/25 08:08, Heinrich Schuchardt wrote:
> > > Hello Simon,
> > >
> > > when running 'make tests' locally I get:
> > >
> > > test/py/tests/test_dm.p
On Wed, 29 Jan 2025 16:24:32 +0100, Michal Simek wrote:
> Some entries are not using tabs for indentation and also help should use
> two spaces indentation.
>
>
Applied to u-boot/master, thanks!
--
Tom
On Fri, 24 Jan 2025 16:04:28 +0800, Weijie Gao wrote:
> This patch fixed the following coding style suggested by checkpatch.pl:
> 1. Use tab instead of space
> 2. Use BIT() instead of <<
> 3. Use mdelay for long time delay
> 4. Remove useless parenthesises
>
>
> [...]
Applied to u-boot/master,
On Fri, 24 Jan 2025 11:39:02 +0800, Weijie Gao wrote:
> Update mt7981 pinctrl driver based on upstream kernel
>
>
Applied to u-boot/master, thanks!
--
Tom
On Tue, 14 Jan 2025 20:07:29 -0600, Tom Rini wrote:
> As this fragment turns off MMC in both SPL and full U-Boot, we can turn
> the whole symbol off rather than just the MMC driver.
>
>
Applied to u-boot/master, thanks!
--
Tom
On Fri, 24 Jan 2025 03:01:48 +0100, Neil Armstrong wrote:
> The SCSI specification originally required that the second
> Command Data Byte contain the LUN value in its high-order bits,
> but this field has been marked as reserved since the SCSI-3 spec
> from 1996.
>
> Some vendors uses this byte
On Thu, 23 Jan 2025 06:43:49 -0800, Daniel Schultz wrote:
> ft_board_setup inside the board code allows to alter
> device-tree during the boot process.
>
> Introduce a new function for the PHYTEC SOM detection
> to read the product name and part number from the EEPROM
> content and include both i
On Fri, 24 Jan 2025 16:14:30 +0100, Stefan Eichenberger wrote:
> The Toradex configuration block is stored in the first boot partition of
> the eMMC. After reading the configuration block, U-Boot switches back to
> the user partition. Currently, this operation always targets mmc device
> 0, even w
Given how files are searched and parsed, we need to use the
"spi_nor_qemu" variant name not "spi-nor_qemu".
Signed-off-by: Tom Rini
---
.azure-pipelines.yml | 2 +-
.gitlab-ci.yml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/.azure-pipelines.yml b/.azure-pipelines
Given how files are searched and parsed,
py/travis-ci/u_boot_boardenv_sifive_unleashed_spi-nor_qemu.py was not
being used due to the dash in the name. Use an underbar for consistency.
Signed-off-by: Tom Rini
---
..._unleashed_spi-nor_qemu => conf.sifive_unleashed_spi_nor_qemu} | 0
...r_qemu.py
Hey,
Can you please confirm that this test currently functions on your
platforms? And then can we please enable it in
https://source.denx.de/u-boot/u-boot-test-hooks as both a functional
example, and testing of the SPI framework?
I'm asking in part because I've attempted to enable it on two TI K3
On Fri, 31 Jan 2025 11:57:04 +0100, Patrice CHOTARD wrote:
> Please pull the STM32 related patches for u-boot/master, v2025.04 =
> u-boot-stm32-20250131
>
> CI status:
> https://source.denx.de/u-boot/custodians/u-boot-stm/-/pipelines/24410
>
> The following
On Sun, 29 Dec 2024 21:53:26 +0100, Marek Vasut wrote:
> The TI DP83822 does have support for configurable RGMII RX/TX clock
> shift, add support for parsing DT properties which describe the RX/TX
> clock shift configuration and configuration of the matching bits in
> RCSR register.
>
> The shift
On Tue, Jan 28, 2025 at 11:19:15AM +0100, Jerome Forissier wrote:
> Adds the COROUTINES Kconfig symbol which introduces a new internal API
> for coroutines support. As explained in the Kconfig file, this is meant
> to provide some kind of cooperative multi-tasking with the goal to
> improve perform
The patch enables the second USB3.0 Type-A USB port on the NanoPi R4S
board, which prevents a crash when initializing the usb system in U-Boot
and allows both Type-A USB ports to be used for booting.
=> usb start
starting USB...
Bus usb@fe38: USB EHCI 1.00
Bus usb@fe3c: "Synchronous Abort"
On Fri, Jan 31, 2025 at 03:41:37PM +0100, Patrice CHOTARD wrote:
>
>
> On 1/29/25 23:01, Tom Rini wrote:
> > On Tue, Jan 28, 2025 at 09:04:26AM -0600, Tom Rini wrote:
> >> On Tue, Jan 28, 2025 at 08:04:56AM -0600, Tom Rini wrote:
> >>> On Tue, Jan 28, 2025 at 08:47:37AM +0100, Patrice CHOTARD wro
On 1/29/25 23:01, Tom Rini wrote:
> On Tue, Jan 28, 2025 at 09:04:26AM -0600, Tom Rini wrote:
>> On Tue, Jan 28, 2025 at 08:04:56AM -0600, Tom Rini wrote:
>>> On Tue, Jan 28, 2025 at 08:47:37AM +0100, Patrice CHOTARD wrote:
On 1/15/25 15:44, Tom Rini wrote:
> On Wed, Jan 15, 2
Hello (again) Neil, Fabio,
On Friday, 31 January 2025 at 15:40, Sam Day wrote:
>
> Hi Neil, Fabio,
>
> On Friday, 31 January 2025 at 12:04, Sam Day m...@samcday.com wrote:
>
> > I'd love to take credit, but actually it was Stephan Gerhold who spotted
> > this when we were debugging the issue
Hi Ilias,
On Fri, 31 Jan 2025 at 08:52, Ilias Apalodimas
wrote:
>
> Hi Raymond, Tom
>
> This config seems reasonable to me and we can now build a combination
> of SPL + older crypto + mbedTLS for u-boot proper which was always the
> goal.
>
> I do still think the naming is a bit confusing.
>
> On
Hi Neil, Fabio,
On Friday, 31 January 2025 at 12:04, Sam Day wrote:
> I'd love to take credit, but actually it was Stephan Gerhold who spotted
> this when we were debugging the issue together :)
>
I got myself very confused here :) Stephan Gerhold helped me identify the
issue fixed in patch #1
Hi Ilias,
On Fri, 31 Jan 2025 at 08:40, Ilias Apalodimas
wrote:
>
> Hi Raymond
>
> On Mon, 27 Jan 2025 at 17:17, Raymond Mao wrote:
> >
> > Currently building with WGET_HTTPS,NET_LWIP and MBEDTLS_LIB failed
> > due to a few incorrect kconfig dependencies.
> > Fix these and clarify what is the pu
>>
>> +config PINCTRL_QCOM_SC7280
>> + bool "Qualcomm SC7280/QCM6490 GCC"
>> + select PINCTRL_QCOM
>
>Hi!
>
>And again, no, this is not GCC, this block is called TLMM.
>GCC is for clock controller.
Hi!
This is correct.
I tested the pinctrl driver, it needed some changes but now I have S
On Thu, 2025-01-30 at 11:04 -0600, Tom Rini wrote:
> On Thu, Jan 30, 2025 at 02:55:53PM +0100, Ferenc Fejes wrote:
>
> > Hi,
> >
> > Is it possible to use the serial port for u-boot networking? For example,
> > given
> > a restricted environment where the FIT image is available with ethernet
> >
Dynamic memory, referenced by 'line', is allocated at imximage.c:761
by calling function 'getline' and lost at imximage.c:793.
Signed-off-by: Maks Mishin
---
tools/imximage.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/imximage.c b/tools/imximage.c
index 467d9f27d2..55231caf8f 100
Add CONFIG_BOOTCOUNT_ALTBOOTCMD so the developer is able to add
custom altbootcmd via Kconfig when they enable BOOTCOUNT.
---
drivers/bootcount/Kconfig | 3 +++
include/env_default.h | 3 +++
2 files changed, 6 insertions(+)
diff --git a/drivers/bootcount/Kconfig b/drivers/bootcount/Kconfig
i
Hi Jonas,
On Thu, 30 Jan 2025 at 23:20, Jonas Karlman wrote:
>
> Hi Quentin,
>
> On 2025-01-30 15:16, Quentin Schulz wrote:
> > Hi Jonas,
> >
> > On 1/29/25 3:20 PM, Jonas Karlman wrote:
> >> Hi Quentin,
> >>
> >> On 2025-01-29 13:42, Quentin Schulz wrote:
> >>> While testing some WIP work done b
Hi Raymond, Tom
This config seems reasonable to me and we can now build a combination
of SPL + older crypto + mbedTLS for u-boot proper which was always the
goal.
I do still think the naming is a bit confusing.
On Mon, 27 Jan 2025 at 17:17, Raymond Mao wrote:
>
> Refactor the entire kconfig pag
On Mon, 27 Jan 2025 at 17:17, Raymond Mao wrote:
>
> U-Boot requires to access x509_internal.h, mbedtls_sha256_context and
> mbedtls_sha1_context in the porting layer, and this requires to
> enable MBEDTLS_ALLOW_PRIVATE_ACCESS.
>
> Enable it to mscode and pkcs7_parser to fix a mbedtls internal bui
Hi Raymond
On Mon, 27 Jan 2025 at 17:17, Raymond Mao wrote:
>
> Currently building with WGET_HTTPS,NET_LWIP and MBEDTLS_LIB failed
> due to a few incorrect kconfig dependencies.
> Fix these and clarify what is the purpose of MBEDTLS_LIB_CRYPTO_ALT.
>
> Signed-off-by: Raymond Mao
> ---
> cmd/Kco
Hello Fabio,
On Friday, 31 January 2025 at 12:29, Fabio Estevam wrote:
>
> On Fri, Jan 31, 2025 at 8:10 AM Sam Day m...@samcday.com wrote:
>
> > I'd love to take credit, but actually it was Stephan Gerhold who spotted
> > this when we were debugging the issue together :)
>
>
> Maybe you could
On Fri, Jan 31, 2025 at 8:10 AM Sam Day wrote:
> I'd love to take credit, but actually it was Stephan Gerhold who spotted
> this when we were debugging the issue together :)
Maybe you could add a Suggested-by tag.
Hi Neil,
On Friday, 31 January 2025 at 10:42, Neil Armstrong
wrote:
>
>
> On 27/01/2025 08:49, Sam Day wrote:
>
> > msm_rng_enable is supposed to skip writing to LFSR_CFG + CONFIG
> > registers in the PRNG_ block if PRNG_CONFIG_HW_ENABLE is already set.
> > The logic to test for this was inv
Hi Tom
Please pull the STM32 related patches for u-boot/master, v2025.04 =
u-boot-stm32-20250131
CI status: https://source.denx.de/u-boot/custodians/u-boot-stm/-/pipelines/24410
The following changes since commit a517796cfa5d8f4ca2f0c11c78c24a08a102c047:
Prepare v2025.04-rc1 (2025-01-27 16
From: Quentin Schulz
There's no need to modify private data from the controller, so let's
make that struct const.
Signed-off-by: Quentin Schulz
---
drivers/pinctrl/rockchip/pinctrl-rv1108.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/rockchip/pinctrl-rv1
From: Quentin Schulz
There's no need to modify private data from the controller, so let's
make that struct const.
Signed-off-by: Quentin Schulz
---
drivers/pinctrl/rockchip/pinctrl-rk3399.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/rockchip/pinctrl-rk3
From: Quentin Schulz
There's no need to modify private data from the controller, so let's
make that struct const.
Signed-off-by: Quentin Schulz
---
drivers/pinctrl/rockchip/pinctrl-rk3368.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/rockchip/pinctrl-rk3
From: Quentin Schulz
There's no need to modify private data from the controller, so let's
make that struct const.
Signed-off-by: Quentin Schulz
---
drivers/pinctrl/rockchip/pinctrl-rk3288.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/rockchip/pinctrl-rk3
From: Quentin Schulz
There's no need to modify private data from the controller, so let's
make that struct const.
Signed-off-by: Quentin Schulz
---
drivers/pinctrl/rockchip/pinctrl-rk3328.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/rockchip/pinctrl-rk3
From: Quentin Schulz
There's no need to modify private data from the controller, so let's
make that struct const.
Signed-off-by: Quentin Schulz
---
drivers/pinctrl/rockchip/pinctrl-rk3308.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/rockchip/pinctrl-rk3
From: Quentin Schulz
There's no need to modify private data from the controller, so let's
make that struct const.
Signed-off-by: Quentin Schulz
---
drivers/pinctrl/rockchip/pinctrl-rk3066.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/rockchip/pinctrl-rk3
From: Quentin Schulz
There's no need to modify private data from the controller, so let's
make that struct const.
Signed-off-by: Quentin Schulz
---
drivers/pinctrl/rockchip/pinctrl-rk322x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/rockchip/pinctrl-rk3
From: Quentin Schulz
There's no need to modify private data from the controller, so let's
make that struct const.
Signed-off-by: Quentin Schulz
---
drivers/pinctrl/rockchip/pinctrl-rk3188.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/rockchip/pinctrl-rk3
From: Quentin Schulz
There's no need to modify private data from the controller, so let's
make that struct const.
Signed-off-by: Quentin Schulz
---
drivers/pinctrl/rockchip/pinctrl-px30.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/rockchip/pinctrl-px30.
From: Quentin Schulz
There's no need to modify private data from the controller, so let's
make that struct const.
Signed-off-by: Quentin Schulz
---
drivers/pinctrl/rockchip/pinctrl-rk3128.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/rockchip/pinctrl-rk3
From: Quentin Schulz
There's no need to modify private data from the controller, so let's
make that struct const.
Signed-off-by: Quentin Schulz
---
drivers/pinctrl/rockchip/pinctrl-rk3036.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/rockchip/pinctrl-rk3
While testing some WIP work done by Ilias Apalodimas on guaranteeing
read-only memory areas truly are handled as read-only[1], my RK3588
Tiger couldn't reach U-Boot CLI anymore because of the pinctrl driver
modifying a const struct rockchip_pin_ctrl, triggering a CPU abort.
Instead of going the la
From: Quentin Schulz
The logic in the core reads the nr_pins of the controller and uses it as
the index of the first pin in the bank (pin_base) it currently parses.
It then increments the number of pins in the controller before going to
the next bank.
This works "fine" for controllers where nr_p
On 1/30/25 05:51, Manikandan Muralidharan wrote:
> In Linux DT,the pinctrl node acts as parent nodes with all other
> gpio banks as child nodes and a single driver in Linux handles both
> pinctrl settings and gpio requests.Current U-Boot DT maintains both
> pinctrl and gpio nodes as separate nod
On 27/01/2025 08:48, Sam Day wrote:
This clock needs to be enabled for the msm-rng driver to work on
MSM8916, otherwise accessing the PRNG register block causes a data
abort.
Signed-off-by: Sam Day
---
drivers/clk/qcom/clock-apq8016.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-
On 27/01/2025 08:49, Sam Day wrote:
msm_rng_enable is supposed to skip writing to LFSR_CFG + CONFIG
registers in the PRNG_ block if PRNG_CONFIG_HW_ENABLE is already set.
The logic to test for this was inverted.
Without this fix, the driver was causing SError aborts on my MSM8916
device. Stephan
Hi,
On 1/30/25 02:23, Jerome Forissier wrote:
[snip]
Please check [1] and let me know if it works for you.
[1] https://lists.denx.de/pipermail/u-boot/2025-January/578982.html
Thanks,
Confirmed. I tested each of two network ports on the same Pine64 Star64
board and it is now working as ex
On 1/30/25 11:51, Patrick DELAUNAY wrote:
> Hi,
>
> On 1/9/25 11:21, Patrice Chotard wrote:
>> mmu_set_region_dcache_behaviour() parameters must be aligned
>> which is not always the case.
>> For example for STM32MP2, we stayed stuck inside
>> mmu_set_region_dcache_behaviour() in an infinite lo
On 1/30/25 11:52, Patrick DELAUNAY wrote:
> Hi,
>
> On 1/9/25 11:21, Patrice Chotard wrote:
>> Spurious characters are displayed on U-Boot console.
>> Usart2 clock is ck_flexgen_08 and its frequency is set
>> to an incorrect value.
>>
>> Update ck_flexgen_08 frequency from 100MHz to 64MHz.
>>
>
On 1/8/25 19:53, Patrick DELAUNAY wrote:
> Hi,
>
> On 12/11/24 09:09, Patrice Chotard wrote:
>> Updating the framebuffer takes quite a long time on this slow patform,
>> set CYCLIC_MAX_CPU_TIME_US to 5 for stm32f469-disco to avoid
>> following cyclic warning:
>>
>> "cyclic function video_in
On 1/8/25 19:53, Patrick DELAUNAY wrote:
> Hi,
>
> On 12/11/24 09:09, Patrice Chotard wrote:
>> Updating the framebuffer takes quite a long time on this slow patform,
>> set CYCLIC_MAX_CPU_TIME_US to 8000 for stm32f769-disco to avoid
>> following cyclic warning:
>>
>> "cyclic function video_ini
On 12/5/24 13:48, Patrick DELAUNAY wrote:
> Hi,
>
> On 11/29/24 13:48, Patrice Chotard wrote:
>> ENV_IS_IN_EXT4 flag is no more used in any STM32 defconfig,
>> remove the related code.
>>
>> Signed-off-by: Patrice Chotard
>> ---
>>
>> board/st/stm32mp1/stm32mp1.c | 2 --
>> 1 file changed,
On 1/8/25 19:51, Patrick DELAUNAY wrote:
> Hi,
>
> On 11/29/24 13:33, Patrice Chotard wrote:
>> From: Patrick Delaunay
>>
>> The clock ck_usbo_48m is a clock source for RCC, so the ck_usbo_48m
>> clock provided by usbphyc need to be probed when RCC clock driver is
>> required, in pre-reloc sta
On 1/8/25 19:50, Patrick DELAUNAY wrote:
> Hi,
>
> On 11/29/24 13:27, Patrice Chotard wrote:
>> In arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog.c, in init_device(),
>> in case of RAW_IMAGE, part->size = block_dev->lba * block_dev->blksz.
>>
>> _ part->size is declared as u64.
>> _ block_
On 1/8/25 19:49, Patrick DELAUNAY wrote:
> Hi,
>
> On 11/29/24 13:27, Patrice Chotard wrote:
>> In arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog.c, in init_device(),
>> in case of RAW_IMAGE, part->size = block_dev->lba * block_dev->blksz.
>>
>> _ part->size is declared as u64.
>> _ block_
On 1/8/25 19:49, Patrick DELAUNAY wrote:
> Hi
>
> On 11/29/24 13:27, Patrice Chotard wrote:
>> Set multiplier to 'G' if part->size if above SZ_1G.
>>
>> Signed-off-by: Patrice Chotard
>> ---
>>
>> arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog.c | 5 -
>> 1 file changed, 4 insertions(+),
On 1/8/25 19:49, Patrick DELAUNAY wrote:
> Hi,
>
> On 11/29/24 13:27, Patrice Chotard wrote:
>> In arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog.c, in init_device(),
>> in case of RAW_IMAGE, part->size = block_dev->lba * block_dev->blksz.
>>
>> _ part->size is declared as u64.
>> _ block_
On 1/8/25 19:48, Patrick DELAUNAY wrote:
> Hi,
>
> On 11/29/24 13:27, Patrice Chotard wrote:
>> If CONFIG_SYS_64BIT_LBA is enable, following compilation warning is
>> triggered:
>>
>> CC drivers/fastboot/fb_mmc.o
>> ../drivers/fastboot/fb_mmc.c: In function 'fb_mmc_erase_mmc_hwpart':
>>
On 1/8/25 19:48, Patrick DELAUNAY wrote:
> Hi,
>
> On 11/29/24 13:27, Patrice Chotard wrote:
>> If CONFIG_SYS_64BIT_LBA flag is enable, following warning is triggered:
>>
>> ../arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog.c: In function
>> 'init_device':
>> ../arch/arm/mach-stm32mp/cmd_stm32p
70 matches
Mail list logo
