On Thu, Jan 30, 2025 at 12:54:52PM -0700, Simon Glass wrote: > Hi Heinrich, > > On Thu, 30 Jan 2025 at 01:32, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: > > > > On 1/30/25 08:08, Heinrich Schuchardt wrote: > > > Hello Simon, > > > > > > when running 'make tests' locally I get: > > > > > > test/py/tests/test_dm.py . > > > > > > ============================================================================== > > > short test summary info > > > =============================================================================== > > > SKIPPED [2] test/py/conftest.py:625: .config feature "sandbox" enabled > > > SKIPPED [1] test/py/tests/test_bootstage.py:39: No bootstage environment > > > file is defined > > > SKIPPED [1] test/py/tests/test_cat/test_cat.py:8: Setup failed > > > SKIPPED [1] test/py/tests/test_dfu.py:114: got empty parameter set > > > ['env__usb_dev_port'], function test_dfu at /test/py/tests/test_dfu.py:113 > > > !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! _pytest.outcomes.Exit: Lab failure: > > > Timeout executing 'dm drivers > > > ': Marking connection bad - no other tests will run > > > !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! > > > > > > > > > Shouldn't the required boardenv_* files be generated by running 'make > > > tests'? > > > > > > Best regards > > > > > > Heinrich > > > > When installing all packages mentioned in tools/docker/Dockerfile the DM > > tests are executed. > > What about test/py/requirements.txt ? > > Really we should document the packages needed. The doc/build/gcc.rst > file is supposed to do that, where it says 'Depending on the build > targets further packages maybe needed'. So perhaps we could add things > there, and even split out the things needed for tests?
Having been kicking things around a little locally, we really need to add tools/buildman/requirements.txt and update tools/buildman/requirements.txt and test/py/requirements.txt, and then tell people they're expected to use a virtual environment like normal best practices. Otherwise things just start failing to build left and right due to missing this-or-that python module. I started that a little bit today even before getting side-tracked on the SPI pytest. -- Tom
signature.asc
Description: PGP signature
