Re: [PATCH v4 7/9] dts: starfive: Add JH7110 Cadence USB dts node

2024-08-29 Thread Minda Chen
> > On Wed, Aug 28, 2024 at 9:47 PM Sumit Garg wrote: > > > > Hi, > > > > On Thu, 29 Aug 2024 at 07:01, Minda Chen > wrote: > > > > > > Add Jh7110 Cadence USB dts node, Visionfive2 default setting is USB > > > 2.0 device. > > > > > > Signed-off-by: Minda Chen > > > --- > > > .../dts/jh7110-st

[PATCH] mtd: spi-nor-ids: Add support for S28HS256T

2024-08-29 Thread tkuw584924
From: Takahiro Kuwano Infineon S28HS256T is 256Mb Octal SPI device which has same functionalities with 512Mb and 1Gb parts. Signed-off-by: Takahiro Kuwano --- Datasheet can be found: https://www.infineon.com/dgdl/Infineon-S28HS256T_S28HL256T_256Mb_SEMPER_Flash_Octal_interface_1_8V_3-DataSheet-v

Re: [PATCH 00/19] vbe: Series part E

2024-08-29 Thread Simon Glass
Hi Tom, On Thu, 29 Aug 2024 at 12:33, Tom Rini wrote: > > On Thu, Aug 29, 2024 at 08:57:43AM -0600, Simon Glass wrote: > > > This includes various patches towards implementing the VBE abrec > > bootmeth in U-Boot. It mostly focuses on SPL tweaks and adjusting what > > fatures are available in VPL

Re: [PATCH v4 8/9] spl: starfive: star64: Setup USB fdt fixup function

2024-08-29 Thread E Shattow
Hi Minda, On Wed, Aug 28, 2024 at 6:31 PM Minda Chen wrote: > > Setup star64 USB fdt fixup function. Set dr_mode to host, > and add vbus pin (GPIO25), and set USB 3.0 mode. > the functions can be used by other 7110 board like Milk-V > board. > > Signed-off-by: Minda Chen > --- > board/starfive/

Re: [PATCH 1/1] riscv: define find_{first, next}_zero_bit in asm/bitops.h

2024-08-29 Thread E Shattow
Series https://patchwork.ozlabs.org/project/uboot/list/?series=421417 Add Starfive JH7110 Cadence USB driver fails to compile anymore without this patch. With that, Tested-by: E Shattow wrote: > > 27.07.2024 13:35, E Shattow wrote: > > Is this a problem in Linux upstream? or specific to U-Boot,

Re: [u-boot-test-hooks][PATCH 1/2] bin/writer.rpi_mount: Use kernel= and simplify logic

2024-08-29 Thread Tom Rini
On Thu, Aug 29, 2024 at 07:06:06PM -0600, Simon Glass wrote: > On Thu, 29 Aug 2024 at 12:56, Tom Rini wrote: > > > > Rather than guess what we need to name our u-boot.bin file as for it to > > boot make use of the kernel= option to always call it u-boot.bin and > > then on 64bit platforms (and sin

Re: [PATCH 00/18] vbe: Series part D

2024-08-29 Thread Tom Rini
On Thu, Aug 29, 2024 at 07:06:32PM -0600, Simon Glass wrote: > Hi Tom, > > On Thu, 29 Aug 2024 at 18:49, Tom Rini wrote: > > > > On Wed, Aug 28, 2024 at 04:16:55PM -0600, Simon Glass wrote: > > > Hi Peter, > > > > > > On Wed, 28 Aug 2024 at 03:59, Peter Robinson wrote: > > > > > > > > Hi Simon,

Re: [PATCH v4 4/9] usb: cdns: starfive: Add cdns USB driver

2024-08-29 Thread Marek Vasut
On 8/29/24 3:30 AM, Minda Chen wrote: Add cdns USB3 wrapper driver. Signed-off-by: Minda Chen --- drivers/usb/cdns3/Kconfig | 7 ++ drivers/usb/cdns3/Makefile | 2 + drivers/usb/cdns3/cdns3-starfive.c | 191 + 3 files changed, 200 insertions

Re: [PATCH v4 3/9] phy: starfive: Add Starfive JH7110 PCIe 2.0 PHY driver

2024-08-29 Thread Marek Vasut
On 8/29/24 3:30 AM, Minda Chen wrote: [...] +static int phy_pcie_mode_set(struct jh7110_pcie_phy *data, bool usb_mode) +{ + unsigned int phy_mode, width, usb3_phy, ss_mode, split; + + /* default is PCIe mode */ + if (!data->stg_syscon || !data->sys_syscon) { + if

Re: [PATCH v4 2/9] phy: starfive: Add Starfive JH7110 USB 2.0 PHY driver

2024-08-29 Thread Marek Vasut
On 8/29/24 3:30 AM, Minda Chen wrote: [...] +menu "Starfive PHY driver" + +config PHY_STARFIVE_JH7110_USB2 + bool "Starfive JH7110 USB 2.0 PHY driver" + select PHY Can this PHY_STARFIVE_JH7110_USB2 symbol be selected if CONFIG_PHY is not set ? I think it cannot, so this 'select P

Re: [PATCH v4 1/9] usb: cdns3: Set USB PHY mode in cdns3_drd_update_mode()

2024-08-29 Thread Marek Vasut
On 8/29/24 3:30 AM, Minda Chen wrote: USB PHY maybe need to set PHY mode in different USB dr mode. So translate USB PHY mode to generic PHY mode and call generic_phy_set_mode(). Signed-off-by: Minda Chen Reviewed-by: Marek Vasut

Re: [u-boot-test-hooks PATCH v4 3/3] Provide some basic scripts for Labgrid integration

2024-08-29 Thread Simon Glass
Hi Tom, On Thu, 29 Aug 2024 at 09:20, Tom Rini wrote: > > On Thu, Aug 29, 2024 at 09:02:38AM -0600, Simon Glass wrote: > > Hi Neil, > > > > On Thu, 29 Aug 2024 at 08:44, wrote: > > > > > > On 29/08/2024 14:17, Simon Glass wrote: > > > > Hi Peter, > > > > > > > > On Thu, 29 Aug 2024 at 04:43, Pet

Re: My labgrid setup

2024-08-29 Thread Simon Glass
Hi Tom, On Thu, 29 Aug 2024 at 13:30, Tom Rini wrote: > > Hey all, > > So now that I've posted my u-boot-test-hooks for labgrid: > https://patchwork.ozlabs.org/project/uboot/patch/20240829185620.3179866-1-tr...@konsulko.com/ > the next relevant parts would be how I use that. There's three scripts

Re: [PATCH v5 03/20] test: Pass stderr to stdout

2024-08-29 Thread Simon Glass
Hi Tom, On Thu, 29 Aug 2024 at 10:48, Tom Rini wrote: > > On Thu, Aug 29, 2024 at 09:01:11AM -0600, Simon Glass wrote: > > Hi Neil, > > > > On Thu, 29 Aug 2024 at 08:22, wrote: > > > > > > On 29/08/2024 00:08, Simon Glass wrote: > > > > Some tests may output things to stderr. Ensure that this ou

Re: [PATCH 00/18] vbe: Series part D

2024-08-29 Thread Simon Glass
Hi Tom, On Thu, 29 Aug 2024 at 18:49, Tom Rini wrote: > > On Wed, Aug 28, 2024 at 04:16:55PM -0600, Simon Glass wrote: > > Hi Peter, > > > > On Wed, 28 Aug 2024 at 03:59, Peter Robinson wrote: > > > > > > Hi Simon, > > > > > > > This includes various patches towards implementing the VBE abrec >

Re: [u-boot-test-hooks][PATCH] labgrid: Add wrapper scripts around using labgrid-client for device control

2024-08-29 Thread Simon Glass
On Thu, 29 Aug 2024 at 12:56, Tom Rini wrote: > > From: Edi Feschiyan > > General usage for these hooks is documented in the README.md file. In > terms of implementation, To start with, we add a common file to ensure > that all required environment variables are set. Next, we add a console > scri

Re: [u-boot-test-hooks][PATCH 2/2] bin/flashair.rpi: Use kernel= and simplify logic

2024-08-29 Thread Simon Glass
On Thu, 29 Aug 2024 at 12:56, Tom Rini wrote: > > Rather than guess what we need to name our u-boot.bin file as for it to > boot make use of the kernel= option to always call it u-boot.bin and > then on 64bit platforms (and since future platforms use rpi_arm64 this > list should not grow) also pas

Re: [u-boot-test-hooks][PATCH 1/2] bin/writer.rpi_mount: Use kernel= and simplify logic

2024-08-29 Thread Simon Glass
On Thu, 29 Aug 2024 at 12:56, Tom Rini wrote: > > Rather than guess what we need to name our u-boot.bin file as for it to > boot make use of the kernel= option to always call it u-boot.bin and > then on 64bit platforms (and since future platforms use rpi_arm64 this > list should not grow) also pas

Re: xPL terminology

2024-08-29 Thread Simon Glass
Hi Tom, On Tue, 27 Aug 2024 at 15:43, Tom Rini wrote: > > On Tue, Aug 27, 2024 at 01:24:59PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 27 Aug 2024 at 10:50, Tom Rini wrote: > > > > > > On Sun, Aug 25, 2024 at 07:07:23AM -0600, Simon Glass wrote: > > > > > > > Hi, > > > > > > > > We h

Re: [PATCH v5 17/20] test: Try to shut down the lab console gracefully

2024-08-29 Thread Simon Glass
Hi Tom, On Thu, 29 Aug 2024 at 10:59, Tom Rini wrote: > > On Thu, Aug 29, 2024 at 09:01:17AM -0600, Simon Glass wrote: > > Hi Neil, > > > > On Thu, 29 Aug 2024 at 08:26, wrote: > > > > > > On 29/08/2024 00:08, Simon Glass wrote: > > > > Send the Labgrid quit characters to ask it to exit graceful

Re: [PATCH v9 35/37] [TESTING] Kconfig: enable NET_LWIP by default except for SANDBOX

2024-08-29 Thread Simon Glass
Hi Jerome, On Thu, 29 Aug 2024 at 10:21, Jerome Forissier wrote: > > > > On 8/29/24 16:05, Simon Glass wrote: > > Hi Jerome, > > > > On Fri, 23 Aug 2024 at 07:50, Jerome Forissier > > wrote: > >> > >> Enable NET_LWIP by default for testing purposes. SANDBOX doesn't support > >> NET_LWIP so defau

Re: [PATCH 05/13] net: fm: call dtsec_init_phy() only when it is defined

2024-08-29 Thread Simon Glass
Hi Jerome, On Thu, 29 Aug 2024 at 10:40, Jerome Forissier wrote: > > > > On 8/29/24 16:04, Simon Glass wrote: > > Hi Jerome, > > > > On Wed, 28 Aug 2024 at 06:11, Jerome Forissier > > wrote: > >> > >> dtsec_init_phy() is defined only with MII so add the proper conditional > >> in the caller code

Re: [PATCH 2/2] cmd: booti: adjust the print format

2024-08-29 Thread Simon Glass
Hi Tom, On Thu, 29 Aug 2024 at 09:03, Tom Rini wrote: > > On Thu, Aug 29, 2024 at 09:00:30AM -0600, Simon Glass wrote: > > Hi Dario, > > > > On Thu, 29 Aug 2024 at 08:25, Dario Binacchi > > wrote: > > > > > > Hi Simon, > > > > > > On Thu, Aug 29, 2024 at 4:05 PM Simon Glass wrote: > > > > > > >

Re: [PATCH 00/18] vbe: Series part D

2024-08-29 Thread Tom Rini
On Wed, Aug 28, 2024 at 04:16:55PM -0600, Simon Glass wrote: > Hi Peter, > > On Wed, 28 Aug 2024 at 03:59, Peter Robinson wrote: > > > > Hi Simon, > > > > > This includes various patches towards implementing the VBE abrec > > > > What is abrec? > > It's a VBE method which supports A, B and recov

[PATCH] u-boot: Ensure we use BFD as linker even if using GCC for it

2024-08-29 Thread Otavio Salvador
If we are using 'ld-is-gold' as DISTRO_FEATURE, the U-Boot Makefile has mechanisms to ensure that we use BFD as linker. However, this does not work for the GCC when it is used as linking tool. To support that, we added explicit BFD use whenever we have the DISTRO_FEATURE feature enabled. Signed-o

Re: [PATCH 00/19] vbe: Series part E

2024-08-29 Thread Tom Rini
On Thu, Aug 29, 2024 at 08:57:43AM -0600, Simon Glass wrote: > This includes various patches towards implementing the VBE abrec > bootmeth in U-Boot. It mostly focuses on SPL tweaks and adjusting what > fatures are available in VPL. A lot of this series makes me really want to stop and rework how

Re: [PATCH v2] mtd: spi-nor: Disable chip erase for S28HS02GT flash

2024-08-29 Thread Takahiro Kuwano
Hello, On 7/30/2024 9:05 PM, Prasad Kummari wrote: > From: Tejas Bhumkar > > Since the opcode SPINOR_OP_CHIP_ERASE (0xc7) is not supported > for the S28HS02GT flash, the NO_CHIP_ERASE flag has been added > to enable sector erase functionality instead. > > Signed-off-by: Tejas Bhumkar > Signed-

[PATCH] mtd: spi-nor-ids: Add NO_CHIP_ERASE flag to Infineon 2Gb parts

2024-08-29 Thread tkuw584924
From: Takahiro Kuwano S25HS02GT, S25HL02GT, and S28HS02GT are dual-die package parts and do not support chip erase. Signed-off-by: Takahiro Kuwano --- drivers/mtd/spi/spi-nor-ids.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers

My labgrid setup

2024-08-29 Thread Tom Rini
Hey all, So now that I've posted my u-boot-test-hooks for labgrid: https://patchwork.ozlabs.org/project/uboot/patch/20240829185620.3179866-1-tr...@konsulko.com/ the next relevant parts would be how I use that. There's three scripts, first of which is "uboot-hw-testcycle.sh" : -

[u-boot-test-hooks][PATCH] labgrid: Add wrapper scripts around using labgrid-client for device control

2024-08-29 Thread Tom Rini
From: Edi Feschiyan General usage for these hooks is documented in the README.md file. In terms of implementation, To start with, we add a common file to ensure that all required environment variables are set. Next, we add a console script which calls labgrid-console. We also add a reset script t

[u-boot-test-hooks][PATCH 2/2] bin/flashair.rpi: Use kernel= and simplify logic

2024-08-29 Thread Tom Rini
Rather than guess what we need to name our u-boot.bin file as for it to boot make use of the kernel= option to always call it u-boot.bin and then on 64bit platforms (and since future platforms use rpi_arm64 this list should not grow) also pass in arm_64bit=1. Signed-off-by: Tom Rini --- bin/flas

[u-boot-test-hooks][PATCH 1/2] bin/writer.rpi_mount: Use kernel= and simplify logic

2024-08-29 Thread Tom Rini
Rather than guess what we need to name our u-boot.bin file as for it to boot make use of the kernel= option to always call it u-boot.bin and then on 64bit platforms (and since future platforms use rpi_arm64 this list should not grow) also pass in arm_64bit=1. Signed-off-by: Tom Rini --- bin/writ

[PATCH 00/19] vbe: Series part E

2024-08-29 Thread Simon Glass
This includes various patches towards implementing the VBE abrec bootmeth in U-Boot. It mostly focuses on SPL tweaks and adjusting what fatures are available in VPL. Simon Glass (19): image: Add a prototype for fit_image_get_phase() serial: ns16550: Allow clocks to be missing boot: Allow

Re: [PATCH v9 20/37] net-lwip: add DHCP support and dhcp commmand

2024-08-29 Thread Simon Glass
Hi Jerome, On Fri, 23 Aug 2024 at 07:49, Jerome Forissier wrote: > > Add what it takes to enable NETDEVICES with NET_LWIP and enable DHCP as > well as the dhcp command. CMD_TFTPBOOT is selected by BOOTMETH_EFI due > to this code having an implicit dependency on do_tftpb(). > > Signed-off-by: Jero

Re: [EXTERNAL] Re: [PATCH 1/6] arm: dts: k3-j7200-r5: Add the pmic node in R5 dt

2024-08-29 Thread Nishanth Menon
On 14:02-20240829, Limaye, Aniket wrote: > > > On 6/14/2024 8:25 PM, Tom Rini wrote: > > On Fri, May 31, 2024 at 10:24:30PM +0530, Limaye, Aniket wrote: > > > > > > > > > On 5/31/2024 7:25 PM, Kumar, Udit wrote: > > > > > > > &g

Re: [PATCH 18/19] boot: Imply CRC8 with VBE

2024-08-29 Thread Tom Rini
On Thu, Aug 29, 2024 at 08:58:01AM -0600, Simon Glass wrote: > VBE uses a crc8 checksum to verify that the nvdata is valid, so make > sure it is available if VBE is enabled. > > Signed-off-by: Simon Glass > --- > > boot/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/boot/Kc

Re: [PATCH 17/19] lib: Allow crc8 in TPL and VPL

2024-08-29 Thread Tom Rini
On Thu, Aug 29, 2024 at 08:58:00AM -0600, Simon Glass wrote: > Provide options to enable the CRC8 feature in TPL and VPL builds. > > Signed-off-by: Simon Glass > --- > > lib/Kconfig | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/lib/Kconfig b/lib/Kconfig > index 7

Re: [PATCH 06/19] malloc: Show amount of used space when memory runs out

2024-08-29 Thread Tom Rini
On Thu, Aug 29, 2024 at 08:57:49AM -0600, Simon Glass wrote: > Show a bit more information when malloc() space is exhausted and > debugging is enabled. > > Signed-off-by: Simon Glass > --- > > common/malloc_simple.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/com

Re: [PATCH 02/19] serial: ns16550: Allow clocks to be missing

2024-08-29 Thread Tom Rini
On Thu, Aug 29, 2024 at 08:57:45AM -0600, Simon Glass wrote: > Allow serial init when clock support is not enabled in a particular phase. > > Signed-off-by: Simon Glass > --- > > drivers/serial/ns16550.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/serial/ns

Re: [GIT PULL] Please pull u-boot-imx-master-20240829

2024-08-29 Thread Tom Rini
nx.de/u-boot/custodians/u-boot-efi (2024-08-24 14:03:28 > -0600) > > are available in the Git repository at: > > https://gitlab.denx.de/u-boot/custodians/u-boot-imx.git > tags/u-boot-imx-master-20240829 > > for you to fetch changes up to aec0015a52d3faf723fec9ed9fe1d1af

Re: [PATCH 00/20] arm: Initial support for Analog Devices SC5xx boards

2024-08-29 Thread Tom Rini
On Thu, Aug 29, 2024 at 03:50:56PM +, Gaskell, Oliver wrote: > > > > -Original Message- > > From: Tom Rini > > Sent: Thursday, August 29, 2024 4:18 PM > > To: Gaskell, Oliver > > Cc: Nathan Barrett-Morrison ; Greg Malysa > > ; Ian Roberts ; > > Bimpikas, Vasileios ; Agarwal, Utsav >

Re: [PATCH v5 17/20] test: Try to shut down the lab console gracefully

2024-08-29 Thread Tom Rini
On Thu, Aug 29, 2024 at 09:01:17AM -0600, Simon Glass wrote: > Hi Neil, > > On Thu, 29 Aug 2024 at 08:26, wrote: > > > > On 29/08/2024 00:08, Simon Glass wrote: > > > Send the Labgrid quit characters to ask it to exit gracefully. This > > > typically allows it to power off the board being used. >

Re: [PATCH v5 03/20] test: Pass stderr to stdout

2024-08-29 Thread Tom Rini
On Thu, Aug 29, 2024 at 09:01:11AM -0600, Simon Glass wrote: > Hi Neil, > > On Thu, 29 Aug 2024 at 08:22, wrote: > > > > On 29/08/2024 00:08, Simon Glass wrote: > > > Some tests may output things to stderr. Ensure that this output is not > > > dropped, by redirecting it to stdout > > > > Can't yo

Re: [PATCH 05/13] net: fm: call dtsec_init_phy() only when it is defined

2024-08-29 Thread Jerome Forissier
On 8/29/24 16:04, Simon Glass wrote: > Hi Jerome, > > On Wed, 28 Aug 2024 at 06:11, Jerome Forissier > wrote: >> >> dtsec_init_phy() is defined only with MII so add the proper conditional >> in the caller code. >> >> Signed-off-by: Jerome Forissier >> --- >> drivers/net/fm/eth.c | 2 ++ >> 1

Re: [PATCH v9 35/37] [TESTING] Kconfig: enable NET_LWIP by default except for SANDBOX

2024-08-29 Thread Jerome Forissier
On 8/29/24 16:05, Simon Glass wrote: > Hi Jerome, > > On Fri, 23 Aug 2024 at 07:50, Jerome Forissier > wrote: >> >> Enable NET_LWIP by default for testing purposes. SANDBOX doesn't support >> NET_LWIP so default to NET in this case. > > Sandbox needs to support NET_LWIP. I agree in principle

RE: [PATCH 00/20] arm: Initial support for Analog Devices SC5xx boards

2024-08-29 Thread Gaskell, Oliver
> -Original Message- > From: Tom Rini > Sent: Thursday, August 29, 2024 4:18 PM > To: Gaskell, Oliver > Cc: Nathan Barrett-Morrison ; Greg Malysa > ; Ian Roberts ; > Bimpikas, Vasileios ; Agarwal, Utsav > ; Artamonovs, Arturs > ; Rayagonda Kokatanur > ; u-boot@lists.denx.de; Linux Fact

Re: [PATCH v9 18/37] net: eth-uclass: add function eth_start_udev()

2024-08-29 Thread Jerome Forissier
On 8/29/24 16:05, Simon Glass wrote: > Hi Jerome, > > On Fri, 23 Aug 2024 at 07:49, Jerome Forissier > wrote: >> >> Add a function to start a given network device, and update eth_init() >> to use it. >> >> Signed-off-by: Jerome Forissier >> Reviewed-by: Tom Rini >> --- >> drivers/mtd/altera

Re: [u-boot-test-hooks PATCH v4 3/3] Provide some basic scripts for Labgrid integration

2024-08-29 Thread Tom Rini
On Thu, Aug 29, 2024 at 09:02:38AM -0600, Simon Glass wrote: > Hi Neil, > > On Thu, 29 Aug 2024 at 08:44, wrote: > > > > On 29/08/2024 14:17, Simon Glass wrote: > > > Hi Peter, > > > > > > On Thu, 29 Aug 2024 at 04:43, Peter Robinson wrote: > > >> > > >> On Wed, 28 Aug 2024 at 22:25, Simon Glass

Re: [PATCH 00/20] arm: Initial support for Analog Devices SC5xx boards

2024-08-29 Thread Tom Rini
On Thu, Aug 29, 2024 at 03:06:31PM +, Gaskell, Oliver wrote: > > > > -Original Message- > > From: Tom Rini > > Sent: Thursday, August 29, 2024 3:52 PM > > To: Gaskell, Oliver > > Cc: Nathan Barrett-Morrison ; Greg Malysa > > ; Ian Roberts ; > > Bimpikas, Vasileios ; Agarwal, Utsav >

RE: [PATCH 00/20] arm: Initial support for Analog Devices SC5xx boards

2024-08-29 Thread Gaskell, Oliver
> -Original Message- > From: Tom Rini > Sent: Thursday, August 29, 2024 3:52 PM > To: Gaskell, Oliver > Cc: Nathan Barrett-Morrison ; Greg Malysa > ; Ian Roberts ; > Bimpikas, Vasileios ; Agarwal, Utsav > ; Artamonovs, Arturs > ; Rayagonda Kokatanur > ; u-boot@lists.denx.de; Linux Fact

Re: [PATCH 2/2] cmd: booti: adjust the print format

2024-08-29 Thread Tom Rini
On Thu, Aug 29, 2024 at 09:00:30AM -0600, Simon Glass wrote: > Hi Dario, > > On Thu, 29 Aug 2024 at 08:25, Dario Binacchi > wrote: > > > > Hi Simon, > > > > On Thu, Aug 29, 2024 at 4:05 PM Simon Glass wrote: > > > > > > Hi Dario, > > > > > > On Sun, 25 Aug 2024 at 06:26, Dario Binacchi > > > wr

Re: [u-boot-test-hooks PATCH v4 3/3] Provide some basic scripts for Labgrid integration

2024-08-29 Thread Simon Glass
Hi Neil, On Thu, 29 Aug 2024 at 08:44, wrote: > > On 29/08/2024 14:17, Simon Glass wrote: > > Hi Peter, > > > > On Thu, 29 Aug 2024 at 04:43, Peter Robinson wrote: > >> > >> On Wed, 28 Aug 2024 at 22:25, Simon Glass wrote: > >>> > >>> Hi Peter, > >>> > >>> On Wed, 28 Aug 2024 at 12:14, Peter Ro

Re: [PATCH v6 07/28] hash: integrate hash on mbedtls

2024-08-29 Thread Simon Glass
Hi Raymond, On Fri, 16 Aug 2024 at 15:47, Raymond Mao wrote: > > Integrate common/hash.c on the hash shim layer so that hash APIs > from mbedtls can be leveraged by boot/image and efi_loader. > > Signed-off-by: Raymond Mao > --- > Changes in v2 > - Use the original head files instead of creating

Re: [PATCH 00/15] binman: More patches to support VBE

2024-08-29 Thread Simon Glass
Hi Peter, On Wed, 28 Aug 2024 at 04:01, Peter Robinson wrote: > > On Mon, 26 Aug 2024 at 20:11, Simon Glass wrote: > > > > This series provides a number of patches to make VBE easier to > > implement, particularly with the new OF_UPSTREAM option. > > How? They mostly look unrelated to VBE. - we

Re: [PATCH v5 01/20] test: Allow signaling that U-Boot is ready

2024-08-29 Thread Simon Glass
Hi Neil, On Thu, 29 Aug 2024 at 08:22, wrote: > > On 29/08/2024 00:08, Simon Glass wrote: > > When Labgrid is used, it can get U-Boot ready for running tests. It > > prints a message when it has done so. > > > > Add logic to detect this message and accept it. > > So labgrid can boot and wait for

Re: [PATCH v5 17/20] test: Try to shut down the lab console gracefully

2024-08-29 Thread Simon Glass
Hi Neil, On Thu, 29 Aug 2024 at 08:26, wrote: > > On 29/08/2024 00:08, Simon Glass wrote: > > Send the Labgrid quit characters to ask it to exit gracefully. This > > typically allows it to power off the board being used. > > Sending those characters every time could collide with other CI systems,

Re: [PATCH v5 03/20] test: Pass stderr to stdout

2024-08-29 Thread Simon Glass
Hi Neil, On Thu, 29 Aug 2024 at 08:22, wrote: > > On 29/08/2024 00:08, Simon Glass wrote: > > Some tests may output things to stderr. Ensure that this output is not > > dropped, by redirecting it to stdout > > Can't you make sure to output all labgrid output to stdout in the hook script > instea

Re: [PATCH 12/35] global_data: Convert have_console into a flag

2024-08-29 Thread Simon Glass
On Thu, 29 Aug 2024 at 08:28, Tom Rini wrote: > > On Thu, Aug 29, 2024 at 08:05:35AM -0600, Simon Glass wrote: > > Hi Alexander, > > > > On Fri, 16 Aug 2024 at 07:08, Sverdlin, Alexander > > wrote: > > > > > > Hi Simon, > > > > > > On Wed, 2024-07-24 at 09:08 -0600, Simon Glass wrote: > > > > We

Re: [PATCH v5 08/20] test: Introduce the concept of a role

2024-08-29 Thread Simon Glass
Hi Neil, On Thu, 29 Aug 2024 at 08:19, wrote: > > Hi, > > On 29/08/2024 00:08, Simon Glass wrote: > > In Labgrid there is the concept of a 'role', which is similar to the > > U-Boot board ID in U-Boot's pytest subsystem. > > > > The role indicates both the target and information about the U-Boot

Re: [PATCH v5 00/20] labgrid: Provide an integration with Labgrid

2024-08-29 Thread Simon Glass
Hi Tom, On Thu, 29 Aug 2024 at 08:13, Tom Rini wrote: > > On Wed, Aug 28, 2024 at 04:08:26PM -0600, Simon Glass wrote: > > > Labgrid provides access to a hardware lab in an automated way. It is > > possible to boot U-Boot on boards in the lab without physically touching > > them. It relies on rel

Re: [PATCH 2/2] cmd: booti: adjust the print format

2024-08-29 Thread Simon Glass
Hi Dario, On Thu, 29 Aug 2024 at 08:25, Dario Binacchi wrote: > > Hi Simon, > > On Thu, Aug 29, 2024 at 4:05 PM Simon Glass wrote: > > > > Hi Dario, > > > > On Sun, 25 Aug 2024 at 06:26, Dario Binacchi > > wrote: > > > > > > All three addresses printed are in hexadecimal format, but only the >

[PATCH 19/19] hash: Plumb crc8 into the hash functions

2024-08-29 Thread Simon Glass
Add an entry for crc8, with watchdog handling. Signed-off-by: Simon Glass --- common/hash.c| 8 include/u-boot/crc.h | 3 +++ lib/crc8.c | 6 ++ 3 files changed, 17 insertions(+) diff --git a/common/hash.c b/common/hash.c index ac63803fed9..43c4e185750 100644 ---

[PATCH 17/19] lib: Allow crc8 in TPL and VPL

2024-08-29 Thread Simon Glass
Provide options to enable the CRC8 feature in TPL and VPL builds. Signed-off-by: Simon Glass --- lib/Kconfig | 18 ++ 1 file changed, 18 insertions(+) diff --git a/lib/Kconfig b/lib/Kconfig index 72a5f3cb04f..b2d5e8d04a7 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -698,6 +698

[PATCH 18/19] boot: Imply CRC8 with VBE

2024-08-29 Thread Simon Glass
VBE uses a crc8 checksum to verify that the nvdata is valid, so make sure it is available if VBE is enabled. Signed-off-by: Simon Glass --- boot/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/boot/Kconfig b/boot/Kconfig index afe04c7327a..49e99e5e155 100644 --- a/boot/Kconfig +++

[PATCH 15/19] spl: lib: Allow for decompression in any SPL build

2024-08-29 Thread Simon Glass
Add Kconfig symbols and update the Makefile rules so that decompression can be used in TPL and VPL Signed-off-by: Simon Glass --- lib/Kconfig | 35 +++ lib/Makefile | 8 2 files changed, 39 insertions(+), 4 deletions(-) diff --git a/lib/Kconfig b/lib/

[PATCH 16/19] boot: Allow use of FIT in TPL and VPL

2024-08-29 Thread Simon Glass
With VBE we want to use FIT in all phases of the boot. Add Kconfig options to support this. Disable the options for sandbox_vpl for now. Signed-off-by: Simon Glass --- boot/Kconfig | 69 ++- boot/Makefile | 4 +- configs/sandbox

[PATCH 14/19] spl: Add some more debugging to load_simple_fit()

2024-08-29 Thread Simon Glass
Add debugging of image-loading progress. Fix a stale comment in the function comment while we are here. Signed-off-by: Simon Glass --- common/spl/spl_fit.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/common/spl/spl_fit.c b/common/spl/spl_fit.c index 614dea9ae18

[PATCH 13/19] spl: Drop a duplicate variable in boot_from_devices()

2024-08-29 Thread Simon Glass
The variable 'ret' is defined twice, which is not intended. This may have been a local merge error. Signed-off-by: Simon Glass Fixes: 2eefeb6d893 ("spl: Report a loader failure") --- common/spl/spl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/common/spl/spl.c b/common/spl/spl.c index 5c

[PATCH 12/19] spl: Drop use of uintptr_t

2024-08-29 Thread Simon Glass
U-Boot uses ulong for addresses. It is confusing to use uintptr_t in a few places, since it makes people wonder if the types are compatible. Change the few occurences in SPL to use ulong Signed-off-by: Simon Glass --- common/spl/spl_atf.c| 36 ++-- common/spl

[PATCH 11/19] spl: Support a relocated stack in any XPL phase

2024-08-29 Thread Simon Glass
The current check looks only at SPL, but TPL or VPL might have a different setting. Update the condition. Signed-off-by: Simon Glass --- common/spl/spl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/spl/spl.c b/common/spl/spl.c index 8b868a298f2..5c687cfc73b 100644

[PATCH 10/19] spl: Allow serial to be disabled in any XPL phase

2024-08-29 Thread Simon Glass
The current check looks only at SPL, but TPL or VPL might have a different setting. Update the condition. Signed-off-by: Simon Glass --- common/spl/spl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/spl/spl.c b/common/spl/spl.c index 143ae96baf0..8b868a298f2 100644

[PATCH 09/19] spl: Report a loader failure

2024-08-29 Thread Simon Glass
If a loader returns an error code it is silently ignored. Show a message to at least provide some feedback to the user. Signed-off-by: Simon Glass --- common/spl/spl.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/common/spl/spl.c b/common/spl/spl.c index da11

[PATCH 08/19] Support setting a maximum size for the VPL image

2024-08-29 Thread Simon Glass
Add a size limit for VPL, to match those for SPL and TPL Signed-off-by: Simon Glass --- common/spl/Kconfig.vpl | 8 1 file changed, 8 insertions(+) diff --git a/common/spl/Kconfig.vpl b/common/spl/Kconfig.vpl index 3dc0e95e09f..eb57dfabea5 100644 --- a/common/spl/Kconfig.vpl +++ b/com

[PATCH 07/19] malloc: Provide a simple malloc for VPL

2024-08-29 Thread Simon Glass
The VPL phase may want to use the smaller malloc() implementation, so add an option for this. Signed-off-by: Simon Glass --- common/spl/Kconfig.vpl | 9 + 1 file changed, 9 insertions(+) diff --git a/common/spl/Kconfig.vpl b/common/spl/Kconfig.vpl index d06f36d4ee4..3dc0e95e09f 100644

[PATCH 06/19] malloc: Show amount of used space when memory runs out

2024-08-29 Thread Simon Glass
Show a bit more information when malloc() space is exhausted and debugging is enabled. Signed-off-by: Simon Glass --- common/malloc_simple.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/common/malloc_simple.c b/common/malloc_simple.c index 5a8ec538f8f..f2b3dc53689 10064

[PATCH 05/19] boot: Respect the load_op in fit_image_load()

2024-08-29 Thread Simon Glass
Some code has crept in which ignores this parameter. Fix this and add a little debugging. Signed-off-by: Simon Glass --- boot/image-fit.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/boot/image-fit.c b/boot/image-fit.c index 439ff51edf6..db7fb61bca9 100644 ---

[PATCH 04/19] bootstd: Avoid sprintf() in SPL when creating bootdevs

2024-08-29 Thread Simon Glass
The name of the bootdev device is not that important, particular in SPL. Save a little code space by using a simpler name. Signed-off-by: Simon Glass --- boot/bootdev-uclass.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/boot/bootdev-uclass.c b/boot/bootdev-ucl

[PATCH 03/19] boot: Allow FIT to fall back from best-match option

2024-08-29 Thread Simon Glass
When the best-match feature fails to find something, use the provided config name as a fallback. The allows SPL to select a suitable config when best-match is enabled. Signed-off-by: Simon Glass --- boot/image-fit.c | 19 ++- include/image.h | 4 +++- 2 files changed, 13 inser

[PATCH 02/19] serial: ns16550: Allow clocks to be missing

2024-08-29 Thread Simon Glass
Allow serial init when clock support is not enabled in a particular phase. Signed-off-by: Simon Glass --- drivers/serial/ns16550.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c index 6fcb5b523ac..5cda273623d 100644 --- a/

[PATCH 01/19] image: Add a prototype for fit_image_get_phase()

2024-08-29 Thread Simon Glass
This function exists but is not exported. Add a prototype so it can be used elsewhere. Signed-off-by: Simon Glass --- include/image.h | 12 1 file changed, 12 insertions(+) diff --git a/include/image.h b/include/image.h index dd4042d1bd9..dbf8d0e7ba9 100644 --- a/include/image.h +

Re: [PATCH 00/20] arm: Initial support for Analog Devices SC5xx boards

2024-08-29 Thread Tom Rini
On Wed, Aug 28, 2024 at 11:02:08AM +0100, Oliver Gaskell via B4 Relay wrote: > ADSP-SC5xx is a series of ARM-based DSPs. > This comprises the armv7 based SC57x, SC58x and SC594 series, and the > armv8 based SC598. > > This patch series includes configurations, init code, and minimal DTs > to enabl

Re: [u-boot-test-hooks PATCH v4 3/3] Provide some basic scripts for Labgrid integration

2024-08-29 Thread neil . armstrong
On 29/08/2024 14:17, Simon Glass wrote: Hi Peter, On Thu, 29 Aug 2024 at 04:43, Peter Robinson wrote: On Wed, 28 Aug 2024 at 22:25, Simon Glass wrote: Hi Peter, On Wed, 28 Aug 2024 at 12:14, Peter Robinson wrote: Hi Simon, With Labgrid we don't need to specify the various methods, ex

Re: [u-boot-test-hooks PATCH v4 3/3] Provide some basic scripts for Labgrid integration

2024-08-29 Thread Tom Rini
On Thu, Aug 29, 2024 at 11:43:12AM +0100, Peter Robinson wrote: > On Wed, 28 Aug 2024 at 22:25, Simon Glass wrote: > > > > Hi Peter, > > > > On Wed, 28 Aug 2024 at 12:14, Peter Robinson wrote: > > > > > > Hi Simon, > > > > > > > With Labgrid we don't need to specify the various methods, except fo

Re: [PATCH v5 01/20] test: Allow signaling that U-Boot is ready

2024-08-29 Thread Neil Armstrong
On 29/08/2024 16:22, neil.armstr...@linaro.org wrote: On 29/08/2024 00:08, Simon Glass wrote: When Labgrid is used, it can get U-Boot ready for running tests. It prints a message when it has done so. Add logic to detect this message and accept it. So labgrid can boot and wait for `board_type

Re: [PATCH 12/35] global_data: Convert have_console into a flag

2024-08-29 Thread Tom Rini
On Thu, Aug 29, 2024 at 08:05:35AM -0600, Simon Glass wrote: > Hi Alexander, > > On Fri, 16 Aug 2024 at 07:08, Sverdlin, Alexander > wrote: > > > > Hi Simon, > > > > On Wed, 2024-07-24 at 09:08 -0600, Simon Glass wrote: > > > We don't need a full word for this boolean value. Convert it into a fla

Re: [PATCH v5 17/20] test: Try to shut down the lab console gracefully

2024-08-29 Thread neil . armstrong
On 29/08/2024 00:08, Simon Glass wrote: Send the Labgrid quit characters to ask it to exit gracefully. This typically allows it to power off the board being used. Sending those characters every time could collide with other CI systems, I don't think it's a good idea. If that doesn't work, tr

Re: [PATCH 2/2] cmd: booti: adjust the print format

2024-08-29 Thread Dario Binacchi
Hi Simon, On Thu, Aug 29, 2024 at 4:05 PM Simon Glass wrote: > > Hi Dario, > > On Sun, 25 Aug 2024 at 06:26, Dario Binacchi > wrote: > > > > All three addresses printed are in hexadecimal format, but only the > > first two have the "0x" prefix. The patch aligns the format of the > > "end" addres

Re: [PATCH v5 03/20] test: Pass stderr to stdout

2024-08-29 Thread neil . armstrong
On 29/08/2024 00:08, Simon Glass wrote: Some tests may output things to stderr. Ensure that this output is not dropped, by redirecting it to stdout Can't you make sure to output all labgrid output to stdout in the hook script instead ? Signed-off-by: Simon Glass --- (no changes since v1)

Re: [PATCH v5 01/20] test: Allow signaling that U-Boot is ready

2024-08-29 Thread neil . armstrong
On 29/08/2024 00:08, Simon Glass wrote: When Labgrid is used, it can get U-Boot ready for running tests. It prints a message when it has done so. Add logic to detect this message and accept it. So labgrid can boot and wait for `board_type & board_identity` itself right ? It's cool, but if the

Re: [PATCH v5 08/20] test: Introduce the concept of a role

2024-08-29 Thread neil . armstrong
Hi, On 29/08/2024 00:08, Simon Glass wrote: In Labgrid there is the concept of a 'role', which is similar to the U-Boot board ID in U-Boot's pytest subsystem. The role indicates both the target and information about the U-Boot build to use. It can also provide any amount of other configuration.

Re: [PATCH v2 2/3] efi: Convert device_path allocation to use malloc()

2024-08-29 Thread Simon Glass
Hi Ilias, On Thu, 29 Aug 2024 at 06:39, Ilias Apalodimas wrote: > > On Thu, 29 Aug 2024 at 15:17, Simon Glass wrote: > > > > Hi Ilias, > > > > On Wed, 28 Aug 2024 at 01:40, Ilias Apalodimas > > wrote: > > > > > > Hi Simon, > > > > > > [...] > > > > > > > > > > > > --- > > > > > > > > > > > > >

Re: [PATCH v5 00/20] labgrid: Provide an integration with Labgrid

2024-08-29 Thread Tom Rini
On Wed, Aug 28, 2024 at 04:08:26PM -0600, Simon Glass wrote: > Labgrid provides access to a hardware lab in an automated way. It is > possible to boot U-Boot on boards in the lab without physically touching > them. It relies on relays, USB UARTs and SD muxes, among other things. > > By way of bac

Re: [PATCH 12/35] global_data: Convert have_console into a flag

2024-08-29 Thread Simon Glass
Hi Alexander, On Fri, 16 Aug 2024 at 07:08, Sverdlin, Alexander wrote: > > Hi Simon, > > On Wed, 2024-07-24 at 09:08 -0600, Simon Glass wrote: > > We don't need a full word for this boolean value. Convert it into a flag > > to save space in global_data. > > > > Signed-off-by: Simon Glass > > ---

Re: [PATCH v4 1/4] binman: Add nxp_imx8mcst etype for i.MX8M flash.bin signing

2024-08-29 Thread Simon Glass
Hi Marek, On Sun, 18 Aug 2024 at 14:51, Marek Vasut wrote: > > On 7/9/24 11:24 AM, Simon Glass wrote: > > Hi Marek, > > Hi, > > > On Sun, 7 Jul 2024 at 01:55, Marek Vasut wrote: > >> > >> On 6/27/24 10:19 AM, Simon Glass wrote: > >>> Hi Marek, > >> > >> Hi, > >> > Add new binman etype w

Re: [RFC PATCH 1/1] env: introduce variable ranges

2024-08-29 Thread Simon Glass
Hi, On Mon, 26 Aug 2024 at 06:51, wrote: > > From: Lukas Funke > > This commit extends the flags-variable with ranges for environment > variables. The range is appended to the variable flags using > the '@'-character. A range can be decimal (min/max), bitmask or regular > expression (64 byte). >

Re: [PATCH v9 35/37] [TESTING] Kconfig: enable NET_LWIP by default except for SANDBOX

2024-08-29 Thread Simon Glass
Hi Jerome, On Fri, 23 Aug 2024 at 07:50, Jerome Forissier wrote: > > Enable NET_LWIP by default for testing purposes. SANDBOX doesn't support > NET_LWIP so default to NET in this case. Sandbox needs to support NET_LWIP. > > Signed-off-by: Jerome Forissier > --- > Kconfig | 1 + > 1 file chang

Re: [PATCH 08/13] net: ftgmac100: depend on NET

2024-08-29 Thread Simon Glass
On Wed, 28 Aug 2024 at 06:12, Jerome Forissier wrote: > > FTGMAC100 enables drivers/net/ftgmac100.c which uses > PHY_INTERFACE_MODE_NCSI, which is defined only when PHY_NCSI is enabled. > Therefore FTGMAC100 depends on PHY_NCSI. However adding such a > dependency causes a "recursive dependency det

Re: [PATCH 2/2] cmd: booti: adjust the print format

2024-08-29 Thread Simon Glass
Hi Dario, On Sun, 25 Aug 2024 at 06:26, Dario Binacchi wrote: > > All three addresses printed are in hexadecimal format, but only the > first two have the "0x" prefix. The patch aligns the format of the > "end" address with the other two by adding the "0x" prefix. > > Signed-off-by: Dario Binacch

Re: [PATCH 02/10] sysinfo: Add sysinfo driver and data structure for SMBIOS

2024-08-29 Thread Simon Glass
Hi Raymond, On Fri, 16 Aug 2024 at 09:47, Raymond Mao wrote: > > Add sysinfo interface and definitions to support SMBIOS type 0 to > type 4. > > Signed-off-by: Raymond Mao > --- > drivers/sysinfo/Makefile | 1 + > drivers/sysinfo/smbios_plat.c | 270 ++ >

Re: RPI CM4 - I2C BUS and Device Tree

2024-08-29 Thread Simon Glass
Hi Romain, On Mon, 19 Aug 2024 at 01:15, Romain Crausaz wrote: > > Hi Simon, Hi Peter, > > First of all, thanks a lot for your answers. > > 1. When I enable the i2c bus in the config.txt (which is parsed by the rpi > first stage bootloader), the overlay put this as compatible:"brcm,bcm2835". I

  1   2   >