Re: [RESEND PATCH v4 10/10] mtd: nand: add initial ecc engine support

On 8/17/24 19:58, Simon Glass wrote: > Hi Mikhail, > > On Wed, 14 Aug 2024 at 04:20, Mikhail Kshevetskiy > wrote: >> only spinand on_die ecc is supported for a moment >> >> Signed-off-by: Mikhail Kshevetskiy >> --- >> drivers/mtd/nand/Makefile | 2 +- >> drivers/mtd/nand/core.c

Re: [PATCH v3 1/1] ata: sata_rescan must scan for block devices

Hi Simon, On Fri, Aug 16, 2024 at 3:32 AM Simon Glass wrote: > > Hi Heinrich, > > On Wed, 14 Aug 2024 at 06:53, Heinrich Schuchardt > wrote: > > > > On 14.08.24 14:40, Simon Glass wrote: > > > On Wed, 14 Aug 2024 at 01:10, Heinrich Schuchardt > > > wrote: > > >> > > >> A system may have multipl

[PATCH] mx6: Expand bmode to support ecspi3 boot

From: Fabio Estevam Currently, the bmode command only supports booting from ecspi1. Expand it to also support booting from ecspi3. Signed-off-by: Fabio Estevam --- arch/arm/mach-imx/mx6/soc.c | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/mach-imx/mx6/soc.c b/arch/arm/mach-i

Re: [PATCH 09/21] test: Update NAND test to avoid extra macros

On 8/10/24 16:51, Simon Glass wrote: Use a single test function with a for() loop instead of using macros to create multiple test functions. Add a message so it is clear what piece the test is up to, if it fails. Signed-off-by: Simon Glass Well, the whole reason I wrote it this was was to mak

Re: [PATCH] spl: fix error handling of spl_fit_read

On 8/16/24 03:33, mailingli...@johanneskirchmair.de wrote: From: Johannes Kirchmair Returning negative values from spl_fit_read leads to u-boot crashing. The return value of spl_fit_read is compared with an unsigned value. Returning negative values leads to the check not detecting the error. No

Re: [PATCH] usb: add reset pin handling to onboard-hub driver

Hi, On Fri, 16 Aug 2024 at 07:36, wrote: > > From: Johannes Kirchmair > > Some onboard-hub chips have external reset pins. This patch adds > handling of said pin to the onboard-hub driver. The naming for the > devicetree binding is done in the same way as in the Linux kernel to > ensure good com

Re: [RESEND PATCH v3 9/9] net/netcat: add netcat over tcp support

Hi Mikhail, On Wed, 14 Aug 2024 at 04:32, Mikhail Kshevetskiy wrote: > > This patch adds downloading/uploading of data with netcat. > Client/server mode both supported. > > Signed-off-by: Mikhail Kshevetskiy > --- > cmd/Kconfig | 7 ++ > cmd/net.c| 34 +++-- > includ

Re: [PATCH] spl: fix error handling of spl_fit_read

+Sean Anderson too, for this Hi, On Fri, 16 Aug 2024 at 07:36, wrote: > > From: Johannes Kirchmair > > Returning negative values from spl_fit_read leads to u-boot crashing. > The return value of spl_fit_read is compared with an unsigned value. > Returning negative values leads to the check not

Re: [RESEND PATCH v3 8/9] net/tcp: define a fallback value for rcv_wnd size

On Wed, 14 Aug 2024 at 04:32, Mikhail Kshevetskiy wrote: > > Some driver implements it's own network packet pool, so PKTBUFSRX is zero. > This results in zero-size TCP receive window, so data transfer doesn't > work. Avod it by setting a reasonable fallback value. > > Signed-off-by: Mikhail Ksheve

Re: [RESEND PATCH v3 7/9] net/tcp: simplify tcp header filling code

Hi Mikhail, On Wed, 14 Aug 2024 at 04:32, Mikhail Kshevetskiy wrote: > > Signed-off-by: Mikhail Kshevetskiy > --- > net/tcp.c | 70 +-- > 1 file changed, 37 insertions(+), 33 deletions(-) > Reviewed-by: Simon Glass nits below > diff --git

Re: [RESEND PATCH v3 6/9] net/tcp: improve tcp framework, use better state machine

Hi Mikhail, On Wed, 14 Aug 2024 at 04:32, Mikhail Kshevetskiy wrote: > > Changes: > * Fix initial send sequence always zero issue > * Use state machine close to RFC 9293. This should make TCP >transfers more reliable (now we can upload a huge array >of data from the board to external se

Re: [RESEND PATCH v3 5/9] net/tcp: rename ack_edge and seq_init to more common rcv_nxt and irs

On Wed, 14 Aug 2024 at 04:32, Mikhail Kshevetskiy wrote: > > Use the names from RFC 9293 > > Signed-off-by: Mikhail Kshevetskiy > --- > include/net/tcp.h | 8 > net/tcp.c | 32 > 2 files changed, 20 insertions(+), 20 deletions(-) > Reviewed-by:

Re: [RESEND PATCH v3 4/9] net/tcp: add connection info to tcp_stream structure

Hi Mikhail, On Wed, 14 Aug 2024 at 04:32, Mikhail Kshevetskiy wrote: > > Changes: > * Avoid use net_server_ip in tcp code, use tcp_stream data instead > * Ignore packets from other connections if connection already created. >This prevents us from connection break caused by other tcp stream.

Re: [RESEND PATCH v3 3/9] net/tcp: put connection specific data into a tcp_stream structure

Hi Mikhail, On Wed, 14 Aug 2024 at 04:32, Mikhail Kshevetskiy wrote: > > no functional changes > > Signed-off-by: Mikhail Kshevetskiy > --- > include/net/tcp.h | 37 +++- > net/net.c | 11 ++- > net/tcp.c | 231 +++--- > net/wget.c

Re: [RESEND PATCH v3 2/9] net/tcp: fix selective acknowledge

On Wed, 14 Aug 2024 at 04:32, Mikhail Kshevetskiy wrote: > > Current code assume that all (except last) packets are of the same size. > This is definitely wrong. Replace SACK code with a new one, that does > not rely on this assumption. Also this code uses less memory. > > Signed-off-by: Mikhail K

Re: [RESEND PATCH v3 1/9] net/tcp: fix TCP options processing

On Wed, 14 Aug 2024 at 04:32, Mikhail Kshevetskiy wrote: > > Current TCP code may miss an option if TCP_O_NOP option was used before > it for proper aligning. > > Signed-off-by: Mikhail Kshevetskiy > --- > net/tcp.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Simo

Re: [RESEND PATCH v4 10/10] mtd: nand: add initial ecc engine support

Hi Mikhail, On Wed, 14 Aug 2024 at 04:20, Mikhail Kshevetskiy wrote: > > only spinand on_die ecc is supported for a moment > > Signed-off-by: Mikhail Kshevetskiy > --- > drivers/mtd/nand/Makefile | 2 +- > drivers/mtd/nand/core.c | 130 +++- > drivers/mtd/nand/ecc.c

Re: [RESEND PATCH v2 2/2] spi: soft_spi: Parse cs-gpios only if num-chipselects is not <0>

On Wed, 14 Aug 2024 at 04:14, Mikhail Kshevetskiy wrote: > > From: Michael Polyntsov > > Some boards don't have chipselect lines for leds so cs-gpios is not > specified in the dts leading to probing error. Fix it by making > behavior similar to the one in Linux, parse num-chipselects and > if it

Re: [PATCH v6 00/28] Integrate MbedTLS v3.6 LTS with U-Boot

Hi Raymond, On Fri, 16 Aug 2024 at 15:44, Raymond Mao wrote: > > Integrate MbedTLS v3.6 LTS (currently v3.6.0) with U-Boot. > > Motivations: > > > 1. MbedTLS is well maintained with LTS versions. > 2. LWIP is integrated with MbedTLS and easily to enable HTTPS. > 3. MbedTLS recently s

Re: [PATCH 00/10] SMBIOS improvements

Hi Raymond, On Fri, 16 Aug 2024 at 09:47, Raymond Mao wrote: > > Motivations for changes: > Current SMBIOS library and command-line tool is not fully matching with > the requirements: > 1. Missing support for other mandatory types (#7, #9, #16, #17, #19). > 2. Only a few platforms support SMBIOS

Re: [PATCH v2 27/32] test: cedit: use allocated address for reading file

Hi Sughosh, On Sat, 17 Aug 2024 at 04:06, Sughosh Ganu wrote: > > On Sat, 17 Aug 2024 at 05:24, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Fri, 16 Aug 2024 at 11:53, Sughosh Ganu wrote: > > > > > > On Fri, 16 Aug 2024 at 22:39, Sughosh Ganu > > > wrote: > > > > > > > > On Fri, 16 Aug 2

Re: [PATCH] lib: move phdr increment to for loop heading

Hi Maxim, On Sat, 17 Aug 2024 at 05:02, Maxim Moskalets wrote: > > Shifting this pointer in the loop will be more logical when working > with the code later, because you can see at a glance what exactly > changes at each iteration. Moreover, the code remains equivalent > because this variable is

Re: RPI CM4 - I2C BUS and Device Tree

+Peter Robinson +Matthias Brugger Hi Romain, On Sat, 17 Aug 2024 at 07:01, Romain Crausaz wrote: > > Hi all, > > > > I am currently facing an issue with U-Boot and a raspberry pi CM4. Here is > the setup: > > > > 1. Yocto Scarthgap > > 2. U-Boot 2024.01 > > 3. rpi_arm64_defconfig > > > > I am tr

Re: RPI CM4 - I2C BUS and Device Tree

Hi, > I am currently facing an issue with U-Boot and a raspberry pi CM4. Here is > the setup: > > > > 1. Yocto Scarthgap > > 2. U-Boot 2024.01 > > 3. rpi_arm64_defconfig > > > > I am trying to access the i2c bus from U-Boot. I have been trying to modify > the device tree which is referenced as > “

RPI CM4 - I2C BUS and Device Tree

Hi all, I am currently facing an issue with U-Boot and a raspberry pi CM4. Here is the setup: 1. Yocto Scarthgap 2. U-Boot 2024.01 3. rpi_arm64_defconfig I am trying to access the i2c bus from U-Boot. I have been trying to modify the device tree which is referenced as “CONFIG_DEFAULT_DEV

[PATCH] lib: move phdr increment to for loop heading

Shifting this pointer in the loop will be more logical when working with the code later, because you can see at a glance what exactly changes at each iteration. Moreover, the code remains equivalent because this variable is not used after the loop. Signed-off-by: Maxim Moskalets --- lib/elf.c |

Re: [PATCH v2 27/32] test: cedit: use allocated address for reading file

On Sat, 17 Aug 2024 at 05:24, Simon Glass wrote: > > Hi Sughosh, > > On Fri, 16 Aug 2024 at 11:53, Sughosh Ganu wrote: > > > > On Fri, 16 Aug 2024 at 22:39, Sughosh Ganu wrote: > > > > > > On Fri, 16 Aug 2024 at 20:17, Simon Glass wrote: > > > > > > > > Hi Sughosh, > > > > > > > > On Fri, 16 Au