[PULL] Please pull qcom/qcom-main

2024-07-25 Thread Caleb Connolly
Hi Tom, Just a few things: * Qualcomm platforms >~2016 gain support for the RPMh (Resource Power Manager) peripheral which is used to control most regulators. The RB5 is now able to power up its USB VBUS regulator via the rpmh regulator driver. Git history from the original Linux driver is

M68K Vectors

2024-07-25 Thread Peter LaDow
I'm trying to add support for a custom Colfire based board. I have things building, but the final linked vectors in start.S do not point to _start. In start.S I have: _vectors: .long 0x /* Flash offset is 0 until we setup CS0 */ .long _START .long _FAULT, _FAULT, _FAU

Re: [PATCH v3 1/5] clock: qcom: ipq4019: add ESS clock

2024-07-25 Thread Caleb Connolly
On Mon, 03 Jun 2024 14:06:12 +0200, Robert Marko wrote: > ESS clock is the Ethernet Subsystem clock, so lets add it as its > already configured by SBL1. > > Applied, thanks! [1/5] clock: qcom: ipq4019: add ESS clock https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commit/6a

Re: [PATCH v3 4/5] net: add Qualcomm ESS EDMA adapter

2024-07-25 Thread Tom Rini
On Fri, Jul 26, 2024 at 01:33:09AM +0200, Caleb Connolly wrote: > Hi all, > > Should this go through a different tree? Otherwise I'll take it through > qcom. I think the qcom tree is best currently, thanks. > > Kind regards, > > On 03/06/2024 14:06, Robert Marko wrote: > > This adds the drive

Re: [PATCH v6 00/24] qcom: rpmh core and regulator support

2024-07-25 Thread Caleb Connolly
On 15/07/2024 12:07, Caleb Connolly wrote: This series introduces support for the RPMh (Resource Power Manager (hardened)) co-processor and associated regulator driver found on most modern Qualcomm platforms (since ~2017). Applied in 1fbd0582a28d108c77d7f9135a7f2c3da2398b72 https://source.

Re: [PATCH v3 4/5] net: add Qualcomm ESS EDMA adapter

2024-07-25 Thread Caleb Connolly
Hi all, Should this go through a different tree? Otherwise I'll take it through qcom. Kind regards, On 03/06/2024 14:06, Robert Marko wrote: This adds the driver for the ESS EDMA ethernet adapter found inside of Qualcomm IPQ40xx SoC series. This driver also integrates the built in modified

Re: [PATCH 5/6] efi: Use malloc() for the EFI pool

2024-07-25 Thread Simon Glass
Hi Heinrich, On Thu, 25 Jul 2024 at 09:54, Heinrich Schuchardt wrote: > > On 25.07.24 15:56, Simon Glass wrote: > > This API call is intended for allocating small amounts of memory, > > similar to malloc(). The current implementation rounds up to whole pages > > which can waste large amounts of m

Re: [PATCH 3/6] efi: Allow monitoring of page allocations

2024-07-25 Thread Simon Glass
Hi Heinrich, On Thu, 25 Jul 2024 at 10:26, Heinrich Schuchardt wrote: > > On 25.07.24 15:56, Simon Glass wrote: > > Some confusion has set in over which memory-allocation method to use in > > EFI-related code, particularly for the pool allocator. Most of the time, > > malloc() is used, which is c

Re: [PATCH 40/40] lmb: ut: re-enable unit tests

2024-07-25 Thread Simon Glass
Hi Sughosh, On Wed, 24 Jul 2024 at 00:06, Sughosh Ganu wrote: > > All the changes needed for making the LMB memory map persistent and > global have been made, including making corresponding changes in the > test code. Re-enable the unit tests on the platforms. > > Signed-off-by: Sughosh Ganu > -

Re: [PATCH 39/40] sandbox: adjust load address of couple of tests

2024-07-25 Thread Simon Glass
Hi Sughosh, On Wed, 24 Jul 2024 at 00:06, Sughosh Ganu wrote: > > The TCG event log has now been moved to the start of the memory, and > occupies 8KB of memory. Make a corresponding change to the load > address in a couple of tests so that it does not overlap with the TCG > event log. That addre

Re: [PATCH 35/40] test: lmb: run lmb tests only manually

2024-07-25 Thread Simon Glass
Hi Sughosh, On Wed, 24 Jul 2024 at 00:05, Sughosh Ganu wrote: > > The LMB code has been changed so that the memory reservations and > allocations are now persistent and global. With this change, the > design of the LMB tests needs to be changed accordingly. Mark the LMB > tests to be run only man

Re: [PATCH 36/40] test: lmb: add a separate class of unit tests for lmb

2024-07-25 Thread Simon Glass
Hi Sughosh, On Wed, 24 Jul 2024 at 00:05, Sughosh Ganu wrote: > > Add the LMB unit tests under a separate class of tests. The LMB tests > involve changing the LMB's memory map. With the memory map now > persistent and global, running these tests has a side effect and > impact any subsequent tests

Re: [PATCH 06/40] alist: add a couple of helper functions

2024-07-25 Thread Simon Glass
Hi Sughosh, On Wed, 24 Jul 2024 at 00:03, Sughosh Ganu wrote: > > Add a couple of helper functions to detect an empty and full alist. > > Signed-off-by: Sughosh Ganu > --- > Changes since rfc: None > > include/alist.h | 22 ++ > 1 file changed, 22 insertions(+) I had to hun

Re: [PATCH 33/40] test: cedit: use allocated address for reading file

2024-07-25 Thread Simon Glass
Hi Sughosh, On Wed, 24 Jul 2024 at 00:05, Sughosh Ganu wrote: > > Instead of a randomly selected address, use an LMB allocated one for > reading the file into memory. With the LMB map now being persistent > and global, the address used for reading the file might be already > allocated as non-over

Re: [PATCH 27/40] spl: sandbox: initialise the ram banksize in spl

2024-07-25 Thread Simon Glass
Hi Sughosh, On Wed, 24 Jul 2024 at 00:05, Sughosh Ganu wrote: > > Initialise the ram bank information for sandbox in SPL. This is needed > for initialising the LMB memory map as part of the platform init. I don't understand what is going on here...you are moving code into a function and should e

Re: [PATCH 30/40] sandbox: iommu: remove lmb allocation in the driver

2024-07-25 Thread Simon Glass
Hi Sughosh, On Wed, 24 Jul 2024 at 00:05, Sughosh Ganu wrote: > > The sandbox iommu driver uses the LMB module to allocate a particular > range of memory for the device virtual address(DVA). This used to work > earlier since the LMB memory map was caller specific and not > global. But with the ch

Re: [PATCH 26/40] spl: call spl_board_init() at the end of the spl init sequence

2024-07-25 Thread Simon Glass
On Wed, 24 Jul 2024 at 00:04, Sughosh Ganu wrote: > > The spl_board_init() function on sandbox invokes the unit > tests. Invoking the tests should be done once the rest of the system > has been initialised. Call the spl_board_init() function at the very > end, once the rest of the initilisation fu

Re: [PATCH 25/40] sandbox: move the TCG event log to the start of ram memory

2024-07-25 Thread Simon Glass
Hi Sughosh, On Wed, 24 Jul 2024 at 00:04, Sughosh Ganu wrote: > > The TCG event log buffer is being set at the end of ram memory. This > region of memory is to be reserved as LMB_NOMAP memory in the LMB > memory map. The current location of this buffer overlaps with the > memory region reserved f

Re: [PATCH 24/40] lmb: add a common implementation of arch_lmb_reserve()

2024-07-25 Thread Simon Glass
Hi Sughosh, On Wed, 24 Jul 2024 at 00:04, Sughosh Ganu wrote: > > Almost all of the current definitions of arch_lmb_reserve() are doing > the same thing. The only exception in a couple of cases is the > alignment parameter requirement. Have a generic weak implementation of > this function, keepin

Re: [PATCH 23/40] lmb: add a flags parameter to the API's

2024-07-25 Thread Simon Glass
Hi Sughosh, On Wed, 24 Jul 2024 at 00:04, Sughosh Ganu wrote: > > Add a flags parameter to the LMB API functions. The parameter can then > be used to pass any other type of reservations or allocations needed > by the callers. These will be used in a subsequent set of changes for > allocation requ

Re: [PATCH 22/40] lmb: init: initialise the lmb data structures during board init

2024-07-25 Thread Simon Glass
Hi Sughosh, On Wed, 24 Jul 2024 at 00:04, Sughosh Ganu wrote: > > The memory map maintained by the LMB module is now persistent and > global. This memory map is being maintained through the alloced list > structure which can be extended at runtime -- there is one list for > the available memory,

Re: [PATCH 21/40] lmb: bootm: remove superfluous lmb stub functions

2024-07-25 Thread Simon Glass
On Wed, 24 Jul 2024 at 00:04, Sughosh Ganu wrote: > > Remove a couple of superfluous LMB stub functions, and instead put a > check for calling the lmb_reserve() function. > > Signed-off-by: Sughosh Ganu > --- > Changes since rfc: New patch > > boot/bootm.c | 9 +++-- > 1 file changed, 3 inse

Re: [PATCH 20/40] lmb: remove lmb_init_and_reserve_range() function

2024-07-25 Thread Simon Glass
On Wed, 24 Jul 2024 at 00:04, Sughosh Ganu wrote: > > With the move to make the LMB allocations persistent and the common > memory regions being reserved during board init, there is no need for > an explicit reservation of a memory range. Remove the > lmb_init_and_reserve_range() function. > > Sig

Re: [PATCH 17/40] lmb: introduce a function to add memory to the lmb memory map

2024-07-25 Thread Simon Glass
Hi Sughosh, On Wed, 24 Jul 2024 at 00:04, Sughosh Ganu wrote: > > Introduce a function lmb_add_memory() to add available memory to the > LMB memory map. Call this function during board init once the LMB data > structures have been initialised. > > Signed-off-by: Sughosh Ganu > --- > Changes sinc

Re: [PATCH 16/40] lmb: allow lmb module to be used in SPL

2024-07-25 Thread Simon Glass
Hi Sughosh, On Wed, 24 Jul 2024 at 00:04, Sughosh Ganu wrote: > > With the introduction of separate config symbols for the SPL phase of > U-Boot, the condition checks need to be tweaked so that platforms that > enable the LMB module in SPL are also able to call the LMB API's. Use > the appropriat

Re: [PATCH 15/40] lmb: config: add lmb config symbols for SPL

2024-07-25 Thread Simon Glass
Hi Sughosh, On Wed, 24 Jul 2024 at 00:04, Sughosh Ganu wrote: > > Add separate config symbols for enabling the LMB module for the SPL > phase. The LMB module implementation now relies on alloced list data > structure which requires heap area to be present. Add specific config > symbol for the SPL

Re: [PATCH 11/40] lmb: make LMB memory map persistent and global

2024-07-25 Thread Simon Glass
Hi Sughosh, On Wed, 24 Jul 2024 at 00:03, Sughosh Ganu wrote: > > The current LMB API's for allocating and reserving memory use a > per-caller based memory view. Memory allocated by a caller can then be > overwritten by another caller. Make these allocations and reservations > persistent using th

Re: [PATCH 05/40] spl: alloc: call full alloc functions if malloc pool is available

2024-07-25 Thread Simon Glass
Hi Sughosh, On Wed, 24 Jul 2024 at 00:03, Sughosh Ganu wrote: > > If the malloc simple functionality is enabled in SPL, it is not > possible to call the full-implementation alloc functions even after > the heap is set-up in ram memory. Check for this condition and > call the functions when enable

Re: [RFC PATCH v2 38/48] lib: Kconfig: add a config symbol for getting lmb memory map updates

2024-07-25 Thread Simon Glass
Hi Tom, On Wed, 24 Jul 2024 at 16:47, Tom Rini wrote: > > On Wed, Jul 24, 2024 at 09:40:35AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Wed, 24 Jul 2024 at 08:52, Tom Rini wrote: > > > > > > On Wed, Jul 24, 2024 at 08:37:14AM -0600, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Tue

Re: [PATCH 2/6] efi: Convert device_path allocation to use malloc()

2024-07-25 Thread Simon Glass
Hi Heinrich, On Thu, 25 Jul 2024 at 10:18, Heinrich Schuchardt wrote: > > On 25.07.24 15:56, Simon Glass wrote: > > Currently this calls efi_alloc() which reserves a page for each > > allocation and this can overwrite memory that will be used for reading > > images. > > We already agreed to integ

***UNCHECKED*** [zdi-disclosu...@trendmicro.com: ZDI-CAN-24679: New Vulnerability Report]

2024-07-25 Thread Tom Rini
I'm re-sending this to the list as I think I might have inadvertently dropped it in the mailing list filters. - Forwarded message from "zdi-disclosu...@trendmicro.com" - Date: Thu, 18 Jul 2024 20:04:42 + From: "zdi-disclosu...@trendmicro.com" To: "u-boot@lists.denx.de" , "tr...@kon

Re: [PATCH v5 00/20] Introduce the lwIP network stack

2024-07-25 Thread Tom Rini
On Thu, Jul 25, 2024 at 11:22:20AM -0600, Tom Rini wrote: > On Thu, Jul 25, 2024 at 02:57:21PM +0200, Jerome Forissier wrote: > > > This is a rework of a patch series by Maxim Uvarov: "net/lwip: add lwip > > library for the network stack" [1]. The goal is to introduce the lwIP TCP/IP > > stack [2]

Re: [PATCH v2 00/40] mmc: dw_mmc: Enable eMMC on E850-96 board

2024-07-25 Thread Sam Protsenko
On Thu, Jul 25, 2024 at 1:25 PM Michael Nazzareno Trimarchi wrote: > > Hi all > > Il mar 9 lug 2024, 02:48 Sam Protsenko ha > scritto: >> >> On Thu, Jun 27, 2024 at 9:42 AM Tom Rini wrote: >> > >> > On Wed, Jun 26, 2024 at 10:12:12PM +0530, Anand Moon wrote: >> > > Hi Sam, >> > > >> > > On Wed,

Re: [PATCH] clk: Propagate clk_set_rate() if CLK_SET_PARENT_RATE present

2024-07-25 Thread Sam Protsenko
[snip] >> >> If anything, that shows there is a rising need in this propagation >> feature. I'd like to encourage the maintainers to take a look at both >> implementations, and maybe at least comment on why there is hesitance >> to accept this patch. It's been almost 5 months that I'm trying to >>

[PATCH v1 1/4] cmd: ab_select: fix indentation problems for --no-dec parameter

2024-07-25 Thread Dmitry Rokosov
Command ab_select has wrong help description from indentation perspective. Signed-off-by: Dmitry Rokosov --- cmd/ab_select.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/ab_select.c b/cmd/ab_select.c index bfb67b8236b6..9e2f74573c22 100644 --- a/cmd/ab_select.c +++

[PATCH v1 4/4] common: android_ab: fix slot suffix for abc block

2024-07-25 Thread Dmitry Rokosov
To align with the official Android BCB (Boot Control Block) specifications, it's important to note that the slot_suffix should start with an underscore symbol. For a comprehensive understanding of the expected slot_suffix format in userspace, please refer to the provided reference [1]. Links: [1]

[PATCH v1 2/4] cmd: ab: introduce 'ab_dump' command to print BCB block content

2024-07-25 Thread Dmitry Rokosov
It's really helpful to have the ability to dump BCB block for debugging A/B logic on the board supported this partition schema. Command 'ab_dump' prints all fields of bootloader_control struct including slot_metadata for all presented slots. Output example: = > board# ab_dump ubi 0#misc > Rea

[PATCH v1 3/4] test/py: introduce test for ab_dump command

2024-07-25 Thread Dmitry Rokosov
The ab_dump command allows you to display ABC data directly on the U-Boot console. During an A/B test execution, this test verifies the accuracy of each field within the ABC data. Signed-off-by: Dmitry Rokosov --- test/py/tests/test_android/test_ab.py | 23 +++ 1 file changed

[PATCH v1 0/4] android_ab: fix slot_suffix issue and introduce ab_dump command

2024-07-25 Thread Dmitry Rokosov
The patch series include changes: - fix indentation problems for --no-dec parameter in the ab_select command - introduce the ab_dump command to print the content of the BCB block; it's seful for debugging A/B logic on supported boards - add a test for the ab_dump command to

Re: [PATCH v4 0/7] usb: gadget: atmel: Code refactor and DM_USB_GADGET support

2024-07-25 Thread Zixun LI
On Thu, Jul 25, 2024 at 8:24 PM Marek Vasut wrote: > > On 7/25/24 5:31 PM, Zixun LI wrote: > > Changes in v4: > > - Release clocks if probe failed > > - Add missing endpoint data free > > - Addressed comments > > Please collect any AB/RB/TB tags that were provided in v3 too. Sorry didn't know tha

[PATCH v4 38/38] doc: samsung: Mention enabled eMMC in E850-96 board doc

2024-07-25 Thread Sam Protsenko
eMMC is enabled on E850-96 board now. Mention that in the board documentation. Signed-off-by: Sam Protsenko --- Changes in v4: - (none) Changes in v3: - (none) Changes in v2: - (none) doc/board/samsung/e850-96.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/

[PATCH v4 37/38] configs: e850-96: Enable MMC

2024-07-25 Thread Sam Protsenko
Enable MMC subsystem and DW MMC driver support to make eMMC functional. Also enable a couple of related commands so the user can make use of eMMC from U-Boot shell. Signed-off-by: Sam Protsenko --- Changes in v4: - Rebased on top of the most recent master Changes in v3: - (none) Changes in

[PATCH v4 36/38] arm: dts: exynos: Remove outdated DW MMC properties in all Exynos dts

2024-07-25 Thread Sam Protsenko
Upstream properties were added to device trees to follow current Linux kernel. DW MMC driver was updated accordingly. Safely remove outdated MMC properties. Details on removed properties are as follows: * samsung,removable: replaced by non-removable * samsung,bus-width: replaced by bus-width * sam

[PATCH v4 35/38] mmc: exynos_dw_mmc: Improve coding style

2024-07-25 Thread Sam Protsenko
Fix most of checkpatch warnings and other obvious style issues. No functional change. Signed-off-by: Sam Protsenko --- Changes in v4: - (none) Changes in v3: - (none) Changes in v2: - (none) arch/arm/mach-exynos/include/mach/dwmmc.h | 36 +-- drivers/mmc/exynos_dw_m

[PATCH v4 34/38] mmc: exynos_dw_mmc: Use dev->name as driver's displayed name

2024-07-25 Thread Sam Protsenko
Reduce U-Boot footprint by reusing dev->name as a driver's displayed name. This changes boot device name (and "mmc info" output) from "EXYNOS DWMMC" to something like "mmc@1210". Signed-off-by: Sam Protsenko --- Changes in v4: - (none) Changes in v3: - (none) Changes in v2: - (none)

[PATCH v4 33/38] mmc: exynos_dw_mmc: Don't call dwmci_setup_cfg() after add_dwmci()

2024-07-25 Thread Sam Protsenko
add_dwmci() is already calling dwmci_setup_cfg() internally, there is no needed to call dwmci_setup_cfg() again in case when add_dwmci() is used (for non-DM cases). Fix it by calling dwmci_setup_cfg() only in DM cases, when add_dwmci() wasn't called. Also, this assignment: host->mmc = &plat->m

[PATCH v4 32/38] mmc: exynos_dw_mmc: Pull all init code into probe function

2024-07-25 Thread Sam Protsenko
There is no logical sense to split the initialization code between multiple functions. Pull both do_dwmci_init() and exynos_dwmci_core_init() into exynos_dwmmc_probe() to make the code more simple and obvious. No functional change. Signed-off-by: Sam Protsenko --- Changes in v4: - (none) Chan

[PATCH v4 31/38] mmc: exynos_dw_mmc: Add support for ARM64 Exynos chips

2024-07-25 Thread Sam Protsenko
Add the compatible entry and corresponding chip data for Exynos7 compatible chips, which covers modern ARM64 based Exynos chips. They have some differences w.r.t. old ARM32 Exynos chips: - CLKSEL register offset is different - 64-bit IDMAC descriptor and 64-bit IDMAC registers are used (imp

[PATCH v4 30/38] mmc: exynos_dw_mmc: Set requested freq in get_mmc_clk() callback

2024-07-25 Thread Sam Protsenko
By now exynos_dw_mmc driver was relying on the correct CIU clock frequency being set on driver init. But dw_mmc core is actually trying to change CIU clock rate dynamically, on init and in set_ios() callback, which it's requesting via host->get_mmc_clk() callback (the name is misleading: although i

[PATCH v4 29/38] mmc: exynos_dw_mmc: Read and use DDR timing when available

2024-07-25 Thread Sam Protsenko
DDR timing values should be defined in "samsung,dw-mshc-ddr-timing" dts property, and used when DDR MMC mode is selected. Read that value from dts and use it. If it's not available, use SDR timing values instead. This change is following upstream Linux kernel implementation. Signed-off-by: Sam Pro

[PATCH v4 28/38] mmc: exynos_dw_mmc: Move quirks from struct dwmci_host to chip data

2024-07-25 Thread Sam Protsenko
host->quirks field is only used internally in exynos_dw_mmc.c driver. To avoid cluttering the scope of struct dwmci_host, move quirks field into Exynos driver's chip data, where it can be statically defined. No functional change. Signed-off-by: Sam Protsenko --- Changes in v4: - (none) Change

[PATCH v4 27/38] mmc: exynos_dw_mmc: Read common clock-frequency property

2024-07-25 Thread Sam Protsenko
Instead of using non-standard "bus_hz" dts property, read common "clock-frequency" property used in upstream Linux kernel. It's safe to do so, as "clock-frequency" property was already added to corresponding nodes in all affected Exynos device tree files. No functional change. Signed-off-by: Sam

[PATCH v4 26/38] mmc: exynos_dw_mmc: Read common bus-width property

2024-07-25 Thread Sam Protsenko
Instead of using non-standard "samsung,bus-width" dts property, read common "bus-width" property used in upstream Linux kernel. It's safe to do so, as "bus-width" property was already added to corresponding nodes in all affected Exynos device tree files. No functional change. Signed-off-by: Sam P

[PATCH v4 25/38] mmc: exynos_dw_mmc: Refactor fixed CIU clock divider

2024-07-25 Thread Sam Protsenko
Some chips like Exynos4412 have fixed internal CIU clock divider. Instead of reading it from non-standard "div" dts property, store its value in the driver internally, in static chip data associated with corresponding compatible. This makes it possible to avoid using host->div for storing it, so th

[PATCH v4 24/38] mmc: exynos_dw_mmc: Abstract CLKSEL register

2024-07-25 Thread Sam Protsenko
CLKSEL register offset may vary between different Exynos chips, e.g. on ARM64 vs ARM32 chips. Provide a way to specify its offset value for each compatible instead of hard-coding its value in read/write calls. No functional change. Signed-off-by: Sam Protsenko --- Changes in v4: - (none) Chan

[PATCH v4 23/38] mmc: exynos_dw_mmc: Read upstream SDR timing properties

2024-07-25 Thread Sam Protsenko
The obsolete "samsung,timing" dts property is now split into "samsung,dw-mshc-ciu-div" (for holding the internal DW MMC divider value) and "samsung,dw-mshc-sdr-timing" (for actual timing values) in upstream Linux kernel. Rework the driver to make use of new properties instead of the old one. All af

[PATCH v4 22/38] mmc: exynos_dw_mmc: Convert to use livetree API

2024-07-25 Thread Sam Protsenko
Update the driver to use livetree API instead of FDT one. No functional change. Signed-off-by: Sam Protsenko --- Changes in v4: - (none) Changes in v3: - (none) Changes in v2: - Moved exynos_dwmmc_of_to_plat() under #ifdef CONFIG_DM_MMC stanza drivers/mmc/exynos_dw_mmc.c | 17 -

[PATCH v4 20/38] mmc: exynos_dw_mmc: Obtain and use CIU clock via CCF API

2024-07-25 Thread Sam Protsenko
New Exynos chips should implement clock drivers using CCF framework. In that case corresponding CCF functions can be used to get/set the clock rates. Moreover, already existing get_mmc_clk() and set_mmc_clk() calls are only implemented for CONFIG_CPU_V7A (i.e. ARM32 chips). In case of ARM64 chips t

[PATCH v4 21/38] mmc: exynos_dw_mmc: Use .of_to_plat for device tree parsing

2024-07-25 Thread Sam Protsenko
exynos_dwmci_get_config() is called from the probe function and used to read data from device tree. Make use of .of_to_plat driver callback instead, and convert exynos_dwmci_get_config() to match its signature. No functional change. Signed-off-by: Sam Protsenko --- Changes in v4: - (none) Cha

[PATCH v4 19/38] mmc: exynos_dw_mmc: Don't call pinmux functions on ARM64 chips

2024-07-25 Thread Sam Protsenko
Pinmux configuration on ARM64 platforms must be performed during startup in pinctrl driver using info from device tree. exynos_pinmux_config() and pinmux_decode_periph_id() are only available on ARM32 platforms, so don't call those functions on ARM64 platforms. Instead of the latter function, use "

[PATCH v4 18/38] mmc: exynos_dw_mmc: Fix getting private data in exynos_dwmci_board_init()

2024-07-25 Thread Sam Protsenko
In case of CONFIG_DM_MMC, host->priv actually holds (struct udevice *), and not (struct dwmci_exynos_priv_data *). This makes *priv pointer invalid and may lead to Synchronous Abort during its dereference later in exynos_dwmci_board_init(). Fix it by extracting exynos_dwmmc_get_priv() helper from e

[PATCH v4 15/38] dt-bindings: exynos: Update bindings doc for DW MMC controller

2024-07-25 Thread Sam Protsenko
Update the bindings doc for Exynos DW MMC block to follow the upstream example and reflect the latest changes made in corresponding Linux kernel bindings. Signed-off-by: Sam Protsenko --- Changes in v4: - (none) Changes in v3: - (none) Changes in v2: - (none) doc/device-tree-bindings/ex

[PATCH v4 16/38] arm: exynos: Add header guard for dwmmc.h

2024-07-25 Thread Sam Protsenko
Add missing header guard to prevent possible build errors. Fixes: 77b55e8cfcee ("ARM: exynos: move SoC sources to mach-exynos") Signed-off-by: Sam Protsenko --- Changes in v4: - (none) Changes in v3: - (none) Changes in v2: - (none) arch/arm/mach-exynos/include/mach/dwmmc.h | 5 + 1

[PATCH v4 17/38] mmc: exynos_dw_mmc: Fix obtaining the base address of controller

2024-07-25 Thread Sam Protsenko
Getting the base address with outdated fdtdec_get_addr() API and further casting it to (void *) leads to next build warning on ARM64 platforms: In function 'exynos_dwmci_get_config': warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] hos

[PATCH v4 14/38] arm: dts: exynos: Add upstream DW MMC properties to all Exynos dts

2024-07-25 Thread Sam Protsenko
Some device tree properties for DW MMC block were updated in Linux kernel. Let's follow its example and rework corresponding properties in all Exynos device trees. Don't remove outdated properties yet, it'll be done later once DW MMC driver is updated accordingly to read the updated properties inst

[PATCH v4 13/38] mmc: dw_mmc: Improve coding style

2024-07-25 Thread Sam Protsenko
Fix most of checkpatch warnings and other obvious style issues. No functional change. Signed-off-by: Sam Protsenko Reviewed-by: Quentin Schulz --- Changes in v4: - Rebased on top of the most recent master Changes in v3: - (none) Changes in v2: - Added R-b tag from Quentin drivers/mmc/

[PATCH v4 11/38] mmc: dw_mmc: Replace fifoth_val property with fifo-depth

2024-07-25 Thread Sam Protsenko
Replace fifoth_val property with its fifo-depth counterpart in all DW MMC drivers. fifo-depth is a common property used in upstream Linux kernel. The FIFOTH register value will be calculated using fifo-depth value in DW MMC core (dw_mmc.c). This change reduces code duplication in platform drivers,

[PATCH v4 12/38] mmc: dw_mmc: Fix kernel-doc comments in dwmmc.h

2024-07-25 Thread Sam Protsenko
Rework kernel-doc comments in dwmmc.h header so it's actually possible to generate a proper documentation from it usin scripts/kernel-doc script, with no errors. No functional change. Signed-off-by: Sam Protsenko --- Changes in v4: - (none) Changes in v3: - (none) Changes in v2: - (none)

[PATCH v4 10/38] mmc: dw_mmc: Add support for 64-bit IDMAC

2024-07-25 Thread Sam Protsenko
Some DW MMC blocks (e.g. those on modern Exynos chips) support 64-bit DMA addressing mode. 64-bit DW MMC variants differ from their 32-bit counterparts: - the register layout is a bit different (because there are additional IDMAC registers present for storing upper part of 64-bit addresses)

[PATCH v4 09/38] mmc: dw_mmc: Improve 32-bit IDMAC descriptor namings

2024-07-25 Thread Sam Protsenko
Prepare for adding 64-bit IDMAC descriptors by renaming current 32-bit descriptor and its fields accordingly. While at it, make use of virt_to_phys() to make it more obvious in which places the physical addresses have to be used. No functional change. Signed-off-by: Sam Protsenko --- Changes in

[PATCH v4 08/38] mmc: dw_mmc: Extract setting the DMA descriptor into a separate routine

2024-07-25 Thread Sam Protsenko
Make dwmci_prepare_data() function easier to read by extracting the preparation of IDMAC descriptor into a dedicated function. No functional change. Signed-off-by: Sam Protsenko Reviewed-by: Quentin Schulz --- Changes in v4: - Rebased on top of the most recent master Changes in v3: - (none

[PATCH v4 07/38] mmc: dw_mmc: Extract DMA transfer handling code into a separate routine

2024-07-25 Thread Sam Protsenko
Make dwmci_send_cmd() easier to read by moving the DMA transfer handling code into a dedicated function. No functional change. Signed-off-by: Sam Protsenko Reviewed-by: Quentin Schulz --- Changes in v4: - (none) Changes in v3: - (none) Changes in v2: - Added R-b tag from Quentin drive

[PATCH v4 06/38] mmc: dw_mmc: Extract FIFO data transfer into a separate routine

2024-07-25 Thread Sam Protsenko
FIFO data transfer is implemented as quite a massive chunk of code. Extract it into a dedicated function to make dwmci_data_transfer() easier to read and reduce the indentation level of the code. No functional change. Signed-off-by: Sam Protsenko --- Changes in v4: - (none) Changes in v3: -

[PATCH v4 05/38] mmc: dw_mmc: Extract divider update to a separate function

2024-07-25 Thread Sam Protsenko
Extract the clock divider update into dwmci_update_div() function. It's a procedure recommended in TRM, so it's better to keep it in a dedicated function to make the code clearer. While at it also extract the clock control code into a separate routine to avoid code duplication in dwmci_setup_bus()

[PATCH v4 04/38] mmc: dw_mmc: Extract FIFO init into a separate routine

2024-07-25 Thread Sam Protsenko
Move FIFO threshold initialization into a separate function to make dwmci_init() more readable. No functional change. Signed-off-by: Sam Protsenko Reviewed-by: Quentin Schulz --- Changes in v4: - (none) Changes in v3: - (none) Changes in v2: - Added R-b tag from Quentin drivers/mmc/dw

[PATCH v4 03/38] mmc: dw_mmc: Extract waiting for data busy into a separate routine

2024-07-25 Thread Sam Protsenko
Waiting for data busy is a logically separate operation and should be implemented as a separate routine. Follow Linux kernel example and extract it from dwmci_send_cmd(). This way it doesn't clutter dwmci_send_cmd() function, and can be reused later in other cases. No functional change. Signed-of

[PATCH v4 02/38] mmc: dw_mmc: Move struct idmac to dw_mmc.c

2024-07-25 Thread Sam Protsenko
struct idmac is only used in dw_mmc.c, so move it there from dwmmc.h to avoid cluttering the interface in the header. No functional change. Signed-off-by: Sam Protsenko Reviewed-by: Quentin Schulz --- Changes in v4: - (none) Changes in v3: - (none) Changes in v2: - Added R-b tag from Qu

[PATCH v4 01/38] mmc: dw_mmc: Remove unused version field from struct dwmci_host

2024-07-25 Thread Sam Protsenko
Nobody seems to use it, so just remove it. No functional change. Signed-off-by: Sam Protsenko Reviewed-by: Quentin Schulz --- Changes in v4: - (none) Changes in v3: - (none) Changes in v2: - Added R-b tag from Quentin include/dwmmc.h | 1 - 1 file changed, 1 deletion(-) diff --git a/

[PATCH v4 00/38] mmc: dw_mmc: Enable eMMC on E850-96 board

2024-07-25 Thread Sam Protsenko
Bring 64-bit support to dw_mmc core and Exynos dw_mmc drivers, and enable it on E850-96 board. Additionally do some related cleanups and device tree updates. 64-bit version of DesignWare MMC can be often found on modern ARM64 chips. It's different from its older 32-bit version (which is already im

Re: [PATCH v4 0/7] usb: gadget: atmel: Code refactor and DM_USB_GADGET support

2024-07-25 Thread Marek Vasut
On 7/25/24 8:48 PM, Zixun LI wrote: On Thu, Jul 25, 2024 at 8:24 PM Marek Vasut wrote: On 7/25/24 5:31 PM, Zixun LI wrote: Changes in v4: - Release clocks if probe failed - Add missing endpoint data free - Addressed comments Please collect any AB/RB/TB tags that were provided in v3 too. S

Re: [PATCH v5 06/20] net: eth-uclass: add function eth_start_udev()

2024-07-25 Thread Tom Rini
On Thu, Jul 25, 2024 at 02:57:27PM +0200, Jerome Forissier wrote: > Add a function to start a given etwork device, and update eth_init() Typo, "network". > to use it. > > Signed-off-by: Jerome Forissier And this is where most of the tiny and acceptable growth comes from in the legacy network

Re: [PATCH] clk: Propagate clk_set_rate() if CLK_SET_PARENT_RATE present

2024-07-25 Thread Michael Nazzareno Trimarchi
Hi Sam Il mar 23 lug 2024, 22:53 Sam Protsenko ha scritto: > On Wed, Jul 3, 2024 at 10:00 AM Michael Nazzareno Trimarchi > wrote: > > > > Hi all > > > > Working on the clock now. I have done a different implementation > > > > clk-mux, clk-gate I have added a clk_generic_set_rate that is a stub

Re: [PATCH v2 00/40] mmc: dw_mmc: Enable eMMC on E850-96 board

2024-07-25 Thread Michael Nazzareno Trimarchi
Hi all Il mar 9 lug 2024, 02:48 Sam Protsenko ha scritto: > On Thu, Jun 27, 2024 at 9:42 AM Tom Rini wrote: > > > > On Wed, Jun 26, 2024 at 10:12:12PM +0530, Anand Moon wrote: > > > Hi Sam, > > > > > > On Wed, 19 Jun 2024 at 02:26, Sam Protsenko < > semen.protse...@linaro.org> wrote: > > > > >

Re: [PATCH v4 0/7] usb: gadget: atmel: Code refactor and DM_USB_GADGET support

2024-07-25 Thread Marek Vasut
On 7/25/24 5:31 PM, Zixun LI wrote: Changes in v4: - Release clocks if probe failed - Add missing endpoint data free - Addressed comments Please collect any AB/RB/TB tags that were provided in v3 too.

Re: [PATCH v5 01/20] flash: prefix error codes with FL_

2024-07-25 Thread Tom Rini
On Thu, Jul 25, 2024 at 02:57:22PM +0200, Jerome Forissier wrote: > Prefix the flash status codes (ERR_*) with FL_ in order to avoid clashes > with third-party libraries. Case in point: including the lwIP library > header file which defines err_enum_t as an enum with values > being ERR_*. > > Si

Re: [PATCH v3 00/38] mmc: dw_mmc: Enable eMMC on E850-96 board

2024-07-25 Thread Sam Protsenko
On Wed, Jul 24, 2024 at 11:30 PM Sam Protsenko wrote: > > Hi Jaehoon, > > Can you please check this series, and if it looks good, apply it? > v3 doesn't apply anymore, due to the recent changes in U-Boot/master. I'll rebase and re-submit v4 today. Thanks! [snip]

Re: [PATCH v5 00/20] Introduce the lwIP network stack

2024-07-25 Thread Tom Rini
On Thu, Jul 25, 2024 at 02:57:21PM +0200, Jerome Forissier wrote: > This is a rework of a patch series by Maxim Uvarov: "net/lwip: add lwip > library for the network stack" [1]. The goal is to introduce the lwIP TCP/IP > stack [2] [3] as an alternative to the current implementation in net/, > sele

Re: Fwd: New Defects reported by Coverity Scan for Das U-Boot

2024-07-25 Thread Tom Rini
On Thu, Jul 25, 2024 at 10:04:33AM +0200, Mattijs Korpershoek wrote: > On mer., juil. 24, 2024 at 16:40, Tom Rini wrote: > > [...] > > >> > > >> >Ok, so does that mean that you agree that this code is safe and we don't > >> >need any further action to fix it? > >> > >> No fix needed. > >> > >>

Re: Please pull u-boot-samung master

2024-07-25 Thread Tom Rini
On Thu, Jul 25, 2024 at 04:48:23PM +0900, Minkyu Kang wrote: > Dear Tom, > > The following changes since commit b182816c1fb436916661949213c543bf4d42250b: > > turris_1x: Normalize Kconfig usage (2024-07-13 10:42:15 -0600) > > are available in the git repository at: > > g...@source.denx.de:u

Re: [PATCH v5 02/20] net: introduce alternative implementation as net-lwip/

2024-07-25 Thread Tom Rini
On Thu, Jul 25, 2024 at 02:57:23PM +0200, Jerome Forissier wrote: > Prepare the introduction of the lwIP (lightweight IP) TCP/IP stack by > adding a new net/lwip/ directory and the NET_LWIP symbol. Network > support is either NO_NET, NET (legacy stack) or NET_LWIP. Subsequent > commits will introd

[PATCH v4 7/7] usb: gadget: atmel: Add DM_USB_GADGET support

2024-07-25 Thread Zixun LI
Add driver model support by using the uclass UCLASS_USB_GADGET_GENERIC. Disable local usb_gadget_register_driver()/usb_gadget_unregister_driver() implementation which is implemented in udc-core.c when DM_USB_GADGET is enabled. Replace dm_usb_gadget_handle_interrupts() with handle_interrupts ops w

[PATCH v4 6/7] usb: gadget: atmel: Add attach/detach support

2024-07-25 Thread Zixun LI
Add controller attach/detach support by using usb_gadget_ops.pullup() function. Signed-off-by: Zixun LI --- drivers/usb/gadget/atmel_usba_udc.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_udc.c index

[PATCH v4 5/7] usb: gadget: atmel: Rename atmel_usba_start()/_stop() to usba_udc_enable()/_disable()

2024-07-25 Thread Zixun LI
Rename atmel_usba_start() / atmel_usba_stop() to usba_udc_enable() / usba_udc_disable(), remove atmel_ prefix to be inline with other functions. Also avoid confusion with DM start() / stop() functions. Signed-off-by: Zixun LI --- drivers/usb/gadget/atmel_usba_udc.c | 8 1 file changed,

[PATCH v4 4/7] usb: gadget: atmel: Move usba_udc_pdata() with other static functions

2024-07-25 Thread Zixun LI
To make all static functions in the top, no functional change. Signed-off-by: Zixun LI --- drivers/usb/gadget/atmel_usba_udc.c | 80 ++--- 1 file changed, 40 insertions(+), 40 deletions(-) diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_

[PATCH v4 3/7] usb: gadget: atmel: Fix typo in usb gadget driver register and unregister

2024-07-25 Thread Zixun LI
Replace "paramter" by "parameter". Signed-off-by: Zixun LI --- drivers/usb/gadget/atmel_usba_udc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_udc.c index 4641638412..2e3d8f36a2 100644 --- a/drivers/

[PATCH v4 2/7] usb: gadget: atmel: Replace printf() and pr_err() by log_err()

2024-07-25 Thread Zixun LI
To have a uniform printing function, also drop linux/printk.h as no longer used. Signed-off-by: Zixun LI --- drivers/usb/gadget/atmel_usba_udc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_u

[PATCH v4 1/7] usb: gadget: atmel: Sort includes

2024-07-25 Thread Zixun LI
Sort includes in alphabetical order. Signed-off-by: Zixun LI --- drivers/usb/gadget/atmel_usba_udc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_udc.c index f99553df8d..5f78251fdb 100644 --- a/driv

[PATCH v4 0/7] usb: gadget: atmel: Code refactor and DM_USB_GADGET support

2024-07-25 Thread Zixun LI
Changes in v4: - Release clocks if probe failed - Add missing endpoint data free - Addressed comments Changes in v3: - Separate code refactor into individual commits - Extract the controller point from udevice private data in DM functions Changes in v2: - Fix null pointer deference in driver unbi

Re: [PATCH v5 02/20] net: introduce alternative implementation as net-lwip/

2024-07-25 Thread Maxim Uvarov
чт, 25 июл. 2024 г. в 15:58, Jerome Forissier : > > Prepare the introduction of the lwIP (lightweight IP) TCP/IP stack by > adding a new net/lwip/ directory and the NET_LWIP symbol. Network > support is either NO_NET, NET (legacy stack) or NET_LWIP. Subsequent > commits will introduce the lwIP code

Re: [PATCH 4/6] efi: Avoid pool allocation in efi_get_memory_map_alloc()

2024-07-25 Thread Heinrich Schuchardt
On 25.07.24 15:56, Simon Glass wrote: This function returns the memory map, allocating memory for it. But it can just use malloc() directly, rather than calling the pool allocator. Update it. The size of the memory map may exceed CONFIG_SYS_MALLOC_LEN which tends to be astonishingly small: 1 Mi

  1   2   3   >