Re: [PATCH 1/3] net: give a different name to rtl8169 interfaces

2024-06-27 Thread Etienne Dublé
Hi Quentin, Le 27/06/2024 à 14:27, Quentin Schulz a écrit : Hi Etienne, On 6/25/24 1:42 PM, Etienne Dublé wrote: Hello, Le 25/06/2024 à 12:25, Dragan Simic a écrit : Another option may be to name them "rtl8169@", with "" reflecting the PCI region address (so it is unique and stable). Wha

Re: [PATCH v1] board: mpfs_icicle: implement board_fdt_blob_setup()

2024-06-27 Thread Conor Dooley
On Fri, Jun 28, 2024 at 08:53:11AM +0300, Ilias Apalodimas wrote: > On Thu, 27 Jun 2024 at 23:27, Conor Dooley wrote: > > On Thu, Jun 27, 2024 at 11:50:33AM +0100, Simon Glass wrote: > > > On Thu, 27 Jun 2024 at 10:38, Conor Dooley > > > wrote: > > > > On Thu, Jun 27, 2024 at 09:36:49AM +0100, S

Re: [PATCH v1] board: mpfs_icicle: implement board_fdt_blob_setup()

2024-06-27 Thread Conor Dooley
On Fri, Jun 28, 2024 at 07:22:35AM +0100, Simon Glass wrote: > On Thu, 27 Jun 2024 at 21:27, Conor Dooley wrote: > > OK, thanks for all the details. I suppose, to me, 128KB does not sound > that constrained :-) But I can see that messing with a bloblist can > add code. A static tool would help wi

Re: [PATCH v1] board: mpfs_icicle: implement board_fdt_blob_setup()

2024-06-27 Thread Simon Glass
Hi Conor, On Thu, 27 Jun 2024 at 21:27, Conor Dooley wrote: > > On Thu, Jun 27, 2024 at 11:50:33AM +0100, Simon Glass wrote: > > On Thu, 27 Jun 2024 at 10:38, Conor Dooley > > wrote: > > > On Thu, Jun 27, 2024 at 09:36:49AM +0100, Simon Glass wrote: > > > > On Tue, 25 Jun 2024 at 15:34, Tom Rin

Re: [PATCH v1] board: mpfs_icicle: implement board_fdt_blob_setup()

2024-06-27 Thread Ilias Apalodimas
Hi Conor, On Thu, 27 Jun 2024 at 23:27, Conor Dooley wrote: > > On Thu, Jun 27, 2024 at 11:50:33AM +0100, Simon Glass wrote: > > On Thu, 27 Jun 2024 at 10:38, Conor Dooley > > wrote: > > > On Thu, Jun 27, 2024 at 09:36:49AM +0100, Simon Glass wrote: > > > > On Tue, 25 Jun 2024 at 15:34, Tom Ri

Re: [PATCH next] doc: develop: Add a general section on gdb usage

2024-06-27 Thread Heinrich Schuchardt
On 6/26/24 12:47, Alexander Dahl wrote: Mashed up from different sources linked below, including the now gone Wiki and doc/README.arm-relocation file. Tested on a custom board with AT91 SAMA5D2 SoC and Segger J-Link Base adapter. This is only generic advice here, the usage is not board specific

Re: [PATCH 1/4] power: regulator: Trigger probe of regulators which are always-on or boot-on

2024-06-27 Thread Caleb Connolly
On 27/06/2024 11:26, Simon Glass wrote: Hi Caleb, On Thu, 27 Jun 2024 at 09:48, Caleb Connolly wrote: On 27/06/2024 10:37, Simon Glass wrote: Hi Marek, On Thu, 27 Jun 2024 at 00:57, Marek Vasut wrote: In case a regulator DT node contains regulator-always-on or regulator-boot-on prop

Re: [PATCH] spl: fit: List DTOs applied by SPL in U-Boot control DT

2024-06-27 Thread Marek Vasut
On 6/27/24 2:42 PM, Quentin Schulz wrote: Hi Marek, Hi, On 6/27/24 1:58 AM, Marek Vasut wrote: Insert /u-boot, = property into the U-Boot control DT during SPL DTO application process. This can be used by user to inspect which DTOs got applied by the SPL and in which order from running U-Bo

Re: [PATCH] spl: fit: List DTOs applied by SPL in U-Boot control DT

2024-06-27 Thread Marek Vasut
On 6/27/24 10:37 AM, Simon Glass wrote: Hi, /* Make room in FDT for changes from the overlay */ ret = fdt_increase_size(spl_image->fdt_addr, - image_info.size); +

[PATCH v2] spl: fit: List DTOs applied by SPL in U-Boot control DT

2024-06-27 Thread Marek Vasut
Insert /u-boot,spl-applied-dto- = property into the U-Boot control DT during SPL DTO application process. This can be used by user to inspect which DTOs got applied by the SPL and in which order from running U-Boot. Example: ``` u-boot=> fdt addr $fdtcontroladdr && fdt list / Working FDT set to a

Re: [PATCH 2/3] dm: core: support dtb switching without devices/drivers unloading

2024-06-27 Thread Caleb Connolly
On 27/06/2024 13:35, Mikhail Kshevetskiy wrote: Consider a case when we have several similar boards but leds & buttons connected differently. Some of leds uses gpio, other pwm, third gpio over spi bitbang. Also different board may have different gpio hogs. And last but not least: board type st

Re: [PATCH 3/3] dm: mmc: fix driver rebinding in the case of dtb reloading

2024-06-27 Thread Caleb Connolly
Hi Mikhail, On 27/06/2024 13:35, Mikhail Kshevetskiy wrote: Rebinding of the mmc driver causes reregistration of block device. Thus second mmc device appears and the first becomes broken. Fix an issue by using already registered block device instead of registering a new one. Signed-off-by: Mik

Re: [PATCH v2 2/2] usb: musb-new: sunxi: make compatible with UDC/DM gadget model

2024-06-27 Thread Sam Edwards
On 6/27/24 09:06, Andre Przywara wrote: On Thu, 8 Jun 2023 13:56:31 -0600 Sam Edwards wrote: Hi, John asked me have a look at this. Hi Andre, it's good to hear from you again, I'd first like to make sure you're aware that the date on this patch is June *2023,* not June 2024. It's possible

Re: [PATCH 1/4] power: regulator: Trigger probe of regulators which are always-on or boot-on

2024-06-27 Thread Marek Vasut
On 6/27/24 10:37 AM, Simon Glass wrote: Hi Marek, Hi, [...] --- drivers/power/regulator/regulator-uclass.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/power/regulator/regulator-uclass.c b/drivers/power/regulator/regulator-uclass.c i

Re: [PATCH 1/2] led: Implement software led blinking

2024-06-27 Thread Christian Marangi
On Thu, Jun 27, 2024 at 01:36:09PM -0600, Tom Rini wrote: > On Thu, Jun 27, 2024 at 02:31:13PM +0300, Mikhail Kshevetskiy wrote: > > > From: Michael Polyntsov > > > > If hardware (or driver) doesn't support leds blinking, it's > > now possible to use software implementation of blinking instead.

Re: [PATCH v1] board: mpfs_icicle: implement board_fdt_blob_setup()

2024-06-27 Thread Conor Dooley
On Thu, Jun 27, 2024 at 11:50:33AM +0100, Simon Glass wrote: > On Thu, 27 Jun 2024 at 10:38, Conor Dooley wrote: > > On Thu, Jun 27, 2024 at 09:36:49AM +0100, Simon Glass wrote: > > > On Tue, 25 Jun 2024 at 15:34, Tom Rini wrote: > > > > On Tue, Jun 25, 2024 at 10:08:06AM +0100, Conor Dooley wrot

Re: [PATCH] zlib: Fix big performance regression

2024-06-27 Thread Tom Rini
On Thu, Jun 27, 2024 at 01:34:55PM -0600, Tom Rini wrote: > On Thu, Jun 27, 2024 at 10:25:21AM +0200, Christophe Leroy wrote: > > > Commit 340fdf1303dc ("zlib: Port fix for CVE-2016-9841 to U-Boot") > > brings a big performance regression in inflate_fast(), which leads > > to watchdog timer reset

Re: [PATCH 1/2] led: Implement software led blinking

2024-06-27 Thread Tom Rini
On Thu, Jun 27, 2024 at 02:31:13PM +0300, Mikhail Kshevetskiy wrote: > From: Michael Polyntsov > > If hardware (or driver) doesn't support leds blinking, it's > now possible to use software implementation of blinking instead. > This relies on cyclic functions. > > Signed-off-by: Michael Polynts

Re: [PATCH] zlib: Fix big performance regression

2024-06-27 Thread Tom Rini
On Thu, Jun 27, 2024 at 10:25:21AM +0200, Christophe Leroy wrote: > Commit 340fdf1303dc ("zlib: Port fix for CVE-2016-9841 to U-Boot") > brings a big performance regression in inflate_fast(), which leads > to watchdog timer reset on powerpc 8xx. > > It looks like that commit does more than what i

Re: [PATCH] Revert "zlib: Port fix for CVE-2016-9841 to U-Boot"

2024-06-27 Thread Christophe Leroy
Le 27/06/2024 à 17:49, Tom Rini a écrit : In commit 340fdf1303dc ("zlib: Port fix for CVE-2016-9841 to U-Boot") Michal brings in (correctly) the upstream fix for CVE-2016-9841. However, when upstream was fixing this issue they also removed a necessary optimization for some CPU classes as part

Re: [PATCH] bootstd: cros: store partition type in an efi_guid_t

2024-06-27 Thread Heinrich Schuchardt
Am 27. Juni 2024 19:06:29 MESZ schrieb "Vincent Stehlé" : >The scan_part() function uses a struct uuid to store the little-endian >partition type GUID, but this structure should be used only to contain a >big-endian UUID. Use an efi_guid_t instead. > >Signed-off-by: Vincent Stehlé >Cc: Simon G

Re: [PATCH] bootstd: cros: store partition type in an efi_guid_t

2024-06-27 Thread Simon Glass
On Thu, 27 Jun 2024 at 18:06, Vincent Stehlé wrote: > > The scan_part() function uses a struct uuid to store the little-endian > partition type GUID, but this structure should be used only to contain a > big-endian UUID. Use an efi_guid_t instead. > > Signed-off-by: Vincent Stehlé > Cc: Simon Gla

Re: [PATCH] CI: Make pytest export JUnitXML

2024-06-27 Thread Simon Glass
On Thu, 27 Jun 2024 at 14:43, Tom Rini wrote: > > Both GitLab and Azure (and other CI systems) have native support for > displaying JUnitXML test report results. The pytest framework that we > use can generate these reports. Change our CI tests so that they will > generate these reports and then h

Re: [PATCH 1/2] led: Implement software led blinking

2024-06-27 Thread Simon Glass
Hi Mikhail, On Thu, 27 Jun 2024 at 12:31, Mikhail Kshevetskiy wrote: > > From: Michael Polyntsov > > If hardware (or driver) doesn't support leds blinking, it's > now possible to use software implementation of blinking instead. > This relies on cyclic functions. > > Signed-off-by: Michael Polynt

Re: [PATCH] gpt: allow spaces in partition list

2024-06-27 Thread Simon Glass
Hi Mikhail, On Thu, 27 Jun 2024 at 12:29, Mikhail Kshevetskiy wrote: > > This allows spliting partition list to several lines in environment file > > ex: > > gpt_partition_list= > name=boot1,size=5MiB,start=0x10; > name=boot2,size=5MiB; > name=root

[PATCH] bootstd: cros: store partition type in an efi_guid_t

2024-06-27 Thread Vincent Stehlé
The scan_part() function uses a struct uuid to store the little-endian partition type GUID, but this structure should be used only to contain a big-endian UUID. Use an efi_guid_t instead. Signed-off-by: Vincent Stehlé Cc: Simon Glass Cc: Tom Rini --- boot/bootmeth_cros.c | 4 ++-- 1 file chang

Re: [PATCH] board/include: ti/env: j721e.env/ti_common: Fix cpsw0_qsgmii_phyinit

2024-06-27 Thread Nishanth Menon
On 15:19-20240627, Siddharth Vadapalli wrote: > The command "main_cpsw0_qsgmii_phyinit" has to be run depending on > whether or not the "do_main_cpsw0_qsgmii_phyinit" variable is set. > However, there is no support for the cases where the environment variable > &

[PATCH] Revert "zlib: Port fix for CVE-2016-9841 to U-Boot"

2024-06-27 Thread Tom Rini
In commit 340fdf1303dc ("zlib: Port fix for CVE-2016-9841 to U-Boot") Michal brings in (correctly) the upstream fix for CVE-2016-9841. However, when upstream was fixing this issue they also removed a necessary optimization for some CPU classes as part of simplifying the code. This in turn leads to

Re: [PATCH v2 2/2] usb: musb-new: sunxi: make compatible with UDC/DM gadget model

2024-06-27 Thread Andre Przywara
On Thu, 8 Jun 2023 13:56:31 -0600 Sam Edwards wrote: Hi, John asked me have a look at this. > Since many sunxi boards do not implement a `board_usb_init`, it's I am confused, what has this have to do with gadget support? *No* sunxi board build provides board_usb_init(), but apparently this wo

Re: [ANN] U-Boot v2024.07-rc5 released

2024-06-27 Thread Tom Rini
On Thu, Jun 27, 2024 at 10:23:34AM +0200, Christophe Leroy wrote: > > > Le 26/06/2024 à 17:01, Tom Rini a écrit : > > On Tue, Jun 25, 2024 at 09:20:54PM +0200, Christophe Leroy wrote: > > > > > > > > > Le 25/06/2024 à 17:19, Tom Rini a écrit : > > > > On Tue, Jun 25, 2024 at 03:12:38PM +, L

Re: [PATCH 13/14] Update u-boot.cfg to include CFG also

2024-06-27 Thread Tom Rini
On Thu, Jun 27, 2024 at 09:37:15AM +0100, Simon Glass wrote: > Hi Tom, > > On Wed, 26 Jun 2024 at 15:07, Tom Rini wrote: > > > > On Wed, Jun 26, 2024 at 09:00:41AM +0100, Simon Glass wrote: > > > Hi Tom, > > > > > > On Tue, 25 Jun 2024 at 15:14, Tom Rini wrote: > > > > > > > > On Tue, Jun 25, 20

Re: [PATCH v2 00/40] mmc: dw_mmc: Enable eMMC on E850-96 board

2024-06-27 Thread Tom Rini
On Wed, Jun 26, 2024 at 10:12:12PM +0530, Anand Moon wrote: > Hi Sam, > > On Wed, 19 Jun 2024 at 02:26, Sam Protsenko > wrote: > > > > If there are no new comments on this series, can you please apply it? > > > > Thanks! > > Tested on Odroid XU4 and Odrroid U3 boards > > Please add my > > Rev

Re: [PATCH] arm: davinci: remove unused defines

2024-06-27 Thread Tom Rini
On Wed, Jun 19, 2024 at 11:00:01AM +, Emil Kronborg wrote: > The last usage of the DV_TIMER_ and DV_WDT_ definitions were removed in > commits 8d7757637138 ("ARM: davinci: remove support for cam_enc_4xx") > and cef443c1666c ("arm: davinci: remove leftover code for dm* SoCs"), > respectively. >

Re: [PATCH] zlib: Fix big performance regression

2024-06-27 Thread Joakim Tjernlund
On Thu, 2024-06-27 at 10:25 +0200, Christophe Leroy wrote: > Commit 340fdf1303dc ("zlib: Port fix for CVE-2016-9841 to U-Boot") > brings a big performance regression in inflate_fast(), which leads > to watchdog timer reset on powerpc 8xx. > > It looks like that commit does more than what it descri

Re: [PATCH] zlib: Fix big performance regression

2024-06-27 Thread Tom Rini
On Thu, Jun 27, 2024 at 10:25:21AM +0200, Christophe Leroy wrote: > Commit 340fdf1303dc ("zlib: Port fix for CVE-2016-9841 to U-Boot") > brings a big performance regression in inflate_fast(), which leads > to watchdog timer reset on powerpc 8xx. > > It looks like that commit does more than what i

[PATCH] CI: Make pytest export JUnitXML

2024-06-27 Thread Tom Rini
Both GitLab and Azure (and other CI systems) have native support for displaying JUnitXML test report results. The pytest framework that we use can generate these reports. Change our CI tests so that they will generate these reports and then have the respective CI platform pick them up. We write to

Re: [PATCH] spl: fit: List DTOs applied by SPL in U-Boot control DT

2024-06-27 Thread Quentin Schulz
Hi Marek, On 6/27/24 1:58 AM, Marek Vasut wrote: Insert /u-boot, = property into the U-Boot control DT during SPL DTO application process. This can be used by user to inspect which DTOs got applied by the SPL and in which order from running U-Boot. Example: ``` u-boot=> fdt addr $fdtcontroladd

Re: [PATCH 1/3] net: give a different name to rtl8169 interfaces

2024-06-27 Thread Quentin Schulz
Hi Etienne, On 6/25/24 1:42 PM, Etienne Dublé wrote: Hello, Le 25/06/2024 à 12:25, Dragan Simic a écrit : Another option may be to name them "rtl8169@", with "" reflecting the PCI region address (so it is unique and stable). What do you think? I guess that's one way, I'm also wondering how

[PATCH 12/12] net/tcp: define a fallback value for rcv_wnd size

2024-06-27 Thread Mikhail Kshevetskiy
Some driver implements it's own network packet pool, so PKTBUFSRX is zero. This results in zero-size TCP receive window, so data transfer doesn't work. Avod it by setting a reasonable fallback value. Signed-off-by: Mikhail Kshevetskiy --- net/tcp.c | 6 +- 1 file changed, 5 insertions(+), 1

[PATCH 11/12] net/tcp: add support of multiple tcp connections

2024-06-27 Thread Mikhail Kshevetskiy
As we don't support ARP table in U-Boot, these connections must come from the same host. Signed-off-by: Mikhail Kshevetskiy --- net/Kconfig| 10 net/fastboot_tcp.c | 12 + net/httpd.c| 20 ++- net/netcat.c | 7 + net/tcp.c | 64 +++

[PATCH 10/12] net/tcp: simplify tcp header filling code

2024-06-27 Thread Mikhail Kshevetskiy
Signed-off-by: Mikhail Kshevetskiy --- net/tcp.c | 70 +-- 1 file changed, 37 insertions(+), 33 deletions(-) diff --git a/net/tcp.c b/net/tcp.c index a5689a892b2..9fb80f9c2a8 100644 --- a/net/tcp.c +++ b/net/tcp.c @@ -528,10 +528,37 @@ void net

[PATCH 09/12] net/httpd-upload: add web-server for file uploading

2024-06-27 Thread Mikhail Kshevetskiy
Signed-off-by: Mikhail Kshevetskiy --- cmd/Kconfig | 14 cmd/net.c | 20 ++ include/net/httpd-upload.h | 12 net/Makefile| 19 + net/httpd-upload.c | 123 net/htt

[PATCH 08/12] net/httpd: add httpd common code

2024-06-27 Thread Mikhail Kshevetskiy
This patch adds HTTP/1.1 compatible web-server that can be used by other. Server supports GET, POST, and HEAD requests. On client request it will call user specified GET/POST callback. Then results will be transmitted to client. The following restrictions exist on the POST request at the moment:

[PATCH 07/12] net/netcat: add netcat over tcp support

2024-06-27 Thread Mikhail Kshevetskiy
This patch adds downloading/uploading of data with netcat. Client/server mode both supported. Signed-off-by: Mikhail Kshevetskiy --- cmd/Kconfig | 7 ++ cmd/net.c| 34 +++-- include/net.h| 2 +- include/net/netcat.h | 20 ++ net/Makefile | 1 +

[PATCH 06/12] net/tcp: improve tcp framework, use better state machine

2024-06-27 Thread Mikhail Kshevetskiy
Changes: * Fix initial send sequence always zero issue * Use state machine close to RFC 9293. This should make TCP transfers more reliable. * Improve TCP framework a lot. This should make tcp client code much more simple. * rewrite wget with new tcp stack * rewrite fastboot_tcp with new

[PATCH 04/12] net/tcp: add connection info to tcp_stream structure

2024-06-27 Thread Mikhail Kshevetskiy
Changes: * Avoid use net_server_ip in tcp code, use tcp_stream data instead * Ignore packets from other connections if connection already created. This prevents us from connection break caused by other tcp stream. Signed-off-by: Mikhail Kshevetskiy --- include/net.h | 5 +- include/n

[PATCH 05/12] net/tcp: rename ack_edge and seq_init to more common rcv_nxt and irs

2024-06-27 Thread Mikhail Kshevetskiy
Use the names from RFC 9293 Signed-off-by: Mikhail Kshevetskiy --- include/net/tcp.h | 8 net/tcp.c | 32 2 files changed, 20 insertions(+), 20 deletions(-) diff --git a/include/net/tcp.h b/include/net/tcp.h index f224d0cae2f..0694af9d5b1 10064

[PATCH 03/12] net/tcp: preparing for multiple connections

2024-06-27 Thread Mikhail Kshevetskiy
no functional changes, just put connection specific data into a tcp_stream structure Signed-off-by: Mikhail Kshevetskiy --- include/net/tcp.h | 37 +++- net/net.c | 11 ++- net/tcp.c | 231 +++--- net/wget.c| 3 +- 4 files c

[PATCH 02/12] net/tcp: fix selective acknowledge

2024-06-27 Thread Mikhail Kshevetskiy
Current code assume that all (except last) packets are of the same size. This is definitely wrong. Replace SACK code with a new one, that does not rely on this assumption. Also this code uses less memory. Signed-off-by: Mikhail Kshevetskiy --- net/tcp.c | 200 +++-

[PATCH 01/12] net/tcp: fix TCP options processing

2024-06-27 Thread Mikhail Kshevetskiy
Current TCP code may miss an option if TCP_O_NOP option was used before it for proper aligning. Signed-off-by: Mikhail Kshevetskiy --- net/tcp.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/tcp.c b/net/tcp.c index a713e1dd609..c9bcd364ee3 100644 --- a/net/tcp.c +

Re: [PATCH v1 1/1] include: configs: tegra-common-post: make usb first boot target

2024-06-27 Thread Svyatoslav Ryhel
чт, 27 черв. 2024 р. о 14:36 Thierry Reding пише: > > On Thu Jun 27, 2024 at 12:27 PM CEST, Svyatoslav Ryhel wrote: > > вт, 18 черв. 2024 р. о 17:16 Svyatoslav пише: > > > > > > > > > > > > 18 червня 2024 р. 15:23:09 GMT+03:00, Thierry Reding > > > написав(-ла): > > > >On Tue Jun 18, 2024 at 2:

Re: [PATCH v1 1/1] include: configs: tegra-common-post: make usb first boot target

2024-06-27 Thread Thierry Reding
On Thu Jun 27, 2024 at 12:27 PM CEST, Svyatoslav Ryhel wrote: > вт, 18 черв. 2024 р. о 17:16 Svyatoslav пише: > > > > > > > > 18 червня 2024 р. 15:23:09 GMT+03:00, Thierry Reding > > написав(-ла): > > >On Tue Jun 18, 2024 at 2:00 PM CEST, Svyatoslav Ryhel wrote: > > >> This ensures that the devi

[PATCH 3/3] dm: mmc: fix driver rebinding in the case of dtb reloading

2024-06-27 Thread Mikhail Kshevetskiy
Rebinding of the mmc driver causes reregistration of block device. Thus second mmc device appears and the first becomes broken. Fix an issue by using already registered block device instead of registering a new one. Signed-off-by: Mikhail Kshevetskiy --- drivers/mmc/mmc-uclass.c | 16 ++

[PATCH 2/3] dm: core: support dtb switching without devices/drivers unloading

2024-06-27 Thread Mikhail Kshevetskiy
Consider a case when we have several similar boards but leds & buttons connected differently. Some of leds uses gpio, other pwm, third gpio over spi bitbang. Also different board may have different gpio hogs. And last but not least: board type stored inside a ubi volume. We want a single u-boot im

[PATCH 1/3] fit_dtb: relocate whole fit dtb image instead of selected dtb only

2024-06-27 Thread Mikhail Kshevetskiy
U-Boot with linked fit dtb image may be loaded by a bootloader to a low memory. On a later stage U-Boot will relocate itself and used dtb. There is no problem until we decide to reselect dtb on a later stage. In this case dtb placed in the low memory address may be selected. But this data can be o

Re: [PATCH 1/2] spi: soft_spi: fix miso gpio property name

2024-06-27 Thread Fabio Estevam
On Thu, Jun 27, 2024 at 8:31 AM Mikhail Kshevetskiy wrote: > > Signed-off-by: Mikhail Kshevetskiy > --- > drivers/spi/soft_spi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/soft_spi.c b/drivers/spi/soft_spi.c > index 0fa14339bdc..3fe62818a44 100644 > ---

Re: [PATCH 1/2] usb: dwc2: Extract USB DWC2 register definitions

2024-06-27 Thread Kongyang Liu
Marek Vasut 于2024年6月23日周日 07:49写道: > > On 5/22/24 4:22 PM, Kongyang Liu wrote: > > Hi, > > sorry for the late reply. > > > diff --git a/drivers/usb/common/dwc2_core.c b/drivers/usb/common/dwc2_core.c > > new file mode 100644 > > index 00..2fa11fd59d > > --- /dev/null > > +++ b/drivers/usb/

[PATCH 2/2] led: Add dts property to specify blinking of the led

2024-06-27 Thread Mikhail Kshevetskiy
From: Michael Polyntsov The standard property linux,default-trigger = "pattern"; used to get an effect. No blinking parameters can be set yet. Signed-off-by: Michael Polyntsov Signed-off-by: Mikhail Kshevetskiy --- drivers/led/led-uclass.c | 34 ++ 1 file

[PATCH 1/2] led: Implement software led blinking

2024-06-27 Thread Mikhail Kshevetskiy
From: Michael Polyntsov If hardware (or driver) doesn't support leds blinking, it's now possible to use software implementation of blinking instead. This relies on cyclic functions. Signed-off-by: Michael Polyntsov Signed-off-by: Mikhail Kshevetskiy --- drivers/led/Kconfig | 9 ++ driv

[PATCH] gpt: allow spaces in partition list

2024-06-27 Thread Mikhail Kshevetskiy
This allows spliting partition list to several lines in environment file ex: gpt_partition_list= name=boot1,size=5MiB,start=0x10; name=boot2,size=5MiB; name=rootfs1,size=70MiB; name=rootfs2,size=70MiB; name=overlay1,size=20MiB;

[PATCH 3/3] cmd: mtd: add nandtest command support

2024-06-27 Thread Mikhail Kshevetskiy
This patch implements readonly test of nand flashes. Signed-off-by: Mikhail Kshevetskiy --- cmd/Kconfig | 6 ++ cmd/mtd.c | 203 2 files changed, 209 insertions(+) diff --git a/cmd/Kconfig b/cmd/Kconfig index 0685b598679..d5cc6de93cd 1006

[PATCH 2/3] cmd: mtd: add torture command support

2024-06-27 Thread Mikhail Kshevetskiy
Some nand flashes (like spi-nand one) are registered with mtd subsystem only, thus nand command can't be used to work with such flashes. As result some functionality is missing. This patch implements 'nand torture' functionality for mtd command. Signed-off-by: Mikhail Kshevetskiy --- cmd/Kconfi

[PATCH 1/3] cmd: mtd: add markbad command support

2024-06-27 Thread Mikhail Kshevetskiy
Some nand flashes (like spi-nand one) are registered with mtd subsystem only, thus nand command can't be used to work with such flashes. As result some functionality is missing. This patch implements 'nand markbad' functionality for mtd command. Signed-off-by: Mikhail Kshevetskiy --- cmd/Kconfi

[PATCH 2/2] spi: soft_spi: Parse cs-gpios only if num-chipselects is not <0>

2024-06-27 Thread Mikhail Kshevetskiy
From: Michael Polyntsov Some boards don't have chipselect lines for leds so cs-gpios is not specified in the dts leading to probing error. Fix it by making behavior similar to the one in Linux, parse num-chipselects and if it is zero, ignore cs-gpios. Signed-off-by: Michael Polyntsov Signed-off

[PATCH 1/2] spi: soft_spi: fix miso gpio property name

2024-06-27 Thread Mikhail Kshevetskiy
Signed-off-by: Mikhail Kshevetskiy --- drivers/spi/soft_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/soft_spi.c b/drivers/spi/soft_spi.c index 0fa14339bdc..3fe62818a44 100644 --- a/drivers/spi/soft_spi.c +++ b/drivers/spi/soft_spi.c @@ -272,7 +272,7 @@ sta

[PATCH 6/7] mtd: spinand: sync supported flashes with linux-6.6

2024-06-27 Thread Mikhail Kshevetskiy
Signed-off-by: Mikhail Kshevetskiy --- drivers/mtd/nand/spi/Makefile | 4 +- drivers/mtd/nand/spi/alliancememory.c | 155 + drivers/mtd/nand/spi/ato.c| 84 drivers/mtd/nand/spi/core.c | 4 +- drivers/mtd/nand/spi/esmt.c

[PATCH 7/7] mtd: spinand: add Winbond W25N04KV flash support

2024-06-27 Thread Mikhail Kshevetskiy
Signed-off-by: Mikhail Kshevetskiy --- drivers/mtd/nand/spi/winbond.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/mtd/nand/spi/winbond.c b/drivers/mtd/nand/spi/winbond.c index 5fe35e35ed5..f38ae95c570 100644 --- a/drivers/mtd/nand/spi/winbond.c +++ b/drivers/mtd/nand/spi/

[PATCH 5/7] mtd: nand: add initial ecc engine support

2024-06-27 Thread Mikhail Kshevetskiy
just now only spinand on_die ecc is supported Signed-off-by: Mikhail Kshevetskiy --- drivers/mtd/nand/Makefile | 2 +- drivers/mtd/nand/core.c | 130 +++- drivers/mtd/nand/ecc.c | 150 ++ drivers/mtd/nand/spi/core.c | 206 +

[PATCH 4/7] mtd: spinand: preparation for ecc engine adding

2024-06-27 Thread Mikhail Kshevetskiy
Signed-off-by: Mikhail Kshevetskiy --- drivers/mtd/nand/spi/core.c | 259 +--- 1 file changed, 151 insertions(+), 108 deletions(-) diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c index 8664e882753..1b2eefc9041 100644 --- a/drivers/mtd/nand/s

[PATCH 3/7] mtd: spinand: simulate behavior of linux's function spinand_wait()

2024-06-27 Thread Mikhail Kshevetskiy
also call schedule() to allow periodic actions Signed-off-by: Mikhail Kshevetskiy --- drivers/mtd/nand/spi/core.c | 35 --- include/linux/mtd/spinand.h | 22 ++ 2 files changed, 50 insertions(+), 7 deletions(-) diff --git a/drivers/mtd/nand/sp

[PATCH 2/7] mtd: spinand: Add a NAND page I/O request type

2024-06-27 Thread Mikhail Kshevetskiy
Use an enum to differentiate the type of I/O (reading or writing a page). Also update the request iterator. This is a port of linux patch 701981cab01696584a12e5f0e7c2ad931a326059 created by Miquel Raynal Signed-off-by: Mikhail Kshevetskiy --- drivers/mtd/nand/spi/core.c | 4 ++-- include/linu

[PATCH 1/7] mtd: spinand: Use the spi-mem dirmap API

2024-06-27 Thread Mikhail Kshevetskiy
Make use of the spi-mem direct mapping API to let advanced controllers optimize read/write operations when they support direct mapping. This is a port of linux patch 981d1aa0697ce1393e00933f154d181e965703d0 created by Boris Brezillon . Signed-off-by: Mikhail Kshevetskiy --- drivers/mtd/nand/spi

[PATCH] net/tftp: make tftpput working with servers that do not use OACK

2024-06-27 Thread Mikhail Kshevetskiy
Signed-off-by: Mikhail Kshevetskiy --- net/tftp.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/net/tftp.c b/net/tftp.c index 2e335413492..2534dec1c9f 100644 --- a/net/tftp.c +++ b/net/tftp.c @@ -494,8 +494,15 @@ static void tftp_handler(uchar *pkt, unsigned dest, st

[PATCH 01/79] net/tftp: make tftpput working with servers that do not use OACK

2024-06-27 Thread Mikhail Kshevetskiy
Signed-off-by: Mikhail Kshevetskiy --- net/tftp.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/net/tftp.c b/net/tftp.c index 2e335413492..2534dec1c9f 100644 --- a/net/tftp.c +++ b/net/tftp.c @@ -494,8 +494,15 @@ static void tftp_handler(uchar *pkt, unsigned dest, st

Re: [PATCH 1/4] power: regulator: Trigger probe of regulators which are always-on or boot-on

2024-06-27 Thread Simon Glass
Hi Svyatoslav, On Thu, 27 Jun 2024 at 11:34, Svyatoslav Ryhel wrote: > > чт, 27 черв. 2024 р. о 12:26 Simon Glass пише: > > > > Hi Svyatoslav, > > > > On Thu, 27 Jun 2024 at 10:09, Svyatoslav wrote: > > > > > > > > > > > > 27 червня 2024 р. 11:48:46 GMT+03:00, Caleb Connolly > > > написав(-ла

Re: [PATCH 1/4] power: regulator: Trigger probe of regulators which are always-on or boot-on

2024-06-27 Thread Svyatoslav Ryhel
чт, 27 черв. 2024 р. о 12:26 Simon Glass пише: > > Hi Svyatoslav, > > On Thu, 27 Jun 2024 at 10:09, Svyatoslav wrote: > > > > > > > > 27 червня 2024 р. 11:48:46 GMT+03:00, Caleb Connolly > > написав(-ла): > > > > > > > > >On 27/06/2024 10:37, Simon Glass wrote: > > >> Hi Marek, > > >> > > >> On

Re: [PATCH 1/4] power: regulator: Trigger probe of regulators which are always-on or boot-on

2024-06-27 Thread Simon Glass
Hi Caleb, On Thu, 27 Jun 2024 at 09:48, Caleb Connolly wrote: > > > > On 27/06/2024 10:37, Simon Glass wrote: > > Hi Marek, > > > > On Thu, 27 Jun 2024 at 00:57, Marek Vasut wrote: > >> > >> In case a regulator DT node contains regulator-always-on or > >> regulator-boot-on > >> property, make s

Re: [PATCH 1/4] power: regulator: Trigger probe of regulators which are always-on or boot-on

2024-06-27 Thread Simon Glass
Hi Svyatoslav, On Thu, 27 Jun 2024 at 10:09, Svyatoslav wrote: > > > > 27 червня 2024 р. 11:48:46 GMT+03:00, Caleb Connolly > написав(-ла): > > > > > >On 27/06/2024 10:37, Simon Glass wrote: > >> Hi Marek, > >> > >> On Thu, 27 Jun 2024 at 00:57, Marek Vasut wrote: > >>> > >>> In case a regulat

Re: [PATCH 1/4] power: regulator: Trigger probe of regulators which are always-on or boot-on

2024-06-27 Thread Svyatoslav
27 червня 2024 р. 11:48:46 GMT+03:00, Caleb Connolly написав(-ла): > > >On 27/06/2024 10:37, Simon Glass wrote: >> Hi Marek, >> >> On Thu, 27 Jun 2024 at 00:57, Marek Vasut wrote: >>> >>> In case a regulator DT node contains regulator-always-on or >>> regulator-boot-on >>> property, make s

Re: [PATCH 1/4] power: regulator: Trigger probe of regulators which are always-on or boot-on

2024-06-27 Thread Caleb Connolly
On 27/06/2024 10:37, Simon Glass wrote: Hi Marek, On Thu, 27 Jun 2024 at 00:57, Marek Vasut wrote: In case a regulator DT node contains regulator-always-on or regulator-boot-on property, make sure the regulator gets correctly configured by U-Boot on start up. Unconditionally probe such reg

Re: [PATCH 2/4] power: regulator: Convert regulators_enable_boot_on/off() to regulator_post_probe

2024-06-27 Thread Simon Glass
Hi Marek, On Thu, 27 Jun 2024 at 00:57, Marek Vasut wrote: > > Turn regulators_enable_boot_on() and regulators_enable_boot_off() into > empty functions. Implement matching functionality in regulator_post_probe() > instead. The regulator_post_probe() is called for all regulators after they > prob

Re: [PATCH 1/4] power: regulator: Trigger probe of regulators which are always-on or boot-on

2024-06-27 Thread Simon Glass
Hi Marek, On Thu, 27 Jun 2024 at 00:57, Marek Vasut wrote: > > In case a regulator DT node contains regulator-always-on or regulator-boot-on > property, make sure the regulator gets correctly configured by U-Boot on start > up. Unconditionally probe such regulator drivers. This is a preparatory p

[PATCH] net: ftgmac100: Fixed the cache coherency issues of rx memory

2024-06-27 Thread Jacky Chou
When executing TFTP, the ARP will be replied to after receiving the ARP. U-boot's ARP routine modifies the data in the receive packet in response to the ARP packet and then copies it into the transmit packet. At this point, the received packet cache is inconsistent. It is possible that the cache wi

Re: [PATCH v1] board: mpfs_icicle: implement board_fdt_blob_setup()

2024-06-27 Thread Simon Glass
Hi Connor, On Thu, 27 Jun 2024 at 10:38, Conor Dooley wrote: > > On Thu, Jun 27, 2024 at 09:36:49AM +0100, Simon Glass wrote: > > > > On Tue, 25 Jun 2024 at 15:34, Tom Rini wrote: > > > > > > On Tue, Jun 25, 2024 at 10:08:06AM +0100, Conor Dooley wrote: > > > > > > > The firmware on the Icicle i

Re: [PATCH v1 1/1] include: configs: tegra-common-post: make usb first boot target

2024-06-27 Thread Svyatoslav Ryhel
вт, 18 черв. 2024 р. о 17:16 Svyatoslav пише: > > > > 18 червня 2024 р. 15:23:09 GMT+03:00, Thierry Reding > написав(-ла): > >On Tue Jun 18, 2024 at 2:00 PM CEST, Svyatoslav Ryhel wrote: > >> This ensures that the device can boot from a USB device prior to MMC. > >> Useful > >> cases are when i

[PATCH] Proposed changes to dynamic UUIDs v3

2024-06-27 Thread Vincent Stehlé
Here are the changes that I would like to suggest for the "efi: CapsuleUpdate: support for dynamic UUIDs" v3 patch series: - Convert from big-endian UUID to little-endian GUID in efi_capsule_update_info_gen_ids(). - Fix tmp size and masking in gen_uuid_v5(). - Use UUID_STR_FORMAT_STD in all pl

[PATCH] board/include: ti/env: j721e.env/ti_common: Fix cpsw0_qsgmii_phyinit

2024-06-27 Thread Siddharth Vadapalli
The command "main_cpsw0_qsgmii_phyinit" has to be run depending on whether or not the "do_main_cpsw0_qsgmii_phyinit" variable is set. However, there is no support for the cases where the environment variable "do_main_cpsw0_qsgmii_phyinit" is updated at runtime. On J721E, the value of "do_main_cpsw0

Re: [PATCH v1] board: mpfs_icicle: implement board_fdt_blob_setup()

2024-06-27 Thread Conor Dooley
On Thu, Jun 27, 2024 at 09:36:49AM +0100, Simon Glass wrote: > > On Tue, 25 Jun 2024 at 15:34, Tom Rini wrote: > > > > On Tue, Jun 25, 2024 at 10:08:06AM +0100, Conor Dooley wrote: > > > > > The firmware on the Icicle is capable of providing a devicetree in a1 to > > > U-Boot, but until now the d

Re: [PATCH v5 14/16] rockchip: Avoid #ifdefs in RK3399 SPL

2024-06-27 Thread Simon Glass
Hi Jonas, On Thu, 27 Jun 2024 at 10:00, Jonas Karlman wrote: > > Hi Simon, > > On 2024-06-27 10:02, Simon Glass wrote: > > Hi Jonas, > > > > On Wed, 26 Jun 2024 at 17:16, Jonas Karlman wrote: > >> > >> Hi Simon, > >> > >> On 2024-06-26 17:59, Simon Glass wrote: > >>> The code here is confusing d

[PATCH v6 8/8] rockchip: Avoid #ifdefs in RK3399 SPL

2024-06-27 Thread Simon Glass
The code here is confusing due to large blocks which are #ifdefed out. Add a function phase_sdram_init() which returns whether SDRAM init should happen in the current phase, using that as needed to control the code flow. This increases code size by about 500 bytes in SPL when the cache is on, sinc

[PATCH v6 7/8] rockchip: Ensure memory size is available in RK3399 SPL

2024-06-27 Thread Simon Glass
At present gd->ram_size is 0 in SPL, meaning that it is not possible to enable the cache. Correct this by always populating the RAM size correctly. This increases code size by about 500 bytes in SPL, since it must call the rather large rockchip_sdram_size() function. Signed-off-by: Simon Glass R

[PATCH v6 6/8] fdt: Correct condition for bloblist existing

2024-06-27 Thread Simon Glass
On some boards, the bloblist is created in SPL once SDRAM is ready. It cannot be accessed until that point, so is not available early in SPL. Add a condition to avoid a hang in this case. This fixes a hang in chromebook_coral Fixes: 70fe2385943 ("fdt: Allow the devicetree to come from a bloblist

[PATCH v6 5/8] binman: Keep the efi_capsule input file

2024-06-27 Thread Simon Glass
There is no need to remove input files. It makes it harder to diagnose failures. Keep the payload file. There is no test for this condition, but one could be added. Signed-off-by: Simon Glass Acked-by: Sughosh Ganu --- (no changes since v4) Changes in v4: - Drop Fixes tag tools/binman/etype

[PATCH v6 4/8] binman: Return failure when a usage() message is generated

2024-06-27 Thread Simon Glass
The tool must return an error code when invalid arguments are provided, otherwise binman has no way of knowing that anything went wrong. Correct this. Signed-off-by: Simon Glass Fixes: fab430be2f4 ("tools: add mkeficapsule command for UEFI...") --- (no changes since v1) tools/mkeficapsule.c |

[PATCH v6 3/8] binman: Deal with mkeficapsule being missing

2024-06-27 Thread Simon Glass
Tools cannot be assumed to be present. Add a check for this with the mkeficpasule tool. Signed-off-by: Simon Glass Fixes: b617611b27a ("binman: capsule: Add support for generating...") --- (no changes since v1) tools/binman/etype/efi_capsule.py | 4 1 file changed, 4 insertions(+) diff -

[PATCH v6 2/8] binman: Collect the version number for mkeficapsule

2024-06-27 Thread Simon Glass
Now that this tool has a version number, collect it. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/btool/mkeficapsule.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/binman/btool/mkeficapsule.py b/tools/binman/btool/mkeficapsule.py index ef1d

[PATCH v6 0/8] Second part of bug-fixes series

2024-06-27 Thread Simon Glass
This consists of some patches split ouf from an earlier series [1]. Apart from the fdt patch they are not needed for the upcoming release. The FDT patch fixes a boot problem on several Chromebooks. [1] https://patchwork.ozlabs.org/project/uboot/patch/20240626155945.278640-15-...@chromium.org/ C

[PATCH v6 1/8] mkeficapsule: Add a --version argument

2024-06-27 Thread Simon Glass
Tools should have an option to obtain the version, so add this to the mkeficapsule tool. Signed-off-by: Simon Glass --- (no changes since v1) doc/mkeficapsule.1 | 4 tools/mkeficapsule.c | 8 +++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/doc/mkeficapsule.1 b/do

Re: [PATCH v5 14/16] rockchip: Avoid #ifdefs in RK3399 SPL

2024-06-27 Thread Jonas Karlman
Hi Simon, On 2024-06-27 10:02, Simon Glass wrote: > Hi Jonas, > > On Wed, 26 Jun 2024 at 17:16, Jonas Karlman wrote: >> >> Hi Simon, >> >> On 2024-06-26 17:59, Simon Glass wrote: >>> The code here is confusing due to large blocks which are #ifdefed out. >>> Add a function phase_sdram_init() whic

Re: [PATCH v3 08/19] test: Introduce the concept of a role

2024-06-27 Thread Simon Glass
Hi Tom, On Wed, 26 Jun 2024 at 15:29, Tom Rini wrote: > > On Wed, Jun 26, 2024 at 09:00:33AM +0100, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 25 Jun 2024 at 15:27, Tom Rini wrote: > > > > > > On Tue, Jun 25, 2024 at 01:38:08PM +0100, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Mon

  1   2   >