Re: [PATCH v3 16/18] rockchip: Avoid #ifdefs in RK3399 SPL

2024-06-21 Thread Kever Yang
Hi Simon, On 2024/6/21 22:57, Simon Glass wrote: Hi Jonas, On Fri, 21 Jun 2024 at 00:45, Jonas Karlman wrote: Hi Simon, On 2024-06-21 01:06, Simon Glass wrote: The code here is confusing due to large blocks which are #ifdefed out. Add a function phase_sdram_init() which returns whether SDRA

USB gadget device (USB_ETHER) with ChipIdea device controller (imx)

2024-06-21 Thread Tim Harvey
Greetings, Is anyone successfully using USB gadget device (USB_ETHER) on any imx that has the ChipIdea device controller? (imx6/imx7/imx8mm): I've never been able to get this to work as when usb_setup_ehci_gadget() is called from ci_udc's usb_gadget_register_driver() it first removes the usb cont

Re: [PATCH v2 2/9] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-21 Thread Tom Rini
On Fri, Jun 21, 2024 at 01:38:07PM -0600, Simon Glass wrote: > Hi Tom, > > On Fri, 21 Jun 2024 at 13:19, Tom Rini wrote: > > > > On Fri, Jun 21, 2024 at 11:55:42AM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Fri, 21 Jun 2024 at 10:05, Tom Rini wrote: > > [snip] > > > > Yes, I very muc

Re: [PATCH 3/5] buildman: Support building within a Python venv

2024-06-21 Thread Tom Rini
On Fri, Jun 21, 2024 at 01:39:46PM -0600, Simon Glass wrote: > Hi Tom, > > On Fri, 21 Jun 2024 at 13:26, Tom Rini wrote: > > > > On Fri, Jun 21, 2024 at 12:19:12PM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Fri, 21 Jun 2024 at 09:22, Tom Rini wrote: > > > > > > > > On Fri, Jun 21, 20

[PATCH 11/11] buildman: Add a way to limit the number of buildmans

2024-06-21 Thread Simon Glass
Buildman uses all available CPUs by default, so running more than one or two concurrent processes is not normally useful. However in some CI cases we want to be able to run several jobs at once to save time. For example, in a lab situation we may want to run a test on 20 boards at a time, since on

[PATCH 09/11] buildman: Add a flag to force mrproper on failure

2024-06-21 Thread Simon Glass
When a file is removed by a commit (e.g. include/common.h yay!) it can cause incremental build failures since one of the dependency files from a previous build may mention the file. Add an option to run 'make mrproper' automatically when a build fails. This can be used to automatically resolve the

[PATCH 10/11] buildman: Retry the build for current source

2024-06-21 Thread Simon Glass
Buildman retries a failed build when processing a branch, but does not do this when building current source. It is useful to do this retry in both cases, so add the logic for it. Signed-off-by: Simon Glass --- tools/buildman/builderthread.py | 8 1 file changed, 8 insertions(+) diff -

[PATCH 07/11] buildman: Make mrproper an argument to run_commit()

2024-06-21 Thread Simon Glass
Pass this in so the caller can change it independently of the member variable. Signed-off-by: Simon Glass --- tools/buildman/builderthread.py | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py

[PATCH 08/11] buildman: Avoid rebuilding when --mrproper is used

2024-06-21 Thread Simon Glass
When this flag is enabled, 'make mrproper' is always used when reconfiguring, so there is no point in doing it again. Update this. Signed-off-by: Simon Glass --- tools/buildman/builderthread.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/buildman/builderthread.py

[PATCH 06/11] buildman: Make mrproper an argument to _config_and_build()

2024-06-21 Thread Simon Glass
Pass this in so the caller can change it independently of the member variable. Signed-off-by: Simon Glass --- tools/buildman/builderthread.py | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py index 5d

[PATCH 04/11] binman: Update the entrydocs header

2024-06-21 Thread Simon Glass
Reduce the length of the underline for this header, to match the heading itself. Signed-off-by: Simon Glass --- tools/binman/entry.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/binman/entry.py b/tools/binman/entry.py index 42e0b7b9145..2ed65800d22 100644 --- a/too

[PATCH 01/11] binman: efi: Correct entry docs

2024-06-21 Thread Simon Glass
Somehow the class documentation has got out of sync with the generated entries.rst file. Regenerating it causes errors, so correct these and regenerate the entries.rst file. Signed-off-by: Simon Glass Fixes: 809f28e7213 ("binman: capsule: Use dumped capsule header...") --- tools/binman/entries.

[PATCH 05/11] buildman: Make mrproper an argument to _reconfigure()

2024-06-21 Thread Simon Glass
Pass this in so the caller can change it independently of the member variable. Signed-off-by: Simon Glass --- tools/buildman/builderthread.py | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py index a8599

[PATCH 03/11] binman: ti: Regenerate entry docs

2024-06-21 Thread Simon Glass
Correct formatting errors in the documentation. Regenerate the entries.rst file to include this recent addition. Signed-off-by: Simon Glass --- tools/binman/entries.rst| 35 + tools/binman/etype/ti_secure.py | 45 + 2 files change

[PATCH 02/11] binman: Regenerate nxp docs

2024-06-21 Thread Simon Glass
Regenerate the entries.rst file to include this recent addition. Note that more docs are needed here, to actually describe the entry type. Note also that the entry type needs Binman tests added. Signed-off-by: Simon Glass --- tools/binman/entries.rst | 22 ++ 1 file change

[PATCH 00/11] Tools updates for Labgrid

2024-06-21 Thread Simon Glass
This series includes patches to update buildman to support Labgrid better and some minor binman fixes. Simon Glass (11): binman: efi: Correct entry docs binman: Regenerate nxp docs binman: ti: Regenerate entry docs binman: Update the entrydocs header buildman: Make mrproper an argument

Re: [PATCH v2 00/43] labgrid: Provide an integration with Labgrid

2024-06-21 Thread Simon Glass
Hi Tom, OK will do. One I have already split out ("Bug-fixes for a few boards") so I'll split out a few more. REgards, Simon On Fri, 21 Jun 2024 at 14:07, Tom Rini wrote: > > On Fri, Jun 21, 2024 at 01:51:21PM -0600, Simon Glass wrote: > > > Labgrid provides access to a hardware lab in an auto

[PATCH] doc: board: ti: Add capsule documentation for TI K3 devices

2024-06-21 Thread Jonathan Humphreys
Added introductory documentation about capsule support for TI devices, including links to more detailed information. Also added a note in the build secction that points to the host package dependency docs. This patch is followup from a request in the series introducing capsule update for TI board

Re: [PATCH v2 00/43] labgrid: Provide an integration with Labgrid

2024-06-21 Thread Tom Rini
On Fri, Jun 21, 2024 at 01:51:21PM -0600, Simon Glass wrote: > Labgrid provides access to a hardware lab in an automated way. It is > possible to boot U-Boot on boards in the lab without physically touching > them. It relies on relays, USB UARTs and SD muxes, among other things. > > By way of bac

[PATCH v2 43/43] CI: Allow running tests on sjg lab

2024-06-21 Thread Simon Glass
Add a way to run tests on a real hardware lab. This is in the very early experimental stages. There are only 23 boards and 3 of those are broken! (bob, ff3399, samus). A fourth fails due to problems with the TPM tests. To try this, assuming you have gitlab access, set SJG_LAB=1, e.g.: git push

[PATCH v2 42/43] Update u-boot.cfg to include CFG also

2024-06-21 Thread Simon Glass
Some configuration is now in variables with a CFG_ prefix. Add these to the .cfg file so that we can see everything in one place. Sort the options so they are easier to find and compare. Signed-off-by: Simon Glass --- Changes in v2: - Add new patch to update u-boot.cfg with CFG_... options scr

[PATCH v2 41/43] test: Add a section for closing the connection

2024-06-21 Thread Simon Glass
This can take a while and involve multiple steps (e.g. turning the board back off). Add a section for it and show the output. Signed-off-by: Simon Glass --- (no changes since v1) test/py/u_boot_console_base.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/test/py/u_bo

[PATCH v2 40/43] test: Try to shut down the lab console gracefully

2024-06-21 Thread Simon Glass
Send the Labgrid quit characters to ask it to exit gracefully. This typically allows it to power off the board being used. If that doesn't work, try the less graceful approach. Signed-off-by: Simon Glass --- (no changes since v1) test/py/u_boot_spawn.py | 17 +++-- 1 file changed,

[PATCH v2 39/43] test: Avoid double echo when starting up

2024-06-21 Thread Simon Glass
There is a very annoying bug at present where the terminal echos part of the first command sent to the board. This happens because the terminal is still set to echo for a period until Labgrid starts up and can change this. Fix this by disabling echo (and other terminal features) as soon as the spa

[PATCH v2 38/43] test: Fix mulptiplex_log typo

2024-06-21 Thread Simon Glass
Fix a typo in a comment. Signed-off-by: Simon Glass --- (no changes since v1) test/py/u_boot_console_base.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/py/u_boot_console_base.py b/test/py/u_boot_console_base.py index eda48cd35f7..1b00821c5e9 100644 --- a/test/py/u

[PATCH v2 37/43] test: Improve handling of sending commands

2024-06-21 Thread Simon Glass
We expect commands to be echoed and this should happen quite quickly, since U-Boot is sitting at the prompt waiting for a command. Reduce the timeout for this situation. Try to produce a more useful error message when something goes wrong. Also handle the case where the connection has gone away si

[PATCH v2 36/43] test: Introduce lab mode

2024-06-21 Thread Simon Glass
There is quite a bit of code in pytest to try to start up U-Boot on a board, with timeouts, expects, etc. This is tedious to maintain and is peripheral to the test system's purpose. It seems better to put this logic in the lab itself, where is can provide such support. With Labgrid we can use the

[PATCH v2 35/43] test: Tidy up remaining exceptions

2024-06-21 Thread Simon Glass
Use the new handle_exception() function from ConsoleBase also. Signed-off-by: Simon Glass --- (no changes since v1) test/py/u_boot_console_base.py | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/test/py/u_boot_console_base.py b/test/py/u_boot_console_base.py in

[PATCH v2 34/43] test: Detect dead connections

2024-06-21 Thread Simon Glass
When the connection to a board dies, assume it is dead forever until some user action is taken. Skip all remaining tests. This avoids CI runs taking an hour, with hundreds of 30-second timeouts all to no avail. Signed-off-by: Simon Glass --- (no changes since v1) test/py/conftest.py | 19 +

[PATCH v2 33/43] test: Separate out the exception handling

2024-06-21 Thread Simon Glass
The tests currently catch a very board Exception in each case. This is thrown even in the event of a coding error. We want to handle exceptions differently depending on their severity, so that we can avoid hour-long delays waiting for a board that is clearly broken. As a first step, create some n

[PATCH v2 32/43] test: Move the receive code into a function

2024-06-21 Thread Simon Glass
There is quite a bit of code to deal with receiving data from the target so move it into its own receive() function. Signed-off-by: Simon Glass --- (no changes since v1) test/py/u_boot_spawn.py | 39 +++ 1 file changed, 27 insertions(+), 12 deletions(-) dif

[PATCH v2 31/43] test: Introduce the concept of a role

2024-06-21 Thread Simon Glass
In Labgrid there is the concept of a 'role', which is similar to the U-Boot board ID in U-Boot's pytest subsystem. The role indicates both the target and information about the U-Boot build to use. It can also provide any amount of other configuration. The information is obtained using the 'labgrid

[PATCH v2 30/43] test: Create a common function to get the config

2024-06-21 Thread Simon Glass
The settings are decoded in two places. Combine them into a new function, before (in a future patch) expanding the number of items. Signed-off-by: Simon Glass --- (no changes since v1) test/py/conftest.py | 41 - 1 file changed, 28 insertions(+), 13 dele

[PATCH v2 29/43] test: Check help output

2024-06-21 Thread Simon Glass
The current test doesn't check anything about the output. If a bug results in junk before the output, this is not currently detected. Add a check for the first line being the one expected. Signed-off-by: Simon Glass --- (no changes since v1) test/py/tests/test_help.py | 6 +- 1 file chang

[PATCH v2 28/43] test: dm: Show failing driver name

2024-06-21 Thread Simon Glass
When a driver is not registered properly it is not clear which one it is. Adjust test_dm_compat() to show this. Signed-off-by: Simon Glass --- (no changes since v1) test/py/tests/test_dm.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/test/py/tests/test_dm.py b/test/

[PATCH v2 27/43] test: Avoid failing skipped tests

2024-06-21 Thread Simon Glass
When a test returns -EAGAIN this should not be considered a failure. Fix what seems to be a problem case, where the pytests see a failure when a test has merely been skipped. Signed-off-by: Simon Glass --- (no changes since v1) test/test-main.c | 16 +++- 1 file changed, 11 inserti

[PATCH v2 26/43] test: Decode exceptions only with sandbox

2024-06-21 Thread Simon Glass
When a real board fails we don't want to decode the exception. Reserve that behaviour for sandbox. Also avoid raising a new exception on failure - just re-raise the existing one. Signed-off-by: Simon Glass --- (no changes since v1) test/py/u_boot_console_sandbox.py | 2 +- test/py/u_boot_spaw

[PATCH v2 25/43] test: Allow connecting to a running board

2024-06-21 Thread Simon Glass
Sometimes we know that the board is already running the right software, so provide an option to allow running of tests directly, without first resetting the board. This saves time when re-running a test where only the Python code is changing. Signed-off-by: Simon Glass --- (no changes since v1)

[PATCH v2 24/43] log: Allow tests to pass with CONFIG_LOGF_FUNC_PAD set

2024-06-21 Thread Simon Glass
This setting pads out the function names. Adjust the test to handle this, since some boards use it. Signed-off-by: Simon Glass --- (no changes since v1) test/py/tests/test_log.py | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/test/py/tests/test_log.py b/test/py

[PATCH v2 23/43] test: Release board after tests complete

2024-06-21 Thread Simon Glass
When a board is finished with, the lab may want to power it off, or perform some other function. Add a new script which is called when tests are complete. Signed-off-by: Simon Glass --- (no changes since v1) test/py/u_boot_console_exec_attach.py | 10 ++ 1 file changed, 10 insertions(+

[PATCH v2 22/43] test: Pass stderr to stdout

2024-06-21 Thread Simon Glass
Some tests may output things to stderr. Ensure that this output is not dropped, by redirecting it to stdout Signed-off-by: Simon Glass --- (no changes since v1) test/py/u_boot_spawn.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/py/u_boot_spawn.py b/test/py/u_boot_spawn.py index

[PATCH v2 21/43] test: Use a constant for the test timeout

2024-06-21 Thread Simon Glass
Declare a constant rather than open-coding the same value twice. Signed-off-by: Simon Glass --- (no changes since v1) test/py/u_boot_console_base.py | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/test/py/u_boot_console_base.py b/test/py/u_boot_console_base.py index

[PATCH v2 20/43] test: Make bootstd init run only on sandbox

2024-06-21 Thread Simon Glass
Tests for standard boot need disks to be set up, which can only be done on sandbox, since adjusting disks on real hardware is not currently supported. Mark the init function as sandbox-only. Signed-off-by: Simon Glass --- (no changes since v1) test/py/tests/test_ut.py | 1 + 1 file changed, 1

[PATCH v2 19/43] test: Allow signaling that U-Boot is ready

2024-06-21 Thread Simon Glass
When Labgrid is used, it can get U-Boot ready for running tests. It prints a message when it has done so. Add logic to detect this message and accept it. Signed-off-by: Simon Glass --- (no changes since v1) test/py/u_boot_console_base.py | 9 + 1 file changed, 5 insertions(+), 4 delet

[PATCH v2 18/43] meson: Correct driver declaration for meson_axg_gpio

2024-06-21 Thread Simon Glass
This should use the driver macros so that the driver appears in the linker list. Fix this. Fixes: 8587839f19d ("pinctrl: meson: add axg support") Reviewed-by: Neil Armstrong Signed-off-by: Simon Glass --- (no changes since v1) drivers/pinctrl/meson/pinctrl-meson-axg-pmx.c | 2 +- drivers/pin

[PATCH v2 17/43] google: Disable TPMv2 on most Chromebooks

2024-06-21 Thread Simon Glass
This feature is not present on older Chromebooks, so disable the setting. Signed-off-by: Simon Glass Reviewed-by: Ilias Apalodimas --- (no changes since v1) configs/chromebook_link64_defconfig| 1 + configs/chromebook_link_defconfig | 1 + configs/chromebook_samus_defconfig | 1 +

[PATCH v2 16/43] sunxi: Mark scp as optional

2024-06-21 Thread Simon Glass
This binary does not prevent the system from booting. Mark it optional so that U-Boot can be built without it. Signed-off-by: Simon Glass --- (no changes since v1) arch/arm/dts/sunxi-u-boot.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/dts/sunxi-u-boot.dtsi b/arch/arm/dts/s

[PATCH v2 15/43] am33xx: Provide a function to set up the debug UART

2024-06-21 Thread Simon Glass
Since commit 0dba45864b2a ("arm: Init the debug UART") the debug UART is set up in _main() before early_system_init() is called. Add a suitable board_debug_uart_init() function to set up the UART in SPL. Signed-off-by: Simon Glass --- (no changes since v1) arch/arm/mach-omap2/am33xx/board.c |

[PATCH v2 14/43] initcall: Correct use of relocation offset

2024-06-21 Thread Simon Glass
The relocation offset can change in some initcall sequences. Handle this and make sure it is used for all debugging statements in init_run_list() Update the trace test to match. Signed-off-by: Simon Glass Reviewed-by: Caleb Connolly --- (no changes since v1) lib/initcall.c | 6 +

[PATCH v2 13/43] dm: core: Enhance comments on bind_drivers_pass()

2024-06-21 Thread Simon Glass
This part of driver model is a little subtle, so add some more comments to promote better understanding. Signed-off-by: Simon Glass --- (no changes since v1) drivers/core/lists.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/core/lists.c b/drivers/core/lists.c i

[PATCH v2 12/43] buildman: Add a way to limit the number of buildmans

2024-06-21 Thread Simon Glass
Buildman uses all available CPUs by default, so running more than one or two concurrent processes is not normally useful. However in some CI cases we want to be able to run several jobs at once to save time. For example, in a lab situation we may want to run a test on 20 boards at a time, since on

[PATCH v2 11/43] buildman: Retry the build for current source

2024-06-21 Thread Simon Glass
Buildman retries a failed build when processing a branch, but does not do this when building current source. It is useful to do this retry in both cases, so add the logic for it. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 8 1 file changed,

[PATCH v2 10/43] buildman: Add a flag to force mrproper on failure

2024-06-21 Thread Simon Glass
When a file is removed by a commit (e.g. include/common.h yay!) it can cause incremental build failures since one of the dependency files from a previous build may mention the file. Add an option to run 'make mrproper' automatically when a build fails. This can be used to automatically resolve the

[PATCH v2 09/43] buildman: Avoid rebuilding when --mrproper is used

2024-06-21 Thread Simon Glass
When this flag is enabled, 'make mrproper' is always used when reconfiguring, so there is no point in doing it again. Update this. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/bui

[PATCH v2 08/43] buildman: Make mrproper an argument to run_commit()

2024-06-21 Thread Simon Glass
Pass this in so the caller can change it independently of the member variable. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/tools/buildman/builderthread.py b/tools/bu

[PATCH v2 07/43] buildman: Make mrproper an argument to _config_and_build()

2024-06-21 Thread Simon Glass
Pass this in so the caller can change it independently of the member variable. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tools/buildman/builderthread.py b/tools/buildman/bu

[PATCH v2 06/43] buildman: Make mrproper an argument to _reconfigure()

2024-06-21 Thread Simon Glass
Pass this in so the caller can change it independently of the member variable. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/buildman/builderthread.py b/tools/buildman/build

[PATCH v2 05/43] binman: Update the entrydocs header

2024-06-21 Thread Simon Glass
Reduce the length of the underline for this header, to match the heading itself. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/entry.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/binman/entry.py b/tools/binman/entry.py index 42e0b7b9145..2ed65

[PATCH v2 04/43] binman: ti: Regenerate entry docs

2024-06-21 Thread Simon Glass
Correct formatting errors in the documentation. Regenerate the entries.rst file to include this recent addition. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/entries.rst| 35 + tools/binman/etype/ti_secure.py | 45 +-

[PATCH v2 02/43] binman: efi: Correct entry docs

2024-06-21 Thread Simon Glass
Somehow the class documentation has got out of sync with the generated entries.rst file. Regenerating it causes errors, so correct these and regenerate the entries.rst file. Signed-off-by: Simon Glass Fixes: 809f28e7213 ("binman: capsule: Use dumped capsule header...") --- (no changes since v1)

[PATCH v2 03/43] binman: Regenerate nxp docs

2024-06-21 Thread Simon Glass
Regenerate the entries.rst file to include this recent addition. Note that more docs are needed here, to actually describe the entry type. Note also that the entry type needs Binman tests added. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/entries.rst | 22 ++

[PATCH v2 01/43] trace: Update test to tolerate different trace-cmd version

2024-06-21 Thread Simon Glass
Some versions of trace-cmd (or some machines?) show one less dot in the CPU list. Signed-off-by: Simon Glass --- (no changes since v1) test/py/tests/test_trace.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/py/tests/test_trace.py b/test/py/tests/test_trace.py index

[PATCH v2 00/43] labgrid: Provide an integration with Labgrid

2024-06-21 Thread Simon Glass
Labgrid provides access to a hardware lab in an automated way. It is possible to boot U-Boot on boards in the lab without physically touching them. It relies on relays, USB UARTs and SD muxes, among other things. By way of background, about 4 years ago I wrong a thing called Labman[1] which allowe

Re: [PATCH 3/5] buildman: Support building within a Python venv

2024-06-21 Thread Simon Glass
Hi Tom, On Fri, 21 Jun 2024 at 13:26, Tom Rini wrote: > > On Fri, Jun 21, 2024 at 12:19:12PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Fri, 21 Jun 2024 at 09:22, Tom Rini wrote: > > > > > > On Fri, Jun 21, 2024 at 08:57:50AM -0600, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Thu

Re: [PATCH v2 2/9] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-21 Thread Simon Glass
Hi Tom, On Fri, 21 Jun 2024 at 13:19, Tom Rini wrote: > > On Fri, Jun 21, 2024 at 11:55:42AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Fri, 21 Jun 2024 at 10:05, Tom Rini wrote: > [snip] > > > Yes, I very much do not like guessing about 3 numbers instead of > > > guessing about 1 number a

Re: [PATCH 3/5] buildman: Support building within a Python venv

2024-06-21 Thread Tom Rini
On Fri, Jun 21, 2024 at 12:19:12PM -0600, Simon Glass wrote: > Hi Tom, > > On Fri, 21 Jun 2024 at 09:22, Tom Rini wrote: > > > > On Fri, Jun 21, 2024 at 08:57:50AM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Thu, 20 Jun 2024 at 17:30, Tom Rini wrote: > > > > > > > > On Thu, Jun 20, 20

Re: [PATCH v2 2/9] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-21 Thread Tom Rini
On Fri, Jun 21, 2024 at 11:55:42AM -0600, Simon Glass wrote: > Hi Tom, > > On Fri, 21 Jun 2024 at 10:05, Tom Rini wrote: [snip] > > Yes, I very much do not like guessing about 3 numbers instead of > > guessing about 1 number and using the standard mechanism we already > > have. Please use BOARD_S

Re: [PATCH v4 00/14] Introduce the lwIP network stack

2024-06-21 Thread Fabio Estevam
Hi Tim and Jerome, On Fri, Jun 21, 2024 at 1:08 PM Tim Harvey wrote: > I tried your to-upstream/v5-wip branch > (042bea36eb9731079a3d7afffe3774d79e06ac5d) and it behaves the same. Do > you have something else to try/test? Yes, when I tested older versions from Maxim I could never get lwIP to wo

Re: [PATCH 3/5] buildman: Support building within a Python venv

2024-06-21 Thread Simon Glass
Hi Tom, On Fri, 21 Jun 2024 at 09:22, Tom Rini wrote: > > On Fri, Jun 21, 2024 at 08:57:50AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Thu, 20 Jun 2024 at 17:30, Tom Rini wrote: > > > > > > On Thu, Jun 20, 2024 at 05:05:30PM -0600, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Thu

Re: [PATCH 5/9] fdt: Correct condition for bloblist existing

2024-06-21 Thread Simon Glass
Hi Raymond, On Fri, 21 Jun 2024 at 10:40, Raymond Mao wrote: > > Hi Simon, > > On Fri, 21 Jun 2024 at 10:58, Simon Glass wrote: >> >> Hi Ilias, >> >> On Wed, 19 Jun 2024 at 06:41, Ilias Apalodimas >> wrote: >> > >> > Hi Simon, >> > >> > On Wed, Jun 12, 2024 at 02:24:31PM -0600, Simon Glass wrot

Re: [PATCH v4 00/14] Introduce the lwIP network stack

2024-06-21 Thread Jerome Forissier
On 6/21/24 18:08, Tim Harvey wrote: > On Fri, Jun 21, 2024 at 5:59 AM Jerome Forissier > wrote: >> >> >> >> On 6/20/24 19:10, Tim Harvey wrote: >>> On Mon, Jun 17, 2024 at 8:33 AM Jerome Forissier >>> wrote: This is a rework of a patch series by Maxim Uvarov: "net/lwip: add lwip

Re: [PATCH v2 2/9] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-21 Thread Simon Glass
Hi Tom, On Fri, 21 Jun 2024 at 10:05, Tom Rini wrote: > > On Fri, Jun 21, 2024 at 08:57:51AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Thu, 20 Jun 2024 at 17:19, Tom Rini wrote: > > > > > > On Thu, Jun 20, 2024 at 05:05:29PM -0600, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Wed

Re: [PATCH v4 00/14] Introduce the lwIP network stack

2024-06-21 Thread Jerome Forissier
Hi Simon, On 6/21/24 16:57, Simon Glass wrote: > Hi Jerome, > > On Mon, 17 Jun 2024 at 09:33, Jerome Forissier > wrote: >> >> This is a rework of a patch series by Maxim Uvarov: "net/lwip: add lwip >> library for the network stack" [1]. The goal is to introduce the lwIP TCP/IP >> stack [2] [3] a

Re: [PATCH v3 10/18] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-21 Thread Simon Glass
Hi Ilias, On Fri, 21 Jun 2024 at 09:52, Ilias Apalodimas wrote: > > Hi Simon, > > On Fri, 21 Jun 2024 at 17:57, Simon Glass wrote: > > > > Hi Ilias, > > > > On Thu, 20 Jun 2024 at 23:49, Ilias Apalodimas > > wrote: > > > > > > On Fri, 21 Jun 2024 at 08:32, Ilias Apalodimas > > > wrote: > > > >

Re: [PATCH v3 0/7] efi: CapsuleUpdate: support for dynamic UUIDs

2024-06-21 Thread Caleb Connolly
On Fri, 21 Jun 2024, 19:06 Vincent Stehlé, wrote: > On Fri, Jun 21, 2024 at 01:00:51PM +0200, Heinrich Schuchardt wrote: > (..) > > The current specification is in RFC 9562, 4.1, "Variant field" > > > > "The variant field consists of a variable number of the most significant > > bits of octet 8 o

Re: [PATCH v3 0/7] efi: CapsuleUpdate: support for dynamic UUIDs

2024-06-21 Thread Vincent Stehlé
On Fri, Jun 21, 2024 at 01:00:51PM +0200, Heinrich Schuchardt wrote: (..) > The current specification is in RFC 9562, 4.1, "Variant field" > > "The variant field consists of a variable number of the most significant > bits of octet 8 of the UUID. > > ... > > Specifically for UUIDs in this docume

Re: [PATCH 5/9] fdt: Correct condition for bloblist existing

2024-06-21 Thread Raymond Mao
Hi Simon, On Fri, 21 Jun 2024 at 10:58, Simon Glass wrote: > Hi Ilias, > > On Wed, 19 Jun 2024 at 06:41, Ilias Apalodimas > wrote: > > > > Hi Simon, > > > > On Wed, Jun 12, 2024 at 02:24:31PM -0600, Simon Glass wrote: > > > Hi Ilias, > > > > > > On Wed, 12 Jun 2024 at 00:02, Ilias Apalodimas >

Re: [PATCH v4 00/14] Introduce the lwIP network stack

2024-06-21 Thread Tim Harvey
On Fri, Jun 21, 2024 at 5:59 AM Jerome Forissier wrote: > > > > On 6/20/24 19:10, Tim Harvey wrote: > > On Mon, Jun 17, 2024 at 8:33 AM Jerome Forissier > > wrote: > >> > >> This is a rework of a patch series by Maxim Uvarov: "net/lwip: add lwip > >> library for the network stack" [1]. The goal i

Re: [PATCH v2 2/9] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-21 Thread Tom Rini
On Fri, Jun 21, 2024 at 08:57:51AM -0600, Simon Glass wrote: > Hi Tom, > > On Thu, 20 Jun 2024 at 17:19, Tom Rini wrote: > > > > On Thu, Jun 20, 2024 at 05:05:29PM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Wed, 19 Jun 2024 at 09:32, Tom Rini wrote: > > > > > > > > On Tue, Jun 18, 20

Re: [PATCH v3 10/18] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-21 Thread Ilias Apalodimas
Hi Simon, On Fri, 21 Jun 2024 at 17:57, Simon Glass wrote: > > Hi Ilias, > > On Thu, 20 Jun 2024 at 23:49, Ilias Apalodimas > wrote: > > > > On Fri, 21 Jun 2024 at 08:32, Ilias Apalodimas > > wrote: > > > > > > Hi Simon, > > > > > > On Fri, 21 Jun 2024 at 02:06, Simon Glass wrote: > > > > > >

Re: Request for hosting a boot-firmware repository in u-boot git (denx and GitHub)

2024-06-21 Thread Bryan Brattlof
On June 21, 2024 thus sayeth Simon Glass: > Hi Peter, > > On Fri, 21 Jun 2024 at 01:35, Peter Robinson wrote: > > > > On Fri, 21 Jun 2024 at 00:05, Simon Glass wrote: > > > > > > Hi Nishanth, > > > > > > On Thu, 20 Jun 2024 at 15:35, Nishanth Menon wrote: > > > > > > > > Hi Team, > > > > > > >

Re: [PATCH] imx8mp-venice-gw702x: Drop EQos clock workaround

2024-06-21 Thread Tim Harvey
On Fri, Jun 21, 2024 at 7:24 AM Fabio Estevam wrote: > > Hi Tim, > > On Wed, Jun 19, 2024 at 10:30 PM Tim Harvey wrote: > > > > The assigned-clock no longer have to be dropped, the clock are now > > defined in clk-imx8mp.c and used by DWMAC driver to configure the > > DWMAC clock. Drop the workar

Re: [PATCH] imx: hab: Make imx_hab_is_enabled dependent on FIELD_RETURN

2024-06-21 Thread Marek Vasut
On 6/21/24 3:06 PM, Paul Geurts wrote: The decision on whether HAB is enabled is solely based on the SEC_CONFIG fuse. The HAB FIELD_RETURN feature is able to permanently disable HAB on a CPU, after which it is able to boot unsigned firmware. U-Boot however does not take into account the FIELD_RET

Re: [PATCH v5] cmd: bootm: add ELF file support

2024-06-21 Thread Heinrich Schuchardt
On 6/21/24 16:16, Максим Москалец wrote: пт, 21 июн. 2024 г. в 15:51, Heinrich Schuchardt : On 21.06.24 13:42, Maxim Moskalets wrote: Some operating systems (e.g. seL4) and embedded applications are ELF images. It is convenient to use FIT-images to implement trusted boot. Added "elf" image typ

Re: [PATCH v2 2/6] buildman: Add python3-pycryptodome

2024-06-21 Thread Tom Rini
On Fri, Jun 21, 2024 at 07:14:18AM -0600, Simon Glass wrote: > This is used by some Binman entry types, so add it to allow more tests > to pass. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 1/6] buildman: Add python3-coverage

2024-06-21 Thread Tom Rini
On Fri, Jun 21, 2024 at 07:14:17AM -0600, Simon Glass wrote: > Add this package so we can run code-coverage tests for Binman. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

Re: [PATCH 3/5] buildman: Support building within a Python venv

2024-06-21 Thread Tom Rini
On Fri, Jun 21, 2024 at 08:57:50AM -0600, Simon Glass wrote: > Hi Tom, > > On Thu, 20 Jun 2024 at 17:30, Tom Rini wrote: > > > > On Thu, Jun 20, 2024 at 05:05:30PM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Thu, 20 Jun 2024 at 08:32, Tom Rini wrote: > > > > > > > > On Thu, Jun 20, 20

Re: [PATCH v3 16/18] rockchip: Avoid #ifdefs in RK3399 SPL

2024-06-21 Thread Simon Glass
Hi Jonas, On Fri, 21 Jun 2024 at 00:45, Jonas Karlman wrote: > > Hi Simon, > > On 2024-06-21 01:06, Simon Glass wrote: > > The code here is confusing due to large blocks which are #ifdefed out. > > Add a function phase_sdram_init() which returns whether SDRAM init > > should happen in the current

Re: [PATCH v4 00/14] Introduce the lwIP network stack

2024-06-21 Thread Simon Glass
Hi Jerome, On Mon, 17 Jun 2024 at 09:33, Jerome Forissier wrote: > > This is a rework of a patch series by Maxim Uvarov: "net/lwip: add lwip > library for the network stack" [1]. The goal is to introduce the lwIP TCP/IP > stack [2] [3] as an alternative to the current implementation in net/, > se

Re: Request for hosting a boot-firmware repository in u-boot git (denx and GitHub)

2024-06-21 Thread Simon Glass
Hi Peter, On Fri, 21 Jun 2024 at 01:35, Peter Robinson wrote: > > On Fri, 21 Jun 2024 at 00:05, Simon Glass wrote: > > > > Hi Nishanth, > > > > On Thu, 20 Jun 2024 at 15:35, Nishanth Menon wrote: > > > > > > Hi Team, > > > > > > We have briefly discussed this topic on IRC[1]. I would like to >

Re: [PATCH v3 07/18] binman: Keep the efi_capsule input file

2024-06-21 Thread Simon Glass
Hi Sughosh, On Fri, 21 Jun 2024 at 00:14, Sughosh Ganu wrote: > > On Fri, 21 Jun 2024 at 04:36, Simon Glass wrote: > > > > There is no need to remove input files. It makes it harder to diagnose > > failures. Keep the payload file. > > > > There is no test for this condition, but one could be add

Re: [PATCH 2/2] doc: develop: testing: Fix reference to test writing section

2024-06-21 Thread Simon Glass
On Fri, 21 Jun 2024 at 01:47, Alexander Dahl wrote: > > Fixes: fc3283314539 ("doc: Explain briefly how to write new tests") > Signed-off-by: Alexander Dahl > --- > doc/develop/testing.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass Please do always add a c

Re: [PATCH 1/2] doc: develop: testing: Fix broken reference to pytest suite help

2024-06-21 Thread Simon Glass
On Fri, 21 Jun 2024 at 01:47, Alexander Dahl wrote: > > This should have been adapted directly with or after > v2021.01-693-gca6583d4e08 ("doc: move test/README to HTML > documentation") or v2021.01-694-g0157619d5c8 ("doc: move > test/py/README.md to HTML documentation") already. > > Signed-off-by

Re: [PATCH 5/9] fdt: Correct condition for bloblist existing

2024-06-21 Thread Simon Glass
Hi Ilias, On Wed, 19 Jun 2024 at 06:41, Ilias Apalodimas wrote: > > Hi Simon, > > On Wed, Jun 12, 2024 at 02:24:31PM -0600, Simon Glass wrote: > > Hi Ilias, > > > > On Wed, 12 Jun 2024 at 00:02, Ilias Apalodimas > > wrote: > > > > > > [...] > > > > > > > > > >> --- > > > > > > >> > > > > > > >>

Re: [PATCH] RFC: Add a tag for the world builds

2024-06-21 Thread Simon Glass
Hi Tom, On Thu, 20 Jun 2024 at 17:15, Tom Rini wrote: > > On Thu, Jun 20, 2024 at 05:05:26PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Thu, 20 Jun 2024 at 08:39, Tom Rini wrote: > > > > > > On Thu, Jun 20, 2024 at 07:33:46AM -0600, Simon Glass wrote: > > > > > > > Currently the world buil

Re: [PATCH v2 2/9] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-21 Thread Simon Glass
Hi Tom, On Thu, 20 Jun 2024 at 17:19, Tom Rini wrote: > > On Thu, Jun 20, 2024 at 05:05:29PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Wed, 19 Jun 2024 at 09:32, Tom Rini wrote: > > > > > > On Tue, Jun 18, 2024 at 09:03:37PM -0600, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Tue

Re: [PATCH 3/5] buildman: Support building within a Python venv

2024-06-21 Thread Simon Glass
Hi Tom, On Thu, 20 Jun 2024 at 17:30, Tom Rini wrote: > > On Thu, Jun 20, 2024 at 05:05:30PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Thu, 20 Jun 2024 at 08:32, Tom Rini wrote: > > > > > > On Thu, Jun 20, 2024 at 07:19:35AM -0600, Simon Glass wrote: > > > > > > > The Python virtualenv to

Re: [PATCH v3 10/18] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-21 Thread Simon Glass
Hi Ilias, On Thu, 20 Jun 2024 at 23:49, Ilias Apalodimas wrote: > > On Fri, 21 Jun 2024 at 08:32, Ilias Apalodimas > wrote: > > > > Hi Simon, > > > > On Fri, 21 Jun 2024 at 02:06, Simon Glass wrote: > > > > > > It does not make sense to enable all SHA algorithms unless they are > > > needed. It

Re: Request for hosting a boot-firmware repository in u-boot git (denx and GitHub)

2024-06-21 Thread Bryan Brattlof
On June 20, 2024 thus sayeth Peter Robinson: > Hi Nishanth, > > Thanks for starting this conversation. > > > We have briefly discussed this topic on IRC[1]. I would like to > > propose a new boot-firmware repository similar to the Linux-firmware > > repository under the aegis of u-boot hosting. >

Re: [PATCH] imx8mp-venice-gw702x: Drop EQos clock workaround

2024-06-21 Thread Fabio Estevam
Hi Tim, On Wed, Jun 19, 2024 at 10:30 PM Tim Harvey wrote: > > The assigned-clock no longer have to be dropped, the clock are now > defined in clk-imx8mp.c and used by DWMAC driver to configure the > DWMAC clock. Drop the workarounds from U-Boot specific DT extras. > > Having the clocks dropped c

  1   2   >