[PATCH] mtd: spinand: Add support for XTX XT26xxxDxxxxx

2023-12-25 Thread Bruce Suen
Add Support XTX Technology XT26G01DX, XT26G11DX, XT26Q01DX, XT26G02DX, XT26G12DX, XT26Q02DX, XT26G04DX, and XT26Q04DX SPI NAND. These are 3V/1.8V 1G/2G/4Gbit serial SLC NAND flash device with on-die ECC(8bit strength per 512bytes). Datasheet Links: - http://www.xtx

Re: [PATCH v2 0/8] An effort to bring DT bindings compliance within U-Boot

2023-12-25 Thread Sumit Garg
On Fri, 22 Dec 2023 at 21:23, Krzysztof Kozlowski wrote: > > On 22/12/2023 16:45, Conor Dooley wrote: > >>> > >>> I suppose we have to relay information to kernel sub-arch maintainers > >>> who aren't the same as maintaining U-Boot counterparts. How about > >>> adding U-Boot ML to CC for whichever

Re: [PATCH v2 6/6] andes: ae350: Enable MISC_INIT_R for ae350 platform

2023-12-25 Thread Yu-Chien Peter Lin
On Tue, Dec 26, 2023 at 02:54:41PM +0800, Leo Yu-Chi Liang wrote: > Enable MISC_INIT_R for ae350 to support CPU name detection > and re-sync the configs via make savedefconfig. > > Signed-off-by: Leo Yu-Chi Liang Reviewed-by: Yu Chien Peter Lin > --- > configs/ae350_rv32_defconfig | 5

Re: [PATCH v2 5/6] andes: ae350: Save cpu name to env

2023-12-25 Thread Yu-Chien Peter Lin
On Tue, Dec 26, 2023 at 02:54:27PM +0800, Leo Yu-Chi Liang wrote: > Detect CPU name through marchid and then save it to env. > > Signed-off-by: Leo Yu-Chi Liang Reviewed-by: Yu Chien Peter Lin > --- > board/AndesTech/ae350/ae350.c | 23 +++ > 1 file changed, 23 insertions(

Re: [PATCH v2 4/6] andes: cpu: Enable cache and TLB ECC support

2023-12-25 Thread Yu-Chien Peter Lin
On Tue, Dec 26, 2023 at 02:17:35PM +0800, Leo Yu-Chi Liang wrote: > Andes CPU supports cache and TLB ECC. > Enable them by default. > > Signed-off-by: Leo Yu-Chi Liang Reviewed-by: Yu Chien Peter Lin > --- > arch/riscv/cpu/andesv5/cpu.c| 3 ++- > arch/riscv/include/asm/arch-andes/

Re: [PATCH v2 3/6] andes: cpu: Enable memboost feature

2023-12-25 Thread Yu-Chien Peter Lin
On Tue, Dec 26, 2023 at 02:17:34PM +0800, Leo Yu-Chi Liang wrote: > Andes CPU has memboost feature including prefetch, > write-around and non-blocking load. Enable them by default. > > Signed-off-by: Leo Yu-Chi Liang Reviewed-by: Yu Chien Peter Lin > --- > arch/riscv/cpu/andesv5/cpu.c

Re: [PATCH v2 2/6] andes: ae350: Implement cache switch via Kconfig

2023-12-25 Thread Yu-Chien Peter Lin
On Tue, Dec 26, 2023 at 02:17:33PM +0800, Leo Yu-Chi Liang wrote: > Kconfig provides SYS_[I|D]CACHE_OFF config options to switch off caches. > Provide the corresponding implementation to the options. > > Signed-off-by: Leo Yu-Chi Liang Reviewed-by: Yu Chien Peter Lin > --- > arch/riscv/cpu/an

Re: [PATCH v2 1/6] andes: csr.h: Clean up CSR definition

2023-12-25 Thread Yu-Chien Peter Lin
On Tue, Dec 26, 2023 at 02:17:32PM +0800, Leo Yu-Chi Liang wrote: > Signed-off-by: Leo Yu-Chi Liang Reviewed-by: Yu Chien Peter Lin > arch/riscv/include/asm/arch-andes/csr.h | 20 > arch/riscv/include/asm/csr.h| 1 + > 2 files changed, 9 insertions(+), 12 dele

[PATCH v2 6/6] andes: ae350: Enable MISC_INIT_R for ae350 platform

2023-12-25 Thread Leo Yu-Chi Liang
Enable MISC_INIT_R for ae350 to support CPU name detection and re-sync the configs via make savedefconfig. Signed-off-by: Leo Yu-Chi Liang --- configs/ae350_rv32_defconfig | 5 +++-- configs/ae350_rv32_spl_defconfig | 5 +++-- configs/ae350_rv32_spl_xip_defconfig | 5 +++-- configs/a

[PATCH v2 5/6] andes: ae350: Save cpu name to env

2023-12-25 Thread Leo Yu-Chi Liang
Detect CPU name through marchid and then save it to env. Signed-off-by: Leo Yu-Chi Liang --- board/AndesTech/ae350/ae350.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/board/AndesTech/ae350/ae350.c b/board/AndesTech/ae350/ae350.c index bef9e3149e..4e53fee5d2 10064

[PATCH v2 2/2] efi_loader: auto-generate removable media boot option first

2023-12-25 Thread Masahisa Kojima
This commit auto-generates the boot option for removable block io devices followed by fixed block io devices. This is what EDK II reference implementation does. Signed-off-by: Masahisa Kojima --- lib/efi_loader/efi_bootmgr.c | 35 +++ 1 file changed, 27 insertions

[PATCH v2 1/2] efi_loader: auto-generate boot option for each blkio device

2023-12-25 Thread Masahisa Kojima
Current efibootmgr auto-generates the boot option for all disks and partitions installing EFI_SIMPLE_FILE_SYSTEM_PROTOCOL, while EDK II reference implementation auto-generates the boot option for all devices installing EFI_BLOCK_IO_PROTOCOL with eliminating logical partitions. This commit modifie

[PATCH v2 0/2] fix auto-generated boot options

2023-12-25 Thread Masahisa Kojima
This series aims to get aligned to the EDK II reference implementation for auto-generated boot options, and tries to address the following issue. https://source.denx.de/u-boot/custodians/u-boot-efi/-/issues/13 This series is based on the efi-next-20231217 tag. [Changelog] v1 -> v2 - fix make html

Re: [PATHv2 2/9] net: sandbox: fix NULL pointer derefences

2023-12-25 Thread Sean Anderson
On 12/26/23 01:18, Maxim Uvarov wrote: On Tue, 26 Dec 2023 at 04:43, Sean Anderson mailto:sean...@gmail.com>> wrote: On 12/25/23 10:39, Maxim Uvarov wrote: > Add additional checks for NULL pointers. > > Signed-off-by: Maxim Uvarov mailto:maxim.uva...@linaro.org>> > ---

Re: [PATCH 0/2] fix auto-generated boot options

2023-12-25 Thread Masahisa Kojima
On Tue, 26 Dec 2023 at 02:14, Heinrich Schuchardt wrote: > > On 12/20/23 09:41, Masahisa Kojima wrote: > > This series aims to get aligned to the EDK II reference > > implementation for auto-generated boot options, and tries > > to address the following issue. > > https://source.denx.de/u-boot/cus

Re: [PATHv2 8/9] omap3: use device specific naming for mem_init

2023-12-25 Thread Maxim Uvarov
On Tue, 26 Dec 2023 at 04:49, Sean Anderson wrote: > On 12/25/23 10:39, Maxim Uvarov wrote: > > Use device specific naming for functions so as to not overlap > > with common function names. > > > > Signed-off-by: Maxim Uvarov > > Reviewed-by: Tom Rini > > --- > > arch/arm/include/asm/arch-oma

Re: [PATHv2 2/9] net: sandbox: fix NULL pointer derefences

2023-12-25 Thread Maxim Uvarov
On Tue, 26 Dec 2023 at 04:43, Sean Anderson wrote: > On 12/25/23 10:39, Maxim Uvarov wrote: > > Add additional checks for NULL pointers. > > > > Signed-off-by: Maxim Uvarov > > --- > > drivers/net/sandbox.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/net/sandbox.

[PATCH v2 4/6] andes: cpu: Enable cache and TLB ECC support

2023-12-25 Thread Leo Yu-Chi Liang
Andes CPU supports cache and TLB ECC. Enable them by default. Signed-off-by: Leo Yu-Chi Liang --- arch/riscv/cpu/andesv5/cpu.c| 3 ++- arch/riscv/include/asm/arch-andes/csr.h | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/riscv/cpu/andesv5/cpu.c b/arch/ri

[PATCH v2 3/6] andes: cpu: Enable memboost feature

2023-12-25 Thread Leo Yu-Chi Liang
Andes CPU has memboost feature including prefetch, write-around and non-blocking load. Enable them by default. Signed-off-by: Leo Yu-Chi Liang --- arch/riscv/cpu/andesv5/cpu.c| 9 - arch/riscv/include/asm/arch-andes/csr.h | 6 ++ 2 files changed, 14 insertions(+), 1 delet

[PATCH v2 2/6] andes: ae350: Implement cache switch via Kconfig

2023-12-25 Thread Leo Yu-Chi Liang
Kconfig provides SYS_[I|D]CACHE_OFF config options to switch off caches. Provide the corresponding implementation to the options. Signed-off-by: Leo Yu-Chi Liang --- arch/riscv/cpu/andesv5/cpu.c | 25 - board/AndesTech/ae350/ae350.c | 3 ++- 2 files changed, 18 insertio

[PATCH v2 1/6] andes: csr.h: Clean up CSR definition

2023-12-25 Thread Leo Yu-Chi Liang
Signed-off-by: Leo Yu-Chi Liang --- arch/riscv/include/asm/arch-andes/csr.h | 20 arch/riscv/include/asm/csr.h| 1 + 2 files changed, 9 insertions(+), 12 deletions(-) diff --git a/arch/riscv/include/asm/arch-andes/csr.h b/arch/riscv/include/asm/arch-andes/csr.h

[PATCH v1] reset: npcm: Add support for Nuvoton NPCM BMC family

2023-12-25 Thread Jim Liu
Add reset controller driver for Nuvoton BMCs. The npcm reset driver not only supports reset each module reset but setting initial value of reset Control Registers. And The driver support each module reset. Signed-off-by: Jim Liu --- drivers/reset/Kconfig | 7 ++ drivers/reset/Makefile

[PATCH v1] spi: npcm_pspi: Fix the wrong clock divider calculation

2023-12-25 Thread Jim Liu
Fix the wrong clock divider calculation. Signed-off-by: Jim Liu --- drivers/spi/npcm_pspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/npcm_pspi.c b/drivers/spi/npcm_pspi.c index 37bab70967..eb14185273 100644 --- a/drivers/spi/npcm_pspi.c +++ b/drivers/spi/np

Re: [PATCH 1/2] efi_loader: auto-generate boot option for each blkio device

2023-12-25 Thread Masahisa Kojima
On Mon, 25 Dec 2023 at 21:22, Heinrich Schuchardt wrote: > > On 12/20/23 09:41, Masahisa Kojima wrote: > > Current efibootmgr auto-generates the boot option for all > > disks and partitions installing EFI_SIMPLE_FILE_SYSTEM_PROTOCOL, > > while EDK II reference implementation auto-generates the boo

Re: [PATCH 3/3] efi_loader: create common function to free struct efi_disk_obj

2023-12-25 Thread Masahisa Kojima
On Mon, 25 Dec 2023 at 19:31, Heinrich Schuchardt wrote: > > On 12/25/23 05:43, Masahisa Kojima wrote: > > Current error handling of creating raw disk/partition has > > following issues. > > - duplicate free for efi handle, efi handle is already freed > > in efi_delete_handle() > > I cannot

Re: [PATCH 2/3] efi_loader: avoid pointer access after calling efi_delete_handle

2023-12-25 Thread Heinrich Schuchardt
Am 26. Dezember 2023 02:13:08 MEZ schrieb Masahisa Kojima : >Hi Heinrich, > >On Mon, 25 Dec 2023 at 19:05, Heinrich Schuchardt wrote: >> >> On 12/25/23 05:43, Masahisa Kojima wrote: >> > efi_delete_handle() calls efi_purge_handle(), then it finally >> > frees the efi handle. >> > Both diskobj

Re: [PATCH 2/3] efi_loader: avoid pointer access after calling efi_delete_handle

2023-12-25 Thread Masahisa Kojima
Hi Heinrich, On Mon, 25 Dec 2023 at 19:05, Heinrich Schuchardt wrote: > > On 12/25/23 05:43, Masahisa Kojima wrote: > > efi_delete_handle() calls efi_purge_handle(), then it finally > > frees the efi handle. > > Both diskobj and handle variables in efi_disk_remove() have > > the same pointer, we

Re: [PATHv2 8/9] omap3: use device specific naming for mem_init

2023-12-25 Thread Sean Anderson
On 12/25/23 10:39, Maxim Uvarov wrote: Use device specific naming for functions so as to not overlap with common function names. Signed-off-by: Maxim Uvarov Reviewed-by: Tom Rini --- arch/arm/include/asm/arch-omap3/mem.h | 2 +- arch/arm/mach-omap2/omap3/board.c | 2 +- arch/arm/mach-o

Re: [PATHv2 2/9] net: sandbox: fix NULL pointer derefences

2023-12-25 Thread Sean Anderson
On 12/25/23 10:39, Maxim Uvarov wrote: Add additional checks for NULL pointers. Signed-off-by: Maxim Uvarov --- drivers/net/sandbox.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/sandbox.c b/drivers/net/sandbox.c index 13022addb6..d91935e032 100644 --- a/drivers/net/san

Re: [PATCH 0/2] fix auto-generated boot options

2023-12-25 Thread Heinrich Schuchardt
On 12/20/23 09:41, Masahisa Kojima wrote: This series aims to get aligned to the EDK II reference implementation for auto-generated boot options, and tries to address the following issue. https://source.denx.de/u-boot/custodians/u-boot-efi/-/issues/13 This series is based on the efi-next-2023121

[PATHv2 9/9] Makefile: add dtbs to clean

2023-12-25 Thread Maxim Uvarov
CI test checks that generated dtb has to be cleaned up. Signed-off-by: Maxim Uvarov --- Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 220411a293..ab603191ad 100644 --- a/Makefile +++ b/Makefile @@ -2165,7 +2165,8 @@ CLEAN_FILES += includ

[PATHv2 8/9] omap3: use device specific naming for mem_init

2023-12-25 Thread Maxim Uvarov
Use device specific naming for functions so as to not overlap with common function names. Signed-off-by: Maxim Uvarov Reviewed-by: Tom Rini --- arch/arm/include/asm/arch-omap3/mem.h | 2 +- arch/arm/mach-omap2/omap3/board.c | 2 +- arch/arm/mach-omap2/omap3/emif4.c | 4 ++-- arch/arm/ma

[PATHv2 7/9] bcm_ns3: use device specific naming for variables

2023-12-25 Thread Maxim Uvarov
Use device specific naming for variables so as to not overlap with common function names. Signed-off-by: Maxim Uvarov Reviewed-by: Tom Rini Reviewed-by: Peter Robinson --- include/configs/bcm_ns3.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/configs/bcm_ns

[PATHv2 6/9] mach-socfpga: do not overlap defines with lwip

2023-12-25 Thread Maxim Uvarov
Fix compilation issue with overlapping lwip and march defines. Signed-off-by: Maxim Uvarov --- arch/arm/mach-socfpga/include/mach/handoff_soc64.h | 6 -- arch/arm/mach-socfpga/wrap_handoff_soc64.c | 9 + 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/arch/arm/

[PATHv2 5/9] driver/net/rtl8139: remove debug print

2023-12-25 Thread Maxim Uvarov
debug print delays reset of the driver. Finally I see bunch of "rx error " errors in the screen. CI can not handle many prints. While network works fine there Reproduced with: make CROSS_COMPILE=sh2-linux- r2dplus_defconfig all qemu-system-sh4 -M r2d -nographic -serial null \ -serial mon:stdio

[PATHv2 4/9] sandbox: eth-raw-os: successful return code is 0

2023-12-25 Thread Maxim Uvarov
all network drivers return 0 on the successful transmission. Signed-off-by: Maxim Uvarov Reviewed-by: Simon Glass --- arch/sandbox/cpu/eth-raw-os.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sandbox/cpu/eth-raw-os.c b/arch/sandbox/cpu/eth-raw-os.c index e59b96be5f.

[PATHv2 3/9] net/smc911x: fix return from smc911x_send

2023-12-25 Thread Maxim Uvarov
return value of smc911x_send is ignored, but on sucesseful send we need return 0 and or error -ETIMEOUT, not opposite. Signed-off-by: Maxim Uvarov Reviewed-by: Tom Rini --- drivers/net/smc911x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/smc911x.c b/drivers/

[PATHv2 2/9] net: sandbox: fix NULL pointer derefences

2023-12-25 Thread Maxim Uvarov
Add additional checks for NULL pointers. Signed-off-by: Maxim Uvarov --- drivers/net/sandbox.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/sandbox.c b/drivers/net/sandbox.c index 13022addb6..d91935e032 100644 --- a/drivers/net/sandbox.c +++ b/drivers/net/sandbox.c @@ -65,6

[PATHv2 1/9] test_net: print out net list

2023-12-25 Thread Maxim Uvarov
Printing net list is useful in CI log files. Signed-off-by: Maxim Uvarov --- test/py/tests/test_net.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/py/tests/test_net.py b/test/py/tests/test_net.py index b2241ae6a4..cd5b791a6a 100644 --- a/test/py/tests/test_net.py +++ b/test/py/tes

[PATHv2 0/9] net fixes prior lwip

2023-12-25 Thread Maxim Uvarov
Add small net fixes prior lwip patches. v2: - rebase on the top of master tree with descriptions fixes suggested in review comments. Maxim Uvarov (9): test_net: print out net list net: sandbox: fix NULL pointer derefences net/smc911x: fix return from smc911x_send sandbox: eth-raw-os

Re: [PATCH RFC] dt-bindings: nvmem: u-boot, env: add any-name MAC cells compatible

2023-12-25 Thread Krzysztof Kozlowski
On 18/12/2023 23:02, Rafał Miłecki wrote: > On 14.12.2023 22:27, Simon Glass wrote: >> On Thu, 14 Dec 2023 at 08:36, Rafał Miłecki wrote: >>> >>> From: Rafał Miłecki >>> >>> So far we had a property for "ethaddr" NVMEM cell containing base >>> Ethernet MAC address. The problem is vendors often pi

[PATCH 5/5] andes: ae350: Save cpu name to env

2023-12-25 Thread Leo Yu-Chi Liang
Detect CPU name through marchid and then save it to env. Signed-off-by: Leo Yu-Chi Liang --- board/AndesTech/ae350/ae350.c | 20 1 file changed, 20 insertions(+) diff --git a/board/AndesTech/ae350/ae350.c b/board/AndesTech/ae350/ae350.c index bef9e3149e..9faf46d96e 100644 -

[PATCH 4/5] andes: cpu: Enable cache and TLB ECC support

2023-12-25 Thread Leo Yu-Chi Liang
Andes CPU supports cache and TLB ECC. Enable them by default. Signed-off-by: Leo Yu-Chi Liang --- arch/riscv/cpu/andesv5/cpu.c| 1 + arch/riscv/include/asm/arch-andes/csr.h | 3 +++ 2 files changed, 4 insertions(+) diff --git a/arch/riscv/cpu/andesv5/cpu.c b/arch/riscv/cpu/andesv5/c

[PATCH 3/5] andes: cpu: Enable memboost feature

2023-12-25 Thread Leo Yu-Chi Liang
Andes CPU has memboost feature including prefetch, write-around and non-blocking load. Enable them by default. Signed-off-by: Leo Yu-Chi Liang --- arch/riscv/cpu/andesv5/cpu.c| 7 +++ arch/riscv/include/asm/arch-andes/csr.h | 6 ++ 2 files changed, 13 insertions(+) diff --gi

[PATCH 2/5] andes: ae350: Implement cache switch via Kconfig

2023-12-25 Thread Leo Yu-Chi Liang
Kconfig provides SYS_[I|D]CACHE_OFF config options to switch off caches. Implement the corresponding options. Signed-off-by: Leo Yu-Chi Liang --- arch/riscv/cpu/andesv5/cpu.c | 9 +++-- board/AndesTech/ae350/ae350.c | 3 ++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/arc

[PATCH 1/5] andes: csr.h: Clean up CSR definition

2023-12-25 Thread Leo Yu-Chi Liang
Signed-off-by: Leo Yu-Chi Liang --- arch/riscv/include/asm/arch-andes/csr.h | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/arch/riscv/include/asm/arch-andes/csr.h b/arch/riscv/include/asm/arch-andes/csr.h index 393d51c6dd..93aa8b2343 100644 --- a/arch/ri

[PATCH V4] ARM add initial support for the Phytium Pe2201 Board.

2023-12-25 Thread TracyMg_Li
From: TracyMg_Li Add pe2201 platform code and the device tree of pe2201 platform board. The initial support comprises the UART and PCIe. Signed-off-by: TracyMg_Li Changes since v1: fix space corrupt. Changes since v2: switch to bootstd and text environment. Changes since v3:

[PATCH v2] android_ab: don't ignore ab_control_store return code

2023-12-25 Thread Alexey Romanov
ab_control_store() can return an error if writing to disk fails. In this case, we have to pass the error code to the caller. Signed-off-by: Alexey Romanov Reviewed-by: Mattijs Korpershoek --- boot/android_ab.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a

Re: [PATCH v3 3/4] net: tftp: remove explicit efi configuration dependency

2023-12-25 Thread Tom Rini
On Mon, Dec 25, 2023 at 10:23:35AM +0100, Heinrich Schuchardt wrote: > On 12/18/23 03:38, AKASHI Takahiro wrote: > > Now it is clear that the feature actually depends on efi interfaces, > > not "bootefi" command. efi_set_bootdev() will automatically be nullified > > if necessary efi component is di

Re: [PATCH 1/2] efi_loader: auto-generate boot option for each blkio device

2023-12-25 Thread Heinrich Schuchardt
On 12/20/23 09:41, Masahisa Kojima wrote: Current efibootmgr auto-generates the boot option for all disks and partitions installing EFI_SIMPLE_FILE_SYSTEM_PROTOCOL, while EDK II reference implementation auto-generates the boot option for all devices installing EFI_BLOCK_IO_PROTOCOL with eliminat

Re: [PATCH 1/2] efi_loader: auto-generate boot option for each blkio device

2023-12-25 Thread Heinrich Schuchardt
On 12/25/23 12:00, Heinrich Schuchardt wrote: On 12/20/23 09:41, Masahisa Kojima wrote: Current efibootmgr auto-generates the boot option for all disks and partitions installing EFI_SIMPLE_FILE_SYSTEM_PROTOCOL, while EDK II reference implementation auto-generates the boot option for all devices

Re: [PATCH 1/2] efi_loader: auto-generate boot option for each blkio device

2023-12-25 Thread Heinrich Schuchardt
On 12/20/23 09:41, Masahisa Kojima wrote: Current efibootmgr auto-generates the boot option for all disks and partitions installing EFI_SIMPLE_FILE_SYSTEM_PROTOCOL, while EDK II reference implementation auto-generates the boot option for all devices installing EFI_BLOCK_IO_PROTOCOL with eliminat

Re: [PATCH v4 1/1] efi: Avoid using dm_scan_other()

2023-12-25 Thread Heinrich Schuchardt
On 12/19/23 15:27, Simon Glass wrote: This function is defined by bootstd so using it precludes using that feature. Use the board_early_init_r() feature instead. Nove the affected code into a new file, so that it is clear that this relates to board init. Signed-off-by: Simon Glass Reviewed-b

Re: [PATCH 3/3] efi_loader: create common function to free struct efi_disk_obj

2023-12-25 Thread Heinrich Schuchardt
On 12/25/23 05:43, Masahisa Kojima wrote: Current error handling of creating raw disk/partition has following issues. - duplicate free for efi handle, efi handle is already freed in efi_delete_handle() I cannot see where this patch reduces the number of efi_delete_handle() invocations.

Re: [PATCH 2/3] efi_loader: avoid pointer access after calling efi_delete_handle

2023-12-25 Thread Heinrich Schuchardt
On 12/25/23 05:43, Masahisa Kojima wrote: efi_delete_handle() calls efi_purge_handle(), then it finally frees the efi handle. Both diskobj and handle variables in efi_disk_remove() have the same pointer, we can not access diskobj->dp after calling efi_delete_handle(). This commit saves the struc

Re: [PATCH 1/3] efi_loader: remove unused members from struct efi_disk_obj

2023-12-25 Thread Heinrich Schuchardt
On 12/25/23 05:43, Masahisa Kojima wrote: part and dev_index in struct efi_disk_obj are not used, let's remove it. This commit also removes the invalid structure comment for @dev, it does not exist. Signed-off-by: Masahisa Kojima Reviewed-by: Heinrich Schuchardt --- lib/efi_loader/efi_d

Re: [PATCH v3 3/4] net: tftp: remove explicit efi configuration dependency

2023-12-25 Thread Heinrich Schuchardt
On 12/18/23 03:38, AKASHI Takahiro wrote: Now it is clear that the feature actually depends on efi interfaces, not "bootefi" command. efi_set_bootdev() will automatically be nullified if necessary efi component is disabled. Signed-off-by: AKASHI Takahiro --- net/tftp.c | 10 -- 1 fil

Re: [PATCH v3 1/4] efi_loader: split unrelated code from efi_bootmgr.c

2023-12-25 Thread Heinrich Schuchardt
On 12/18/23 03:38, AKASHI Takahiro wrote: Some code moved from cmd/bootefi.c is actually necessary only for "bootefi " command (starting an image manually loaded by a user using U-Boot load commands or other methods (like JTAG debugger). The code will never been opted out as unused code by a com