Re: [PATCH v1] stm32mp1: read auth stats and boot_partition from tamp

2023-11-08 Thread Patrice CHOTARD
On 11/6/23 11:41, Igor Opaniuk wrote: > Obtain from TAMP backup register information about image authorization > status and partition id used for booting. Store this info in > environmental variables ("boot_auth" and "boot_part" correspondingly). > > Image authorization supported values: > 0x0

Re: [PATCH 2/2] arm: stm32: Limit u-boot.itb size to 0x160000 bytes on DH STM32MP15 DHSOM

2023-11-08 Thread Patrice CHOTARD
On 11/4/23 17:31, Marek Vasut wrote: > The maximum size of u-boot.itb in SPI NOR on DH STM32MP15 DHSOM is > 0x16 . Define this size in U-Boot config to prevent misconfigured > builds from emitting larger u-boot.itb than the one which fits the > SPI NOR area reserved for the blob. > > The SP

Re: [PATCH 1/2] arm: stm32: Enable TCP, IPv6, wget on DH STM32MP15 DHSOM

2023-11-08 Thread Patrice CHOTARD
On 11/4/23 17:31, Marek Vasut wrote: > Enable support for TCP protocol, wget, and IPv6 on this platform. > The former two allow users download payload into the U-Boot from > a web server, which may be more convenient or easier to set up > than TFTP server. The later is enabled to future proof th

[PATCH 1/2] drivers: watchdog: add andes atcwdt200 support

2023-11-08 Thread Randolph
This patch adds an implementation of the Andes watchdog ATCWDT200 driver. Signed-off-by: CL Wang Signed-off-by: Randolph --- drivers/watchdog/Kconfig | 6 + drivers/watchdog/Makefile| 1 + drivers/watchdog/atcwdt200_wdt.c | 219 +++ 3 files change

[PATCH 2/2] configs: andes: add watchdog support fot andes ae350

2023-11-08 Thread Randolph
It adds the ATCWDT200 support for Andes AE350 platform. It also enables wdt command support. Signed-off-by: CL Wang Signed-off-by: Randolph --- configs/ae350_rv32_defconfig | 4 configs/ae350_rv32_spl_defconfig | 4 configs/ae350_rv32_spl_xip_defconfig | 4 configs/ae

Re: [PATCH v6 08/25] spl: Refactor spl_load_info->read to use units of bytes

2023-11-08 Thread Xavier Drudis Ferran
El Wed, Nov 08, 2023 at 10:59:13AM -0500, Sean Anderson deia: > > OK, what about > > @offset: Offset to read from in bytes. This must be a multiple of > @load->bl_len. > > --Sean Great. Thank you.

[PATCH v3] arm64: zynqmp: Introduce kria SOM defconfig

2023-11-08 Thread Venkatesh Yadav Abbarapu
Enable the initial kria SOM specific configurations like pinctrl, pinconf etc. Also add the environment file. Signed-off-by: Venkatesh Yadav Abbarapu --- Changes in v2: - Updated the CONFIG_ENV_OFFSET_REDUND - Updated the CONFIG_SF_DEFAULT_SPEED to 3000 - Enabled the CONFIG_VIDEO_ZYNQMP_DPSUB

Re: [PATCH 6/6] rockchip: ringneck-px30: fix modified boot_targets detection

2023-11-08 Thread Kever Yang
On 2023/11/8 22:20, Quentin Schulz wrote: From: Quentin Schulz U-Boot proper automatically modifies boot_targets to swap the order in which MMC storage media are used for standard boot based on which MMC storage medium was used to load U-Boot proper. This is however only done if the user has

Re: [PATCH 5/6] rockchip: puma-rk3399: fix modified boot_targets detection

2023-11-08 Thread Kever Yang
On 2023/11/8 22:20, Quentin Schulz wrote: From: Quentin Schulz U-Boot proper automatically modifies boot_targets to swap the order in which MMC storage media are used for standard boot based on which MMC storage medium was used to load U-Boot proper. This is however only done if the user has

Re: [PATCH 4/6] rockchip: ringneck-px30: only declare functions in U-Boot proper

2023-11-08 Thread Kever Yang
On 2023/11/8 22:20, Quentin Schulz wrote: From: Quentin Schulz Those functions are useless in anything but U-Boot proper for now, so let's compile them out explicitly. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- board/theobroma-systems

Re: [PATCH 3/6] rockchip: puma-rk3399: only declare functions in U-Boot proper

2023-11-08 Thread Kever Yang
On 2023/11/8 22:20, Quentin Schulz wrote: From: Quentin Schulz Those functions are useless in anything but U-Boot proper for now, so let's compile them out explicitly. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- board/theobroma-systems

Re: [PATCH 2/6] env: migrate env_get_default to call env_get_default_into

2023-11-08 Thread Kever Yang
On 2023/11/8 22:20, Quentin Schulz wrote: From: Quentin Schulz Since both functions share a similar goal and env_get_default_into can do what env_get_default wants to do with specific arguments, let's make env_get_default call env_get_default_into so as to avoid code duplication. Cc: Quentin

Re: [PATCH 1/6] env: allow to copy value from default environment into a buffer

2023-11-08 Thread Kever Yang
On 2023/11/8 22:20, Quentin Schulz wrote: From: Quentin Schulz env_get_default suffers from a particular issue int that it can only return a value truncated to gd->env_buf (32) characters. This may be enough for most variables but it isn't for others, so let's allow users to provide a preallo

Re: [PATCH 1/2] configs: rockchip: Use dwc3-generic driver on RK3328 and RK3399

2023-11-08 Thread Kever Yang
Hi Jonas, Marek, On 2023/10/20 12:23, Marek Vasut wrote: On 10/19/23 22:39, Jonas Karlman wrote: On 2023-10-19 01:44, Marek Vasut wrote: On 10/19/23 00:30, Jonas Karlman wrote: [..] +++ b/configs/rock960-rk3399_defconfig @@ -50,6 +50,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y    CONFIG_SYS_MMC_ENV

[PATCH] riscv: binman: fix the load field format

2023-11-08 Thread Randolph
The #address-cells is now equal to 2. The format of the load field for the Linux kernel doesn't match. Signed-off-by: Randolph --- arch/riscv/dts/binman.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/riscv/dts/binman.dtsi b/arch/riscv/dts/binman.dtsi index 6b4eb8

Re: [PATCH] rockchip: rk3588-rock-5b: Enable CONFIG_PCI_INIT_R to support EFI networking

2023-11-08 Thread Kever Yang
Hi Martin and jonas, On 2023/11/4 21:04, Martin Roukala (né Peres) wrote: When u-boot chainloads an EFI bootloader such as iPXE, we want to have already initialized the PCI subsystem so that network driver is loaded and ready to use by the bootloader. Fixes: 191ece249a96 ("rockchip: rk3588-rock

Re: [PATCH] rockchip: ringneck-px30: enable i2c command

2023-11-08 Thread Kever Yang
On 2023/10/25 19:17, Quentin Schulz wrote: From: Quentin Schulz This is a useful tool to check the presence of a device on a specific i2c bus, so let's enable it. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- configs/ringneck-px30_defco

Re: [PATCH v11 00/24] Modernize U-Boot shell

2023-11-08 Thread Tom Rini
On Wed, Nov 08, 2023 at 12:14:28PM +, Peter Robinson wrote: > On Wed, Nov 8, 2023 at 12:49 AM Francis Laniel > wrote: > > > > Hi. > > > > > > During 2021 summer, Sean Anderson wrote a contribution to add a new shell, > > based > > on LIL, to U-Boot [1, 2]. > > While one of the goals of this c

Re: inconsistent wget behavior

2023-11-08 Thread Fabio Estevam
Hi Tom, On Wed, Nov 8, 2023 at 9:17 PM Tom Rini wrote: > Interesting. What if you take wget out of the equation and use "tftp" > to grab a large file with a known checksum, repeatedly (note that "rhash > -C" will give a crc32 in Linux so you can confirm the correct value and > loop a get, crc32

Re: [PATCH v11 00/24] Modernize U-Boot shell

2023-11-08 Thread Simon Glass
Hi Peter, On Wed, 8 Nov 2023 at 05:14, Peter Robinson wrote: > > On Wed, Nov 8, 2023 at 12:49 AM Francis Laniel > wrote: > > > > Hi. > > > > > > During 2021 summer, Sean Anderson wrote a contribution to add a new shell, > > based > > on LIL, to U-Boot [1, 2]. > > While one of the goals of this

Re: [PATCH v11 8/9] cmd: efidebug: add uri device path

2023-11-08 Thread Simon Glass
Hi Masahisa, On Wed, 8 Nov 2023 at 04:08, Masahisa Kojima wrote: > > This adds the URI device path option for 'boot add' subcommand. > User can add the URI load option for downloading ISO image file > or EFI application through network. Currently HTTP is only supported. > > Signed-off-by: Masahis

Re: [PATCH] scsi: Have scsi_init_dev_desc_priv() use memset

2023-11-08 Thread Simon Glass
On Wed, 8 Nov 2023 at 12:28, Tom Rini wrote: > > When we do not have CONFIG_BOUNCE_BUFFER enabled, inside of > scsi_init_dev_desc_priv we never set the 'bb' field to false, we only > initialize it to true when CONFIG_BOUNCE_BUFFER is set. Given that we > have a number of other fields here we had b

Re: [PATCH v7 08/26] spl: Refactor spl_load_info->read to use units of bytes

2023-11-08 Thread Simon Glass
On Wed, 8 Nov 2023 at 09:49, Sean Anderson wrote: > > Simplify things a bit for callers of spl_load_info->read by refactoring it > to use units of bytes instead of bl_len. This generally simplifies the > logic, as MMC is the only loader which actually works in sectors. It will > also allow further

Re: [PATCH] sysreset: Fix unsupported request return values

2023-11-08 Thread Simon Glass
On Wed, 8 Nov 2023 at 01:51, Paul Barker wrote: > > The description of the sysreset request method in says that > the return value should be -EPROTONOSUPPORT if the requested reset type > is not supported by this device. > > Signed-off-by: Paul Barker > --- > drivers/sysreset/poweroff_gpio.c

Re: [PATCH v7 02/26] arm: Disable SPL_FS_FAT when it isn't used

2023-11-08 Thread Simon Glass
On Wed, 8 Nov 2023 at 09:49, Sean Anderson wrote: > > Several boards enable SPL_FS_FAT and SPL_LIBDISK_SUPPORT when they can't be > used (as there is no block device support enabled). Disable these configs. > The list of boards was generated with the following command: > > $ tools/qconfig.py -

Re: [PATCH v7 10/26] spl: Remove filename from spl_load_info

2023-11-08 Thread Simon Glass
On Wed, 8 Nov 2023 at 09:49, Sean Anderson wrote: > > For filesystems, filename serves the same purpose as priv. However, > spl_load_fit_image also uses it to determine whether to use a DMA-aligned > buffer. This is beneficial for FAT, which uses a bounce-buffer if the > destination is not DMA-ali

Re: [PATCH v7 09/26] spl: Set FAT bl_len to ARCH_DMA_MINALIGN

2023-11-08 Thread Simon Glass
On Wed, 8 Nov 2023 at 09:49, Sean Anderson wrote: > > Instead of relying on the presence of filename to determine whether we are > dealing with a FAT filesystem (and should DMA-align the buffer), have FAT set > bl_len to ARCH_DMA_MINALIGN instead. With this done, we can remove the > special-case l

Re: [PATCH v11 2/9] net: wget: add wget with dns utility function

2023-11-08 Thread Simon Glass
On Wed, 8 Nov 2023 at 04:07, Masahisa Kojima wrote: > > Current wget takes the target uri in this format: > ":" e.g.) 192.168.1.1:/bar > The http server ip address must be resolved before > calling wget. > > This commit adds the utility function runs wget with dhs. > User can call wget with the

Re: [PATCH] net: Make NET imply NETDEVICES

2023-11-08 Thread Simon Glass
On Wed, 8 Nov 2023 at 17:12, Tom Rini wrote: > > Normally, when NET is enabled, CMD_NET will then be enabled and in turn > NETDEVICES will (likely) be enabled via imply. However, if we disable > CMDLINE in a defconfig we now no longer get CMD_NET enabling NETDEVICES > for us. This suggestion (as a

[PATCH 2/2] cmd: bcb: extend BCB C API to allow read/write the fields

2023-11-08 Thread Dmitrii Merkurev
Currently BCB C API only allows to modify 'command' BCB field. Extend it so that we can also read and modify all the available BCB fields (command, status, recovery, stage). Co-developed-by: Cody Schuffelen Signed-off-by: Cody Schuffelen Signed-off-by: Dmitrii Merkurev Cc: Eugeniu Rosca Cc: Yi

[PATCH 1/2] cmd: bcb: support various block device interfaces for BCB command

2023-11-08 Thread Dmitrii Merkurev
Currently BCB command-line, C APIs and implementation only support MMC interface. Extend it to allow various block device interfaces. Signed-off-by: Dmitrii Merkurev Cc: Eugeniu Rosca Cc: Ying-Chun Liu (PaulLiu) Cc: Simon Glass Cc: Mattijs Korpershoek Cc: Sean Anderson Cc: Cody Schuffelen -

[PATCH 0/2] cmd: bcb: extend BCB APIs to support Android boot flow

2023-11-08 Thread Dmitrii Merkurev
Following patches introduce various block interfaces support and extend API of BCB (bootloader control block) to reuse it for Android boot flow of Cuttlefish virtual device. Signed-off-by: Dmitrii Merkurev Cc: Eugeniu Rosca Cc: Ying-Chun Liu (PaulLiu) Cc: Simon Glass Cc: Mattijs Korpershoek C

Re: inconsistent wget behavior

2023-11-08 Thread Tom Rini
On Wed, Nov 08, 2023 at 09:00:23PM -0300, Fabio Estevam wrote: > [Adding Tom and Marek] > > On Wed, Nov 8, 2023 at 7:22 PM Tim Harvey wrote: > > > > Greetings, > > > > I've recently given wget/tcp a try and find the results inconsistent. > > > > Transferring the same file 15 times in a row will

[PATCH] net: Make NET imply NETDEVICES

2023-11-08 Thread Tom Rini
Normally, when NET is enabled, CMD_NET will then be enabled and in turn NETDEVICES will (likely) be enabled via imply. However, if we disable CMDLINE in a defconfig we now no longer get CMD_NET enabling NETDEVICES for us. This suggestion (as an imply is) really isn't about the network commands but

Re: inconsistent wget behavior

2023-11-08 Thread Fabio Estevam
[Adding Tom and Marek] On Wed, Nov 8, 2023 at 7:22 PM Tim Harvey wrote: > > Greetings, > > I've recently given wget/tcp a try and find the results inconsistent. > > Transferring the same file 15 times in a row will eventually give me > an incomplete transfer with packet/byte count wrong but showi

Re: [PATCH v11 24/24] DO NOT MERGE: ci: Build the world in any case.

2023-11-08 Thread Tom Rini
On Tue, Nov 07, 2023 at 11:41:21PM +0200, Francis Laniel wrote: > The CI can fails previously for reasons which are not tied to hush 2021. > Let's build the world in any case to check everything is OK there too. > > Signed-off-by: Francis Laniel > --- > .azure-pipelines.yml | 1 + > 1 file chan

inconsistent wget behavior

2023-11-08 Thread Tim Harvey
Greetings, I've recently given wget/tcp a try and find the results inconsistent. Transferring the same file 15 times in a row will eventually give me an incomplete transfer with packet/byte count wrong but showing 'Transfer Successful'. Here is current master on an imx8mp-venice-gw74xx board usi

[PATCH] scsi: Have scsi_init_dev_desc_priv() use memset

2023-11-08 Thread Tom Rini
When we do not have CONFIG_BOUNCE_BUFFER enabled, inside of scsi_init_dev_desc_priv we never set the 'bb' field to false, we only initialize it to true when CONFIG_BOUNCE_BUFFER is set. Given that we have a number of other fields here we had been explicitly setting to zero, change to first calling

Re: [PATCH v3 1/6] net: split IP_TCP header into separate IP/IP6 and TCP headers

2023-11-08 Thread Dmitrii Merkurev
Hey Tom, huge thanks for sharing that. I agree lwip is the proper way to handle this, will try out this patch set and eventually migrate fastboot apps into a new stack. On Wed, Nov 8, 2023 at 6:45 AM Tom Rini wrote: > On Tue, Jul 25, 2023 at 10:56:52PM +0100, Dmitrii Merkurev wrote: > > > This a

Re: [PATCH v1 2/2] fs: fat: calculate FAT type based on cluster count

2023-11-08 Thread Sean Anderson
On 11/8/23 13:57, Sean Anderson wrote: On 11/8/23 07:12, christian.taedcke-...@weidmueller.com wrote: From: Christian Taedcke This fixes an issue where the FAT type (FAT12, FAT16) is not correctly detected, e.g. when the BPB field BS_FilSysType contains the valid value "FAT ". According t

Re: [PATCH v1 2/2] fs: fat: calculate FAT type based on cluster count

2023-11-08 Thread Sean Anderson
On 11/8/23 07:12, christian.taedcke-...@weidmueller.com wrote: From: Christian Taedcke This fixes an issue where the FAT type (FAT12, FAT16) is not correctly detected, e.g. when the BPB field BS_FilSysType contains the valid value "FAT ". According to the FAT spec the field BS_FilSysType h

Re: [PATCH v2] clk: nuvoton: add read only feature for clk driver

2023-11-08 Thread Sean Anderson
On 11/7/23 04:01, Jim Liu wrote: Add a flag to set ahb/apb/fiu clock divider as read-only It just protects the clock source and can't modify it in uboot. Thanks for adding this Signed-off-by: Jim Liu --- Changes for v2: - add commit message --- drivers/clk/nuvoton/clk_npcm.c| 15 ++

Re: [PATCH v7 2/2] schemas: Add some common reserved-memory usages

2023-11-08 Thread Lean Sheng Tan
Hi Rob, Sure, I will ask if the edk2 developers who work together for UPL spec could help to respond here. Hi Ard, Regarding this part: *However, there is no scoping in DT schema as far as I am aware, which means that the OS may be forced/expected to interpret these regions beyond simply disregard

[PATCH] fs: ext4: Remove unused parameter from ext4_mount

2023-11-08 Thread Sean Anderson
The part_length parameter is not used. Remove it. Signed-off-by: Sean Anderson --- common/spl/spl_ext.c | 4 ++-- env/ext4.c| 4 ++-- fs/ext4/ext4_common.c | 2 +- fs/ext4/ext4fs.c | 2 +- include/ext4fs.h | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --g

Re: [PATCH v3 0/2] rng: Provide a RNG based on the RISC-V Zkr ISA extension

2023-11-08 Thread Palmer Dabbelt
On Tue, 07 Nov 2023 15:12:16 PST (-0800), Conor Dooley wrote: +CC Palmer On Tue, Nov 07, 2023 at 05:38:37PM -0500, Tom Rini wrote: On Tue, Nov 07, 2023 at 10:27:50PM +, Conor Dooley wrote: > On Tue, Nov 07, 2023 at 05:10:23PM -0500, Tom Rini wrote: > > > > further clarify or not > > the

Re: [PATCH v2 7/8] board: ti: j721e: During resume spl restores TF-A and DM-Firmware

2023-11-08 Thread Andrew Davis
On 11/7/23 10:18 AM, Thomas Richard wrote: During the boot a copy of DM-Firmware is done in a reserved memory area before it starts. When resuming, R5 SPL uses this copy of DM-Firmware instead of the fit image. TF-A which saved itself in this same memory area, is restored in SRAM by R5 SPL. Base

[PATCH next v2 6/6] rockchip: rk3128: remove noop file

2023-11-08 Thread Quentin Schulz
From: Quentin Schulz arch_cpu_init is already returning 0 in its weak definition in common/board_f.c so let's just remove the file entirely since nothing else is done in it. Cc: Quentin Schulz Signed-off-by: Quentin Schulz --- arch/arm/mach-rockchip/rk3128/Makefile | 1 - arch/arm/mach-rockc

[PATCH next v2 5/6] rockchip: remove unused global data ptr

2023-11-08 Thread Quentin Schulz
From: Quentin Schulz Remove leftover import and global data ptr from files since they aren't used anymore. Cc: Quentin Schulz Signed-off-by: Quentin Schulz --- arch/arm/mach-rockchip/board.c | 3 --- arch/arm/mach-rockchip/rk3128/rk3128.c | 3 --- arch/arm/mach-rockchip/rk3308/rk3308.

[PATCH next v2 4/6] rockchip: rk3588: insert u-boot, spl-boot-device into U-Boot device tree

2023-11-08 Thread Quentin Schulz
From: Quentin Schulz It is possible to boot U-Boot proper from a different storage medium than the one used by the BOOTROM to load the SPL. This information is stored in the u-boot,spl-boot-device Device Tree property and is accessible from U-Boot proper so that it has knowledge at runtime where

[PATCH next v2 3/6] rockchip: factor out spl_perform_fixups into common spl-boot-order

2023-11-08 Thread Quentin Schulz
From: Quentin Schulz All SoCs are susceptible to wanting to know which storage medium was used to load U-Boot SPL. So instead of reimplementing the same functions in SoCs over and over again (here just rk3399 and px30 but rk3588 is coming), let's just put all this in common into spl-boot-order.c

[PATCH next v2 2/6] rockchip: px30: simplify logic for getting SPL boot medium DT node

2023-11-08 Thread Quentin Schulz
From: Quentin Schulz In preparation of moving spl_perform_fixups to spl-boot-order.c, let's simplify the logic around mapping the BOOT_DEVICE_x enum index to a DT node by using an instantiated array of chars instead of creating a new data structure on the fly. This will make it easier to only de

[PATCH next v2 1/6] rockchip: rk3399: simplify logic for getting SPL boot medium DT node

2023-11-08 Thread Quentin Schulz
From: Quentin Schulz In preparation of moving spl_perform_fixups to spl-boot-order.c, let's simplify the logic around mapping the BOOT_DEVICE_x enum index to a DT node by using an instantiated array of chars instead of creating a new data structure on the fly. This will make it easier to only de

[PATCH next v2 0/6] rockchip: rk3588: add support for detecting U-Boot proper boot medium

2023-11-08 Thread Quentin Schulz
It is possible to boot U-Boot proper from a different storage medium than the one used by the BOOTROM to load the SPL. This information is stored in the u-boot,spl-boot-device Device Tree property and is accessible from U-Boot proper so that it has knowledge at runtime where it was loaded from. Th

Re: [PATCH v3 0/2] rng: Provide a RNG based on the RISC-V Zkr ISA extension

2023-11-08 Thread Heinrich Schuchardt
On 11/8/23 08:44, Tom Rini wrote: On Wed, Nov 08, 2023 at 07:25:22AM -0800, Heinrich Schuchardt wrote: On 11/8/23 06:37, Tom Rini wrote: On Wed, Nov 08, 2023 at 06:23:37AM -0800, Heinrich Schuchardt wrote: On 11/7/23 16:34, Tom Rini wrote: On Wed, Nov 08, 2023 at 12:29:03AM +, Conor Doole

Re: [PATCH v6 7/8] clk: treewide: switch to clock dump from clk_ops

2023-11-08 Thread Sean Anderson
On 11/5/23 03:38, Igor Prusov wrote: Switch to using new dump operation in clock provider drivers instead of overriding soc_clk_dump. Signed-off-by: Igor Prusov Tested-by: Patrice Chotard Reviewed-by: Sean Anderson --- arch/mips/mach-pic32/cpu.c | 23 drivers/c

Re: [PATCH v6 6/8] cmd: clk: Use dump function from clk_ops

2023-11-08 Thread Sean Anderson
On 11/5/23 03:38, Igor Prusov wrote: Add another loop to dump additional info from clock providers that implement dump operation. Signed-off-by: Igor Prusov Reviewed-by: Patrice Chotard Tested-by: Patrice Chotard --- cmd/clk.c | 9 + 1 file changed, 9 insertions(+) diff --git a/cm

Re: [PATCH v6 5/8] clk: Add dump operation to clk_ops

2023-11-08 Thread Sean Anderson
On 11/5/23 03:38, Igor Prusov wrote: This adds dump function to struct clk_ops which should replace soc_clk_dump. It allows clock drivers to provide custom dump implementation without overriding generic CCF dump function. Signed-off-by: Igor Prusov Reviewed-by: Patrice Chotard Tested-by: Patri

Re: [UBOOT PATCH v3] test/py: net: Add a TFTP put test

2023-11-08 Thread Tom Rini
On Wed, Nov 08, 2023 at 12:40:31PM +0530, Love Kumar wrote: > Execute tftpput command for uploading files to a server and validate its > size & CRC32. > > Signed-off-by: Love Kumar Thanks for reworking this. After changing tftp server so I could upload files, this is working as I was hoping it

[PATCH v7 24/26] spl: Convert spi to spl_load

2023-11-08 Thread Sean Anderson
This converts the spi load method to use spl_load. The address used for LOAD_FIT_FULL may be different, but there are no in-tree users of that config. Since payload_offs is only used without OS_BOOT, we defer its initialization. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no chan

[PATCH v7 26/26] spl: fat: Add option to disable DMA alignment

2023-11-08 Thread Sean Anderson
If we don't DMA-align buffers we pass to FAT, it will align them itself. This behaviour likely should be deprecated in favor of CONFIG_BOUNCE_BUFFER, but that's a task for another series. For the meantime, don't bother aligning the buffer unless we had been doing so in the past. Signed-off-by: Sea

[PATCH v7 25/26] spl: spi: Consolidate spi_load_image_os into spl_spi_load_image

2023-11-08 Thread Sean Anderson
spi_load_image_os performs almost the same steps as the non-falcon-boot path of spl_spi_load_image. The load address is different, and it also loads a device tree, but that's it. Refactor the boot process so that they can both use the same load function. Signed-off-by: Sean Anderson Reviewed-by:

[PATCH v7 23/26] spl: Convert semihosting to spl_load

2023-11-08 Thread Sean Anderson
This converts the semihosting load method to use spl_load. As a result, it also adds support for LOAD_FIT_FULL and IMX images. Signed-off-by: Sean Anderson --- (no changes since v6) Changes in v6: - Explicitly initialize load_info members Changes in v5: - Rework to load header in spl_load Cha

[PATCH v7 21/26] spl: Convert nor to spl_load

2023-11-08 Thread Sean Anderson
This converts the nor load method to use spl_load. As a result it also adds support for LOAD_FIT_FULL. Since this is the last caller of spl_load_legacy_img, it has been removed. We can't load FITs with external data with SPL_LOAD_FIT_FULL, so disable the test in that case. No boards enable SPL_NOR

[PATCH v7 20/26] spl: Convert net to spl_load

2023-11-08 Thread Sean Anderson
This converts the net load method to use spl_load. As a result, it also adds support for LOAD_FIT_FULL and IMX images. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v6) Changes in v6: - Explicitly initialize load_info members Changes in v5: - Rework to load heade

[PATCH v7 22/26] spl: Convert NVMe to spl_load

2023-11-08 Thread Sean Anderson
This converts the blk load method (used exclusively by NVMe) to use spl_load. As a consequence, it also adds support for LOAD_FIT_FULL and IMX images. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v6) Changes in v6: - Fix invalid return from spl_blk_load_image - E

[PATCH v7 19/26] spl: Convert nand to spl_load

2023-11-08 Thread Sean Anderson
This converts the nand load method to use spl_load. nand_page_size may not be valid until after nand_spl_load_image is called (see e.g. fsl_ifc_spl), so we set bl_len in spl_nand_read. Since spl_load reads the header for us, we can remove that argument from spl_nand_load_element. There are two pos

[PATCH v7 18/26] spl: Convert mmc to spl_load

2023-11-08 Thread Sean Anderson
This converts the mmc loader to spl_load. Legacy images are handled by spl_load (via spl_parse_image_header), so mmc_load_legacy can be omitted. To accurately determine whether mmc_load_image_raw_sector is used (which might not be the case if SYS_MMCSD_FS_BOOT is enabled), we introduce a helper con

Re: [PATCH 1/3] board: ti: common: add rtc setup to common folder

2023-11-08 Thread Tom Rini
On Wed, Nov 08, 2023 at 09:46:34AM -0600, Bryan Brattlof wrote: > On November 7, 2023 thus sayeth Tom Rini: > > On Tue, Nov 07, 2023 at 05:21:41PM -0600, Bryan Brattlof wrote: > > > > > All of the starter kit boards for the am62xxx extended family utilize > > > the same 32k crystal oscillator for

[PATCH v7 17/26] spl: Convert fat to spl_load

2023-11-08 Thread Sean Anderson
This converts the fat loader to use spl_load. Some platforms are very tight on space, so we take care to only include the code we really need. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v5) Changes in v5: - Rework to load header in spl_load Changes in v3: - Fi

[PATCH v7 15/26] spl: Add generic spl_load function

2023-11-08 Thread Sean Anderson
Implementers of SPL_LOAD_IMAGE_METHOD have to correctly determine what type of image is being loaded and then call the appropriate image load function correctly. This is tricky, because some image load functions expect the whole image to already be loaded (CONFIG_SPL_LOAD_FIT_FULL), some will load

[PATCH v7 16/26] spl: Convert ext to use spl_load

2023-11-08 Thread Sean Anderson
This converts the ext load method to use spl_load. As a consequence, it also adds support for FIT and IMX images. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v6) Changes in v6: - Explicitly initialize load_info members Changes in v5: - Rework to load header in

[PATCH v7 14/26] test: spl: Support testing LEGACY_LZMA filesystem images

2023-11-08 Thread Sean Anderson
These will soon be supported, so we need to be able to test it. Export the lzma data and generally use the same process in spl_test_mmc_fs as do_spl_test_load. If we end up needing this in third place in the future, it would probably be good to refactor things out. Signed-off-by: Sean Anderson R

[PATCH v7 10/26] spl: Remove filename from spl_load_info

2023-11-08 Thread Sean Anderson
For filesystems, filename serves the same purpose as priv. However, spl_load_fit_image also uses it to determine whether to use a DMA-aligned buffer. This is beneficial for FAT, which uses a bounce-buffer if the destination is not DMA-aligned. However, this is unnecessary now that filesystems set b

[PATCH v7 13/26] spl: legacy: Split off LZMA decompression into its own function

2023-11-08 Thread Sean Anderson
To allow for easier reuse of this functionality, split it off into its own function. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v6) Changes in v6: - New common/spl/spl_legacy.c | 73 ++--- include/spl.h | 13 +

[PATCH v7 11/26] spl: Only support bl_len when we have to

2023-11-08 Thread Sean Anderson
Aligning addresses and sizes causes overhead which is unnecessary when we are not loading from block devices. Remove bl_len when it is not needed. For example, on iot2050 we save 144 bytes with this patch (once the rest of this series is applied): add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-144

[PATCH v7 12/26] spl: nand: Remove spl_nand_legacy_read

2023-11-08 Thread Sean Anderson
Now that spl_nand_fit_read works in units of bytes, it can be combined with spl_nand_legacy_read. Rename the resulting function spl_nand_read, since it is no longer FIT-specific. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v6) Changes in v6: - New common/spl/s

[PATCH v7 08/26] spl: Refactor spl_load_info->read to use units of bytes

2023-11-08 Thread Sean Anderson
Simplify things a bit for callers of spl_load_info->read by refactoring it to use units of bytes instead of bl_len. This generally simplifies the logic, as MMC is the only loader which actually works in sectors. It will also allow further refactoring to remove the special-case handling of filename.

[PATCH v7 09/26] spl: Set FAT bl_len to ARCH_DMA_MINALIGN

2023-11-08 Thread Sean Anderson
Instead of relying on the presence of filename to determine whether we are dealing with a FAT filesystem (and should DMA-align the buffer), have FAT set bl_len to ARCH_DMA_MINALIGN instead. With this done, we can remove the special-case logic checking for the presence of filename. Because filesyst

[PATCH v7 07/26] spl: Take advantage of bl_len's power-of-twoness

2023-11-08 Thread Sean Anderson
bl_len must be a power of two, so we can use ALIGN instead of roundup and similar tricks to avoid divisions. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v6) Changes in v6: - New common/spl/spl_fit.c | 2 +- common/spl/spl_imx_container.c | 8

[PATCH v7 06/26] spl: Remove dev from spl_load_info

2023-11-08 Thread Sean Anderson
dev and priv serve the same purpose, and are never set at the same time. Remove dev and convert all users to priv. While we're at it, reorder bl_len to be last for better alignment. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- Changes in v7: - Fix typo in commit message Changes in

[PATCH v7 05/26] spl: Remove NULL assignments in spl_load_info

2023-11-08 Thread Sean Anderson
Remove NULL assignments to fields in spl_load_info when .load doesn't reference these fields. This can result in more efficient code. filename must stay even if it is unused, since load_simple_fit uses it. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v6) Changes

[PATCH v7 04/26] spl: semihosting: Don't close fd before spl_load_simple_fit

2023-11-08 Thread Sean Anderson
On real hardware, semihosting calls tend to have a large constant overhead (on the order of tens of milliseconds). Reduce the number of calls by one by reusing the existing fd in smh_fit_read, and closing it at the end of spl_smh_load_image. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass

[PATCH v7 03/26] spl: Make SHOW_ERRORS depend on LIBCOMMON

2023-11-08 Thread Sean Anderson
The purpose of SHOW_ERRORS is to print extra information. Make it depend on LIBCOMMON to avoid having to check for two configs. Signed-off-by: Sean Anderson Reviewed-by: Tom Rini Reviewed-by: Simon Glass --- (no changes since v5) Changes in v5: - New common/spl/Kconfig | 1 + common/spl/spl

[PATCH v7 02/26] arm: Disable SPL_FS_FAT when it isn't used

2023-11-08 Thread Sean Anderson
Several boards enable SPL_FS_FAT and SPL_LIBDISK_SUPPORT when they can't be used (as there is no block device support enabled). Disable these configs. The list of boards was generated with the following command: $ tools/qconfig.py -f SPL SPL_FS_FAT ~SPL_MMC ~SPL_BLK_FS ~SPL_SATA \

[PATCH v7 01/26] spl: blk_fs: Fix uninitialized return value when we can't get a blk_desc

2023-11-08 Thread Sean Anderson
Initialize ret to avoid returning garbage if blk_get_devnum_by_uclass_id fails. Fixes: 8ce6a2e1757 ("spl: blk: Support loading images from fs") Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v6) Changes in v6: - New common/spl/spl_blk_fs.c | 2 +- 1 file changed,

[PATCH v7 00/26] spl: Use common function for loading/parsing images

2023-11-08 Thread Sean Anderson
This series adds support for loading all image types (Legacy (with and without LZMA), FIT (with and without LOAD_FIT_FULL), and i.MX) to the MMC, SPI, NOR, NET, FAT, EXT, NVMe, and semihosting load methods. It does this by introducing a helper function which handles the minutiae of invoking the pro

Re: [PATCH v3 0/2] rng: Provide a RNG based on the RISC-V Zkr ISA extension

2023-11-08 Thread Tom Rini
On Wed, Nov 08, 2023 at 07:25:22AM -0800, Heinrich Schuchardt wrote: > On 11/8/23 06:37, Tom Rini wrote: > > On Wed, Nov 08, 2023 at 06:23:37AM -0800, Heinrich Schuchardt wrote: > > > On 11/7/23 16:34, Tom Rini wrote: > > > > On Wed, Nov 08, 2023 at 12:29:03AM +, Conor Dooley wrote: > > > > > O

[PATCH v2 5/5] pmic: qcom: dont use dev_read_addr to get USID

2023-11-08 Thread Caleb Connolly
Linux DTs stuff a value indicating if the USID is a USID or a GSID in the reg property, the Linux SPMI driver then reads the two address cells separately. U-boot's dev_read_addr() doesn't know how to handle this, so use ofnode_read_u32_index() to get just the USID. The Qcom pmic driver doesn't hav

[PATCH v2 4/5] spmi: msm: fix register range names

2023-11-08 Thread Caleb Connolly
The core and chnl register ranges were swapped on SDM845. Fix it, and fetch the register ranges by name instead of by index. Drop the cosmetic "version" variable and clean up the debug logging. Signed-off-by: Caleb Connolly --- arch/arm/dts/sdm845.dtsi | 2 +- drivers/spmi/spmi-msm.c | 46 +++

[PATCH v2 2/5] gpio: qcom_pmic: rework pwrkey driver into a button driver

2023-11-08 Thread Caleb Connolly
The power and resin keys were implemented as GPIOs here, but their only use would be as buttons. Avoid the additional layer of introspection and rework this driver into a button driver. While we're here, replace the "qcom,pm8998-pwrkey" compatible with "qcom,pm8941-pwrkey" to match upstream (Linux

[PATCH v2 3/5] gpio: qcom_pmic: fix support for upstream DT

2023-11-08 Thread Caleb Connolly
Linux devicetrees use the "gpio-ranges" property, add support for parsing it instead of "gpio-count" so that upstream DTs can be used with U-Boot. Signed-off-by: Caleb Connolly --- drivers/gpio/qcom_pmic_gpio.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drive

[PATCH v2 1/5] gpio: qcom_pmic: fix silent dev_read_addr downcast

2023-11-08 Thread Caleb Connolly
priv->pid is uint32_t, but dev_read_addr() returns a uint64_t on arm64, with the upper bits being used for error codes. Do error checking before downcasting to u32 to prevent errors being silently ignored. Signed-off-by: Caleb Connolly --- drivers/gpio/qcom_pmic_gpio.c | 14 ++ 1 fil

[PATCH v2 0/5] Qualcomm PMIC fixes

2023-11-08 Thread Caleb Connolly
This series addresses some long-standing issues with the SPMI arb driver, the PMIC, and the PMIC GPIO. It fixes compatibility with upstream Linux devicetrees, and simplifies pwrkey/resin support by rewriting the pon driver to be a button driver rather than a GPIO driver. Existing users are adjuste

Re: [PATCH v6 06/25] spl: Remove dev from spl_load_info

2023-11-08 Thread Sean Anderson
On 11/7/23 23:23, Simon Glass wrote: Hi Sean, On Sun, 5 Nov 2023 at 19:26, Sean Anderson wrote: dev and priv server the same purpose, and are never set at the same time. serve Remove dev and convert all users to priv. While we're at it, reorder bl_len to be last for better alignment. It

Re: [PATCH] clk: exynos: Add header guard for clk-pll.h

2023-11-08 Thread Sean Anderson
On 11/7/23 16:22, Sam Protsenko wrote: The clk-pll.h is going to be included in multiple files soon. Add missing header guard to prevent possible build errors in future. Signed-off-by: Sam Protsenko Fixes: 166097e87753 ("clk: exynos: add clock driver for Exynos7420 Soc") --- drivers/clk/exyno

Re: rockpro64 rk3399 dwc3 issue

2023-11-08 Thread Shantur Rathore
On Wed, Nov 8, 2023 at 2:50 PM Peter Robinson wrote: > > Hi, > > > I am trying to boot OS via USB3.0 ports on RK3399 base RockPro64. > > U-boot is failing to detect the drive in the USB3.0 port. > > > > If I boot linux through other mediums the drive is detected and works fine. > > Can anyone plea

Re: [PATCH 0/6] siemens,am335x: clean up the draco board family

2023-11-08 Thread Tom Rini
On Wed, Nov 08, 2023 at 03:53:16PM +0100, Enrico Leto wrote: > The boards were not maintained upstream since the development phase. > > Restore SPL and remove unused settings. We need i2c to read the DDR > settings from EEPROM, get u-boot from NAND, the console output and the > watchdog. > > Res

Re: [PATCH v6 08/25] spl: Refactor spl_load_info->read to use units of bytes

2023-11-08 Thread Sean Anderson
On 11/7/23 03:49, Xavier Drudis Ferran wrote: El Mon, Nov 06, 2023 at 08:54:03AM -0500, Sean Anderson deia: On 11/6/23 07:35, Xavier Drudis Ferran wrote: Thanks for your work. I'm still reading... but... El Sun, Nov 05, 2023 at 09:25:46PM -0500, Sean Anderson deia: diff --git a/include/spl.h

Re: [PATCH v2 1/2] driver: power: add support for TPS65224

2023-11-08 Thread Bhargav Raviprakash
Hello Jaehoon, > > Hi Bhargav, > > > > On Mon, 6 Nov 2023 at 10:11, Bhargav Raviprakash wrote: > > > > > > Added support for PMIC TPS65224. Includes driver for pmic, > > > and disabling Watchdog. > > > > > > Signed-off-by: Bhargav Raviprakash > > > --- > > > drivers/power/pmic/Kconfig| 6

Re: [PATCH v6 16/25] spl: Convert fat to spl_load

2023-11-08 Thread Sean Anderson
On 11/7/23 23:24, Simon Glass wrote: Hi Sean, On Sun, 5 Nov 2023 at 19:26, Sean Anderson wrote: This converts the fat loader to use spl_load. Some platforms are very tight on space, so we take care to only include the code we really need. Signed-off-by: Sean Anderson --- (no changes since

  1   2   >