On Wed, Nov 08, 2023 at 03:53:16PM +0100, Enrico Leto wrote: > The boards were not maintained upstream since the development phase. > > Restore SPL and remove unused settings. We need i2c to read the DDR > settings from EEPROM, get u-boot from NAND, the console output and the > watchdog. > > Restore u-boot up to the user prompt. The complete functionality will > be restored in future patches. > > Signed-off-by: Enrico Leto <enrico.l...@siemens.com>
I'm glad to see this series and in general it looks fine and is a good start. As some parts of the future cleanup work I'd love to see a file under doc/board/siemens for the family and moving to plain text environment, both of which iot2050 do so there's some in-house experience I am hopeful you can leverage as well if needed. It would also be good to reduce the include/configs/ files to as little as possible, I believe there's a number of dead-comments there, and other defines that are only needed in a local context and can move to a specific file or other header. Thanks! -- Tom
signature.asc
Description: PGP signature
