Re: [PATCH] net: eth-uclass: Improve error message when MAC is not found

2023-10-19 Thread Lothar Waßmann
Hi, On Thu, 19 Oct 2023 18:57:20 -0300 Fabio Estevam wrote: > From: Fabio Estevam > > While bringinp up a new board without the MAC fuses programmed, > the following error message was observed: > > Error: ethernet@30bf address not set. > > Improve the error message to make it clearer the r

Re: [PATCH 2/3] arm: mvebu: Espressobin: move network setup into a separate function

2023-10-19 Thread Stefan Roese
Hi Robert, On 9/18/23 08:47, Stefan Roese wrote: On 9/14/23 12:16, Robert Marko wrote: Currently, Esspresobin switch is being setup directly in last_stage_init() which makes it hard to add support for any other board to be setup. So, lets just move the switch setup code to a separate function

Re: [PATCH] arm: mvebu: AC5/AC5X: use fixed page table size

2023-10-19 Thread Stefan Roese
Hi Chris, On 10/18/23 22:53, Chris Packham wrote: Since commit 6cdf6b7a340d ("arm64: Use FEAT_HAFDBS to track dirty pages when available") the default get_page_table_size() sets some flags for more efficient handling of dirty page table entries. This causes problems on the AC5/AC5X SoC (specific

Re: [RESEND PATCH] arm: kirkwood: Pogo v4: Enable LTO

2023-10-19 Thread Stefan Roese
On 10/16/23 22:01, Tony Dinh wrote: Enable building Pogo V4 u-boot image with LTO, which results in about 30K reduction in size. Rebased to latest master and resend. Nitpicking: In such cases, please generate a v2 and put this description in the patch history below the "---" line. No need to

Re: [PATCH 1/8] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-10-19 Thread Masahisa Kojima
Hi Sughosh, On Fri, 8 Sept 2023 at 21:00, Sughosh Ganu wrote: > > Add support for specifying the parameters needed for capsule > generation through a config file, instead of passing them through > command-line. Parameters for more than a single capsule file can be > specified, resulting in genera

[PATCH] arm64: zynqmp: Disable Tri-state for MIO38 Pin

2023-10-19 Thread Tejas Bhumkar
gpio38 is used in SOM's kv260 to reset the Ethernet PHY. At present, HW reset is not working properly as Tri-state?? is enabled for MIO38, causing inappropriate PHY register reads. Disabled Tri-state for MIO38 to make HW reset work. Tri-state disable : ZynqMP> md 0xFF180208 2 ff180208: 00bfe7a3 0

Re: [PATCH] mmc: renesas-sdhi: Fix error handling in rzg2l_sdhi_setup

2023-10-19 Thread Marek Vasut
On 10/19/23 16:50, Paul Barker wrote: We should ensure that reset_free() is called in the error path. Signed-off-by: Paul Barker Fixes: 93c811b7331b ("mmc: renesas-sdhi: Initialize module on RZ/G2L") --- drivers/mmc/renesas-sdhi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) dif

Re: [PATCH 1/2] configs: rockchip: Use dwc3-generic driver on RK3328 and RK3399

2023-10-19 Thread Marek Vasut
On 10/19/23 22:39, Jonas Karlman wrote: On 2023-10-19 01:44, Marek Vasut wrote: On 10/19/23 00:30, Jonas Karlman wrote: [..] +++ b/configs/rock960-rk3399_defconfig @@ -50,6 +50,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y CONFIG_SYS_MMC_ENV_DEV=1 CONFIG_ROCKCHIP_GPIO=y CONFIG_SYS_I2C_ROCKCHIP

Re: [PATCH] clock_imx8mm: Add a stub for imx8mp_fec_interface_init()

2023-10-19 Thread Marek Vasut
On 10/20/23 02:47, Fabio Estevam wrote: From: Fabio Estevam When CONFIG_DWC_ETH_QOS_IMX=y and CONFIG_FEC_MXC is not selected, the following warning is seen: arch/arm/mach-imx/imx8m/clock_imx8mm.c: In function 'board_interface_eth_init': arch/arm/mach-imx/imx8m/clock_imx8mm.c:914:24: warning: i

[PATCH] mpc85xx: relocate code in non-SPL build

2023-10-19 Thread Martin Fäcknitz
When building a non-SPL image, relocation is needed. This patch restores the old behaviour before commit b35316fb67: CONFIG_SPL_SKIP_RELOCATE was only defined if CONFIG_SPL_BUILD was defined. Fixes: b35316fb67cb ("Convert CONFIG_SPL_INIT_MINIMAL et al to Kconfig") Signed-off-by: Martin Fäcknitz -

How to use USB_HOST for at91 OHCI USB

2023-10-19 Thread Afshin Pir
Hi all I want to use usb command and usb mass storage with at91 ohci. These features depend on USB_HOST, but I found that USB_ATMEL option does not select USB_HOST and I don't know why. How can I do this? Best Regards This email is confidential and may contain i

[PATCH v3 6/6] spi: zynq_qspi: Add parallel memories support in QSPI driver

2023-10-19 Thread Venkatesh Yadav Abbarapu
Add support for parallel memories in zynq_qspi.c driver. In case of parallel memories STRIPE bit is set and sent to the qspi ip, which will send data bits to both the flashes in parallel. However for few commands we should not use stripe, instead send same data to both the flashes. Those commands a

[PATCH v3 4/6] spi: spi-uclass: Read chipselect and restrict capabilities

2023-10-19 Thread Venkatesh Yadav Abbarapu
From: Ashok Reddy Soma Read chipselect properties from DT which are populated using 'reg' property and save it in plat->cs[] array for later use. Also read multi chipselect capability which is used for parallel-memories and return errors if they are passed on using DT but driver is not capable o

[PATCH v3 5/6] spi: zynqmp_gqspi: Add parallel memories support in GQSPI driver

2023-10-19 Thread Venkatesh Yadav Abbarapu
Add support for parallel memories in zynqmp_gqspi.c driver. In case of parallel memories STRIPE bit is set and sent to the qspi ip, which will send data bits to both the flashes in parallel. However for few commands we should not use stripe, instead send same data to both the flashes. Those command

[PATCH v3 3/6] mtd: spi-nor: Add parallel and stacked memories support in read_bar and write_bar

2023-10-19 Thread Venkatesh Yadav Abbarapu
From: Ashok Reddy Soma Add support for parallel memories and stacked memories configuration in read_bar and write_bar functions. Signed-off-by: Ashok Reddy Soma Signed-off-by: Venkatesh Yadav Abbarapu --- drivers/mtd/spi/spi-nor-core.c | 55 +- 1 file changed,

[PATCH v3 2/6] mtd: spi-nor: Add parallel memories support for read_sr and read_fsr

2023-10-19 Thread Venkatesh Yadav Abbarapu
From: Ashok Reddy Soma Add support for parallel memories flash configuration in read status register and read flag status register functions. Signed-off-by: Ashok Reddy Soma Signed-off-by: Venkatesh Yadav Abbarapu --- drivers/mtd/spi/spi-nor-core.c | 50 -- 1 f

[PATCH v3 1/6] mtd: spi-nor: Add parallel and stacked memories support

2023-10-19 Thread Venkatesh Yadav Abbarapu
From: Ashok Reddy Soma In parallel mode, the current implementation assumes that a maximum of two flashes are connected. The QSPI controller splits the data evenly between both the flashes so, both the flashes that are connected in parallel mode should be identical. During each operation SPI-NOR

[PATCH v3 0/6] spi-nor: Add parallel and stacked memories support

2023-10-19 Thread Venkatesh Yadav Abbarapu
This series adds support for Xilinx qspi parallel and stacked memeories. In parallel mode, the current implementation assumes that a maximum of two flashes are connected. The QSPI controller splits the data evenly between both the flashes so, both the flashes that are connected in parallel mode sh

Re: [PATCH 2/2] bootcount: Add driver model I2C driver

2023-10-19 Thread Heiko Schocher
Hello Philip, On 18.10.23 18:10, Simon Glass wrote: > Hi Philip, > > On Wed, 18 Oct 2023 at 05:00, Philip Oberfichtner > wrote: >> >> Hi Heiko, >> >> On Wed, Oct 18, 2023 at 06:31:57AM +0200, Heiko Schocher wrote: >> > [...] >> > >> > May Philip can use uclass_get_device_by_

Re: Branches in uboot-imx

2023-10-19 Thread Fabio Estevam
Hi Grzegorz, On Thu, Oct 19, 2023 at 11:58 AM Grzegorz Borowiak wrote: > > Hello! > > I just cloned the repository: > > https://github.com/nxp-imx/uboot-imx This is a U-Boot fork maintained by NXP. Only NXP can help you with this one. > and I encountered a rather large amount of branches (list

[PATCH] clock_imx8mm: Add a stub for imx8mp_fec_interface_init()

2023-10-19 Thread Fabio Estevam
From: Fabio Estevam When CONFIG_DWC_ETH_QOS_IMX=y and CONFIG_FEC_MXC is not selected, the following warning is seen: arch/arm/mach-imx/imx8m/clock_imx8mm.c: In function 'board_interface_eth_init': arch/arm/mach-imx/imx8m/clock_imx8mm.c:914:24: warning: implicit declaration of function 'imx8mp_

Re: Falcon mode on RISC-V

2023-10-19 Thread Randolph Lin
On Thu, Oct 19, 2023 at 10:49:56PM +0200, Heinrich Schuchardt wrote: Hi Heinrich > Hello Randolph, > > I just saw your patches merged to enable Falcon mode on RISC-V using > CONFIG_SPL_LOAD_FIT_OPENSBI_OS_BOOT. I did not see any documentation update. > > Should information about your development

Re: [PATCH v3 22/32] efi: Update EFI_LOADER to depend on DM_ETH

2023-10-19 Thread AKASHI Takahiro
On Thu, Oct 19, 2023 at 08:01:11AM -0600, Simon Glass wrote: > Hi Heinrich, > > On Wed, 18 Oct 2023 at 06:55, Heinrich Schuchardt wrote: > > > > On 10/17/23 16:09, Tom Rini wrote: > > > On Mon, Oct 16, 2023 at 04:28:13PM -0600, Simon Glass wrote: > > > > > >> Since efi_device_path.c calls eth_get

[PATCH 3/3] sunxi: dts: arm: add T113s/D1 DT files from Linux-v6.6-rc6

2023-10-19 Thread Andre Przywara
This copies in some devicetree files from the official Linux kernel tree, v6.6-rc6. It covers a board with the Allwinner T113s SoC, which shares many devices with its RISC-V sibling, the Allwinner D1(s). This is the reason for the core .dtsi files landing in the arch/riscv directory. We are only a

[PATCH 1/3] sunxi: dts: arm64: update devicetree files from Linux-v6.6-rc6

2023-10-19 Thread Andre Przywara
Sync the devicetree files from the official Linux kernel tree, v6.6-rc6. This is covering Allwinner SoCs with 64-bit ARM cores. Only small cosmetic changes (clock name fixed), but we add the DT for the new OrangePi Zero 3 board, for which U-Boot enablement patches are pending. As before, this omi

[PATCH 2/3] sunxi: dts: arm: update devicetree files from Linux-v6.6-rc6

2023-10-19 Thread Andre Przywara
Sync the devicetree files from the official Linux kernel tree, v6.6-rc6. This is covering Allwinner SoCs with 32-bit ARM cores, minus the T113s board and related .dtsi files, which come separately. Only small changes: Bluetooth got enabled on the C.H.I.P., and a clock got renamed. More interesting

[PATCH 0/3] sunxi: devicetree updates from Linux v6.6

2023-10-19 Thread Andre Przywara
This updates the devicetree files to match the Linux kernel repository as of v6.6-rc6. Mostly cosmetic changes, but we gain some new board files and the T113s board .dtsi files, which are needed for the pending U-Boot patches. Split per architecture, with the T113s being separate due to its RISC-V

Re: [PATCH v2 02/22] net: sunxi_emac: chase DT nodes to find PHY regulator

2023-10-19 Thread Samuel Holland
Hi Andre, On 9/28/23 16:54, Andre Przywara wrote: > At the moment the sun4i EMAC driver relies on hardcoded CONFIG_MACPWR > Kconfig symbols to enable potential PHY regulators. As we want to get rid > of those, we need to find the regulator by chasing up the DT. > > The sun4i-emac binding puts the

Re: [PATCH v2 12/22] clk: sunxi: Add support for the D1 CCU

2023-10-19 Thread Samuel Holland
On 9/28/23 16:54, Andre Przywara wrote: > From: Samuel Holland > > Since the D1 CCU binding is defined, we can add support for its > gates/resets, following the pattern of the existing drivers. > > Signed-off-by: Samuel Holland > Reviewed-by: Andre Przywara > Acked-by: Sean Anderson > Signed-

Re: [PATCH v2 01/22] sunxi: remove CONFIG_SATAPWR

2023-10-19 Thread Samuel Holland
On 9/28/23 16:54, Andre Przywara wrote: > The CONFIG_SATAPWR Kconfig symbol was used to point to a GPIO that > enables the power for a SATA harddisk. > In the DT this is described with the target-supply property in the AHCI > DT node, pointing to a (GPIO controlled) regulator. Since we need SATA >

Re: [PATCH] board: synquacer: Update the flash image layout

2023-10-19 Thread Masahisa Kojima
On Thu, 19 Oct 2023 at 22:54, Ilias Apalodimas wrote: > > The SynQuacer Developerbox, in EFI mode, supports A/B capsule > updates and single image ones. The flash layout in the latter case is > outdated, update it with the new offsets and images > > Signed-off-by: Ilias Apalodimas > --- > board/

Re: [PATCH v13 0/8] tpm: Support boot measurements

2023-10-19 Thread Ilias Apalodimas
Hi Eddie, Does the series compile for you against -master? For qemu_arm64_defonfig I am getting compilation errors both locally and on the CI https://source.denx.de/u-boot/custodians/u-boot-tpm/-/jobs/717362#L39 Thanks /Ilias On Thu, 19 Oct 2023 at 19:45, Ilias Apalodimas wrote: > > Thanks Eddi

[PATCH] net: eth-uclass: Improve error message when MAC is not found

2023-10-19 Thread Fabio Estevam
From: Fabio Estevam While bringinp up a new board without the MAC fuses programmed, the following error message was observed: Error: ethernet@30bf address not set. Improve the error message to make it clearer the reason of the failure. Signed-off-by: Fabio Estevam --- net/eth-uclass.c |

Re: [PATCH v3 2/2] imx8mp_evk: Remove unneeded header files

2023-10-19 Thread Hugo Villeneuve
On Thu, 19 Oct 2023 18:51:13 -0300 Fabio Estevam wrote: > From: Fabio Estevam > > Cleanup the file by removing unneeded header files. > > Signed-off-by: Fabio Estevam Reviewed-by: Hugo Villeneuve > --- > Changes since v2: > - Also remove and DECLARE_GLOBAL_DATA_PTR. (Hugo) > > board/fr

[PATCH v3 2/2] imx8mp_evk: Remove unneeded header files

2023-10-19 Thread Fabio Estevam
From: Fabio Estevam Cleanup the file by removing unneeded header files. Signed-off-by: Fabio Estevam --- Changes since v2: - Also remove and DECLARE_GLOBAL_DATA_PTR. (Hugo) board/freescale/imx8mp_evk/imx8mp_evk.c | 13 - 1 file changed, 13 deletions(-) diff --git a/board/freesca

[PATCH v3 1/2] imx8mp_evk: Simplify Ethernet initialization

2023-10-19 Thread Fabio Estevam
From: Fabio Estevam With DM enabled, there is no need for board code to initialize the Ethernet interfaces. The RTL8211FDI Ethernet PHYs have 25MHz oscillator, so there is no need to enable the RGMII TX clk output. Also, there is no need for describing the deprecated phy-reset FEC properties, n

Falcon mode on RISC-V

2023-10-19 Thread Heinrich Schuchardt
Hello Randolph, I just saw your patches merged to enable Falcon mode on RISC-V using CONFIG_SPL_LOAD_FIT_OPENSBI_OS_BOOT. I did not see any documentation update. Should information about your development be added to doc/develop/falcon.rst? Would you be willing to provide a patch? Best regards

Re: [RESEND PATCH v1 1/2] spi: add support for Amlogic A1 SPI Flash Controller

2023-10-19 Thread Igor Prusov
On Tue, Oct 17, 2023 at 09:33:02PM -0600, Simon Glass wrote: > Hi Igor, > > On Tue, 17 Oct 2023 at 11:18, Igor Prusov wrote: > > > > From: Igor Prusov > > > > Add A1 SPIFC driver from Linux. Slightly modified to use u-boot driver > > framework and accommodate to lack of ioread32_rep/iowrite32_re

Re: [PATCH 1/2] configs: rockchip: Use dwc3-generic driver on RK3328 and RK3399

2023-10-19 Thread Jonas Karlman
On 2023-10-19 01:44, Marek Vasut wrote: > On 10/19/23 00:30, Jonas Karlman wrote: > > [..] > >> +++ b/configs/rock960-rk3399_defconfig >> @@ -50,6 +50,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y >> CONFIG_SYS_MMC_ENV_DEV=1 >> CONFIG_ROCKCHIP_GPIO=y >> CONFIG_SYS_I2C_ROCKCHIP=y >> +CONFIG_MISC=y >>

Re: [PATCH v2 1/2] imx8mp_evk: Simplify Ethernet initialization

2023-10-19 Thread Hugo Villeneuve
On Thu, 19 Oct 2023 16:21:54 -0300 Fabio Estevam wrote: > From: Fabio Estevam > > With DM enabled, there is no need for board code to initialize > the Ethernet interfaces. > > The RTL8211FDI Ethernet PHYs have 25MHz oscillator, so there is no > need to enable the RGMII TX clk output. > > Also

Re: [PATCH v2 2/2] mx8mp_evk: Remove unneeded header files

2023-10-19 Thread Hugo Villeneuve
On Thu, 19 Oct 2023 16:21:55 -0300 Fabio Estevam wrote: > From: Fabio Estevam > > Cleanup the file by removing unneeded header files. > > Signed-off-by: Fabio Estevam > --- > Changes since v1: > - Newly introduced. (Hugo) > > board/freescale/imx8mp_evk/imx8mp_evk.c | 10 -- > 1 file

Re: CONFIG_SPL_SKIP_RELOCATE in non-SPL build

2023-10-19 Thread Tom Rini
On Thu, Oct 19, 2023 at 03:30:25PM +0200, Martin Fäcknitz wrote: > Hello, > > The patch > Convert CONFIG_SPL_INIT_MINIMAL et al to Kconfig > (b35316fb67cb7aeaf022032ce078135251372f39) > > changes the behaviour for non-SPL builds when relocating code. The patch > sets the CONFIG_SPL_SKIP_RELOC

[PATCH] imx8mn-var-som: Simplify FEC initialization

2023-10-19 Thread Hugo Villeneuve
From: Hugo Villeneuve With DM enabled, there is no need for board code to initialize the FEC interface. The ethernet PHYs on the symphony carrier board have a dedicated crystal/oscillator. If the SOM has the EC configuration option (onboard ethernet PHY), it also has a dedicated crystal/oscillat

[PATCH] imx8mn_var_som: Add myself to MAINTAINERS

2023-10-19 Thread Hugo Villeneuve
From: Hugo Villeneuve I would like to help maintaining the imx8mn_var_som symphony board. Add myself to MAINTAINERS. Signed-off-by: Hugo Villeneuve --- board/variscite/imx8mn_var_som/MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/board/variscite/imx8mn_var_som/MAINTAINERS b/

[PATCH v2 2/2] mx8mp_evk: Remove unneeded header files

2023-10-19 Thread Fabio Estevam
From: Fabio Estevam Cleanup the file by removing unneeded header files. Signed-off-by: Fabio Estevam --- Changes since v1: - Newly introduced. (Hugo) board/freescale/imx8mp_evk/imx8mp_evk.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/board/freescale/imx8mp_evk/imx8mp_evk.c

[PATCH v2 1/2] imx8mp_evk: Simplify Ethernet initialization

2023-10-19 Thread Fabio Estevam
From: Fabio Estevam With DM enabled, there is no need for board code to initialize the Ethernet interfaces. The RTL8211FDI Ethernet PHYs have 25MHz oscillator, so there is no need to enable the RGMII TX clk output. Also, there is no need for describing the deprecated phy-reset FEC properties, n

Re: [PATCH] imx8mp_evk: Simplify FEC initialization

2023-10-19 Thread Hugo Villeneuve
On Thu, 19 Oct 2023 14:04:41 -0300 Fabio Estevam wrote: > From: Fabio Estevam > > With DM enabled, there is no need for board code to initialize > the FEC interface. > > The RTL8211FDI Ethernet PHYs have 25MHz oscillator, so there is no > need to enable the RGMII TX clk output. > > Also, ther

Re: [PATCH v13 6/8] doc: Add measured boot documentation

2023-10-19 Thread Heinrich Schuchardt
On 10/19/23 18:21, Eddie James wrote: Briefly describe the feature and specify the requirements. Signed-off-by: Eddie James Reviewed-by: Simon Glass --- Changes since v12: - Add a bit of detail about OS usage and what pieces are measured doc/usage/index.rst | 1 + doc/usage/meas

Re: [PATCH v13 7/8] efi_loader: fix EFI_ENTRY point on get_active_pcr_banks

2023-10-19 Thread Heinrich Schuchardt
On 10/19/23 18:21, Eddie James wrote: From: Ilias Apalodimas efi_tcg2_get_active_pcr_banks doesn't immediately call the EFI_ENTRY() wrapper once it enters the function. Move the call a few lines above to cover the error cases properly as well. Signed-off-by: Ilias Apalodimas Reviewed-by: He

Re: [PATCH 1/9] DO NOT MERGE: arm: dts: k3-j7200-r5-common: Add pmic node for esm

2023-10-19 Thread Nishanth Menon
On 14:42-20231019, Thomas Richard wrote: > On 10/16/23 18:29, Nishanth Menon wrote: > > On 16:11-20231016, Thomas Richard wrote: > >> From: Gowtham Tammana > >> > >> Add pmic tps659413 node needed for ESM error event handling. > >> > >> Si

[PULL] u-boot-sh/master_uart_test

2023-10-19 Thread Marek Vasut
The following changes since commit e463222cce0df86f05a117f06e1737f539841fe6: Merge branch 'master' of https://source.denx.de/u-boot/custodians/u-boot-riscv (2023-10-19 09:40:04 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-sh.git master_uart

[PATCH] imx8mp_evk: Simplify FEC initialization

2023-10-19 Thread Fabio Estevam
From: Fabio Estevam With DM enabled, there is no need for board code to initialize the FEC interface. The RTL8211FDI Ethernet PHYs have 25MHz oscillator, so there is no need to enable the RGMII TX clk output. Also, there is no need for describing the deprecated phy-reset properties in u-boot.dt

Re: [PATCH v13 0/8] tpm: Support boot measurements

2023-10-19 Thread Ilias Apalodimas
Thanks Eddie I've queued this up on public CI. I also have an internal one, this one failed to add the TF-A eventlog, but everything else looks fine. I'll have a look tomorrow, but since this used to work on earlier versions I suspect it's going to be trivial to fix Cheers /Ilias On Thu, 19 Oct

[PATCH v13 4/8] bootm: Support boot measurement

2023-10-19 Thread Eddie James
Add a configuration option to measure the boot through the bootm function. Add the measurement state to the booti and bootz paths as well. Signed-off-by: Eddie James Reviewed-by: Simon Glass --- Changes since v8: - Added a configuration option to select to ignore any existing event log. This

[PATCH v13 8/8] test: use a non system PCR for testing PCR extend

2023-10-19 Thread Eddie James
From: Ilias Apalodimas We currently use PCR 0 for testing the PCR read/extend functionality in our selftests. How ever those PCRs are defined by the TCG spec for platform use. For example if the tests run *after* the efi subsystem initialization, which extends PCRs 0 & 7 it will give a false po

[PATCH v13 3/8] tpm: Support boot measurements

2023-10-19 Thread Eddie James
Add TPM2 functions to support boot measurement. This includes starting up the TPM, initializing/appending the event log, and measuring the U-Boot version. Much of the code was used in the EFI subsystem, so remove it there and use the common functions. Signed-off-by: Eddie James --- Changes since

[PATCH v13 6/8] doc: Add measured boot documentation

2023-10-19 Thread Eddie James
Briefly describe the feature and specify the requirements. Signed-off-by: Eddie James Reviewed-by: Simon Glass --- Changes since v12: - Add a bit of detail about OS usage and what pieces are measured doc/usage/index.rst | 1 + doc/usage/measured_boot.rst | 31

[PATCH v13 5/8] test: Add sandbox TPM boot measurement

2023-10-19 Thread Eddie James
Use the sandbox TPM driver to measure some boot images in a unit test case. Signed-off-by: Eddie James Reviewed-by: Simon Glass Acked-by: Ilias Apalodimas --- Changes since v5: - Only compile in the measurement u-boot command when CONFIG_MEASURED_BOOT is enabled. arch/sandbox/dts/sandbox.

[PATCH v13 7/8] efi_loader: fix EFI_ENTRY point on get_active_pcr_banks

2023-10-19 Thread Eddie James
From: Ilias Apalodimas efi_tcg2_get_active_pcr_banks doesn't immediately call the EFI_ENTRY() wrapper once it enters the function. Move the call a few lines above to cover the error cases properly as well. Signed-off-by: Ilias Apalodimas --- lib/efi_loader/efi_tcg2.c | 4 ++-- 1 file changed,

[PATCH v13 1/8] tpm: Fix spelling for tpmu_ha union

2023-10-19 Thread Eddie James
tmpu -> tpmu Signed-off-by: Eddie James Reviewed-by: Ilias Apalodimas --- include/tpm-v2.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/tpm-v2.h b/include/tpm-v2.h index 2b6980e441..6684033deb 100644 --- a/include/tpm-v2.h +++ b/include/tpm-v2.h @@ -169,7 +169

[PATCH v13 2/8] tpm: sandbox: Update for needed TPM2 capabilities

2023-10-19 Thread Eddie James
The driver needs to support getting the PCRs in the capabilities command. Fix various other things and support the max number of PCRs for TPM2. Remove the !SANDBOX dependency for EFI TCG2 as well. Signed-off-by: Eddie James Reviewed-by: Simon Glass Acked-by: Ilias Apalodimas --- Changes since v

[PATCH v13 0/8] tpm: Support boot measurements

2023-10-19 Thread Eddie James
This series adds support for measuring the boot images more generically than the existing EFI support. Several EFI functions have been moved to the TPM layer. The series includes optional measurement from the bootm command. A new test case has been added for the bootm measurement to test the new p

Re: [PATCH v12 6/8] doc: Add measured boot documentation

2023-10-19 Thread Eddie James
On 10/12/23 10:29, Simon Glass wrote: Hi Eddie, On Thu, 12 Oct 2023 at 08:08, Eddie James wrote: Briefly describe the feature and specify the requirements. Signed-off-by: Eddie James Reviewed-by: Simon Glass This could use a bit more detail. What pieces are measured? What DT binding is u

Re: [PATCH v2 1/1] efi_loader: expose the device-tree file name

2023-10-19 Thread Heinrich Schuchardt
On 19.10.23 15:55, Simon Glass wrote: Hi Heinrich, On Wed, 18 Oct 2023 at 02:15, Heinrich Schuchardt wrote: On 10/18/23 05:33, Simon Glass wrote: Hi Heinrich, On Tue, 17 Oct 2023 at 07:50, Heinrich Schuchardt wrote: Forward and backward compatibility of Linux kernel device-trees is somet

Re: [PATCH v5 00/11] spl: Use common function for loading/parsing images

2023-10-19 Thread Tom Rini
On Wed, Oct 18, 2023 at 01:33:20PM -0400, Sean Anderson wrote: > On 8/3/23 00:41, Heinrich Schuchardt wrote: > > On 8/3/23 03:31, Tom Rini wrote: > > > On Wed, Aug 02, 2023 at 09:13:21PM -0400, Sean Anderson wrote: > > > > On 8/2/23 16:11, Tom Rini wrote: > > > > > On Mon, Jul 31, 2023 at 06:42:52P

Re: [PATCH 6/6] led: add TI LP5562 LED driver

2023-10-19 Thread Marek Vasut
On 10/19/23 11:58, Rasmus Villemoes wrote: From: Doug Zobel Driver for the TI LP5562 4 channel LED controller. Supports independent on/off control of all 4 channels. Supports LED_BLINK on 3 independent channels: blue/green/red. The white channel can blink, but shares the blue channel blink rate

Re: [PATCH 4/6] led: led_gpio: use led_bind_generic() helper

2023-10-19 Thread Marek Vasut
On 10/19/23 11:58, Rasmus Villemoes wrote: Commit message is missing.

Re: [PATCH 5/6] led: led_pwm: use led_bind_generic() helper

2023-10-19 Thread Marek Vasut
On 10/19/23 11:58, Rasmus Villemoes wrote: Commit message is missing.

Re: [PATCH 3/6] led: introduce led_bind_generic()

2023-10-19 Thread Marek Vasut
On 10/19/23 11:58, Rasmus Villemoes wrote: All existing drivers in drivers/led/ contain a .bind method that does exactly the same thing, with just the actual driver name differing. Create a helper so all those individual methods can be changed to one-liners. Signed-off-by: Rasmus Villemoes Re

Re: [PATCH 2/6] led-uclass: honour ->label field populated by driver's own .bind

2023-10-19 Thread Marek Vasut
On 10/19/23 11:58, Rasmus Villemoes wrote: If the driver's own .bind method has populated uc_plat->label, don't override that. This is necessary for an upcoming driver for ti,lp5562, where the DT binding unfortunately says to use "chan-name" and not "label". Signed-off-by: Rasmus Villemoes ---

Re: [PATCH 1/6] led-uclass: do not create fallback label for top-level node

2023-10-19 Thread Marek Vasut
On 10/19/23 11:58, Rasmus Villemoes wrote: Many existing drivers, and led-uclass itself, rely on uc_plat->label being NULL for the device representing the top node, as opposed to the child nodes representing individual LEDs. This means that the drivers whose .probe methods rely on this were broke

Re: [RESEND PATCH v1 1/2] spi: add support for Amlogic A1 SPI Flash Controller

2023-10-19 Thread Igor Prusov
On Tue, Oct 17, 2023 at 09:33:02PM -0600, Simon Glass wrote: > Hi Igor, > > On Tue, 17 Oct 2023 at 11:18, Igor Prusov wrote: > > > > From: Igor Prusov > > > > Add A1 SPIFC driver from Linux. Slightly modified to use u-boot driver > > framework and accommodate to lack of ioread32_rep/iowrite32_re

Re: [v4 11/24] efi: Rearrange the Kconfig for CMD_BOOTEFI_BOOTMGR

2023-10-19 Thread Tom Rini
On Thu, Oct 19, 2023 at 05:24:33PM +0200, Heinrich Schuchardt wrote: > On 19.10.23 17:19, Tom Rini wrote: > > On Thu, Oct 19, 2023 at 05:16:28PM +0200, Heinrich Schuchardt wrote: > > > On 19.10.23 17:00, Tom Rini wrote: > > > > From: Simon Glass > > > > > > > > The command should not be used to e

Re: [v4 11/24] efi: Rearrange the Kconfig for CMD_BOOTEFI_BOOTMGR

2023-10-19 Thread Heinrich Schuchardt
On 19.10.23 17:19, Tom Rini wrote: On Thu, Oct 19, 2023 at 05:16:28PM +0200, Heinrich Schuchardt wrote: On 19.10.23 17:00, Tom Rini wrote: From: Simon Glass The command should not be used to enable library functionality. Add a new BOOTEFI_BOOTMGR Kconfig for that. Adjust the conditions so tha

Re: [v4 11/24] efi: Rearrange the Kconfig for CMD_BOOTEFI_BOOTMGR

2023-10-19 Thread Tom Rini
On Thu, Oct 19, 2023 at 05:16:28PM +0200, Heinrich Schuchardt wrote: > On 19.10.23 17:00, Tom Rini wrote: > > From: Simon Glass > > > > The command should not be used to enable library functionality. Add a > > new BOOTEFI_BOOTMGR Kconfig for that. Adjust the conditions so that the > > same code i

Re: [v4 11/24] efi: Rearrange the Kconfig for CMD_BOOTEFI_BOOTMGR

2023-10-19 Thread Heinrich Schuchardt
On 19.10.23 17:00, Tom Rini wrote: From: Simon Glass The command should not be used to enable library functionality. Add a new BOOTEFI_BOOTMGR Kconfig for that. Adjust the conditions so that the same code is built. Signed-off-by: Simon Glass Suggested-by: AKASHI Takahiro --- Cc: Heinrich Sch

[PATCH] common: Reword CONSOLE_RECORD_.*SIZE help texts

2023-10-19 Thread Tom Rini
Make it clear that in the options for setting the console record buffer sizes that we are talking about buffers for that feature specifically and not the general console buffers. Signed-off-by: Tom Rini --- common/Kconfig | 16 1 file changed, 8 insertions(+), 8 deletions(-) di

[v4 24/24] clk_k210.c: Clean up how we handle nop

2023-10-19 Thread Tom Rini
Now that sandbox has and defines nop() there we should include that in our driver for clarity and then remove our local nop() from . Signed-off-by: Tom Rini --- I can see that our ARM should be and updated in a few other ways to match how the kernel is currently. This is not a big deal yet as

[v4 23/24] sandbox: Add

2023-10-19 Thread Tom Rini
Add a mostly empty asm/barrier.h file for sandbox where we define nop() to be an empty function. Signed-off-by: Tom Rini --- arch/sandbox/include/asm/barrier.h | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 arch/sandbox/include/asm/barrier.h diff --git a/arch/sandbox/include/asm/b

[v4 22/24] sandbox: Avoid requiring CMDLINE

2023-10-19 Thread Tom Rini
From: Simon Glass Add some dependencies on features that we had been selecting so that we can still disable CMDLINE. Signed-off-by: Simon Glass Signed-off-by: Tom Rini --- Changes in v4: - Reword the commit slightly (Tom) - Rework overall to select if CMDLINE Changes in v3: - Reorder the Kcon

[v4 21/24] sandbox: Disable CONFIG_DISTRO_DEFAULTS

2023-10-19 Thread Tom Rini
From: Simon Glass This is not used for sandbox, so drop it. Enable the things that it controls to avoid dstrastic changes in the config settings for sandbox builds. The end result is that these are enabled: BOOTMETH_DISTRO BOOTSTD_DEFAULTS and these are disabled: USE_BOOTCOMMAND B

[v4 20/24] cmd: Make most commands depend on CMDLINE

2023-10-19 Thread Tom Rini
From: Simon Glass If we disable CMDLINE then we should not ask about enabling the hush parser nor any of the commands that would be run on the command line as it is no longer available. Convert the CMDLINE option into a menuconfig and make every command referenced under cmd/Kconfig depend on it.

[v4 19/24] boot: Make preboot and bootcmd require CMDLINE

2023-10-19 Thread Tom Rini
In order for a predefined "preboot" or "bootcmd" to be executed by the running system we must have a command line. Add CMDLINE as a dependency. Signed-off-by: Tom Rini --- boot/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/boot/Kconfig b/boot/Kconfig index 40a04f43ee3d..fabf6fec

[v4 18/24] bootmeth_script: Depend on CMDLINE

2023-10-19 Thread Tom Rini
As this particular bootmeth requires the command line and assorted commands to function, make sure we have CMDLINE enabled. Signed-off-by: Tom Rini --- boot/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/boot/Kconfig b/boot/Kconfig index 7c92e0974c5f..40a04f43ee3d

[v4 17/24] bootmeth_cros: Require bootm.o and bootm_os.o

2023-10-19 Thread Tom Rini
In order to use bootmeth_cros, at least on non-X86, we need to be able to start any type of kernel that the "bootm" code paths can handle. Add these objects to the required list for this option. Signed-off-by: Tom Rini --- Cc: Simon Glass --- boot/Makefile | 2 +- 1 file changed, 1 insertion(+

[v4 15/24] boot: Rework BOOT_DEFAULTS to allow for CMDLINE to be disabled

2023-10-19 Thread Tom Rini
We split BOOT_DEFAULTS to have BOOT_DEFAULTS_FEATURES and BOOT_DEFAULTS_CMDS that in turn list general features or commands that we want enabled when BOOT_DEFAULTS is selected. We only select BOOT_DEFAULTS_CMDS if CMDLINE is set. Signed-off-by: Tom Rini --- boot/Kconfig | 23 +++

[v4 14/24] boot: Make DISTRO_DEFAULTS select CMDLINE

2023-10-19 Thread Tom Rini
The implementation of DISTRO_DEFAULTS is done in environment scripts and requires the command line in order to work. Because of this, select CMDLINE here. Signed-off-by: Tom Rini --- boot/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/boot/Kconfig b/boot/Kconfig index 0dbd10a93469..

[v4 16/24] boot: Move SYS_BOOTM_LEN to be by LEGACY_IMAGE_FORMAT

2023-10-19 Thread Tom Rini
This particular option is required for booting all image types, regardless of if we are starting an OS via command line or something else. Move the question for SYS_BOOTM_LEN to be by the question for LEGACY_IMAGE_FORMAT, as that's where our generic OS questions start. Signed-off-by: Tom Rini --

[v4 11/24] efi: Rearrange the Kconfig for CMD_BOOTEFI_BOOTMGR

2023-10-19 Thread Tom Rini
From: Simon Glass The command should not be used to enable library functionality. Add a new BOOTEFI_BOOTMGR Kconfig for that. Adjust the conditions so that the same code is built. Signed-off-by: Simon Glass Suggested-by: AKASHI Takahiro --- Cc: Heinrich Schuchardt Cc: Ilias Apalodimas Change

[v4 13/24] autoboot: Correct dependencies on CMDLINE

2023-10-19 Thread Tom Rini
From: Simon Glass Make AUTOBOOT depend on CMDLINE since it is mostly meaningless without it. Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- boot/Kconfig | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/boot/Kconfig b/boot/Kconfig index

[v4 12/24] bootmeth: Make BOOTMETH_EFILOADER depend on CMD_BOOTEFI

2023-10-19 Thread Tom Rini
Today, the bootmeth for using the EFI loader via bootefi depends on calling the bootefi command directly, so make this in turn depend on CMD_BOOTEFI. Signed-off-by: Tom Rini --- boot/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/boot/Kconfig b/boot/Kconfig index

[v4 10/24] cli_simple: Rework this support slightly

2023-10-19 Thread Tom Rini
The interactive portion of our non-HUSH 'simple' parser is guarded by CONFIG_CMDLINE already. Much of the code behind this simple parser is also used as "input" parser, such as from menu interfaces and so forth and not strictly command line input. To support this, always build the assorted cli ob

[v4 08/24] test: Make UNIT_TEST depend on CMDLINE

2023-10-19 Thread Tom Rini
From: Simon Glass Many tests make some use of the command line, so require it for all test code. This could be teased apart, perhaps with a test flag indicating that it uses the command line. Leave that for later. Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- test/Kconfig | 1 + 1 fil

[v4 09/24] video: Don't require the font command

2023-10-19 Thread Tom Rini
From: Simon Glass While it is nice to have the font command, using 'select' makes it impossible to build the console code without it. Stop using 'select' and make it default if CONSOLE_TRUETYPE is enabled when asking the command. Signed-off-by: Simon Glass Signed-off-by: Tom Rini --- Changes i

[v4 07/24] env: Move env_set() out of cmd/nvedit.c and in to env/common.c

2023-10-19 Thread Tom Rini
Inside of env/common.c we already have our helper env_set_xxx functions, and even have a comment that explains why env_set() itself wasn't moved. We now handle that move. This requires that we rename the previous _do_env_set() to env_do_env_set() and note it as an internal env function. Add comment

[v4 06/24] Kconfig: Move CONFIG_SYS_[CP]BSIZE to common/Kconfig

2023-10-19 Thread Tom Rini
Move CONFIG_SYS_CBSIZE (console buffer size) and CONFIG_SYS_PBSIZE (console print buffer size) out of cmd/Kconfig and in to common/Kconfig. Create help entries for both which explain their usage and why they are both not entirely command centric. Signed-off-by: Tom Rini --- cmd/Kconfig| 14 -

[v4 05/24] qemu: Correct CMD_QFW dependencies in Kconfig

2023-10-19 Thread Tom Rini
Rather than selecting CMD_QFW, we should make the option itself by enabled by default on these platforms. Then in the board-specific Kconfig we should select the appropriate back-end as needed if the command is enabled. Signed-off-by: Tom Rini --- Cc: Tuomas Tynkkynen Cc: Bin Meng --- board/e

[v4 04/24] version: Separate our version string from the version command

2023-10-19 Thread Tom Rini
In order to be able to disable all commands we need to construct our version string in a common file, and have the version command reference that string, like the other users of it do. Create common/version.c with just the strings. Signed-off-by: Tom Rini --- cmd/version.c| 9 - co

[v4 03/24] dfu: Make DFU_TFTP depend on NETDEVICES

2023-10-19 Thread Tom Rini
In order to do a DFU update over TFTP we need to have some network device available, so make this depend on NETDEVICES Signed-off-by: Tom Rini --- drivers/dfu/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dfu/Kconfig b/drivers/dfu/Kconfig index 4e80e85d10d7..8771678ca5a0 10

[v4 02/24] virtio: Make VIRTIO_NET depend on NETDEVICES

2023-10-19 Thread Tom Rini
As VIRTIO_NET is the symbol for enabling network devices, make this depend on NETDEVICES Signed-off-by: Tom Rini --- Cc: Bin Meng --- drivers/virtio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig index 852f6735b602..1d

  1   2   >