Re: [PATCH 1/1] acpi: Add missing RISC-V acpi_table header

+Simon, On Tue, Jul 25, 2023 at 9:30 AM Heinrich Schuchardt wrote: > > The pci_mmc.c driver can generate ACPI info and therefore includes > asm/acpi_table.h. This file does not exist for the RISC-V architecture > and thus code compilation fails when using this driver on RISC-V Which header file

RE: [PATCH 1/1] dm: adc: imx93-adc depends on ADC (fix boot)

> -Original Message- > From: Sébastien Szymanski > Sent: 2023年7月24日 23:18 > To: u-boot@lists.denx.de > Cc: Bough Chen ; Luca Ellero ; > Sébastien Szymanski > Subject: [PATCH 1/1] dm: adc: imx93-adc depends on ADC (fix boot) > > The i.MX93 11x11 EVK fails to boot with following error: >

Re: [PATCH] xhci_register: Fix double free on failure

On Tue, Jul 25, 2023 at 3:45 AM Richard Habeeb wrote: > > drivers/core/device.c will call `device_free()` after xhci_register > already frees the private device data. This can cause a crash later > during the boot process, observed on aarch64 RPi4b as a synchronous > exception. All callers of xhci

[PATCH 1/1] acpi: Add missing RISC-V acpi_table header

The pci_mmc.c driver can generate ACPI info and therefore includes asm/acpi_table.h. This file does not exist for the RISC-V architecture and thus code compilation fails when using this driver on RISC-V Create an empty include file. Signed-off-by: Heinrich Schuchardt --- arch/riscv/include/asm/

Re: [PATCH v7 4/4] riscv: dts: starfive: Enable PCIe host controller

On Thu, Jul 20, 2023 at 07:23:33PM +0800, Minda Chen wrote: > From: Mason Huo > > Enable and add pinctrl configuration for PCIe host controller. > > Signed-off-by: Mason Huo > Signed-off-by: Minda Chen > --- > .../dts/jh7110-starfive-visionfive-2.dtsi | 11 +++ > arch/riscv/dts/jh7110.dts

Re: [PATCH v7 3/4] configs: starfive-jh7110: Add support for PCIe host driver

On Thu, Jul 20, 2023 at 07:23:32PM +0800, Minda Chen wrote: > From: Mason Huo > > Add PCIe host driver and nvme driver in configure file. > > Signed-off-by: Mason Huo > Signed-off-by: Minda Chen > --- > configs/starfive_visionfive2_defconfig | 8 > 1 file changed, 8 insertions(+) Re

Re: [PATCH v7 2/4] starfive: pci: Add StarFive JH7110 pcie driver

On Thu, Jul 20, 2023 at 07:23:31PM +0800, Minda Chen wrote: > From: Mason Huo > > Add pcie driver for StarFive JH7110, Also add PLDA > PCIe controller common driver functions. > > Several devices are tested: > a) M.2 NVMe SSD > b) Realtek 8169 Ethernet adapter. > > Signed-off-by: Mason Huo > S

Re: [PATCH v15 00/10] introduce Arm FF-A support

On Thu, Jul 13, 2023 at 02:28:37PM +0100, Abdellatif El Khlifi wrote: > Adding support for Arm FF-A v1.0 (Arm Firmware Framework for Armv8-A) [A]. > > FF-A specifies interfaces that enable a pair of software execution > environments aka partitions to > communicate with each other. A partition cou

Re: [PATCH v3 3/3] board: toradex: add verdin am62 support

On Mon, Jul 24, 2023 at 08:34:04PM +, Marcel Ziswiler wrote: > Hi Nishanth > > On Fri, 2023-07-21 at 08:37 -0500, Nishanth Menon wrote: > > On 09:40-20230715, Marcel Ziswiler wrote: > > > From: Marcel Ziswiler > > > > > > This adds initial support for the Toradex Verdin AM62 Quad 1GB WB IT >

Re: [PATCH v2 1/1] spl: CONFIG_SPL_PCI_PNP should depend on CONFIG_SPL_PCI

On Mon, Jul 24, 2023 at 09:27:26PM +0200, Heinrich Schuchardt wrote: > CONFIG_SPL_PCI_PNP=y without CONFIG_SPL_PCI=y makes no sense. > > Fixes: 32f5e9e5c1a7 ("nvme: pci: Enable for SPL") > Signed-off-by: Heinrich Schuchardt Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signat

Re: [PATCH v2 1/1] spl: initialize PCI before booting

On Mon, Jul 24, 2023 at 10:18:41PM +0200, Heinrich Schuchardt wrote: > MMC, SATA, and USB may be using PCI based controllers. > Initialize the PCI sub-system before trying to boot. > > Remove the initialization for NVMe that is now redundant. > > Signed-off-by: Heinrich Schuchardt Reviewed-by:

Re: Please pull u-boot-dm

On Mon, Jul 24, 2023 at 12:31:55PM -0600, Simon Glass wrote: > Hi Tom, > > https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/17032 > > > The following changes since commit be71a05a417deb5fcea8e39e557f890626ab2352: > > Merge branch '2023-07-22-TI-binman-and-K3-improvements' (2023

Re: [PATCH v15 00/10] introduce Arm FF-A support

On Thu, 13 Jul 2023 14:28:37 +0100, Abdellatif El Khlifi wrote: > Adding support for Arm FF-A v1.0 (Arm Firmware Framework for Armv8-A) [A]. > > FF-A specifies interfaces that enable a pair of software execution > environments aka partitions to > communicate with each other. A partition could be

Re: [PATCH v3 3/3] board: toradex: add verdin am62 support

Hi Nishanth On Fri, 2023-07-21 at 08:37 -0500, Nishanth Menon wrote: > On 09:40-20230715, Marcel Ziswiler wrote: > > From: Marcel Ziswiler > > > > This adds initial support for the Toradex Verdin AM62 Quad 1GB WB IT > > V1.0A module. They are strapped to boot from their on-module eMMC. > > U-Boo

[PATCH v2 1/1] spl: initialize PCI before booting

MMC, SATA, and USB may be using PCI based controllers. Initialize the PCI sub-system before trying to boot. Remove the initialization for NVMe that is now redundant. Signed-off-by: Heinrich Schuchardt --- v2: Centralize the PCI initialization --- common/spl/spl.c | 7 +++ commo

RPi Zero 2 W usb keyboard support?

Hi, is supposed usb keyboard to work in u-boot 2023.04 on RPi Zero 2 W? Configured as rpi_arm64_defconfig, no usb devices found but subsequent kernel works as expected. [pi02] kernel=u-boot.bin otg_mode=0 dtoverlay=dwc2,dr_mode=host Regards, Filip

[PATCH] xhci_register: Fix double free on failure

drivers/core/device.c will call `device_free()` after xhci_register already frees the private device data. This can cause a crash later during the boot process, observed on aarch64 RPi4b as a synchronous exception. All callers of xhci_register use priv_auto, so this won't lead to memory leaks. Sig

[PATCH v2 1/1] spl: CONFIG_SPL_PCI_PNP should depend on CONFIG_SPL_PCI

CONFIG_SPL_PCI_PNP=y without CONFIG_SPL_PCI=y makes no sense. Fixes: 32f5e9e5c1a7 ("nvme: pci: Enable for SPL") Signed-off-by: Heinrich Schuchardt --- v2: Keep CONFIG_SPL_PCI_PNP in drivers/pci/Kconfig Add ' in SPL' to label --- drivers/pci/Kconfig | 3 ++- 1 file changed, 2 inse

Re: [PATCH v3 05/11] binman: ftest: Add test for u_boot_spl_pubkey_dtb

From: Lukas Funke Add test for u_boot_spl_pubkey_dtb. The test adds a public key to the dtb and checks if the required nodes will be added to the images dtb. Signed-off-by: Lukas Funke Reviewed-by: Simon Glass --- Changes in v3: - Add newline before main - Adapted test due to property renami

Re: [PATCH v6 1/3] binman: Add support for externally encrypted blobs

On Mon, 17 Jul 2023 at 01:06, wrote: > > From: Christian Taedcke > > This adds a new etype encrypted. > > It creates a new cipher node in the related image similar to the > cipher node used by u-boot, see boot/image-cipher.c. > > Signed-off-by: Christian Taedcke > --- > > Changes in v6: > - fix

Re: [PATCH v6 2/3] binman: Allow cipher node as special section

On Mon, 17 Jul 2023 at 01:06, wrote: > > From: Christian Taedcke > > The new encrypted etype generates a cipher node in the device tree > that should not be evaluated by binman, but still be kept in the > output device tree. > > Signed-off-by: Christian Taedcke > --- > > (no changes since v3) >

Re: [PATCH v6 3/3] binman: Add tests for etype encrypted

On Mon, 17 Jul 2023 at 01:06, wrote: > > From: Christian Taedcke > > Add tests to reach 100% code coverage for the added etype encrypted. > > Signed-off-by: Christian Taedcke > --- > > (no changes since v5) > > Changes in v5: > - add comments to test functions > > Changes in v4: > - fix failing

Re: [PATCH v3 02/11] binman: Don't decompress data while signing

From: Lukas Funke While signing a fit compressed data (i.e. 'blob-ext') is decompressed, but never compressed again. When compressed data was wrapped in a section, decompression leads to an error because the outer section had the original compressed size but the inner entry has the uncompressed s

Re: [PATCH v3 03/11] binman: blob_dtb: Add fake_size argument to ObtainContents()

From: Lukas Funke The method 'connect_contents_to_file()' calls ObtainsContents() with 'fake_size' argument. Without providing the argument in the blob_dtb we are not able to call this method without error. Signed-off-by: Lukas Funke Reviewed-by: Simon Glass --- (no changes since v1) tools/

Re: [PATCH v3 04/11] binman: doc: Add documentation for fdt_add_pubkey bintool

From: Lukas Funke Add documentation for btool which calls 'fdt_add_pubkey' Signed-off-by: Lukas Funke Reviewed-by: Simon Glass --- Changes in v3: - Fix rst headline length tools/binman/bintools.rst | 10 ++ 1 file changed, 10 insertions(+) Applied to u-boot-dm, thanks!

Re: [PATCH v3 06/11] binman: btool: Add fdt_add_pubkey as btool

From: Lukas Funke Add btool which calls 'fdt_add_pubkey' Signed-off-by: Lukas Funke Reviewed-by: Simon Glass --- (no changes since v1) tools/binman/btool/fdt_add_pubkey.py | 67 1 file changed, 67 insertions(+) create mode 100644 tools/binman/btool/fdt_add_pubk

Re: [PATCH v3 07/11] binman: etype: Add u-boot-spl-pubkey-dtb etype

From: Lukas Funke This adds a new etype 'u-boot-spl-pubkey-dtb'. The etype adds the public key from a certificate to the dtb. This creates a '/signature' node which is turn contains the fields which make up the public key. Usually this is done by 'mkimage -K'. However, 'binman sign' does not add

Re: [PATCH v3 08/11] binman: doc: Add documentation for Xilinx Bootgen bintool

From: Lukas Funke Add documentation for the 'bootgen' bintool Signed-off-by: Lukas Funke Reviewed-by: Simon Glass --- (no changes since v1) tools/binman/bintools.rst | 12 1 file changed, 12 insertions(+) Applied to u-boot-dm, thanks!

Re: [PATCH v4 01/83] buildman: Fix verboose typo and add comment

Fix the typo in the RunTests() function, adding comments while we are here. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch to fix verboose typo and add comment tools/buildman/main.py | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) Applie

Re: [PATCH v4 02/83] buildman: Allow --debug to enable debugging

The -D option is used, but plumb it through --debug to enable a full traceback when something goes wrong. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch to allow --debug to enable debugging tools/buildman/main.py | 7 --- 1 file changed, 4 insertions(+

Re: [PATCH v4 03/83] buildman: Exit with the return code consistently

Test should return a suitable exit code when they fail. Fix this and tidy up the code a little. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch to exit with the return code consistently tools/buildman/main.py | 8 +--- 1 file changed, 5 insertions(+), 3

Re: [PATCH v4 05/83] buildman: Drop dead code to handle :CONFIG_ construct

This is not needed anymore, so drop it. Signed-off-by: Simon Glass Fixes: 252ed872 ("kconfig: remove meaningless prefixes in defconfig files") --- (no changes since v3) Changes in v3: - Add new patch to drop dead code to handle :CONFIG_ construct tools/buildman/boards.py | 14 +-

Re: [PATCH v4 04/83] buildman: Rename the ARM boards

Use names consistent with their target names. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch to rename the ARM boards tools/buildman/func_test.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v4 06/83] buildman: Avoid globals in leaf functions

Rather than using the global thoughout each function, pass in these values. This allows tests to use different values when testing the same functions. Improve a few comments while we are here. No functional change is intended. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3

Re: [PATCH v4 07/83] buildman: Add a test for Boards.scan_defconfigs()

Add a test for this code. It requires some defconfig files and a test Kconfig to work with, so copy these into the temporary directory at the start. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch with a test for Boards.scan_defconfigs() tools/buildman/func

Re: [PATCH v4 09/83] buildman: Add a partial test for ensure_board_list()

Create a new function which has the non-UI parts of ensure_board_list(). Add some tests for everything except the N: tag. While we are here, fix the confusing usage of fname inside a loops that also uses fname. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch

Re: [PATCH v4 08/83] buildman: Add a test for Boards.output_is_new()

Add a test for this code, adjusting the timestamp on various files to check each use case. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch with a test for Boards.output_is_new() tools/buildman/func_test.py | 61 + 1 file

Re: [PATCH v4 14/83] buildman: Detect boards with no CONFIG_TARGET defined

We generally expected exactly one of these. Add a check for it. Note: This warning is not displayed by default. An option will be added to enable it. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch to detect boards with no CONFIG_TARGET defined tools/build

Re: [PATCH v4 15/83] buildman: Correct operation of MAINTAINERS N:

This doesn't work as intended. Instead it scans every defconfig file in the source tree. Fix it and add a test. Signed-off-by: Simon Glass --- Changes in v4: - Use search() instead of fullmatch() to allow partial matches Changes in v3: - Add new patch to correct operation of MAINTAINERS N: t

Re: [PATCH v4 16/83] buildman: Just display a single line for missing maintainers

At present we get multiple lines of output when a board has no MAINTAINERS entry: WARNING: no status info for 'bananapi-m2-pro' WARNING: no maintainers for 'bananapi-m2-pro' Suppress the 'status' one since it is implied by the other. Signed-off-by: Simon Glass --- (no changes since v3)

Re: [PATCH v4 18/83] buildman: Correct logic for missing maintainers

An orphaned board should produce a warning, as should a missing name for the maintainer (when '-' is provided). Add these cases. Signed-off-by: Simon Glass --- Changes in v4: - Add new patch to correct logic for missing maintainers tools/buildman/boards.py| 14 +- tools/buildma

Re: [PATCH v4 17/83] buildman: Sort the maintainer warnings

Sort the warnings into alphabetical order, for easier reading. Also make sure that the buildman test files are ignored. Signed-off-by: Simon Glass --- Changes in v4: - Add new patch to sort the maintainer warnings tools/buildman/boards.py| 4 ++-- tools/buildman/func_test.py | 5 +++-- 2 f

Re: [PATCH v4 19/83] buildman: Add an option to check maintainers

Rather than using the -R option to get this report as a side effect, add a dedicated option for it. Disable CI for now as there are some missing maintainers, unfortunately. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch with an option to check maintainers -

Re: [PATCH v4 20/83] buildman: Provide an argument to the -R option

Allow writing the file to a selected location, since otherwise this is controlled by the buildman configuration, so cannot be determined by the caller. Signed-off-by: Simon Glass Fixes: https://source.denx.de/u-boot/u-boot/-/issues/17 --- (no changes since v1) tools/buildman/buildman.rst | 7

Re: [PATCH v4 21/83] buildman: Tidy up pylint warnings in main

Tidy up the various pylint warnings in module 'main'. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/main.py | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v4 23/83] buildman: Fix most pylint warnings in control

Tidy up the easier-to-fix pylint warnings in module 'control'. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 119 +--- tools/buildman/func_test.py | 2 +- 2 files changed, 71 insertions(+), 50 deletions(-) Applied to u-boo

Re: [PATCH v4 22/83] buildman: Convert camel case in control.py

Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 31 ++- tools/buildman/func_test.py | 7 --- tools/buildman/main.py | 3 +-- tools/buildman/test.py

Re: [PATCH v4 28/83] buildman: Drop use of builder in show_actions()

This function only needs the output directory from the builder. This is passed into the builder, so just pass the same value to show_actions(). The avoids needing a builder to call show_actions(). Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 8 1 fi

Re: [PATCH v4 10/83] buildman: Tidy up common code in parse_file()

Use a function to add to the maintainers database, to avoid duplicating the same code twice. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch to tidy up common code in parse_file() tools/buildman/boards.py | 13 - 1 file changed, 8 insertions(+),

Re: [PATCH v4 11/83] buildman: Warn about dangling maintainer entries

Other than the top-level MAINTAINERS file, all maintainer entries should actually reference a target. Add a warning to detect those that do not. Signed-off-by: Simon Glass --- Changes in v4: - Reword the warning message Changes in v3: - Add new patch to warn about dangling maintainer entries

Re: [PATCH v4 12/83] buildman: Refactor target handling in Boards.scan()

Move the assert to the top of the function and provide an explicit variables for the target name and base name. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch to refactor target handling in Boards.scan() tools/buildman/boards.py | 8 +--- 1 file change

Re: [PATCH v4 13/83] buildman: Detect boards with multiple CONFIG_TARGETs defined

The TARGET_xxx options are special in that they refer to a single target. Exactly one should be enabled for each target, corresponding to a defconfig file. Detect configs which result in two TARGET_xxx options being set. For example, at present, TARGET_POLEG and TARET_POLEG_EVB are enabled for the

Re: [PATCH v4 29/83] buildman: Move dry-run handling higher in do_buildman()

Move this up above where the builder is created, since it no-longer makes use of the builder. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 88 --- 1 file changed, 45 insertions(+), 43 deletions(-) Applied to u-boot-dm, th

Re: [PATCH v4 24/83] buildman: Move full-help processing to main

This does not need any of the control features. Move it out of main to reduce the size of the do_buildman() function. For Python 3.6 the -H feature will not work, but this does not seem to be a huge problem, as it dates from 2016. Signed-off-by: Simon Glass --- (no changes since v1) tools/bui

Re: [PATCH v4 25/83] buildman: Move series calculations into a separate function

Reduce the size of the do_buildman() function a little by moving the code that figures out the series into a separate function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 95 +++ 1 file changed, 56 insertions(+), 39 dele

Re: [PATCH v4 26/83] buildman: Move fetch-arch code into a separate function

Reduce the size of the do_buildman() function a little by moving the code that handles --fetch-arch into a separate function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 49 +-- 1 file changed, 31 insertions(+), 18 deleti

Re: [PATCH v4 27/83] buildman: Add a test for the -A option

This lacks a test at present. Add one. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/func_test.py | 7 +++ 1 file changed, 7 insertions(+) Applied to u-boot-dm, thanks!

Re: [PATCH v4 30/83] buildman: Add tests for excluding things

Add some tests for the -x flag. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch to test for excluding things tools/buildman/func_test.py | 24 1 file changed, 24 insertions(+) Applied to u-boot-dm, thanks!

Re: [PATCH v4 31/83] buildman: Move board-selection code into a function

Create a new determine_boards() function to hold the code which selects which boards to build. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Correct test failure when using incorrect variable tools/buildman/control.py | 59 --- 1 fil

Re: [PATCH v4 32/83] bulidman: Move more code to determine_series()

Move some more series-related code here, to reduce the size of the main function. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Correct operation of -A tools/buildman/control.py | 82 --- 1 file changed, 42 insertions(+), 40 deletion

Re: [PATCH v4 33/83] buildman: Move Boards-object code into a function

Move the code which obtains a Boards object into its own function, to reduce the size of the main function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 74 +-- 1 file changed, 48 insertions(+), 26 deletions(-) Applied to

Re: [PATCH v4 34/83] bulidman: Move toolchain handling to a function

Move the code for dealing with toolchains out into its own function, to reduce the size of the main function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 53 --- 1 file changed, 38 insertions(+), 15 deletions(-) Applied

Re: [PATCH v4 35/83] bulldman: Set up output_dir earlier

Set up output_dir at the start of the main function, instead of updating the options.output_dir option. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v4 36/83] buildman: Move output-file setup into one place

Collect the two parts of the output-file handling into single place. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v4 37/83] buildman: Pass option values to get_action_summary()

Pass in the individual values rather than the whole options object, so we can see what is needed. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v4 38/83] buildman: Pass option values to show_actions()

Pass in the individual values rather than the whole options object, so we can see what is needed. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v4 39/83] buildman: Build option-adjusting into a function

Create a separate function to adjust options. Also move show_actions() up as far as we can in the function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 53 --- 1 file changed, 33 insertions(+), 20 deletions(-) Applied to

Re: [PATCH v4 40/83] buildman: Move counting of commits into a function

Move this code into a separate function to avoid a pylint warning in determine_series(). Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 63 +-- 1 file changed, 41 insertions(+), 22 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v4 41/83] buildman: Move setting up the output dir into a function

Move this code into a separate function to reduce the size of the main do_buildman() directory. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 45 --- 1 file changed, 33 insertions(+), 12 deletions(-) Applied to u-boot-dm,

Re: [PATCH v4 42/83] buildman: Move commit numbering into determine_series()

Commits are numbered for use in tests. Do this in determine_series() since it is already dealing with the series. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v4 43/83] buildman: Avoid too many returns in do_buildman()

Fix the pylint warning by using a variable instead of lots of 'return' statements. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v4 44/83] buildman: Move remaining builder properties to constructor

Do these all in the constructor, so it is consistent. Move the stray builder comment into the correct place. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builder.py | 25 ++--- tools/buildman/control.py | 18 +++--- 2 files changed, 25 in

Re: [PATCH v4 45/83] buildman: Tweak commits and show_bloat

Move setting of show_bloat to adjust_options() and adjust how the commits variable is set. Together these remove the pylint warning about too many statements. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 13 + 1 file changed, 5 insertions(+), 8 d

Re: [PATCH v4 46/83] buildman: Moving running of the builder into a function

Move this code into a new function. This removes the pylint warning about too many branches. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 56 --- 1 file changed, 35 insertions(+), 21 deletions(-) Applied to u-boot-dm, tha

Re: [PATCH v4 47/83] buildman: Drop some unnecessary variables

Drop some variables at the end of the do_bulidman() function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v4 48/83] buildman: Adjust show_toolchain_prefix() to not return

This function does not need to return. Simplify the code by exiting immediately. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v4 49/83] buildman: Move checking for make into run_builder()

This is not needed until the builder is run. Move it there to reduce the size of the do_buildman() function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v4 50/83] buildman: Move getting the adjust_cfg into run_builder()

Move this into its own function to reduce the size of do_buildman(). Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 38 +++--- 1 file changed, 27 insertions(+), 11 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v4 51/83] buildman: Use get_alow_missing() directly to avoid var

Avoid an unnecessary local variable by moving this code to a function. This fixes the pylint warning about too many local variables. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) Applied to u-boot-

Re: [PATCH v4 52/83] buildman: Create a function to get number of built commits

Move this code into a function. This removes the last pylint error in the control module. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 34 +- 1 file changed, 25 insertions(+), 9 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v4 53/83] buildman: Convert camel case in cmdline.py

Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/cmdline.py | 2 +- tools/buildman/func_test.py | 2 +- tools/buildman/main.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) Applied to u-boo

Re: [PATCH v4 54/83] buildman: Correct most pylint warnings in cmdline

Tidu up warnings in this file. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/cmdline.py | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v4 55/83] buildman: Add a test for --boards

Add a simple functional test for the --boards option. Fix the example in the docs while we are here. Also improve the docs for Builder.count so it is clearer what it contains. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Use snake case for tests tools/buildman/builder

Re: [PATCH v4 63/83] buildman: Correct invalid use of out_dir variable

This variable has a different meaning in the outer scope. Use a different name to avoid confusion, or bugs. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Fix 'scrop' typo tools/buildman/builderthread.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Applied

Re: [PATCH v4 64/83] buildman: Drop unnecessary assignment of config_out

This is already set up earlier in the function, so drop the extra assignment. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 1 - 1 file changed, 1 deletion(-) Applied to u-boot-dm, thanks!

Re: [PATCH v4 67/83] buildman: Move more things into _build_args()

Move more of the argument-building code into this function. Fix a missing assignment for out_rel_dir too. Rename the function since it now builds all the arguments. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 55 - 1 f

Re: [PATCH v4 56/83] buildman: Convert to argparse

Use argparse to parse the arguments, since OptionParser is deprecated now. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/cmdline.py | 130 + tools/buildman/control.py | 141 ++-- tools/buildman/func_test.

Re: [PATCH v4 57/83] buildman: Convert camel case in bsettings.py

Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/bsettings.py | 14 +++--- tools/buildman/control.py | 2 +- tools/buildman/func_test.py | 12 ++-- tools/buildman/main.py | 2 +- tool

Re: [PATCH v4 58/83] buildman: Convert camel case in builder.py

Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builder.py | 228 tools/buildman/builderthread.py | 26 ++-- tools/buildman/control.py | 13 +- tools/buildman/f

Re: [PATCH v4 59/83] buildman: Split parser creation in two

Split this into two functions to avoid a warning about too many statements. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/cmdline.py | 44 +-- 1 file changed, 33 insertions(+), 11 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v4 61/83] buildman: Correct most pylint warnings in builderthread

Fix the easy warnings in this file. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 95 ++--- 1 file changed, 51 insertions(+), 44 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v4 60/83] buildman: Convert camel case in builderthread.py

Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builder.py | 8 +++--- tools/buildman/builderthread.py | 50 - 2 files changed, 29 insertions(+), 29 deletions(-) Appli

Re: [PATCH v4 62/83] buildman: Export _get_output_dir() to avoid warnings

Make this a public memory since it is used outside the class. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builder.py | 8 tools/buildman/builderthread.py | 2 +- tools/buildman/test.py | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) App

Re: [PATCH v4 65/83] buildman: Start a function to set up the make arguments

Move some of this code into a new funciion, to help reduce the size of the run_commits() function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 38 - 1 file changed, 23 insertions(+), 15 deletions(-) Applied to u-boot-d

Re: [PATCH v4 66/83] buildman: Move setting of toolchain arguments to _build_args()

Move a few more pieces to this new function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v4 68/83] buildman: Convert config_out to string IO

This is probably a little more efficient and it allows passing the object to another function to write data. Convert config_out to use a string I/O device. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 9 + 1 file changed, 5 insertions(+), 4 del

Re: [PATCH v4 71/83] buildman: Move reading of the done file into a function

Move this logic into its own function to reduce the size of the run_commt() function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 66 + 1 file changed, 42 insertions(+), 24 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v4 69/83] buildman: Move reconfigure code into its own function

Split this into its own function so reduce the size of run_commit(). Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 41 - 1 file changed, 30 insertions(+), 11 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v4 70/83] buildman: Move bulid code into its own function

Split this into its own function so reduce the size of run_commit(). Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 40 - 1 file changed, 30 insertions(+), 10 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v4 72/83] buildman: Move code to remove old outputs

Put this in its own function to reduce the size of the run_commit() function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) Applied to u-boot-dm, thanks!

  1   2   3   >