Re: [PATCH 1/2] tools: add fdt_add_pubkey

2021-11-09 Thread Jan Kiszka
[no top-posting please] On 10.11.21 08:03, Roman Kopytin wrote: > Hi, Simon > I have question about: > Some of these are not optional so should not have [] around them. > > As I see we have defaults for: > static const char *algo_name = "sha1,rsa2048"; /* -a */ > static const char *keydir = ".";

Re: [PATCH 1/2] tools: add fdt_add_pubkey

2021-11-09 Thread Jan Kiszka
On 08.11.21 16:28, Roman Kopytin wrote: > Having to use the -K option to mkimage to populate U-Boot's .dtb with the > public key while signing the kernel FIT image is often a little > awkward. In particular, when using a meta-build system such as > bitbake/Yocto, having the tasks of the kernel and

Re: [PATCH 0/2] RFC: add fdt_add_pubkey tool

2021-11-09 Thread Jan Kiszka
On 10.11.21 07:55, Jan Kiszka wrote: > On 10.11.21 01:58, Simon Glass wrote: >> Hi, >> >> On Tue, 9 Nov 2021 at 02:17, Jan Kiszka wrote: >>> >>> On 08.11.21 16:28, Roman Kopytin wrote: In order to reduce the coupling between building the kernel and U-Boot, I'd like a tool that can add a

Re: Pull request: u-boot-samsung master

2021-11-09 Thread Minkyu Kang
Hi, 2021년 11월 10일 (수) 05:09, Tom Rini 님이 작성: > On Tue, Nov 09, 2021 at 07:02:34PM +0900, Minkyu Kang wrote: > > > 2021년 11월 9일 (화) 18:59, Minkyu Kang 님이 작성: > > > > > Dear Tom, > > > > > > The following changes since commit > > > f8ed9059001d803b0eae4b49178789aa0e29edec: > > > > > > Merge tag '

RE: [PATCH 1/2] tools: add fdt_add_pubkey

2021-11-09 Thread Roman Kopytin
Hi, Simon I have question about: Some of these are not optional so should not have [] around them. As I see we have defaults for: static const char *algo_name = "sha1,rsa2048"; /* -a */ static const char *keydir = "."; /* -k */ static const char *keyname = "key"; /* -n */ It means that we can

Re: [PATCH 5/6] drivers: tpm: atmel_twi: implement get_desc operation

2021-11-09 Thread Ilias Apalodimas
Hi Matthew, On Wed, 10 Nov 2021 at 04:43, Mathew McBride wrote: > > > > On Thu, Nov 4, 2021, at 6:39 PM, Ilias Apalodimas wrote: > > Hi Matthew, > > On Thu, 4 Nov 2021 at 03:14, Mathew McBride wrote: > > > static int tpm_atmel_twi_get_desc(struct udevice *dev, char *buf, int size) > > { > > -

Re: [PATCH 0/2] RFC: add fdt_add_pubkey tool

2021-11-09 Thread Jan Kiszka
On 10.11.21 01:58, Simon Glass wrote: > Hi, > > On Tue, 9 Nov 2021 at 02:17, Jan Kiszka wrote: >> >> On 08.11.21 16:28, Roman Kopytin wrote: >>> In order to reduce the coupling between building the kernel and >>> U-Boot, I'd like a tool that can add a public key to U-Boot's dtb >>> without simult

Re: [PATCH 0/2] RFC: add fdt_add_pubkey tool

2021-11-09 Thread Jan Kiszka
On 10.11.21 01:58, Simon Glass wrote: > Hi Jan, > > On Tue, 9 Nov 2021 at 03:07, Jan Kiszka wrote: >> >> On 09.11.21 10:37, Roman Kopytin wrote: >>> Can we have discussion with code lines? For me it is not very clear, >>> because it isn't my code. >>> >> >> Please do not top-post. >> >>> -Or

Re: [PATCH 1/2] tools: add fdt_add_pubkey

2021-11-09 Thread Jan Kiszka
On 08.11.21 16:28, Roman Kopytin wrote: > Having to use the -K option to mkimage to populate U-Boot's .dtb with the > public key while signing the kernel FIT image is often a little > awkward. In particular, when using a meta-build system such as > bitbake/Yocto, having the tasks of the kernel and

Re: [RFC 3/3] cmd: efidebug: handle booting from removable media

2021-11-09 Thread AKASHI Takahiro
On Tue, Nov 09, 2021 at 10:50:37AM +0100, Heinrich Schuchardt wrote: > On 11/9/21 02:32, AKASHI Takahiro wrote: > > Support for booting from removable media is now added to UEFI boot > > manager. Here we should modify efidebug command in order to define > > a proper "Boot" variable. > > > > Wi

Re: [RFC 2/3] efi_loader: bootmgr: add booting from removable media

2021-11-09 Thread AKASHI Takahiro
Hi Mark, Thank you for your comments. On Tue, Nov 09, 2021 at 02:53:14PM +0100, Mark Kettenis wrote: > > From: AKASHI Takahiro > > Date: Tue, 9 Nov 2021 10:32:32 +0900 > > Hi Takahiro, > > > Under the current implementation, booting from removal media using > > a architecture-specific default

Re: [PATCH] pci: pci_mvebu: Use global MBUS_PCI_MEM_SIZE macro

2021-11-09 Thread Stefan Roese
On 06.11.21 12:16, Pali Rohár wrote: Header file mach/cpu.h already defines MBUS_PCI_MEM_SIZE macro which defines size of MBUS_PCI_MEM_BASE window. So use global MBUS_PCI_MEM_SIZE macro instead of locally defined PCIE_MEM_SIZE macro. Both macros have same definition. Signed-off-by: Pali Rohár

Re: [PATCH u-boot-marvell 00/11] Another kwbimage series

2021-11-09 Thread Stefan Roese
Hi Marek, Hi Pali, On 08.11.21 18:12, Marek Behún wrote: From: Marek Behún Hi Stefan, Pali has prepared another series of patches for kwbimage, I have reviewed them. Thanks. Just checking with you: Does this series include / supersede these 2 patches: http://patchwork.ozlabs.org/project/ub

Re: [RFC 2/3] efi_loader: bootmgr: add booting from removable media

2021-11-09 Thread AKASHI Takahiro
Hi Heinrich, Overall, do you agree to add this feature? On Tue, Nov 09, 2021 at 10:14:47AM +0100, Heinrich Schuchardt wrote: > > > On 11/9/21 02:32, AKASHI Takahiro wrote: > > Under the current implementation, booting from removal media using > > a architecture-specific default image name, say

[PATCH v2 2/2] board: traverse: add initial Ten64 support

2021-11-09 Thread Mathew McBride
The Ten64 is a networking-oriented MiniITX board using the NXP LS1088A SoC. This patch provides the bare minimum to support Ten64 boards under U-Boot for distroboot. Some related drivers have not yet been submitted and this basic support lacks some of the opinionated defaults provided by our firm

[PATCH v2 1/2] board: traverse: add Ten64 board controller driver

2021-11-09 Thread Mathew McBride
Traverse Technologies Ten64 family boards use a microcontroller to control low level board functions like startup and reset, as well as holding details such as the board MAC address. Communication between the CPU and microcontroller is via I2C. To keep the driver structure clean between the Ten64

[PATCH v2 0/2] Initial Traverse Ten64 board support

2021-11-09 Thread Mathew McBride
This patchset adds initial support for the Traverse Ten64 family, which is a networking focused Mini-ITX board using NXP's LS1088A. This patchset is the bare minimum necessary to get a system running on U-Boot and booting via distroboot/EFI. There are still a few more drivers to come, such as the

Re: Testing pci_mvebu.c with Kirkwood SoCs

2021-11-09 Thread Tony Dinh
Hi Pali, On Tue, Nov 9, 2021 at 3:05 PM Pali Rohár wrote: > > Hello! > > On Tuesday 09 November 2021 14:51:33 Tony Dinh wrote: > > Hi Pali, > > > > On Tue, Nov 9, 2021 at 7:08 AM Pali Rohár wrote: > > > > > > On Monday 08 November 2021 22:34:51 Tony Dinh wrote: > > > > The above log was the buil

Re: [PATCH 5/6] drivers: tpm: atmel_twi: implement get_desc operation

2021-11-09 Thread Mathew McBride
On Thu, Nov 4, 2021, at 6:39 PM, Ilias Apalodimas wrote: > Hi Matthew, > > On Thu, 4 Nov 2021 at 03:14, Mathew McBride wrote: > > > static int tpm_atmel_twi_get_desc(struct udevice *dev, char *buf, int size) > > { > > - return 0; > > + if (size < 50) > > + return -

Pull request: u-boot-sunxi/master fix for 2022.01

2021-11-09 Thread Andre Przywara
Hi Tom, as discussed, please pull this patch to disable the watchdog on sunxi boards by default. The watchdog only got enabled in this release cycle, and its short period breaks actual users (Debian installer). Thanks, Andre The following changes since commit e8e9c6f4840

Re: [RFC 0/2] Do not stop with an error when mkimage fails

2021-11-09 Thread Tom Rini
On Wed, Nov 10, 2021 at 01:26:12AM +0100, Rasmus Villemoes wrote: > On 10/11/2021 01.18, Rasmus Villemoes wrote: > > On 09/11/2021 20.42, Tom Rini wrote: > >> On Tue, Nov 09, 2021 at 08:21:07PM +0100, Heiko Thiery wrote: > >>> Hi Wolfgang, > >>> > > > >>> I know this is not a perfect solution but

Re: [RFC 0/2] Do not stop with an error when mkimage fails

2021-11-09 Thread Simon Glass
Hi, On Tue, 9 Nov 2021 at 12:42, Tom Rini wrote: > > On Tue, Nov 09, 2021 at 08:21:07PM +0100, Heiko Thiery wrote: > > Hi Wolfgang, > > > > Am So., 7. Nov. 2021 um 15:48 Uhr schrieb Wolfgang Denk : > > > > > > Dear Heiko, > > > > > > In message > > > you > > > wrote: > > > > > > > > > > While

Re: [PATCH 1/2] tools: add fdt_add_pubkey

2021-11-09 Thread Simon Glass
Hi Roman, On Mon, 8 Nov 2021 at 08:29, Roman Kopytin wrote: > > Having to use the -K option to mkimage to populate U-Boot's .dtb with the > public key while signing the kernel FIT image is often a little > awkward. In particular, when using a meta-build system such as > bitbake/Yocto, having the

Re: [PATCH 2/2] test_vboot.py: include test of fdt_add_pubkey tool

2021-11-09 Thread Simon Glass
Hi Roman, On Mon, 8 Nov 2021 at 08:29, Roman Kopytin wrote: > > Signed-off-by: Roman Kopytin > Cc: Rasmus Villemoes > --- > test/py/tests/test_vboot.py | 8 > 1 file changed, 8 insertions(+) > > diff --git a/test/py/tests/test_vboot.py b/test/py/tests/test_vboot.py > index 6dff6779

Re: [PATCH 0/2] RFC: add fdt_add_pubkey tool

2021-11-09 Thread Simon Glass
Hi, On Tue, 9 Nov 2021 at 02:17, Jan Kiszka wrote: > > On 08.11.21 16:28, Roman Kopytin wrote: > > In order to reduce the coupling between building the kernel and > > U-Boot, I'd like a tool that can add a public key to U-Boot's dtb > > without simultaneously signing a FIT image. That tool doesn'

Re: [PATCH 0/2] RFC: add fdt_add_pubkey tool

2021-11-09 Thread Simon Glass
Hi François, On Tue, 9 Nov 2021 at 05:43, François Ozog wrote: > > Hi > > as we are in design discussions, I would promote the idea of not pushing > non hardware related things in the DTB that is passed to the kernel. > Is your use case to allow U-Boot to verify the kernel's signature ? > Why not

Re: [PATCH 0/2] RFC: add fdt_add_pubkey tool

2021-11-09 Thread Simon Glass
Hi Jan, On Tue, 9 Nov 2021 at 03:07, Jan Kiszka wrote: > > On 09.11.21 10:37, Roman Kopytin wrote: > > Can we have discussion with code lines? For me it is not very clear, > > because it isn't my code. > > > > Please do not top-post. > > > -Original Message- > > From: Jan Kiszka > > Sen

[BUGFIX PATCH] configs: synquacer: Fix dfu_alt_info to use nor1

2021-11-09 Thread Masami Hiramatsu
Fix dfu_alt_info to use nor1 instead of the device name. This reverts a part of commit 59bd18d4c4d7 ("configs: synquacer: Remove mtdparts settings and update DFU setting") because the commit a4f2d8341455 ("mtd: spi: nor: force mtd name to "nor%d"") changed the mtd device naming scheme to nor%d. Si

Re: [RFC 0/2] Do not stop with an error when mkimage fails

2021-11-09 Thread Rasmus Villemoes
On 10/11/2021 01.18, Rasmus Villemoes wrote: > On 09/11/2021 20.42, Tom Rini wrote: >> On Tue, Nov 09, 2021 at 08:21:07PM +0100, Heiko Thiery wrote: >>> Hi Wolfgang, >>> > >>> I know this is not a perfect solution but I don't know how to get my >>> board merged without doing this kind of workaroun

Re: [RFC 0/2] Do not stop with an error when mkimage fails

2021-11-09 Thread Rasmus Villemoes
On 09/11/2021 20.42, Tom Rini wrote: > On Tue, Nov 09, 2021 at 08:21:07PM +0100, Heiko Thiery wrote: >> Hi Wolfgang, >> >> I know this is not a perfect solution but I don't know how to get my >> board merged without doing this kind of workaround for the U-Boot CI. > > Unfortunately in these days

Re: [PATCH 1/1] efi_loader: stop watchdogs in ExitBootServices()

2021-11-09 Thread Grant Likely
On Tue, Nov 9, 2021 at 5:55 PM Tom Rini wrote: > > On Tue, Nov 09, 2021 at 11:19:01AM +0100, Heinrich Schuchardt wrote: > > > The UEFI specification requires for ExitBootServices() that "the boot > > services watchdog timer is disabled". We already disable the software > > watchdog. We should addi

Re: [PATCH 04/11] mmc: fsl_esdhc_imx: clean up bus width configuration code

2021-11-09 Thread Jaehoon Chung
On 11/10/21 7:47 AM, Sean Anderson wrote: > > > On 11/9/21 5:41 PM, Jaehoon Chung wrote: >> Hi Sean, >> >> On 11/9/21 11:42 PM, Sean Anderson wrote: >>> >>> >>> On 11/9/21 2:19 AM, Jaehoon Chung wrote: On 11/6/21 2:39 AM, Sean Anderson wrote: > [ fsl_esdhc commit 07bae1de382723b942440969

Re: Testing pci_mvebu.c with Kirkwood SoCs

2021-11-09 Thread Pali Rohár
Hello! On Tuesday 09 November 2021 14:51:33 Tony Dinh wrote: > Hi Pali, > > On Tue, Nov 9, 2021 at 7:08 AM Pali Rohár wrote: > > > > On Monday 08 November 2021 22:34:51 Tony Dinh wrote: > > > The above log was the build with the following configs: > > > CONFIG_CMD_PCI=y > > > CONFIG_PCI=y > > >

Re: Testing pci_mvebu.c with Kirkwood SoCs

2021-11-09 Thread Tony Dinh
Hi Pali, On Tue, Nov 9, 2021 at 7:08 AM Pali Rohár wrote: > > On Monday 08 November 2021 22:34:51 Tony Dinh wrote: > > The above log was the build with the following configs: > > CONFIG_CMD_PCI=y > > CONFIG_PCI=y > > CONFIG_PCI_MVEBU=y > > CONFIG_PCI_PNP=y > > CONFIG_USB_XHCI_HCD=y > > CONFIG_USB

Re: [PATCH 04/11] mmc: fsl_esdhc_imx: clean up bus width configuration code

2021-11-09 Thread Jaehoon Chung
On 11/10/21 1:13 AM, Adam Ford wrote: > On Fri, Nov 5, 2021 at 12:41 PM Sean Anderson wrote: >> >> [ fsl_esdhc commit 07bae1de382723b94244096953b05225572728cd ] >> >> This patch is to clean up bus width setting code. >> >> - For DM_MMC, remove getting "bus-width" from device tree. >> This has be

Re: [PATCH 04/11] mmc: fsl_esdhc_imx: clean up bus width configuration code

2021-11-09 Thread Sean Anderson
On 11/9/21 5:41 PM, Jaehoon Chung wrote: Hi Sean, On 11/9/21 11:42 PM, Sean Anderson wrote: On 11/9/21 2:19 AM, Jaehoon Chung wrote: On 11/6/21 2:39 AM, Sean Anderson wrote: [ fsl_esdhc commit 07bae1de382723b94244096953b05225572728cd ] This patch is to clean up bus width setting code.

Re: [PATCH 04/11] mmc: fsl_esdhc_imx: clean up bus width configuration code

2021-11-09 Thread Jaehoon Chung
Hi Sean, On 11/9/21 11:42 PM, Sean Anderson wrote: > > > On 11/9/21 2:19 AM, Jaehoon Chung wrote: >> On 11/6/21 2:39 AM, Sean Anderson wrote: >>> [ fsl_esdhc commit 07bae1de382723b94244096953b05225572728cd ] >>> >>> This patch is to clean up bus width setting code. >>> >>> - For DM_MMC, remove g

Re: [PATCH 1/1] watchdog: don't autostart watchdog on Sunxi boards

2021-11-09 Thread Andre Przywara
On Fri, 5 Nov 2021 19:34:31 +0100 Heinrich Schuchardt wrote: > The Sunxi boards only support a 16 second watchdog timeout. This is too > short to boot Linux. The UEFI specification requires 300 seconds as > default timeout. As detailed in this thread here [1], I would argue that always keeping

Re: [PATCH 1/1] efi_loader: stop watchdogs in ExitBootServices()

2021-11-09 Thread Andre Przywara
On Tue, 9 Nov 2021 13:18:28 -0500 Tom Rini wrote: > On Tue, Nov 09, 2021 at 07:15:10PM +0100, Heinrich Schuchardt wrote: > > On 11/9/21 18:55, Tom Rini wrote: > > > On Tue, Nov 09, 2021 at 11:19:01AM +0100, Heinrich Schuchardt wrote: > > > > > > > The UEFI specification requires for ExitBoot

Re: Pull request: u-boot-samsung master

2021-11-09 Thread Tom Rini
On Tue, Nov 09, 2021 at 07:02:34PM +0900, Minkyu Kang wrote: > 2021년 11월 9일 (화) 18:59, Minkyu Kang 님이 작성: > > > Dear Tom, > > > > The following changes since commit > > f8ed9059001d803b0eae4b49178789aa0e29edec: > > > > Merge tag 'efi-2022-01-rc2' of > > https://source.denx.de/u-boot/custodians/

Re: [RFC 0/2] Do not stop with an error when mkimage fails

2021-11-09 Thread Tom Rini
On Tue, Nov 09, 2021 at 08:21:07PM +0100, Heiko Thiery wrote: > Hi Wolfgang, > > Am So., 7. Nov. 2021 um 15:48 Uhr schrieb Wolfgang Denk : > > > > Dear Heiko, > > > > In message > > you > > wrote: > > > > > > > > While converting to binman for an imx8mq board, it has been found that > > > > > b

Re: U-boot is broken with -O0?

2021-11-09 Thread Tom Rini
On Tue, Nov 09, 2021 at 02:34:41PM -0500, Sean Anderson wrote: > Hi Oleh, > > On 11/9/21 2:31 PM, Oleh Kravchenko wrote: > > Hello Tom, > > for what reason it's not supported? > > > > I'm finding that very useful for debugging. > > Perhaps try -Og Yes. There are several places where we rely on

Re: U-boot is broken with -O0?

2021-11-09 Thread Sean Anderson
Hi Oleh, On 11/9/21 2:31 PM, Oleh Kravchenko wrote: Hello Tom, for what reason it's not supported? I'm finding that very useful for debugging. Perhaps try -Og --Sean Only a few issues with conditional compilation breaks it. Also this issue reproducible if -DDEBUG=1 is used. -- Best regar

Re: [PATCH v2 1/4] mtd: spi-nor-core: Introduce SPI_NOR_SOFT_RESET flash_info flag

2021-11-09 Thread Pratyush Yadav
On 04/11/21 01:49AM, Tudor Ambarus wrote: > Some flashes can determine if Soft Reset is supported by parsing > BFPT_DWORD(16). There are however flashes that do not define any of > the SFDP tables, so they can't discover this capability at SFDP > parsing time. For such cases introduce the SPI_NOR_S

Re: U-boot is broken with -O0?

2021-11-09 Thread Oleh Kravchenko
Hello Tom, for what reason it's not supported? I'm finding that very useful for debugging. Only a few issues with conditional compilation breaks it. Also this issue reproducible if -DDEBUG=1 is used. -- Best regards, Oleh Kravchenko > 9 лист. 2021 р. о 20:52 Tom Rini пише: > > On Tue, Nov 09

Re: [PATCH v2 4/4] mtd: spi-nor-core: Fix the opcode extension for the software reset sequence

2021-11-09 Thread Pratyush Yadav
On 04/11/21 01:49AM, Tudor Ambarus wrote: > It was always hardcoded to SPI_NOR_EXT_REPEAT, while there are > flashes that may use an SPI_NOR_EXT_INVERT opcode extension > (mx66lm1g45g). Remove the hardcoded value and let flashes use > their per flash opcode extension type. I suggested this exact p

Re: [PATCH 1/1] Dockerfile: build swtpm

2021-11-09 Thread Tom Rini
On Tue, Nov 09, 2021 at 07:51:20PM +0100, Heinrich Schuchardt wrote: > For testing the TPM drivers and the EFI_TCG2_PROTOCOL we need the tool > swtpm. > > Once we move to Ubuntu Impish we can take libtpms from package libtpms-dev. > > Signed-off-by: Heinrich Schuchardt Much like how we used to

Re: [PATCH v2 3/4] Revert "mtd: spi-nor-core: Perform a Soft Reset on boot"

2021-11-09 Thread Pratyush Yadav
Hi Tudor, On 04/11/21 01:49AM, Tudor Ambarus wrote: > This reverts commit 0be8ab1f166844d53477387dc9a1184161ef44ef. > > There are multiple reset commands and it was used one at guess, Correct. > see BFPT[dword(16)]. It is preferable to avoid issuing unsupported > commands to a flash. Since ther

Re: [RFC 0/2] Do not stop with an error when mkimage fails

2021-11-09 Thread Heiko Thiery
Hi Wolfgang, Am So., 7. Nov. 2021 um 15:48 Uhr schrieb Wolfgang Denk : > > Dear Heiko, > > In message > you > wrote: > > > > > > While converting to binman for an imx8mq board, it has been found that > > > > building in the u-boot CI fails. This is because an imx8mq requires an > > > > external

Re: U-boot is broken with -O0?

2021-11-09 Thread Tom Rini
On Tue, Nov 09, 2021 at 08:33:33PM +0200, Oleh Kravchenko wrote: > Hello guys! > > I think the CI verification job for u-boot patches should be updated to > include CFLAGS like -O0 > Because I'm not able to build u-boot for Raspberry Pi (or to another board) > with -O0 > > Here the commands ho

[PATCH 1/1] Dockerfile: build swtpm

2021-11-09 Thread Heinrich Schuchardt
For testing the TPM drivers and the EFI_TCG2_PROTOCOL we need the tool swtpm. Once we move to Ubuntu Impish we can take libtpms from package libtpms-dev. Signed-off-by: Heinrich Schuchardt --- tools/docker/Dockerfile | 28 1 file changed, 28 insertions(+) diff --gi

U-boot is broken with -O0?

2021-11-09 Thread Oleh Kravchenko
Hello guys! I think the CI verification job for u-boot patches should be updated to include CFLAGS like -O0 Because I'm not able to build u-boot for Raspberry Pi (or to another board) with -O0 Here the commands how to quickly reprodice the problem:     export ARCH=arm64     export CROSS_COMPILE

Re: [PATCH 1/1] efi_loader: stop watchdogs in ExitBootServices()

2021-11-09 Thread Tom Rini
On Tue, Nov 09, 2021 at 07:15:10PM +0100, Heinrich Schuchardt wrote: > On 11/9/21 18:55, Tom Rini wrote: > > On Tue, Nov 09, 2021 at 11:19:01AM +0100, Heinrich Schuchardt wrote: > > > > > The UEFI specification requires for ExitBootServices() that "the boot > > > services watchdog timer is disable

Re: [PATCH 1/1] efi_loader: stop watchdogs in ExitBootServices()

2021-11-09 Thread Heinrich Schuchardt
On 11/9/21 18:55, Tom Rini wrote: On Tue, Nov 09, 2021 at 11:19:01AM +0100, Heinrich Schuchardt wrote: The UEFI specification requires for ExitBootServices() that "the boot services watchdog timer is disabled". We already disable the software watchdog. We should additionally disable the hardwar

Re: [PATCH 1/1] efi_loader: stop watchdogs in ExitBootServices()

2021-11-09 Thread Tom Rini
On Tue, Nov 09, 2021 at 11:19:01AM +0100, Heinrich Schuchardt wrote: > The UEFI specification requires for ExitBootServices() that "the boot > services watchdog timer is disabled". We already disable the software > watchdog. We should additionally disable the hardware watchdogs. > > Reported-by:

Re: [PATCH 0/2] RFC: add fdt_add_pubkey tool

2021-11-09 Thread François Ozog
Hi Jan, On Tue, 9 Nov 2021 at 15:00, Jan Kiszka wrote: > On 09.11.21 14:16, François Ozog wrote: > > Hi Jan > > > > On Tue, 9 Nov 2021 at 13:58, Jan Kiszka > > wrote: > > > > On 09.11.21 13:43, François Ozog wrote: > > > Hi > > > > > > as we are in

Re: [PATCH 1/1] efi_loader: stop watchdogs in ExitBootServices()

2021-11-09 Thread Heinrich Schuchardt
On 11/9/21 15:54, Michael Walle wrote: Am 2021-11-09 15:46, schrieb Mark Kettenis: From: Michael Walle Date: Tue,  9 Nov 2021 15:20:17 +0100 > The UEFI specification requires for ExitBootServices() that "the boot > services watchdog timer is disabled". We already disable the software > watchdo

Re: [PATCH v2 1/2] board: sifive: unmatched: use zero copy for initrd

2021-11-09 Thread Tom Rini
On Tue, Nov 09, 2021 at 05:27:52PM +0100, Heinrich Schuchardt wrote: > On 11/9/21 17:07, Tom Rini wrote: > > On Tue, Nov 09, 2021 at 04:50:27PM +0100, Heinrich Schuchardt wrote: > > > On 11/9/21 16:46, Tom Rini wrote: > > > > On Tue, Nov 09, 2021 at 03:46:00PM +0100, Heinrich Schuchardt wrote: > >

Re: [PATCH 4/5] vexpress64: Enable OF_CONTROL and OF_BOARD for VExpress64

2021-11-09 Thread Peter Hoyes
Hi, On 09/11/2021 15:06, Andre Przywara wrote: On Thu, 4 Nov 2021 16:56:18 + Peter Hoyes wrote: Hi, From: Peter Hoyes Capture x0 in lowlevel_init.S as potential fdt address. Modify board_fdt_blob_setup to use fdt address from either vexpress_aemv8.h or lowlevel_init.S. Signed-off-by:

Re: [PATCH v2 1/2] board: sifive: unmatched: use zero copy for initrd

2021-11-09 Thread Heinrich Schuchardt
On 11/9/21 17:07, Tom Rini wrote: On Tue, Nov 09, 2021 at 04:50:27PM +0100, Heinrich Schuchardt wrote: On 11/9/21 16:46, Tom Rini wrote: On Tue, Nov 09, 2021 at 03:46:00PM +0100, Heinrich Schuchardt wrote: Booting Ubuntu Impish showed the following output: relocaddr = 0xfff60

[PATCH u-boot-marvell] arm: mvebu: turris_omnia: enable A385 watchdog before disabling MCU watchdog

2021-11-09 Thread Marek Behún
From: Pali Rohár Commit aeb0ca64dbb5 ("arm: mvebu: turris_omnia: disable MCU watchdog in SPL when booting over UART") disabled MCU watchdog when booting over UART to ensure that watchdog does not reboot the board before UART transfer finishes. But if UART transfer fails for some reason, or if U-

Re: [PATCH 04/11] mmc: fsl_esdhc_imx: clean up bus width configuration code

2021-11-09 Thread Adam Ford
On Fri, Nov 5, 2021 at 12:41 PM Sean Anderson wrote: > > [ fsl_esdhc commit 07bae1de382723b94244096953b05225572728cd ] > > This patch is to clean up bus width setting code. > > - For DM_MMC, remove getting "bus-width" from device tree. > This has been done in mmc_of_parse(). > > - For non-DM_MMC

[PATCH v2 5/5] firmware: scmi: Add OP-TEE transport

2021-11-09 Thread Etienne Carriere
This change implements an SCMI transport for agent interfacing the OP-TEE SCMI service. OP-TEE provides an SCMI PTA (Pseudo-TA) for non-secure world to send SCMI messages over an identified channel. The driver implemented here uses a SMT shared memory for passing messages between client and server.

[PATCH v2 4/5] dt-bindings: arm: scmi: OP-TEE as transport channel for SCMI messages

2021-11-09 Thread Etienne Carriere
Introduce compatible "linaro,scmi-optee" for SCMI transport channel based on an OP-TEE service invocation. Define "linaro,optee-channel-id" property to identify the OP-TEE SCMI channel used by the protocol(s). OP-TEE SCMI transport can either use shared memory or a static shared memory buffer iden

[PATCH v2 3/5] tee: optee: define TEE error code TEE_ERROR_SHORT_BUFFER

2021-11-09 Thread Etienne Carriere
Adds TEE_ERROR_SHORT_BUFFER as TEE error code. This error code is commonly used by TEEs to inform caller that the buffer(s) it provided is too small for the desired operation. Cc: Jens Wiklander Reviewed-by: Patrick Delaunay Reviewed-by: Jens Wiklander Signed-off-by: Etienne Carriere --- Chang

[PATCH v2 2/5] tee: optee: remove unused duplicated login Id macros

2021-11-09 Thread Etienne Carriere
Remove unused OPTEE_MSG_LOGIN_* ID macros as suitable TEE_LOGIN_* ID macros are already defined tee.h. Cc: Jens Wiklander Reviewed-by: Patrick Delaunay Reviewed-by: Jens Wiklander Signed-off-by: Etienne Carriere --- Changes since v1: - Apply review tags Added info for v1: This change was prev

[PATCH v2 1/5] tee: define session login identifiers

2021-11-09 Thread Etienne Carriere
Define identifiers for clnt_login field in struct tee_open_session_arg based in GlobalPlatform Device TEE IDs and on the REE_KERNEL identifier extension from OP-TEE OS. Cc: Jens Wiklander Reviewed-by: Patrick Delaunay Reviewed-by: Jens Wiklander Signed-off-by: Etienne Carriere --- Changes sin

Re: [PATCH v2 1/2] board: sifive: unmatched: use zero copy for initrd

2021-11-09 Thread Tom Rini
On Tue, Nov 09, 2021 at 04:50:27PM +0100, Heinrich Schuchardt wrote: > On 11/9/21 16:46, Tom Rini wrote: > > On Tue, Nov 09, 2021 at 03:46:00PM +0100, Heinrich Schuchardt wrote: > > > > > Booting Ubuntu Impish showed the following output: > > > > > > relocaddr = 0xfff6 > > > >

Re: [PATCH v2 1/2] board: sifive: unmatched: use zero copy for initrd

2021-11-09 Thread Heinrich Schuchardt
On 11/9/21 16:46, Tom Rini wrote: On Tue, Nov 09, 2021 at 03:46:00PM +0100, Heinrich Schuchardt wrote: Booting Ubuntu Impish showed the following output: relocaddr = 0xfff6 Loading Ramdisk to fa118000, end f19d ... The initrd is overwriting the U-Boot binary. Boot

Re: [PATCH v2 2/2] board: sifive: unmatched: rearrange load addresses

2021-11-09 Thread Tom Rini
On Tue, Nov 09, 2021 at 04:46:00PM +0100, Heinrich Schuchardt wrote: > On 11/9/21 16:43, Tom Rini wrote: > > On Tue, Nov 09, 2021 at 03:46:01PM +0100, Heinrich Schuchardt wrote: > > > > > * Put the small files below $kernel_addr_r to not limit the kernel size. > > > * ramdisk_addr_r should be the

Re: [PATCH v2 1/2] board: sifive: unmatched: use zero copy for initrd

2021-11-09 Thread Tom Rini
On Tue, Nov 09, 2021 at 03:46:00PM +0100, Heinrich Schuchardt wrote: > Booting Ubuntu Impish showed the following output: > > relocaddr = 0xfff6 > > Loading Ramdisk to fa118000, end f19d ... > > The initrd is overwriting the U-Boot binary. Booting fails. > > There is

Re: [PATCH v2 2/2] board: sifive: unmatched: rearrange load addresses

2021-11-09 Thread Heinrich Schuchardt
On 11/9/21 16:43, Tom Rini wrote: On Tue, Nov 09, 2021 at 03:46:01PM +0100, Heinrich Schuchardt wrote: * Put the small files below $kernel_addr_r to not limit the kernel size. * ramdisk_addr_r should be the highest of all loading addresses to avoid limiting the size of the initial RAM disk.

Re: [PATCH 5/5] firmware: scmi: Add OP-TEE transport

2021-11-09 Thread Etienne Carriere
On Tue, 9 Nov 2021 at 15:39, Patrick DELAUNAY wrote: > > Hi Etienne, > > one missing remark, don't see in my first review. > > On 11/4/21 3:14 PM, Etienne Carriere wrote: > > This change implements an SCMI transport for agent interfacing the > > OP-TEE SCMI service. OP-TEE provides an SCMI PTA (Ps

Re: [PATCH v2 2/2] board: sifive: unmatched: rearrange load addresses

2021-11-09 Thread Tom Rini
On Tue, Nov 09, 2021 at 03:46:01PM +0100, Heinrich Schuchardt wrote: > * Put the small files below $kernel_addr_r to not limit the kernel size. > * ramdisk_addr_r should be the highest of all loading addresses to > avoid limiting the size of the initial RAM disk. > > Signed-off-by: Heinrich Sch

Re: [PATCH v2 11/12] arm: mvebu: Espressobin: Use new API for setting default env at runtime

2021-11-09 Thread Pali Rohár
On Friday 05 November 2021 09:50:42 Pali Rohár wrote: > On Thursday 04 November 2021 20:02:33 Simon Glass wrote: > > On Wed, 3 Nov 2021 at 17:23, Marek Behún wrote: > > > > > > From: Marek Behún > > > > > > ESPRESSObin's board code uses an ad-hoc solution for ensuring that > > > ethaddrs are not

Re: [RFC PATCH 08/23] net: sunxi_emac: Remove non-DM pin setup

2021-11-09 Thread Heinrich Schuchardt
On 10/21/21 06:55, Samuel Holland wrote: This is now handled automatically by the pinctrl driver. Signed-off-by: Samuel Holland --- arch/arm/include/asm/arch-sunxi/gpio.h | 1 - drivers/net/sunxi_emac.c | 5 - 2 files changed, 6 deletions(-) diff --git a/arch/arm/include

Re: [PATCH v10 1/2] net: brcm: netXtreme driver

2021-11-09 Thread Roman Bacik
On Tue, Nov 9, 2021 at 12:37 AM Ramon Fried wrote: > > On Tue, Nov 9, 2021 at 4:55 AM Marek Behún wrote: > > > > On Mon, 8 Nov 2021 18:20:43 -0800 > > Roman Bacik wrote: > > > > > On Mon, Nov 8, 2021 at 5:12 PM Marek Behún wrote: > > > > > > > > On Mon, 8 Nov 2021 16:48:33 -0800 > > > > Roman B

Re: Testing pci_mvebu.c with Kirkwood SoCs

2021-11-09 Thread Pali Rohár
On Monday 08 November 2021 14:48:03 Tony Dinh wrote: > This Pogoplug V4 board is still out-of-tree. I have not submitted > patches to add support for it. I plan to do that in the near future, > and it will be under board/cloudengines/. > > However, there is a show stopper right now that prevents m

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-09 Thread Grant Likely
On 09/11/2021 14:34, Heinrich Schuchardt wrote: On 11/9/21 15:26, Andre Przywara wrote: On Tue, 9 Nov 2021 08:50:37 -0500 Tom Rini wrote: Hi, On Tue, Nov 09, 2021 at 09:00:05AM +0100, Heinrich Schuchardt wrote: [snip] thanks for that ;-) I am still puzzled about this, if I read the UEFI

Re: Testing pci_mvebu.c with Kirkwood SoCs

2021-11-09 Thread Pali Rohár
On Monday 08 November 2021 22:34:51 Tony Dinh wrote: > The above log was the build with the following configs: > CONFIG_CMD_PCI=y > CONFIG_PCI=y > CONFIG_PCI_MVEBU=y > CONFIG_PCI_PNP=y > CONFIG_USB_XHCI_HCD=y > CONFIG_USB_XHCI_PCI=y > CONFIG_USB_XHCI_MVEBU=y > CONFIG_PCI_INIT_R=y > CONFIG_SYS_EARLY

Re: [PATCH 5/5] vexpress64: Enable VIRTIO_NET network driver

2021-11-09 Thread Andre Przywara
On Thu, 4 Nov 2021 16:56:19 + Peter Hoyes wrote: > From: Peter Hoyes > > The SMSC driver is using the old driver model. > > Init the virtio system in vexpress64.c so that the network device is > discovered. Mmmh, it looks a bit weird to explicitly call virtio_init(), when this should be

Re: [PATCH 4/5] vexpress64: Enable OF_CONTROL and OF_BOARD for VExpress64

2021-11-09 Thread Andre Przywara
On Thu, 4 Nov 2021 16:56:18 + Peter Hoyes wrote: Hi, > From: Peter Hoyes > > Capture x0 in lowlevel_init.S as potential fdt address. Modify > board_fdt_blob_setup to use fdt address from either vexpress_aemv8.h > or lowlevel_init.S. > > Signed-off-by: Peter Hoyes > --- > board/armltd/v

Re: [PATCH 3/5] vexpress64: Clean up BASE_FVP boot configuration

2021-11-09 Thread Andre Przywara
On Thu, 4 Nov 2021 16:56:17 + Peter Hoyes wrote: > From: Peter Hoyes > > Move env var address values to #defines so they can be reused elsewhere. > > Rename env var names to those recommended in the README. Many thanks for cleaning this up and fixing the wrong variable names. I think we

Re: [PATCH 2/5] vexpress64: Refactor header file to make it easier to add new FVPs

2021-11-09 Thread Andre Przywara
On Thu, 4 Nov 2021 16:56:16 + Peter Hoyes wrote: > From: Peter Hoyes > > Rename from vexpress_aemv8a.h -> vepxress_aemv8.h as new FVPs may not be > v8-A. No change in behavior. That looks like a reasonable cleanup to me, mostly just changing "is it the FVP, or Juno?" into "is it the Juno,

Re: [PATCH 1/5] doc: Add documentation for the Arm VExpress64 board configs

2021-11-09 Thread Andre Przywara
On Thu, 4 Nov 2021 16:56:15 + Peter Hoyes wrote: > From: Peter Hoyes > > Create a new documentation section for Arm Ltd boards with a sub-page > for the VExpress64 boards (FVP-A and Juno). Many thanks for providing this! > Signed-off-by: Peter Hoyes > --- > doc/board/armltd/index.rst

Re: [PATCH 1/1] efi_loader: stop watchdogs in ExitBootServices()

2021-11-09 Thread Michael Walle
Am 2021-11-09 15:46, schrieb Mark Kettenis: From: Michael Walle Date: Tue, 9 Nov 2021 15:20:17 +0100 > The UEFI specification requires for ExitBootServices() that "the boot > services watchdog timer is disabled". We already disable the software > watchdog. We should additionally disable the ha

Re: [PATCH 1/1] efi_loader: stop watchdogs in ExitBootServices()

2021-11-09 Thread Mark Kettenis
> From: Michael Walle > Date: Tue, 9 Nov 2021 15:20:17 +0100 > > > The UEFI specification requires for ExitBootServices() that "the boot > > services watchdog timer is disabled". We already disable the software > > watchdog. We should additionally disable the hardware watchdogs. > > What about

[PATCH v2 2/2] board: sifive: unmatched: rearrange load addresses

2021-11-09 Thread Heinrich Schuchardt
* Put the small files below $kernel_addr_r to not limit the kernel size. * ramdisk_addr_r should be the highest of all loading addresses to avoid limiting the size of the initial RAM disk. Signed-off-by: Heinrich Schuchardt --- v2: new patch --- include/configs/sifive-unmatched.h | 15

[PATCH v2 1/2] board: sifive: unmatched: use zero copy for initrd

2021-11-09 Thread Heinrich Schuchardt
Booting Ubuntu Impish showed the following output: relocaddr = 0xfff6 Loading Ramdisk to fa118000, end f19d ... The initrd is overwriting the U-Boot binary. Booting fails. There is no need to copy the initrd from $ramdisk_addr_r. Set init_high = ~0UL to use zero copy.

[PATCH v2 0/2] board: sifive: unmatched: use zero copy for initrd

2021-11-09 Thread Heinrich Schuchardt
Booting Ubuntu Impish showed the following output: relocaddr = 0xfff6 Loading Ramdisk to fa118000, end f19d ... The initrd is overwriting the U-Boot binary. Booting fails. There is no need to copy the initrd from $ramdisk_addr_r. Set init_high = ~0UL to use zero copy.

Re: [PATCH 06/11] mmc: fsl_esdhc_imx: fix mmc->clock with actual clock

2021-11-09 Thread Sean Anderson
On 11/9/21 2:23 AM, Jaehoon Chung wrote: On 11/6/21 2:39 AM, Sean Anderson wrote: [ fsl_esdhc commit 30f6444d024a74ee48aa6969c1531aecd3c59deb ] Fix mmc->clock with actual clock which is divided by the controller, and record it with priv->clock. Signed-off-by: Yangbo Lu Signed-off-by: Sean

Re: [PATCH 04/11] mmc: fsl_esdhc_imx: clean up bus width configuration code

2021-11-09 Thread Sean Anderson
On 11/9/21 2:19 AM, Jaehoon Chung wrote: On 11/6/21 2:39 AM, Sean Anderson wrote: [ fsl_esdhc commit 07bae1de382723b94244096953b05225572728cd ] This patch is to clean up bus width setting code. - For DM_MMC, remove getting "bus-width" from device tree. This has been done in mmc_of_parse()

Re: [PATCH 5/5] firmware: scmi: Add OP-TEE transport

2021-11-09 Thread Patrick DELAUNAY
Hi Etienne, one missing remark, don't see in my first review. On 11/4/21 3:14 PM, Etienne Carriere wrote: This change implements an SCMI transport for agent interfacing the OP-TEE SCMI service. OP-TEE provides an SCMI PTA (Pseudo-TA) for non-secure world to send SCMI messages over an identified

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-09 Thread Heinrich Schuchardt
On 11/9/21 15:26, Andre Przywara wrote: On Tue, 9 Nov 2021 08:50:37 -0500 Tom Rini wrote: Hi, On Tue, Nov 09, 2021 at 09:00:05AM +0100, Heinrich Schuchardt wrote: [snip] thanks for that ;-) I am still puzzled about this, if I read the UEFI spec correctly, the 5 minutes watchdog timer is

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-09 Thread Andre Przywara
On Tue, 9 Nov 2021 08:50:37 -0500 Tom Rini wrote: Hi, > On Tue, Nov 09, 2021 at 09:00:05AM +0100, Heinrich Schuchardt wrote: > > [snip] thanks for that ;-) > > > I am still puzzled about this, if I read the UEFI spec correctly, the > > > 5 minutes watchdog timer is for EFI applications using

Re: [PATCH 1/1] efi_loader: stop watchdogs in ExitBootServices()

2021-11-09 Thread Michael Walle
> The UEFI specification requires for ExitBootServices() that "the boot > services watchdog timer is disabled". We already disable the software > watchdog. We should additionally disable the hardware watchdogs. What about watchdogs that cannot be stopped? IIRC the IMX SoCs are like that. -michael

Re: [PATCH 0/2] RFC: add fdt_add_pubkey tool

2021-11-09 Thread Jan Kiszka
On 09.11.21 14:16, François Ozog wrote: > Hi Jan > > On Tue, 9 Nov 2021 at 13:58, Jan Kiszka > wrote: > > On 09.11.21 13:43, François Ozog wrote: > > Hi > > > > as we are in design discussions, I would promote the idea of not > pushing > > n

Re: [PATCH] net: uclass: Save ethernet MAC address when generated

2021-11-09 Thread Michael Walle
Am 2021-11-04 22:00, schrieb Ramon Fried: What's the verdict ? We're keeping this patch ? There was a good point from Grygorii: linux might deal in its own way with missing ethernet addresses (and warn the user about it because its usually an error). And IMHO that net list can be fixed in a d

Re: [RFC 2/3] efi_loader: bootmgr: add booting from removable media

2021-11-09 Thread Mark Kettenis
> From: AKASHI Takahiro > Date: Tue, 9 Nov 2021 10:32:32 +0900 Hi Takahiro, > Under the current implementation, booting from removal media using > a architecture-specific default image name, say BOOTAA64.EFI, is > supported only in distro_bootcmd script. See the commit 74522c898b35 > ("efi_load

Re: [PATCH v3 0/6] Improved sysreset/watchdog uclass integration

2021-11-09 Thread Tom Rini
On Tue, Nov 09, 2021 at 09:00:05AM +0100, Heinrich Schuchardt wrote: [snip] > > I am still puzzled about this, if I read the UEFI spec correctly, the > > 5 minutes watchdog timer is for EFI applications using boot services? > > So grub, for instance. But the description of ExitBootServices tells m

  1   2   >