Hi Matthew, On Wed, 10 Nov 2021 at 04:43, Mathew McBride <m...@traverse.com.au> wrote: > > > > On Thu, Nov 4, 2021, at 6:39 PM, Ilias Apalodimas wrote: > > Hi Matthew, > > On Thu, 4 Nov 2021 at 03:14, Mathew McBride <m...@traverse.com.au> wrote: > > > static int tpm_atmel_twi_get_desc(struct udevice *dev, char *buf, int size) > > { > > - return 0; > > + if (size < 50) > > + return -ENOSPC; > > + > > + return snprintf(buf, size, "Atmel 1.2 TPM (%s)", dev->name); > > Is there anything more helpful we can print on that? Device ID, > manufacturer ID maybe? > > Perhaps the DT compatible would be useful? > > => tpm device > device 0: atmel,at97sc3204t TPM 1.2 (tpm@29)
No strong preference here, up to you. > > > tpm_version under Linux provides this, but it requires talking to the TPM > over TIS: > $ tpm_version > TPM 1.2 Version Info: > Chip Version: 1.2.66.16 > Spec Level: 2 > Errata Revision: 3 > TPM Vendor ID: ATML > TPM Version: 01010000 > Manufacturer Info: 41544d4c > Ok fair enough. I am fine keeping it as is. Thanks /Ilias