Re: [PATCH] sandbox: Remove OF_HOSTFILE

2021-09-28 Thread Ilias Apalodimas
> > > - */ > > > -int sandbox_read_fdt_from_file(void); > > > - > > > /** > > > * sandbox_reset() - reset sandbox > > > * > > > diff --git a/configs/sandbox64_defconfig b/configs/sandbox64_defconfig > > > index f7098b496983..358a6c168259 100644 > > > --- a/configs/sandbox64_defconfig > > > +++

[PATCH 3/3] net: tsec: Make redundant_init() static

2021-09-28 Thread Bin Meng
redundant_init() is only called in the tsec driver. Make it static. Signed-off-by: Bin Meng --- drivers/net/tsec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c index ee820aae15..b433e411bd 100644 --- a/drivers/net/tsec.c +++ b/drive

[PATCH 2/3] net: fec_mxc: Declare 'promisc' as bool

2021-09-28 Thread Bin Meng
priv->promisc is used as the parameter of the set_promisc() call which accepts a bool type instead of char. Signed-off-by: Bin Meng --- drivers/net/fec_mxc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/fec_mxc.h b/drivers/net/fec_mxc.h index 62b55ef395..133f5

[PATCH 1/3] net: dsa: Use true instead of 1 in the set_promisc() call

2021-09-28 Thread Bin Meng
set_promisc() call accepts the parameter of a bool type. Make it clear by using true instead of 1. Signed-off-by: Bin Meng --- net/dsa-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dsa-uclass.c b/net/dsa-uclass.c index 694664d81b..dcefec03f4 100644 --- a/net/d

Re: [PATCH] sandbox: Remove OF_HOSTFILE

2021-09-28 Thread Ilias Apalodimas
Hi Simon, [...] > > -INPUTS-$(CONFIG_OF_HOSTFILE) += u-boot.dtb > > +INPUTS-$(CONFIG_SANDBOX) += u-boot.dtb > > ifneq ($(CONFIG_SPL_TARGET),) > > INPUTS-$(CONFIG_SPL) += $(CONFIG_SPL_TARGET:"%"=%) > > endif > > @@ -1423,7 +1423,7 @@ u-boot-lzma.img: u-boot.bin.lzma FORCE > > > > u-boot-dtb.im

Re: [PATCH 2/2] mtd: spi-nor-core: Add fixups for Spansion S25FL256L

2021-09-28 Thread Takahiro Kuwano
On 9/18/2021 1:51 AM, Pratyush Yadav wrote: > On 08/09/21 05:47PM, tkuw584...@gmail.com wrote: >> From: Takahiro Kuwano >> >> The S25FL256L is 32MB NOR Flash that does not support Bank Address >> Register. This fixup is activated if CONFIG_SPI_FLASH_BAR is enabled and >> returns ENOTSUPP in setup(

Re: [PATCH] arm: dts: armada8040: Fix CP0 eMMC/SDIO support

2021-09-28 Thread Stefan Roese
On 27.09.21 23:03, Robert Marko wrote: During the migration to a single DTSI for the CP110-s specific pinctrl compatibles were moved to the SoC DTSI as CP0 and CP1 have some specifics. Namely, CP0 eMMC/SDIO support depends on the mvebu-pinctrl driver setting the BIT(0) in eMMC PHY IO Control 0 Re

Re: [PATCH v2 1/2] nvme: Enable FUA

2021-09-28 Thread Bin Meng
On Mon, Sep 27, 2021 at 9:22 PM Jon Lin wrote: > > Most NVME devcies maintain data in internal cache for an uncertain typo: devices > times, and u-boot has no method to force NVME to flush cache. > So this patch adds FUA to avoid data loss caused by power off after data > programming. > > Signed

Re: [PATCH 9/9] configs: ls1021a-tsn: enable the generation of random Ethernet MAC addresses

2021-09-28 Thread Bin Meng
On Tue, Sep 28, 2021 at 7:50 AM Vladimir Oltean wrote: > > Don't fail when booting a board with an empty EEPROM for MAC addresses. > > Signed-off-by: Vladimir Oltean > --- > configs/ls1021atsn_qspi_defconfig | 1 + > configs/ls1021atsn_sdcard_defconfig | 1 + > 2 files changed, 2 insertions(+)

Re: [PATCH 8/9] configs: ls1021a-tsn: enable sja1105 switch driver

2021-09-28 Thread Bin Meng
On Tue, Sep 28, 2021 at 7:51 AM Vladimir Oltean wrote: > > The sja1105 is a 5-port switch that uses a DM_DSA driver. Its 5th (CPU) > port is connected internally to the eth2 port of the LS1021A SoC. > > Signed-off-by: Vladimir Oltean > --- > configs/ls1021atsn_qspi_defconfig | 2 ++ > configs/

Re: [PATCH 4/9] net: introduce a helper to determine whether to use in-band autoneg

2021-09-28 Thread Bin Meng
On Tue, Sep 28, 2021 at 7:50 AM Vladimir Oltean wrote: > > Certain serial SERDES protocols like 1000base-x, 2500base-x, SGMII, > USXGMII can operate either in a mode where the PHY (be it on-board or > inside an SFP module) passes the link parameters (speed, duplex, pause) > to the MAC through in-b

Re: [PATCH 2/9] include: import if_vlan.h from Linux

2021-09-28 Thread Bin Meng
On Tue, Sep 28, 2021 at 7:49 AM Vladimir Oltean wrote: > > This is needed for the VLAN header structure. > > Signed-off-by: Vladimir Oltean > --- > include/linux/if_vlan.h | 26 ++ > 1 file changed, 26 insertions(+) > create mode 100644 include/linux/if_vlan.h > Reviewe

Re: [PATCH 1/9] net: tsec: add support for promiscuous mode

2021-09-28 Thread Bin Meng
On Tue, Sep 28, 2021 at 7:49 AM Vladimir Oltean wrote: > > The Freescale TSEC can be a DSA master, and the ports of the attached > DSA switch can have different MAC addresses compared to the TSEC. > Nonetheless, the TSEC must receive the packets on behalf of those switch > ports. Therefore, implem

Re: imx6 DM_VIDEObroken

2021-09-28 Thread Fabio Estevam
Hi Tim, On Tue, Sep 28, 2021 at 2:00 PM Tim Harvey wrote: > I would think the other board maintainers would have raised a red flag > if things broke for their boards, I just haven't tested it in quite > some time for gwventana_*_defconfig. I have just tested wandboard with the top of tree U-Boo

Re: [PATCH] configs: ls1028a: ensure Ethernet is enabled

2021-09-28 Thread Bin Meng
On Tue, Sep 28, 2021 at 7:18 AM Vladimir Oltean wrote: > > CONFIG_FSL_ENETC is not explicitly enabled in the NXP LS1028A config > files, instead it is selected by CONFIG_MSCC_FELIX_SWITCH, a state of > matters which is fragile. > > CONFIG_MSCC_FELIX_SWITCH depends on CONFIG_DM_DSA, which depends o

Re: Status of the various RISC-V specification and policy

2021-09-28 Thread Atish Patra
On Tue, Sep 28, 2021 at 3:43 PM Palmer Dabbelt wrote: > > On Tue, 28 Sep 2021 13:05:53 PDT (-0700), ati...@atishpatra.org wrote: > > On Tue, Sep 28, 2021 at 11:34 AM Palmer Dabbelt wrote: > >> > >> On Mon, 27 Sep 2021 08:57:15 PDT (-0700), markhimelst...@riscv.org wrote: > >> > the words in this

Re: [PATCH 17/17] ti: keystone: Migrate CONFIG_SOC_K2* to Kconfig

2021-09-28 Thread Tom Rini
On Sun, Sep 12, 2021 at 08:32:33PM -0400, Tom Rini wrote: > Move the individual keystone 2 SoC symbols to the mach Kconfig file, > select them as needed. > > Signed-off-by: Tom Rini Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 16/17] ti: keystone: Move away from CONFIG_SOC_KEYSTONE

2021-09-28 Thread Tom Rini
On Sun, Sep 12, 2021 at 08:32:32PM -0400, Tom Rini wrote: > We have individual SOC symbols for each keystone 2 platform. Use the > existing CONFIG_ARCH_KEYSTONE rather than CONFIG_SOC_KEYSTONE to > encompass all of the keystone families. > > Signed-off-by: Tom Rini Applied to u-boot/next, than

Re: [PATCH 15/17] omap4_panda: Remove unused comments/code

2021-09-28 Thread Tom Rini
On Sun, Sep 12, 2021 at 08:32:31PM -0400, Tom Rini wrote: > Clean up the config header file by removing some now irrelevant code / > comments. > > Signed-off-by: Tom Rini Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 14/17] omap3_logic: Remove unused comments/code

2021-09-28 Thread Tom Rini
On Sun, Sep 12, 2021 at 08:32:30PM -0400, Tom Rini wrote: > Clean up the config header file by removing some now irrelevant code / > comments. > > Signed-off-by: Tom Rini Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 13/17] am3517_evm: Remove unused comments/code

2021-09-28 Thread Tom Rini
On Sun, Sep 12, 2021 at 08:32:29PM -0400, Tom Rini wrote: > Clean up the config header file by removing some now irrelevant code / > comments. > > Signed-off-by: Tom Rini Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 12/17] Convert CONFIG_OMAP_EHCI_PHY1_RESET_GPIO et al to Kconfig

2021-09-28 Thread Tom Rini
On Sun, Sep 12, 2021 at 08:32:28PM -0400, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_OMAP_EHCI_PHY1_RESET_GPIO >CONFIG_OMAP_EHCI_PHY2_RESET_GPIO >CONFIG_OMAP_EHCI_PHY3_RESET_GPIO > > To do this, we also introduce CONFIG_HAS_CONFIG_OMAP_EHCI_PHYn_RESET_GPIO > opt

Re: [PATCH 11/17] usb: ehci-omap: Drop non-DM_USB legacy code

2021-09-28 Thread Tom Rini
On Sun, Sep 12, 2021 at 08:32:27PM -0400, Tom Rini wrote: > Now that DM_USB is always enabled, we can drop some legacy code. > > Signed-off-by: Tom Rini Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 10/17] omapl138_lcdk: Stop using CONFIG_MACH_OMAPL138_LCDK

2021-09-28 Thread Tom Rini
On Sun, Sep 12, 2021 at 08:32:26PM -0400, Tom Rini wrote: > We have one places that uses this symbol and CONFIG_TARGET_OMAPL138_LCDK > works equally well, switch to that. > > Signed-off-by: Tom Rini Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 09/17] ti: keystone: dma: Migrate to Kconfig

2021-09-28 Thread Tom Rini
On Sun, Sep 12, 2021 at 08:32:25PM -0400, Tom Rini wrote: > Move the main option for handling drivers/dma/keystone_nav* to Kconfig, > and enable it by default. All of the sub-symbols are not configurable, > so remove them from the CONFIG namespace. > > Signed-off-by: Tom Rini Applied to u-boot

Re: [PATCH 08/17] ti: keystone: Clean up or migrate some NAND related options.

2021-09-28 Thread Tom Rini
On Sun, Sep 12, 2021 at 08:32:24PM -0400, Tom Rini wrote: > The COFNIG_KEYSTONE_RBL_NAND option is always enabled for the driver on > keystone platforms, but not older davinci platforms. Use def_bool for > the symbol. For CONFIG_KEYSTONE_NAND_MAX_RBL_PAGE, it's only used within > the driver and d

Re: [PATCH 2/3] doc: ti: am335x_evm: Minor general updates

2021-09-28 Thread Tom Rini
On Sat, Sep 11, 2021 at 08:57:32AM -0400, Tom Rini wrote: > - At this point there are a large number of Beaglebone boards, refer to > them as a family rather than a growing list. > - Reword customization as we're largely Kconfig-oriented now. > - Remove the NOR section as the relevant defconfigs

Re: [PATCH 07/17] compulab: Clean up some unused symbols

2021-09-28 Thread Tom Rini
On Sun, Sep 12, 2021 at 08:32:23PM -0400, Tom Rini wrote: > Since cm_t35 was removed, CONFIG_CM_T3X does not exist. This lets us > simplify the code in board/compulab/common/eeprom.c a bit. > > Cc: Igor Grinberg > Cc: Nikita Kiryanov > Signed-off-by: Tom Rini Applied to u-boot/next, thanks!

Re: [PATCH 06/17] Convert CONFIG_USB_XHCI_OMAP to Kconfig

2021-09-28 Thread Tom Rini
On Sun, Sep 12, 2021 at 08:32:22PM -0400, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_USB_XHCI_OMAP > > Signed-off-by: Tom Rini Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 05/17] usb: phy: ti: Remove non-DM PHY code

2021-09-28 Thread Tom Rini
On Sun, Sep 12, 2021 at 08:32:21PM -0400, Tom Rini wrote: > At this point in time, all platforms that had previously used > drivers/usb/phy/omap_usb_phy.c have been migrated to DM and related > options. Remove this now unused code and some related unused defines. > > Signed-off-by: Tom Rini Ap

Re: [PATCH 04/17] keystone2: Move CONFIG_AEMIF_CNTRL_BASE out of CONFIG namespace

2021-09-28 Thread Tom Rini
On Sun, Sep 12, 2021 at 08:32:20PM -0400, Tom Rini wrote: > This is only used in the aemif driver that is otherwise currently > keystone2 centric. Moving forward, if this is applicable to some other > platform then such base addresses should be able to be obtained via the > device tree. Use KS2_

Re: [PATCH 1/3] doc: ti: Convert am335x_evm README to rST

2021-09-28 Thread Tom Rini
On Sat, Sep 11, 2021 at 08:57:31AM -0400, Tom Rini wrote: > Convert the existing documentation to rST, keeping to just making > formatting changes to start with. > > Signed-off-by: Tom Rini Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: Please pull u-boot-i2c/next

2021-09-28 Thread Tom Rini
enx.de/u-boot/custodians/u-boot-dm into next > (2021-09-27 11:09:23 -0400) > > are available in the Git repository at: > > https://source.denx.de/u-boot/custodians/u-boot-i2c.git 20210928-for-next > > for you to fetch changes up to a70c3f9fb84524243eabefd28e0aa539f22e6226: >

Re: [PATCH] sandbox: Remove OF_HOSTFILE

2021-09-28 Thread Simon Glass
Hi Ilias, On Tue, 28 Sept 2021 at 03:05, Ilias Apalodimas wrote: > > OF_HOSTFILE is used on sandbox configs only. Although it's pretty > unique not a source of any confusions, we are better of having simple > config options for the DTB. > So let's replace that with the existing OF_BOARD. This

Re: Status of the various RISC-V specification and policy

2021-09-28 Thread Palmer Dabbelt
On Tue, 28 Sep 2021 13:05:53 PDT (-0700), ati...@atishpatra.org wrote: On Tue, Sep 28, 2021 at 11:34 AM Palmer Dabbelt wrote: On Mon, 27 Sep 2021 08:57:15 PDT (-0700), markhimelst...@riscv.org wrote: > the words in this document : > > https://wiki.riscv.org/plugins/servlet/mobile?contentId=13

Re: Status of the various RISC-V specification and policy

2021-09-28 Thread Atish Patra
On Tue, Sep 28, 2021 at 11:34 AM Palmer Dabbelt wrote: > > On Mon, 27 Sep 2021 08:57:15 PDT (-0700), markhimelst...@riscv.org wrote: > > the words in this document : > > > > https://wiki.riscv.org/plugins/servlet/mobile?contentId=13098230#content/view/13098230 > > > > make it very clear when chang

linksys wrt1900acs v2 boot problem

2021-09-28 Thread Dilyan Lazarov
Hi, I have a problem with my linksys wrt1900acs. My main question is this a hardware problem or software problem? Is it possible to address? I have started researching and have tried with "kwboot" under Windows VM - Ubuntu 20 - Linux but I have a problem with usb serial connection. I have tried sev

Please pull u-boot-net/network_master

2021-09-28 Thread Ramon Fried
Hi Tom, Please pull u-boot-net/network_master. The following changes since commit 0b9bcf665cd98fe9db0956c894006b250a7d465f: Prepare v2021.10-rc5 (2021-09-27 09:34:20 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-net.git for you to fetch chan

Re: [PATCH v4 2/2] mtd: spi: nor: force mtd name to "nor%d"

2021-09-28 Thread Tom Rini
On Wed, Sep 22, 2021 at 06:29:08PM +0200, Patrick Delaunay wrote: > Force the mtd name of spi-nor to "nor" + the driver sequence number: > "nor0", "nor1"... beginning after the existing nor devices. > > This patch is coherent with existing "nand" and "spi-nand" > mtd device names. > > When CFI M

Re: [PATCH v4 1/2] mtd: cfi_flash: use cfi_flash_num_flash_banks only when supported

2021-09-28 Thread Tom Rini
On Wed, Sep 22, 2021 at 06:29:07PM +0200, Patrick Delaunay wrote: > When CONFIG_SYS_MAX_FLASH_BANKS_DETECT is activated, > CONFIG_SYS_MAX_FLASH_BANKS is replaced by cfi_flash_num_flash_banks, > but this variable is defined in drivers/mtd/cfi_flash.c, which is > compiled only when CONFIG_FLASH_CFI_

Re: [PATCH] imx: imx7d-sdb: fix ethernet, sync .dts with linux

2021-09-28 Thread Tom Rini
On Thu, Sep 16, 2021 at 04:53:14PM +0200, Rasmus Villemoes wrote: > Commit 0d52bab46 (mx7dsabre: Enable DM_ETH) changed these flags from 0 > (aka GPIO_ACTIVE_HIGH) to GPIO_ACTIVE_LOW. It claimed to "Also sync > device tree with v5.5-rc1", but in the linux tree, these gpios have > always been GPIO_

Re: [RFC][PATCH] mtd: spi: Set CONFIG_SF_DEFAULT_MODE default to 0

2021-09-28 Thread Tom Rini
On Tue, Sep 14, 2021 at 08:28:24PM +0200, Marek Vasut wrote: > Before e2e95e5e254 ("spi: Update speed/mode on change") most systems > silently defaulted to SF bus mode 0. Now the mode is always updated, > which causes breakage. It seems most SF which are used as boot media > operate in bus mode 0,

Re: [PATCH] mtd: nand: raw: convert nand_dt_init() to ofnode_xx() interface

2021-09-28 Thread Tom Rini
On Mon, Sep 13, 2021 at 04:25:53PM +0200, Patrice Chotard wrote: > nand_dt_init() is still using fdtdec_xx() interface. > If OF_LIVE flag is enabled, dt property can't be get anymore. > Updating all fdtdec_xx() interface to ofnode_xx() to solve this issue. > > For doing this, node parameter type

Re: Status of the various RISC-V specification and policy

2021-09-28 Thread Palmer Dabbelt
On Mon, 27 Sep 2021 08:57:15 PDT (-0700), markhimelst...@riscv.org wrote: the words in this document : https://wiki.riscv.org/plugins/servlet/mobile?contentId=13098230#content/view/13098230 make it very clear when changes are allowed or not and likely or not. if you think the verbiage is some

error -22 whilst initialising SD Card - New Raspberry Pi 4b 4GB (C0 stepping)

2021-09-28 Thread Craig Setera
Hello, I wasn't quite sure where to report this, so I figured I would start with the mailing list.  If there is another place I should go, please feel free to redirect me. I'm a user if IPFire which uses u-boot.  I recently bought a new Raspberry Pi 4b 4gb device, but it fails to boot with a

Re: [PATCH v2 1/3] efi_loader: add SMBIOS table measurement

2021-09-28 Thread Ilias Apalodimas
Hi Simon, [...] > > > > We've mentioned this in the past. The sandbox TPM is very limited wrt > > > > tpm testing for the EFI TCG protocol. > > > > > > So let's add some more features? If it helps, think of the sandbox TPM > > > as test code, not an emulator. It is a very simple kind of emulator

Re: [PATCH 6/9] net: add driver for NXP SJA1105 DSA L2 switch

2021-09-28 Thread Ramon Fried
On Tue, Sep 28, 2021 at 2:48 AM Vladimir Oltean wrote: > > The SJA1105 driver is largely reused from Linux. Its programming model > is that it is blank out of reset, and it waits for a static > configuration stream over SPI, which contains all runtime parameters (it > has no notion of "default val

[PATCH] tools/image-host.c: Fix spelling of "expected".

2021-09-28 Thread Vagrant Cascadian
Signed-off-by: Vagrant Cascadian --- tools/image-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/image-host.c b/tools/image-host.c index d3a882ec29..a6b0a94420 100644 --- a/tools/image-host.c +++ b/tools/image-host.c @@ -313,7 +313,7 @@ static int fit_image_read_

Re: imx6 DM_VIDEObroken

2021-09-28 Thread Tim Harvey
On Tue, Sep 28, 2021 at 5:55 AM Anatolij Gustschin wrote: > > Hey Tim, > > On Mon, 27 Sep 2021 17:25:58 -0700 > Tim Harvey thar...@gateworks.com wrote: > > > Anatolij, > > > > Since commit d37618d18d49 ("imx: convert gwventana board to DM_VIDEO") > > video support for IMX6 based Ventana boards has

Re: [PATCH u-boot-spi v2 5/9] mtd: spi-nor-core: Don't check for zero length in spi_nor_erase()

2021-09-28 Thread Pratyush Yadav
On 25/09/21 07:33PM, Marek Behún wrote: > From: Marek Behún > > This check is already done in mtdcore's mtd_erase(), no reason to do > this here as well. But do we always get here via mtd_erase()? What about "sf erase"? I looked at the code and I don't see any checks for 0 length there. > > S

Re: [PATCH u-boot-spi v2 1/9] mtd: spi-nor-core: Try cleaning up in case writing BAR failed

2021-09-28 Thread Pratyush Yadav
On 25/09/21 07:33PM, Marek Behún wrote: > From: Marek Behún > > Use the cleanup codepath of spi_nor_erase() also in the event of failure > of writing the BAR register. > > Signed-off-by: Marek Behún > Reviewed-by: Simon Glass > Reviewed-by: Jagan Teki > Tested-by: Masami Hiramatsu Reviewed-

Re: [PATCH u-boot-spi v2 2/9] mtd: spi-nor-core: Check return value of write_enable() in spi_nor_erase()

2021-09-28 Thread Pratyush Yadav
On 25/09/21 07:33PM, Marek Behún wrote: > From: Marek Behún > > The spi_nor_erase() function does not check return value of the > write_enable() call. Fix this. This is the case for many more calls for write_enable(), but we can fix them later I suppose. Reviewed-by: Pratyush Yadav > > Sign

Re: [PATCH 1/2] net: dsa: pass CPU port fixed PHY to .port_disable

2021-09-28 Thread Tim Harvey
On Sat, Sep 18, 2021 at 4:50 AM Vladimir Oltean wrote: > > While adding the logic for DSA to register a fixed-link PHY for the CPU > port, I forgot to pass it to the .port_disable method too, just > .port_enable. > > Bug had no impact for felix_switch.c, due to the phy argument not being > used, b

Re: [PATCH 19/25] net: qe: uec: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-28 Thread Ramon Fried
On Mon, Sep 27, 2021 at 2:22 PM Vladimir Oltean wrote: > > strncpy() simply bails out when copying a source string whose size > exceeds the destination string size, potentially leaving the destination > string unterminated. > > One possible way to address is to pass MDIO_NAME_LEN - 1 and a > previ

Re: [PATCH 14/25] net: dsa: felix: ensure mii_bus->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-28 Thread Ramon Fried
On Mon, Sep 27, 2021 at 2:22 PM Vladimir Oltean wrote: > > strncpy() simply bails out when copying a source string whose size > exceeds the destination string size, potentially leaving the destination > string unterminated. > > One possible way to address is to pass MDIO_NAME_LEN - 1 and a > previ

Re: [PATCH 5/9] net: dsa: felix: configure the in-band autoneg property based on OF node info

2021-09-28 Thread Ramon Fried
On Tue, Sep 28, 2021 at 2:48 AM Vladimir Oltean wrote: > > Instead of trying to guess which operating modes need in-band > negotiation to be active and which ones don't, parse the available > information from the device tree. That will be correct in the cases we > can already guess, and more. > >

Re: [PATCH 4/9] net: introduce a helper to determine whether to use in-band autoneg

2021-09-28 Thread Ramon Fried
On Tue, Sep 28, 2021 at 2:48 AM Vladimir Oltean wrote: > > Certain serial SERDES protocols like 1000base-x, 2500base-x, SGMII, > USXGMII can operate either in a mode where the PHY (be it on-board or > inside an SFP module) passes the link parameters (speed, duplex, pause) > to the MAC through in-b

Re: [PATCH 3/9] net: dsa: allow drivers to get the port OF node

2021-09-28 Thread Ramon Fried
On Tue, Sep 28, 2021 at 2:48 AM Vladimir Oltean wrote: > > In the current DSA switch driver API, only the udevice of the switch > (belonging to UCLASS_DSA) is exposed, as well as an "int port" argument. > So drivers do not have access to the udevice of individual ports > (belonging to UCLASS_ETH),

Re: [PATCH 1/9] net: tsec: add support for promiscuous mode

2021-09-28 Thread Ramon Fried
On Tue, Sep 28, 2021 at 2:48 AM Vladimir Oltean wrote: > > The Freescale TSEC can be a DSA master, and the ports of the attached > DSA switch can have different MAC addresses compared to the TSEC. > Nonetheless, the TSEC must receive the packets on behalf of those switch > ports. Therefore, implem

Re: [PATCH] net: phy: mscc: add support for VSC8502 in dual RGMII mode

2021-09-28 Thread Ramon Fried
On Tue, Sep 28, 2021 at 2:13 AM Vladimir Oltean wrote: > > The VSC8502 is a Microchip (formerly Microsemi, formerly Vitesse) > dual port, gigabit Ethernet copper PHY which supports the MII, GMII and > RGMII MAC-side interfaces. > > Of these, I could only test RGMII, and my board needed RGMII delay

Re: [PATCH 23/25] net: dsa: ensure port names are NULL-terminated after DSA_PORT_NAME_LENGTH truncation

2021-09-28 Thread Ramon Fried
On Mon, Sep 27, 2021 at 2:22 PM Vladimir Oltean wrote: > > strncpy() simply bails out when copying a source string whose size > exceeds the destination string size, potentially leaving the destination > string unterminated. > > One possible way to address is to pass DSA_PORT_NAME_LENGTH - 1 and a

Re: [PATCH 22/25] net: dsa: felix: check return code of mdio_alloc and mdio_register

2021-09-28 Thread Ramon Fried
On Mon, Sep 27, 2021 at 2:22 PM Vladimir Oltean wrote: > > These functions can return errors, it's best to catch them and trigger > the driver unwind code path. > > Signed-off-by: Vladimir Oltean > --- > drivers/net/mscc_eswitch/felix_switch.c | 10 +- > 1 file changed, 9 insertions(+),

Re: [PATCH 20/25] net: mdio-uclass: rewrite dm_mdio_post_probe using strlcpy

2021-09-28 Thread Ramon Fried
On Mon, Sep 27, 2021 at 2:22 PM Vladimir Oltean wrote: > > dm_mdio_post_probe used to be vulnerable after truncation, but has been > patched by commit 398e7512d8d7 ("net: Fix Covarity Defect 244093"). > Nonetheless, we can use strlcpy like the rest of the code base now, > which yields the same res

Re: [PATCH 18/25] net: davinci_emac: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-28 Thread Ramon Fried
On Mon, Sep 27, 2021 at 2:22 PM Vladimir Oltean wrote: > > strncpy() simply bails out when copying a source string whose size > exceeds the destination string size, potentially leaving the destination > string unterminated. > > One possible way to address is to pass MDIO_NAME_LEN - 1 and a > previ

Re: [PATCH 16/25] net: sh_eth: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-28 Thread Ramon Fried
On Mon, Sep 27, 2021 at 2:22 PM Vladimir Oltean wrote: > > strncpy() simply bails out when copying a source string whose size > exceeds the destination string size, potentially leaving the destination > string unterminated. > > One possible way to address is to pass MDIO_NAME_LEN - 1 and a > previ

Re: [PATCH 17/25] net: smc911x: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-28 Thread Ramon Fried
On Mon, Sep 27, 2021 at 2:22 PM Vladimir Oltean wrote: > > strncpy() simply bails out when copying a source string whose size > exceeds the destination string size, potentially leaving the destination > string unterminated. > > One possible way to address is to pass MDIO_NAME_LEN - 1 and a > previ

Re: [PATCH 15/25] net: mvgbe: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-28 Thread Ramon Fried
On Mon, Sep 27, 2021 at 2:22 PM Vladimir Oltean wrote: > > strncpy() simply bails out when copying a source string whose size > exceeds the destination string size, potentially leaving the destination > string unterminated. > > One possible way to address is to pass MDIO_NAME_LEN - 1 and a > previ

Re: [PATCH 13/25] net: mpc8xx_fec: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-28 Thread Ramon Fried
On Mon, Sep 27, 2021 at 2:22 PM Vladimir Oltean wrote: > > strncpy() simply bails out when copying a source string whose size > exceeds the destination string size, potentially leaving the destination > string unterminated. > > One possible way to address is to pass MDIO_NAME_LEN - 1 and a > previ

Re: [PATCH 12/25] net: macb: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-28 Thread Ramon Fried
On Mon, Sep 27, 2021 at 2:22 PM Vladimir Oltean wrote: > > strncpy() simply bails out when copying a source string whose size > exceeds the destination string size, potentially leaving the destination > string unterminated. > > One possible way to address is to pass MDIO_NAME_LEN - 1 and a > previ

Re: [PATCH 10/25] net: ftmac110: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-28 Thread Ramon Fried
On Mon, Sep 27, 2021 at 2:22 PM Vladimir Oltean wrote: > > strncpy() simply bails out when copying a source string whose size > exceeds the destination string size, potentially leaving the destination > string unterminated. > > One possible way to address is to pass MDIO_NAME_LEN - 1 and a > previ

Re: [PATCH 11/25] net: lpc32xx: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-28 Thread Ramon Fried
On Mon, Sep 27, 2021 at 2:22 PM Vladimir Oltean wrote: > > strncpy() simply bails out when copying a source string whose size > exceeds the destination string size, potentially leaving the destination > string unterminated. > > One possible way to address is to pass MDIO_NAME_LEN - 1 and a > previ

Re: [PATCH 09/25] net: mcdmafec: ensure bus->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-28 Thread Ramon Fried
On Mon, Sep 27, 2021 at 2:22 PM Vladimir Oltean wrote: > > strncpy() simply bails out when copying a source string whose size > exceeds the destination string size, potentially leaving the destination > string unterminated. > > One possible way to address is to pass MDIO_NAME_LEN - 1 and a > previ

Re: [PATCH 08/25] net: enetc: ensure imdio.name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-28 Thread Ramon Fried
On Mon, Sep 27, 2021 at 2:22 PM Vladimir Oltean wrote: > > strncpy() simply bails out when copying a source string whose size > exceeds the destination string size, potentially leaving the destination > string unterminated. > > One possible way to address is to pass MDIO_NAME_LEN - 1 and a > previ

Re: [PATCH 07/25] net: ep93xx: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-28 Thread Ramon Fried
On Mon, Sep 27, 2021 at 2:22 PM Vladimir Oltean wrote: > > strncpy() simply bails out when copying a source string whose size > exceeds the destination string size, potentially leaving the destination > string unterminated. > > One possible way to address is to pass MDIO_NAME_LEN - 1 and a > previ

Re: [PATCH 06/25] net: eepro100: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-28 Thread Ramon Fried
On Mon, Sep 27, 2021 at 2:22 PM Vladimir Oltean wrote: > > strncpy() simply bails out when copying a source string whose size > exceeds the destination string size, potentially leaving the destination > string unterminated. > > One possible way to address is to pass MDIO_NAME_LEN - 1 and a > previ

Re: [PATCH 05/25] net: bcm-sf2: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-28 Thread Ramon Fried
On Mon, Sep 27, 2021 at 2:22 PM Vladimir Oltean wrote: > > strncpy() simply bails out when copying a source string whose size > exceeds the destination string size, potentially leaving the destination > string unterminated. > > One possible way to address is to pass MDIO_NAME_LEN - 1 and a > previ

Re: [PATCH 04/25] net: at91_emac: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-28 Thread Ramon Fried
On Mon, Sep 27, 2021 at 2:22 PM Vladimir Oltean wrote: > > strncpy() simply bails out when copying a source string whose size > exceeds the destination string size, potentially leaving the destination > string unterminated. > > One possible way to address is to pass MDIO_NAME_LEN - 1 and a > previ

Re: [PATCH 03/25] net: armada100_fec: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-28 Thread Ramon Fried
On Mon, Sep 27, 2021 at 2:22 PM Vladimir Oltean wrote: > > strncpy() simply bails out when copying a source string whose size > exceeds the destination string size, potentially leaving the destination > string unterminated. > > One possible way to address is to pass MDIO_NAME_LEN - 1 and a > previ

Re: Please pull u-boot-i2c/next

2021-09-28 Thread Patrice CHOTARD
Hi Tom On 9/28/21 2:20 PM, Tom Rini wrote: > On Tue, Sep 28, 2021 at 09:26:43AM +0200, Heiko Schocher wrote: >> Hello Patrice, >> >> On 28.09.21 09:05, Patrice CHOTARD wrote: >>> Hi Heiko, Tom >>> >>> Is this PR can be merged into v2021.10 ? >>> The patch "mtd: nand: raw: convert nand_dt_init() to

Re: [PATCH 2/2] net: tsec: read the phy-mode property as fallback to phy-connection-type

2021-09-28 Thread Ramon Fried
On Sun, Sep 19, 2021 at 10:32 AM Bin Meng wrote: > > On Sat, Sep 18, 2021 at 8:47 PM Vladimir Oltean > wrote: > > > > The two should be equivalent, but at the moment some platforms > > (ls1021a-tsn.dts) use phy-mode only, which is not parsed. > > > > Signed-off-by: Vladimir Oltean > > --- > >

Re: [PATCH 1/2] net: tsec: only call tsec_get_interface as fallback to DT-specified PHY mode

2021-09-28 Thread Ramon Fried
On Sun, Sep 19, 2021 at 10:32 AM Bin Meng wrote: > > On Sat, Sep 18, 2021 at 8:47 PM Vladimir Oltean > wrote: > > > > Currently the init_phy function may overwrite the priv->interface > > property, since it calls tsec_get_interface which tries to determine it > > dynamically based on default reg

Re: [PATCH 4/4] net: dsa: felix: remove "xgmii" phy-mode

2021-09-28 Thread Ramon Fried
On Sat, Sep 18, 2021 at 3:34 PM Vladimir Oltean wrote: > > The felix driver runs only on NXP LS1028A, which most definitely does > not support the parallel 10G interface, just USXGMII, and that only up > to 2.5Gbps (toned down from 10 Gbps via symbol replication). > > Signed-off-by: Vladimir Oltea

Re: [PATCH 3/4] net: enetc: remove support for "xgmii" phy-mode

2021-09-28 Thread Ramon Fried
On Sat, Sep 18, 2021 at 3:34 PM Vladimir Oltean wrote: > > The enetc driver runs only on NXP LS1028A, which most definitely does > not support the parallel 10G interface, just USXGMII, and that only up > to 2.5Gbps (toned down from 10 Gbps via symbol replication). > > Signed-off-by: Vladimir Oltea

Re: [PATCH 2/4] net: freescale: replace usage of phy-mode = "sgmii-2500" with "2500base-x"

2021-09-28 Thread Ramon Fried
On Sat, Sep 18, 2021 at 3:34 PM Vladimir Oltean wrote: > > After the discussion here: > https://lore.kernel.org/netdev/20210603143453.if7hgifupx5k433b@pali/ > > which resulted in this patch: > https://patchwork.kernel.org/project/netdevbpf/patch/20210704134325.24842-1-p...@kernel.org/ > > and many

Re: [PATCH 1/4] net: replace the "xfi" phy-mode with "10gbase-r"

2021-09-28 Thread Ramon Fried
On Sat, Sep 18, 2021 at 3:34 PM Vladimir Oltean wrote: > > As part of the effort of making U-Boot work with the same device tree as > Linux, there is an issue with the "xfi" phy-mode. To be precise, in > Linux there was a discussion (for those who have time to read: > https://lore.kernel.org/netde

Re: [PATCH] net: phy: genphy_init can be static

2021-09-28 Thread Ramon Fried
On Sat, Sep 18, 2021 at 3:09 PM Bin Meng wrote: > > On Sat, Sep 18, 2021 at 7:55 PM Vladimir Oltean > wrote: > > > > To avoid a warning with W=1 about this function not having a previous > > prototype, declare it as static, because it is not used outside of this > > translation module. > > > > S

Re: [PATCH 2/2] net: dsa: remove unused variables

2021-09-28 Thread Ramon Fried
On Sat, Sep 18, 2021 at 2:50 PM Vladimir Oltean wrote: > > "dev" and "dsa_pdata" are unused inside dsa_port_of_to_pdata. > > "dsa_priv" is unused inside dsa_port_probe. > > Signed-off-by: Vladimir Oltean > --- > net/dsa-uclass.c | 14 +- > 1 file changed, 1 insertion(+), 13 deletions

Re: [PATCH 1/2] net: dsa: pass CPU port fixed PHY to .port_disable

2021-09-28 Thread Ramon Fried
On Sat, Sep 18, 2021 at 2:50 PM Vladimir Oltean wrote: > > While adding the logic for DSA to register a fixed-link PHY for the CPU > port, I forgot to pass it to the .port_disable method too, just > .port_enable. > > Bug had no impact for felix_switch.c, due to the phy argument not being > used, b

Re: [PATCH 24/25] arch: powerpc: mpc85xx: free MDIO bus if mdio_register fails

2021-09-28 Thread Ramon Fried
On Mon, Sep 27, 2021 at 2:22 PM Vladimir Oltean wrote: > > If mdio_register fails, it is nice to not leave behind dangling > allocated memory. > > Signed-off-by: Vladimir Oltean > --- > arch/powerpc/cpu/mpc85xx/ether_fcc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH 8/9] configs: ls1021a-tsn: enable sja1105 switch driver

2021-09-28 Thread Ramon Fried
On Tue, Sep 28, 2021 at 2:48 AM Vladimir Oltean wrote: > > The sja1105 is a 5-port switch that uses a DM_DSA driver. Its 5th (CPU) > port is connected internally to the eth2 port of the LS1021A SoC. > > Signed-off-by: Vladimir Oltean > --- > configs/ls1021atsn_qspi_defconfig | 2 ++ > configs/

Re: [PATCH 9/9] configs: ls1021a-tsn: enable the generation of random Ethernet MAC addresses

2021-09-28 Thread Ramon Fried
On Tue, Sep 28, 2021 at 2:48 AM Vladimir Oltean wrote: > > Don't fail when booting a board with an empty EEPROM for MAC addresses. > > Signed-off-by: Vladimir Oltean > --- > configs/ls1021atsn_qspi_defconfig | 1 + > configs/ls1021atsn_sdcard_defconfig | 1 + > 2 files changed, 2 insertions(+)

Re: [PATCH 7/9] arm: dts: ls1021a-tsn: add sja1105 and eth2 bindings

2021-09-28 Thread Ramon Fried
On Tue, Sep 28, 2021 at 2:48 AM Vladimir Oltean wrote: > > The eth aliases are for correct probing order, so that each Ethernet > port will get a predictable MAC address from the environment. > > Signed-off-by: Vladimir Oltean > --- > arch/arm/dts/ls1021a-tsn.dts | 103 ++

Re: [PATCH 2/9] include: import if_vlan.h from Linux

2021-09-28 Thread Ramon Fried
On Tue, Sep 28, 2021 at 2:48 AM Vladimir Oltean wrote: > > This is needed for the VLAN header structure. > > Signed-off-by: Vladimir Oltean > --- > include/linux/if_vlan.h | 26 ++ > 1 file changed, 26 insertions(+) > create mode 100644 include/linux/if_vlan.h > > diff -

Re: [PATCH 02/25] board: gdsys: a38x: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-28 Thread Ramon Fried
On Mon, Sep 27, 2021 at 2:22 PM Vladimir Oltean wrote: > > strncpy() simply bails out when copying a source string whose size > exceeds the destination string size, potentially leaving the destination > string unterminated. > > One possible way to address is to pass MDIO_NAME_LEN - 1 and a > previ

Re: [PATCH 01/25] arch: powerpc: mpc85xx: ensure mdiodev->name is NULL terminated after MDIO_NAME_LEN truncation

2021-09-28 Thread Ramon Fried
On Mon, Sep 27, 2021 at 2:22 PM Vladimir Oltean wrote: > > strncpy() simply bails out when copying a source string whose size > exceeds the destination string size, potentially leaving the destination > string unterminated. > > One possible way to address is to pass MDIO_NAME_LEN - 1 and a > previ

Re: imx6 DM_VIDEObroken

2021-09-28 Thread Anatolij Gustschin
Hey Tim, On Mon, 27 Sep 2021 17:25:58 -0700 Tim Harvey thar...@gateworks.com wrote: > Anatolij, > > Since commit d37618d18d49 ("imx: convert gwventana board to DM_VIDEO") > video support for IMX6 based Ventana boards has been broken. Back then I've tested similar DM_VIDEO conversion changes on

Re: Please pull u-boot-i2c/next

2021-09-28 Thread Heiko Schocher
Hi Tom, On 28.09.21 14:20, Tom Rini wrote: > On Tue, Sep 28, 2021 at 09:26:43AM +0200, Heiko Schocher wrote: >> Hello Patrice, >> >> On 28.09.21 09:05, Patrice CHOTARD wrote: >>> Hi Heiko, Tom >>> >>> Is this PR can be merged into v2021.10 ? >>> The patch "mtd: nand: raw: convert nand_dt_init() to

Re: [PATCH] imx: imx7d-sdb: fix ethernet, sync .dts with linux

2021-09-28 Thread Tom Rini
On Tue, Sep 28, 2021 at 12:18:10PM +0200, Rasmus Villemoes wrote: > On 16/09/2021 18.52, Fabio Estevam wrote: > > Hi Rasmus, > > > > On Thu, Sep 16, 2021 at 11:53 AM Rasmus Villemoes > > wrote: > >> > >> Commit 0d52bab46 (mx7dsabre: Enable DM_ETH) changed these flags from 0 > >> (aka GPIO_ACTIVE

Re: [PATCH] fastboot: fix partition name truncation in environment lookup

2021-09-28 Thread Matthias Schiffer
On Fri, 2021-07-30 at 10:04 -0400, Sean Anderson wrote: > On 7/30/21 8:23 AM, Matthias Schiffer wrote: > > strlcat() need to be passed the full buffer length. The incorrect call > > caused truncation of partition names for fastboot_raw_partition_... and > > fastboot_partition_alias_... env lookup t

Re: Please pull u-boot-i2c/next

2021-09-28 Thread Tom Rini
On Tue, Sep 28, 2021 at 09:26:43AM +0200, Heiko Schocher wrote: > Hello Patrice, > > On 28.09.21 09:05, Patrice CHOTARD wrote: > > Hi Heiko, Tom > > > > Is this PR can be merged into v2021.10 ? > > The patch "mtd: nand: raw: convert nand_dt_init() to ofnode_xx() interface" > > is fixing > > an

  1   2   >