Re: [PATCH v7 0/4] Move qfw to DM, add Arm support

Hi Asherah, On Fri, Mar 19, 2021 at 2:05 PM Asherah Connor wrote: > > On 21/03/19 12:03:p, Bin Meng wrote: > > When applying this series, there are warnings: > > > > $ git am 1.patch > > Applying: x86: qemu: move QFW to its own uclass > > .git/rebase-apply/patch:438: new blank line at EOF. > > +

Re: [PATCH v7 0/4] Move qfw to DM, add Arm support

On 21/03/19 12:03:p, Bin Meng wrote: > When applying this series, there are warnings: > > $ git am 1.patch > Applying: x86: qemu: move QFW to its own uclass > .git/rebase-apply/patch:438: new blank line at EOF. > + > warning: 1 line adds whitespace errors. > Applying: test: qemu: add qfw sandbox d

Re: [PATCH v7 4/4] qemu: arm: select QFW, MMIO on qemu-arm

On Fri, Mar 19, 2021 at 11:14 AM Asherah Connor wrote: > > Select CMD_QFW and QFW_MMIO in the qemu-arm board (covers arm and > arm64). > > Signed-off-by: Asherah Connor > Reviewed-by: Simon Glass > > --- > > (no changes since v5) > > Changes in v5: > * Split adding MMIO driver to QEMU arm/64 int

Re: [PATCH v7 3/4] qemu: add MMIO driver for QFW

On Fri, Mar 19, 2021 at 11:14 AM Asherah Connor wrote: > > Add MMIO driver for QFW. > > Note that there is no consumer as of this patch. > > Signed-off-by: Asherah Connor > Reviewed-by: Simon Glass > --- > > (no changes since v5) > > Changes in v5: > * Split MMIO driver into its own commit. > *

Re: [PATCH v7 2/4] test: qemu: add qfw sandbox driver, dm tests, qemu tests

On Fri, Mar 19, 2021 at 11:14 AM Asherah Connor wrote: > > A sandbox driver and test are added for the qfw uclass, and a test in > QEMU added for qfw functionality to confirm it doesn't break in real > world use. > > Signed-off-by: Asherah Connor > Reviewed-by: Simon Glass > > --- > > Changes in

Re: [PATCH v7 1/4] x86: qemu: move QFW to its own uclass

On Fri, Mar 19, 2021 at 11:14 AM Asherah Connor wrote: > > We move qfw into its own uclass and split the PIO functions into a > specific driver for that uclass. The PIO driver is selected in the > qemu-x86 board config (this covers x86 and x86_64). > > include/qfw.h is cleaned up and documentatio

Re: [PATCH v7 0/4] Move qfw to DM, add Arm support

Hi Asherah, On Fri, Mar 19, 2021 at 11:14 AM Asherah Connor wrote: > > This series moves the QFW driver into a uclass, UCLASS_QFW, and splits > the driver into qfw_pio and qfw_mmio. Each driver is selected on the > appropriate QEMU board. A sandbox driver is also added, and a DM unit > test aga

[PATCH v7 4/4] qemu: arm: select QFW, MMIO on qemu-arm

Select CMD_QFW and QFW_MMIO in the qemu-arm board (covers arm and arm64). Signed-off-by: Asherah Connor Reviewed-by: Simon Glass --- (no changes since v5) Changes in v5: * Split adding MMIO driver to QEMU arm/64 into own commit. * Use the generic qemu-arm board config rather than adding to mu

[PATCH v7 3/4] qemu: add MMIO driver for QFW

Add MMIO driver for QFW. Note that there is no consumer as of this patch. Signed-off-by: Asherah Connor Reviewed-by: Simon Glass --- (no changes since v5) Changes in v5: * Split MMIO driver into its own commit. * Add CONFIG_QFW_MMIO for selection by arch/board. drivers/misc/Kconfig| 7

[PATCH v7 2/4] test: qemu: add qfw sandbox driver, dm tests, qemu tests

A sandbox driver and test are added for the qfw uclass, and a test in QEMU added for qfw functionality to confirm it doesn't break in real world use. Signed-off-by: Asherah Connor Reviewed-by: Simon Glass --- Changes in v7: * Make the qfw tests agnostic to running against a real QEMU instance

[PATCH v7 1/4] x86: qemu: move QFW to its own uclass

We move qfw into its own uclass and split the PIO functions into a specific driver for that uclass. The PIO driver is selected in the qemu-x86 board config (this covers x86 and x86_64). include/qfw.h is cleaned up and documentation added. Signed-off-by: Asherah Connor Reviewed-by: Simon Glass

[PATCH v7 0/4] Move qfw to DM, add Arm support

This series moves the QFW driver into a uclass, UCLASS_QFW, and splits the driver into qfw_pio and qfw_mmio. Each driver is selected on the appropriate QEMU board. A sandbox driver is also added, and a DM unit test against that driver. The qfw command is tested in QEMU, and documentation added.

Re: Ficus EE not working / supported ?

Hi Eze, On Tue, Mar 16, 2021 at 09:44:02AM -0300, Ezequiel Garcia wrote: > Hi Mani, Kever, > > I tried to bringup (again) my Ficus board, but I've been unable to > boot a kernel. > > Seems my old u-boot branch doesn't want to boot, and the only U-Boot I managed > to boot is some recent one (whic

Re: [PATCH v6 2/4] test: qemu: add qfw sandbox driver, dm tests, qemu tests

On 21/03/14 04:03:p, Tom Rini wrote: > A small thing, CMD_QFW needs to be disabled on sandbox_spl_defconfig (a > special config for some tests only). A larger thing is that these tests > fail for me both locally and in CI: > https://source.denx.de/u-boot/u-boot/-/jobs/237539 > https://source.denx.

Re: [PATCH] Avoid delay when initializing USB peripheral by dwc2

On 3/17/21 4:52 PM, João Loureiro wrote: When `usb start` is called on the terminal, the dwc2 driver will try to start every USB device as host first, even if it is explicitly configured as peripheral in the device tree (dr_mode = "peripheral"). So to avoid an unwanted 15 seconds delay when init

Re: [PATCH] video: Drop unprintable characters from video_font_data.h

Hi Anatolij, On Tue, 23 Feb 2021 at 08:22, Anatolij Gustschin wrote: > > On Wed, 16 Dec 2020 20:51:53 -0700 > Simon Glass s...@chromium.org wrote: > > > This file contains characters which are not valid in utf-8. This confuses > > dtoc which wants to parse it. They don't really serve any purpose

OMAP3 clocks with ARM vs Thumb

The arch/arm/mach-omap2/omap3/clock.c is being forced to compile with an ARM target even when thumb2 is the preferred target. The note in the makefile states it's due to a bootup issue with OMAP35. Since Thumb2 can help reduce code size, I thought I'd run some tests. The DM3730 can boot with clo

[PATCH 2/2] binman: Allow disabling expanding an entry

At present there is a command-line flag to disable substitution of expanded entries. Add an optino to the entry node as well, so it can be controlled at the node level. Add a test to cover this. Signed-off-by: Simon Glass --- tools/binman/binman.rst | 7 +++ tools/binman/

[PATCH 1/2] binman: Use a unique number for the symbols test file

Two test devicetree files currently have 192 as their unique number. Fix this by separating them out. Signed-off-by: Simon Glass --- tools/binman/ftest.py | 2 +- .../test/{192_symbols_nodtb.dts => 196_symbols_nodtb.dts} | 0 2 files changed, 1 in

[PATCH] dfu: dfu_sf: avoid double free of SPI device

Multiple DFU entities may share the same SPI device. We must make sure that the SPI device is only freed once. When using the driver model it is not necessary to free the SPI device. Signed-off-by: Heinrich Schuchardt --- drivers/dfu/dfu_sf.c | 18 +- 1 file changed, 17 insertio

Re: [PATCH] Fix data abort in startup for at91 machines based on ARM926EJS

Hello Martin, I reviewed things a bit, and, as it looks to me, and according to AAPCS, we can still use r4, as this is scratch space, but we need to save it and restore it before and after the code of lowlevel_init. Because r6 is also scratch, with your patch , we lose the data in r6, in case s

Re: [PATCH] Fix data abort in startup for at91 machines based on ARM926EJS

Hi Eugen, Pop and push gets my vote as it future proofs the code from usage of r6 in lowlevel_init. Let me know if you want me to respin the patch with this and test it out on my board here. Kind regards Martin Martin Townsend | Embedded Software Engineer mar...@rufilla.com

Re: [PATCH 1/2] of: addr: Abort address translation for parent nodes missing 'ranges'

On Thu, Mar 18, 2021 at 08:27:49AM +0100, Dario Binacchi wrote: > Hi Bin, > > > Il 17/03/2021 02:26 Bin Meng ha scritto: > > > > > > Hi Dario, > > > > On Wed, Mar 17, 2021 at 4:57 AM Dario Binacchi wrote: > > > > > > Hi Bin, > > > > > > > Il 16/03/2021 02:28 Bin Meng ha scritto: > > > > > >

Re: Ficus EE not working / supported ?

Hi Mani, Have you had any chance to look at this? Thanks! Ezequiel On Tue, 16 Mar 2021 at 09:44, Ezequiel Garcia wrote: > > Hi Mani, Kever, > > I tried to bringup (again) my Ficus board, but I've been unable to > boot a kernel. > > Seems my old u-boot branch doesn't want to boot, and the only U

Re: [PATCH resend] mmc: mtk-sd: don't ignore max-frequency from device tree

On Mon, Mar 15, 2021 at 03:31:11PM +, Daniel Golle wrote: > commit e58e68d9 ("mmc: mtk-sd: assign plat->cfg.f_max with a correct value") > wrongly assumed that plat->cfg.f_max is always unset at the time > mscd_drv_probe() is run. This is not true in case max-frequency being > defined in devic

Re: [PATCH] avb: Fix error when partition not found

On Fri, Feb 26, 2021 at 12:19:10AM +0800, schspa wrote: > part_get_info_by_name will return -1 on error, and >0 on success. > > Signed-off-by: schspa > Cc: Igor Opaniuk > Reviewed-by: Igor Opaniuk Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] image: Avoid -ENODATA in host tools

On Wed, Feb 24, 2021 at 08:50:32AM -0500, Simon Glass wrote: > Unfortunately -ENODATA is not available in OpenBSD. Use -EBADMSG > instead, to indicate a missing timestamp. > > Fixes: c5819701a3d image: Adjust the workings of fit_check_format() > Signed-off-by: Simon Glass > Reviewed-by: Mark Ket

Re: [PATCH v2 1/4] test: Include /sbin to the PATH when creating ext4 disk image

On Thu, Feb 11, 2021 at 04:40:09PM +0200, Andy Shevchenko wrote: > On some distributions the mkfs.ext4 is under /sbin and /sbin is not set > for mere users. Include /sbin to the PATH when creating ext4 disk image, > so that users won't get a scary traceback from Python. > > Cc: Patrick Delaunay

[PATCH V2 2/3] arm: omap3: Make secureworld_exit() static

secureworld_exit() is only used in one file, so make it static to that file and remove it from sys_proto.h. This may help with some further optimization in the future. Signed-off-by: Adam Ford --- arch/arm/include/asm/arch-omap3/sys_proto.h | 1 - arch/arm/mach-omap2/omap3/board.c | 2

[PATCH V2 0/3] arm: omap3: Make functions static when possible

A few functions are defined without being labeled as static to that file. In an effort to keep SPL as small as possible, one function needs to be moved into an #ifdef so it's only enabled when the calling function is available, and all of these can simply be marked as static. Before: textd

[PATCH V2 1/3] arm: omap3: Make try_unlock_memory() static

try_unlock_memory() is only used in one file, so make it static in that file,remove it from the sys_proto header file, and relocate it into the #ifdef section that call it. This will make it only built under the conditions when it is called, and it may help with some further optimization in the fut

[PATCH V2 3/3] arm: omap3: Make secure_unlock_mem() static

secure_unlock_mem() is only used in one file, so make it static in that file. This may help with some further optimization in the future. Signed-off-by: Adam Ford --- arch/arm/mach-omap2/omap3/board.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/omap3/b

Re: [PATCH] dfu: memory leak in dfu_free_entities()

On 18.03.21 12:18, Heinrich Schuchardt wrote: > We must free all entries that we remove from the list not just one to avoid > a memory leak. > > With list_for_each_entry_safe_reverse() it is safe to delete the current > entry as it provides a second pointer for the next entry. I got that wrong: d

[PATCH] dfu: memory leak in dfu_free_entities()

We must free all entries that we remove from the list not just one to avoid a memory leak. With list_for_each_entry_safe_reverse() it is safe to delete the current entry as it provides a second pointer for the next entry. Signed-off-by: Heinrich Schuchardt --- drivers/dfu/dfu.c | 4 +--- 1 file

Re: [PATCH 1/2] sunxi: support asymmetric dual rank DRAM on A64/R40

On Thu, Feb 25, 2021 at 4:14 PM Icenowy Zheng wrote: > > Previously we have known that R40 has a configuration register for its > rank 1, which allows different configuration than rank 0. Reverse > engineering of newest libdram of A64 from Allwinner shows that A64 has > this register too. It's bit

Re: [PATCH v3 21/27] doc: Move UEFI under develop/

On 18.03.21 08:25, Simon Glass wrote: > Much of the content here is useful only for development. Move it under > that section. > > Signed-off-by: Simon Glass The patch cannot be applied independently of patch 20/27. Reviewed-by: Heinrich Schuchardt > --- > > Changes in v3: > - Fix x86 docs whi

Re: [PATCH 1/2] of: addr: Abort address translation for parent nodes missing 'ranges'

Hi Bin, > Il 17/03/2021 02:26 Bin Meng ha scritto: > > > Hi Dario, > > On Wed, Mar 17, 2021 at 4:57 AM Dario Binacchi wrote: > > > > Hi Bin, > > > > > Il 16/03/2021 02:28 Bin Meng ha scritto: > > > > > > > > > Hi Dario, > > > > > > On Tue, Mar 16, 2021 at 6:49 AM Dario Binacchi wrote: > >

[PATCH v3 27/27] binman: Update various pieces of the documentation

A few sections are a little out of date now. Update them. Signed-off-by: Simon Glass --- Changes in v3: - Make a symlink to the entry docs doc/develop/package/entries.rst | 1 + tools/binman/binman.rst | 83 + 2 files changed, 45 insertions(+), 39 delet

[PATCH v3 26/27] binman: Drop repetitive heading for each entry

Many entries start 'Entry containing a'. This looks fine in the source code but is annoying when viewed in the htmldocs table of contents. Drop these unnecessary words. Signed-off-by: Simon Glass --- Changes in v3: - Update entry docs tools/binman/entries.rst| 76 ++

[PATCH v3 25/27] binman: Incorporate entry documentation

Update this to avoid sphinx warnings and incorporate it into the new documentaiton tree. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/cmdline.py | 2 +- tools/binman/{README.entries => entries.rst} | 79 +++- tools/binman/etype/cbfs.py

[PATCH v3 24/27] binman: Rearrange documentation into headings

Collect the material into different top-level headings to make it easier to read. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/binman.rst | 523 1 file changed, 266 insertions(+), 257 deletions(-) diff --git a/tools/binman/binman.r

[PATCH v3 23/27] binman: doc: Add documentation to htmldocs

Add a link to binman's documentation and adjust the files so that it is accessible. Use the name README.rst so it is easy to discover when binman is installed without U-Boot. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Put binman docs in doc/develop and FIT in doc/usag

[PATCH v3 22/27] doc: Move driver model docs under develop/

These docs are useful for developers, not users. Move them under that section. Suggested-by: Heinrich Schuchardt Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Add new patch to move driver model docs under develop/ doc/{ => develop}/driver-model/bind.rst

[PATCH v3 21/27] doc: Move UEFI under develop/

Much of the content here is useful only for development. Move it under that section. Signed-off-by: Simon Glass --- Changes in v3: - Fix x86 docs which refer to this Changes in v2: - Move UEFI under develop/ instead doc/arch/x86.rst | 4 ++-- doc/develop/index.rst

[PATCH v3 20/27] x86: dts: Drop unused CONFIG_SPL

This cannot be used since the previous #elif has already dealt with SPL. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/dts/u-boot.dtsi | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/arch/x86/dts/u-boot.dtsi b/arch/x86/dts/u-boot.dtsi index 501

[PATCH v3 19/27] x86: Make use of binman expanded entries

We don't need to spell out the separate pieces of U-Boot phase binaries anymore. Revert to using the simple entry and let binman do the expansion itself as needed. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/dts/u-boot.dtsi | 11 +-- 1 file changed, 1 insertion(+), 10

[PATCH v3 17/27] binman: Automatically expand phase binaries into sections

When creating an entry, check for an expanded version of that entry, then use it instead. This allows, for example use of: u-boot { }; instead of having to write out in full: u-boot { type = "section"; u-boot-nodtb { }; u-boot-dtb { }; }; Add an imple

[PATCH v3 18/27] Makefile: Pass new entry args to binman

To support the use of 'expanded' entries, binman needs to be told whether SPL and TPL have a devicetree and whether they need BSS padding. Add these to the Makefile. Signed-off-by: Simon Glass --- (no changes since v1) Makefile | 8 1 file changed, 8 insertions(+) diff --git a/Makefi

[PATCH v3 16/27] binman: Plumb expanded entries through fully

Add support for this feature in the control, image and section modules, so that expanded entries will be selected by default. So far there are no expanded entry types, so this is a nop. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/control.py | 24 ++--

[PATCH v3 15/27] binman: Allow a way to select expanded entries

Add a new command-line option to disable expanded entries. This is needed for most tests, since it is much easier to 'factor out' this function into a separate test and keep the existing packing tests simple. Add the option and select it by default from tests. Signed-off-by: Simon Glass --- (no

[PATCH v3 14/27] binman: Allow using an an 'expanded' entry type

As the first step in supporting expanded entries, add a way for binman to automatically select an 'expanded' version of an entry type, if requested. This is controlled by a class method. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/entry.py | 60 ++

[PATCH v3 13/27] binman: Use standard filenames for SPL/TPL devicetree

At present, before any entry expansion is done (such as a 'files' entry expanding out to individual entries for each file it contains), we check the binman definition (i.e. '/binman' node) to find out what devicetree files are used in the images. This is a pain, since the definition may change dur

[PATCH v3 12/27] binman: Move the comment for GetFdts() to the base class

Like with other methods this comment should be in the base class. Move it. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch to move the comment for GetFdts() to the base class tools/binman/entry.py | 2 +- tools/binman/etype/blob_dtb.py | 9 - 2 files changed, 1 i

[PATCH v3 11/27] binman: Drop unnecessary field in output_fdt_info

At present we store an entry as the third field in output_fdt_info[]. This is only used to get the type of the entry. Of course multiple entries may have this same type. Also the entry type is the key to this dict, so we can use that instead. Drop the field and update GetUpdateNodes() to suit. Imp

[PATCH v3 10/27] binman: Use the fake SPL/TPL only if requested

At present we always use the main devicetree for SPL/TPL as well when setting up the state. But this it not needed if there is a real devicetree for SPL or TPL. In fact it confuses things since we cannot distinguish between one being provided and using the fake one. Update the code to create the f

[PATCH v3 09/27] binman: Drop unnecessary 'type' property in tests

A few tests declare a type when this can be inferred from the node name. Drop these lines, since it might cause confusion. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch to drop unnecessary 'type' property in tests tools/binman/test/149_symbols_tpl.dts | 1 - tools/binman/te

[PATCH v3 08/27] binman: Add support for u-boot-tpl-bss-bad

This entry holds the padding between the end of of TPL binary and the end of BSS. This region must be left empty so that the devicetree can be appended correctly and remain accessible without interfering with BSS. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/README.entries

[PATCH v3 07/27] binman: Add support for u-boot-tpl-nodtb

Allow this entry type to be placed in an image. This is the TPL binary, without a devicetree appended. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/README.entries| 23 tools/binman/etype/u_boot_tpl_nodtb.py | 41 ++ tool

[PATCH v3 06/27] binman: Support symbols in u-boot-spl-nodtb

Since this is an execuable we should be able insert symbol values into it. Add support for this. Use common code for this test and the original testSymbols. Use hex consistently for the values and add some more comments. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch to support s

[PATCH v3 05/27] binman: Correct the documentation for u-boot-spl-bss-pad

The documentation for this entry indicates that the SPL binary is included along with the padding. It is not, so update it to correct the error. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/README.entries | 17 ++--- tools/binman/etype/u_boot_spl_b

[PATCH v3 04/27] binman: Tidy up underscores in entry documentation

Several entries currently use an underscore in the entry-type name, but in fact a hyphen is used. Update the docs to fix this as it might be confusing. Also simplify the 'filename' comment and fix the 'operation' typo. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/README.e

[PATCH v3 03/27] binman: Update entry help for files-align

Regenerate the entry documentation, which step was missed when the files-align feature was added. Fixes: 6eb9932668f ("binman: Support alignment of files") Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/README.entries | 1 + 1 file changed, 1 insertion(+) diff --git a/tool

[PATCH v3 02/27] binman: Document ExpandEntries() in the base class

Move the documentation to the base method as it is with other methods. Also update it a little while we are here. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/entry.py | 11 +++ tools/binman/etype/section.py | 6 -- 2 files changed, 11 insertions(+), 6

[PATCH v3 01/27] binman: Allow extracting to current directory

Extracting files to the current directory is not normally a very friendly thing to do, but it can be warranted, e.g. in a new temporary dir. At present binman reports an error when such an attempt is made. Fix it. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/control.py | 2

[PATCH v3 00/27] binman: Support devicetree update in all entries

U-Boot's various phase binaries actually comprise two or three pieces. For example, u-boot.bin has the executable followed by a devicetree. With binman we want to be able to update that devicetree with full image information so that it is accessible to the executable. This is tricky if it is not c