RE: [PATCH 12/13] arm: socfpga: arria5_secu1: Disable ATAGs support

> > These platforms never had to support an ATAGs-based Linux Kernel, so > remove the options. > > Cc: Holger Brunck > Signed-off-by: Tom Rini > --- > I'm assuming, please correct me if I'm wrong. > --- you are right, this can be removed. Reviewed-By: Holger Brunck Best regards Holger

Re: [PATCH v2 00/37] dm: Implement OF_PLATDATA_INST in driver model (part E)

On 2/3/21 5:43 PM, Simon Glass wrote: This series builds on the recent dtoc implementation of build-time device instantiation. It adds the required driver model support, which is basically a few more data structures. With this, sandbox_spl and chromebook_coral both use the new feature. For cor

[PATCH v2 3/3] fs: fat: remove trailing periods from long name

The FAT32 File System Specification [1] requires leading and trailing spaces as well as trailing periods of long names to be ignored. [1] Microsoft Extensible Firmware Initiative FAT32 File System Specification Version 1.03, December 6, 2000 Microsoft Corporation https://www.wi

[PATCH v2 2/3] fs: fat: must not write directory '.' and '..'

Directories or files called '.' or '..' cannot be created or written to in any directory. Move the test to normalize_longname() to check this early. Signed-off-by: Heinrich Schuchardt --- v2: check for file length 0, simplify check for invalid file names --- fs/fat/fat_write.c | 13 +++--

[PATCH v2 1/3] fs: fat: usage basename in file_fat_write_at, fat_mkdir

This patch involves no functional change. It is just about code readability. Both in file_fat_write_at() and fat_mkdir() the incoming file or directory path are split into two parts: the parent directory and the base name. In file_fat_write_at() the value of the variable basename is assigned to t

[PATCH v2 0/3] fs: fat: avoid invalid filenames

The FAT32 File System Specification requires leading and trailing spaces as well as trailing periods of long names to be ignored. Up to now U-Boot could create files with invalid file names violating the restriction above. With the patches this is avoided. v2: Change the separation of du

Re: [PATCH v5 01/20] mmc: sdhci: Add helper functions for UHS modes

Hi Aswath, On 2/4/21 2:09 PM, Aswath Govindraju wrote: > Hi Jaehoon, > > On 04/02/21 4:23 am, Jaehoon Chung wrote: >> Hi Aswath, >> >> On 2/3/21 3:06 PM, Aswath Govindraju wrote: >>> Hi Jaehoon, >>> >>> On 02/02/21 3:40 am, Jaehoon Chung wrote: Hi Aswath, On 1/29/21 11:47 PM, Aswat

Re: [PATCH v5 01/20] mmc: sdhci: Add helper functions for UHS modes

Hi Jaehoon, On 04/02/21 4:23 am, Jaehoon Chung wrote: > Hi Aswath, > > On 2/3/21 3:06 PM, Aswath Govindraju wrote: >> Hi Jaehoon, >> >> On 02/02/21 3:40 am, Jaehoon Chung wrote: >>> Hi Aswath, >>> >>> On 1/29/21 11:47 PM, Aswath Govindraju wrote: From: Faiz Abbas Add a set_voltage

Re: [PATCH 07/14] spi: dw: Mask all possible interrupts

On 1/31/21 7:34 PM, Sean Anderson wrote: DWC_SPI has more than 8 interrupts. Write to the whole IMR to mask everything. Signed-off-by: Sean Anderson --- drivers/spi/designware_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/designware_spi.c b/drivers/sp

Please pull u-boot-dm

Hi Tom, https://gitlab.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/6206 The following changes since commit fdcb93e1709ab1a2ebb562455621617c29e2099c: Merge branch '2021-02-01-assorted-fixes' (2021-02-02 09:24:10 -0500) are available in the Git repository at: git://git.denx.de/u-boot-dm

[PATCH 2/2] dm: core: Add DM_DEVICE_REMOVE condition to all exit paths

At present device_bind() does some unnecessary work if a device fails to bind in SPL. Add the missing conditions. Also fix a style nit in the same function while we are here. Signed-off-by: Simon Glass --- drivers/core/device.c | 19 +++ 1 file changed, 11 insertions(+), 8 dele

[PATCH 1/2] dm: core: Fix allocation of empty of-platdata

With of-platdata we always have a dtv struct that holds the platform data provided by the driver_info record. However, this struct can be empty if there are no actual devicetree properties provided. The upshot of empty platform data is that it will end up as a zero-size member in the BSS section,

Re: [PATCH 02/13] arm: imx: Remove unused CONFIG_xxx_TAG support

On Thu, Feb 04, 2021 at 12:02:52AM -0300, Fabio Estevam wrote: > Hi Tom, > > On Wed, Feb 3, 2021 at 11:24 PM Tom Rini wrote: > > > > The i.MX8 family has never possibly supported ATAGs so we can remove > > Yes, we don't need ATAGs for the i.MX family as we use devicetree for > all i.MX members.

Re: [PATCH 1/1] cmd/riscv/sbi: support System Reset Extension

On Mon, Jan 18, 2021 at 5:27 AM Heinrich Schuchardt wrote: > > Let the sbi command detect the 'System Reset Extension' > (EID #0x53525354 "SRST"). > > Cf. https://github.com/riscv/riscv-sbi-doc > > Signed-off-by: Heinrich Schuchardt > --- > cmd/riscv/sbi.c | 1 + > 1 file changed, 1 insertion(+)

Re: [PATCH 02/13] arm: imx: Remove unused CONFIG_xxx_TAG support

Hi Tom, On Wed, Feb 3, 2021 at 11:24 PM Tom Rini wrote: > > The i.MX8 family has never possibly supported ATAGs so we can remove Yes, we don't need ATAGs for the i.MX family as we use devicetree for all i.MX members. > CONFIG_SERIAL_TAG support from that family. Furthermore, the i.MX7 but rea

Re: [PATCH 14/14] riscv: k210: Enable QSPI for spi3

On Sun, Jan 31, 2021 at 07:34:36PM -0500, Sean Anderson wrote: > This device has four IOs connected to the SPI flash. Add the appropriate > bindings. > > Signed-off-by: Sean Anderson > --- > > arch/riscv/dts/k210-maix-bit.dts | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/risc

Re: [PATCH 1/1] cmd/riscv/sbi: support System Reset Extension

On Sun, Jan 17, 2021 at 09:27:13PM +, Heinrich Schuchardt wrote: > Let the sbi command detect the 'System Reset Extension' > (EID #0x53525354 "SRST"). > > Cf. https://github.com/riscv/riscv-sbi-doc > > Signed-off-by: Heinrich Schuchardt > --- > cmd/riscv/sbi.c | 1 + > 1 file changed, 1 ins

[PATCH 11/13] arm: s32v234: Disable ATAGs support

These platforms never had to support an ATAGs-based Linux Kernel, so remove the options. Cc: Eddy Petrișor Signed-off-by: Tom Rini --- I'm assuming, please correct me if I'm wrong. --- include/configs/s32v234evb.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/configs/s32v234evb.

[PATCH 13/13] arm: stm32: Disable ATAGs support

These platforms never had to support an ATAGs-based Linux Kernel, so remove the options. Cc: Kamil Lulko Cc: Patrick Delaunay Cc: Patrice Chotard Cc: Vikas Manocha Cc: Marek Vasut Signed-off-by: Tom Rini --- I'm assuming, please correct me if I'm wrong. --- include/configs/stm32f429-discove

[PATCH 09/13] arm: mvebu: Disable ATAGs support on some platforms

These platforms never had to support an ATAGs-based Linux Kernel, so remove the options. Cc: Stefan Roese Cc: Marek Behún Signed-off-by: Tom Rini --- I'm assuming, please correct me if I'm wrong. --- include/configs/mvebu_armada-37xx.h | 9 - include/configs/mvebu_armada-8k.h | 9 ---

[PATCH 10/13] arm: rcar2/3: Disable ATAGs support

These platforms never had to support an ATAGs-based Linux Kernel, so remove the options. Cc: Marek Vasut Signed-off-by: Tom Rini --- I'm assuming, please correct me if I'm wrong. --- include/configs/grpeach.h | 1 - include/configs/rcar-gen2-common.h | 4 include/configs/rcar-gen3

[PATCH 12/13] arm: socfpga: arria5_secu1: Disable ATAGs support

These platforms never had to support an ATAGs-based Linux Kernel, so remove the options. Cc: Holger Brunck Signed-off-by: Tom Rini --- I'm assuming, please correct me if I'm wrong. --- include/configs/socfpga_arria5_secu1.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/configs/socf

[PATCH 08/13] arm: mediatek: Disable ATAGs support

These platforms never had to support an ATAGs-based Linux Kernel, so remove the options. Cc: Ryder Lee Cc: Weijie Gao Signed-off-by: Tom Rini --- I'm assuming, please correct me if I'm wrong. --- include/configs/mt7623.h | 4 include/configs/mt7629.h | 4 2 files changed, 8 deletions

[PATCH 07/13] arm: aspeed: Disable ATAGs support

This platform never had to support an ATAGs-based Linux kernel, so remove the support for it. Cc: Ryan Chen Cc: Chia-Wei Wang Cc: Aspeed BMC SW team Signed-off-by: Tom Rini --- I'm assuming, please correct me if I'm wrong. --- include/configs/aspeed-common.h | 5 - 1 file changed, 5 delet

[PATCH 06/13] arm: goni: Disable CONFIG_REVISION_TAG

Rather than provide an empty revision tag here, remove the code to generate an empty one and disable the feature. Cc: Robert Baldyga Signed-off-by: Tom Rini --- I do not know if this platform ever had to support an ATAG-based Linux kernel and if not, there is more cleanup that could be done here

[PATCH 05/13] arm: puma_rk3399: Disable ATAGs support

This platform never supported an ATAGs-based Linux kernel, so remove. Cc: Philipp Tomsich Cc: Klaus Goger Signed-off-by: Tom Rini --- I'm assuming, please correct me if I'm wrong. --- .../theobroma-systems/puma_rk3399/puma-rk3399.c | 16 include/configs/puma_rk3399.h

[PATCH 04/13] bcmstb: Disable ATAGs support

This platform never supported ATAG-based Linux kernels, so disable. Cc: Thomas Fitzsimmons Signed-off-by: Tom Rini --- I am assuming, please correct me if wrong. --- board/broadcom/bcmstb/bcmstb.c | 5 - include/configs/bcmstb.h | 6 -- 2 files changed, 11 deletions(-) diff --git

[PATCH 03/13] arm: layerscape: Disable ATAG support on some platforms

The layerscape platforms are new enough to have never supported ATAGs, so disable that support. Cc: Alison Wang Cc: Feng Li Cc: Mingkai Hu Cc: Rajesh Bhagat Cc: Sumit Garg Signed-off-by: Tom Rini --- include/configs/ls1021aiot.h | 2 -- include/configs/ls1021aqds.h | 2 -- include/configs/l

[PATCH 02/13] arm: imx: Remove unused CONFIG_xxx_TAG support

The i.MX8 family has never possibly supported ATAGs so we can remove CONFIG_SERIAL_TAG support from that family. Furthermore, the i.MX7 family is new enough to have never supported ATAGs so remove and disable those options as well. Cc: Stefano Babic Cc: Fabio Estevam Cc: NXP i.MX U-Boot Team S

[PATCH 01/13] arm: nanopi2: Remove unused code

This platform did not ever enable CONFIG_REVISION_TAG, so the code to set the board_rev environment variable was never enabled. This particular symbol is also only for use with the REVISION ATAG and this platform is new enough to have never supported an ATAG-based Linux Kernel. Cc: Stefan Bosch

Re: [PATCH v5 7/9] dm: core: Add late driver remove option

From: Marek Vasut Add another flag to the DM core which could be assigned to drivers and which makes those drivers call their remove callbacks last, just before booting OS and after all the other drivers finished with their remove callbacks. This is necessary for things like clock drivers, where

Re: [PATCH v5 5/9] dm: core: Remove children before advising uclass

At present the uclass pre-remove method is called before the children are removed. But the children may refused to be removed, in whch case the uclass is in a tricky situation. At present we handle this by calling the uclass' post_probe() method. But it seems better to avoid doing anything with the

Re: [PATCH v5 8/9] arm: Remove vital devices last

Update announce_and_cleanup() to remove all devices, with the vital ones being removed last. This is an extra patch on top of the recent RFC: http://patchwork.ozlabs.org/project/uboot/list/?series=223280 Signed-off-by: Simon Glass --- Changes in v5: - Add patch to remove vital devices last

Re: [PATCH v2 01/10] riscv: Adjust board_get_usable_ram_top() for 32-bit

From: Bin Meng When testing QEMU RISC-V 'virt' machine with a 2 GiB memory configuration, it was discovered gd->ram_top is assigned to value zero in setup_dest_addr(). While gd->ram_top should not be declared as type `unsigned long`, which will be updated in a future patch, the current logic in

Re: [PATCH 1/1] firmware: smci: possible NULL dereference

On Sun, 31 Jan 2021 at 19:02, Heinrich Schuchardt wrote: > > sandbox_scmi_devices_ctx() may return NULL. We should not dereference this > value in sandbox_scmi_devices_remove(). > > The problem was indicated by 'gcc-11 -fanalyzer'. > > Signed-off-by: Heinrich Schuchardt > --- > drivers/firmware/

Re: [PATCH v2 03/10] global_data.h: Change ram_top type to phys_addr_t

From: Bin Meng It's possible to have ram_top above 4 GiB in a 32-bit system, hence we need to declare ram_top as `phys_addr_t`. Signed-off-by: Bin Meng Reviewed-by: Simon Glass --- (no changes since v1) include/asm-generic/global_data.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v2 06/10] net: ftmac100: Cast priv->iobase with uintptr_t

From: Bin Meng priv->iobase was declared as phys_addr_t which is now a 64-bit address. In a 32-bit build, this causes the following warning seen when building ftmac100.c: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] Cast priv->iobase with uintptr_t. Signed-

Re: [PATCH v5 2/9] nand: brcmnand: Don't use -EPROBE_DEFER

This has no useful meaning in U-Boot and will never be returned. We want to reserve this flag for internal driver model use. Drop the code. Signed-off-by: Simon Glass --- (no changes since v1) drivers/mtd/nand/raw/brcmnand/brcmnand.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-)

Re: [PATCH v5 1/9] smem: Don't use -EPROBE_DEFER

This has no useful meaning in U-Boot. Use -ENOMEM since that appears to be what has gone wrong in this case. We want to reserve this flag for internal driver model use. Signed-off-by: Simon Glass --- (no changes since v1) drivers/smem/msm_smem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 d

Re: [PATCH v5 4/9] dm: pci: Correct use of wrong flag name

Update a driver that uses the incorrect flag. Add a comment to hopefully prevent furture mistakes. Signed-off-by: Simon Glass --- (no changes since v1) drivers/pci/pcie_iproc.c | 2 +- include/dm/device.h | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) Applied to u-boot-dm, than

Re: [PATCH v5 3/9] dm: Rename DM_FLAG_REMOVE_WITH_PD_ON

This flag has the word 'REMOVE' in it which means it conflicts with the DM_REMOVE flags. Rename it to DM_FLAG_LEAVE_PD_ON which seems to indicate its purpose well enough. Signed-off-by: Simon Glass --- (no changes since v1) drivers/core/device-remove.c| 2 +- drivers/video/meson/meson_vpu.

Re: [PATCH v5 6/9] dm: core: Avoid partially removing devices

At present if device_remove() decides that the device should not actually be removed, it still calls the uclass pre_remove() method and powers the device down. Signed-off-by: Simon Glass --- (no changes since v1) drivers/core/device-remove.c | 59 include/d

Re: [PATCH v5 9/9] dm: core: Add documentation about device removal

Make mention of this feature in the core documentation so people can discover it without looking at a header file. Signed-off-by: Simon Glass --- (no changes since v4) Changes in v4: - Revised and updated based on discussion doc/driver-model/design.rst | 20 1 file change

Re: [PATCH v2 02/10] arm: rockchip: Explicitly cast gd->ram_top in dram_init_banksize()

From: Bin Meng The min() macro used in dram_init_banksize() requires two elements to compare have the same type. Let's explicitly cast gd->ram_top. Signed-off-by: Bin Meng --- Changes in v2: - new patch: arm: rockchip: Explicitly cast gd->ram_top in dram_init_banksize() arch/arm/mach-rockchi

Re: [PATCH v2 04/10] serial: sifive: Cast dev_read_addr() with uintptr_t

From: Bin Meng dev_read_addr() returns fdt_addr_t which is now a 64-bit address. In a 32-bit build, this causes the following warning seen when building serial_sifive.c: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] Cast the return value with uintptr_t. Sign

Re: [PATCH v2 07/10] fdtdec: Cast prior_stage_fdt_address with uintptr_t

From: Bin Meng At present prior_stage_fdt_address is declared as phys_addr_t. On a 32-bit platform where phys_addr_t can be 64-bit, assigning its value to gd->fdt_blob which is a pointer, can cause warnings. Cast it to uintptr_t before the assignment. Signed-off-by: Bin Meng Reviewed-by: Simon

Re: [PATCH v2 05/10] riscv: ax25-ae350: Cast addr with uintptr_t

From: Bin Meng addr was delcared as fdt_addr_t which is now a 64-bit address. In a 32-bit build, this causes the following warning seen when building ax25-ae350.c: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] Cast addr with uintptr_t. Signed-off-by: Bin Men

Re: [PATCH v2 08/10] riscv: Change phys_addr_t and phys_size_t to 64-bit

From: Bin Meng phys_addr_t and phys_size_t are currently defined as `unsigned long`, but RV32 supports 34-bit physical address, hence both phys_addr_t and phys_size_t should be defined to 64-bit using `unsigned long long`. Signed-off-by: Bin Meng --- (no changes since v1) arch/riscv/include/

Re: [PATCH v2 09/10] bdinfo: Rename function names to be clearer

From: Bin Meng At present we have bdinfo_print_num() to print unsigned long numbers. We also have print_phys_addr() which accept numbers that might be 64-bit on a 32-bit platform. Rename these 2 functions to be clearer: bdinfo_print_num() => bdinfo_print_num_l() print_phys_addr() => bdinfo_pri

Re: [PATCH v2 10/10] bdinfo: Change to use bdinfo_print_num_ll() where the number could be 64-bit

On Sun, 31 Jan 2021 at 05:37, Bin Meng wrote: > > From: Bin Meng > > There are some calls to bdinfo_print_num_l() with parameters that > could be a 64-bit value on a 32-bit system. Change those calls to > use bdinfo_print_num_ll() instead. > > Signed-off-by: Bin Meng > --- > > (no changes since

Re: [PATCH v2 1/1] sandbox: mark os_abort() as noreturn

On Sun, 31 Jan 2021 at 17:24, Heinrich Schuchardt wrote: > > gcc -fanalyzer needs the information that a function does not return to > provide accurate information. > > os_abort() does not return. Mark it accordingly. > > Signed-off-by: Heinrich Schuchardt > --- > v2: > use __attribute__(

Re: [PATCH] serial: ns16550: Handle zero value

Hi Simon, On Thu, Feb 4, 2021 at 8:33 AM Simon Glass wrote: > > On Wed, 3 Feb 2021 at 17:20, Bin Meng wrote: > > > > Hi Simon, > > > > On Thu, Feb 4, 2021 at 5:42 AM Simon Glass wrote: > > > > > > Hi Bin, > > > > > > On Wed, 3 Feb 2021 at 07:42, Bin Meng wrote: > > > > > > > > A working device

Re: [PATCH] serial: ns16550: Handle zero value

On Wed, 3 Feb 2021 at 17:20, Bin Meng wrote: > > Hi Simon, > > On Thu, Feb 4, 2021 at 5:42 AM Simon Glass wrote: > > > > Hi Bin, > > > > On Wed, 3 Feb 2021 at 07:42, Bin Meng wrote: > > > > > > A working device tree node of ns16550 should never be populated > > > with value zero for the propert

Re: [PATCH V2] spi: imx: Implement set_speed

On Thu, Feb 4, 2021 at 12:54 AM Marek Vasut wrote: > > The set_speed() callback should configure the bus speed, make it so. > > Signed-off-by: Marek Vasut > Cc: Jagan Teki > Cc: Stefano Babic > --- > V2: Rename dev_get_platdata() to dev_get_plat() > --- > drivers/spi/mxc_spi.c | 5 - > 1 f

Re: [PATCH] serial: ns16550: Handle zero value

Hi Simon, On Thu, Feb 4, 2021 at 5:42 AM Simon Glass wrote: > > Hi Bin, > > On Wed, 3 Feb 2021 at 07:42, Bin Meng wrote: > > > > A working device tree node of ns16550 should never be populated > > with value zero for the property. Unfortunately > > this is the case for the QEMU ppce500 target.

[PATCH] ARM: imx6: dh-imx6: Drop the SF hunk in config

There is now CONFIG_SPL_DM_SPI{,_FLASH}, however keeping CONFIG_DM_SPI{,_FLASH} enabled in SPL seems to grow the SPL by a couple of bytes: textdata bss dec hex filename - 340691568 96 357338b95 spl/u-boot-spl + 340751568 96 357398b9b spl/u-b

Please pull u-boot-x86

Hi Tom, This PR includes the following x86 changes for v2021.04: - Fix broken multi-core boot for QEMU x86 - Add zboot support to boot x86 Linux kernel image in the PXE sysboot utility Azure results: PASS https://dev.azure.com/bmeng/GitHub/_build/results?buildId=320&view=results The following c

Re: [PATCH v5 01/20] mmc: sdhci: Add helper functions for UHS modes

Hi Aswath, On 2/3/21 3:06 PM, Aswath Govindraju wrote: > Hi Jaehoon, > > On 02/02/21 3:40 am, Jaehoon Chung wrote: >> Hi Aswath, >> >> On 1/29/21 11:47 PM, Aswath Govindraju wrote: >>> From: Faiz Abbas >>> >>> Add a set_voltage() function which handles the switch from 3.3V to 1.8V >>> for SD car

Re: [PATCH] ARM: imx: Revert "dh_imx6: Switch to full DM-aware"

On 2/3/21 10:45 PM, Tom Rini wrote: [...] diff --git a/include/configs/dh_imx6.h b/include/configs/dh_imx6.h index fce5b0dd451..6c7c7171a4a 100644 --- a/include/configs/dh_imx6.h +++ b/include/configs/dh_imx6.h @@ -52,6 +52,12 @@ /* SATA Configs */ #define CONFIG_LBA48 +/* SPI Flash Conf

[PATCH] ARM: imx6: dh-imx6: Enable support for applying DTO

Enable DTO support to make it possible to boot fitImage with DTOs embedded in them. Signed-off-by: Marek Vasut Cc: Stefano Babic --- configs/dh_imx6_defconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configs/dh_imx6_defconfig b/configs/dh_imx6_defconfig index 0a667

Re: [PATCH] rpi: limit size of the RAM to the multiple of the MMU_SECTION_SIZE

On 2/3/21 9:20 PM, Nicolas Saenz Julienne wrote: > On Mon, 2021-02-01 at 12:16 +0100, Marek Szyprowski wrote: >> When RPi4 is booted from USB Mass Storage, the firmware reports 947MiB of >> the ARM memory (948 in case of the standard SD-card boot). This value is >> not MMU_SECTION_SIZE aligned, so

Re: [PATCH u-boot-marvell] mmc: mv_sdhci: call mmc_of_parse()

On 2/3/21 10:41 PM, Marek Behun wrote: > On Wed, 3 Feb 2021 08:32:45 +0900 > Jaehoon Chung wrote: > >> On 2/3/21 2:37 AM, Marek Behún wrote: >>> This is needed to parse more capabilities such as `non-removable`. >>> >>> Commit da18c62b6e6a ("mmc: sdhci: Implement SDHCI card detect") caused >>> a

Re: [PATCH] ARM: imx: Revert "dh_imx6: Switch to full DM-aware"

On Wed, Feb 03, 2021 at 10:36:33PM +0100, Marek Vasut wrote: > This reverts commit 03a673cf49e ("dh_imx6: Switch to full DM-aware"). > According to discussion [1], the patch is known to break the dh_imx6 > board, however it made it upstream just before 2021.01-rc4, likely by > mistake. Revert this

Re: [PATCH v2 1/1] sandbox: host bind must close file descriptor

On Tue, 2 Feb 2021 at 16:22, Heinrich Schuchardt wrote: > > Each invocation of the 'host bind' command with a file name argument opens > a file descriptor. The next invocation of the 'host bind' command destroys > the block device but the file descriptor remains open. The same holds true > for the

Re: [PATCH 1/2] lib: Fix BINMAN_FDT dependency

On Wed, 3 Feb 2021 at 06:20, Bin Meng wrote: > > lib/binman.c references the following 3 ofnode APIs: > ofnode_first_subnode(), ofnode_path() and ofnode_read_bool(). > > These APIs get built only when DM is on. Fix the dependency then. > > Signed-off-by: Bin Meng > --- > > lib/Kconfig | 2 +- >

Re: [PATCH 2/2] dts: Fix OF_LIVE dependency

On Wed, 3 Feb 2021 at 06:20, Bin Meng wrote: > > lib/of_live.c references the following 2 ofnode APIs: > of_alias_scan() and of_get_property(). > > These APIs get built only when DM is on. Fix the dependency then. > > Signed-off-by: Bin Meng > --- > > dts/Kconfig | 2 +- > 1 file changed, 1 inse

Re: [PATCH] serial: ns16550: Handle zero value

Hi Bin, On Wed, 3 Feb 2021 at 07:42, Bin Meng wrote: > > A working device tree node of ns16550 should never be populated > with value zero for the property. Unfortunately > this is the case for the QEMU ppce500 target. > > Let's try to assign plat->clock to CONFIG_SYS_NS16550_CLK as the > last r

Re: [PATCH] serial: ns16550: Correct the base address type

On Wed, 3 Feb 2021 at 06:22, Bin Meng wrote: > > Currently ns16550_serial_assign_base() treats the argument 'base' > with type `ulong`. This is incorrect because the base address was > obtained from device tree with type `fdt_addr_t` that can represent > a physical address larger than 32-bit in a

[PATCH] ARM: imx: Revert "dh_imx6: Switch to full DM-aware"

This reverts commit 03a673cf49e ("dh_imx6: Switch to full DM-aware"). According to discussion [1], the patch is known to break the dh_imx6 board, however it made it upstream just before 2021.01-rc4, likely by mistake. Revert this patch to put the board back into working order. Also note that this

Re: [PATCH v2] net: tftp: Avoid sending extra ack on completion

On Wed, Feb 3, 2021 at 11:26 AM Ramon Fried wrote: > > in tftpboot, if ack was already sent previously for this > packet, don't send again. > > Fixes: cc6b87ecaa96 ("net: tftp: Add client support for RFC 7440") > > Reported-by: Suneel Garapati > Signed-off-by: Ramon Fried > --- > v2: Fix it so i

Re: [PATCH] net: tftp: Avoid sending extra ack on completion

On Wed, Feb 3, 2021 at 11:26 AM Ramon Fried wrote: > > On Wed, Feb 3, 2021 at 8:43 PM Suneel Garapati wrote: > > > > On Wed, Feb 3, 2021 at 12:05 AM Ramon Fried wrote: > > > > > > in tftpboot, if ack was already sent previously for this > > > packet, don't send again. > > > > > > Fixes: cc6b87ec

[PATCH v2] net: tftp: Avoid sending extra ack on completion

in tftpboot, if ack was already sent previously for this packet, don't send again. Fixes: cc6b87ecaa96 ("net: tftp: Add client support for RFC 7440") Reported-by: Suneel Garapati Signed-off-by: Ramon Fried --- v2: Fix it so it actually works :) net/tftp.c | 11 ++- 1 file changed, 6 i

Re: [PATCH] net: tftp: Avoid sending extra ack on completion

On Wed, Feb 3, 2021 at 8:43 PM Suneel Garapati wrote: > > On Wed, Feb 3, 2021 at 12:05 AM Ramon Fried wrote: > > > > in tftpboot, if ack was already sent previously for this > > packet, don't send again. > > > > Fixes: cc6b87ecaa96 ("net: tftp: Add client support for RFC 7440") > > > > Reported-b

Re: [PATCH] net: tftp: Avoid sending extra ack on completion

On Wed, Feb 3, 2021 at 12:05 AM Ramon Fried wrote: > > in tftpboot, if ack was already sent previously for this > packet, don't send again. > > Fixes: cc6b87ecaa96 ("net: tftp: Add client support for RFC 7440") > > Reported-by: Suneel Garapati > Signed-off-by: Ramon Fried > --- > net/tftp.c | 3

Re: [PATCH 4/4] net: gem: Enable ethernet rx clock for versal

On Wed, Feb 3, 2021 at 2:18 PM Michal Simek wrote: > > From: T Karthik Reddy > > Enable rx clock along with tx clock for versal platform. > > Signed-off-by: T Karthik Reddy > Signed-off-by: Michal Simek > --- > > drivers/net/zynq_gem.c | 26 -- > 1 file changed, 20 inse

[PATCH 1/1] efi_loader: VenMedia device path node

The Load File2 protocol exposes a device path with a VenMedia() node. Hence our implementation of the device path to text protocol should support this node. Cc: Ilias Apalodimas Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_device_path_to_text.c | 15 +++ 1 file changed,

Re: [PATCH] spi: imx: Implement set_speed

On 2/2/21 4:10 AM, Bin Meng wrote: On Thu, Jan 28, 2021 at 12:01 AM Marek Vasut wrote: The set_speed() callback should configure the bus speed, make it so. Signed-off-by: Marek Vasut Cc: Jagan Teki Cc: Stefano Babic --- drivers/spi/mxc_spi.c | 5 - 1 file changed, 4 insertions(+), 1

[PATCH V2] spi: imx: Implement set_speed

The set_speed() callback should configure the bus speed, make it so. Signed-off-by: Marek Vasut Cc: Jagan Teki Cc: Stefano Babic --- V2: Rename dev_get_platdata() to dev_get_plat() --- drivers/spi/mxc_spi.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/spi/mxc

[PATCH v2 37/37] x86: apl: Use read-only SPL and new of-platdata

With Apollo Lake, SPL is placed in read-only memory. Set this new option so that OF_PLATDATA_INST can be used. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/cpu/apollolake/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/cpu/apollolake/Kconfig b/arch/x86/c

[PATCH v2 36/37] x86: coral: Drop ACPI properties from of-platdata

We don't use these in TPL or SPL, so drop them. Also drop 'ranges' since we don't have a full PCI driver. Signed-off-by: Simon Glass --- (no changes since v1) configs/chromebook_coral_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/chromebook_coral_defconfig b/configs/ch

[PATCH v2 35/37] x86: Don't include reset driver in SPL

We don't normally need this driver in TPL/SPL, so drop it for now. It can be enabled by individual boards if needed. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/dts/reset.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/dts/reset.dtsi b/arch/x

[PATCH v2 34/37] x86: Support a fake PCI device with of-platdata-inst

With TPL we don't need full PCI support and it adds to code size. Instead, a simple_bus driver is good enough to be able to read and write the PCI config and do a little basic setup. So at present there are two drivers in U-Boot called pci_x86. One is in UCLASS_PCI, used in SPL and U-Boot proper.

[PATCH v2 32/37] x86: apl: Tell of-platdata about a required header file

This enum is needed to generate build-time devices. Tell dtoc where to find the header, to avoid compile errors in the generated code. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/cpu/apollolake/punit.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/cpu/apollolak

[PATCH v2 33/37] x86: itss: Tidy up bind() for of-platdata-inst

With the standard of-platdata we must fix up driver_data manually. With of-platadata-inst this is not necessary, since it is added to the device by dtoc. Update the code to handle this. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/cpu/intel_common/itss.c | 5 +++-- 1 file cha

[PATCH v2 31/37] x86: apl: Fix the header order in pmc

The dm.h header should come first. In fact it needs to, since otherwise the driver model definitions are not available to dt-structs.h Fix this, since it causes problems with OF_PLATDATA_INST. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/cpu/apollolake/pmc.c | 2 +- 1 file ch

[PATCH v2 30/37] x86: Define a region for device priv/plat data

Collect this together in one place, so driver model can access set it up in a new place if needed. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/cpu/u-boot-spl.lds | 8 1 file changed, 8 insertions(+) diff --git a/arch/x86/cpu/u-boot-spl.lds b/arch/x86/cpu/u-boot-spl.

[PATCH v2 29/37] dm: core: Use separate priv/plat data region

Make use of the new priv/plat data region if enabled. This is implemented as a simple offset from the position set up by dtoc to the new position. So long as all access goes through dm_priv_to_rw() this is safe. Signed-off-by: Simon Glass --- (no changes since v1) drivers/core/device.c | 12 +

[PATCH v2 28/37] sandbox: Define a region for device priv/plat data

Collect this together in one place, so driver model can access set it up in a new place if needed. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/cpu/u-boot-spl.lds | 8 1 file changed, 8 insertions(+) diff --git a/arch/sandbox/cpu/u-boot-spl.lds b/arch/sandbox/cpu

[PATCH v2 27/37] dm: core: Allow storing priv/plat data separately

At present the device priv/data data allocated by dtoc is stored in the data section along with other variables. On some platforms it is better to allocate space for it separately, e.g. if SPL is running from read-only memory. Create a new space with the same size as that allocated by dtoc, ready

[PATCH v2 24/37] dm: core: Add an option to support SPL in read-only memory

Some systems (e.g. x86 APL) run SPL from read-only memory. The device instances created by dtoc are therefore not writeable. To make things work we would need to copy the devices to read/write memory. To avoid this, add an option to use a separate runtime struct for devices, just as is done for dr

[PATCH v2 26/37] dm: core: Move flags to device-runtime info

When of-platdata-inst is active, use the flags in the new udevice_rt table, dropping them from the main struct udevice. This ensures that the latter is not updated at runtime. Signed-off-by: Simon Glass --- Changes in v2: - Leave the flags_ memeber in the same struct position drivers/core/devi

[PATCH v2 25/37] dm: core: Create a struct for device runtime info

At present when driver model needs to change a device it simply updates the struct udevice structure. But with of-platdata-inst most of the fields are not modified at runtime. In fact, typically only the flags need to change. For systems running SPL from read-only memory it is convenient to separa

[PATCH v2 23/37] azure/gitlab: Add tests for sandbox_noinst

Add this new board to the test plans. Travis-CI is left out, since it is being removed soon due to lack of capacity. Signed-off-by: Simon Glass --- (no changes since v1) .azure-pipelines.yml | 3 +++ .gitlab-ci.yml | 10 +- 2 files changed, 12 insertions(+), 1 deletion(-) diff

[PATCH v2 22/37] test: Run sandbox_spl tests on sandbox_noinst

Run the tests on this build too, to prevent regressions. Signed-off-by: Simon Glass --- (no changes since v1) test/run | 4 1 file changed, 4 insertions(+) diff --git a/test/run b/test/run index 735628e7e37..869406cd8d2 100755 --- a/test/run +++ b/test/run @@ -30,6 +30,10 @@ fi run_test

[PATCH v2 21/37] sandbox: Create a new sandbox_noinst build

Move sandbox_spl over to use OF_PLATDATA_INST. Create a new board to test the case when this is not enabled, since we will be keeping that code around for several months and want to avoid regressions. Skip the dm_test_of_plat_dev() test since driver info is not available for OF_PLATDATA_INST. Sig

[PATCH v2 20/37] Revert "sandbox: Disable I2C emulators in SPL"

With recent changes this can be supported again. Add it back. This reverts commit d85f2c4f2970d0ec2f5f075de734afd11200d153. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/dts/sandbox.dtsi | 10 +++--- configs/sandbox_spl_defconfig | 1 + drivers/i2c/Makefile |

[PATCH v2 19/37] sandbox: i2c: Support i2c emulation with of-platdata

At present the i2c emulators require access to the devicetree, which is not possible (by design) with of-platdata. Add a way for drivers to record the of-platdata index of their emulator, so that we can still find the emulator. This allows i2c emulation to work with of-platdata. Signed-off-by: S

[PATCH v2 18/37] sandbox_spl: Increase SPL malloc() size

The test framework reinits driver model tests before running each test. Since malloc_simple does not support free(), this eventually runs out of memory. Fix it for now by increasing the space to 32KB. Signed-off-by: Simon Glass --- (no changes since v1) configs/sandbox_spl_defconfig | 1 + 1

[PATCH v2 17/37] dm: Rename device_get_by_driver_info_idx()

This function finds a device by its driver_info index. With of-platdata-inst we do not use driver_info, but instead instantiate udevice records at build-time. However the semantics of using the function are the same in each case: the caller provides an index and gets back a device. So rename the

[PATCH v2 14/37] dm: core: Drop device_get_by_driver_info()

This function is now only used in a test. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) drivers/core/device.c | 15 --- include/dm/device.h | 15 --- test/dm/of_platdata.c | 7 ++- 3 files changed, 2 insertions(+), 35 deletions(-) diff --git a/dr

  1   2   3   >