Re: [PATCH v6 00/28] Add DM support for omap PWM backlight

2020-12-22 Thread Lokesh Vutla
On 23/12/20 12:00 am, Dario Binacchi wrote: > Hi Lokesh, > >> Il 22/12/2020 14:52 Lokesh Vutla ha scritto: >> >> >> Hi Dario, >> >> On 22/11/20 9:41 pm, Dario Binacchi wrote: >>> >>> The series was born from the need to manage the PWM backlight of the >>> display connected to my beaglebone b

RE: [PATCH] imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN

2020-12-22 Thread Peng Fan
All, > Subject: RE: [PATCH] imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN I am thinking to remove the CLK CCF support for i.MX8M, and use simple CLK DM. Do you agree? Thanks, Peng. > > > Subject: [PATCH] imx8mp_evk: Increase CONFIG_SYS_MALLOC_F_LEN > > > > When booting imx8mp-evk the following

[PATCH v3 14/14] qemu: arm64: Add documentation for capsule update

2020-12-22 Thread Sughosh Ganu
Add documentation highlighting the steps for using the uefi capsule update feature for updating the u-boot firmware image. Signed-off-by: Sughosh Ganu --- Changes since V2: * Moved the capsule update related documentation for the Qemu platform to a new file under doc/board/emulation/ directory

[PATCH v3 13/14] efidebug: capsule: Add a command to update capsule on disk

2020-12-22 Thread Sughosh Ganu
Add a efidebug subcommand to initiate a firmware update using the efi firmware management protocol(fmp) set_image routine. The firmware update can be initiated through 'efidebug capsule disk-update' This would locate the efi capsule file on the efi system partition, and call the platform's set_i

[PATCH v3 12/14] efi_loader: Enable uefi capsule authentication

2020-12-22 Thread Sughosh Ganu
Add support for enabling uefi capsule authentication. This feature is enabled by setting the environment variable "capsule_authentication_enabled". The following configs are needed for enabling uefi capsule update and capsule authentication features on the platform. CONFIG_EFI_HAVE_CAPSULE_SUPPOR

[PATCH v3 11/14] efi: capsule: Add support for uefi capsule authentication

2020-12-22 Thread Sughosh Ganu
Add support for authenticating uefi capsules. Most of the signature verification functionality is shared with the uefi secure boot feature. The root certificate containing the public key used for the signature verification is stored as part of the device tree blob. The root certificate is stored a

[PATCH v3 10/14] efi_loader: Re-factor code to build the signature store from efi signature list

2020-12-22 Thread Sughosh Ganu
The efi_sigstore_parse_sigdb function reads the uefi authenticated variable, stored in the signature database format and builds the signature store structure. Factor out the code for building the signature store. This can then be used by the capsule authentication routine to build the signature sto

[PATCH v3 09/14] efi_loader: Make the pkcs7 header parsing function an extern

2020-12-22 Thread Sughosh Ganu
The pkcs7 header parsing functionality is pretty generic, and can be used by other features like capsule authentication. Make the function an extern, also changing it's name to efi_parse_pkcs7_header Signed-off-by: Sughosh Ganu --- Changes since V2: None include/efi_loader.h | 4 ++

[PATCH v3 08/14] dfu_mtd: Add provision to unlock mtd device

2020-12-22 Thread Sughosh Ganu
Prior to writing to an mtd device, mtd_erase is called. This call fails in case the sector being erased is locked. Call mtd_unlock to unlock the region which is to be erased and later written to. Lock the region once the write to the region has completed. Signed-off-by: Sughosh Ganu --- Changes

[PATCH v3 07/14] efi_loader: Add logic to parse EDKII specific fmp payload header

2020-12-22 Thread Sughosh Ganu
When building the capsule using scripts in edk2, a fmp header is added on top of the binary payload. Add logic to detect presence of the header. When present, the pointer to the image needs to be adjusted as per the size of the header to point to the actual binary payload. Signed-off-by: Sughosh G

[PATCH v3 05/14] qemu: common: Set dfu_alt_info variable for the platform

2020-12-22 Thread Sughosh Ganu
The dfu framework uses the dfu_alt_info environment variable to get information that is needed for performing the firmware update. Add logic to set the dfu_alt_info for the qemu arm64 platform to reflect the two mtd partitions created for the u-boot env and the firmware image. This can be subsequen

[PATCH v3 06/14] fsp: Move and rename fsp_types.h file

2020-12-22 Thread Sughosh Ganu
The fsp_types.h header file contains macros for building signatures of different widths. These signature macros are architecture agnostic, and can be used in all places which use signatures in a data structure. Move and rename the fsp_types.h under the common include header. Signed-off-by: Sughosh

[PATCH v3 04/14] qemu: common: Add support for dynamic mtdparts for the platform

2020-12-22 Thread Sughosh Ganu
Add support for setting the default values for mtd partitions on the platform. This would be used for updating the firmware image using uefi capsule update with the dfu mtd backend driver. Currently, values have been defined for the qemu arm64 platform, with default values defined for the mtd part

[PATCH v3 03/14] crypto: Fix the logic to calculate hash with authattributes set

2020-12-22 Thread Sughosh Ganu
RFC 2315 Section 9.3 describes the message digesting process. The digest calculated depends on whether the authenticated attributes are present. In case of a scenario where the authenticated attributes are present, the message digest that gets signed and is part of the pkcs7 message is computed fro

[PATCH v3 02/14] qemu: arm: Initialise virtio devices in board_late_init

2020-12-22 Thread Sughosh Ganu
On the qemu arm platform, the virtio devices are initialised in the board_init function, which gets called before the initr_pci. With this sequence, the virtio block devices on the pci bus are not initialised. Move the initialisation of the virtio devices to board_late_init which gets called after

[PATCH v3 01/14] mkeficapsule: Add support for embedding public key in a dtb

2020-12-22 Thread Sughosh Ganu
Add options for embedding the public key esl(efi signature list) file to the platform's dtb. The esl file is then retrieved and used for authenticating the capsule to be used for updating firmare components on the platform. The esl file can now be embedded in the dtb by invoking the following comm

[PATCH v3 00/14] qemu: arm64: Add support for uefi capsule update on qemu arm platform

2020-12-22 Thread Sughosh Ganu
The capsule update feature is supported on a platform configuration booting in a non-secure mode, i.e with -machine virt,secure=off option set. This results in the platform booting u-boot directly without the presence of trusted firmware(tf-a). Steps that need to be followed for using this feature

Re: [PATCH v6 03/28] bus: ti: add minimal sysc interconnect target driver

2020-12-22 Thread Lokesh Vutla
On 22/11/20 9:41 pm, Dario Binacchi wrote: > We can handle the sysc interconnect target module in a generic way for > many TI SoCs. Initially let's just enable domain clocks before the > children are probed. > > The code is loosely based on the drivers/bus/ti-sysc.c of the Linux > kernel versio

Re: [PATCH v2 5/6] mmc: actions: add MMC driver for Actions OWL S700

2020-12-22 Thread Jaehoon Chung
Hi Amit, On 12/23/20 2:59 PM, Amit Tomar wrote: > Hi Jaehoon > > I had already mentioned about making more readable than now. > >> >> if (rate <= 100) { >> rdelay = wdelay = OWL_SD_DELAY_LOW_CLK; >> } else if ( ...) { >> rdelay = wdelay = OWL_SD_DELAY_MID_CLK; >> } else if (.

Re: [PATCH v2] Nokia RX-51: Enable usbtty serial console by default

2020-12-22 Thread Lokesh Vutla
On 22/12/20 9:32 pm, Pali Rohár wrote: > On Tuesday 22 December 2020 21:08:45 Lokesh Vutla wrote: >> On 22/12/20 8:47 pm, Pali Rohár wrote: >>> On Tuesday 22 December 2020 20:39:11 Lokesh Vutla wrote: On 22/12/20 8:38 pm, Lokesh Vutla wrote: > > > On 22/12/20 8:36 pm,

Re: [PATCH v2 5/6] mmc: actions: add MMC driver for Actions OWL S700

2020-12-22 Thread Amit Tomar
Hi Jaehoon I had already mentioned about making more readable than now. > > if (rate <= 100) { > rdelay = wdelay = OWL_SD_DELAY_LOW_CLK; > } else if ( ...) { > rdelay = wdelay = OWL_SD_DELAY_MID_CLK; > } else if () { > rdelay = OWL_SD_RDELAY_HIGH; > wdelay

Re: [PATCH 2/2] patman: Quieten down the alias checking

2020-12-22 Thread Sean Anderson
On 12/22/20 10:14 PM, Simon Glass wrote: When a tag is used in a patch subject (e.g. "tag: rest of message") and it cannot be found as an alias, patman currently reports a fatal error, unless -t is provided, in which case it reports a warning. Experience suggest that the fatal error is not very

Re: [PATCH v2 5/6] mmc: actions: add MMC driver for Actions OWL S700

2020-12-22 Thread Jaehoon Chung
On 12/23/20 11:22 AM, Amit Tomer wrote: > On Wed, Dec 23, 2020 at 5:57 AM André Przywara wrote: >> >> On 19/12/2020 14:51, Amit Singh Tomar wrote: >>> From: Amit Singh Tomar >>> >>> This commit adds support for MMC controllers found on Actions OWL >>> S700 SoC platform. >>> >>> Signed-off-by: Ami

RE: [v5 17/18] arm: socfpga: soc64: Enable FIT image generation using binman

2020-12-22 Thread Tan, Ley Foon
> -Original Message- > From: Lim, Elly Siew Chin > Sent: Tuesday, December 22, 2020 12:50 AM > To: u-boot@lists.denx.de > Cc: Marek Vasut ; Tan, Ley Foon > ; See, Chin Liang ; > Simon Goldschmidt ; Chee, Tien Fong > ; Westergreen, Dalon > ; Simon Glass ; Gan, > Yau Wai ; Lim, Elly Siew

RE: [v5 16/18] arm: socfpga: dts: soc64: Add binman node of FIT image with ATF support

2020-12-22 Thread Tan, Ley Foon
> -Original Message- > From: Lim, Elly Siew Chin > Sent: Tuesday, December 22, 2020 12:50 AM > To: u-boot@lists.denx.de > Cc: Marek Vasut ; Tan, Ley Foon > ; See, Chin Liang ; > Simon Goldschmidt ; Chee, Tien Fong > ; Westergreen, Dalon > ; Simon Glass ; Gan, > Yau Wai ; Lim, Elly Siew

RE: [v5 10/18] net: designware: socfpga: Add ATF support for MAC driver

2020-12-22 Thread Tan, Ley Foon
> -Original Message- > From: Lim, Elly Siew Chin > Sent: Tuesday, December 22, 2020 12:50 AM > To: u-boot@lists.denx.de > Cc: Marek Vasut ; Tan, Ley Foon > ; See, Chin Liang ; > Simon Goldschmidt ; Chee, Tien Fong > ; Westergreen, Dalon > ; Simon Glass ; Gan, > Yau Wai ; Ang, Chee Hong

RE: [v5 09/18] mmc: dwmmc: socfpga: Add ATF support for MMC driver

2020-12-22 Thread Tan, Ley Foon
> -Original Message- > From: Lim, Elly Siew Chin > Sent: Tuesday, December 22, 2020 12:50 AM > To: u-boot@lists.denx.de > Cc: Marek Vasut ; Tan, Ley Foon > ; See, Chin Liang ; > Simon Goldschmidt ; Chee, Tien Fong > ; Westergreen, Dalon > ; Simon Glass ; Gan, > Yau Wai ; Ang, Chee Hong

RE: [v5 08/18] mmc: dwmmc: Change designware MMC 'clksel' callback function to return status

2020-12-22 Thread Tan, Ley Foon
> -Original Message- > From: Lim, Elly Siew Chin > Sent: Tuesday, December 22, 2020 12:50 AM > To: u-boot@lists.denx.de > Cc: Marek Vasut ; Tan, Ley Foon > ; See, Chin Liang ; > Simon Goldschmidt ; Chee, Tien Fong > ; Westergreen, Dalon > ; Simon Glass ; Gan, > Yau Wai ; Lim, Elly Siew

RE: [v5 07/18] arm: socfpga: Add secure register access helper functions for SoC 64bits

2020-12-22 Thread Tan, Ley Foon
> -Original Message- > From: Lim, Elly Siew Chin > Sent: Tuesday, December 22, 2020 12:50 AM > To: u-boot@lists.denx.de > Cc: Marek Vasut ; Tan, Ley Foon > ; See, Chin Liang ; > Simon Goldschmidt ; Chee, Tien Fong > ; Westergreen, Dalon > ; Simon Glass ; Gan, > Yau Wai ; Lim, Elly Siew

[PATCH 2/2] patman: Quieten down the alias checking

2020-12-22 Thread Simon Glass
When a tag is used in a patch subject (e.g. "tag: rest of message") and it cannot be found as an alias, patman currently reports a fatal error, unless -t is provided, in which case it reports a warning. Experience suggest that the fatal error is not very useful. Instead, default to reporting a war

[PATCH 1/2] this: patman: Update documentation to match new usage

2020-12-22 Thread Simon Glass
With the subcommands some of the documentation examples are no-longer correct. Fix all of them, so it is consistent. Signed-off-by: Simon Glass --- tools/patman/README | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tools/patman/README b/tools/patman/README in

Re: patman regression?

2020-12-22 Thread Simon Glass
Hi, On Tue, 22 Dec 2020 at 18:25, Bin Meng wrote: > > Hi Simon, > > On Sat, Dec 12, 2020 at 12:29 AM Simon Glass wrote: > > > > Hi Bin, > > > > On Thu, 10 Dec 2020 at 21:37, Bin Meng wrote: > > > > > > On Fri, Dec 11, 2020 at 12:32 PM Sean Anderson wrote: > > > > > > > > On 12/10/20 11:27 PM,

[PATCH v2 18/18] dm: core: Rename the priv/plat members

2020-12-22 Thread Simon Glass
These are supposed to be private to driver model, not accessed by any code outside. Add a trailing underscore to indicate this. Signed-off-by: Simon Glass --- (no changes since v1) drivers/core/device.c | 24 drivers/core/uclass.c | 4 ++-- include/dm/device.h | 29

[PATCH v2 17/18] dm: core: Use access methods for dev/uclass private data

2020-12-22 Thread Simon Glass
Use these functions in the core code as much as possible. With this, there are only two places where each priv/plat pointer is accessed, one for read and one for write. Signed-off-by: Simon Glass --- Changes in v2: - Add a warning for clk_reqister() drivers/core/device-remove.c | 8 ++--- dri

[PATCH v2 14/18] dm: core: Add function to access uclass priv

2020-12-22 Thread Simon Glass
Add functions so this information is not accessed directly. This will be needed for of-platdata which stores it in a different place. Signed-off-by: Simon Glass --- (no changes since v1) drivers/core/uclass.c| 10 ++ include/dm/uclass-internal.h | 14 ++ include/dm/

[PATCH v2 15/18] dm: core: Add functions to set priv/plat

2020-12-22 Thread Simon Glass
This should not normally be needed in drivers, but add accessors for the few cases that exist. Signed-off-by: Simon Glass --- (no changes since v1) drivers/core/device.c| 30 + include/dm/device-internal.h | 84 2 files changed, 114 inse

[PATCH v2 13/18] x86: apl: Drop support for !OF_PLATDATA_PARENT

2020-12-22 Thread Simon Glass
This code was kept around after of-platdata started supporting parent devices. That feature seems stable now, so let's drop it. Signed-off-by: Simon Glass --- Changes in v2: - Remove an old comment about this in pinctrl arch/x86/cpu/apollolake/Kconfig | 1 + arch/x86/cpu/apollolake/spl.c

[PATCH v2 11/18] dm: core: Use 'uclass_driver' for the uclass linker_list

2020-12-22 Thread Simon Glass
At present the name 'uclass_driver' is used for the uclass linker list. This does not follow the convention of using the struct name. Fix it. Signed-off-by: Simon Glass --- (no changes since v1) drivers/core/lists.c | 4 ++-- drivers/core/root.c | 4 ++-- include/dm/uclass.h | 2 +- 3 files

[PATCH v2 12/18] dm: core: Only include simple-bus devicetree id when needed

2020-12-22 Thread Simon Glass
This is not needed when of-platdata is in use. Update it. Signed-off-by: Simon Glass --- (no changes since v1) drivers/core/simple-bus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/core/simple-bus.c b/drivers/core/simple-bus.c index c45212a0d3a..7dbcbecd948 1

[PATCH v2 09/18] spl: Drop bd_info in the data section

2020-12-22 Thread Simon Glass
This uses up space in the SPL binary but it always starts as zero. Also some boards cannot support data in TPL (e.g. Intel Apollo Lake). Use malloc() to allocate this structure instead, by moving the init a little later, after malloc() is inited. Make this function optional since it pulls in mallo

[PATCH v2 06/18] serial: Update NS16550_t and struct NS16550

2020-12-22 Thread Simon Glass
Typedefs should not be used in U-Boot and structs should be lower case. Update the code to use struct ns16550 consistently. Put a header guard on the file while we are here. Signed-off-by: Simon Glass Reviewed-by: Andy Shevchenko --- (no changes since v1) arch/arm/mach-davinci/da850_lowleve

[PATCH v2 10/18] dm: core: Support dm_dump_all() in SPL

2020-12-22 Thread Simon Glass
At present the output from this function is hard to read in SPL, due to (intended) limitations in SPL's printf() function. Add an SPL version so it is clearer. Signed-off-by: Simon Glass --- (no changes since v1) drivers/core/dump.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

[PATCH v2 07/18] serial: Rename ns16550 functions to lower case

2020-12-22 Thread Simon Glass
Lower case should be used for function names. Update this driver and its callers accordingly. Signed-off-by: Simon Glass Reviewed-by: Andy Shevchenko --- (no changes since v1) arch/arm/mach-davinci/da850_lowlevel.c | 2 +- arch/arm/mach-davinci/spl.c| 4 ++-- arch/arm/m

[PATCH v2 08/18] sandbox: Drop unnecessary test node

2020-12-22 Thread Simon Glass
The spl-test4 node deliberately has an invalid compatible string. This causes a warning from dtoc and the check it does is not really necessary. Drop it, to avoid the warning and associated confusion. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/dts/sandbox.dtsi| 5 --

[PATCH v2 05/18] buildman: Report sizes for TPL also

2020-12-22 Thread Simon Glass
At present only U-Boot proper and SPL are scanned to obtain size information. Add TPL also, to complete the picture. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/buildman/builderth

[PATCH v2 03/18] Makefile: Tidy up SPL dtb production

2020-12-22 Thread Simon Glass
Use the SPL_NAME variable to simplify the rules. Drop the SPL targets clean-files since the SPL and TPL dts/ directories are removed by existing rules. Move the SPL rules into a new spl_dtbs to avoid the complicated $(if) construct. Also drop unused pieces from the 'targets' variable. With this,

[PATCH v2 02/18] Makefile: Build SPL dtbs in the spl/ directory

2020-12-22 Thread Simon Glass
Rather than putting these in the top-level dts/ directory (which is intended for U-Boot proper), put them in the correct subdirectory for SPL (either spl/ or tpl/). This is where other SPL targets are kept, so this is more consistent. Signed-off-by: Simon Glass --- (no changes since v1) dts/Ma

[PATCH v2 04/18] Makefile: Use common args for dtoc

2020-12-22 Thread Simon Glass
At present the dtoc commmand line is repeated twice in the Makefile. Use a variable to avoid this, so it is easier to add more conditional arguments. Signed-off-by: Simon Glass --- (no changes since v1) scripts/Makefile.spl | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --g

[PATCH v2 01/18] Makefile: Build a separate .dtb for TPL

2020-12-22 Thread Simon Glass
At present both SPL and TPL use the same devicetree binary. While there is logic to run fdtgrep separately on each one, it does not actually happen. Add a new TPL rule and use that instead. Make this rule conditional on there actually being a TPL. Do the same for SPL for consistency. Note that th

[PATCH v2 00/18] dm: Preparation for enhanced of-platdata

2020-12-22 Thread Simon Glass
This series includes various patches in service of some upcoming of-platdata enhancements. The new features will support declaring devices and uclasses at build time (automatically, using dtoc) so as to further reduce the code-size overhead of driver model. The main changes in this series are: - S

Re: [PATCH v2 5/6] mmc: actions: add MMC driver for Actions OWL S700

2020-12-22 Thread Amit Tomer
On Wed, Dec 23, 2020 at 5:57 AM André Przywara wrote: > > On 19/12/2020 14:51, Amit Singh Tomar wrote: > > From: Amit Singh Tomar > > > > This commit adds support for MMC controllers found on Actions OWL > > S700 SoC platform. > > > > Signed-off-by: Amit Singh Tomar > > --- > > Changes since pre

Re: [PATCH v2 4/6] ARM: dts: s700: add MMC/SD controller node

2020-12-22 Thread Amit Tomar
On Wed, Dec 23, 2020 at 4:58 AM Jaehoon Chung wrote: > On 12/19/20 11:51 PM, Amit Singh Tomar wrote: > > From: Amit Singh Tomar > > > > This patch adds node for ethernet controller found on Action Semi OWL > > S700 SoC. > > Is "ethernet controller" right? > It gets picked from one of earlier co

[RESEND PATCH 2/2] dt-bindings: usb: mtk-xhci: add optional properies to disable ports

2020-12-22 Thread Chunfeng Yun
Add optional properies to disable usb2 or usb3 ports, they are used when provided ports are not used on some special platforms. Signed-off-by: Chunfeng Yun --- doc/device-tree-bindings/usb/mediatek,mtk-xhci.txt | 4 1 file changed, 4 insertions(+) diff --git a/doc/device-tree-bindings/usb/

[RESEND PATCH 1/2] usb: xhci-mtk: support option to disable ports

2020-12-22 Thread Chunfeng Yun
Add support to disable specific ports, it's useful for some scenarios: 1. usb3 PHY is shared whith PCIe or SATA, the corresponding usb3 port can be disabled; 2. some usb2 or usb3 ports are not used on special platforms, they should be disabled to save power. Signed-off-by: Chunfeng Yun ---

Re: [PATCH v2 4/6] ARM: dts: s700: add MMC/SD controller node

2020-12-22 Thread Jaehoon Chung
On 12/23/20 9:27 AM, André Przywara wrote: > On 22/12/2020 23:28, Jaehoon Chung wrote: >> On 12/19/20 11:51 PM, Amit Singh Tomar wrote: >>> From: Amit Singh Tomar >>> >>> This patch adds node for ethernet controller found on Action Semi OWL >>> S700 SoC. >> >> Is "ethernet controller" right? >> >>

Re: patman regression?

2020-12-22 Thread Bin Meng
Hi Simon, On Sat, Dec 12, 2020 at 12:29 AM Simon Glass wrote: > > Hi Bin, > > On Thu, 10 Dec 2020 at 21:37, Bin Meng wrote: > > > > On Fri, Dec 11, 2020 at 12:32 PM Sean Anderson wrote: > > > > > > On 12/10/20 11:27 PM, Bin Meng wrote: > > > > On Fri, Dec 11, 2020 at 12:08 PM Bin Meng wrote: >

Re: [PATCH] doc: qemu-riscv: Fix opensbi build instructions

2020-12-22 Thread Bin Meng
On Wed, Dec 23, 2020 at 3:50 AM Atish Patra wrote: > > Latest opensbi uses generic platform for Qemu. Update the build > instructions. > > Signed-off-by: Atish Patra > --- > doc/board/emulation/qemu-riscv.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng

Re: patman regression?

2020-12-22 Thread Sean Anderson
On 12/22/20 7:06 PM, Simon Glass wrote: Hi Sean, On Tue, 22 Dec 2020 at 16:51, Sean Anderson wrote: On 12/11/20 11:29 AM, Simon Glass wrote: Hi Bin, On Thu, 10 Dec 2020 at 21:37, Bin Meng wrote: On Fri, Dec 11, 2020 at 12:32 PM Sean Anderson wrote: On 12/10/20 11:27 PM, Bin Meng wrote

Re: [PATCH v2 5/6] mmc: actions: add MMC driver for Actions OWL S700

2020-12-22 Thread André Przywara
On 19/12/2020 14:51, Amit Singh Tomar wrote: > From: Amit Singh Tomar > > This commit adds support for MMC controllers found on Actions OWL > S700 SoC platform. > > Signed-off-by: Amit Singh Tomar > --- > Changes since previous version > * Corrected block count to 512. > * Changed t

Re: [PATCH v2 5/6] mmc: actions: add MMC driver for Actions OWL S700

2020-12-22 Thread André Przywara
On 22/12/2020 23:37, Jaehoon Chung wrote: > On 12/19/20 11:51 PM, Amit Singh Tomar wrote: >> From: Amit Singh Tomar >> >> This commit adds support for MMC controllers found on Actions OWL >> S700 SoC platform. >> >> Signed-off-by: Amit Singh Tomar >> --- >> Changes since previous version >>

Re: [PATCH v2 4/6] ARM: dts: s700: add MMC/SD controller node

2020-12-22 Thread André Przywara
On 22/12/2020 23:28, Jaehoon Chung wrote: > On 12/19/20 11:51 PM, Amit Singh Tomar wrote: >> From: Amit Singh Tomar >> >> This patch adds node for ethernet controller found on Action Semi OWL >> S700 SoC. > > Is "ethernet controller" right? > >> >> Since, upstream Linux binding has not been merg

Re: [PATCH v2 2/6] clk: actions: Add SD/MMC clocks

2020-12-22 Thread André Przywara
On 19/12/2020 14:51, Amit Singh Tomar wrote: Hi, > From: Amit Singh Tomar > > This commit adds SD/MMC clocks, and provides .set/get_rate callbacks > for SD/MMC device present on Actions OWL S700 SoCs. > > Signed-off-by: Amit Singh Tomar > --- > Changes since previous version: > * Remove

Re: [PATCH v4 00/13] Raspberry Pi 400/Compute Module 4 support

2020-12-22 Thread Simon Glass
Hi Nicolas, On Tue, 22 Dec 2020 at 05:36, Nicolas Saenz Julienne wrote: > > @Simon: I had to roll back all "if (CONFIG_IS_ENABLED(DM_DMA)" uses. As > per buildman it breaks compilation when !DM or !DM_DMA due to access to > undefined variables, namely dev and dev->dma_offset. I figure in u-boot >

Re: [PATCH 3/3] patman: fix project-defaults not propagating into parsers

2020-12-22 Thread Simon Glass
Hi Philipp, On Wed, 25 Nov 2020 at 12:41, Philipp Tomsich wrote: > > Simon, > > On Wed, 25 Nov 2020 at 16:30, Simon Glass wrote: > > Here is a pointer to the docs I saw: > > > > https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.set_defaults > > > > "Parser-level defaults ca

Re: patman regression?

2020-12-22 Thread Simon Glass
Hi Sean, On Tue, 22 Dec 2020 at 16:51, Sean Anderson wrote: > > On 12/11/20 11:29 AM, Simon Glass wrote: > > Hi Bin, > > > > On Thu, 10 Dec 2020 at 21:37, Bin Meng wrote: > >> > >> On Fri, Dec 11, 2020 at 12:32 PM Sean Anderson wrote: > >>> > >>> On 12/10/20 11:27 PM, Bin Meng wrote: > On

[PATCH v5 6/6] riscv: Enable watchdog for the k210

2020-12-22 Thread Sean Anderson
This enables the necessary config options. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v1) board/sipeed/maix/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/board/sipeed/maix/Kconfig b/board/sipeed/maix/Kconfig index 4c42dd2087..95fe6d9706 100644

[PATCH v5 5/6] riscv: Add watchdog bindings for the k210

2020-12-22 Thread Sean Anderson
This adds the necessary bindings. Most of them are already there. Signed-off-by: Sean Anderson Acked-by: Rick Chen --- (no changes since v2) Changes in v2: - Move watchdog enable to k210.dtsi as it does not depend on anything board-specific. arch/riscv/dts/k210.dtsi | 1 - 1 file changed,

[PATCH v5 0/6] wdt: Add support for watchdogs on Kendryte K210

2020-12-22 Thread Sean Anderson
This series depends on https://patchwork.ozlabs.org/project/uboot/list/?series=200642 Changes in v5: - Rebase on u-boot/master Changes in v4: - Fix build error without CONFIG_CLK Changes in v3: - Note dependency on "time: Fix get_ticks being non-monotonic" - Add a few signed-off-bys which were s

[PATCH v5 4/6] wdt: dw: Free the clock on error

2020-12-22 Thread Sean Anderson
The clock subsystem requires that clk_free be called on clocks obtained via clk_get_*. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v4) Changes in v4: - Fix build error without CONFIG_CLK drivers/watchdog/designware_wdt.c | 18 +- 1 file changed

[PATCH v5 3/6] wdt: dw: Enable the clock before using it

2020-12-22 Thread Sean Anderson
The watchdog won't work if the clock isn't enabled. Fixes: cf89ef8d10f240554541c20b2e1bdcdd58d1d7e6 Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v1) drivers/watchdog/designware_wdt.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/watchdog/design

[PATCH v5 2/6] wdt: dw: Switch to if(CONFIG()) instead of using #if

2020-12-22 Thread Sean Anderson
This is preferred over #if because the compiler can check syntax even if the feature is disabled. This cannot be used for CONFIG_CLK because CONFIG_DW_WDT_CLOCK_KHZ is not defined on all platforms. Signed-off-by: Sean Anderson Reviewed-by: Heinrich Schuchardt --- (no changes since v1) drivers

[PATCH v5 1/6] wdt: dw: Switch to using fls for log2

2020-12-22 Thread Sean Anderson
log_2_n_round_up is only found in arm. fls performs the same job and is generic. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v2) Changes in v2: - Fix fls being off-by-one when compared to log_2_n_round_up drivers/watchdog/designware_wdt.c | 3 +-- 1 file chang

[PATCH v2] riscv: Add support for SPI on Kendryte K210

2020-12-22 Thread Sean Anderson
This enables configs necessary for using SPI. The environment is saved to the very end of SPI flash. This is unlikely to be overwritten unless the entire flash is reprogrammed. This also supplies a default bootcommand. It loads an image and device tree from the first partition of the MMC. This is

[PATCH v2 8/8] spl: fit: Load devicetree when a Linux payload is found

2020-12-22 Thread Alexandru Gagniuc
When a FIT config specifies a devicetree, we should load it, no questions asked. In the case of the "simple" FIT loading path, a difficulty arises in selecting the load address of the FDT. The default FDT location is right after the "kernel" or "firmware" image. However, if that is an OP-TEE image

[PATCH v2 7/8] spl: fit: Replace #ifdef blocks with more readable constructs

2020-12-22 Thread Alexandru Gagniuc
Use the IS_ENABLED() macro to control code flow, instead of the caveman approach of sprinkling #ifdefs. Code size is not affected, as the linker garbage-collects unused functions. However, readability is improved significantly. Signed-off-by: Alexandru Gagniuc Reviewed-by: Simon Glass --- commo

[PATCH v2 6/8] image: Do not #if guard board_fit_config_name_match() prototype

2020-12-22 Thread Alexandru Gagniuc
There's no point in guarding function prototypes with #ifdefs. If a function is not defined, the linker will notice. Having the prototype does not affect code size. What the #if guard takes away is the ability to use IS_ENABLED: if (CONFIG_IS ENABLED(FIT_IMAGE_POST_PROCESS))

[PATCH v2 5/8] spl: fit: Only look up FIT configuration node once

2020-12-22 Thread Alexandru Gagniuc
The configuration node a sub node under "/configurations", which describes the components to load from "/images". We only need to locate this node once. However, for each component, spl_fit_get_image_name() would parse the FIT image, looking for the correct node. Such work duplication is not neces

[PATCH v2 4/8] spl: fit: Remove useless loop in spl_fit_get_image_name()

2020-12-22 Thread Alexandru Gagniuc
When a desired configuration is not found, conf_node will have a negative value. Thus the for loop will start at the root "/" node of the image, print the "/description" property, and stop. It appears the intent of the loop was to print the names of the subnodes under "/configurations". We would n

[PATCH v2 3/8] spl: fit: Pass FIT context via a structure pointer

2020-12-22 Thread Alexandru Gagniuc
Several loose arguments describe the FIT image. They are thus related, and it makes sense to pass them together, in a structure. Examples include the FIT blob pointer, offset to FDT nodes, and the offset to external data. Use a spl_fit_info structure to group these parameters. Signed-off-by: Alex

[PATCH v2 2/8] spl: fit: Factor out FIT parsing and use a context struct

2020-12-22 Thread Alexandru Gagniuc
The logical steps in spl_load_simple_fit() are difficult to follow. I think the long comments, ifdefs, and ungodly number of variables seriously affect the readability. In particular, it violates section 6 of the coding style, paragraphs (3), and (4). The purpose of this patch is to improve the si

[PATCH v2 1/8] spl: fit: Drop 'length' argument to board_spl_fit_post_load()

2020-12-22 Thread Alexandru Gagniuc
The size is derived from the FIT image itself. Any alignment requirements are machine-specific and known by the board code. Thus the total length can be derived from the FIT image and knowledge of the platform. The 'length' argument is redundant. Remove it. Signed-off-by: Alexandru Gagniuc Review

[PATCH v2 0/8] spl: fit: Play nicely with OP-TEE and Linux

2020-12-22 Thread Alexandru Gagniuc
This patch series is part of a larger effort to get linux to boot really fast alongside a secure OS. One piece of the puzzle is getting Linux and OP-TEE to boot straight from SPL. This is where the FIT image comes in. The "simple" fit code was mostly ready for this, although it was quite difficult

[PATCH v1] riscv: Add support for SPI on Kendryte K210

2020-12-22 Thread Sean Anderson
This enables configs necessary for using SPI. The environment is saved to the very end of SPI flash. This is unlikely to be overwritten unless the entire flash is reprogrammed. This also supplies a default bootcommand. It loads an image and device tree from the first partition of the MMC. This is

Re: patman regression?

2020-12-22 Thread Sean Anderson
On 12/11/20 11:29 AM, Simon Glass wrote: Hi Bin, On Thu, 10 Dec 2020 at 21:37, Bin Meng wrote: On Fri, Dec 11, 2020 at 12:32 PM Sean Anderson wrote: On 12/10/20 11:27 PM, Bin Meng wrote: On Fri, Dec 11, 2020 at 12:08 PM Bin Meng wrote: Hi Simon, The following command no longer works.

Re: [v5 09/18] mmc: dwmmc: socfpga: Add ATF support for MMC driver

2020-12-22 Thread Jaehoon Chung
On 12/22/20 1:49 AM, Siew Chin Lim wrote: > From: Chee Hong Ang > > In non-secure mode (EL2), MMC driver calls the SMC/PSCI services > provided by ATF to set SDMMC's DRVSEL and SMPLSEL. > > Signed-off-by: Chee Hong Ang > Signed-off-by: Siew Chin Lim Reviewed-by: Jaehoon Chung Best Regards,

Re: [v5 08/18] mmc: dwmmc: Change designware MMC 'clksel' callback function to return status

2020-12-22 Thread Jaehoon Chung
On 12/22/20 1:49 AM, Siew Chin Lim wrote: > Change 'clksel' callback function to allow the code to return a > status. > > This patch is a preparation for enabling Arm-Trusted-Firmware (ATF) > in Intel SoC FPGA. This patch does not change functionality. > > When using Arm-Trusted-Firmware (ATF) in

Re: [PATCH v2 5/6] mmc: actions: add MMC driver for Actions OWL S700

2020-12-22 Thread Jaehoon Chung
On 12/19/20 11:51 PM, Amit Singh Tomar wrote: > From: Amit Singh Tomar > > This commit adds support for MMC controllers found on Actions OWL > S700 SoC platform. > > Signed-off-by: Amit Singh Tomar > --- > Changes since previous version > * Corrected block count to 512. > * Changed

Re: [PATCH v2 4/6] ARM: dts: s700: add MMC/SD controller node

2020-12-22 Thread Jaehoon Chung
On 12/19/20 11:51 PM, Amit Singh Tomar wrote: > From: Amit Singh Tomar > > This patch adds node for ethernet controller found on Action Semi OWL > S700 SoC. Is "ethernet controller" right? > > Since, upstream Linux binding has not been merged for S700 MMC/SD > controller, Changes are put in u-

[PATCH 2/2] arm: dart6ul: read and print SoM info from eeprom on startup

2020-12-22 Thread ferlandm
From: Marc Ferland The dart6ul has an i2c eeprom at 0x50 which contains, among other things, the manufacturing/revision/options info of the SoM. This patch replaces the current checkboard() implementation with a more exhaustive one based on the content of the eeprom. Since this code uses the new

[PATCH 1/2] arm: dart6ul: change compatible string for eeprom

2020-12-22 Thread ferlandm
From: Marc Ferland The eeprom at address 0x50 is a BR24G04NUX-3TTR. It has a 4Kbit (512x8) capacity, change the compatible string to reflect this fact. Also, add an alias to easily refer to this eeprom with fdt_path_offset() which will be in another commit. Signed-off-by: Marc Ferland --- arc

[PATCH] doc: qemu-riscv: Fix opensbi build instructions

2020-12-22 Thread Atish Patra
Latest opensbi uses generic platform for Qemu. Update the build instructions. Signed-off-by: Atish Patra --- doc/board/emulation/qemu-riscv.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/board/emulation/qemu-riscv.rst b/doc/board/emulation/qemu-riscv.rst index 3acd4

Re: [PATCH v6 00/28] Add DM support for omap PWM backlight

2020-12-22 Thread Dario Binacchi
Hi Lokesh, > Il 22/12/2020 14:52 Lokesh Vutla ha scritto: > > > Hi Dario, > > On 22/11/20 9:41 pm, Dario Binacchi wrote: > > > > The series was born from the need to manage the PWM backlight of the > > display connected to my beaglebone board. To hit the target, I had to > > develop drivers

Re: [PATCH v2 6/6] cmd: Add MBR partition layout control utility

2020-12-22 Thread Heinrich Schuchardt
On 12/22/20 3:09 PM, Marek Szyprowski wrote: Add a 'mbr' command to let user create or verify MBR partition layout based on the provided text description. The partition layout is altearnatively read from 'mbr_parts' environment variable. This can be used in scripts to help system image flashing t

[PATCH v7 7/7] doc: board: Add Microchip MPFS Icicle Kit doc

2020-12-22 Thread Padmarao Begari
This doc describes the procedure to build, flash and boot Linux using U-boot on Microchip MPFS Icicle Kit. Signed-off-by: Padmarao Begari Reviewed-by: Anup Patel Reviewed-by: Bin Meng --- doc/board/index.rst | 1 + doc/board/microchip/index.rst | 9 + doc/board/microc

[PATCH v7 5/7] riscv: dts: Add device tree for Microchip Icicle Kit

2020-12-22 Thread Padmarao Begari
Add device tree for Microchip PolarFire SoC Icicle Kit. Signed-off-by: Padmarao Begari Reviewed-by: Anup Patel Reviewed-by: Bin Meng --- arch/riscv/dts/Makefile | 1 + .../dts/microchip-mpfs-icicle-kit-u-boot.dtsi | 14 + arch/riscv/dts/microchip-mpfs-icicle-kit.dts |

[PATCH v7 6/7] riscv: Add Microchip MPFS Icicle Kit support

2020-12-22 Thread Padmarao Begari
This patch adds Microchip MPFS Icicle Kit support. For now, only NS16550 Serial, Microchip clock, Cadence eMMC and MACB drivers are enabled. The Microchip MPFS Icicle defconfig by default builds U-Boot for S-Mode because U-Boot on Microchip PolarFire SoC will run in S-Mode as payload of HSS + OpenS

[PATCH v7 3/7] net: macb: Add phy address to read it from device tree

2020-12-22 Thread Padmarao Begari
Read phy address from device tree and use it to find the phy device if not found then search in the range of 0 to 31. Signed-off-by: Padmarao Begari Reviewed-by: Anup Patel Reviewed-by: Bin Meng Tested-by: Bin Meng --- drivers/net/macb.c | 13 + 1 file changed, 13 insertions(+) d

[PATCH v7 2/7] net: macb: Add DMA 64-bit address support for macb

2020-12-22 Thread Padmarao Begari
Enable 32-bit or 64-bit DMA in the macb driver based on the macb hardware compatibility and it is configured with structure macb_config in the driver. The Microchip PolarFire SoC Memory Protection Unit(MPU) gives the 64-bit DMA access with the GEM, the MPU transactions on the AXI bus is 64-bit not

[PATCH v7 4/7] clk: Add Microchip PolarFire SoC clock driver

2020-12-22 Thread Padmarao Begari
Add clock driver code for the Microchip PolarFire SoC. This driver handles reset and clock control of the Microchip PolarFire SoC device. Signed-off-by: Padmarao Begari Reviewed-by: Anup Patel Tested-by: Bin Meng --- drivers/clk/Kconfig | 1 + drivers/clk/Makefile

[PATCH v7 0/7] Microchip PolarFire SoC support

2020-12-22 Thread Padmarao Begari
This patch set adds Microchip PolarFire SoC Icicle Kit support to RISC-V U-Boot. The patches are based upon latest U-Boot tree (https://gitlab.denx.de/u-boot/u-boot.git) at commit id c15f44acf9d473f4682bfdc63b8aebd313492b15 All drivers namely: NS16550 Serial, Microchip clock, Cadence eMMC and Cad

  1   2   >