RE: [PATCH v2 1/3] dm: core: Add of_match_node helper function

2020-11-03 Thread Biju Das
Hi Simon, Thanks for the feedback. > Subject: Re: [PATCH v2 1/3] dm: core: Add of_match_node helper function > > On Mon, 2 Nov 2020 at 08:10, Biju Das wrote: > > > > Add of_match_node() helper function to iterate over the device tree > > and tell if a device_node has a matching of_match structu

Re: [PATCH 1/1] riscv: enable SATA disk on qemu-riscv64_defconfig

2020-11-03 Thread Bin Meng
Hi Heinrich, On Wed, Nov 4, 2020 at 3:26 PM Heinrich Schuchardt wrote: > > On 11/4/20 3:45 AM, Bin Meng wrote: > > On Wed, Nov 4, 2020 at 10:44 AM Bin Meng wrote: > >> > >> Hi Heinrich, > >> > >> On Mon, Nov 2, 2020 at 7:37 PM Heinrich Schuchardt > >> wrote: > >>> > >>> Allow attaching a virtu

Re: [PATCH 1/1] riscv: enable SATA disk on qemu-riscv64_defconfig

2020-11-03 Thread Heinrich Schuchardt
On 11/4/20 3:45 AM, Bin Meng wrote: > On Wed, Nov 4, 2020 at 10:44 AM Bin Meng wrote: >> >> Hi Heinrich, >> >> On Mon, Nov 2, 2020 at 7:37 PM Heinrich Schuchardt >> wrote: >>> >>> Allow attaching a virtual SATA disk to qemu-riscv64_defconfig. >>> >>> Signed-off-by: Heinrich Schuchardt >>> --- >

Re: stm32mp: The purpose of "!tee_find_device()"

2020-11-03 Thread Etienne Carriere
On Tue, 3 Nov 2020 at 16:53, Alex G. wrote: > > On 10/30/20 3:28 AM, Etienne Carriere wrote: > > On Thu, 29 Oct 2020 at 15:33, Alex G. wrote: > >> > >> On 9/30/20 6:03 PM, Alex G. wrote: > >>> Hi > >>> > >>> I'm trying to wrap my head around the purpose of the following lines in > >>> ft_system_s

Re: [PATCH] dfu: add DFU_SKIP layout concept

2020-11-03 Thread Minkyu Kang
Hi, On Wed, 4 Nov 2020 at 08:36, Jaehoon Chung wrote: > Add DFU_SKIP layout cencept. > "cencept" -> typo?? > If layout is "skip", it will be skipped after nothing to do. > It's useful to support multiple board with one tar file. > > Signed-off-by: Jaehoon Chung > --- > doc/README.dfu

[RFC] serial: pl01x: add sbsa-uart favor

2020-11-03 Thread AKASHI Takahiro
sbsa-uart is a virtual UART device with a sub-set of PL011 functionality which is described in SBSA (Server Base System Architecture)[1]. It mainly targets for server use, but sbsa-uart itself is useful in any para-virtualized use cases, including Xen. At present, this patch is submitted as RFC b

Re: [PATCH 1/1] riscv: enable SATA disk on qemu-riscv64_defconfig

2020-11-03 Thread Bin Meng
On Wed, Nov 4, 2020 at 10:44 AM Bin Meng wrote: > > Hi Heinrich, > > On Mon, Nov 2, 2020 at 7:37 PM Heinrich Schuchardt wrote: > > > > Allow attaching a virtual SATA disk to qemu-riscv64_defconfig. > > > > Signed-off-by: Heinrich Schuchardt > > --- > > configs/qemu-riscv64_defconfig | 6 ++

Re: [PATCH 1/1] riscv: enable SATA disk on qemu-riscv64_defconfig

2020-11-03 Thread Bin Meng
Hi Heinrich, On Mon, Nov 2, 2020 at 7:37 PM Heinrich Schuchardt wrote: > > Allow attaching a virtual SATA disk to qemu-riscv64_defconfig. > > Signed-off-by: Heinrich Schuchardt > --- > configs/qemu-riscv64_defconfig | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/configs/qemu-ris

Re: [PATCH 1/1] riscv: enable SATA disk on qemu-riscv64_defconfig

2020-11-03 Thread Rick Chen
> From: U-Boot [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Heinrich > Schuchardt > Sent: Monday, November 02, 2020 7:37 PM > To: Bin Meng > Cc: u-boot@lists.denx.de; Heinrich Schuchardt > Subject: [PATCH 1/1] riscv: enable SATA disk on qemu-riscv64_defconfig > > Allow attaching a virtual SA

Re: [PATCH v4 0/7] wdt: Add support for watchdogs on Kendryte K210

2020-11-03 Thread Rick Chen
於 2020年11月4日 週三 上午10:01寫道: > > > > -Original Message- > From: U-Boot [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Sean Anderson > Sent: Friday, October 23, 2020 9:30 PM > To: u-boot@lists.denx.de > Cc: Bin Meng; Marek Vasut; Jagan Teki; Simon Glass; Heinrich Schuchardt > Subject: Re:

Re: [PATCH] riscv: Fix efi header for RV32

2020-11-03 Thread Rick Chen
Hi Atish > From: U-Boot [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Heinrich > Schuchardt > Sent: Wednesday, October 14, 2020 9:16 AM > To: Bin Meng; Atish Patra > Cc: U-Boot Mailing List; Anup Patel; Jagan Teki; Marek Vasut; Simon > Goldschmidt; David Abdurachmanov; Tom Rini > Subject: R

Re: [PATCH v4 13/13] smbios: Drop the unused Kconfig options

2020-11-03 Thread Bin Meng
Hi Simon, On Thu, Oct 22, 2020 at 10:23 PM Simon Glass wrote: > > Now that we can use devicetree to specify this information, drop the old > CONFIG options. > > Signed-off-by: Simon Glass > --- > > (no changes since v3) > > Changes in v3: > - Add onto the sysinfo binding > > configs/clearfog_gt

[PATCH] dfu: add DFU_SKIP layout concept

2020-11-03 Thread Jaehoon Chung
Add DFU_SKIP layout cencept. If layout is "skip", it will be skipped after nothing to do. It's useful to support multiple board with one tar file. Signed-off-by: Jaehoon Chung --- doc/README.dfu| 10 +- drivers/dfu/dfu.c | 2 +- drivers/dfu/dfu_mmc.c | 9 + include/

Re: [PATCH v3 5/8] sandbox: implement reset

2020-11-03 Thread Simon Glass
On Tue, 27 Oct 2020 at 13:29, Heinrich Schuchardt wrote: > > Up to now the sandbox would shutdown upon a cold reset request. Instead it > should be reset. > > In our coding we use static variables like LIST_HEAD(efi_obj_list). A reset > can occur at any time, e.g. via an UEFI binary calling the re

Re: [PATCH v3 2/8] sandbox: enable poweroff command

2020-11-03 Thread Simon Glass
The command to shut down a device is 'poweroff'. It is a deficit of the sandbox that it does not support resetting yet but shuts down upong seeing the 'reset' command. Once the sandbox properly supports reset we need the 'poweroff' command to leave the sandbox. Signed-off-by: Heinrich Schuchardt

Re: [PATCH v3 06/29] patman: Fix remaining pylint3 warnings in func_test

2020-11-03 Thread Simon Glass
This fixes all but the ones about too many variables/statements. Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/func_test.py | 76 +-- 1 file changed, 58 insertions(+), 18 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v3 01/29] patman: Correct operation of -n

2020-11-03 Thread Simon Glass
This operation was unfortunately broken by a recent change. It is now necessary to use -i in addition to -n, if there are errors or warnings in the patches. Correct this by always showing the summary information. Fixes: f3653759758 ("patman: Move main code out to a control module") Signed-off-by:

Re: [PATCH v3 05/29] patman: Use capture_sys_output() consistently

2020-11-03 Thread Simon Glass
One test still uses its own function for capturing output. Modify it to use the standard one in test_util Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/func_test.py | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v3 07/29] patman: Allow linking a series with patchwork

2020-11-03 Thread Simon Glass
Add a new Series-links tag to tell patman how to find the series in patchwork. Each item is the series ID optionally preceded by the series version that the link refers to. An empty version indicates this is the latest series. For example: Series-links: 209816 1:203302 Documentation is added

Re: [PATCH v3 16/29] patman: Convert 'Series-xxx' tag errors into warnings

2020-11-03 Thread Simon Glass
If the Series-xxx tag is not recognised patman currently reports a fatal error. This is inconvenient if a new feature is later added to patman that an earlier version does not support. Report a warning instead, to allow the user to take action if needed, but still allow operation to proceed. Sign

Re: [PATCH v3 1/8] sandbox: eth-raw: do not close the console input

2020-11-03 Thread Simon Glass
When the sandbox eth-raw device host_lo is removed this leads to closing the console input. Do not call close(0). Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass --- v3: no change v2: no change --- arch/sandbox/cpu/eth-raw-os.c | 8 arch/sandbox/cpu/os.c

Re: [PATCH v3 26/29] patman: Support checking for review tags in patchwork

2020-11-03 Thread Simon Glass
Before sending out a new version of a series for review, it is important to add any review tags (e.g. Reviewed-by, Acked-by) collected by patchwork. Otherwise people waste time reviewing the same patch repeatedly, become frustrated and stop reviewing your patches. To help with this, add a new 'sta

Re: [PATCH v3 19/29] patman: Add some tests for warnings

2020-11-03 Thread Simon Glass
Add tests that check that warnings are generated when expected. Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/func_test.py | 111 +--- tools/patman/main.py| 16 +- tools/patman/patchstream.py | 2 +- 3 files changed, 116 inse

Re: [PATCH] binman: Call helper function binman_set_rom_offset() to fill offset

2020-11-03 Thread Simon Glass
On Wed, 26 Aug 2020 at 07:13, Michal Simek wrote: > > There is prepared function for filing rom_offset. That's why use it instead > of copying content of it. > > Signed-off-by: Michal Simek > --- > > lib/binman.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass

Re: [PATCH v3 7/8] sandbox: update function descriptions in os.h

2020-11-03 Thread Simon Glass
Hi Heinrich, On Mon, 2 Nov 2020 at 17:13, Heinrich Schuchardt wrote: > > Am 3. November 2020 01:06:00 MEZ schrieb Simon Glass : > >Hi Heinrich, > > > >On Tue, 27 Oct 2020 at 13:29, Heinrich Schuchardt > >wrote: > >> > >> Use Sphinx style function descriptions. > >> > >> Signed-off-by: Heinrich S

Re: [PATCH v3 22/29] patman: Don't ignore lines starting with hash

2020-11-03 Thread Simon Glass
These lines can indicate a continuation of an error and should not be ignored. Fix this. Fixes: 666eb15e923 ("patman: Handle checkpatch output with notes and code") Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/checkpatch.py | 7 +-- 1 file changed, 5 insertions(+), 2

Re: [PATCH] binman: Fix typo in kernel-doc format for binman_symname()

2020-11-03 Thread Simon Glass
Hi Michal, On Mon, 2 Nov 2020 at 02:32, Michal Simek wrote: > > Hi Simon, > > út 1. 9. 2020 v 17:34 odesílatel Simon Glass napsal: > > > > On Wed, 26 Aug 2020 at 07:34, Michal Simek wrote: > > > > > > Fix typo. > > > > > > Fixes: 19790632648b ("binman: Support accessing binman tables at run >

Re: [PATCH v3 8/8] doc: add sandbox API

2020-11-03 Thread Simon Glass
On Tue, 27 Oct 2020 at 13:29, Heinrich Schuchardt wrote: > > Add sandbox API to generated HTML documentation > > Signed-off-by: Heinrich Schuchardt > --- > v3: > no change > v2: > new patch > --- > doc/api/index.rst | 1 + > doc/api/sandbox.rst | 9 + > 2 files changed,

Re: [PATCH v3 3/8] test/py: test poweroff

2020-11-03 Thread Simon Glass
It is the 'poweroff' and not the 'reset' command that should shut down the sandbox. Adjust the unit test accordingly Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass --- v3: no change v2: no change --- test/py/tests/test_sandbox_exit.py | 8 1 file changed,

Re: [PATCH v3 6/8] test: adjust sysreset tests

2020-11-03 Thread Simon Glass
As we have a working COLD_RESET on the sandbox the sysreset test has to be adjusted. Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass --- v3: no change v2: no change --- test/dm/sysreset.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) Applied to u

Re: [PATCH v3 04/29] patman: Fix whitespace errors in func_test

2020-11-03 Thread Simon Glass
Fix up various indentation and other minor things to make pylint3 happier. Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/func_test.py | 37 +++-- 1 file changed, 19 insertions(+), 18 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v3 4/8] sandbox: use O_CLOEXEC in os_open()

2020-11-03 Thread Simon Glass
On Tue, 27 Oct 2020 at 13:29, Heinrich Schuchardt wrote: > > During a cold reset execv() is used to relaunch the U-Boot binary. > We must ensure that all files are closed in this case. > > Signed-off-by: Heinrich Schuchardt > --- > v3: > no change > v2: > new patch > --- > arch/s

Re: [PATCH 1/2] binman: Update intel_ifwi to store padded section

2020-11-03 Thread Simon Glass
With a recent change this entry stores only part of the section data, leaving out the padding at the end. Fix this by using GetPaddedData() to get the data. Add this function to the base Entry class also. Fixes: d1d3ad7d1fe ("binman: Move section padding to the parent") Signed-off-by: Simon Glass

Re: [PATCH v3 03/29] patman: Update how tests are run

2020-11-03 Thread Simon Glass
The current instructions are out-of-date. Fix them. Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/README | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v3 02/29] azure/gitLab/travis: Add pygit2 as a dependency for tests

2020-11-03 Thread Simon Glass
This lets patman run all of its tests, rather than skipping quite a few. Signed-off-by: Simon Glass --- (no changes since v1) .azure-pipelines.yml | 2 +- .gitlab-ci.yml | 2 +- .travis.yml | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v3 12/29] patman: Drop unused args in patchstream

2020-11-03 Thread Simon Glass
Drop a few arguments that are not used in functions. Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/patchstream.py | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v3 11/29] patman: Rename variables in patchstream

2020-11-03 Thread Simon Glass
Some variables are too short or shadow other variables or types. Fix these to keep pylint3 happy. Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/patchstream.py | 52 ++--- 1 file changed, 26 insertions(+), 26 deletions(-) Applied to u-boot-dm

Re: [PATCH v3 09/29] patman: Fix constant style in patchstream

2020-11-03 Thread Simon Glass
These constants should use upper case. Update them to keep pylint3 happy. Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/patchstream.py | 44 ++--- 1 file changed, 22 insertions(+), 22 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v3 08/29] patman: Fix indenting in patchstream

2020-11-03 Thread Simon Glass
Update the indenting to keep pylint3 happy. Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/patchstream.py | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v3 10/29] patman: Rename functions in patchstream

2020-11-03 Thread Simon Glass
Rename these functions to lower case as per PEP8. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 6 +-- tools/patman/control.py | 6 +-- tools/patman/func_test.py | 6 +-- tools/patman/patchstream.py | 88

Re: [PATCH v3 29/29] patman: Support listing comments from patchwork

2020-11-03 Thread Simon Glass
While reviewing feedback it is helpful to see the review comments on the command line to check that each has been addressed. Add an option to support that. Update the workflow documentation to describe the new features. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Many

Re: [PATCH v3 13/29] patman: Fix up argument/return docs in patchstream

2020-11-03 Thread Simon Glass
Add missing documentation and type information. Fix up some missing docs on exceptions also. Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/patchstream.py | 82 ++--- 1 file changed, 50 insertions(+), 32 deletions(-) Applied to u-boot-dm, tha

Re: [PATCH v3 28/29] patman: Support parsing of review snippets

2020-11-03 Thread Simon Glass
Add support for parsing the contents of a patchwork 'patch' web page containing comments received from reviewers. This allows patman to show these comments in a simple 'snippets' format. A snippet is some quoted code plus some unquoted comments below it. Each review is from a unique person/email a

Re: [PATCH v3 18/29] patman: Add a test for PatchStream tags

2020-11-03 Thread Simon Glass
The current functional tests run most of patman. Add a smaller test that just checks tag handling with the PatchStream class. Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/func_test.py | 26 +- tools/patman/patchstream.py | 23 +

Re: [PATCH v3 14/29] patman: Move warning collection to a function

2020-11-03 Thread Simon Glass
Add a new function in PatchStream to collect the warnings generated while parsing the stream. This will allow us to adjust the logic, such as dealing with per-commit warnings. Two of the warnings are in fact internal errors, so change them to raise and exception. Signed-off-by: Simon Glass ---

Re: [PATCH v3 15/29] patman: Attach warnings to individual patches

2020-11-03 Thread Simon Glass
At present warnings are produced across the whole set of patches when parsing them. It is more useful to associate each warning with the patch (or commit) that generated it. Attach warnings to the Commit object and move them out of PatchStream. Also avoid generating duplicate warnings for the same

Re: [PATCH v3 21/29] patman: Fix spelling of plural for warning

2020-11-03 Thread Simon Glass
Tidy up the extra 's' when there is only a single warning. Fix the empty print statement also. Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/patchstream.py | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v3 20/29] patman: Convert testBasic() to use an interator

2020-11-03 Thread Simon Glass
On balance it is easier to use an iterator here, particularly if we need to insert lines due to new functionality. The only niggle is the need to keep the previous iterator value around in one case. Convert this test to use iter(). Signed-off-by: Simon Glass --- (no changes since v1) tools/pa

Re: [PATCH v3 24/29] patman: Improve handling of files

2020-11-03 Thread Simon Glass
Sometimes warnings are associated with a file and sometimes with the patch as a whole. Update the regular expression to handle both cases, even in emacs mode. Also add support for detecting new files. Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/checkpatch.py | 11

Re: [PATCH v3 23/29] patman: Allow showing a Commit as a string

2020-11-03 Thread Simon Glass
Use the subject of the Commit object when printing it out. Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/commit.py | 3 +++ 1 file changed, 3 insertions(+) Applied to u-boot-dm, thanks!

Re: [PATCH v3 17/29] patman: Drop unused signoff member

2020-11-03 Thread Simon Glass
This is not used. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/func_test.py | 1 + tools/patman/patchstream.py | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) Applied to u-boot-dm, thanks!

Re: [PATCH v3 27/29] patman: Support updating a branch with review tags

2020-11-03 Thread Simon Glass
It is tedious to add review tags into the local branch and errors can sometimes be made. Add an option to create a new branch with the review tags obtained from patchwork. Signed-off-by: Simon Glass --- Changes in v3: - Allow tags to be inserted in the middle of the commit message tools/patman

Re: [PATCH 2/2] binman: Correct calculation for image-pos

2020-11-03 Thread Simon Glass
A recent change removed the base offset from the calculation. This is used on coral to find the FSP-S binary. Fix it. Fixes: a9fad07d4b8 ("binman: Avoid reporting image-pos with compression") Signed-off-by: Simon Glass --- tools/binman/entry.py | 2 +- 1 file changed, 1 insertion(+), 1 deletio

Re: [PATCH v3 25/29] patman: Detect missing upstream in CountCommitsToBranch

2020-11-03 Thread Simon Glass
At present if we fail to find the upstream then the error output is piped to wc, resulting in bogus results. Avoid the pipe and check the output directly. Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/func_test.py | 19 +++ tools/patman/gitutil.py | 10 +++

Re: [PATCH 1/1] test: linking test/compression.c fails

2020-11-03 Thread Simon Glass
On Sat, 31 Oct 2020 at 01:59, Heinrich Schuchardt wrote: > > Building U-Boot with unit tests on a non-sandbox systems fails: > > ld.bfd: test/built-in.o: in function `compress_using_gzip': > test/compression.c:138: undefined reference to `gzip' > ld.bfd: test/built-in.o: in function `uncompress_us

Re: [PATCH 1/1] test: test/bloblist.c depends on asm/state.h

2020-11-03 Thread Simon Glass
On Sat, 31 Oct 2020 at 01:38, Heinrich Schuchardt wrote: > > Building test/bloblist.c fails for non sandbox devices: > > test/bloblist.c:10:10: fatal error: asm/state.h: No such file or directory > #include > ^ > > Build the test only on the sandbox. > > Signed-off-by: Hein

Re: [PATCH] mmc: fsl_esdhc_imx: optimize the timing setting

2020-11-03 Thread Jaehoon Chung
On 11/3/20 6:18 PM, haibo.c...@nxp.com wrote: > From: Haibo Chen > > For imx usdhc/esdhc, once set the DDR_EN, enable the DDR mode, the > card clock will be divied by 2 automatically by the host. So need > to first config the DDR_EN correctly, then update the card clock. > This will make sure the

Re: [PATCH] mmc: atmel-sdhci: fix the clk_enable call in case of no ops

2020-11-03 Thread Jaehoon Chung
On 11/3/20 9:33 PM, Eugen Hristev wrote: > If the clock driver does not offer a clk_enable ops, then the system will > return -ENOSYS. > The clk_enable works with CCF (common clock framework). > Some clocks in some cases (like the generic clock for some products: sama5d2) > do not have the clk_enab

[PATCH 5/7] patman: Allow specifying the patchwork URL

2020-11-03 Thread Simon Glass
Add a new argument to allow the URL of the patchwork server to be speciified. For now this is hard-coded in the main file, but future patches will move it to the settings file. Signed-off-by: Simon Glass --- tools/patman/control.py | 5 +++-- tools/patman/func_test.py | 38 ++

[PATCH 7/7] patman: Add a Series-patchwork-url option

2020-11-03 Thread Simon Glass
Add a commit tag to allow the Patchwork URL to be specified in a commit. This can be handy for when you submit code to multiple projects but don't want to use the -p option. Signed-off-by: Simon Glass --- tools/patman/README | 6 ++ tools/patman/control.py | 7 ++- tools/patman/seri

[PATCH 6/7] patman: Add a setting for the Patchwork URL

2020-11-03 Thread Simon Glass
Add an argument to allow specifying the the patchwork URL. This also adds this feature to the settings file, either globally, or on a per-project basis. Signed-off-by: Simon Glass --- tools/patman/README | 1 + tools/patman/main.py | 6 -- 2 files changed, 5 insertions(+), 2 deletions(-)

[PATCH 3/7] patman: Fix-up for plural warning

2020-11-03 Thread Simon Glass
This should be squashed into: patman: Fix spelling of plural for warning Signed-off-by: Simon Glass --- tools/patman/patchstream.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/patman/patchstream.py b/tools/patman/patchstream.py index b8cb6163182..cdcd50a84

[PATCH 4/7] patman: Update defaults in subparsers

2020-11-03 Thread Simon Glass
At present values from the settings file are only applied to the main parser. With the new parser structure this means that some settings are ignored. Update the implementation to set defaults across the main parser and all subparsers. Also fix up the comments, since ArgumentParser is being used n

[PATCH 1/7] patman: Refactor how the default subcommand works

2020-11-03 Thread Simon Glass
At present patman tries to assume a default subcommand of 'send', to maintain backwards compatibility. However it does not cope with arguments added to the default command, so for example 'patman -t' does not work. Update the logic to handle this. Also update the CC command to use 'send' explicitl

[PATCH 2/7] patman: Correct Change-Ids error message args

2020-11-03 Thread Simon Glass
The arguments of this error are incorrectly formatted. Fix it. Signed-off-by: Simon Glass --- tools/patman/patchstream.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/patman/patchstream.py b/tools/patman/patchstream.py index d8dcf8c4561..b8cb6163182 100644 --- a

[PATCH 0/7] patman: Minor improvements to 'patman status'

2020-11-03 Thread Simon Glass
This series builds on the previous one which added a new 'status' subcommand to patman. With this, the patchwork URL can be specified in the settings file, a commit tag or the command line. Some other minor improvements are included also. Both series are available at u-boot-dm/patman-working Si

[PATCH] ARM: dts: stm32: Add DHCOM based PicoITX board

2020-11-03 Thread Marek Vasut
Add DT for DH PicoITX unit, which is a bare-bones carrier board for the DHCOM. The board has ethernet port, USB, CAN, LEDs and a custom board-to-board expansion connector. Signed-off-by: Marek Vasut Cc: Patrice Chotard Cc: Patrick Delaunay --- arch/arm/dts/Makefile | 1

[PATCH] mmc: atmel-sdhci: fix the clk_enable call in case of no ops

2020-11-03 Thread Eugen Hristev
If the clock driver does not offer a clk_enable ops, then the system will return -ENOSYS. The clk_enable works with CCF (common clock framework). Some clocks in some cases (like the generic clock for some products: sama5d2) do not have the clk_enable primitive, and in this case probing of the drive

Re: [PATCH 10/10] setexpr: Add support for strings

2020-11-03 Thread Marek Behun
On Tue, 3 Nov 2020 08:12:17 -0700 Simon Glass wrote: > Hi Marek, > > On Sun, 1 Nov 2020 at 16:08, Marek Behun wrote: > > > > What is the purpose of + operator on strings? > > Can't we use setenv "${a}${b}" ? > > Yes, that does the same thing, although it is a bit clumsy. > > setenv a *10 >

Re: Speed/mode setting via "sf probe" command

2020-11-03 Thread Tom Rini
On Wed, Oct 28, 2020 at 11:46:07AM -0400, Ralph Siemsen wrote: > Dear maintainers, > > Any thoughts on this? It seems that "sf probe" behaviour should either get > fixed, or we should remove the "hz" and "mode" arguments entirely, since > they don't work anymore. This does sound like something t

Re: [PATCH] env: sf: fix init function behaviour

2020-11-03 Thread Tom Rini
On Tue, Nov 03, 2020 at 03:22:36PM +0100, Heiko Schocher wrote: > Michael wrote: > commit 92765f45bb95 ("env: Access Environment in SPI flashes before > relocation") at least breaks the Kontron sl28 board. I guess it also > breaks others which use a (late) SPI environment. > > reason is, that env

Re: stm32mp: The purpose of "!tee_find_device()"

2020-11-03 Thread Alex G.
On 10/30/20 3:28 AM, Etienne Carriere wrote: On Thu, 29 Oct 2020 at 15:33, Alex G. wrote: On 9/30/20 6:03 PM, Alex G. wrote: Hi I'm trying to wrap my head around the purpose of the following lines in ft_system_setup(): if (!CONFIG_IS_ENABLED(OPTEE) || !tee_find_device(NULL,

Re: [PATCH] binman: Fix typo in kernel-doc format for binman_symname()

2020-11-03 Thread Simon Glass
Hi Michal, On Mon, 2 Nov 2020 at 02:32, Michal Simek wrote: > > Hi Simon, > > út 1. 9. 2020 v 17:34 odesílatel Simon Glass napsal: > > > > On Wed, 26 Aug 2020 at 07:34, Michal Simek wrote: > > > > > > Fix typo. > > > > > > Fixes: 19790632648b ("binman: Support accessing binman tables at run >

Re: [PATCH v2 2/2] rockchip: gru: Allow setting up clocks in U-Boot proper

2020-11-03 Thread Simon Glass
On Tue, 27 Oct 2020 at 15:15, Alper Nebi Yasak wrote: > > Commit fe974716326c ("rockchip: rk3288: Allow setting up clocks in > U-Boot proper") fixes some clock issues when chainloading U-Boot on > rk3288 chromebooks. Part of that change is still available in veyron's > board_early_init_r() functio

Re: [PATCH v2 05/21] mips: enable _machine_restart for spl

2020-11-03 Thread Simon Glass
On Fri, 30 Oct 2020 at 03:34, Weijie Gao wrote: > > The sysreset driver has a config CONFIG_SPL_SYSRESET for the spl stage. > Change CONFIG_SYSRESET to CONFIG_IS_ENABLED(SYSRESET) will give spl a > chance to use _machine_restart instead of the sysreset driver. > > Signed-off-by: Weijie Gao > ---

Re: [PATCH 1/2] rtc: use probe() to initialize emulated RTC

2020-11-03 Thread Simon Glass
On Thu, 29 Oct 2020 at 21:20, Heinrich Schuchardt wrote: > > Currently the emulated RTC is initialized in the emul_rtc_get() get > function. This does not match the design of the driver model. > > Move the initialization of the emulated RTC to the probe() function. > > Signed-off-by: Heinrich Schu

Re: CONFIG_SPL_UNIT_TEST

2020-11-03 Thread Simon Glass
Hi Heinrich, On Sat, 31 Oct 2020 at 00:47, Heinrich Schuchardt wrote: > > Hello Simon, > > CONFIG_SPL_UNIT_TEST can be selected for non-sandboard boards. > > How would the tests be executed here? I don't have a mechanism for that at present. We can't use a command in SPL and of course we can't u

Re: [PATCH v5 18/27] misc: am33xx: add control module driver

2020-11-03 Thread Simon Glass
Hi Dario, On Sun, 1 Nov 2020 at 02:13, Dario Binacchi wrote: > > Hi Simon, > > > Il 28/10/2020 03:10 Simon Glass ha scritto: > > > > > > On Sun, 25 Oct 2020 at 06:40, Dario Binacchi wrote: > > > > > > The implementation of this driver was needed to bind the device tree > > > sub-nodes of the 'c

Re: [PATCH v2 2/3] dm: soc: Add SoC id for attribute matching

2020-11-03 Thread Simon Glass
Hi Biju, On Mon, 2 Nov 2020 at 08:10, Biju Das wrote: > > Add SoC identification string for attribute matching. > Also changed the comments from "an SOC" to "an SoC". Please put this second bit in a separate patch, perhaps before this one in the series. Otherwise it looks good to me. > Signed

Re: [PATCH v2 1/3] dm: core: Add of_match_node helper function

2020-11-03 Thread Simon Glass
On Mon, 2 Nov 2020 at 08:10, Biju Das wrote: > > Add of_match_node() helper function to iterate over the device tree > and tell if a device_node has a matching of_match structure. > > Signed-off-by: Biju Das > Reviewed-by: Lad Prabhakar > --- > v1->v2: > * No Change. > Ref: > https://patchw

Re: [PATCH 2/2] rtc: initialize emulated RTC from environment variable

2020-11-03 Thread Simon Glass
On Thu, 29 Oct 2020 at 21:20, Heinrich Schuchardt wrote: > > Up to now the emulated RTC is initialized using the U-Boot build time. > > With this patch the environment variable 'rtc_emul_epoch' can be used to > provide a better initial time. The variable is a decimal string with > the number of se

Re: [PATCH 10/25] binman: Move section-building code into a function

2020-11-03 Thread Simon Glass
Hi Alper, On Mon, 26 Oct 2020 at 17:20, Alper Nebi Yasak wrote: > > On 26/10/2020 22:22, Simon Glass wrote: > > On Mon, 19 Oct 2020 at 15:29, Alper Nebi Yasak > > wrote: > >> On 19/10/2020 05:41, Simon Glass wrote: > >>> for entry in self._entries.values(): > >>> data = en

Re: [PATCH 1/1] test: test/bloblist.c depends on asm/state.h

2020-11-03 Thread Simon Glass
On Sat, 31 Oct 2020 at 01:38, Heinrich Schuchardt wrote: > > Building test/bloblist.c fails for non sandbox devices: > > test/bloblist.c:10:10: fatal error: asm/state.h: No such file or directory > #include > ^ > > Build the test only on the sandbox. > > Signed-off-by: Hein

Re: [PATCH 10/10] setexpr: Add support for strings

2020-11-03 Thread Simon Glass
Hi Marek, On Sun, 1 Nov 2020 at 16:08, Marek Behun wrote: > > What is the purpose of + operator on strings? > Can't we use setenv "${a}${b}" ? Yes, that does the same thing, although it is a bit clumsy. setenv a *10 setenv b *100 setenv c "${a}${b}" instead of setexpr c *10 + *100 Regards, S

Re: test/Kconfig

2020-11-03 Thread Simon Glass
Hi Heinrich, On Sat, 31 Oct 2020 at 01:14, Heinrich Schuchardt wrote: > > Hello Simon, > > since your patch > > ba96be48ad34180debcfbc11434be7329d530701 > dm: test: Build tests for SPL > > test/Kconfig is a bit in disarray. > > menuconfig UNIT_TEST marks a submenu. But there is no submenu anymore

Re: [PATCH 1/1] test: linking test/compression.c fails

2020-11-03 Thread Simon Glass
On Sat, 31 Oct 2020 at 01:59, Heinrich Schuchardt wrote: > > Building U-Boot with unit tests on a non-sandbox systems fails: > > ld.bfd: test/built-in.o: in function `compress_using_gzip': > test/compression.c:138: undefined reference to `gzip' > ld.bfd: test/built-in.o: in function `uncompress_us

Re: [PATCH] cros_ec: Support keyboard scanning with EC_CMD_GET_NEXT_EVENT

2020-11-03 Thread Simon Glass
On Fri, 30 Oct 2020 at 11:25, Alper Nebi Yasak wrote: > > The cros_ec_keyb driver currently uses EC_CMD_MKBP_STATE to scan the > keyboard, but this host command was superseded by EC_CMD_GET_NEXT_EVENT > and unavailable on more recent devices (including gru-kevin), as it was > removed in cros-ec co

Re: [PATCH v2 1/2] rockchip: rk3399: Init clocks in U-Boot proper if SPL was not run

2020-11-03 Thread Simon Glass
On Tue, 27 Oct 2020 at 15:15, Alper Nebi Yasak wrote: > > It's possible to chainload U-Boot proper from the vendor firmware in > rk3399 chromebooks, but the way the vendor firmware sets up clocks is > somehow different than what U-Boot expects. This causes the display to > stay devoid of content e

Re: [PATCH v2 10/21] serial: add uart driver for MediaTek MT7620 SoC

2020-11-03 Thread Simon Glass
On Fri, 30 Oct 2020 at 03:34, Weijie Gao wrote: > > This patch adds uart support for MediaTek MT7620 and earlier SoCs. > > The UART used by MT7620 is incompatible with the ns16550a driver. > All registers of this UART have different addresses. A special 16-bit > register for Divisor Latch is used

Re: [PATCH 2/3] acpi: Only include asm header when available

2020-11-03 Thread Simon Glass
On Fri, 30 Oct 2020 at 02:45, Harm Berntsen wrote: > > The only platforms with an asm/acpi_table.h file are X86 and Sandbox. > Some drivers, i.e. pci_mmc.c, can generate ACPI info and therefore > include asm/acpi_table.h by proxy. This commit ensures that the > platforms wishing to use such driver

Re: [PATCH v4 07/27] rockchip: Enable building a SPI ROM image on bob

2020-11-03 Thread Simon Glass
Hi Hugh, On Wed, 14 Oct 2020 at 12:37, Hugh Cole-Baker wrote: > > Hello, > > On 11 Oct 2020, at 16:39, Emmanuel Vadot wrote: > > > > > > Hi Simon, > > > > On Sun, 19 Jul 2020 13:55:58 -0600 > > Simon Glass wrote: > > > >> Add a simple binman config and enable CONFIG_HAS_ROM so that U-Boot > >>

Re: [PATCH 3/3] mmc: Only retrieve cd pin when GPIO is enabled

2020-11-03 Thread Simon Glass
Hi Harm, On Fri, 30 Oct 2020 at 02:45, Harm Berntsen wrote: > > The driver only needs to retrieve the pin for the ACPI info. The driver > itself works without depending on GPIO. > > Signed-off-by: Harm Berntsen > CC: Simon Glass > > --- > > drivers/mmc/pci_mmc.c | 2 ++ > 1 file changed, 2 ins

Re: [PATCH] spl: fit: Prefer a malloc()'d buffer for loading images

2020-11-03 Thread Simon Glass
+Tom Rini too On Wed, 21 Oct 2020 at 17:33, Alexandru Gagniuc wrote: > > Fit images were loaded to a buffer provided by spl_get_load_buffer(). > This may work when the FIT image is small and fits between the start > of DRAM and SYS_TEXT_BASE. > > One problem with this approach is that the locati

Re: [PATCH 11/11] bootm: Support string substitution in bootargs

2020-11-03 Thread Simon Glass
Hi Wolfgang, On Thu, 22 Oct 2020 at 06:32, Wolfgang Denk wrote: > > Dear Simon, > > In message > you > wrote: > > > > Well my series does that to a large extent. It is much more like bootm > > now, in that it is properly split into stages. I think it would be > > possible to combine parts of i

Re: [PATCH] spl: spl_fit.c: enable check of signature for config node in spl/tpl

2020-11-03 Thread Simon Glass
On Thu, 29 Oct 2020 at 11:50, Philippe Reynes wrote: > > This commit add the support of signature check for config node > in spl/tpl when the function spl_load_simple_fit is used. > > Signed-off-by: Philippe Reynes > --- > common/spl/spl_fit.c | 10 ++ > 1 file changed, 10 insertions(+)

Re: [PATCH v3 09/23] test: log: Convert log_test from python to C

2020-11-03 Thread Simon Glass
On Sat, 17 Oct 2020 at 12:08, Sean Anderson wrote: > > When rebasing this series I had to renumber all my log tests because > someone made another log test in the meantime. This involved updaing a > number in several places (C and python), and it wasn't checked by the > compiler. So I though "how

Re: [PATCH v3 10/23] test: log: Give tests names instead of numbers

2020-11-03 Thread Simon Glass
On Sat, 17 Oct 2020 at 12:08, Sean Anderson wrote: > > Now that the log test command is no more, we can give the log tests proper > names. > > Signed-off-by: Sean Anderson > --- > > Changes in v3: > - New > > test/log/log_test.c | 48 ++--- > 1 file change

Re: [PATCH v3 19/23] test: Add a test for getopt

2020-11-03 Thread Simon Glass
On Sat, 17 Oct 2020 at 12:08, Sean Anderson wrote: > > A few of these tests were inspired by those in glibc. The syntax for > invoking test_getopt is a bit funky, but it's necessary so that the CPP can > parse the arguments correctly. > > Signed-off-by: Sean Anderson > --- > > (no changes since v

Re: [PATCH v3 18/23] lib: Add getopt

2020-11-03 Thread Simon Glass
On Sat, 17 Oct 2020 at 12:08, Sean Anderson wrote: > > Some commands can get very unweildy if they have too many positional > arguments. Adding options makes them easier to read, remember, and > understand. > > This implementation of getopt has been taken from barebox, which has had > option suppo

Re: [PATCH 2/2] video: simple_panel: Add boe,nv101wxmn51 display

2020-11-03 Thread Simon Glass
On Tue, 27 Oct 2020 at 15:42, Alper Nebi Yasak wrote: > > Add "boe,nv101wxmn51" to the compatible node. This is the panel for > chromebook_bob. > > Signed-off-by: Alper Nebi Yasak > --- > I didn't test this as I don't have a gru-bob, but this panel is listed > among Linux's simple-panel compatibl

  1   2   >