Hi Biju, On Mon, 2 Nov 2020 at 08:10, Biju Das <biju.das...@bp.renesas.com> wrote: > > Add SoC identification string for attribute matching. > Also changed the comments from "an SOC" to "an SoC".
Please put this second bit in a separate patch, perhaps before this one in the series. Otherwise it looks good to me. > Signed-off-by: Biju Das <biju.das...@bp.renesas.com> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad...@bp.renesas.com> > --- > v1->v2: Changed the comments from "a SoC" to "an SoC" > Ref: > https://patchwork.ozlabs.org/project/uboot/patch/20201030140724.12773-1-biju.das...@bp.renesas.com/ > --- > drivers/soc/soc-uclass.c | 19 ++++++++++++++++++- > drivers/soc/soc_sandbox.c | 8 ++++++++ > include/soc.h | 39 +++++++++++++++++++++++++++++++++------ > test/dm/soc.c | 8 ++++++++ > 4 files changed, 67 insertions(+), 7 deletions(-) >