Re: [U-Boot] [PATCH] Fix unreliable detection of DRAM size on Orange Pi 3

2019-08-24 Thread Ondřej Jirman
Hi Jagan, can you please apply this patch to the sunxi tree, so that it doesn't get lost. thank you, Ondrej On Mon, Jul 29, 2019 at 01:39:42AM +0200, megous hlavni wrote: > From: Ondrej Jirman > > Orange Pi 3 has 2 GiB of DRAM, that sometime get misdetected > as 4 GiB, due to false neg

[U-Boot] [PATCH] Kconfig: Varios: Fix more SPL, TPL dependencies

2019-08-24 Thread Adam Ford
Several options are presenting themselves on a various boards where the options are clearly not used. (ie, SPL/TPL options when SPL or TPL are not defined) This patch is not attempting to be a complete list of items, but more like low hanging fruit. In some instances, I wasn't sure of DM was req

Re: [U-Boot] [PATCH V2] Convert CONFIG_FSL_USDHC to Kconfig

2019-08-24 Thread Tom Rini
On Wed, Aug 14, 2019 at 07:23:43AM -0500, Adam Ford wrote: > This converts the following to Kconfig: >CONFIG_FSL_USDHC > > Signed-off-by: Adam Ford Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot ma

Re: [U-Boot] [PATCH] Convert CONFIG_MX_CYCLIC to Kconfig

2019-08-24 Thread Tom Rini
On Wed, Aug 14, 2019 at 07:54:34AM -0500, Adam Ford wrote: > This converts the following to Kconfig: >CONFIG_MX_CYCLIC > > Signed-off-by: Adam Ford > Acked-by: David Lechner > > diff --git a/cmd/Kconfig b/cmd/Kconfig > index 041de1d831..05872fa0d7 100644 Applied to u-boot/master, thanks!

Re: [U-Boot] Pull request: u-boot-rockchip-20190823

2019-08-24 Thread Tom Rini
On Sat, Aug 24, 2019 at 08:27:30AM +0800, Kever Yang wrote: > Hi Tom, > > Please pull the rockchip update: > - remove rk3288 fennec board > - remove SPL raw image support for Rockchip SoCs > - add common misc_init_r() for ethaddr from cpuid > - enable USB HOST support for rk3328 > - unify code fo

Re: [U-Boot] [PATCH] Kconfigs: Various: Fix some SPL, TPL and ARM64 dependencies

2019-08-24 Thread Tom Rini
On Tue, Aug 13, 2019 at 02:32:30PM -0500, Adam Ford wrote: > Several options are presenting themselves on a various boards > where the options are clearly not used. (ie, arm64 options on > arm9, or SPL/TPL options when SPL or TPL are not defined) > > This patch is not attempting to be a complete

Re: [U-Boot] [PATCH] kconfig: Convert CONFIG_MXS_GPIO to Kconfig

2019-08-24 Thread Tom Rini
On Tue, Aug 13, 2019 at 06:10:39PM +0200, Lukasz Majewski wrote: > This converts the following to Kconfig: >CONFIG_MXS_GPIO > > Travis-CI: https://travis-ci.org/lmajewski/u-boot-dfu/builds/571260789 > > Signed-off-by: Lukasz Majewski > Acked-by: Peng Fan > Acked-by: Jagan Teki Applied to

Re: [U-Boot] [GIT] Pull request: u-boot-clk (22.08.2019)

2019-08-24 Thread Tom Rini
On Thu, Aug 22, 2019 at 05:14:57PM +0200, Lukasz Majewski wrote: > Dear Tom, > > Please find a PR for u-boot-clk branch: > > The following changes since commit > 753e5385ca6d0fe5b5f5a3a97cc96b0f2469ca94: Can you please provide at least a summary in the future, if not a tag? > > test/py: Add

Re: [U-Boot] [PATCH] sunxi: H6: DRAM: Add support for half DQ

2019-08-24 Thread Thomas Graichen
hi jernej, On Mon, Aug 19, 2019 at 8:29 PM Jernej Škrabec wrote: > > +CC: Thomas > > Dne četrtek, 18. julij 2019 ob 00:16:17 CEST je Jernej Skrabec napisal(a): > > Half DQ configuration seems to be very rare for H6 based boards/STBs, > > but exists nevertheless. Currently the only known product w

[U-Boot] [PATCH] mailmap: Update mail address

2019-08-24 Thread Ricardo Ribalda Delgado
Update my email address from gmail to my domain. Signed-off-by: Ricardo Ribalda Delgado --- .mailmap | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.mailmap b/.mailmap index dc72f24688..63afce3774 100644 --- a/.mailmap +++ b/.mailmap @@ -31,8 +31,8 @@ Markus Klotzbuecher

[U-Boot] [PATCH] cmd: pxe: Use internal FDT if external one cannot be retrieved

2019-08-24 Thread Anton Leontiev
From: Anton Leontiev Original commit c61d94d86035 ("pxe: implement fdtdir extlinux.conf tag") states, that if FDT file cannot be retrieved then FDT packaged in firmware should be used. If FDT file cannot be retrieved and it is specified explicitly using FDT keyword then the label is skipped. If

[U-Boot] [PATCH v2 03/10] x86: Create a new fsp_arch.h header

2019-08-24 Thread Simon Glass
At present fsp_support.h includes fsp_vpd.h which is an FPSv1 concept (VPD means Vital Product Data). For FSPv2 only UPD (Updatable Product Data) is used. To avoid mangling header files, put these two includes in a separate header which we can adjust as necessary for FSPv2. Signed-off-by: Simon G

[U-Boot] [PATCH v2 02/10] x86: Move fsp_azalia.h to the generic fsp directory

2019-08-24 Thread Simon Glass
This header file is the same for FSP v1 and v2. Move it into the general fsp directory. Signed-off-by: Simon Glass --- Changes in v2: - Rewrite to make azalia a common file for FSP1 and FSP2 arch/x86/include/asm/{fsp1 => fsp}/fsp_azalia.h | 0 arch/x86/include/asm/fsp1/fsp_support.h |

[U-Boot] [PATCH v2 04/10] x86: Move fsp_api.h inclusion out of fsp_support.h

2019-08-24 Thread Simon Glass
This header file is different for each version of FSP. Move it into the fsp_arch.h header file. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None arch/x86/include/asm/fsp1/fsp_support.h | 1 - arch/x86/include/asm/fsp_arch.h | 1 + 2 files changed, 1 insertion(+

[U-Boot] [PATCH v2 08/10] x86: Move fsp_infoheader.h to the generic fsp directory

2019-08-24 Thread Simon Glass
This header file is the same for FSP v1 and v2. Move it into the general fsp directory. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None arch/x86/include/asm/fsp1/fsp_support.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/include/asm/fsp

[U-Boot] [PATCH v2 09/10] x86: Move fsp_bootmode.h to the generic fsp directory

2019-08-24 Thread Simon Glass
This header file is the same for FSP v1 and v2, although there may be some additions to come. Move it into the generic fsp directory. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None arch/x86/include/asm/{fsp1 => fsp}/fsp_bootmode.h | 0 arch/x86/include/asm/fsp1/fsp_s

[U-Boot] [PATCH v2 07/10] x86: Move fsp_hob.h to the generic fsp directory

2019-08-24 Thread Simon Glass
This header file is the same for FSP v1 and v2. Move it into the general fsp directory. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None arch/x86/include/asm/{fsp1 => fsp}/fsp_hob.h| 0 arch/x86/include/asm/{fsp1 => fsp}/fsp_infoheader.h | 0 arch/x86/include/a

[U-Boot] [PATCH v2 10/10] x86: Move fsp_ffs.h include to fsp_arch.h

2019-08-24 Thread Simon Glass
This include file is only used for FSP v1. Avoid including it from fdt_support.h so we can use the latter with FSP v2. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None arch/x86/include/asm/fsp_arch.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/include/

[U-Boot] [PATCH v2 06/10] x86: Move fsp_fv.h to the generic fsp directory

2019-08-24 Thread Simon Glass
This header file is the same for FSP v1 and v2. Move it into the general fsp directory. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None arch/x86/include/asm/{fsp1 => fsp}/fsp_fv.h | 0 arch/x86/include/asm/fsp1/fsp_support.h | 2 +- 2 files changed, 1 insertion(+)

[U-Boot] [PATCH v2 05/10] x86: Move fsp_types.h to the generic fsp directory

2019-08-24 Thread Simon Glass
This header file is the same for FSP v1 and v2. Move it into the general fsp directory. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v2: None arch/x86/include/asm/{fsp1 => fsp}/fsp_types.h | 0 arch/x86/include/asm/fsp1/fsp_support.h| 2 +- 2 files changed, 1 insert

[U-Boot] [PATCH v2 01/10] x86: Rename existing FSP code to fsp1

2019-08-24 Thread Simon Glass
Since there is now a new version of the FSP and it is incompatible with the existing version, move the code into an fsp1 directory. This will allow us to put FSP v2 code into an fsp2 directory. Add a Kconfig which defines which version is in use. Some of the code in this new fsp1/ directory is ge

[U-Boot] [PATCH v2 00/10] x86: Prepare for adding FSP2 code

2019-08-24 Thread Simon Glass
At present the x86 FSP (Firmware Support Package) code assumes that FSP version 1 is used. Since this code was added to U-Boot a new version (FSP2) has been produced by Intel. In preparation for adding support for FSP2, move the existing code into a directory that indicates it is used for FSP1. C

[U-Boot] [PATCH 18/34] binman: Use the Makefile for u_boot_binman_syms_bad

2019-08-24 Thread Simon Glass
Remove this file from git and instead build it using the Makefile. Signed-off-by: Simon Glass --- tools/binman/elf_test.py | 4 ++-- tools/binman/test/Makefile | 2 +- tools/binman/test/u_boot_binman_syms_bad | Bin 4890 -> 0 bytes 3 files changed, 3 insertions

[U-Boot] [PATCH 24/34] binman: Increase size of TPL and SPL test data

2019-08-24 Thread Simon Glass
At present these are large enough to hold 20 bytes of symbol data. Add four more bytes so we can add another test. Unfortunately at present this involves changing a few test files to make room. We could adjust the test files to not specify sizes for entries. Then we could make the tests check the

[U-Boot] [PATCH 20/34] binman: Allow symbols to be resolved inside sections

2019-08-24 Thread Simon Glass
At present we only support symbols inside binaries which are at the top level of an image. This restrictions seems unreasonable since more complex images may want to group binaries within different sections. Relax the restriction. Also fix a typo in the comment for testTpl(). Signed-off-by: Simo

[U-Boot] [PATCH 14/34] binman: Use the Makefile for u_boot_ucode_ptr

2019-08-24 Thread Simon Glass
Remove this file from git and instead build it using the Makefile. Update tools.GetInputFilename() to support reading files from an absolute path, so that we can read the Elf test files easily. Also make sure that the temp directory is report in ELF tests as this was commented out. Signed-off-by:

[U-Boot] [PATCH 26/34] binman: Correct symbol calculation with non-zero image base

2019-08-24 Thread Simon Glass
At present binman adds the image base address to the symbol value before it writes it to the binary. This is not correct since the symbol value itself (e.g. image position) has no relationship to the image base. Fix this and update the tests to cover this case. Signed-off-by: Simon Glass --- t

[U-Boot] [PATCH 31/34] binman: Support writing symbols into entries within an IFWI

2019-08-24 Thread Simon Glass
The Intel IFWI (Integrated Firmware Image) is effectively a section with other entries inside it. Support writing symbol information into entries within it. Signed-off-by: Simon Glass --- tools/binman/etype/intel_ifwi.py | 5 + 1 file changed, 5 insertions(+) diff --git a/tools/binman/etyp

[U-Boot] [PATCH 23/34] binman: Avoid needing the section size in advance

2019-08-24 Thread Simon Glass
Entries which include a section and need to obtain its contents call GetData(), as with any other entry. But the current implementation of this method in entry_Section requires the size of the section to be known. If it is unknown, an error is produced, since size is None: TypeError: can't mult

[U-Boot] [PATCH 17/34] binman: Use the Makefile for u_boot_binman_syms_size

2019-08-24 Thread Simon Glass
Remove this file from git and instead build it using the Makefile. Signed-off-by: Simon Glass --- tools/binman/elf_test.py | 5 +++-- tools/binman/ftest.py | 2 +- tools/binman/test/u_boot_binman_syms_size | Bin 4825 -> 0 bytes 3 files changed, 4 insert

[U-Boot] [PATCH 07/34] binman: Correct use of 'replace' in IFWI tests

2019-08-24 Thread Simon Glass
At present the Intel IFWI entry uses 'replace' without the 'ifwi-' prefix. This is a fairly generic name which might conflict with the main Entry base class at some point, if more features are added. Add a prefix. Signed-off-by: Simon Glass --- tools/binman/README.entries | 6

[U-Boot] [PATCH 27/34] binman: Add support for Intel FSP meminit

2019-08-24 Thread Simon Glass
The Intel FSP supports initialising memory early during boot using a binary blob called 'fspm'. Add support for this. Signed-off-by: Simon Glass --- tools/binman/README.entries | 17 + tools/binman/etype/intel_fsp_m.py | 27 +++ tools/binman

[U-Boot] [PATCH 06/34] binman: Handle hidden symbols in ELF files

2019-08-24 Thread Simon Glass
Some versions of binutils generate hidden symbols which are currently not parsed by binman. Correct this. Signed-off-by: Simon Glass --- tools/binman/elf.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/binman/elf.py b/tools/binman/elf.py index c7ef74ce7d..66cfe796a2

[U-Boot] [PATCH 12/34] binman: Use tools.Run() to run objdump

2019-08-24 Thread Simon Glass
At present this command silently fails if something goes wrong. Use the tools.Run() function instead, since it reports errors. Signed-off-by: Simon Glass --- tools/binman/elf.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/binman/elf.py b/tools/binman/elf.py index 6

[U-Boot] [PATCH 30/34] binman: Update IFWI entry to support updates

2019-08-24 Thread Simon Glass
Add support for the ProcessContents() method in this entry so that it is possible to support entries which change after initial creation. Signed-off-by: Simon Glass --- tools/binman/etype/intel_ifwi.py | 46 +++- 1 file changed, 28 insertions(+), 18 deletions(-) dif

[U-Boot] [PATCH 33/34] binman: Add logging for the number of pack passes

2019-08-24 Thread Simon Glass
Sometimes binman takes multiple passes to complete packing an image. Add logging to indicate this. Signed-off-by: Simon Glass --- tools/binman/control.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/binman/control.py b/tools/binman/control.py index 07dffbd89c..d1ca798cfb 100644 ---

[U-Boot] [PATCH 22/34] binman: Rename some two-digit test files

2019-08-24 Thread Simon Glass
Two of the test files somehow were not converted to three digits. Fix them, using the next available numbers. Signed-off-by: Simon Glass --- tools/binman/ftest.py | 4 ++-- ...rt_together.dts => 098_4gb_and_skip_at_start_together.dts} | 0 ...g_resetvec.d

[U-Boot] [PATCH 11/34] binman: Fix IFWI output when using an Intel FIT image

2019-08-24 Thread Simon Glass
At present this entry does not work correctly when a FIT image is used as the input. It updates the FIT instead of the output image. The test passed because the FIT image happened to have the right data already. Fix it. Signed-off-by: Simon Glass --- tools/binman/etype/intel_ifwi.py | 6 +++---

[U-Boot] [PATCH 16/34] binman: Use the Makefile for u_boot_binman_syms

2019-08-24 Thread Simon Glass
Remove this file from git and instead build it using the Makefile. With this change a few things need to be adjusted: 1. The 'notes' section no-longer appears at the start of the ELF file (before the code), so update testSymbols to adjust the offsets. 2. The dynamic linker is disabled to avoid e

[U-Boot] [PATCH 08/34] binman: Add support for an x86 'reset' section

2019-08-24 Thread Simon Glass
At present binman has a single entry type for the 16-bit code code needed to start up an x86 processor. This entry is intended to include both the reset vector itself as well as the code to move to 32-bit mode. However this is not very flexible since in some cases other data needs to be included a

[U-Boot] [PATCH 28/34] binman: Fix entry comment for Intel descriptor

2019-08-24 Thread Simon Glass
This comment references another entry type. Fix it. Signed-off-by: Simon Glass --- tools/binman/etype/intel_descriptor.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/binman/etype/intel_descriptor.py b/tools/binman/etype/intel_descriptor.py index fb5e889ebf..b64779

[U-Boot] [PATCH 10/34] binman: Add support for Intel FIT

2019-08-24 Thread Simon Glass
A Firmware Image Table (FIT) is a data structure defined by Intel which contains information about various things needed by the SoC, such as microcode. Add support for this entry as well as the pointer to it. The contents of FIT are fixed at present. Future work is needed to support adding microco

[U-Boot] [PATCH 15/34] binman: Use the Makefile for u_boot_no_ucode_ptr

2019-08-24 Thread Simon Glass
Remove this file from git and instead build it using the Makefile. Signed-off-by: Simon Glass --- tools/binman/elf_test.py | 2 +- tools/binman/ftest.py | 10 +- tools/binman/test/u_boot_no_ucode_ptr | Bin 4182 -> 0 bytes 3 files changed, 6 insertions(+)

[U-Boot] [PATCH 34/34] binman: Drop comment-out code in testUpdateFdtOutput()

2019-08-24 Thread Simon Glass
This code is not needed so drop it. Signed-off-by: Simon Glass --- tools/binman/ftest.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/binman/ftest.py b/tools/binman/ftest.py index b0b942dfdc..0a66369cbd 100644 --- a/tools/binman/ftest.py +++ b/tools/binman/ftest.py @@ -1669,8 +166

[U-Boot] [PATCH 29/34] binman: Update IFWI entry to read entries outside constructor

2019-08-24 Thread Simon Glass
At present this class reads its entries in the constructor. This is not how things should be done now. Update it. Signed-off-by: Simon Glass --- tools/binman/etype/intel_ifwi.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/binman/etype/intel_ifwi.py b/tools/binman/etype/intel_if

[U-Boot] [PATCH 21/34] binman: Use underscore in test filenames

2019-08-24 Thread Simon Glass
At present a small number of test files use hyphens instead of underscores. Rename them for consistency. Signed-off-by: Simon Glass --- tools/binman/ftest.py | 28 +-- .../test/{029_x86-rom.dts => 029_x86_rom.dts} | 0 ...no-desc.dts => 030_x86_rom_me_no

[U-Boot] [PATCH 25/34] binman: Allow support for writing a size symbol to binaries

2019-08-24 Thread Simon Glass
It is useful to be able to access the size of an image in SPL, with something like: binman_sym_declare(unsigned long, u_boot_any, size); ... ulong u_boot_size = binman_sym(ulong, u_boot_any, size); Add support for this and update the tests. Signed-off-by: Simon Glass --- tools/binman/elf_

[U-Boot] [PATCH 32/34] binman: Write symbol info before image inclusion

2019-08-24 Thread Simon Glass
At present the symbol information is written to binaries just before binman exits. This is fine for entries within sections since the section contents is calculated when it is needed, so the updated symbol values are included in the image that is written. However some binaries are inside entries w

[U-Boot] [PATCH 19/34] binman: Clean up unnecessary code related to ELF test files

2019-08-24 Thread Simon Glass
We use the Makefile for all ELF test files now, so drop all the code that checks whether to get the test file from the Makefile or from the git repo. Also add a comment to the Makefile indicating that it is run from binman. Signed-off-by: Simon Glass --- tools/binman/elf_test.py | 5 + t

[U-Boot] [PATCH 02/34] patman: Update command.Run() to handle failure better

2019-08-24 Thread Simon Glass
At present tools are not expected to fail. If they do an exception is raised but there is no detail about what went wrong. This makes it hard to debug if something does actually go wrong. Fix this by outputting both stderr and stdout on failure. Signed-off-by: Simon Glass --- tools/patman/tool

[U-Boot] [PATCH 13/34] binman: Use the Makefile to build ELF test files

2019-08-24 Thread Simon Glass
At present the ELF test files are checked into the U-Boot tree. This is covenient since the files never change and can be used on non-x86 platforms. However it is not good practice to check in binaries and in this case it does not seem essential. Update the binman test-file Makefile to support hav

[U-Boot] [PATCH 09/34] binman: x86: Separate out 16-bit reset and init code

2019-08-24 Thread Simon Glass
At present these two sections of code are linked together into a single 2KB chunk in a single file. Some Intel SoCs like to have a FIT (Firmware Interface Table) in the ROM and the pointer for this needs to go at 0xffc0 which is in the middle of these two sections. Make use of the new 'reset'

[U-Boot] [PATCH 05/34] binman: Drop .note section from ELF

2019-08-24 Thread Simon Glass
Recent versions of binutils add a '.note.gnu.property' into the ELF file. This is not required and interferes with the expected output. Drop it. Also fix testMakeElf() to use a different file for input and output. Signed-off-by: Simon Glass --- tools/binman/elf.py | 3 +++ tools/binman/el

[U-Boot] [PATCH 04/34] binman: Allow use of help and entry-docs without libfdt

2019-08-24 Thread Simon Glass
At present if libfdt is not available binman can't do anything much. Improve the situation a little. Ideally there should be a test to cover this, but I'm not quite sure how to fake this. Signed-off-by: Simon Glass --- tools/binman/control.py | 10 -- tools/binman/e

[U-Boot] [PATCH 03/34] binman: Use cls instead of self for class methods

2019-08-24 Thread Simon Glass
It is more common to use the name 'cls' for the class object of a class method, to distinguish it from normal methods, which use 'self' Update the binman tests accordingly. Signed-off-by: Simon Glass --- tools/binman/ftest.py | 54 +-- 1 file changed, 27

[U-Boot] [PATCH 01/34] patman: Drop binary parameter

2019-08-24 Thread Simon Glass
Since cros_subprocess use bytestrings now, this feature not needed. Drop it. Signed-off-by: Simon Glass --- tools/patman/cros_subprocess.py | 3 +-- tools/patman/tools.py | 15 +++ 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/tools/patman/cros_subproces

[U-Boot] [PATCH 00/34] binman: Various improvements and tidy-ups

2019-08-24 Thread Simon Glass
This series includes a number of minor improvements to binman, including: - Dropping some test Elf files and building them from source instead - Refactoring of x86 16-bit entries - Support for SPL symbols within sections - Handle the 'notes' sections and hidden symbols in recent binutils - Improve

Re: [U-Boot] [PATCH 3/4] env: add missing header file

2019-08-24 Thread Joris OFFOUGA
Hi Pierre-Jean It's work on my side. Tested-by Joris Offouga Best Regards, Joris Offouga Le ven. 23 août 2019 à 23:05, Pierre-Jean Texier a écrit : > Since commit af95f20 ("env: Create a new file for environment functions"), > a new header file exists. > > So, this commit add a missing heade

Re: [U-Boot] [PATCH 1/4] fw_env: remove duplicated definitions

2019-08-24 Thread Joris OFFOUGA
Hi Pierre-Jean It's work on my side. Tested-by Joris Offouga Best Regards, Joris Offouga Le ven. 23 août 2019 à 23:04, Pierre-Jean Texier a écrit : > Since commit d3716dd ("env: Rename the redundancy flags"), the > definitions of ENV_REDUND_OBSOLETE & ENV_REDUND_ACTIVE was moved > to env.h.

Re: [U-Boot] [PATCH 2/4] fw_env: fix build error

2019-08-24 Thread Joris OFFOUGA
Hi Pierre-Jean It's work on my side. Tested-by Joris Offouga Best Regards, Joris Offouga Le ven. 23 août 2019 à 23:04, Pierre-Jean Texier a écrit : > The following error appears: > > tools/env/fw_env.c:1149:25: error: lvalue required as unary ‘&’ operand > rc = write(fd, &ENV_REDUND_OBSOLE