musb->endpoints[] has array size MUSB_C_NUM_EPS.
We must check array bounds before accessing the array and not afterwards.
Signed-off-by: Heinrich Schuchardt
---
v2
do not move the ep->desc check
---
drivers/usb/musb-new/musb_gadget_ep0.c | 7 ++-
1 file changed, 6 insertions(+), 1 d
No need to initialize variables if the next usage is an assignment.
Signed-off-by: Heinrich Schuchardt
---
v2
add missing semicolon
---
drivers/video/exynos/exynos_dp.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/video/exynos/exynos_dp.c b/dri
On Thu, Feb 15, 2018 at 4:09 PM, Bernhard Messerklinger
wrote:
> Use dm_pci_map_bar function for BAR mapping. This has the advantage
> of clearing BAR flags and and only accepting mapped memory.
>
> Signed-off-by: Bernhard Messerklinger
>
> ---
>
> drivers/mmc/pci_mmc.c | 5 ++---
> 1 file chan
Hi Ivan,
On Sat, Mar 17, 2018 at 8:32 AM, Ivan Gorinov wrote:
> On x86 platforms, U-Boot does not provide Device Tree data to the kernel.
> This prevents the kernel from using the same hardware description.
>
> Make a copy of DTB data with setup_data header and insert new item
> into the the setu
Hi Marek,
The following changes since commit 958ad42b77be9d9a69f059066622ef0c15c603ee:
usb: dwc2: Replace printf, pr_err by dev_info, dev_err (2018-03-19
11:03:46 +0800)
are available in the git repository at:
git://git.denx.de/u-boot-usb.git topic-xhci
for you to fetch changes up to 24b36
On Mon, Mar 19, 2018 at 11:00 AM, Bin Meng wrote:
> On Sun, Mar 18, 2018 at 8:51 PM, Heinrich Schuchardt
> wrote:
>> If fdtdec_next_compatible_subnode() fails it returns a negative value.
>> The check (node <= 0) cannot identify this if node is unsigned.
>>
>> Signed-off-by: Heinrich Schuchardt
On Mon, Mar 19, 2018 at 11:00 AM, Bin Meng wrote:
> On Sun, Mar 18, 2018 at 9:01 PM, Heinrich Schuchardt
> wrote:
>> No need to set a variable to NULL if the next use is an assignment.
>> Do not define variables in the middle of nowhere.
>>
>> Signed-off-by: Heinrich Schuchardt
>> ---
>> drive
On Mon, Mar 19, 2018 at 11:00 AM, Bin Meng wrote:
> On Sun, Mar 18, 2018 at 8:55 PM, Heinrich Schuchardt
> wrote:
>> There is no need to set variables to NULL if they are not used before
>> the next assignment.
>>
>> Signed-off-by: Heinrich Schuchardt
>> ---
>> drivers/usb/host/xhci-keystone.c
On Mon, Mar 19, 2018 at 11:00 AM, Bin Meng wrote:
> On Sun, Mar 18, 2018 at 9:04 PM, Heinrich Schuchardt
> wrote:
>> There is not need to set variables to NULL before an assignment.
>>
>> Signed-off-by: Heinrich Schuchardt
>> ---
>> drivers/usb/host/xhci.c | 4 ++--
>> 1 file changed, 2 insert
On Sun, Mar 18, 2018 at 8:51 PM, Heinrich Schuchardt wrote:
> If fdtdec_next_compatible_subnode() fails it returns a negative value.
> The check (node <= 0) cannot identify this if node is unsigned.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> drivers/usb/host/xhci-exynos5.c | 2 +-
> 1 file c
On Sun, Mar 18, 2018 at 8:55 PM, Heinrich Schuchardt wrote:
> There is no need to set variables to NULL if they are not used before
> the next assignment.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> drivers/usb/host/xhci-keystone.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
On Sun, Mar 18, 2018 at 9:01 PM, Heinrich Schuchardt wrote:
> No need to set a variable to NULL if the next use is an assignment.
> Do not define variables in the middle of nowhere.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> drivers/usb/host/xhci-ring.c | 2 +-
> 1 file changed, 1 insertion(
On Sun, Mar 18, 2018 at 9:04 PM, Heinrich Schuchardt wrote:
> There is not need to set variables to NULL before an assignment.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> drivers/usb/host/xhci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Bin Meng
On 04.02.2018 21:11, Álvaro Fernández Rojas wrote:
> Add support for BCM6318 usbh phy.
>
> v2: use correct phy driver
>
> Álvaro Fernández Rojas (3):
> phy: add support for bcm6318 usbh phy
> mips: bmips: add support for bcm6318 usb
> mips: bmips: add ar-5315 usb support
>
> arch/mips/d
On 04.02.2018 21:10, Álvaro Fernández Rojas wrote:
> Add support for BCM 6328/6362/6368/63268 usbh phy.
>
> v2: use correct phy driver and simplify code.
>
> Álvaro Fernández Rojas (9):
> phy: add support for bcm6368 usbh phy
> mips: bmips: add support for bcm6368 usb
> mips: bmips: add w
On Sun, Mar 18, 2018 at 11:28:20PM +0100, Heinrich Schuchardt wrote:
> It makes no sense to assign a value to 'res' if the next use of the
> variable is an assignment.
>
> Signed-off-by: Heinrich Schuchardt
Reviewed-by: Tom Rini
--
Tom
signature.asc
Description: PGP signature
_
On 04.02.2018 11:19, Álvaro Fernández Rojas wrote:
> Add support for BCM6358 usbh phy.
>
> Álvaro Fernández Rojas (4):
> phy: add support for bcm6358 usbh phy
> mips: bmips: add support for bcm6358 usb
> mips: bmips: add hg556a usb support
> mips: bmips: add nb4-ser usb support
>
> arc
On 04.02.2018 11:18, Álvaro Fernández Rojas wrote:
> Add support for BCM6348 usbh phy.
>
> Álvaro Fernández Rojas (3):
> phy: add support for bcm6348 usbh phy
> mips: bmips: add support for bcm6348 usb
> mips: bmips: add ct-5361 usb support
>
> arch/mips/dts/brcm,bcm6348.dtsi | 20
On 18.03.2018 23:43, Heinrich Schuchardt wrote:
> If we check an index against array bounds, we should do so before
> accessing the array and not afterwards.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> board/micronas/vct/scc.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
a
On 03/19/2018 12:48 AM, Philipp Tomsich wrote:
>> Assigning f_rkusb->reboot_flag twice doesn't make sense.
>>
>> Signed-off-by: Heinrich Schuchardt
>> Acked-by: Philipp Tomsich
>> Reviewed-by: Philipp Tomsich
>> ---
>> drivers/usb/gadget/f_rockusb.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>
> Pointers are never negative. Use macro IS_ERR() for checking.
> cf. rk3288_mipi.c
>
> Signed-off-by: Heinrich Schuchardt
> Acked-by: Philipp Tomsich
> Reviewed-by: Philipp Tomsich
> ---
> drivers/video/rockchip/rk3399_mipi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied
> The patch set dpll settings for 300MHz to values used by binary
> blob[1]. With new values dpll still generate 300MHz clock, but
> EMAC work. Probably with new values dpll generate more stable clock.
>
> dpll on rk3188 provide clocks to DDR and EMAC. With current
> dpll settings EMAC doesn't wor
> If we want to check the duration we need to increment the counter.
>
> Signed-off-by: Heinrich Schuchardt
> Acked-by: Philipp Tomsich
> Reviewed-by: Philipp Tomsich
> ---
> I do not have the hardware for testing. But the current coding is
> obviously flawed.
> ---
> drivers/ram/rockchip/sdra
> The error checking should also catch the case that no range has beeen
> defined.
> syscon_get_first_range() returns NULL if no range is defined.
> cf. rk3399_mipi.c
>
> Signed-off-by: Heinrich Schuchardt
> Acked-by: Philipp Tomsich
> Reviewed-by: Philipp Tomsich
> ---
> I do not possess the h
> Assigning f_rkusb->reboot_flag twice doesn't make sense.
>
> Signed-off-by: Heinrich Schuchardt
> Acked-by: Philipp Tomsich
> Reviewed-by: Philipp Tomsich
> ---
> drivers/usb/gadget/f_rockusb.c | 1 -
> 1 file changed, 1 deletion(-)
>
Applied to u-boot-rockchip, thanks!
___
> Clean the iomux definitions at grf_rk3188.h, and move them into
> pinctrl-driver for resolving the compiling error of redefinition.
>
> Signed-off-by: Alexander Kochetkov
> Acked-by: Philipp Tomsich
> Reviewed-by: Philipp Tomsich
> ---
> arch/arm/include/asm/arch-rockchip/grf_rk3188.h | 380
> Clean the iomux definitions at grf_rk3036.h, and move them into
> pinctrl-driver for resolving the compiling error of redefinition.
>
> Signed-off-by: Alexander Kochetkov
> Acked-by: Philipp Tomsich
> Reviewed-by: Philipp Tomsich
> ---
> arch/arm/include/asm/arch-rockchip/grf_rk3036.h | 409
On Sat, 17 Mar 2018 16:36:14 +
Calvin Johnson wrote:
> It would be good to have this cosmetic change into a separate patch.
Ok. But at this stage I'm at the "Forgive me Lord for I know not what
I do"
> IMO, better place for this definition and associated explanation
> would be above the c
If we check an index against array bounds, we should do so before
accessing the array and not afterwards.
Signed-off-by: Heinrich Schuchardt
---
board/micronas/vct/scc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/board/micronas/vct/scc.c b/board/micronas/vct/scc.c
ind
It makes no sense to assign a value to 'res' if the next use of the
variable is an assignment.
Signed-off-by: Heinrich Schuchardt
---
v2
correct commit message
---
lib/slre.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/slre.c b/lib/slre.c
index e26d344865..969c46a859 100644
On Sun, Mar 18, 2018 at 11:12:10PM +0100, Heinrich Schuchardt wrote:
> It makes to assign a value to 'res' if the next use of the variable is an
> assignment.
I think you meant "It makes no sense to " ...
Thanks (and for all of the other load of fixes you've been posting)!
--
Tom
signature.a
It makes to assign a value to 'res' if the next use of the variable is an
assignment.
Signed-off-by: Heinrich Schuchardt
---
lib/slre.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/slre.c b/lib/slre.c
index e26d344865..969c46a859 100644
--- a/lib/slre.c
+++ b/lib/slre.c
@@ -703,8 +70
On 03/18/2018 10:21 PM, Maxime Ripard wrote:
> Hi,
>
> On Sun, Mar 18, 2018 at 04:20:06PM +0100, Heinrich Schuchardt wrote:
>> doc/driver-model/MIGRATION.txt requires to move block drivers to the
>> the driver model by v2018.05
>>
>> So make the switch for the SUNXI block drivers.
>>
>> Select BLK
Hi,
On Sun, Mar 18, 2018 at 04:20:06PM +0100, Heinrich Schuchardt wrote:
> doc/driver-model/MIGRATION.txt requires to move block drivers to the
> the driver model by v2018.05
>
> So make the switch for the SUNXI block drivers.
>
> Select BLK, DM_MMC, and DM_SCSI.
>
> DM_USB dpends on USB but th
Cause: u-boot/Kconfig DISTRO_DEFAULTS missing variables in Kconfig files
u-boot/ config DISTRO_DEFAULTS contains these directives:
select HUSH_PARSER
select BOOTP_BOOTPATH if NET && CMD_NET
select BOOTP_DNS if NET && CMD_NET
select BOOTP_GATEWAY if NET && CMD_NET
Dear Tom,
In message <20180313121344.gk1...@bill-the-cat.ec.rr.com> you wrote:
>
> We're a day off schedule, but I wanted to see a final comment on one
> last bug fix. So, now, I've released v2018.03 and it's live on git and
> FTP and ACD (along with the PGP sig file).
Sorry for the long delay
Dear Andy,
In message
you wrote:
>
> Is it just not possible for the zImages in RAM to be decoded as per the
> uImages ?
You can decode only the information that is in there. uImage adds
an extra 64 byte header with informnation I considered useful to
have, like names, timestamp, checksum.
Hi,
> Use of CONFIG_UBIFS_SILENCE_MSG was added in
> 147162dac6 ("ubi: ubifs: Turn off verbose prints")
>
> Then it was removed in
> ff94bc40af ("mtd, ubi, ubifs: resync with Linux-3.14")
>
> Cc: Joe Hershberger
> Cc: Heiko Schocher
> Signed-off-by: Petr Vorel
> ---
> Note, not sure whether we
> On 18 Mar 2018, at 18:35, Klaus Goger
> wrote:
>
> Adds devicemodel support to the ISL1208 driver.
> This patch drops the non-dm API as no board was using it anyway.
> Also add it to Kconfig.
>
> Signed-off-by: Klaus Goger
Reviewed-by: Philipp Tomsich
_
On 16-03-18 16:56, David Lechner wrote:
On 03/16/2018 01:26 AM, Mike Looijmans wrote:
On 15-03-18 02:36, David Lechner wrote:
commit 1601dd97edc6 ("davinci: omapl138_lcdk: increase PLL0 frequency")
changed the PLL0 frequency to 456MHz, which is needed for the LCDC IP
block. However, in doing s
The mxsimage utility fails to compile against LibreSSL version < 2.7.0
because LibreSSL says it is OpenSSL 2.0, but it does not support the
complete OpenSSL 1.1 interface.
LibreSSL defines OPENSSL_VERSION_NUMBER with 0x2000L and therefor
claims to have an API compatible with OpenSSL 2.0, but i
Adds devicemodel support to the ISL1208 driver.
This patch drops the non-dm API as no board was using it anyway.
Also add it to Kconfig.
Signed-off-by: Klaus Goger
---
drivers/rtc/Kconfig | 7 +++
drivers/rtc/isl1208.c | 141 ++
2 files chang
> Pointers are never negative. Use macro IS_ERR() for checking.
> cf. rk3288_mipi.c
>
> Signed-off-by: Heinrich Schuchardt
> ---
> drivers/video/rockchip/rk3399_mipi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Philipp Tomsich
_
> Assigning f_rkusb->reboot_flag twice doesn't make sense.
>
> Signed-off-by: Heinrich Schuchardt
> Acked-by: Philipp Tomsich
> ---
> drivers/usb/gadget/f_rockusb.c | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: Philipp Tomsich
___
U-Boot ma
> If we want to check the duration we need to increment the counter.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> I do not have the hardware for testing. But the current coding is
> obviously flawed.
> ---
> drivers/ram/rockchip/sdram_rk3399.c | 1 +
> 1 file changed, 1 insertion(+)
>
Review
> The error checking should also catch the case that no range has beeen
> defined.
> syscon_get_first_range() returns NULL if no range is defined.
> cf. rk3399_mipi.c
>
> Signed-off-by: Heinrich Schuchardt
> ---
> I do not possess the hardware for testing. But the coding is not consistent
> with
> The error checking should also catch the case that no range has beeen
> defined.
> syscon_get_first_range() returns NULL if no range is defined.
> cf. rk3399_mipi.c
>
> Signed-off-by: Heinrich Schuchardt
> ---
> I do not possess the hardware for testing. But the coding is not consistent
> with
> Pointers are never negative. Use macro IS_ERR() for checking.
> cf. rk3288_mipi.c
>
> Signed-off-by: Heinrich Schuchardt
> ---
> drivers/video/rockchip/rk3399_mipi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Philipp Tomsich
__
> rk3066 and rk3188 has two I2C controller implementations.
> Current I2C driver wan't work with legacy implementation.
> Switching between controllers is performed using a bit inside
> GFR_SOC_CON1 register. The bit setting is performed by pinctrl
> driver. The patch ask pinctrl to do settings.
>
> If we want to check the duration we need to increment the counter.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> I do not have the hardware for testing. But the current coding is
> obviously flawed.
> ---
> drivers/ram/rockchip/sdram_rk3399.c | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-
> Assigning f_rkusb->reboot_flag twice doesn't make sense.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> drivers/usb/gadget/f_rockusb.c | 1 -
> 1 file changed, 1 deletion(-)
>
Acked-by: Philipp Tomsich
___
U-Boot mailing list
U-Boot@lists.denx.de
> Signed-off-by: Mark Kettenis
> ---
> include/configs/rk3399_common.h | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Philipp Tomsich
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
> From: Philipp Tomsich
>
> This adds support for the (to date unsupported) I2C controllers 1~4
> and 6~7 (i.e. now all controllers except I2C5, which is not accessible
> on the RK3399-Q7, are supported by pinctrl).
>
> Signed-off-by: Philipp Tomsich
> Tested-by: Klaus Goger
>
> Signed-off-by
> From: Philipp Tomsich
>
> The shift values for GPIO2B1 and GPIO2B2 had in fact referred to
> GPIO2B0 and GPIO2B1, respectively. This substitutes the correct
> values.
>
> Signed-off-by: Philipp Tomsich
> Signed-off-by: Klaus Goger
> Acked-by: Philipp Tomsich
> ---
>
> arch/arm/include/as
On 03/18/2018 03:41 PM, Heinrich Schuchardt wrote:
> On 03/18/2018 01:27 PM, Marek Vasut wrote:
>> On 03/18/2018 01:25 PM, Heinrich Schuchardt wrote:
>>> Assigning a value to ret if it is immediately overwritten does not make
>>> sense.
>>>
>>> Signed-off-by: Heinrich Schuchardt
>>
>> Did you even
On 03/18/2018 03:41 PM, Heinrich Schuchardt wrote:
> On 03/18/2018 01:27 PM, Marek Vasut wrote:
>> On 03/18/2018 01:25 PM, Heinrich Schuchardt wrote:
>>> Assigning a value to ret if it is immediately overwritten does not make
>>> sense.
>>>
>>> Signed-off-by: Heinrich Schuchardt
>>
>> Did you even
doc/driver-model/MIGRATION.txt requires to move block drivers to the
the driver model by v2018.05
So make the switch for the SUNXI block drivers.
Select BLK, DM_MMC, and DM_SCSI.
DM_USB dpends on USB but there is no necessity to make it depend on
DISTRO_DEFAULTS.
Signed-off-by: Heinrich Schucha
On Mon, Mar 12, 2018 at 11:58:33PM +0100, Heinrich Schuchardt wrote:
> Remove a link to a non-existent file.
>
> Signed-off-by: Heinrich Schuchardt
> Acked-by: Andrew F. Davis
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP signature
On Mon, Mar 12, 2018 at 11:40:29PM +0100, Heinrich Schuchardt wrote:
> Remove non-existing paths.
>
> Signed-off-by: Heinrich Schuchardt
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Bo
On Mon, Mar 12, 2018 at 11:02:17PM +0100, Heinrich Schuchardt wrote:
> Fix an incorrect path.
>
> Signed-off-by: Heinrich Schuchardt
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@l
On Tue, Mar 13, 2018 at 01:57:04PM +0100, Patrick Delaunay wrote:
> Merge init_helpers.h in the new file init.h
> with only prototypes for init_cache_f_r
> used in common/board_f.c
>
> Signed-off-by: Patrick Delaunay
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP si
On Tue, Mar 13, 2018 at 01:57:00PM +0100, Patrick Delaunay wrote:
> Move prototypes for function used in common/board_f.c
> from common.h to init.h
> Remove weak for arch_reserve_stacks in prototype
> (checkpatch issue)
>
> Signed-off-by: Patrick Delaunay
Applied to u-boot/master, thanks!
--
On Tue, Mar 13, 2018 at 01:57:03PM +0100, Patrick Delaunay wrote:
> Move function prototype for common/init/board_init.c
> from common.h to init.h
>
> Signed-off-by: Patrick Delaunay
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP signature
__
On Tue, Mar 13, 2018 at 01:57:02PM +0100, Patrick Delaunay wrote:
> Move function prototypes used in common/board_r.c
> from common.h to init.h
>
> Signed-off-by: Patrick Delaunay
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP signature
_
On Mon, Mar 12, 2018 at 09:22:44AM +0100, Patrick Delaunay wrote:
> The 2 functions board_power_mode and board_poweroff
> are no more existing in U-Boot code (check with grep)
> This patch updates the documentation and removes
> the unnecessary prototypes.
>
> Signed-off-by: Patrick Delaunay
Ap
On Tue, Mar 13, 2018 at 11:17:07AM +0100, Michal Simek wrote:
> This file is completely unused and it should be removed as the part of
> ppc405/ppc440 xilinx platform removal.
>
> Signed-off-by: Michal Simek
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP signature
_
On Tue, Mar 13, 2018 at 01:57:01PM +0100, Patrick Delaunay wrote:
> Move function prototypes for common/init/board_init.c
> from common.h to init.h
>
> Signed-off-by: Patrick Delaunay
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP signature
_
On Mon, Mar 12, 2018 at 11:08:09PM +0100, Heinrich Schuchardt wrote:
> Change due to commit b08c8c487083 ("libfdt: move headers to
> and ")
>
> Signed-off-by: Heinrich Schuchardt
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP signature
_
On Mon, Mar 12, 2018 at 11:17:11PM +0100, Heinrich Schuchardt wrote:
> Remove non-existing directories.
>
> Signed-off-by: Heinrich Schuchardt
> Acked-by: Minkyu Kang
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP signature
_
On Mon, Mar 12, 2018 at 10:56:18PM +0100, Heinrich Schuchardt wrote:
> arch/arm/cpu/armv7/mx*/ does not relate to any existing directory.
>
> Signed-off-by: Heinrich Schuchardt
> Reviewed-by: Fabio Estevam
Applied to u-boot/master, thanks!
--
Tom
signature.asc
Description: PGP signature
__
On Mon, Mar 12, 2018 at 09:19:22AM +0100, Patrick Delaunay wrote:
> Remove the prototypes for 4 functions no more existing
> in U-Boot code (checked by grep):
> - checkflash
> - checkdram
> - mdm_init
> - setup_board_extra
>
> Signed-off-by: Patrick Delaunay
Applied to u-boot/master, thanks!
-
On Fri, Mar 09, 2018 at 06:28:12PM +0100, Patrick Delaunay wrote:
> Add a new file init.h with the prototype for arch_cpu_init
> Add a prototype for mach_cpu_init() to avoid a warning:
> no previous prototype for ‘mach_cpu_init’
>
> It is a first step to move all the functions prototype
> used du
On Sat, Mar 17, 2018 at 01:32:52PM +0530, Keerthy wrote:
> From: Tero Kristo
>
> Kernel stores information to the RTC_SCRATCH0 and RTC_SCRATCH1 registers
> for wakeup from RTC-only mode with DDR in self-refresh. Parse these
> registers during SPL boot and jump to the kernel resume vector if the
On 03/18/2018 01:10 PM, Marek Vasut wrote:
> On 03/18/2018 01:00 PM, Heinrich Schuchardt wrote:
>> In
>>
>> struct dwc3_request *r = NULL;
>> r = A;
>>
>> the first assignment has no effect. Remove it.
>>
>> Signed-off-by: Heinrich Schuchardt
>
> The driver is imported from Linux, d
On 03/18/2018 01:27 PM, Marek Vasut wrote:
> On 03/18/2018 01:25 PM, Heinrich Schuchardt wrote:
>> Assigning a value to ret if it is immediately overwritten does not make
>> sense.
>>
>> Signed-off-by: Heinrich Schuchardt
>
> Did you even compile-test this ? I have a feeling this file is not used
The error checking should also catch the case that no range has beeen
defined.
syscon_get_first_range() returns NULL if no range is defined.
cf. rk3399_mipi.c
Signed-off-by: Heinrich Schuchardt
---
I do not possess the hardware for testing. But the coding is not consistent
with the coding used in
Pointers are never negative. Use macro IS_ERR() for checking.
cf. rk3288_mipi.c
Signed-off-by: Heinrich Schuchardt
---
drivers/video/rockchip/rk3399_mipi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/rockchip/rk3399_mipi.c
b/drivers/video/rockchip/rk3399_mi
No need to initialize variables if the next usage is an assignment.
Signed-off-by: Heinrich Schuchardt
---
drivers/video/exynos/exynos_dp.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/video/exynos/exynos_dp.c b/drivers/video/exynos/exynos_dp.c
index 3
If an event does not occur the current coding stays in an endless loop.
Signed-off-by: Heinrich Schuchardt
---
drivers/video/da8xx-fb.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c
index 6ec4f89e34..26db73b138 100644
Eliminate (x2 - x2) which is always zero.
Signed-off-by: Heinrich Schuchardt
---
drivers/video/stb_truetype.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/stb_truetype.h b/drivers/video/stb_truetype.h
index 26e483cf56..5d00bff9fd 100644
--- a/drivers/video/st
(A || !A && B) == (A || B)
Signed-off-by: Heinrich Schuchardt
---
drivers/video/cfb_console.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/cfb_console.c b/drivers/video/cfb_console.c
index 0b25897062..5b7795dd44 100644
--- a/drivers/video/cfb_console.c
+++ b/
musb->endpoints[] has array size MUSB_C_NUM_EPS.
We must check array bounds before accessing the array and not afterwards.
Signed-off-by: Heinrich Schuchardt
---
drivers/usb/musb-new/musb_gadget_ep0.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/musb
On 03/18/2018 01:33 AM, Jonathan Gray wrote:
> On Sat, Mar 17, 2018 at 05:24:47PM +0100, Marek Vasut wrote:
>> On 03/17/2018 04:09 PM, Hauke Mehrtens wrote:
>>> On 03/17/2018 03:47 PM, Marek Vasut wrote:
On 03/17/2018 01:23 PM, Hauke Mehrtens wrote:
> The mxsimage utility fails to compile
On Fri, 2018-03-16 at 10:45 -0500, David Lechner wrote:
> On 03/16/2018 04:26 AM, Sekhar Nori wrote:
> > On Thursday 15 March 2018 08:02 PM, David Lechner wrote:
> > >
> > > Thanks for the tips. I've actually done exactly that (using my
> > > own SD
> > > card).
> > >
> > > However, these changes
Hi list.
If a pci modify command is issued, do_pci() takes the size specifier (.l, .w,
.b) and turns it into one of PCI_SIZE_8, PCI_SIZE_16, or PCI_SIZE_32, which
correspond to 0, 1, and 2.
Consequently, the address increment moves at 0, 1, or 2 bytes.
This would be a trivial patch for me to
The mxsimage utility fails to compile against LibreSSL because LibreSSL
says it is OpenSSL 2.0, but it does not support the complete OpenSSL 1.1
interface.
LibreSSL defines OPENSSL_VERSION_NUMBER with 0x2000L and therefor
claims to have an API compatible with OpenSSL 2.0, but it does not
imple
On 03/17/2018 03:47 PM, Marek Vasut wrote:
> On 03/17/2018 01:23 PM, Hauke Mehrtens wrote:
>> The mxsimage utility fails to compile against LibreSSL because LibreSSL
>> says it is OpenSSL 2.0, but it does not support the complete OpenSSL 1.1
>> interface.
>
> The mxsimage does support OpenSSL 1.1
The mxsimage utility fails to compile against LibreSSL because LibreSSL
says it is OpenSSL 2.0, but it does not support the complete OpenSSL 1.1
interface.
Signed-off-by: Hauke Mehrtens
---
tools/mxsimage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/mxsimage.c b/to
Setting ret = -EINVAL is superfluous.
Signed-off-by: Heinrich Schuchardt
---
drivers/usb/musb-new/musb_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/musb-new/musb_core.c b/drivers/usb/musb-new/musb_core.c
index 79e118ef85..19c072a67e 100644
--- a/drivers/
There is not need to set variables to NULL before an assignment.
Signed-off-by: Heinrich Schuchardt
---
drivers/usb/host/xhci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 4673738d1e..7e3c373e64 100644
--- a/driv
No need to set a variable to NULL if the next use is an assignment.
Do not define variables in the middle of nowhere.
Signed-off-by: Heinrich Schuchardt
---
drivers/usb/host/xhci-ring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb
There is no need to set variables to NULL if they are not used before
the next assignment.
Signed-off-by: Heinrich Schuchardt
---
drivers/usb/host/xhci-keystone.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/xhci-keystone.c b/drivers/usb/host/xhci-keys
If fdtdec_next_compatible_subnode() fails it returns a negative value.
The check (node <= 0) cannot identify this if node is unsigned.
Signed-off-by: Heinrich Schuchardt
---
drivers/usb/host/xhci-exynos5.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci-
Don't make the same assignment twice.
Signed-off-by: Heinrich Schuchardt
---
drivers/usb/host/sl811-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/sl811-hcd.c b/drivers/usb/host/sl811-hcd.c
index b29c67e189..e587895bfc 100644
--- a/drivers/usb/host/sl8
On 03/18/2018 01:25 PM, Heinrich Schuchardt wrote:
> Assigning a value to ret if it is immediately overwritten does not make
> sense.
>
> Signed-off-by: Heinrich Schuchardt
Did you even compile-test this ? I have a feeling this file is not used
at all, so maybe we should remove this driver.
> -
Assigning a value to ret if it is immediately overwritten does not make
sense.
Signed-off-by: Heinrich Schuchardt
---
drivers/usb/host/ehci-faraday.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-faraday.c b/drivers/usb/host/ehci-faraday.c
index 821222
Assigning f_rkusb->reboot_flag twice doesn't make sense.
Signed-off-by: Heinrich Schuchardt
---
drivers/usb/gadget/f_rockusb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/gadget/f_rockusb.c b/drivers/usb/gadget/f_rockusb.c
index d5a10f1904..ad3ae91e6d 100644
--- a/drivers/usb/
An unsigned int is always >= 0.
Signed-off-by: Heinrich Schuchardt
---
drivers/usb/gadget/f_mass_storage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/f_mass_storage.c
b/drivers/usb/gadget/f_mass_storage.c
index 1ecb92ac6b..7d7ed4242b 100644
--- a/driv
On 03/18/2018 01:00 PM, Heinrich Schuchardt wrote:
> In
>
> struct dwc3_request *r = NULL;
> r = A;
>
> the first assignment has no effect. Remove it.
>
> Signed-off-by: Heinrich Schuchardt
The driver is imported from Linux, did you fix it in Linux too ?
> ---
> drivers/usb/d
We should not make the same assignement twice.
Signed-off-by: Heinrich Schuchardt
---
drivers/usb/gadget/composite.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
index d0ee7847b9..7dd1e13b92 100644
--- a/drive
1 - 100 of 112 matches
Mail list logo
