Re: [U-Boot] [PATCH v3 07/20] arm: socfpga: Fix with the correct polling status bit

2017-10-22 Thread Chee, Tien Fong
On Isn, 2017-10-16 at 10:29 -0500, Dinh Nguyen wrote: > > On 10/13/2017 03:08 AM, tien.fong.c...@intel.com wrote: > > > > From: Tien Fong Chee > > > > Commit 2baa997240d ("arm: socfpga: Add FPGA driver support for > > Arria 10") > > Polling the wrong status bit. Fix with correct polling status

Re: [U-Boot] [PATCH v3 03/20] arm: socfpga: Add Arria 10 SoCFPGA programming interface

2017-10-22 Thread Chee, Tien Fong
On Isn, 2017-10-16 at 07:39 -0500, Dinh Nguyen wrote: > Please run get_maintainer on this patch. I think you need to include > a > few more people. > Okay. > On 10/13/2017 03:08 AM, tien.fong.c...@intel.com wrote: > > > > From: Tien Fong Chee > > > > Add code necessary into the FPGA driver fram

Re: [U-Boot] [PATCH v3 06/20] common: Generic firmware loader for file system

2017-10-22 Thread Chee, Tien Fong
On Isn, 2017-10-16 at 16:41 +0200, Marek Vasut wrote: > On 10/16/2017 04:08 PM, Dinh Nguyen wrote: > > > > > > > > On 10/13/2017 03:08 AM, tien.fong.c...@intel.com wrote: > > > > > > From: Tien Fong Chee > > > > > > Generic firmware loader framework contains some common > > > functionality >

Re: [U-Boot] [PATCH] ARM: SPL: FIT: fix DTC warnings on FIT generation

2017-10-22 Thread Lokesh Vutla
On Tuesday 17 October 2017 02:43 AM, Tom Rini wrote: > On Tue, Oct 17, 2017 at 02:29:14AM +0530, Jagan Teki wrote: >> On Mon, Oct 9, 2017 at 10:15 AM, Simon Glass wrote: >>> Hi Andre, >>> >>> On 4 October 2017 at 17:24, Andre Przywara wrote: Newer versions of the device tree compiler (righ

Re: [U-Boot] [PATCH v3 1/2] thermal: ti-bandgap: Add support for temperature sensor

2017-10-22 Thread Faiz Abbas
Hi Tom, On Monday 23 October 2017 08:30 AM, Tom Rini wrote: > On Mon, Oct 23, 2017 at 08:07:09AM +0530, Lokesh Vutla wrote: >> On Wednesday 18 October 2017 05:11 PM, Faiz Abbas wrote: >>> The dra7xx series of SOCs contain a temperature sensor and an >>> associated analog-to-digital converter (ADC)

[U-Boot] [GIT PULL] Please pull u-boot-mmc master

2017-10-22 Thread Jaehoon Chung
Dear Tom, Could you pull these patches to u-boot/master? To develop the supporting HS200 mode, each host driver also needs to implement something. First step is the applying JJ's patches. If there is a problem, let me know, plz. The following changes since commit 0def58f7fd26a237bb08cfbd58ec533

Re: [U-Boot] [PATCH] mmc: replace the printf() instead of error()

2017-10-22 Thread Jaehoon Chung
On 10/23/2017 01:46 PM, Jaehoon Chung wrote: > Replace the printf() instead of error(). > It is occurred the compiler error with "undefined reference to 'error'". > > Fixes: e0079fecd75b ("mmc: refacstor SD startup to make it easier to support > new modes") > > Signed-off-by: Jaehoon Chung App

[U-Boot] [PATCH] mmc: replace the printf() instead of error()

2017-10-22 Thread Jaehoon Chung
Replace the printf() instead of error(). It is occurred the compiler error with "undefined reference to 'error'". Fixes: e0079fecd75b ("mmc: refacstor SD startup to make it easier to support new modes") Signed-off-by: Jaehoon Chung --- drivers/mmc/mmc.c | 8 1 file changed, 4 insertio

Re: [U-Boot] [PATCH v3 1/2] thermal: ti-bandgap: Add support for temperature sensor

2017-10-22 Thread Tom Rini
On Mon, Oct 23, 2017 at 08:07:09AM +0530, Lokesh Vutla wrote: > On Wednesday 18 October 2017 05:11 PM, Faiz Abbas wrote: > > The dra7xx series of SOCs contain a temperature sensor and an > > associated analog-to-digital converter (ADC) which produces > > an output which is proportional to the SOC t

Re: [U-Boot] Build failure in u-boot-mmc/master: undefined reference to error

2017-10-22 Thread Jaehoon Chung
Dear Stephen, On 10/21/2017 12:47 AM, Stephen Warren wrote: > With the latest content of u-boot-mmc/master, 41dc35a149b3 "drivers: mmc: > Avoid memory leak in case of failure", all Tegra boards (perhaps others too; > my system only tests Tegra) fail to build with the following error: I had foun

Re: [U-Boot] [PATCH v3 1/2] thermal: ti-bandgap: Add support for temperature sensor

2017-10-22 Thread Lokesh Vutla
On Wednesday 18 October 2017 05:11 PM, Faiz Abbas wrote: > The dra7xx series of SOCs contain a temperature sensor and an > associated analog-to-digital converter (ADC) which produces > an output which is proportional to the SOC temperature. > Add support for this temperature sensor. > > Signed-off

Re: [U-Boot] [PATCH 3/3] Powerpc: pcie: Make pcie link state judgement more specific

2017-10-22 Thread Xiaowei Bao
-Original Message- From: Joakim Tjernlund [mailto:joakim.tjernl...@infinera.com] Sent: Friday, October 20, 2017 9:13 PM To: w...@denx.de; Mingkai Hu ; tony.obr...@alliedtelesis.co.nz; u-boot@lists.denx.de; Z.q. Hou ; York Sun ; Xiaowei Bao ; hamish.mar...@alliedtelesis.co.nz; M.h. Lian

[U-Boot] [PATCH v4 3/5] arm: layerscape: Remove CONFIG_USB_MAX_CONTROLLER_COUNT

2017-10-22 Thread Ran Wang
Because COMFIG_DM_USB has been enabled and will not use it anymore. Signed-off-by: Ran Wang Reviewed-by: Bin Meng --- Change in v4: Typo correction. Change in v3: New patch file. include/configs/ls1012afrdm.h | 5 - include/configs/ls1012aqds.h | 3 --- include/co

[U-Boot] [PATCH v4 5/5] ls1088aqds: Enable USB command on QDS for qspi-boot

2017-10-22 Thread Ran Wang
Signed-off-by: Amrita Kumari Signed-off-by: Ashish Kumar Signed-off-by: Ran Wang Reviewed-by: Bin Meng --- Change in v4: Typo correction. Change in v3: - none Change in v2: Remove macro CONFIG_HAS_FSL_XHCI_USB and CONFIG_USB_XHCI_FSL and CONFIG_USB_MAX_CONTROLL

[U-Boot] [PATCH v4 4/5] ls1088ardb: Enable USB command RDB qspi-boot

2017-10-22 Thread Ran Wang
Signed-off-by: Ashish Kumar Signed-off-by: Amrita Kumari Signed-off-by: Ran Wang Reviewed-by: Bin Meng --- Change in v4: Typo correction. Change in v3: 1.Move HAS_FSL_XHCI_USB and USB_XHCI_FSL define to other patch file. Change in v2: 1.Adjust USB nodes positio

[U-Boot] [PATCH v4 2/5] usb: host: Move CONFIG_XHCI_FSL to Kconfig

2017-10-22 Thread Ran Wang
use Kconfig to select xhci accordingly. Signed-off-by: Ran Wang Reviewed-by: Bin Meng --- Change in v4: Typo correction. Change in v3: New patch file. drivers/usb/host/Kconfig | 6 ++ include/configs/ls1012afrdm.h | 1 - include/configs/ls1012aqds.h | 1 - in

[U-Boot] [PATCH v4 1/5] arm64: layerscape: Move CONFIG_HAS_FSL_XHCI_USB to Kconfig

2017-10-22 Thread Ran Wang
Use Kconfig to select QE-HDLC and USB pin-mux. Signed-off-by: Ran Wang Reviewed-by: Bin Meng --- Change in v4: Typo correction. Change in v3: New patch file. arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 7 +++ include/configs/ls1012afrdm.h | 4 incl

Re: [U-Boot] [PATCH 6/9] spi: ich: Lock down controller settings if required

2017-10-22 Thread Bin Meng
Hi Simon, On Sun, Oct 22, 2017 at 10:36 PM, Simon Glass wrote: > On 19 October 2017 at 03:20, Bin Meng wrote: >> Some Intel FSP (like Braswell) does SPI lock-down during the call >> to fsp_notify(INIT_PHASE_BOOT). But before SPI lock-down is done, >> it's bootloader's responsibility to configure

[U-Boot] [PATCH] image-sig: use designated initializers for algorithm

2017-10-22 Thread Masahiro Yamada
Designated initializers are more readable because we do not have to check the order in the struct definitions. Signed-off-by: Masahiro Yamada --- common/image-sig.c | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/common/image-si

[U-Boot] sunxi: broken sun4i_emacs, all boards?

2017-10-22 Thread Artturi Alm
Hi, this has been 'blocking' my attempts to revive the A10-boards i have since early june, or so. now i found this commit abc3e4df59f54cf3dda42a35a75d617fe861f5fe, which left the drivers/net/Makefile untouched, essentially breaking sunxi_emac. the diff below didn't fix it however, i can see how

[U-Boot] [GIT PULL] u-boot-uniphier/master

2017-10-22 Thread Masahiro Yamada
Hi Tom, This was late for -rc2 for some reason, but it includes what I intended to include in it. Some fixes, remove unused CONFIG, DT sync, etc. Please pull. The following changes since commit 23d51bef94aacd0ad4dcbdb31e66acd82def13eb: uniphier_ld4_sld8: Re-add SMC911X_BASE address (2017-10

Re: [U-Boot] [PATCH] doc: uniphier: add simple guide to Verified Boot

2017-10-22 Thread Masahiro Yamada
2017-10-22 15:15 GMT+09:00 Masahiro Yamada : > Add a simple documentation about how to use the Verified Boot on > UniPhier boards. > > Signed-off-by: Masahiro Yamada > --- Applied to u-boot-uniphier/master. -- Best Regards Masahiro Yamada ___ U-Boot

Re: [U-Boot] [PATCH] ARM: uniphier: remove verify=n from environments

2017-10-22 Thread Masahiro Yamada
2017-10-21 19:51 GMT+09:00 Masahiro Yamada : > If the environment "verify" is set to n, the image verification > is entirely skipped. Remove it as a preparation for verified boot. > > Signed-off-by: Masahiro Yamada > --- Applied to u-boot-uniphier/master. -- Best Regards Masahiro Yamada

Re: [U-Boot] [PATCH] ARM: uniphier: increase CONFIG_SYS_BOOTM_LEN to 32MB

2017-10-22 Thread Masahiro Yamada
2017-10-19 19:17 GMT+09:00 Masahiro Yamada : > The default value of CONFIG_SYS_BOOTM_LEN, 0x80, causes error > when uncompressing Image.gz out of fit. > >Uncompressing Kernel Image ... Error: inflate() returned -5 > Image too large: increase CONFIG_SYS_BOOTM_LEN > > Signed-off-by: Masahiro

Re: [U-Boot] [PATCH 1/4] ARM: uniphier: enable DWC3 xHCI driver really

2017-10-22 Thread Masahiro Yamada
2017-10-17 21:19 GMT+09:00 Masahiro Yamada : > I thought commit d37d31849c6a ("ARM: uniphier: enable DWC3 xHCI > driver") enabled CONFIG_USB_DWC3_UNIPHIER, but CONFIG_USB_XHCI_DWC3 > was missing in uniphier_v7_defconfig. Re-add. > > Signed-off-by: Masahiro Yamada > --- Applied to u-boot-uniphier

Re: [U-Boot] [PATCH 5/5] lib: libfdt: wrap scripts/dtc/libfdt/* where possible

2017-10-22 Thread Masahiro Yamada
2017-10-22 23:35 GMT+09:00 Simon Glass : > Hi Masahiro, > > On 17 October 2017 at 15:30, Masahiro Yamada > wrote: >> lib/libfdt/ and scripts/dtc/libfdt have the same copies for the >> followings 6 files: >> fdt.c fdt_addresses.c fdt_empty_tree.c fdt_overlay.c fdt_strerr.c >> fdt_sw.c >> >> Mak

Re: [U-Boot] [PATCH 1/5] libfdt: change fdt.h to a wrapper of scripts/dtc/libfdt/*

2017-10-22 Thread Masahiro Yamada
Hi Simon, 2017-10-22 23:35 GMT+09:00 Simon Glass : > Hi Masahiro, > > On 17 October 2017 at 15:30, Masahiro Yamada > wrote: >> Fortunately, U-Boot did not modify fdt.h locally. >> >> Change it to a wrapper of scripts/dtc/libfdt/fdt.h, which will be >> periodically synced with the upstream DTC (or

Re: [U-Boot] [PATCH] tools: image: fix node name of signature node in FIT

2017-10-22 Thread Masahiro Yamada
Hi Simon, 2017-10-22 23:36 GMT+09:00 Simon Glass : > On 19 October 2017 at 12:16, Masahiro Yamada > wrote: >> Both "conf_name" and "sig_name" point to the name of config node. >> The latter should be the name of the signature node. >> >> Signed-off-by: Masahiro Yamada >> --- >> >> tools/image-h

Re: [U-Boot] [PATCH 7/9] x86: braswell: cherryhill: Update dts for SPI lock down

2017-10-22 Thread Simon Glass
On 19 October 2017 at 03:20, Bin Meng wrote: > Intel Braswell FSP requires SPI controller settings to be locked down, > let's do this in the chrryhill.dts and remove previous Kconfig option. > > Signed-off-by: Bin Meng > --- > > arch/x86/cpu/braswell/Kconfig | 4 > arch/x86/dts/cherryhill.d

Re: [U-Boot] [PATCH 1/1] efi_loader: disable saving of EFI variables

2017-10-22 Thread Simon Glass
On 20 October 2017 at 00:15, Heinrich Schuchardt wrote: > The current implementation of saving of EFI variables has > unwanted side effects: > > - Writing to flash on every boot may harm the memory. > - All variables are saved. Not only the EFI ones. > - Variables are saved even if there is not ch

Re: [U-Boot] [PATCH v3 08/18] efi_selftest: reformat code

2017-10-22 Thread Simon Glass
On 18 October 2017 at 00:02, Heinrich Schuchardt wrote: > Remove superfluous spaces. > > Signed-off-by: Heinrich Schuchardt > --- > v3 > new patch split off > --- > lib/efi_selftest/efi_selftest.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Simon Glass

Re: [U-Boot] [PATCH 4/9] x86: Fix ACPI resume dependency to MRC cache

2017-10-22 Thread Simon Glass
On 19 October 2017 at 03:20, Bin Meng wrote: > In an S3 resume path, MRC cache is mandatory. Enforce the dependency > in the Kconfig. > > Signed-off-by: Bin Meng > --- > > arch/x86/Kconfig | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Simon Glass

Re: [U-Boot] [PATCH 9/9] x86: acpi: Put sleepstates.asl to the common place

2017-10-22 Thread Simon Glass
On 19 October 2017 at 03:21, Bin Meng wrote: > The supported sleep states are generic on Intel processors. Move the > ASL definition to the common place. > > Signed-off-by: Bin Meng > --- > > arch/x86/include/asm/{arch-baytrail => }/acpi/sleepstates.asl | 0 > arch/x86/include/asm/arch-baytrail

Re: [U-Boot] [PATCH v2 5/5] cmd: gpt: solve issue for swap

2017-10-22 Thread Simon Glass
On 16 October 2017 at 18:17, Patrick Delaunay wrote: > don't use prettyprint_part_size() in create_gpt_partitions_list() > that avoid to align offset and size to 1 MiB and increase precision for > start and size > This patch avoid the risk to change partition size > and lost data during swap > > S

Re: [U-Boot] [PATCH] ARM: SPL: FIT: fix DTC warnings on FIT generation

2017-10-22 Thread Simon Glass
Hi Andre, On 16 October 2017 at 23:30, André Przywara wrote: > Hi, > > sorry Simon for dropping the ball earlier. I will try to answer both > Jagan's and your concern below. > > On 16/10/17 21:59, Jagan Teki wrote: >> On Mon, Oct 9, 2017 at 10:15 AM, Simon Glass wrote: >>> Hi Andre, >>> >>> On 4

Re: [U-Boot] [PATCH 6/9] spi: ich: Lock down controller settings if required

2017-10-22 Thread Simon Glass
On 19 October 2017 at 03:20, Bin Meng wrote: > Some Intel FSP (like Braswell) does SPI lock-down during the call > to fsp_notify(INIT_PHASE_BOOT). But before SPI lock-down is done, > it's bootloader's responsibility to configure the SPI controller's > opcode registers properly otherwise SPI contro

[U-Boot] How to enable USB Mass Storage

2017-10-22 Thread Frank Kunz
Hello, I want to use the ums command to access the SD card of a A20-OlinuxIno-Lime board via usb-org cable. For that I start the CPU in FEL mode, download the u-boot-sunxi-with-spl.bin file by sunxi-fel tool. I do this FEL mode boot for preparation of an Einstein A20 board, which has only an i

Re: [U-Boot] [PATCH v3 18/18] efi_loader: set parent handle in efi_load_image

2017-10-22 Thread Simon Glass
On 18 October 2017 at 00:02, Heinrich Schuchardt wrote: > The parent_handle of the loaded image must be set. > Set the system table. > > Signed-off-by: Heinrich Schuchardt > --- > v3 > new patch > --- > lib/efi_loader/efi_boottime.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by:

Re: [U-Boot] [PATCH v3 04/18] efi_loader: new function utf8_to_utf16

2017-10-22 Thread Simon Glass
On 18 October 2017 at 00:02, Heinrich Schuchardt wrote: > Provide a conversion function from utf8 to utf16. > > Add missing #include in include/charset.h. > Remove superfluous #include in lib/charset.c. > > Signed-off-by: Heinrich Schuchardt > --- > v3 > no change > v2 > new pat

Re: [U-Boot] [PATCH 1/1] Kconfig: add CONFIG_BROKEN

2017-10-22 Thread Simon Glass
On 19 October 2017 at 23:49, Heinrich Schuchardt wrote: > Provide a Kconfig option that we can use as dependency for > features that are broken. This allows to easily disable them > without removing the code. > > As no short text is supplied the option will not appear in > menuconfig. > > Signed-o

Re: [U-Boot] i.MX6: Prealloc pinctrl make U-Boot hang at relocation (data abort)

2017-10-22 Thread Simon Glass
Hi Jagan, On 17 October 2017 at 00:53, Jagan Teki wrote: > + Tom > > > On 17-Oct-2017 12:44 AM, "Jagan Teki" wrote: > > Hi, > > I'm trying to use SPL_OF_CONTROL with u-boot,dm-spl So I've marked > u-boot,dm-spl with pinctrl since MMC used the pinconfig. > > The issue observed here is SPL handove

Re: [U-Boot] [PATCH v3 16/18] test/py: fix typo in test_efi_loader.py

2017-10-22 Thread Simon Glass
On 18 October 2017 at 00:02, Heinrich Schuchardt wrote: > Make a comment line easier to read. > > Signed-off-by: Heinrich Schuchardt > --- > v3 > no change > v2 > no change > --- > test/py/tests/test_efi_loader.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-

Re: [U-Boot] [PATCH v2] power: extend prefix match to regulator-name property

2017-10-22 Thread Simon Glass
On 18 October 2017 at 11:39, Felix Brack wrote: > This patch extends pmic_bind_children prefix matching. In addition to > the node name the property regulator-name is used while trying to match > prefixes. This allows assigning different drivers to regulator nodes > named regulator@1 and regulator

Re: [U-Boot] [PATCH v3 10/18] efi_selftest: deduplicate code

2017-10-22 Thread Simon Glass
On 18 October 2017 at 00:02, Heinrich Schuchardt wrote: > Move duplicate code to the new function efi_st_do_tests. > > Suggested-by: Alexander Graf > Signed-off-by: Heinrich Schuchardt > --- > v3 > new patch > --- > lib/efi_selftest/efi_selftest.c | 71 > ---

Re: [U-Boot] [PATCH u-boot 1/3] net: phy: Add Amlogic Meson GXL Internal PHY support

2017-10-22 Thread Simon Glass
On 18 October 2017 at 10:02, Neil Armstrong wrote: > The Amlogic Meson GXL/GXM families embeds an internal RMII Ethernet PHY. > > The PHY acts as a generic PHY but needs a slight configuration right > before it's configuration. > > Signed-off-by: Neil Armstrong > --- > drivers/net/phy/Kconfig

Re: [U-Boot] [PATCH] doc: verified-boot: fix crypto algorithm examples

2017-10-22 Thread Simon Glass
On 19 October 2017 at 12:37, Masahiro Yamada wrote: > As you see in crypto_algos in common/image-sig.c, the algorithm > should be either "rsa2048" or "rsa4096". "rs2048" is a typo. > > Signed-off-by: Masahiro Yamada > --- > > doc/uImage.FIT/signature.txt | 4 ++-- > 1 file changed, 2 insertions

Re: [U-Boot] [PATCH 1/1] efi_selftest: correctly check return values

2017-10-22 Thread Simon Glass
On 13 October 2017 at 01:00, Heinrich Schuchardt wrote: > When cancelling the timer we should check the return > value provided by the set_timer service. > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_selftest/efi_selftest_events.c | 2 +- > lib/efi_selftest/efi_selftest_tpl.c| 2 +-

Re: [U-Boot] [PATCH] tools: image: fix node name of signature node in FIT

2017-10-22 Thread Simon Glass
On 19 October 2017 at 12:16, Masahiro Yamada wrote: > Both "conf_name" and "sig_name" point to the name of config node. > The latter should be the name of the signature node. > > Signed-off-by: Masahiro Yamada > --- > > tools/image-host.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [U-Boot] [PATCH 8/9] x86: fsp: graphics: Add some notes about the graphics info hob

2017-10-22 Thread Simon Glass
On 19 October 2017 at 03:20, Bin Meng wrote: > On some platforms (eg: Braswell), the FSP will not produce the > graphics info HOB unless you plug some cables to the display > interface (eg: HDMI) on the board. Add such notes in the FSP > video driver. > > Signed-off-by: Bin Meng > --- > > arch/x

Re: [U-Boot] [PATCH 3/9] env: x86: braswell: Set ENV_IS_IN_SPI_FLASH as default

2017-10-22 Thread Simon Glass
On 19 October 2017 at 03:20, Bin Meng wrote: > Imply does not work for a Kconfig choice. Update ENV_IS_IN_SPI_FLASH > to be the default one for Intel Braswell. > > Signed-off-by: Bin Meng > --- > > arch/x86/cpu/braswell/Kconfig | 1 - > env/Kconfig | 1 + > 2 files changed, 1 i

Re: [U-Boot] [PATCH 2/9] x86: braswell: Fix unexpected crash during Linux kernel boot

2017-10-22 Thread Simon Glass
On 19 October 2017 at 03:20, Bin Meng wrote: > It was observed that when booting Linux kernel on Intel Cherry Hill > board, unexpected crash happens quite randomly. Sometimes kernel > just oops, while sometimes kernel throws MCE errors and hangs: > > mce: [Hardware Error]: Machine check events l

Re: [U-Boot] [PATCH v3 14/18] efi_selftest: test reboot by watchdog

2017-10-22 Thread Simon Glass
On 18 October 2017 at 00:02, Heinrich Schuchardt wrote: > A test is added that verifies that the watchdog timer actually > causes a reboot upon timeout. The test is only executed on > request using > > setenv efi_selftest watchdog reboot > bootefi selftest > > Signed-off-by: Heinrich Schuc

Re: [U-Boot] [PATCH v3 13/18] efi_loader: use bootargs as load options

2017-10-22 Thread Simon Glass
On 18 October 2017 at 00:02, Heinrich Schuchardt wrote: > Use environment variable bootargs used as load options > for bootefi payloads. > > Signed-off-by: Heinrich Schuchardt > --- > v3 > new patch split off > --- > cmd/bootefi.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: S

Re: [U-Boot] [PATCH 2/2] i2c: stm32f7_i2c: fix usage of useless local variable

2017-10-22 Thread Simon Glass
On 11 October 2017 at 15:30, wrote: > From: Patrice Chotard > > Remove useless local variable "s" and use directly > function's parameter "output" > > Signed-off-by: Patrice Chotard > --- > drivers/i2c/stm32f7_i2c.c | 10 ++ > 1 file changed, 2 insertions(+), 8 deletions(-) Reviewed-b

Re: [U-Boot] [PATCH 5/5] lib: libfdt: wrap scripts/dtc/libfdt/* where possible

2017-10-22 Thread Simon Glass
Hi Masahiro, On 17 October 2017 at 15:30, Masahiro Yamada wrote: > lib/libfdt/ and scripts/dtc/libfdt have the same copies for the > followings 6 files: > fdt.c fdt_addresses.c fdt_empty_tree.c fdt_overlay.c fdt_strerr.c > fdt_sw.c > > Make them a wrapper of scripts/dtc/libfdt/*. This is exa

Re: [U-Boot] [PATCH v2 9/9] test/py: fix typo in test_efi_loader.py

2017-10-22 Thread Simon Glass
On 13 October 2017 at 19:33, Heinrich Schuchardt wrote: > Make a comment line easier to read. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > test/py/tests/test_efi_loader.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass

Re: [U-Boot] [PATCH v3 09/18] efi_selftest: efi_st_memcmp should return 0

2017-10-22 Thread Simon Glass
On 18 October 2017 at 00:02, Heinrich Schuchardt wrote: > If the compared memory areas match the return value should be 0. > We should not use the unrelated constant EFI_ST_SUCCESS. > > Signed-off-by: Heinrich Schuchardt > --- > v3 > new patch split off > --- > lib/efi_selftest/efi_selft

Re: [U-Boot] [PATCH v3 15/18] test/py: test reboot by EFI watchdog

2017-10-22 Thread Simon Glass
On 18 October 2017 at 00:02, Heinrich Schuchardt wrote: > Clear environment variable efi_selftest before executing the > default tests. > > Provide a test verifying that the EFI watchdog > reboots the system upon timeout. > > The test depends on CONFIG_CMD_EFI_SELFTEST=y. > > Signed-off-by: Heinri

Re: [U-Boot] [PATCH v3 07/18] efi_selftest: provide a dummy device path

2017-10-22 Thread Simon Glass
On 18 October 2017 at 00:02, Heinrich Schuchardt wrote: > Currently we pass bootefi_device_path and bootefi_image_path as > device and image path without initializing them. They may carry > values from previous calls to bootefi. > > With the patch the variables are initialized valid dummy values.

Re: [U-Boot] [PATCH v2 3/9] efi_selftest: provide test for watchdog timer

2017-10-22 Thread Simon Glass
On 13 October 2017 at 19:33, Heinrich Schuchardt wrote: > The test verifies that resetting the watchdog timer ensures > that it is not called during the timeout period. > > Testing that the watchdog timer actually executes a reset > would require a test outside the efi_selftest framework. > > Sign

Re: [U-Boot] [PATCH v3 12/18] efi_selftest: correctly cleanup after selftest

2017-10-22 Thread Simon Glass
On 18 October 2017 at 00:02, Heinrich Schuchardt wrote: > After executing bootefi selftest > * restore GD > * unlink the load image handle > * return 0 or 1 and not a truncated efi_status_t. > > Signed-off-by: Heinrich Schuchardt > --- > v3 > new patch split off > --- > cmd/bootefi.c | 4

Re: [U-Boot] [PATCH v2 3/5] disk: efi: correct the overlap check on GPT header and PTE

2017-10-22 Thread Simon Glass
On 16 October 2017 at 18:17, Patrick Delaunay wrote: > the partition starting at 0x4400 is refused with overlap error: > $> gpt write mmc 0 "name=test,start=0x4400,size=0" > Writing GPT: Partition overlap > error! > > even if the 0x4400 is the first available offset for LBA35 with default >

Re: [U-Boot] [PATCH v3 06/18] efi_loader: consistently use efi_status_t in bootefi

2017-10-22 Thread Simon Glass
On 18 October 2017 at 00:02, Heinrich Schuchardt wrote: > Where ulong or unsigned long are used to hold an EFI status > code we should consistenly use efi_status_t. nit: konsisstinley > > Signed-off-by: Heinrich Schuchardt > --- > v3 > new patch > --- > cmd/bootefi.c | 18 +

Re: [U-Boot] [PATCH v3 05/18] efi_loader: guard against double inclusion of efi_loader.h

2017-10-22 Thread Simon Glass
On 18 October 2017 at 00:02, Heinrich Schuchardt wrote: > Use a define to detect double inclusion of efi_loader.h. > > Signed-off-by: Heinrich Schuchardt > --- > v3 > no change > v2 > new patch > --- > include/efi_loader.h | 7 ++- > 1 file changed, 6 insertions(+), 1 deletio

Re: [U-Boot] [PATCH v3 17/18] efi_selftest: provide test for EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL

2017-10-22 Thread Simon Glass
On 18 October 2017 at 00:02, Heinrich Schuchardt wrote: > The following services are tested: > OutputString, TestString, SetAttribute. > > Signed-off-by: Heinrich Schuchardt > --- > v3 > new patch > --- > lib/efi_selftest/Makefile | 5 ++- > lib/efi_selftest/efi_selftes

Re: [U-Boot] [PATCH v2 4/4] pylibfdt: compile pylibfdt only when dtoc/binman is necessary

2017-10-22 Thread Simon Glass
Hi Masahiro, On 17 October 2017 at 06:42, Masahiro Yamada wrote: > Currently, pylibfdt is always compiled if swig is installed on your > machine. It is really annoying because most of targets (excepts > x86, sunxi, rockchip) do not use dtoc or binman. > > "checkbinman" and "checkdtoc" are wrong.

Re: [U-Boot] [PATCH v2 5/9] efi_loader: guard against double inclusion of efi_loader.h

2017-10-22 Thread Simon Glass
On 13 October 2017 at 19:33, Heinrich Schuchardt wrote: > Use a define to detect double inclusion of efi_loader.h. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > new patch > --- > include/efi_loader.h | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) Reviewed-by: Simon

Re: [U-Boot] [PATCH] efi_loader: Decouple EFI input/output from stdin/stdout

2017-10-22 Thread Simon Glass
Hi, On 10 October 2017 at 10:12, Alexander Graf wrote: > > > On 10.10.17 02:27, Rob Clark wrote: >> On Mon, Sep 11, 2017 at 10:04 AM, Rob Clark wrote: >>> In some cases, it is quite useful to have (for example) EFI on screen >>> but u-boot on serial port. >>> >>> Signed-off-by: Rob Clark >>> --

Re: [U-Boot] [PATCH 1/5] libfdt: change fdt.h to a wrapper of scripts/dtc/libfdt/*

2017-10-22 Thread Simon Glass
Hi Masahiro, On 17 October 2017 at 15:30, Masahiro Yamada wrote: > Fortunately, U-Boot did not modify fdt.h locally. > > Change it to a wrapper of scripts/dtc/libfdt/fdt.h, which will be > periodically synced with the upstream DTC (or kernel). > > Signed-off-by: Masahiro Yamada > --- > > includ

Re: [U-Boot] [PATCH v2 2/2] ARM: dts: OMAP5+: Add support for bandgap sensor in SPL

2017-10-22 Thread Simon Glass
On 9 October 2017 at 14:17, Faiz Abbas wrote: > Mark bandgap node as uboot,dm-spl so that it can be accessed in spl > > Signed-off-by: Faiz Abbas > --- > arch/arm/dts/omap5-u-boot.dtsi | 4 > 1 file changed, 4 insertions(+) Reviewed-by: Simon Glass

Re: [U-Boot] [PATCH] drivers: core: Add translation in live tree case

2017-10-22 Thread Simon Glass
Hi Mario, On 13 October 2017 at 13:21, Mario Six wrote: > The function dev_read_addr calls ofnode_get_addr_index in the live tree > case, which does not apply bus translations to the address read from the > device tree. This results in illegal addresses on boards that rely on > bus translations b

Re: [U-Boot] [PATCH] rockchip: rk3399: init CPU clock when rkclk_init()

2017-10-22 Thread Simon Glass
On 12 October 2017 at 09:27, Kever Yang wrote: > Init the CPU and its buses to speed up the boot time. > Move rkclk_init() to a place after rk3399_configure_cpu has defined > at the same time, or else there will be a warning. > > Signed-off-by: Kever Yang > --- > > drivers/clk/rockchip/clk_rk339

Re: [U-Boot] [PATCH v2 8/9] test/py: test reboot by EFI watchdog

2017-10-22 Thread Simon Glass
On 13 October 2017 at 19:33, Heinrich Schuchardt wrote: > Clear environment variable efi_selftest before executing the > default tests. > > Provide a test verifying that the EFI watchdog > reboots the system upon timeout. > > The test depends on CONFIG_CMD_EFI_SELFTEST=y. > > Signed-off-by: Heinri

Re: [U-Boot] [PATCH v2 1/2] thermal: ti-bandgap: Add support for temperature sensor

2017-10-22 Thread Simon Glass
On 9 October 2017 at 14:17, Faiz Abbas wrote: > The dra7xx series of SOCs contain a temperature sensor and an > associated analog-to-digital converter (ADC) which produces > an output which is proportional to the SOC temperature. > Add support for this temperature sensor. > > Signed-off-by: Faiz A

Re: [U-Boot] [PATCH] usb: xhci: Add Renesas R-Car xHCI driver

2017-10-22 Thread Simon Glass
Hi Bin, On 9 October 2017 at 09:16, Bin Meng wrote: > Hi Marek, > > On Mon, Oct 9, 2017 at 2:34 AM, Marek Vasut wrote: >> Add firmware V3, firmware loader and XHCI glue for the Renesas R-Car >> Gen3 SoCs XHCI controller. Thus far only the R-Car Gen3 R8A7795 ES2.0+ >> and R8A7796 are supported. >

Re: [U-Boot] [PATCH] imx: serial: Wait for ongoing transmission to finish before serial reset

2017-10-22 Thread Simon Glass
Hi Lucasz, On 9 October 2017 at 12:46, Łukasz Majewski wrote: > Hi Simon, > >> Hi Lukasz, >> >> On 3 October 2017 at 03:16, Lukasz Majewski wrote: >>> >>> It may happen that the MXC serial IP block is performing some ongoing >>> transmission (started at e.g. board_init()) when the "initr_serial"

[U-Boot] PLL cpux allwinner H3

2017-10-22 Thread Mark L .
Hi, The formula for the PLL CPUX output is (24Mhz * N * K) / (M * P). Is there a problem applying N = 32 && K = 2 instead of N = 16 and K = 4 (M and P being equal)? I am asking if there is a pattern to respect or not at all. Thanks --  Mark ___ U-Boo

[U-Boot] [PATCH 8/9] efi_loader: rework efi_locate_handle

2017-10-22 Thread Heinrich Schuchardt
Check the parameters in efi_locate_handle. Use list_for_each_entry instead of list_for_each. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_boottime.c | 44 +++ 1 file changed, 32 insertions(+), 12 deletions(-) diff --git a/lib/efi_loader/efi_

[U-Boot] [PATCH 7/9] efi_loader: consistently use efi_uintn_t in boot services

2017-10-22 Thread Heinrich Schuchardt
Consistenly use efi_uintn_t wherever the UEFI spec uses UINTN in boot services interfaces. Signed-off-by: Heinrich Schuchardt --- include/efi_api.h | 29 ++- include/efi_loader.h| 12 lib/efi_loader/efi_boottime.c

[U-Boot] [PATCH 5/9] efi_loader: remove unused typedef for INTN

2017-10-22 Thread Heinrich Schuchardt
INTN is not used in the coding. Signed-off-by: Heinrich Schuchardt --- include/efi_api.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/efi_api.h b/include/efi_api.h index fcd7483ab2..8ea44b1a7a 100644 --- a/include/efi_api.h +++ b/include/efi_api.h @@ -29,7 +29,6 @@ enum efi_timer_d

[U-Boot] [PATCH 9/9] efi_loader: rework efi_search_obj

2017-10-22 Thread Heinrich Schuchardt
EFI_HANDLEs are used both in boottime and in runtime services. efi_search_obj is a function that can be used to validate handles. So let's make it accessible via efi_loader.h. We can simplify the coding using list_for_each_entry. Signed-off-by: Heinrich Schuchardt --- include/efi_loader.h

[U-Boot] [PATCH 0/9] efi_loader: clean up protocol services

2017-10-22 Thread Heinrich Schuchardt
This patch series supplies a test case for boottime protocol services that are used to manage protocols on handles. The other patches do not introduce any new functionality but clean up the code. This series should be merged after "efi_loader: implement SetWatchdogTimer". Next think I am prepari

[U-Boot] [PATCH 6/9] efi_loader: replace UINTN by efi_uintn_t

2017-10-22 Thread Heinrich Schuchardt
UINTN is used in the UEFI specification for unsigned integers matching the bitness of the CPU. Types in U-Boot should be lower case. The patch replaces it by efi_uintn_t. Suggested-by: Simon Glass Suggested-by: Rob Clark Signed-off-by: Heinrich Schuchardt --- include/efi_api.h

[U-Boot] [PATCH 2/9] efi_selftest: test protocol management

2017-10-22 Thread Heinrich Schuchardt
This unit test checks the following protocol services: InstallProtocolInterface, UninstallProtocolInterface, InstallMultipleProtocolsInterfaces, UninstallMultipleProtocolsInterfaces, HandleProtocol, ProtocolsPerHandle, LocateHandle, LocateHandleBuffer. As UninstallProtocolInterface and UninstallMu

[U-Boot] [PATCH 1/9] efi_loader: capitalize EFI_LOCATE_SEARCH_TYPE values

2017-10-22 Thread Heinrich Schuchardt
Constants should be capitalized. So rename the values of enum efi_locate_search_type. Signed-off-by: Heinrich Schuchardt --- include/efi.h | 6 +++--- lib/efi_loader/efi_boottime.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/efi.h b/include/

[U-Boot] [PATCH 4/9] efi_loader: eliminate efi_uninstall_protocol_interface_ext

2017-10-22 Thread Heinrich Schuchardt
As we now have EFI_CALL there is no need for separate functions efi_uninstall_protocol_interface_ext and efi_uninstall_protocol_interface. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_boottime.c | 42 -- 1 file changed, 12 insertions(+), 30 de

[U-Boot] [PATCH 3/9] efi_loader: eliminate efi_install_protocol_interface_ext

2017-10-22 Thread Heinrich Schuchardt
As we now have EFI_CALL there is no need for separate functions efi_install_protocol_interface_ext and efi_install_protocol_interface. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_boottime.c | 52 +-- 1 file changed, 15 insertions(+), 37 delet

Re: [U-Boot] [RFC] Attempt to Add SPL Support to imx6q_logic

2017-10-22 Thread Lukasz Majewski
Hi Adam, > The Logic PD i.MX6 dev kit is capable of SPL. This patch follows > a similar method as the mx6sabresd > > Following instructions I found which show to put the SPL and .img > files on the SD card with dd. > > sudo dd if=SPL of=/dev/xxx bs=1K seek=1; sync > sudo dd if=u-boot.img of=/de

[U-Boot] [PATCH V2] ARM: imx6: Enable UMS and DFU on DHCOM i.MX6 PDK

2017-10-22 Thread Marek Vasut
Enable UMS and DFU, so that the eMMC can be accessed via the USB gadget port on the board. Signed-off-by: Marek Vasut Cc: Stefano Babic --- V2: Replace G_DNL with USB_GADGET as suggested by Lukasz --- board/dhelectronics/dh_imx6/dh_imx6.c | 10 ++ configs/dh_imx6_defconfig |