Re: [U-Boot] [PATCH] dm: video: fix abuse of enum

2017-06-22 Thread Lothar Waßmann
Hi, On Wed, 21 Jun 2017 09:59:05 +0200 Lothar Waßmann wrote: > Hi, > > On Tue, 20 Jun 2017 12:26:29 -0600 Simon Glass wrote: > > Hi Lothar, > > > > On 20 June 2017 at 04:25, Lothar Waßmann wrote: > > > LCD_MAX_WIDTH, LCD_MAX_HEIGHT and LCD_MAX_LSBPP are not alternative > > > values for one spec

Re: [U-Boot] Initilize IDE prior environment

2017-06-22 Thread Heiko Schocher
Hello, Am 23.06.2017 um 01:49 schrieb Tom Rini: On Thu, Jun 22, 2017 at 10:05:48AM -0600, Simon Glass wrote: Hi Bin, On 20 June 2017 at 17:19, Bin Meng wrote: +Simon On Wed, Jun 21, 2017 at 4:08 AM, Otavio Salvador wrote: On Tue, Jun 20, 2017 at 2:42 PM, Tom Rini wrote: On Mon, Jun 19,

Re: [U-Boot] [PATCH v6 5/8] usb: dwc2: use dev_read_bool() instead of fdt_getprop()

2017-06-22 Thread rock-chips(daniel.meng)
On 2017/6/23 1:29, Heiko Stuebner wrote: Hi, Am Mittwoch, 21. Juni 2017, 11:58:24 CEST schrieb Meng Dongyang: Use dev_read_bool() instead of fdt_getprop() to get the property from DTS. And add a comment for "hnp-srp-disable" property to fully describe its effect. Signed-off-by: Meng Dongyang

Re: [U-Boot] Initilize IDE prior environment

2017-06-22 Thread Tom Rini
On Thu, Jun 22, 2017 at 10:05:48AM -0600, Simon Glass wrote: > Hi Bin, > > On 20 June 2017 at 17:19, Bin Meng wrote: > > > > +Simon > > > > On Wed, Jun 21, 2017 at 4:08 AM, Otavio Salvador > > wrote: > > > On Tue, Jun 20, 2017 at 2:42 PM, Tom Rini wrote: > > >> On Mon, Jun 19, 2017 at 11:56:04A

[U-Boot] mpc85xx boards

2017-06-22 Thread Simon Glass
Hi York, There are about 258 mpc85xx boards. In converting things to Kconfig quite a bit of the work comes in this area. I am just wondering if all these boards are still needed, or it would be possible to prune them a bit? I see you have already done a bit of this. Regards, Simon ___

Re: [U-Boot] [PATCH] net: add static to do_tftpput()

2017-06-22 Thread Joe Hershberger
On Thu, Jun 22, 2017 at 2:49 AM, Masahiro Yamada wrote: > This is only used in cmd/net.c > > Signed-off-by: Masahiro Yamada Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v6 5/8] usb: dwc2: use dev_read_bool() instead of fdt_getprop()

2017-06-22 Thread Heiko Stuebner
Hi, Am Mittwoch, 21. Juni 2017, 11:58:24 CEST schrieb Meng Dongyang: > Use dev_read_bool() instead of fdt_getprop() to get the property > from DTS. And add a comment for "hnp-srp-disable" property to > fully describe its effect. > > Signed-off-by: Meng Dongyang > --- > > Changes in v6: > - New

Re: [U-Boot] [PATCH] Revert 'rockchip: mkimage: remove placeholder functions from rkimage'

2017-06-22 Thread Dr. Philipp Tomsich
Guillaume, > On 22 Jun 2017, at 10:11, Guillaume GARDET wrote: > > Revert commit 253c60a557d6740f15169a1f15772d7e64928d9b as it breaks the > return value of 'mkimage -T rkimage' and print the following error: > './tools/mkimage: Can't print header for Rockchip Boot Image support: Success’ If

Re: [U-Boot] Initilize IDE prior environment

2017-06-22 Thread Simon Glass
Hi Bin, On 20 June 2017 at 17:19, Bin Meng wrote: > > +Simon > > On Wed, Jun 21, 2017 at 4:08 AM, Otavio Salvador > wrote: > > On Tue, Jun 20, 2017 at 2:42 PM, Tom Rini wrote: > >> On Mon, Jun 19, 2017 at 11:56:04AM -0300, Otavio Salvador wrote: > >> > >>> To allow the loading of environment fr

[U-Boot] [PATCH] mx6: soc: Fix typo in temperature unit name

2017-06-22 Thread Fabio Estevam
The correct name is 'Celsius', so fix it accordingly. Signed-off-by: Fabio Estevam --- arch/arm/cpu/armv7/mx6/soc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/cpu/armv7/mx6/soc.c b/arch/arm/cpu/armv7/mx6/soc.c index dd94797..2bedbdb 100644 --- a/arch/arm/cpu/arm

Re: [U-Boot] [PATCH v3] powerpc: Restore core of mpc8xx

2017-06-22 Thread Heiko Schocher
Hello Christophe, Am 22.06.2017 um 13:20 schrieb Christophe LEROY: Le 22/06/2017 à 11:59, Wolfgang Denk a écrit : Dear Christophe, In message <0784ad6e-86ab-9c1d-1b81-a5cacaf2b...@c-s.fr> you wrote: Please see my previous comments to Tom's message. At least, please clean up the directory

Re: [U-Boot] [PATCH v2 06/13] drivers: usb: dwc3: add ti dwc3 peripheral driver with driver model support

2017-06-22 Thread Lukasz Majewski
On Thu, 22 Jun 2017 17:42:38 +0530 Vignesh R wrote: > > > On Wednesday 21 June 2017 01:39 PM, Lukasz Majewski wrote: > > Hi Vignesh, > > > >> Hi, > >> > >> On Tuesday 20 June 2017 07:14 PM, Lukasz Majewski wrote: > >>> Hi Marek, Vignesh, > >> [...] > > > > All gadget drivers like ether

Re: [U-Boot] [PATCH v2 06/13] drivers: usb: dwc3: add ti dwc3 peripheral driver with driver model support

2017-06-22 Thread Vignesh R
On Wednesday 21 June 2017 01:39 PM, Lukasz Majewski wrote: > Hi Vignesh, > >> Hi, >> >> On Tuesday 20 June 2017 07:14 PM, Lukasz Majewski wrote: >>> Hi Marek, Vignesh, >> [...] > > All gadget drivers like ether.c or f_mass_storage.c call > usb_gadget_handle_interrupts() just passing

Re: [U-Boot] [PATCH v3] powerpc: Restore core of mpc8xx

2017-06-22 Thread Christophe LEROY
Le 22/06/2017 à 11:59, Wolfgang Denk a écrit : Dear Christophe, In message <0784ad6e-86ab-9c1d-1b81-a5cacaf2b...@c-s.fr> you wrote: Please see my previous comments to Tom's message. At least, please clean up the directory structure and get rid of unrelated (4xx) and untested/broken code (b

[U-Boot] [PATCH] arch: armv8: Remove the error when dcache is off

2017-06-22 Thread Siva Durga Prasad Paladugu
Remove the error which causes compilation failure when dcache is off for builds otherthan SPL. There may be cases where user wants to disable dcache completely eventhough it is not SPL. Signed-off-by: Siva Durga Prasad Paladugu --- arch/arm/cpu/armv8/cache_v8.c | 9 - 1 file changed, 9 d

Re: [U-Boot] [PATCH v3] powerpc: Restore core of mpc8xx

2017-06-22 Thread Wolfgang Denk
Dear Christophe, In message <0784ad6e-86ab-9c1d-1b81-a5cacaf2b...@c-s.fr> you wrote: > > > Please see my previous comments to Tom's message. At least, please > > clean up the directory structure and get rid of unrelated (4xx) and > > untested/broken code (bedbug, probably kgdb, pcmcia, usb). >

[U-Boot] [PATCH 1/2] arm64: dts: uniphier: add support for LD11 Global board

2017-06-22 Thread Masahiro Yamada
From: Kunihiko Hayashi Add initial device tree support for LD11 Global board. Signed-off-by: Kunihiko Hayashi Signed-off-by: Masahiro Yamada --- arch/arm/dts/Makefile | 1 + arch/arm/dts/uniphier-ld11-global.dts | 79 +++ 2 files changed, 80 i

[U-Boot] [PATCH 2/2] arm64: dts: uniphier: add support for LD20 Global board

2017-06-22 Thread Masahiro Yamada
From: Kunihiko Hayashi Add initial device tree support for LD20 Global board. Signed-off-by: Kunihiko Hayashi Signed-off-by: Masahiro Yamada --- arch/arm/dts/Makefile | 1 + arch/arm/dts/uniphier-ld20-global.dts | 61 +++ 2 files changed, 62 i

Re: [U-Boot] [PATCH] usb: add static to local symbols

2017-06-22 Thread Marek Vasut
On 06/22/2017 09:35 AM, Masahiro Yamada wrote: > Sparse reports "... was not declared. Should it be static?" > > Signed-off-by: Masahiro Yamada Applied, thanks. > --- > > drivers/usb/host/ehci-hcd.c | 2 +- > drivers/usb/host/usb-uclass.c | 18 +- > drivers/usb/host/xhci-dw

Re: [U-Boot] [PATCH 2/2] pinctrl: a3700: Fix the issue that gpio controller is registered with wrong node id

2017-06-22 Thread Stefan Roese
On 22.06.2017 11:13, m...@marvell.com wrote: From: Ken Ma In armada_37xx_gpiochip_register, the return value of fdtdec_get_bool should be true when gpio-controller is found; current codes makes a wrong inverse return value judgement, this patch fixes it. Signed-off-by: Ken Ma Cc: Stefan Roese

Re: [U-Boot] [PATCH 1/2] pinctrl: a3700: Fix uart2 group selection register mask

2017-06-22 Thread Stefan Roese
Hi Ken, On 22.06.2017 11:13, m...@marvell.com wrote: > From: Ken Ma > > If north bridge selection register bit1 is clear, pins [10:8] are for > SDIO0 Resetn, Wakeup, and PDN while if bit1 is set, pins [10:8]are for > GPIO; when bit1 is clear, pin 9 and pin 10 can be used for uart2 RTSn > and CTS

Re: [U-Boot] at91: smartweb board fails with current HEAD

2017-06-22 Thread Yang, Wenyou
Hello Wolfgang, On 2017/6/22 15:07, Wolfgang Denk wrote: Dear Wenyou, In message you wrote: After supporting the driver model and device tree, the size of SPL is beyond 4K. SPL is not suitable in 4K internal SRAM If you are aware of this situation, you should not post patches that break a

[U-Boot] [PATCH 1/2] pinctrl: a3700: Fix uart2 group selection register mask

2017-06-22 Thread make
From: Ken Ma If north bridge selection register bit1 is clear, pins [10:8] are for SDIO0 Resetn, Wakeup, and PDN while if bit1 is set, pins [10:8]are for GPIO; when bit1 is clear, pin 9 and pin 10 can be used for uart2 RTSn and CTSn, so bit1 should be added to uart2 group and it must be set for b

[U-Boot] [PATCH 2/2] pinctrl: a3700: Fix the issue that gpio controller is registered with wrong node id

2017-06-22 Thread make
From: Ken Ma In armada_37xx_gpiochip_register, the return value of fdtdec_get_bool should be true when gpio-controller is found; current codes makes a wrong inverse return value judgement, this patch fixes it. Signed-off-by: Ken Ma Cc: Stefan Roese Cc: Kostya Porotchkin Cc: Gregory CLEMENT C

[U-Boot] [PATCH 0/2] *** SUBJECT HERE ***

2017-06-22 Thread make
From: Ken Ma *** BLURB HERE *** Fix 2 armada-37xx pinctrl issues. Ken Ma (2): pinctrl: a3700: Fix uart2 group selection register mask pinctrl: a3700: Fix the issue that gpio controller is registered with wrong node id drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 7 --- 1 file chan

Re: [U-Boot] [PATCH] efi_loader: add static to local functions

2017-06-22 Thread Bin Meng
On Thu, Jun 22, 2017 at 4:49 PM, Masahiro Yamada wrote: > These are locally used in lib/efi_loader/efi_boottime.c > > Signed-off-by: Masahiro Yamada > --- > > lib/efi_loader/efi_boottime.c | 20 +++- > 1 file changed, 11 insertions(+), 9 deletions(-) > Reviewed-by: Bin Meng ___

[U-Boot] [PATCH] mmc: cadence: use fdt32_t for DT property value to fix sparse warning

2017-06-22 Thread Masahiro Yamada
DTB is encoded in big endian. When we retrieve property values, we need to use fdt32_to_cpu (aka be32_to_cpu) for endian conversion. This is a bit error-prone, but sparse is useful to detect endian mismatch. We need to use (fdt32_t *) instead of (u32 *) for a pointer of a property value. Otherwi

[U-Boot] [PATCH] dm: ofnode: use fdt32_t for DT property value to fix sparse warning

2017-06-22 Thread Masahiro Yamada
DTB is encoded in big endian. When we retrieve property values, we need to use fdt32_to_cpu (aka be32_to_cpu) for endian conversion. This is a bit error-prone, but sparse is useful to detect endian mismatch. We need to use (fdt32_t *) instead of (u32 *) for a pointer of a property value. Otherwi

Re: [U-Boot] [PATCHv2] powerpc: Restore core of mpc8xx

2017-06-22 Thread Christophe LEROY
Le 21/06/2017 à 23:43, Tom Rini a écrit : On Wed, Jun 21, 2017 at 11:41:02PM +0200, Christophe LEROY wrote: Le 21/06/2017 à 17:26, Tom Rini a écrit : From: Christophe Leroy Please fill me in better with v3. I squahed the previous 1-10 into a single commit that brings back the core of mpc8

[U-Boot] [PATCH] efi_loader: add static to local functions

2017-06-22 Thread Masahiro Yamada
These are locally used in lib/efi_loader/efi_boottime.c Signed-off-by: Masahiro Yamada --- lib/efi_loader/efi_boottime.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c index 51080cbeed2f..ba

Re: [U-Boot] [PATCH] dm: include from driver/core/dump.c

2017-06-22 Thread Bin Meng
On Thu, Jun 22, 2017 at 4:12 PM, Masahiro Yamada wrote: >> dm: include from driver/core/dump.c > > A typo in the subject. > I mean "drivers/core/dump.c" > Reviewed-by: Bin Meng ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinf

Re: [U-Boot] [PATCH 11/11] powerpc, 8xx: Add a directory for soon to come boards from CSSI

2017-06-22 Thread Christophe LEROY
Le 22/06/2017 à 09:20, Wolfgang Denk a écrit : Dear Tom, In message <20170621152200.GJ27196@bill-the-cat> you wrote: With what I'm going to send out as a v2 of the rest of the series, I'm OK with not including an empty directory for now and bringing back mpc8xx, thanks again! Sorry, but I

Re: [U-Boot] [PATCH v3] powerpc: Restore core of mpc8xx

2017-06-22 Thread Christophe LEROY
Le 22/06/2017 à 09:35, Wolfgang Denk a écrit : Dear Christophe Leroy, In message <20170621213804.c5aca67...@pc13941vm.idsi0.si.c-s.fr> you wrote: Signed-off-by: Christophe Leroy --- v3: Fixed build error in arch/powerpc/include/asm/ppc.h ; removed commproc.h from 4xx v2: Tom squashed p

Re: [U-Boot] [PATCH] mmc: add static to spl_mmc_get_device_index()

2017-06-22 Thread Bin Meng
On Thu, Jun 22, 2017 at 4:22 PM, Masahiro Yamada wrote: > 2017-06-22 16:52 GMT+09:00 Masahiro Yamada : >> This function is only used in common/spl/spl_mmc.c[ > > The '[' at the end of line is a typo. > > Please drop it when applied. > Reviewed-by: Bin Meng ___

Re: [U-Boot] [PATCH] i2c_eeprom: add static to i2c_eeprom_std_ops/probe

2017-06-22 Thread Bin Meng
On Thu, Jun 22, 2017 at 3:51 PM, Masahiro Yamada wrote: > These are only used in drivers/mis/i2c_eeprom.c > > Signed-off-by: Masahiro Yamada > --- > > drivers/misc/i2c_eeprom.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Bin Meng _

Re: [U-Boot] [PATCH] mmc: add static to spl_mmc_get_device_index()

2017-06-22 Thread Masahiro Yamada
2017-06-22 16:52 GMT+09:00 Masahiro Yamada : > This function is only used in common/spl/spl_mmc.c[ The '[' at the end of line is a typo. Please drop it when applied. -- Best Regards Masahiro Yamada ___ U-Boot mailing list U-Boot@lists.denx.de https

Re: [U-Boot] [PATCH] gpio: add static to get_function()

2017-06-22 Thread Bin Meng
On Thu, Jun 22, 2017 at 3:50 PM, Masahiro Yamada wrote: > Signed-off-by: Masahiro Yamada > --- > > drivers/gpio/gpio-uclass.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Bin Meng ___ U-Boot mailing list U-Boot@lists.den

Re: [U-Boot] [PATCH] dm: include from drivers/core/util.c

2017-06-22 Thread Bin Meng
On Thu, Jun 22, 2017 at 3:50 PM, Masahiro Yamada wrote: > Fix sparse warnings "... was not declared. Should it be static?" > > Also, fix redefinition of dm_warn/dm_dbg. > > Signed-off-by: Masahiro Yamada > --- > > drivers/core/util.c | 5 + > 1 file changed, 5 insertions(+) > Reviewed-by: B

Re: [U-Boot] [PATCH] net: add static to do_tftpput()

2017-06-22 Thread Bin Meng
On Thu, Jun 22, 2017 at 3:49 PM, Masahiro Yamada wrote: > This is only used in cmd/net.c > > Signed-off-by: Masahiro Yamada > --- > > cmd/net.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng ___ U-Boot mailing list U-

Re: [U-Boot] [PATCH] serial: make serial_stub_* to static functions

2017-06-22 Thread Bin Meng
On Thu, Jun 22, 2017 at 3:48 PM, Masahiro Yamada wrote: > Add missing static to serial_stub_puts(). > > Unexport serial_stub_{getc,tstc} because they are used locally. > > Signed-off-by: Masahiro Yamada > --- > > drivers/serial/serial-uclass.c | 11 +++ > drivers/serial/serial.c|

Re: [U-Boot] [PATCH] usb: add static to local symbols

2017-06-22 Thread Bin Meng
On Thu, Jun 22, 2017 at 3:35 PM, Masahiro Yamada wrote: > Sparse reports "... was not declared. Should it be static?" > > Signed-off-by: Masahiro Yamada > --- > > drivers/usb/host/ehci-hcd.c | 2 +- > drivers/usb/host/usb-uclass.c | 18 +- > drivers/usb/host/xhci-dwc3.c | 2

Re: [U-Boot] [PATCH] dm: include from driver/core/dump.c

2017-06-22 Thread Masahiro Yamada
> dm: include from driver/core/dump.c A typo in the subject. I mean "drivers/core/dump.c" 2017-06-22 17:10 GMT+09:00 Masahiro Yamada : > Include to fix sparse warnings: > symbol 'dm_dump_all' was not declared. Should it be static? > symbol 'dm_dump_uclass' was not declared. Should it be stati

[U-Boot] [PATCH] Revert 'rockchip: mkimage: remove placeholder functions from rkimage'

2017-06-22 Thread Guillaume GARDET
Revert commit 253c60a557d6740f15169a1f15772d7e64928d9b as it breaks the return value of 'mkimage -T rkimage' and print the following error: './tools/mkimage: Can't print header for Rockchip Boot Image support: Success' Signed-off-by: Guillaume GARDET Cc: Philipp Tomsich Cc: Simon Glass Cc:

[U-Boot] [PATCH] dm: include from driver/core/dump.c

2017-06-22 Thread Masahiro Yamada
Include to fix sparse warnings: symbol 'dm_dump_all' was not declared. Should it be static? symbol 'dm_dump_uclass' was not declared. Should it be static? Signed-off-by: Masahiro Yamada --- drivers/core/dump.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/core/dump.c b/drivers/co

[U-Boot] [PATCH 3/5] dm: ofnode: rename ofnode_read_prop() to ofnode_get_property()

2017-06-22 Thread Masahiro Yamada
This function returns the pointer to the value of a node property. The current name ofnode_read_prop() is confusing. Follow the naming of_get_property() from Linux. The return type (const u32 *) is wrong. DT property values can be strings as well as integers. This is why of_get_property/fdt_get

[U-Boot] [PATCH 4/5] dm: ofnode: rename dev_read_prop() to dev_get_property()

2017-06-22 Thread Masahiro Yamada
The previous commit renamed ofnode_read_prop() to ofnode_get_propery() and fixed its return type. Likewise, rename dev_read_prop() and fix its return type. Signed-off-by: Masahiro Yamada --- drivers/core/read.c| 3 ++- drivers/input/key_matrix.c | 4 ++-- include/dm/read.h | 9

[U-Boot] [PATCH 5/5] dm: ofnode: simplify ofnode_read_bool()

2017-06-22 Thread Masahiro Yamada
Reuse ofnode_get_property() to simplify the implementation. Signed-off-by: Masahiro Yamada --- drivers/core/ofnode.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/core/ofnode.c b/drivers/core/ofnode.c index 87e731dc2b77..5a3e1d452fbb 100644 --- a/dri

[U-Boot] [PATCH 2/5] dm: ofnode: simplify ofnode_read_prop()

2017-06-22 Thread Masahiro Yamada
The code inside the if-block is the same as of_get_property(). Signed-off-by: Masahiro Yamada --- drivers/core/ofnode.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/core/ofnode.c b/drivers/core/ofnode.c index b8b16bf5e275..08b3e03b1e8e 100644 --- a/dr

[U-Boot] [PATCH 1/5] dm: ofnode: use ofnode_read_bool() to check property existence

2017-06-22 Thread Masahiro Yamada
This will clarify the code. Signed-off-by: Masahiro Yamada --- drivers/core/ofnode.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/core/ofnode.c b/drivers/core/ofnode.c index ac312d654654..b8b16bf5e275 100644 --- a/drivers/core/ofnode.c +++ b/drivers/cor

[U-Boot] [PATCH] mmc: add static to spl_mmc_get_device_index()

2017-06-22 Thread Masahiro Yamada
This function is only used in common/spl/spl_mmc.c[ Signed-off-by: Masahiro Yamada --- common/spl/spl_mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/spl/spl_mmc.c b/common/spl/spl_mmc.c index 18c1b59b22cc..bb48cac1efac 100644 --- a/common/spl/spl_mmc.c +++ b/co

[U-Boot] [PATCH] i2c_eeprom: add static to i2c_eeprom_std_ops/probe

2017-06-22 Thread Masahiro Yamada
These are only used in drivers/mis/i2c_eeprom.c Signed-off-by: Masahiro Yamada --- drivers/misc/i2c_eeprom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/i2c_eeprom.c b/drivers/misc/i2c_eeprom.c index da6e2b05f730..a14e83225bcc 100644 --- a/drivers/misc/i

[U-Boot] [PATCH] gpio: add static to get_function()

2017-06-22 Thread Masahiro Yamada
Signed-off-by: Masahiro Yamada --- drivers/gpio/gpio-uclass.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-uclass.c b/drivers/gpio/gpio-uclass.c index f611996f1729..9faf3357af8b 100644 --- a/drivers/gpio/gpio-uclass.c +++ b/drivers/gpio/gpio-uclass.c

[U-Boot] [PATCH] dm: include from drivers/core/util.c

2017-06-22 Thread Masahiro Yamada
Fix sparse warnings "... was not declared. Should it be static?" Also, fix redefinition of dm_warn/dm_dbg. Signed-off-by: Masahiro Yamada --- drivers/core/util.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/core/util.c b/drivers/core/util.c index 5ceac8bbb15b..2e232d57a14f

[U-Boot] [PATCH] serial: make serial_stub_* to static functions

2017-06-22 Thread Masahiro Yamada
Add missing static to serial_stub_puts(). Unexport serial_stub_{getc,tstc} because they are used locally. Signed-off-by: Masahiro Yamada --- drivers/serial/serial-uclass.c | 11 +++ drivers/serial/serial.c| 4 ++-- include/common.h | 5 - 3 files changed, 9

[U-Boot] [PATCH] net: add static to do_tftpput()

2017-06-22 Thread Masahiro Yamada
This is only used in cmd/net.c Signed-off-by: Masahiro Yamada --- cmd/net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/net.c b/cmd/net.c index df8b6c9b53f0..5e91d3ab8a19 100644 --- a/cmd/net.c +++ b/cmd/net.c @@ -42,7 +42,7 @@ U_BOOT_CMD( ); #ifdef CONFIG_CMD_TF

[U-Boot] [PATCH] ARM: dts: uniphier: sync DT with Linux next-20170622

2017-06-22 Thread Masahiro Yamada
Signed-off-by: Masahiro Yamada --- arch/arm/dts/uniphier-ld11-ref.dts | 2 +- arch/arm/dts/uniphier-ld11.dtsi | 40 ++--- arch/arm/dts/uniphier-ld20-ref.dts | 2 +- arch/arm/dts/uniphier-ld20.dtsi | 40 ++--- arc

[U-Boot] [PATCH] ARM: uniphier: fix various sparse warnings

2017-06-22 Thread Masahiro Yamada
Fix warnings reported by sparse: - ... was not declared. Should it be static?" - cast to restricted __be32 While fixing those, the type conflict of cci500_init() was found. Signed-off-by: Masahiro Yamada --- arch/arm/mach-uniphier/arm64/arm-cci500.c| 2 ++ arch/arm/mach-uniphier/arm64/s

[U-Boot] Please pull u-boot-x86

2017-06-22 Thread Bin Meng
Hi Tom, The following changes since commit 235c5b8315c6a9eb566fd3d99a098cc6db869fc5: Merge branch 'master' of git://git.denx.de/u-boot-samsung (2017-06-21 08:01:07 -0400) are available in the git repository at: git://git.denx.de/u-boot-x86.git for you to fetch changes up to c8f258d8a8452b9

[U-Boot] [PATCH] usb: add static to local symbols

2017-06-22 Thread Masahiro Yamada
Sparse reports "... was not declared. Should it be static?" Signed-off-by: Masahiro Yamada --- drivers/usb/host/ehci-hcd.c | 2 +- drivers/usb/host/usb-uclass.c | 18 +- drivers/usb/host/xhci-dwc3.c | 2 +- drivers/usb/host/xhci.c | 4 ++-- 4 files changed, 13 insert

Re: [U-Boot] [PATCH v3] powerpc: Restore core of mpc8xx

2017-06-22 Thread Wolfgang Denk
Dear Christophe Leroy, In message <20170621213804.c5aca67...@pc13941vm.idsi0.si.c-s.fr> you wrote: > Signed-off-by: Christophe Leroy > --- > v3: Fixed build error in arch/powerpc/include/asm/ppc.h ; removed commproc.h > from 4xx > > v2: Tom squashed patches 1-10 of the serie Please see my pr

Re: [U-Boot] [PATCHv2] powerpc: Restore core of mpc8xx

2017-06-22 Thread Wolfgang Denk
Dear Tom, In message <1498058762-1909-1-git-send-email-tr...@konsulko.com> you wrote: > > Please fill me in better with v3. I squahed the previous 1-10 into a > single commit that brings back the core of mpc8xx. Please add an entry > to MAINTAINERS for yourself for mpc8xx and do a travis-ci bui

Re: [U-Boot] [PATCH 11/11] powerpc, 8xx: Add a directory for soon to come boards from CSSI

2017-06-22 Thread Wolfgang Denk
Dear Tom, In message <20170621152200.GJ27196@bill-the-cat> you wrote: > > With what I'm going to send out as a v2 of the rest of the series, I'm > OK with not including an empty directory for now and bringing back > mpc8xx, thanks again! Sorry, but I disagree here. This revert series is a mess.

[U-Boot] [PATCH v2 04/18] usb: xhci: Add input slot context in xhci_set_configuration()

2017-06-22 Thread Bin Meng
A valid input slot context for a 'configure endpoint' command requires the 'Context Entries' field to be initialized to the index of the last valid endpoint context that is defined by the target configuration. We set up the 'Context Entries' field, but we forget to include the input slot context in

[U-Boot] [PATCH v2 12/18] configs: Remove CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS in all boards

2017-06-22 Thread Bin Meng
Now that xHCD does not use CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS, remove it in all boards' config files. Signed-off-by: Bin Meng Reviewed-by: Simon Glass Reviewed-by: Stefan Roese Tested-by: Stefan Roese --- Changes in v2: None include/configs/am43xx_evm.h | 1 - include/configs/am57xx

[U-Boot] [PATCH v2 08/18] usb: hub: Change USB hub descriptor to match USB 3.0 hubs

2017-06-22 Thread Bin Meng
USB 3.0 hubs have a slightly different hub descriptor than USB 2.0 hubs, with a fixed (rather than variable length) size. Change the host controller drivers that access those last two fields (DeviceRemovable and PortPowerCtrlMask) to use the union. Signed-off-by: Bin Meng Reviewed-by: Simon Glass

[U-Boot] [PATCH v2 15/18] usb: cmd: Print actual packet size for super speed devices

2017-06-22 Thread Bin Meng
USB 3.0 defines bMaxPacketSize0 field in the device descriptor as the exponent of 2, so let's print the calculated actual size. Signed-off-by: Bin Meng Reviewed-by: Simon Glass Reviewed-by: Stefan Roese Tested-by: Stefan Roese --- Changes in v2: - Change to use uint and also 'normal' variabl

[U-Boot] [PATCH v2 14/18] configs: Remove CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS in all boards

2017-06-22 Thread Bin Meng
Now that EHCD does not use CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS, remove it in all boards' config files. Signed-off-by: Bin Meng Reviewed-by: Simon Glass Reviewed-by: Stefan Roese Tested-by: Stefan Roese --- Changes in v2: None arch/arm/include/asm/ehci-omap.h| 4 include/configs/MPC8

[U-Boot] [PATCH v2 16/18] usb: xhci: Convert CONFIG_USB_XHCI_PCI to Kconfig

2017-06-22 Thread Bin Meng
Add CONFIG_USB_XHCI_PCI as a Kconfig option. Signed-off-by: Bin Meng Reviewed-by: Simon Glass Reviewed-by: Stefan Roese Tested-by: Stefan Roese --- Changes in v2: - Update description to use "PCI-based" - Remove CONFIG_USB_XHCI_PCI from config_whitelist.txt drivers/usb/host/Kconfig | 6

[U-Boot] [PATCH v2 17/18] x86: minnowmax: Add a environment variable for USB power-on delay

2017-06-22 Thread Bin Meng
Occasionally it was observed that on Intel MinnowMax board, with a USB 2.0 device connected to the bottom port, when doing 'usb start' on the xHCI controller: scanning bus 0 for devices... cannot reset port 3!? But neither of the two USB ports is routed to xHCI root port 3. Adding some debug in

[U-Boot] [PATCH v2 18/18] x86: minnowmax: Enable USB xHCI support

2017-06-22 Thread Bin Meng
BayTrail SoC supports both EHCI and xHCI controllers. However only one host controller (either EHCI or xHCI) can be used. To enable HSIC and SS ports, xHCI must be used. This turns on xHCI support on Intel MinnowMax board. Signed-off-by: Bin Meng Reviewed-by: Simon Glass Reviewed-by: Stefan Roes

[U-Boot] [PATCH v2 10/18] usb: xhci: Change MAX_HC_PORTS to 255

2017-06-22 Thread Bin Meng
HCSPARAMS1:MaxPorts field specifies the maximum port number value, and its valid values are in the range of 1 to 255. Signed-off-by: Bin Meng Reviewed-by: Simon Glass Reviewed-by: Stefan Roese Tested-by: Stefan Roese --- Changes in v2: None drivers/usb/host/xhci.h | 6 +++--- 1 file changed

[U-Boot] [PATCH v2 11/18] usb: xhci: Get rid of CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS

2017-06-22 Thread Bin Meng
xHC reports supported maximum number of ports in the HCSPARAMS1 register, so it's unnecessary to use a hardcoded config option CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS. Signed-off-by: Bin Meng Reviewed-by: Simon Glass Reviewed-by: Stefan Roese Tested-by: Stefan Roese --- Changes in v2: None drive

[U-Boot] [PATCH v2 06/18] usb: hub: Send correct wValue to get hub descriptor of a USB 3.0 hub

2017-06-22 Thread Bin Meng
Testing a USB 3.0 hub by connecting it to the xHCI port on Intel MinnowMax, when issuing 'get hub descriptor' to the hub, xHCI reports a transfer event TRB with a completion code 6 which means 'Stall Error'. In fact super speed USB hub descriptor type is 0x2a, not 0x29. Sending correct SETUP packe

[U-Boot] [PATCH v2 09/18] usb: hub: Add 3.0 hub port status mask of 2.0 hub

2017-06-22 Thread Bin Meng
USB 3.0 hub port status has different bit position regarding to port power, port speed, etc. But others are the same as 2.0 hubs. Signed-off-by: Bin Meng Reviewed-by: Simon Glass Reviewed-by: Stefan Roese Tested-by: Stefan Roese --- Changes in v2: None include/usb_defs.h | 7 ++- 1 file

[U-Boot] [PATCH v2 13/18] usb: ehci: Get rid of CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS

2017-06-22 Thread Bin Meng
EHC reports supported maximum number of ports in the HCSPARAMS register, so it's unnecessary to use a hardcoded config option CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS. Signed-off-by: Bin Meng Reviewed-by: Simon Glass Reviewed-by: Stefan Roese Tested-by: Stefan Roese --- Changes in v2: None driver

[U-Boot] [PATCH v2 05/18] usb: hub: Update handling connect status/change in usb_scan_port()

2017-06-22 Thread Bin Meng
It was observed that on Intel MinnowMax board, when xHCI is enabled in the BayTrail SoC, with a USB 3.0 device connected to the bottom USB 3.0 port (mapped to xHCI root port #7), its PORTSC register is always 0x201203 (CCS = 1, CSC = 0). The root cause of such behavior is unknown yet. Connect statu

[U-Boot] [PATCH v2 07/18] usb: hub: Revise wLength for 'get port status' request

2017-06-22 Thread Bin Meng
For accuracy, we should use 'sizeof(struct usb_port_status)' as the wLength for 'get port status' request, although it happens to be equal to 'sizeof(struct usb_hub_status)'. Signed-off-by: Bin Meng Reviewed-by: Simon Glass Reviewed-by: Stefan Roese Tested-by: Stefan Roese --- Changes in v2:

[U-Boot] [PATCH v2 01/18] usb: xhci: Remove incorrect comments for struct xhci_container_ctx

2017-06-22 Thread Bin Meng
There is no member called 'dma' in struct xhci_container_ctx. Remove the comments that mentions it. Signed-off-by: Bin Meng Reviewed-by: Simon Glass Reviewed-by: Stefan Roese Tested-by: Stefan Roese --- Changes in v2: None drivers/usb/host/xhci.h | 3 +-- 1 file changed, 1 insertion(+), 2 d

[U-Boot] [PATCH v2 03/18] usb: xhci: Initialize scratchpad buffer array and scratchpad buffers

2017-06-22 Thread Bin Meng
The scratchpad buffer array is used to define the locations of statically allocated memory pages that are available for the private use of the xHC. The xHCI spec explicitly mentions that system software shall allocate the scratchpad buffers before placing the xHC in to Run mode (Run/Stop (R/S) = ‘1

[U-Boot] [PATCH v2 02/18] usb: xhci: Correct command TRB 4th dword initialization

2017-06-22 Thread Bin Meng
In xhci_queue_command(), when the command is not 'reset endpoint', 'stop endpoint' or 'set TR dequeue pointer', endpoint ID should not be encoded in the TRB. Signed-off-by: Bin Meng Reviewed-by: Simon Glass Reviewed-by: Stefan Roese Tested-by: Stefan Roese --- Changes in v2: None drivers/us

[U-Boot] [PATCH v2 00/18] usb: xhci: Fix USB xHCI support on Intel platform

2017-06-22 Thread Bin Meng
Currently U-Boot xHCI driver does not work on Intel BayTrail SoC based boards that have USB 3.0 ports. Trying to do a 'usb start' simply hangs the board. This series fixes a bunch of xHCI driver issues to make it work on Intel's platform. Issues identified in the U-Boot xHCI driver are really spec

Re: [U-Boot] at91: smartweb board fails with current HEAD

2017-06-22 Thread Wolfgang Denk
Dear Wenyou, In message you wrote: > > After supporting the driver model and device tree, the size of SPL is beyond > 4K. > SPL is not suitable in 4K internal SRAM If you are aware of this situation, you should not post patches that break a number of existing boards. Instead, we should search