[U-Boot] [PATCH] treewide: remove unneeded semicolons

2017-06-12 Thread Masahiro Yamada
Signed-off-by: Masahiro Yamada --- arch/powerpc/cpu/ppc4xx/speed.c| 2 +- board/amcc/bamboo/bamboo.c | 2 +- board/amcc/luan/luan.c | 2 +- board/freescale/s32v234evb/clock.c | 2 +- board/ti/beagle/beagle.c | 6 +++--- board/tqc/tqm5200/cmd_stk52xx.c|

Re: [U-Boot] dtb build issue on U-Boot

2017-06-12 Thread Masahiro Yamada
Hi Kever, Simon, Sorry for my late reply. 2017-06-07 6:16 GMT+09:00 Simon Glass : > +Masahiro > > On 6 June 2017 at 05:45, Kever Yang wrote: >> >> I notice that the dtb content in spl/u-boot-spl.bin and u-boot.bin not >> >> able to update after I modify the dts file and make again, I have to >> >

Re: [U-Boot] am335x_evm_usbspl_defconfig testint

2017-06-12 Thread Vignesh R
On Monday 12 June 2017 10:12 PM, Jason Kridner wrote: > I see you submitted this defconfig: > https://lists.denx.de/pipermail/u-boot/2016-November/272425.html > > I have a Google Summer of Code student intern attempting to use it and he's > seeing it hang without entering UMS mode. Details are

[U-Boot] [PATCH 12/12] power: regulator: lp87565: get_enable should return integer

2017-06-12 Thread Keerthy
get_enable should be able to return error values. Hence change the return type to integer. Signed-off-by: Keerthy --- drivers/power/regulator/lp87565_regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/regulator/lp87565_regulator.c b/drivers/power/regul

[U-Boot] [PATCH 08/12] power: regulator: rk8xx: get_enable should return integer

2017-06-12 Thread Keerthy
get_enable should be able to return error values. Hence change the return type to integer. Signed-off-by: Keerthy --- drivers/power/regulator/rk8xx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/power/regulator/rk8xx.c b/drivers/power/regulator/rk8xx.c index

[U-Boot] [PATCH 00/12] regulator: Change get_enable return type to integer from bool

2017-06-12 Thread Keerthy
Change get_enable return type to int so errors can be returned. The series converts the return type of get_enable hook in the dm_regulator_ops to integer from bool. This enables it to return any error values if any. Compile tested. Keerthy (12): regulator: Change get_enable return type to integ

[U-Boot] [PATCH 03/12] power: regulator: act8846: get_enable should return integer

2017-06-12 Thread Keerthy
get_enable should be able to return error values. Hence change the return type to integer. Signed-off-by: Keerthy --- drivers/power/regulator/act8846.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/regulator/act8846.c b/drivers/power/regulator/act8846.c index

[U-Boot] [PATCH 05/12] power: regulator: palmas: get_enable should return integer

2017-06-12 Thread Keerthy
get_enable should be able to return error values. Hence change the return type to integer. Signed-off-by: Keerthy --- drivers/power/regulator/palmas_regulator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/power/regulator/palmas_regulator.c b/drivers/power/reg

[U-Boot] [PATCH 02/12] power: regulator: fixed: get_enable should return integer

2017-06-12 Thread Keerthy
get_enable should be able to return error values. Hence change the return type to integer. Signed-off-by: Keerthy --- drivers/power/regulator/fixed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/regulator/fixed.c b/drivers/power/regulator/fixed.c index 656371

[U-Boot] [PATCH 09/12] power: sandbox: fixed: get_enable should return integer

2017-06-12 Thread Keerthy
get_enable should be able to return error values. Hence change the return type to integer. Signed-off-by: Keerthy --- drivers/power/regulator/sandbox.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/power/regulator/sandbox.c b/drivers/power/regulator/sandbox.c i

[U-Boot] [PATCH 10/12] power: regulator: s5m8767: get_enable should return integer

2017-06-12 Thread Keerthy
get_enable should be able to return error values. Hence change the return type to integer. Signed-off-by: Keerthy --- drivers/power/regulator/s5m8767.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/power/regulator/s5m8767.c b/drivers/power/regulator/s5m8767.c i

[U-Boot] [PATCH 11/12] power: regulator: lp873x: get_enable should return integer

2017-06-12 Thread Keerthy
get_enable should be able to return error values. Hence change the return type to integer. Signed-off-by: Keerthy --- drivers/power/regulator/lp873x_regulator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/power/regulator/lp873x_regulator.c b/drivers/power/reg

[U-Boot] [PATCH 07/12] power: regulator: tps65090: get_enable should return integer

2017-06-12 Thread Keerthy
get_enable should be able to return error values. Hence change the return type to integer. Signed-off-by: Keerthy --- drivers/power/regulator/tps65090_regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/regulator/tps65090_regulator.c b/drivers/power/reg

[U-Boot] [PATCH 06/12] power: regulator: pfuze100: get_enable should return integer

2017-06-12 Thread Keerthy
get_enable should be able to return error values. Hence change the return type to integer. Signed-off-by: Keerthy --- drivers/power/regulator/pfuze100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/regulator/pfuze100.c b/drivers/power/regulator/pfuze100.c in

[U-Boot] [PATCH 04/12] power: regulator: max77686: get_enable should return integer

2017-06-12 Thread Keerthy
get_enable should be able to return error values. Hence change the return type to integer. Signed-off-by: Keerthy --- drivers/power/regulator/max77686.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/power/regulator/max77686.c b/drivers/power/regulator/max77686.

[U-Boot] [PATCH 01/12] regulator: Change get_enable return type to integer from bool

2017-06-12 Thread Keerthy
Change get_enable return type to int so errors can be returned. Signed-off-by: Keerthy --- drivers/power/regulator/regulator-uclass.c | 2 +- include/power/regulator.h | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/power/regulator/regulator-

Re: [U-Boot] [PATCH 2/3] regulator: lp873x: Fix the return value of ldo_get_enable function

2017-06-12 Thread Keerthy
On Tuesday 13 June 2017 05:21 AM, Simon Glass wrote: > On 10 June 2017 at 23:01, Keerthy wrote: >> The function wrongly returned an integer while it is supposed to >> return boolean. Fix that. >> >> Fixes: 99785de83 ("power: regulator: lp873x: Add regulator support") >> Signed-off-by: Keerthy >

Re: [U-Boot] [PATCH v8 4/7] arm: socfpga: Enable FPGA driver on SPL

2017-06-12 Thread Chee, Tien Fong
On Isn, 2017-06-12 at 16:38 +0800, Chee, Tien Fong wrote: > On Jum, 2017-06-09 at 08:52 -0500, Dinh Nguyen wrote: > > > > > > On 06/09/2017 03:25 AM, Marek Vasut wrote: > > > > > > > > > > > > I didn't really look since we still have a discussion open on V8 > > > . > > > There > > > is no poin

Re: [U-Boot] [PATCH 23/29] dm: ahci: Create a local version of two SCSI functions

2017-06-12 Thread Bin Meng
On Tue, Jun 6, 2017 at 3:15 AM, Simon Glass wrote: > With driver model we need to define implementations of exec() and > bus_reset() separately for each SCSI driver. As a first step, create a > local version of each function in the AHCI driver and call each from its > global version. > > Signed-of

Re: [U-Boot] [PATCH 20/29] dm: scsi: Add operations

2017-06-12 Thread Bin Meng
On Tue, Jun 6, 2017 at 3:15 AM, Simon Glass wrote: > Add operations for SCSI. These are not yet implemented, but we have the > struct. > > Signed-off-by: Simon Glass > --- > > include/scsi.h | 20 > 1 file changed, 20 insertions(+) > Reviewed-by: Bin Meng _

Re: [U-Boot] [PATCH 19/29] dm: ahci: Drop use of probe_ent

2017-06-12 Thread Bin Meng
On Tue, Jun 6, 2017 at 3:15 AM, Simon Glass wrote: > With driver model we cannot have static data or assume that there is only > one device of each time. Adjust the code so that 'probe_ent' is not needed > with driver model. Add a new ahci_init_dm() function which can init AHCI > for driver model

Re: [U-Boot] [PATCH 24/29] dm: scsi: Add operations for SCSI devices

2017-06-12 Thread Bin Meng
On Tue, Jun 6, 2017 at 3:15 AM, Simon Glass wrote: > The SCSI uclass currently has no operations. It just uses the global SCSI > functions. Fix this by adding operations to the only two drivers that use > the uclass, and replacing the global functions with those defined locally > in the SCSI code.

Re: [U-Boot] [PATCH 28/29] dm: scsi: Drop scsi_init() when driver model is used

2017-06-12 Thread Bin Meng
On Tue, Jun 6, 2017 at 3:15 AM, Simon Glass wrote: > This function should not be used with driver model. Update the code to > reflect this. > > Signed-off-by: Simon Glass > --- > > drivers/scsi/scsi.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > Reviewed-by: Bin Meng ___

Re: [U-Boot] [PATCH 26/29] dm: scsi: Split out the bus scanning code

2017-06-12 Thread Bin Meng
On Tue, Jun 6, 2017 at 3:15 AM, Simon Glass wrote: > Split out the code that scans a single SCSI bus into a separate function. > This will allow it to be used from driver model. > > Signed-off-by: Simon Glass > --- > > drivers/scsi/scsi.c | 35 +++ > include/scsi.

Re: [U-Boot] [PATCH 29/29] RFC: x86: Move link to use driver model for SCSI

2017-06-12 Thread Bin Meng
Hi Simon, On Tue, Jun 6, 2017 at 3:15 AM, Simon Glass wrote: > As a demonstration of how to use SCSI with driver model, move link over > to use this. This patch needs more work, but illustrates the concept. > > Signed-off-by: Simon Glass > --- > > arch/x86/cpu/ivybridge/sata.c | 38

Re: [U-Boot] [PATCH 25/29] dm: scsi: Adjust return value of scsi_exec()

2017-06-12 Thread Bin Meng
On Tue, Jun 6, 2017 at 3:15 AM, Simon Glass wrote: > Change this function to return an error number instead of true/false. > This allows us to return a proper error number. > > Signed-off-by: Simon Glass > --- > > drivers/ata/ahci.c | 6 +++--- > drivers/scsi/scsi.c | 8 > 2 files chan

Re: [U-Boot] [PATCH 18/29] dm: ahci: Unwind the confusing init code

2017-06-12 Thread Bin Meng
On Tue, Jun 6, 2017 at 3:15 AM, Simon Glass wrote: > Two AHCI drivers use SCSI with CONFIG_DM_SCSI. The SCSI uclass calls > scsi_low_level_init() which is implemented by ahci.c. If > CONFIG_SCSI_AHCI_PLAT is defined it does one thing and if it is not > it does something else. > > We don't need to

Re: [U-Boot] [PATCH 17/29] dm: ahci: Move common code for starting ports into a function

2017-06-12 Thread Bin Meng
On Tue, Jun 6, 2017 at 3:15 AM, Simon Glass wrote: > This code is duplicated. Create a ahci_start_ports() function to handle > this and call it from both places. > > Signed-off-by: Simon Glass > --- > > drivers/ata/ahci.c | 45 ++--- > 1 file changed, 22 i

Re: [U-Boot] [PATCH 27/29] dm: ahci: Add a driver for SCSI on AHCI

2017-06-12 Thread Bin Meng
Hi Simon, On Tue, Jun 6, 2017 at 3:15 AM, Simon Glass wrote: > Some AHCI drivers use SCSI under the hood. Rather than making the AHCI > driver be in the SCSI uclass it makes sense to have the AHCI device create > a SCSI device as a child. That way we can handle any AHCI-specific > operations rath

Re: [U-Boot] [PATCH 21/29] dm: scsi: Add a device pointer to scan_exec(), scsi_bus_reset()

2017-06-12 Thread Bin Meng
On Tue, Jun 6, 2017 at 3:15 AM, Simon Glass wrote: > With driver model these functions need a device pointer. Add one even > when CONFIG_DM_SCSI is not defined. This avoids having ugly conditional > function prototypes, When CONFIG_DM_SCSI is not defined we can just ignore > the pointer. > > Signe

Re: [U-Boot] [PATCH 13/29] dm: ahci: Rename struct ahci_probe_ent

2017-06-12 Thread Bin Meng
On Tue, Jun 6, 2017 at 3:15 AM, Simon Glass wrote: > This is not a very useful name since once it is probed it still hangs > around. With driver model we will use uclass data for this, so rename the > struct. > > Signed-off-by: Simon Glass > --- > > board/highbank/ahci.c| 2 +- > drivers/at

Re: [U-Boot] [PATCH 11/29] dm: scsi: Drop the ccb typedef

2017-06-12 Thread Bin Meng
On Tue, Jun 6, 2017 at 3:14 AM, Simon Glass wrote: > We should not be using typedefs in U-Boot and 'ccb' is a pretty short > name. It is also used with variables. Drop the typedef and use 'struct' > instead. > > Signed-off-by: Simon Glass > --- > > common/usb_storage.c| 44 ++

Re: [U-Boot] [PATCH 22/29] dm: scsi: Document and rename the scsi_scan() parameter

2017-06-12 Thread Bin Meng
On Tue, Jun 6, 2017 at 3:15 AM, Simon Glass wrote: > The 'mode' parameter is actually a flag to determine whether to display > a list of devices found during the scan. Rename it to reflect this, add a > function comment and adjust callers to use a boolean. > > Signed-off-by: Simon Glass > --- > >

Re: [U-Boot] [PATCH 14/29] dm: sata: Move ataid into struct ahci_uc_priv

2017-06-12 Thread Bin Meng
On Tue, Jun 6, 2017 at 3:15 AM, Simon Glass wrote: > This array relates to the AHCI controller so should be exist out on its > own in the file. Move it into the structure. Adjust functions that need > access to this to take the structure as a parameter. > > Signed-off-by: Simon Glass > --- > > d

Re: [U-Boot] [PATCH 16/29] dm: scsi: Indent the confusing #ifdefs

2017-06-12 Thread Bin Meng
On Tue, Jun 6, 2017 at 3:15 AM, Simon Glass wrote: > These are very confusing without some sort of indentation. At some point > we will be able to remove them, but for now, indent them. > > Signed-off-by: Simon Glass > --- > > drivers/scsi/scsi.c | 26 +- > 1 file changed

Re: [U-Boot] [PATCH 15/29] dm: ahci: Refactor to avoid static variables

2017-06-12 Thread Bin Meng
On Tue, Jun 6, 2017 at 3:15 AM, Simon Glass wrote: > With driver model we need each device to have its own state. As a step > towards this, restrict use of the global 'probe_ent' to just a few places > in the file. This will allow us to add driver-model functions which can > pass the correct data

Re: [U-Boot] [PATCH 12/29] dm: scsi: Use the uclass platform data

2017-06-12 Thread Bin Meng
On Tue, Jun 6, 2017 at 3:14 AM, Simon Glass wrote: > At present the two driver-model SCSI drivers use device platform data to > store information that relates to the uclass. It is better to use uclass > platform data in this situation. Update the code to do this. > > Signed-off-by: Simon Glass >

Re: [U-Boot] [PATCH 10/29] dm: scsi: Rename struct SCSI_cmd_block to struct scsi_cmd

2017-06-12 Thread Bin Meng
On Tue, Jun 6, 2017 at 3:14 AM, Simon Glass wrote: > This name should be lower case. Also the _block suffix is superfluous. > Rename it. > > Signed-off-by: Simon Glass > --- > > drivers/usb/emul/sandbox_flash.c | 2 +- > include/scsi.h | 2 +- > 2 files changed, 2 insertions(+)

Re: [U-Boot] [PATCH 09/29] dm: scsi: Rearrange header file for driver model

2017-06-12 Thread Bin Meng
On Tue, Jun 6, 2017 at 3:14 AM, Simon Glass wrote: > Put the driver-model declarations first since we are migrating to that. > Also drop scsi_init() when driver model is used. > > Signed-off-by: Simon Glass > --- > > include/scsi.h | 34 ++ > 1 file changed, 14 in

Re: [U-Boot] [PATCH] imx: mx6ull: fix USB bmode for i.MX 6UL and 6ULL

2017-06-12 Thread Stefan Agner
On 2017-06-12 01:51, Esponde, Joel wrote: > Hi Stefan, > > Why did you take the value 0x20 in the table entry instead of the > value 0x00 as it is, for example, in the NXP U-Boot? 0x00 would mean b, which is WEIM (OneNAND/NOR flash, which is probably a likely boot device). 0x20 is no defined

Re: [U-Boot] [PATCH 06/29] Kconfig: Add CONFIG_SATA to enable SATA

2017-06-12 Thread Bin Meng
On Tue, Jun 6, 2017 at 3:14 AM, Simon Glass wrote: > At present CONFIG_CMD_SATA enables the 'sata' command which also brings > in SATA support. Some boards may wish to enable SATA without the command. > Add a separate CONFIG to permit this. > > Signed-off-by: Simon Glass > --- > > api/api_storag

Re: [U-Boot] [PATCH 08/29] scsi: Move drivers into new drivers/scsi directory

2017-06-12 Thread Bin Meng
On Tue, Jun 6, 2017 at 3:14 AM, Simon Glass wrote: > At present we have the SCSI drivers in the drivers/block and common/ > directories. It is better to split them out into their own place. Use > drivers/scsi which is what Linux does. > > Signed-off-by: Simon Glass > --- > > common/Makefile

Re: [U-Boot] [PATCH 04/29] scsi: Drop scsi_print_error()

2017-06-12 Thread Bin Meng
On Tue, Jun 6, 2017 at 3:14 AM, Simon Glass wrote: > This function is only defined by one driver and is empty. Move it into > the SCSI implementation itself. We could remove it, but it should be > useful for debugging. > > Signed-off-by: Simon Glass > --- > > common/scsi.c| 5 +++

Re: [U-Boot] [PATCH 07/29] sata: Move drivers into new drivers/ata directory

2017-06-12 Thread Bin Meng
On Tue, Jun 6, 2017 at 3:14 AM, Simon Glass wrote: > At present we have the SATA and PATA drivers mixed up in the drivers/block > directory. It is better to split them out into their own place. Use > drivers/ata which is what Linux does. > > Signed-off-by: Simon Glass > --- > > arch/powerpc/cpu/

Re: [U-Boot] [PATCH 05/29] Convert CONFIG_CMD_SATA to Kconfig

2017-06-12 Thread Bin Meng
On Tue, Jun 6, 2017 at 3:14 AM, Simon Glass wrote: > This converts the following to Kconfig: >CONFIG_CMD_SATA > > Signed-off-by: Simon Glass > --- > > arch/Kconfig | 1 + > arch/arm/cpu/armv7/mx6/Kconfig | 4 ++ > arch/arm/mach-mveb

Re: [U-Boot] [PATCH 03/29] scsi: Drop sym53c8xx driver

2017-06-12 Thread Bin Meng
On Tue, Jun 6, 2017 at 3:14 AM, Simon Glass wrote: > This driver is for a PowerPC board that will likely be removed soon. > Rather than converting it to driver model, drop it. > > Signed-off-by: Simon Glass > --- > > README | 5 - > board/mpl/pip405/README | 5 +- >

Re: [U-Boot] [PATCH 02/29] Convert CONFIG_SCSI to Kconfig

2017-06-12 Thread Bin Meng
Hi Simon, On Tue, Jun 6, 2017 at 3:14 AM, Simon Glass wrote: > This converts the following to Kconfig: >CONFIG_SCSI > > Signed-off-by: Simon Glass > --- > > README | 1 - > arch/Kconfig| 1 + > arch/arm/Kconfig

Re: [U-Boot] [PATCH 2/2] mmc: rpmb: update size format for write_counter

2017-06-12 Thread Kever Yang
Hi Simon, On 06/09/2017 08:28 PM, Simon Glass wrote: On 7 June 2017 at 19:20, Kever Yang wrote: According to MMC spec, the write_counter is 4-byte length, use 'int' instead of 'long' type for the 'long' is not 4-byte in 64 bit CPU. Signed-off-by: Jason Zhu Signed-off-by: Kever Yang ---

[U-Boot] [PATCH] rockchip: clk: rk3036: correct setting for pll integer mode

2017-06-12 Thread Kever Yang
According to rk3036 TRM, pll_con1[12] should be set to '1' for the pll integer mode, while the '0' means the frac mode. series-version: 2 series-changes: 2 - fix tpyo interger/integer Signed-off-by: Kever Yang Reviewed-by: Philipp Tomsich Acked-by: Simon Glass --- drivers/clk/rockchip/clk_rk

Re: [U-Boot] [U-Boot, RFC, 2/5] rockchip: boot0: align to 0x20 for armv7 '_start'

2017-06-12 Thread Kever Yang
Hi Philipp, On 06/10/2017 02:47 AM, Philipp Tomsich wrote: On Wed, 31 May 2017, Kever Yang wrote: The '_start' is using as vector table base address, and will write to VBAR register, need to align to 0x20 for armv7. Signed-off-by: Kever Yang --- arch/arm/include/asm/arch-rockchip/boot0.h

Re: [U-Boot] [RFC PATCH 1/5] armv7: move boot hook before '_start'

2017-06-12 Thread Kever Yang
Hi Marek, On 06/07/2017 02:28 PM, Marek Vasut wrote: On 06/07/2017 04:28 AM, Kever Yang wrote: Hi Andre, Steve, Marek, Could you help to check how to make it work with this patch on sunxi, bcm and socfpga platform? The socfpga expects the hook at that exact position (0x40 I think) , so

Re: [U-Boot] [RFC PATCH 0/5] move boot0 hook in the beginning for armv7

2017-06-12 Thread Kever Yang
Hi Simon, On 06/09/2017 08:27 PM, Simon Glass wrote: Hi Kever, On 7 June 2017 at 04:55, Kever Yang wrote: Simon, On 06/07/2017 11:15 AM, Simon Glass wrote: Hi Kever, On 6 June 2017 at 20:41, Kever Yang wrote: Simon, On 06/07/2017 05:08 AM, Simon Glass wrote: Hi Kever, On 31 May 2

Re: [U-Boot] [PATCH 01/29] configs: Resync with savedefconfig

2017-06-12 Thread Bin Meng
+Tom Hi Tom, On Tue, Jun 6, 2017 at 3:14 AM, Simon Glass wrote: > Rsync all defconfig files using moveconfig.py > > Signed-off-by: Simon Glass > --- > > configs/Sinovoip_BPI_M2_Plus_defconfig | 1 - > configs/UCP1020_SPIFLASH_defconfig | 2 +- > configs/UCP1020_defcon

Re: [U-Boot] [PATCH v2 3/3] test: Add a test for snprintf() and the banner/version

2017-06-12 Thread Bin Meng
On Sun, Jun 11, 2017 at 1:59 AM, Simon Glass wrote: > Add a simple test to make sure that these functions obey the buffer size > passed into them. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Fix buffer overflow problem when there is not enough space for the build tag > - Add test

Re: [U-Boot] [PATCH v2 2/3] Allow displaying the U-Boot banner on a video display

2017-06-12 Thread Bin Meng
Hi Simon, On Mon, Jun 12, 2017 at 11:17 PM, Simon Glass wrote: > Hi Bin, > > On 12 June 2017 at 09:13, Bin Meng wrote: >> Hi Simon, >> >> On Sun, Jun 11, 2017 at 1:59 AM, Simon Glass wrote: >>> At present the U-Boot banner is only displayed on the serial console. If >>> this is not visible to t

Re: [U-Boot] [PATCH v2 1/3] display_options: Refactor to allow obtaining the banner

2017-06-12 Thread Bin Meng
On Tue, Jun 13, 2017 at 3:28 AM, Stephen Warren wrote: > On 06/10/2017 11:59 AM, Simon Glass wrote: >> >> Move the display options code into a separate function so that the U-Boot >> banner can be obtained from other code. Adjust the 'version' command to >> use it. > > > This series passed my auto

Re: [U-Boot] [PATCH v1 0/4] Add FIT support for falcon boot

2017-06-12 Thread York Sun
On 06/12/2017 04:16 PM, André Przywara wrote: > On 09/06/17 19:48, york sun wrote: > > Hi York, > >> On 05/19/2017 02:56 AM, Andre Przywara wrote: >>> Hi York, >>> >>> On 16/05/17 16:54, york sun wrote: On 05/15/2017 10:42 PM, Lokesh Vutla wrote: > + Andre > > > On Monday 15

Re: [U-Boot] [beagleboard-gsoc] Re: am335x_evm_usbspl_defconfig testint

2017-06-12 Thread Michael Welling
On Mon, Jun 12, 2017 at 10:42:40AM -0700, Ravi Kumar Prasad wrote: > > > On Monday, June 12, 2017 at 10:13:08 PM UTC+5:30, Jason Kridner wrote: > > > > Stefan, > > > > I see you submitted this defconfig: > > https://lists.denx.de/pipermail/u-boot/2016-November/272425.html > > > > I have a Google

Re: [U-Boot] [PATCH v1 0/4] Add FIT support for falcon boot

2017-06-12 Thread André Przywara
On 09/06/17 19:48, york sun wrote: Hi York, > On 05/19/2017 02:56 AM, Andre Przywara wrote: >> Hi York, >> >> On 16/05/17 16:54, york sun wrote: >>> On 05/15/2017 10:42 PM, Lokesh Vutla wrote: + Andre On Monday 15 May 2017 09:31 PM, York Sun wrote: > This patch set adds FI

Re: [U-Boot] [PATCH v3 00/35] dm: tegra: Move nyan-big, jetson-tk1, beaver to livetree

2017-06-12 Thread Simon Glass
Hi Stephen, On 12 June 2017 at 13:52, Stephen Warren wrote: > On 06/12/2017 06:21 AM, Simon Glass wrote: >> >> This moves three entire boards to use a live device tree as an example of >> the impact. > > > This series appears to cause problems on a couple of boards: > > On both Jetson TK1 and Jet

Re: [U-Boot] [PATCH v3 00/35] dm: tegra: Move nyan-big, jetson-tk1, beaver to livetree

2017-06-12 Thread Stephen Warren
On 06/12/2017 02:09 PM, Simon Glass wrote: Hi Stephen, On 12 June 2017 at 13:52, Stephen Warren wrote: On 06/12/2017 06:21 AM, Simon Glass wrote: This moves three entire boards to use a live device tree as an example of the impact. This series appears to cause problems on a couple of boar

[U-Boot] [PATCH] defconfig: arm335x_evm_usbspl: Update MUSB Ethernet

2017-06-12 Thread Michael Welling
Adds CONFIG_SPL_USB_GADGET_SUPPORT and CONFIG_SPL_USBETH_SUPPORT. Removes CONFIG_SPL_NAND_SUPPORT, CONFIG_SPL_MTD_SUPPORT, and CONFIG_SPL_YMODEM_SUPPORT to free up space to fit in RAM. Signed-off-by: Michael Welling --- configs/am335x_evm_usbspl_defconfig | 5 - 1 file changed, 4 insertion

Re: [U-Boot] [PATCH v3 00/35] dm: tegra: Move nyan-big, jetson-tk1, beaver to livetree

2017-06-12 Thread Stephen Warren
On 06/12/2017 06:21 AM, Simon Glass wrote: This moves three entire boards to use a live device tree as an example of the impact. This series appears to cause problems on a couple of boards: On both Jetson TK1 and Jetson TX1 (p2372-180), "pci enum" fails with: ERROR: tegra-pcie: failed to powe

Re: [U-Boot] am335x_evm_usbspl_defconfig testint

2017-06-12 Thread Ravi Kumar Prasad
On Monday, June 12, 2017 at 10:13:08 PM UTC+5:30, Jason Kridner wrote: > > Stefan, > > I see you submitted this defconfig: > https://lists.denx.de/pipermail/u-boot/2016-November/272425.html > > I have a Google Summer of Code student intern attempting to use it and > he's seeing it hang without

Re: [U-Boot] [PATCH v3 3/4] rockchip: Add basic support for phyCORE-RK3288 SoM based carrier board

2017-06-12 Thread Simon Glass
On 12 June 2017 at 03:59, Wadim Egorov wrote: > The phyCORE-RK3288 is a SoM (System on Module) containing a RK3288 SoC. > The module can be connected to different carrier boards. > It can be also equipped with different RAM, SPI flash and eMMC variants. > The Rapid Development Kit option is using

Re: [U-Boot] [PATCH v3 4/4] doc: rockchip: Add phyCORE-RK3288 RDK to board list

2017-06-12 Thread Simon Glass
On 12 June 2017 at 03:59, Wadim Egorov wrote: > Signed-off-by: Wadim Egorov > Acked-by: Simon Glass > --- > Changes in v3: > - Added Acked-by: Simon Glass > --- > doc/README.rockchip | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Simon Glass __

Re: [U-Boot] [PATCH 2/3] regulator: lp873x: Fix the return value of ldo_get_enable function

2017-06-12 Thread Simon Glass
On 10 June 2017 at 23:01, Keerthy wrote: > The function wrongly returned an integer while it is supposed to > return boolean. Fix that. > > Fixes: 99785de83 ("power: regulator: lp873x: Add regulator support") > Signed-off-by: Keerthy > --- > drivers/power/regulator/lp873x_regulator.c | 2 +- > 1

Re: [U-Boot] [PATCH v3 2/4] power: regulator: rk8xx: Allow input current/charger shutdown configuration

2017-06-12 Thread Simon Glass
Hi Wadim, On 12 June 2017 at 03:59, Wadim Egorov wrote: > The RK818 PMIC contains a charger. Add very basic charger functionality > to be able to regulate the USB input current and charger shutdown limits. > > Signed-off-by: Wadim Egorov > --- > drivers/power/regulator/rk8xx.c | 34

Re: [U-Boot] [PATCH 1/3] regulator: lp87565: Fix the return value of buck_get_enable function

2017-06-12 Thread Simon Glass
On 10 June 2017 at 23:01, Keerthy wrote: > The function wrongly returned an integer while it is supposed to > return boolean. Fix that. > > Fixes: 2dd9dc02a3("power: regulator: lp87565: add regulator support") > Reported-by: Nishanth Menon > Signed-off-by: Keerthy > --- > drivers/power/regulato

Re: [U-Boot] [PATCH 13/13] rockchip: rk3066: add sdram init code for tpl

2017-06-12 Thread Simon Glass
Hi Pawel, On 9 June 2017 at 07:15, Paweł Jarosz wrote: > > > W dniu 09.06.2017 o 14:27, Simon Glass pisze: > >> Hi Pawel, >> >> On 7 June 2017 at 09:44, Paweł Jarosz wrote: >>> >>> Hi Simon, >>> >>> >>> W dniu 06.06.2017 o 23:10, Simon Glass pisze: >>> Hi Pawel, On 6 June 2017 at

Re: [U-Boot] [PATCH v3 1/4] power: regulator: rk8xx: Build get_ldo_reg only for SPL

2017-06-12 Thread Simon Glass
On 12 June 2017 at 03:58, Wadim Egorov wrote: > Enabling CONFIG_SPL_POWER_SUPPORT will cause a compiler warning: > ‘get_ldo_reg’ defined but not used [-Wunused-function] > > Let's wrap get_ldo_reg(), rk808_ldo and rk818_ldo with ENABLE_DRIVER > which is only set for non SPL builds. > > Signed-of

Re: [U-Boot] [PATCH] blk: dm: make blk_create_device() take a number of block instead of a size

2017-06-12 Thread Simon Glass
On 9 June 2017 at 08:45, Jean-Jacques Hiblot wrote: > There is an overflow problem when taking the size instead of the number > of blocks in blk_create_device(). This results in a wrong device size: the > device apparent size is its real size modulo 4GB. > Using the number of blocks instead of th

Re: [U-Boot] [PATCH v5 02/11] reset: add reset_count()

2017-06-12 Thread Simon Glass
Hi Patrice, On 12 June 2017 at 01:51, Patrice CHOTARD wrote: > > > On 06/12/2017 09:27 AM, Patrice CHOTARD wrote: >> Hi Simon >> >> On 06/06/2017 11:08 PM, Simon Glass wrote: >>> Hi, >>> >>> On 5 June 2017 at 05:18, Marek Vasut wrote: On 06/05/2017 11:34 AM, Patrice CHOTARD wrote: > Hi

Re: [U-Boot] [PATCH] dm: bcm6345_gpio: Set proper output level in bcm6345_gpio_direction_output

2017-06-12 Thread Simon Glass
On 8 June 2017 at 03:20, Axel Lin wrote: > Current code does not set output level in bcm6345_gpio_direction_output, > fix it. > > Signed-off-by: Axel Lin > --- > drivers/gpio/bcm6345_gpio.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Simon Glass _

Re: [U-Boot] [RFC PATCH 0/5] move boot0 hook in the beginning for armv7

2017-06-12 Thread Simon Glass
Hi Philipp, On 9 June 2017 at 06:59, Dr. Philipp Tomsich wrote: > Simon, > >> On 09 Jun 2017, at 14:27, Simon Glass wrote: >> >> Hi Kever, >> >> On 7 June 2017 at 04:55, Kever Yang wrote: >>> Simon, >>> >>> >>> >>> On 06/07/2017 11:15 AM, Simon Glass wrote: Hi Kever, On 6 Ju

Re: [U-Boot] [PATCH 12/13] armv7: support rk3066 early back to bootrom in start.S

2017-06-12 Thread Simon Glass
Hi Pawel, On 9 June 2017 at 06:31, Paweł Jarosz wrote: > > > W dniu 09.06.2017 o 13:46, Heiko Stuebner pisze: > >> Am Mittwoch, 7. Juni 2017, 17:37:13 CEST schrieb Paweł Jarosz: >>> >>> Hi Simon, >>> >>> >>> W dniu 06.06.2017 o 23:10, Simon Glass pisze: Hi Pawel, On 6 June 201

Re: [U-Boot] [PATCH 06/13] rockchip: rk3066: add core support

2017-06-12 Thread Simon Glass
Hi Pawel, On 9 June 2017 at 07:03, Paweł Jarosz wrote: > > > W dniu 09.06.2017 o 14:27, Simon Glass pisze: > >> Hi Pawel, >> >> On 7 June 2017 at 09:22, Paweł Jarosz wrote: >>> >>> Hi Simon >>> >>> >>> W dniu 06.06.2017 o 23:10, Simon Glass pisze: Hi Pawel, On 6 June 2017 at

Re: [U-Boot] [PATCH] ARM: provide a valid exception stack address for startup code

2017-06-12 Thread Simon Glass
On 8 June 2017 at 02:16, Lothar Waßmann wrote: > Create exception stack in IRAM if available to facilitate debugging of > pre-relocation code by catching exceptions rather than stopping dead. > > Signed-off-by: Lothar Waßmann > --- > arch/arm/lib/vectors.S | 5 - > 1 file changed, 4 insertio

Re: [U-Boot] [PATCH] ARM: remove bogus cp_delay() function

2017-06-12 Thread Simon Glass
On 8 June 2017 at 01:48, Lothar Waßmann wrote: > The cp_delay() function was introduced because of a missing 'volatile' > attribute to the 'asm' statement in get_cr() which led to the 'mrc' > instruction in get_cr() being optimised out eventually. > This has been fixed in commit 53fd4b8c22bb ("arm

[U-Boot] Pull request, u-boot-tegra/master

2017-06-12 Thread Tom Warren
Tom, Please pull u-boot-tegra/master into U-Boot/master. Thanks! All Tegra builds are OK, and Stephen's automated test system reports that all tests pass. The following changes since commit 8cb3ce64f936f5dedbcfc1935c5caf31bb682474: Merge git://git.denx.de/u-boot-dm (2017-06-10 18:01:22 -0400)

Re: [U-Boot] [PATCH v3 00/35] dm: tegra: Move nyan-big, jetson-tk1, beaver to livetree

2017-06-12 Thread Simon Glass
Hi Stephen, On 12 June 2017 at 15:39, Stephen Warren wrote: > On 06/12/2017 03:15 PM, Simon Glass wrote: >> >> [trimming the cc list a bit] >> >> Hi Stephen, >> >> On 12 June 2017 at 15:02, Stephen Warren wrote: >>> >>> On 06/12/2017 02:09 PM, Simon Glass wrote: Hi Stephen, >

Re: [U-Boot] arm: adjust PC displayed in exception handlers to point to the failing instruction

2017-06-12 Thread Tom Rini
On Thu, Jun 08, 2017 at 09:52:33AM +0200, Lothar Waßmann wrote: > Adjust the program counter register to point to the failing > instruction depending on the exeption type. > This makes it easier to localize the offending instruction leading to > a fatal exception. > > Signed-off-by: Lothar Waßman

Re: [U-Boot] MAINTAINERS: mpc83xx: Add new custodian

2017-06-12 Thread Tom Rini
On Fri, Jun 09, 2017 at 02:50:47PM +0200, mario@gdsys.cc wrote: > Add myself as mpc83xx custodian. Reviewed-by: Tom Rini -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/list

Re: [U-Boot] dm: bcm6345_gpio: Set proper output level in bcm6345_gpio_direction_output

2017-06-12 Thread Tom Rini
On Thu, Jun 08, 2017 at 05:20:12PM +0800, Axel Lin wrote: > Current code does not set output level in bcm6345_gpio_direction_output, > fix it. > > Signed-off-by: Axel Lin Reviewed-by: Tom Rini -- Tom signature.asc Description: Digital signature _

Re: [U-Boot] [U-Boot, 1/2] serial: stm32x7: align compatible with kernel one

2017-06-12 Thread Tom Rini
On Thu, Jun 08, 2017 at 09:26:54AM +0200, Patrice Chotard wrote: > From: Patrice Chotard > > stm32x7.c driver is dedicated for STM32F7. > In kernel, "st,stm32-usart" and "st,stm32-uart" compatible > strings are dedicated for STM32F4. > > To keep U-boot and kernel aligned, replace the serial com

Re: [U-Boot] [U-Boot, 03/10] fdtgrep: Deal with NULL data passed to check_type_include()

2017-06-12 Thread Tom Rini
On Wed, Jun 07, 2017 at 10:28:40AM -0600, Simon Glass wrote: > Since the parameter can be NULL we must be careful not to dereference it > in this case. > > Signed-off-by: Simon Glass > Reported-by: Coverity (CID: 163250) > Fixes: 1043d0a0 (fdt: Add fdtgrep tool) Reviewed-by: Tom Rini -- Tom

Re: [U-Boot] cmd: nvedit: bring error message in sync with condition under which it appears

2017-06-12 Thread Tom Rini
On Thu, Jun 08, 2017 at 02:16:14PM +0200, Lothar Waßmann wrote: > The list of symbols listed in the error message for missing Kconfig > symbols is out of sync with the symbols actually tested. > Add the missing symbols and reorder their appearance to be in sync > with the #if statement for easier

Re: [U-Boot] cmd: mtdparts: fix uninitialized variable warning

2017-06-12 Thread Tom Rini
On Thu, Jun 08, 2017 at 02:04:03PM +0200, Lothar Waßmann wrote: > commit 06a040a31bcf ("cmd: mtdparts: fix null pointer dereference in > parse_mtdparts") > removed the initialization of a pointer variable, which is > subsequently used in a debug() call. This produces an uninitialized > variable w

Re: [U-Boot] [U-Boot, 04/10] fdt: Add a check to do_fdt() for coverity

2017-06-12 Thread Tom Rini
On Wed, Jun 07, 2017 at 10:28:41AM -0600, Simon Glass wrote: > We know that fdt_getprop() does not return NULL when len is > 0 but > coverity does not. Add an extra check to keep it happy. > > Signed-off-by: Simon Glass > Reported-by: Coverity (CID: 163249) > Fixes: bc80295b (fdt: Add get comman

Re: [U-Boot] ARM: provide a valid exception stack address for startup code

2017-06-12 Thread Tom Rini
On Thu, Jun 08, 2017 at 10:16:36AM +0200, Lothar Waßmann wrote: > Create exception stack in IRAM if available to facilitate debugging of > pre-relocation code by catching exceptions rather than stopping dead. > > Signed-off-by: Lothar Waßmann Reviewed-by: Tom Rini -- Tom signature.asc Desc

Re: [U-Boot] tools/tbot: update README

2017-06-12 Thread Tom Rini
On Fri, Jun 09, 2017 at 06:13:34AM +0200, Heiko Schocher wrote: > refer in the README to tbots webpage, and delete > the README in tools/tbot, as the latest documentation > for tbot is on this webpage. > > Signed-off-by: Heiko Schocher Reviewed-by: Tom Rini -- Tom signature.asc Description

Re: [U-Boot] [U-Boot, v2, 3/3] arm: dra7: Set fastboot variables in environment

2017-06-12 Thread Tom Rini
On Mon, May 22, 2017 at 07:16:42PM +0300, Semen Protsenko wrote: > One can obtain those variables using next commands: > > $ fastboot getvar cpu > $ fastboot getvar secure > $ fastboot getvar board_rev > $ fastboot getvar userdata_size > > Those variables are needed for fastboot.

Re: [U-Boot] [U-Boot, 2/2] serial: stm32x7: simplify baud rate register calculation

2017-06-12 Thread Tom Rini
On Thu, Jun 08, 2017 at 09:26:55AM +0200, Patrice Chotard wrote: > From: Patrice Chotard > > Simplify baud rate register formula and use the oversampling > uart feature. > This code is aligned with what is implemented in kernel driver > drivers/tty/serial/stm32-usart.c since kernel v4.9. > > Si

Re: [U-Boot] [U-Boot, 01/10] test: pwm: Add a check that dev is not NULL

2017-06-12 Thread Tom Rini
On Wed, Jun 07, 2017 at 10:28:38AM -0600, Simon Glass wrote: > We know that uclass_get_device() does not return NULL for dev when it > succeeds but coverity does not. Add an extra check to hopefully keep it > happy. > > Signed-off-by: Simon Glass > Reported-by: Coverity (CID: 161690) > Fixes: 43

Re: [U-Boot] [U-Boot, 08/10] dm: core: Supress dead-code warning in __of_get_next_child()

2017-06-12 Thread Tom Rini
On Wed, Jun 07, 2017 at 10:28:45AM -0600, Simon Glass wrote: > Suppress a warning on next = next->sibling. > > Signed-off-by: Simon Glass > Reported-by: Coverity (CID: 163245) > Fixes 644ec0a (dm: core: Add livetree access functions) Reviewed-by: Tom Rini -- Tom signature.asc Description:

Re: [U-Boot] arm: am57xx: Keep environment in eMMC

2017-06-12 Thread Tom Rini
On Fri, Jun 09, 2017 at 05:12:56PM +0300, Semen Protsenko wrote: > Use eMMC (instead of SD card) to store U-Boot environment. Use > "reserved" partition for U-Boot environment. > > Signed-off-by: Sam Protsenko > Reviewed-by: Lokesh Vutla Reviewed-by: Tom Rini -- Tom signature.asc Descript

Re: [U-Boot] [U-Boot, 09/10] board_f: Use IS_ENABLED instead of #ifdef in initf_bootstage()

2017-06-12 Thread Tom Rini
On Wed, Jun 07, 2017 at 10:28:46AM -0600, Simon Glass wrote: > The current implementation makes it look like the 'if (from_spl)' part is > dead code because these features are not enabled for sandbox. We could > enable it for sandbox_spl, but this is not done yet (it requires sharing > memory betw

Re: [U-Boot] board: ti: am335x: Fix scale_vcore for beaglebones

2017-06-12 Thread Tom Rini
On Sat, Jun 10, 2017 at 01:22:56PM +0530, Lokesh Vutla wrote: > commit 0650798824 ("board: am335x: Introduce scale_vcores") > updated voltages of each board based on efuse. It updated > beagle bone specific voltages under the condition board_is_bone(). > But this is true only for BeagleBoneWhite.

Re: [U-Boot] arm: am57xx: Increase "bootloader" partition size

2017-06-12 Thread Tom Rini
On Fri, Jun 09, 2017 at 05:12:41PM +0300, Semen Protsenko wrote: > Increase the size of u-boot.img, so that it conforms with new DFU > configuration (see commit [1]). > > [1] 7a53a1a8115b ARM: ti: Update layout for MMC and eMMC (env and dfu) > > Signed-off-by: Sam Protsenko > Reviewed-by: Tom R

Re: [U-Boot] ARM: remove bogus cp_delay() function

2017-06-12 Thread Tom Rini
On Thu, Jun 08, 2017 at 09:48:41AM +0200, Lothar Waßmann wrote: > The cp_delay() function was introduced because of a missing 'volatile' > attribute to the 'asm' statement in get_cr() which led to the 'mrc' > instruction in get_cr() being optimised out eventually. > This has been fixed in commit 5

  1   2   3   >