[U-Boot] [PATCH V6] sf: Turn SPI flash chip into 3-Byte address mode

2015-08-11 Thread Zhiqiang Hou
From: Hou Zhiqiang For more than 16MiB SPI flash chips, there are 3-Byte and 4-Byte address mode, and only the 3-Byte address mode is supported in U-Boot so far. So, reset the SPI flash to 3-Byte address mode in probe to ensure the SPI flash work correctly, because it may has been set to 4-Byte a

Re: [U-Boot] [PATCH v2] powerpc/fsl: support low power boot for e500 and later

2015-08-11 Thread Wang Dongsheng
Hi Scott, > -Original Message- > From: Wood Scott-B07421 > Sent: Wednesday, August 12, 2015 1:18 PM > To: Wang Dongsheng-B40534 > Cc: Sun York-R58495; u-boot@lists.denx.de > Subject: Re: [PATCH v2] powerpc/fsl: support low power boot for e500 and later > > On Wed, 2015-08-12 at 00:15 -050

Re: [U-Boot] [PATCH v2] powerpc/fsl: support low power boot for e500 and later

2015-08-11 Thread Scott Wood
On Wed, 2015-08-12 at 00:50 -0500, Wang Dongsheng-B40534 wrote: > Hi Scott, > > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Wednesday, August 12, 2015 1:18 PM > > To: Wang Dongsheng-B40534 > > Cc: Sun York-R58495; u-boot@lists.denx.de > > Subject: Re: [PATCH v2] powerpc/fsl:

Re: [U-Boot] [PATCH v2] powerpc/fsl: support low power boot for e500 and later

2015-08-11 Thread Scott Wood
On Wed, 2015-08-12 at 00:15 -0500, Wang Dongsheng-B40534 wrote: > Hi Scott, > > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Wednesday, August 12, 2015 12:55 PM > > To: Wang Dongsheng-B40534 > > Cc: Sun York-R58495; u-boot@lists.denx.de > > Subject: Re: [PATCH v2] powerpc/fsl

Re: [U-Boot] [PATCH v2] powerpc/fsl: support low power boot for e500 and later

2015-08-11 Thread Wang Dongsheng
Hi Scott, > -Original Message- > From: Wood Scott-B07421 > Sent: Wednesday, August 12, 2015 12:55 PM > To: Wang Dongsheng-B40534 > Cc: Sun York-R58495; u-boot@lists.denx.de > Subject: Re: [PATCH v2] powerpc/fsl: support low power boot for e500 and later > > On Tue, 2015-08-11 at 15:15 +08

Re: [U-Boot] [PATCH v2] powerpc/fsl: support low power boot for e500 and later

2015-08-11 Thread Scott Wood
On Tue, 2015-08-11 at 15:15 +0800, Dongsheng Wang wrote: > From: Wang Dongsheng > > low power boot means u-boot will put non-boot cpus into a low power > status. Non-boot cpus don't need any more spin wait. e500, e500v2 will > going to DOZE status. e500mc, e5500, e6500 will going to PW10 state. >

Re: [U-Boot] [PATCH v1 0/2] Rename DDR4 target names

2015-08-11 Thread Priyanka Jain
Hello York, For T1040QDS, we can change the name. For T1024 also, I think there should not be any issue. Shengzhou please confirm. Regards Priyanka From: Sun York-R58495 Sent: Monday, August 10, 2015 8:18 PM To: Jain Priyanka-B32167; Sun York-R58495; U-Boot Mailing List Cc: Wood Scott-B07421; S

Re: [U-Boot] [ELCE 2015][Presentation] Proposal for U-boot Mini Summit presentation

2015-08-11 Thread Heiko Schocher
Hello Lukasz, Am 11.08.2015 um 23:19 schrieb Lukasz Majewski: Hi Stefan, Hi Lukasz, On 11.08.2015 10:45, Lukasz Majewski wrote: Please assess if the following presentation is suitable for the 2015 U-boot Mini Summit held at ELCE2015. __Title__ "Automated Test System - build blocks" __Abst

Re: [U-Boot] [PATCH v3 3/3] x86: Show the un-relocated IP address in exceptions

2015-08-11 Thread Simon Glass
On 10 August 2015 at 23:49, Bin Meng wrote: > On Tue, Aug 11, 2015 at 12:02 PM, Simon Glass wrote: >> When trying to figure out where an exception has occured, the relocated >> address is not a lot of help. Its value depends on various factors. Show >> the un-relocated IP as well. This can be loo

Re: [U-Boot] [PATCH v2 5/5] x86: Switch to using generic global_data setup

2015-08-11 Thread Simon Glass
On 11 August 2015 at 00:28, Bin Meng wrote: > On Tue, Aug 11, 2015 at 10:44 AM, Simon Glass wrote: >> There is quite a bit of assembler code that can be removed if we use the >> generic global_data setup. Less arch-specific code makes it easier to add >> new features and maintain the start-up cod

Re: [U-Boot] [PATCH v3 1/3] x86: Convert minnowmax to use CONFIG_DM_USB

2015-08-11 Thread Simon Glass
On 10 August 2015 at 23:49, Bin Meng wrote: > On Tue, Aug 11, 2015 at 12:02 PM, Simon Glass wrote: >> Move to driver model for USB on minnowmax. >> >> Signed-off-by: Simon Glass >> --- >> >> Changes in v3: >> - Use savedefconfig to tidy up the ordering >> >> Changes in v2: None >> >> configs/mi

Re: [U-Boot] [PATCH v2 2/5] Align global_data to a 16-byte boundary

2015-08-11 Thread Simon Glass
On 11 August 2015 at 00:28, Bin Meng wrote: > On Tue, Aug 11, 2015 at 10:44 AM, Simon Glass wrote: >> Some archs like to have larger alignment for their global data. Use 16 bytes >> which suits all current archs. >> >> Signed-off-by: Simon Glass >> --- >> >> Changes in v2: >> - Correct logic to

Re: [U-Boot] [PATCH] Revert "dm: pci: Allow scan bridge child devices before relocation"

2015-08-11 Thread Simon Glass
On 10 August 2015 at 21:12, Bin Meng wrote: > On Tue, Aug 11, 2015 at 10:54 AM, Simon Glass wrote: >> This reverts commit df189d9ba3f8fd1bc67e3c0c3c4ace16cd065ee1. >> >> Unfortunately this commit breaks chromebook_link because it adds lots of PCI >> devices >> before relocation and there is not

Re: [U-Boot] [PATCH v3 2/3] x86: Convert minnowmax to use CONFIG_DM_NET

2015-08-11 Thread Simon Glass
On 10 August 2015 at 23:49, Bin Meng wrote: > On Tue, Aug 11, 2015 at 12:02 PM, Simon Glass wrote: >> Move to driver model for networking on minnowmax. >> >> Signed-off-by: Simon Glass >> --- >> >> Changes in v3: >> - Use savedefconfig to tidy up the ordering >> >> Changes in v2: None >> >> boa

Re: [U-Boot] [PATCH v2 4/5] x86: Move the GDT into global_data

2015-08-11 Thread Simon Glass
On 10 August 2015 at 20:44, Simon Glass wrote: > Rather than keeping track of the Global Descriptor Table in its own memory > we may as well put it in global_data with everything else. As a first step, > stop using the separately allocated GDT. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Me

Re: [U-Boot] [PATCH v2 3/5] Allow arch-specific setting of global_data in board_init_f_mem()

2015-08-11 Thread Simon Glass
On 11 August 2015 at 00:28, Bin Meng wrote: > On Tue, Aug 11, 2015 at 10:44 AM, Simon Glass wrote: >> At present we have a simple assignment to gd. With some archs this is >> implemented as a register or through some other means; a simple assignment >> does not suit in all cases. >> >> Change thi

Re: [U-Boot] [PATCH v2 1/5] x86: Remove init_gd() function

2015-08-11 Thread Simon Glass
On 10 August 2015 at 20:44, Simon Glass wrote: > This is declared but no-longer exists. Drop it. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v2: None > > arch/x86/include/asm/u-boot-x86.h | 1 - > 1 file changed, 1 deletion(-) Applied to u-boot-x86 _

Re: [U-Boot] [PATCH v3 06/10] x86: Allow pirq_init() to return an error

2015-08-11 Thread Simon Glass
On 10 August 2015 at 07:05, Simon Glass wrote: > This function can fail. In this case we should return the error rather than > swallowing it. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v3: None > Changes in v2: > - Add new patch to allow pirq_init() to return an

Re: [U-Boot] [PATCH v3 08/10] x86: baytrail: Tidy up interrupt and FSP init

2015-08-11 Thread Simon Glass
On 10 August 2015 at 23:16, Bin Meng wrote: > On Mon, Aug 10, 2015 at 9:05 PM, Simon Glass wrote: >> We should signal to the FSP that PCI enumeration is complete. Perform this >> task in a suitable place. >> >> Signed-off-by: Simon Glass >> --- >> >> Changes in v3: >> - Drop interrupt.h header i

Re: [U-Boot] [PATCH v3 04/10] x86: Tidy up the PIRQ routing code a little

2015-08-11 Thread Simon Glass
On 10 August 2015 at 07:05, Simon Glass wrote: > This code could use a little tightening up. There is some repetition and > an odd use of fdtdec_get_int_array(). > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > Tested-by: Bin Meng > --- > > Changes in v3: None > Changes in v2: > - Fix h

Re: [U-Boot] [PATCH v3 10/10] x86: baytrail: Support running as an EFI payload

2015-08-11 Thread Simon Glass
On 10 August 2015 at 07:05, Simon Glass wrote: > We should not fiddle with interrupts or the FSP when running as an EFI > payload. Detect this and skip this code. > > Signed-off-by: Simon Glass > Reviewed-by: Bin Meng > --- > > Changes in v3: None > Changes in v2: > - Add new patch to support ru

Re: [U-Boot] [PATCH v3 05/10] x86: Split out fsp_init_phase_pci() code into a new function

2015-08-11 Thread Simon Glass
On 10 August 2015 at 07:05, Simon Glass wrote: > This code may be useful for boards that use driver model for PCI. > > Note: It would be better to have driver model automatically call this > function somehow. However for now it is probably safer to have it under > board control. > > Signed-off-by:

Re: [U-Boot] [PATCH v3 03/10] x86: Re-order efi-x86_defconfig

2015-08-11 Thread Simon Glass
On 10 August 2015 at 22:54, Bin Meng wrote: > On Mon, Aug 10, 2015 at 9:05 PM, Simon Glass wrote: >> Use savedefconfig to get this file into the correct order. >> >> Signed-off-by: Simon Glass >> --- >> >> Changes in v3: None >> Changes in v2: >> - Rebase to mainline >> >> configs/efi-x86_defco

Re: [U-Boot] [PATCH v3 01/10] dm: pci: Provide friendly config access functions

2015-08-11 Thread Simon Glass
On 10 August 2015 at 22:11, Bin Meng wrote: > On Mon, Aug 10, 2015 at 9:05 PM, Simon Glass wrote: >> At present there are no PCI functions which allow access to PCI >> configuration using a struct udevice. This is a sad situation for driver >> model as it makes use of PCI harder. Add these functi

Re: [U-Boot] [PATCH v4] x86: baytrail: Configure FSP UPD from device tree

2015-08-11 Thread Simon Glass
+Gabriel Hi Andrew, On 11 August 2015 at 09:20, Andrew Bradford wrote: > Hi Simon, > > On 08/11 08:06, Simon Glass wrote: >> Hi Andrew, >> >> On 11 August 2015 at 06:08, Andrew Bradford >> wrote: >> > Hi Simon, >> > >> > On 08/10 21:07, Simon Glass wrote: >> >> Hi Bin, >> >> >> >> On 10 August

Re: [U-Boot] [PATCH v3 02/10] dm: pci: Add a way to iterate through all PCI devices

2015-08-11 Thread Simon Glass
On 10 August 2015 at 22:14, Bin Meng wrote: > On Mon, Aug 10, 2015 at 9:05 PM, Simon Glass wrote: >> These functions allow iteration through all PCI devices including bridges. >> The children of each PCI bus are returned in turn. This can be useful for >> configuring, checking or enumerating all

Re: [U-Boot] [PATCH] x86: fsp: Do not assert VPD_IMAGE_REV when DEBUG

2015-08-11 Thread Simon Glass
On 8 August 2015 at 08:10, Simon Glass wrote: > On 8 August 2015 at 08:01, Bin Meng wrote: >> When using different release version of Intel FSP, the VPD_IMAGE_REV >> is different (ie: BayTrail Gold 3 is 0x0303 while Gold 4 is 0x0304). >> Remove the asserting of this so that U-Boot does not hang i

Re: [U-Boot] [PATCH] net: macb: add gmac multi-queue support

2015-08-11 Thread Josh Wu
Hi, Joe On 8/12/2015 2:29 AM, Joe Hershberger wrote: Hi Josh, On Wed, Jun 3, 2015 at 3:45 AM, Josh Wu wrote: This patch refer to linux kernel commit: d8b763e1e79f net/macb: add TX multiqueue support for gem by: Cyrille Pitchen 1. macb driver will check the register to find how many que

Re: [U-Boot] [PATCH] arm: iproc: add NAND driver

2015-08-11 Thread Scott Wood
On Sat, Aug 08, 2015 at 05:58:04PM -0700, Steve Rae wrote: > From: Jiandong Zheng > > Add support for the iproc NAND, and enable on Cygnus and NSP boards. > > Signed-off-by: Jiandong Zheng > Signed-off-by: Steve Rae > --- > > arch/arm/include/asm/arch-bcmcygnus/configs.h | 11 + > arch/arm

Re: [U-Boot] [PATCH] x86: Drop FSP error defines and use EFI instead

2015-08-11 Thread Bin Meng
Hi Simon, On Wed, Aug 12, 2015 at 1:57 AM, Simon Glass wrote: > Now that we have an efi.h header we can use that for FSP error defines. > Drop the FSP ones. > > Signed-off-by: Simon Glass > --- > > arch/x86/include/asm/fsp/fsp_types.h | 11 --- > arch/x86/lib/fsp/fsp_common.c|

Re: [U-Boot] [PATCH v3 14/15] of: flip CONFIG_SPL_DISABLE_OF_CONTROL into CONFIG_SPL_OF_CONTROL

2015-08-11 Thread Marek Vasut
On Wednesday, August 12, 2015 at 01:38:23 AM, Masahiro Yamada wrote: > Hi Marek, Hi Masahiro! > 2015-08-12 7:47 GMT+09:00 Marek Vasut : > > On Wednesday, August 12, 2015 at 12:31:54 AM, Masahiro Yamada wrote: > > > > Hi! > > > >> As we discussed a couple of times, negative CONFIG options make o

Re: [U-Boot] [PATCH v3 14/15] of: flip CONFIG_SPL_DISABLE_OF_CONTROL into CONFIG_SPL_OF_CONTROL

2015-08-11 Thread Masahiro Yamada
Hi Marek, 2015-08-12 7:47 GMT+09:00 Marek Vasut : > On Wednesday, August 12, 2015 at 12:31:54 AM, Masahiro Yamada wrote: > > Hi! > >> As we discussed a couple of times, negative CONFIG options make our >> life difficult; CONFIG_SYS_NO_FLASH, CONFIG_SYS_DCACHE_OFF, ... >> and here is another one.

[U-Boot] [PATCH v3 15/15] of: clean up OF_CONTROL ifdef conditionals

2015-08-11 Thread Masahiro Yamada
We have flipped CONFIG_SPL_DISABLE_OF_CONTROL. We have cleansing devices, $(SPL_) and CONFIG_IS_ENABLED(), so we are ready to clear away the ugly logic in include/fdtdec.h: #ifdef CONFIG_OF_CONTROL # if defined(CONFIG_SPL_BUILD) && !defined(SPL_OF_CONTROL) # define OF_CONTROL 0 # else # de

Re: [U-Boot] [PATCH v3 14/15] of: flip CONFIG_SPL_DISABLE_OF_CONTROL into CONFIG_SPL_OF_CONTROL

2015-08-11 Thread Marek Vasut
On Wednesday, August 12, 2015 at 12:31:54 AM, Masahiro Yamada wrote: Hi! > As we discussed a couple of times, negative CONFIG options make our > life difficult; CONFIG_SYS_NO_FLASH, CONFIG_SYS_DCACHE_OFF, ... > and here is another one. > > Now, there are three boards enabling OF_CONTROL on SPL:

[U-Boot] [PATCH v3 14/15] of: flip CONFIG_SPL_DISABLE_OF_CONTROL into CONFIG_SPL_OF_CONTROL

2015-08-11 Thread Masahiro Yamada
As we discussed a couple of times, negative CONFIG options make our life difficult; CONFIG_SYS_NO_FLASH, CONFIG_SYS_DCACHE_OFF, ... and here is another one. Now, there are three boards enabling OF_CONTROL on SPL: - socfpga_arria5_defconfig - socfpga_cyclone5_defconfig - socfpga_socrates_defconf

[U-Boot] [PATCH v3 00/15] Add macros to ease our life with independent CONFIGs between U-Boot and SPL

2015-08-11 Thread Masahiro Yamada
Refer to Simon's question, too: http://lists.denx.de/pipermail/u-boot/2015-July/219598.html Since U-boot introduced SPL (not since Kconfig), enabling features for U-boot and SPL independently is always a PITA. - decide if each feature should be supported for SPL or not - Add CONFIG_SPL_FRED_SUP

[U-Boot] [PATCH v3 13/15] fdtdec: fix OF_CONTROL switch

2015-08-11 Thread Masahiro Yamada
There is no case where defined(SPL_DISABLE_OF_CONTROL) is true. Signed-off-by: Masahiro Yamada Reviewed-by: Tom Rini Reviewed-by: Simon Glass --- Changes in v3: None Changes in v2: None include/fdtdec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/fdtdec.h b/in

[U-Boot] [PATCH v3 12/15] dm: drop CONFIG_DM_DEVICE_REMOVE from uncmd list

2015-08-11 Thread Masahiro Yamada
We do not want to compile the DM remove code for SPL. Currently, we undef it in include/config_uncmd_spl.h (for C files) and in scripts/Makefile.uncmd_spl (for Makefiles). This is really ugly. This commit demonstrates how we can deprecate those two files. Use $(SPL_) for the entry in the Makfil

[U-Boot] [PATCH v3 10/15] led: rename CONFIG_SPL_LED_SUPPORT to CONFIG_SPL_LED

2015-08-11 Thread Masahiro Yamada
Signed-off-by: Masahiro Yamada Reviewed-by: Tom Rini Reviewed-by: Simon Glass --- Changes in v3: None Changes in v2: None drivers/Makefile| 2 +- drivers/led/Kconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/Makefile b/drivers/Makefile index aff0d05..d

[U-Boot] [PATCH v3 11/15] led: unify obj-$(CONFIG_LED) and obj-$(CONFIG_SPL_LED) entries

2015-08-11 Thread Masahiro Yamada
Signed-off-by: Masahiro Yamada Reviewed-by: Tom Rini Reviewed-by: Stefano Babic Reviewed-by: Simon Glass --- Changes in v3: None Changes in v2: None drivers/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/Makefile b/drivers/Makefile index ddb4215..a721e

[U-Boot] [PATCH v3 04/15] spl: move SPL driver entries to driver/Makefile

2015-08-11 Thread Masahiro Yamada
Just preparing for upcoming cleaning. The board-specific linker script board/vpac270/u-boot-spl.lds has been touched to avoid build error. It does not change the size of spl/u-boot-spl.bin for this board, so it should be OK. Signed-off-by: Masahiro Yamada Reviewed-by: Tom Rini Reviewed-by: St

[U-Boot] [PATCH v3 08/15] ram: rename CONFIG_SPL_RAM_SUPPORT to CONFIG_SPL_RAM

2015-08-11 Thread Masahiro Yamada
Signed-off-by: Masahiro Yamada Reviewed-by: Tom Rini Reviewed-by: Simon Glass --- Changes in v3: None Changes in v2: None drivers/Makefile| 2 +- drivers/ram/Kconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/Makefile b/drivers/Makefile index 8630a58..3

[U-Boot] [PATCH v3 07/15] clk: unify obj-$(CONFIG_CLK) and obj-$(CONFIG_SPL_CLK) entries

2015-08-11 Thread Masahiro Yamada
Signed-off-by: Masahiro Yamada Reviewed-by: Tom Rini Reviewed-by: Stefano Babic Reviewed-by: Simon Glass --- Changes in v3: None Changes in v2: None drivers/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/Makefile b/drivers/Makefile index 2e17d02..8630a

[U-Boot] [PATCH v3 09/15] ram: unify obj-$(CONFIG_RAM) and obj-$(CONFIG_SPL_RAM) entries

2015-08-11 Thread Masahiro Yamada
Signed-off-by: Masahiro Yamada Reviewed-by: Tom Rini Reviewed-by: Simon Glass --- Changes in v3: None Changes in v2: None drivers/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/Makefile b/drivers/Makefile index 3b38861..aff0d05 100644 --- a/drivers/Make

[U-Boot] [PATCH v3 05/15] dm: unify obj-$(CONFIG_DM) and obj-$(CONFIG_SPL_DM) entries

2015-08-11 Thread Masahiro Yamada
Signed-off-by: Masahiro Yamada Reviewed-by: Tom Rini Reviewed-by: Simon Glass --- Changes in v3: None Changes in v2: None drivers/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/Makefile b/drivers/Makefile index a24c5f5..ee8e418 100644 --- a/drivers/Ma

[U-Boot] [PATCH v3 02/15] kbuild: add a makefile macro useful with per-image config options

2015-08-11 Thread Masahiro Yamada
Commit e02ee2548afe ("kconfig: switch to single .config configuration") made the configuration itself pretty simple, instead, we lost the way to systematically enable/disable config options for each image independently. Our current strategy is, put entries into Makefile.spl for options we need sep

[U-Boot] [PATCH v3 01/15] kbuild: fixdep: optimize code slightly

2015-08-11 Thread Masahiro Yamada
If the target string matches "CONFIG_", move the pointer p forward. This saves several 7-chars adjustments. Signed-off-by: Masahiro Yamada Reviewed-by: Tom Rini Reviewed-by: Simon Glass --- Changes in v3: None Changes in v2: None scripts/basic/fixdep.c | 7 --- 1 file changed, 4 inserti

[U-Boot] [PATCH v3 06/15] clk: rename CONFIG_SPL_CLK_SUPPORT to CONFIG_SPL_CLK

2015-08-11 Thread Masahiro Yamada
Signed-off-by: Masahiro Yamada Reviewed-by: Tom Rini Reviewed-by: Stefano Babic Reviewed-by: Simon Glass --- Changes in v3: None Changes in v2: None drivers/Makefile| 2 +- drivers/clk/Kconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/Makefile b/drive

[U-Boot] [PATCH v3 03/15] linux/kconfig.h: add CPP macros useful for per-image config options

2015-08-11 Thread Masahiro Yamada
The previous commit introduced a useful macro used in makefiles, in order to reference to different variables (CONFIG_... or CONFIG_SPL_...) depending on the build context. Per-image config option control is a PITA in C sources, too. Here are some macros useful in C/CPP expressions. CONFIG_IS_ENA

Re: [U-Boot] [PATCH] lpc32xx: move common SLC NAND defines to arch/config.h

2015-08-11 Thread Vladimir Zapolskiy
Hi Sylvain, On 11.08.2015 23:16, LEMIEUX, SYLVAIN wrote: > Hi Vladimir, > >> -Original Message- >> From: Vladimir Zapolskiy [mailto:v...@mleia.com] >> Sent: 11-Aug-15 12:57 PM >> >> A number of LPC32xx SLC NAND defines is dictated by controller >> hardware limits and OOB layout is defined

Re: [U-Boot] [PATCH 00/25] dm: Convert TPM drivers to driver model

2015-08-11 Thread christophe.ricard
Hi Simon, I pretty much like the move to driver model for TPM. However, i have some few remarks: The current i2c driver stick to Infineon TPMs and will not support any other vendors like ST(in my case). The main reason for this is that there is no transport protocol over I2C specification defi

Re: [U-Boot] [PATCH 08/25] tpm: tpm_tis_i2c: Drop struct tpm_vendor_specific

2015-08-11 Thread christophe.ricard
Hi Simon, Locality concept are valid almost on any chip assuming if no locality are supported the default one is locality 0. I would leave this change open for discussion. However, as per patch 06 & 07, i would keep req_complete_mask, req_complete_val, req_canceled, timeout_a, timeout_b, time

Re: [U-Boot] [PATCH 09/25] tpm: tpm_tis_i2c: Merge struct tpm_dev into tpm_chip

2015-08-11 Thread christophe.ricard
Hi Simon, As per my delivery tentative, don't you think driver specific data could be stored in a void *priv field in struct tpm_vendor_specific ? This how we manage such information in Linux drivers. Please have a look in tpm_private.h changes: http://lists.denx.de/pipermail/u-boot/2015-Augus

Re: [U-Boot] [PATCH 07/25] tpm: tpm_tis_i2c: Drop unnecessary methods

2015-08-11 Thread christophe.ricard
Hi Simon, As per my comment on patch 6, i would disagree as well on this one. It tpm_vendor_specific structure is convenient for ST33ZP24 for example. Best Regards Christophe On 11/08/2015 16:47, Simon Glass wrote: The function methods in struct tpm_vendor_specific just call local functions. C

Re: [U-Boot] [PATCH 10/25] tpm: tpm_tis_i2c: Merge struct tpm into tpm_chip

2015-08-11 Thread christophe.ricard
Hi Simon, I almost agree with this one. Except that here tis_init, tis_open... are already merged into tpm_tis_i2c... Best Regards Christophe On 11/08/2015 16:48, Simon Glass wrote: There are too many structures storing the same sort of information. Move the fields from struct tpm into struct

Re: [U-Boot] [PATCH 03/25] tpm: Add Kconfig options for TPMs

2015-08-11 Thread christophe.ricard
Hi Simon, On 11/08/2015 16:47, Simon Glass wrote: Add new Kconfig options for TPMs in preparation for moving boards to use Kconfig for TPM configuration. Signed-off-by: Simon Glass --- common/Kconfig | 12 drivers/tpm/Kconfig | 52 +

Re: [U-Boot] [PATCH 11/25] tpm: tpm_tis_i2c: Move definitions into the header file

2015-08-11 Thread christophe.ricard
Hi Simon, As per my previous comment, this file may be kept common to may other drivers (lpc or from ST...). I would renamed tpm_tis_i2c.h into something more generic like tpm.h. Below please find data specific to Infineon (tpm_tis_i2c) driver. On 11/08/2015 16:48, Simon Glass wrote: Some de

Re: [U-Boot] [PATCH 12/25] tpm: tpm_tis_i2c: Simplify init code

2015-08-11 Thread christophe.ricard
Hi Simon, Nothing much to say on tpm_tis_i2c, however this could be even more generic if providing init ops to be specified by TPM driver developers. For example: +struct dm_tpm_ops { + int (*init)(struct udevice *); + int (*open)(struct udevice *); + int (*close)(struct udev

Re: [U-Boot] [PATCH 04/25] tpm: Convert board config TPM options to Kconfig

2015-08-11 Thread christophe.ricard
Hi Simon, Acked-by: Christophe Ricard Best Regards Christophe On 11/08/2015 16:47, Simon Glass wrote: Convert all TPM options to Kconfig and tidy up. Signed-off-by: Simon Glass --- configs/chromebook_link_defconfig | 2 ++ configs/chromebox_panther_defconfig

Re: [U-Boot] [PATCH 02/25] tpm: Drop two unused options

2015-08-11 Thread christophe.ricard
Hi Simon, I am ok with this one. I proposed about the same changed in here: http://lists.denx.de/pipermail/u-boot/2015-August/222598.html Acked-by: Christophe Ricard Best Regards Christophe On 11/08/2015 16:47, Simon Glass wrote: The address of the I2C TPM is now defined in the device tree so

Re: [U-Boot] [PATCH 14/25] tpm: tpm_tis_i2c: Tidy up delays

2015-08-11 Thread christophe.ricard
Hi Simon, Acked-by: Christophe Ricard Best Regards Christophe On 11/08/2015 16:48, Simon Glass wrote: Use a _US suffix for microseconds and a _MS suffic for milliseconds. Move all timeouts and delays into one place. Use mdelay() instead of udelay() where appropriate. Signed-off-by: Simon Gla

Re: [U-Boot] [PATCH 13/25] tpm: tpm_tis_i2c: Use a consistent tpm_tis_i2c_ prefix

2015-08-11 Thread christophe.ricard
Hi Simon, Acked-by: Christophe Ricard Best Regards Christophe On 11/08/2015 16:48, Simon Glass wrote: Use the same prefix on each function for consistency. Signed-off-by: Simon Glass --- drivers/tpm/tpm_tis_i2c.c | 113 -- 1 file changed, 58 i

Re: [U-Boot] [PATCH 15/25] dm: tpm: Add a uclass for Trusted Platform Modules

2015-08-11 Thread christophe.ricard
Hi Simon, I think we are pretty inline for the uclass. Please find below some few remarks. On 11/08/2015 16:48, Simon Glass wrote: Add a new uclass for TPMs which uses almost the same TIS (TPM Interface Specification) as is currently implemented. Since init() is handled by the normal driver mod

Re: [U-Boot] [PATCH 16/25] dm: tpm: Convert the TPM command and library to driver model

2015-08-11 Thread christophe.ricard
Hi Simon On 11/08/2015 16:48, Simon Glass wrote: Add driver model support to the TPM command and the TPM library. Both support only a single TPM at present. Signed-off-by: Simon Glass --- common/cmd_tpm.c | 26 ++ include/tpm.h| 2 +- lib/tpm.c| 29 +++

Re: [U-Boot] [PATCH 19/25] dm: tpm: sandbox: Convert TPM driver to driver model

2015-08-11 Thread christophe.ricard
Acked-by: Christophe Ricard On 11/08/2015 16:48, Simon Glass wrote: Convert the sandbox TPM driver to use driver model. Add it to the device tree so that it can be found on start-up. Signed-off-by: Simon Glass --- arch/sandbox/dts/sandbox.dts | 4 configs/sandbox_defconfig | 1

Re: [U-Boot] [PATCH 18/25] tpm: Report tpm errors on the command line

2015-08-11 Thread christophe.ricard
Hi Simon, Good one ! Acked-by: Christophe Ricard Best Regards Christophe On 11/08/2015 16:48, Simon Glass wrote: When a 'tpm' command fails, we set the return code but give no indication of failure. This can be confusing. Add an error message when any tpm command fails. Signed-off-by: Simon

Re: [U-Boot] [PATCH 20/25] tpm: Check that parse_byte_string() has data to parse

2015-08-11 Thread christophe.ricard
Hi Simon, Acked-by: Christophe Ricard Best Regards Christophe On 11/08/2015 16:48, Simon Glass wrote: Rather then crashing when there is no data, print an error. Signed-off-by: Simon Glass --- common/cmd_tpm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/common/cmd_tpm.c b/comm

Re: [U-Boot] [PATCH 06/25] tpm: Move the I2C TPM code into one file

2015-08-11 Thread christophe.ricard
Hi Simon, I would basically disagree with this one. The code from tpm.c you are merging into tpm_tis_i2c may not only be used by tpm_tis_i2c as it is using data from TPM standards (e.g: Trusted computing group) that should be used by other TPM drivers. You can find in chapter 17 how the table t

Re: [U-Boot] [PATCH 05/25] tpm: Convert drivers to use SPDX

2015-08-11 Thread christophe.ricard
Hi Simon, Just to mention i have seen this one as well. Acked-by: Christophe Ricard Best Regards Christophe On 11/08/2015 16:47, Simon Glass wrote: Add an SPDX header to two drivers that don't have it. Signed-off-by: Simon Glass --- drivers/tpm/tpm_atmel_twi.c | 15 +++ driv

Re: [U-Boot] [PATCH 01/25] tpm: Remove old pre-driver-model I2C code

2015-08-11 Thread christophe.ricard
Hi Simon, In here you are removing usage of i2c_read/i2c_write for dm_i2c_read/dm_i2c_write. This require boards to support DM_I2C which is not the case with example beagleboard or boards using omap. Will you drop all drivers not supporting DM in the future ? Other than that i have proposed

Re: [U-Boot] [PATCH 23/25] dm: tpm: Convert LPC driver to driver model

2015-08-11 Thread christophe.ricard
Hi Simon, Ok for now, except with the xfer handler. Best Regards Christophe On 11/08/2015 16:48, Simon Glass wrote: Convert the tpm_tis_lpc driver to use driver model and update boards which use it. Signed-off-by: Simon Glass --- configs/chromebook_link_defconfig | 2 + configs/chrom

Re: [U-Boot] [PATCH 22/25] dm: tpm: Convert I2C driver to driver model

2015-08-11 Thread christophe.ricard
Hi Simon, I would be ok if we can get to a common agreement on my previous comments. Best Regards Christophe On 11/08/2015 16:48, Simon Glass wrote: Convert the tpm_tis_i2c driver to use driver model and update boards which use it. Signed-off-by: Simon Glass --- configs/peach-pi_defconfig

Re: [U-Boot] [PATCH 24/25] tpm: Add a 'tpm info' command

2015-08-11 Thread christophe.ricard
Hi Simon, Acked-by: Christophe Ricard Best Regards Christophe On 11/08/2015 16:48, Simon Glass wrote: Add a command to display basic information about a TPM such as the model and open/close state. This can be useful for debugging. Signed-off-by: Simon Glass --- common/cmd_tpm.c | 26

Re: [U-Boot] [PATCH 25/25] tegra: nyan: Enable TPM command and driver

2015-08-11 Thread christophe.ricard
Hi Simon, Acked-by: Christophe Ricard Best Regards Christophe On 11/08/2015 16:48, Simon Glass wrote: The TPM is listed in the device tree. Enable the driver and 'tpm' command so that it can be used. Signed-off-by: Simon Glass --- configs/nyan-big_defconfig | 4 1 file changed, 4 i

Re: [U-Boot] [PATCH RESEND 0/7] spi: cadence_qspi: optimize & fix indirect rd-writes

2015-08-11 Thread vikasm
Hi Stefan, On 07/23/2015 05:22 AM, Stefan Roese wrote: > Hi Vikas, > > On 16.07.2015 08:46, Stefan Roese wrote: > In addition can you please check the patch causing this instability on > socfpga. I don't like to bug you but to close this patchset, this info > & tests mentioned above s

Re: [U-Boot] [ELCE 2015][Presentation] Proposal for U-boot Mini Summit presentation

2015-08-11 Thread Lukasz Majewski
Hi Stefan, > Hi Lukasz, > > On 11.08.2015 10:45, Lukasz Majewski wrote: > > Please assess if the following presentation is suitable for the 2015 > > U-boot Mini Summit held at ELCE2015. > > > > __Title__ > > > > "Automated Test System - build blocks" > > > > __Abstract__ > > > > Assuring software

Re: [U-Boot] [PATCH 3/3 V2] dm9000: rework dm9000 to support multiple devices

2015-08-11 Thread Andrew Ruder
On 08/11/2015 12:58 PM, Joe Hershberger wrote: > What ever became of this series? I failed to ever email it in... I have a redone series, let me clean it up and give it a quick test and make sure it works on latest... Needed to rebase on about 10 months of upstream. ___

Re: [U-Boot] Pull request, u-boot-tegra/master

2015-08-11 Thread Tom Warren
Thanks! > -Original Message- > From: Tom Rini [mailto:tr...@konsulko.com] > Sent: Tuesday, August 11, 2015 11:04 AM > To: Tom Warren > Cc: u-boot@lists.denx.de; Stephen Warren; Alex Courbot; > 'tomcwarren3...@gmail.com' > Subject: Re: Pull request, u-boot-tegra/master > > * PGP Signed by

Re: [U-Boot] [PATCH] lpc32xx: move common SLC NAND defines to arch/config.h

2015-08-11 Thread LEMIEUX, SYLVAIN
Hi Vladimir, > -Original Message- > From: Vladimir Zapolskiy [mailto:v...@mleia.com] > Sent: 11-Aug-15 12:57 PM > > A number of LPC32xx SLC NAND defines is dictated by controller > hardware limits and OOB layout is defined by operating system, the > definitions are common for all users. Si

Re: [U-Boot] [PATCH 1/5] Make RBTREE selectable by Kconfig

2015-08-11 Thread Joe Hershberger
Hi Lars, On Tue, Jul 28, 2015 at 11:01 AM, Joe Hershberger wrote: > Hi Lars, > > On Tue, Jul 28, 2015 at 3:25 AM, Lars Poeschel wrote: >> Hi Joe, >> >> On Wed, Jun 10, 2015 at 11:03:59AM -0500, Joe Hershberger wrote: >>> >> I beat you to it: >>> >> http://lists.denx.de/pipermail/u-boot/2015-May

Re: [U-Boot] LPC32xx changes

2015-08-11 Thread Tom Rini
On Tue, Aug 11, 2015 at 06:20:32PM +, LEMIEUX, SYLVAIN wrote: > Hi Toni, > > Do you know who will review and accept the other patches in the > "LPC32xx: enhancement and update" series that were not review? > > For your convenience this is a list of links to patchwork: > * http://patchwork.oz

Re: [U-Boot] [PATCH v3] net: TFTP: add timer count environment variable

2015-08-11 Thread Joe Hershberger
Hi Albert, On Sun, Jul 26, 2015 at 4:53 PM, Albert ARIBAUD (3ADEV) wrote: > There already is an environment variable 'tftptimeout' > for setting individuabl block query timeout value, but > there is none for setting the maximum TFTP timeout count, > which can also help with unreliable network, TF

Re: [U-Boot] [PATCH] net: macb: add gmac multi-queue support

2015-08-11 Thread Joe Hershberger
Hi Josh, On Wed, Jun 3, 2015 at 3:45 AM, Josh Wu wrote: > This patch refer to linux kernel commit: d8b763e1e79f > net/macb: add TX multiqueue support for gem > by: Cyrille Pitchen > > 1. macb driver will check the register to find how many queues support for > this chip. > > 2. Then as we onl

Re: [U-Boot] [PATCH] net/phy: set led for rtl8211f phy

2015-08-11 Thread Joe Hershberger
Hi Shengzhou, On Thu, May 21, 2015 at 5:07 AM, Shengzhou Liu wrote: > Initialize LCR rigister to configure > green LED for Link, yellow LED for Active. > > Signed-off-by: Shengzhou Liu Acked-by: Joe Hershberger ___ U-Boot mailing list U-Boot@lists.de

Re: [U-Boot] LPC32xx changes

2015-08-11 Thread LEMIEUX, SYLVAIN
Hi Toni, Do you know who will review and accept the other patches in the "LPC32xx: enhancement and update" series that were not review? For your convenience this is a list of links to patchwork: * http://patchwork.ozlabs.org/patch/500510/ * http://patchwork.ozlabs.org/patch/500512/ * http://patch

Re: [U-Boot] [PATCH v1 2/3] sparc: Add MDIO support to GRETH driver

2015-08-11 Thread Joe Hershberger
Hi Francios, On Wed, Nov 5, 2014 at 6:30 AM, Francois Retief wrote: > Added MDIO support to the Aeroflex Gaisler GRETH driver. The result is > that we can now use the CONFIG_CMD_MII commands to access the PHY chip. > > Signed-off-by: Francois Retief > --- I noticed this still sitting in patchwo

Re: [U-Boot] Pull request, u-boot-tegra/master

2015-08-11 Thread Tom Rini
On Tue, Aug 11, 2015 at 05:44:13PM +, Tom Warren wrote: > Tom, > > Don’t want to nag, but has this gone in yet? So I saw this again this morning and double checked myself: $ git pull git://git.denx.de/u-boot-tegra.git From git://git.denx.de/u-boot-tegra * branchHEAD -> FET

Re: [U-Boot] net/fm: Update FMan Compatibels

2015-08-11 Thread Joe Hershberger
Hi Igal, On Thu, May 28, 2015 at 10:47 AM, Scott Wood wrote: > On Mon, May 18, 2015 at 02:46:30PM +0300, Igal.Liberman wrote: >> From: Igal Liberman >> >> During FMan upstreaming, the FMan Port and MAC compatibles changed. >> This patch aligns the FMan Port and MAC compatibles to the FMan >> dev

Re: [U-Boot] [PATCH 3/3 V2] dm9000: rework dm9000 to support multiple devices

2015-08-11 Thread Joe Hershberger
Hi Andrew, On Mon, Oct 20, 2014 at 6:47 PM, Tom Rini wrote: > On Mon, Oct 20, 2014 at 08:16:59PM +, Andrew Ruder wrote: >> On 10/20/2014 03:00 PM, Tom Rini wrote: >> > So, on new platforms we call dm9000_initialize with the right IO/DATA >> > locations for the given device, yes? I think I'd

[U-Boot] [PATCH] x86: Drop FSP error defines and use EFI instead

2015-08-11 Thread Simon Glass
Now that we have an efi.h header we can use that for FSP error defines. Drop the FSP ones. Signed-off-by: Simon Glass --- arch/x86/include/asm/fsp/fsp_types.h | 11 --- arch/x86/lib/fsp/fsp_common.c| 3 ++- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/arch/x8

Re: [U-Boot] [PATCH 2/2] arm: bcmcygnus: Enable Ethernet support

2015-08-11 Thread Joe Hershberger
Hi Steve, On Wed, Jul 15, 2015 at 6:28 PM, Steve Rae wrote: > From: Jiandong Zheng > > Enable BCM SF2 ethernet and PHY for BCM Cygnus SoC > > Signed-off-by: Jiandong Zheng > Signed-off-by: Steve Rae Acked-by: Joe Hershberger ___ U-Boot mailing list

Re: [U-Boot] Pull request, u-boot-tegra/master

2015-08-11 Thread Tom Warren
Tom, Don’t want to nag, but has this gone in yet? Thanks! -- nvpublic From: Tom Warren [mailto:tomcwarren3...@gmail.com] Sent: Thursday, August 06, 2015 1:40 PM To: Tom Rini; u-boot@lists.denx.de Cc: Stephen Warren; Tom Warren; Alex Courbot Subject: Pull request, u-boot-tegra/master Tom, Plea

Re: [U-Boot] [PATCH] tegra: Correct logic for reading pll_misc in clock_start_pll()

2015-08-11 Thread Simon Glass
Hi Tom, On 11 August 2015 at 11:41, Tom Warren wrote: > Simon, > >> -Original Message- >> From: Simon Glass [mailto:s...@google.com] On Behalf Of Simon Glass >> Sent: Monday, August 10, 2015 6:15 AM >> To: U-Boot Mailing List >> Cc: Simon Glass; Tom Warren; Thierry Reding; Masahiro Yamada

Re: [U-Boot] [PATCH] dm: Use dev_get_addr() where possible

2015-08-11 Thread Simon Glass
Hi Stephen, On 11 August 2015 at 11:33, Stephen Warren wrote: > > On 08/11/2015 08:33 AM, Simon Glass wrote: >> >> This is a convenient way for a driver to get the hardware address of a >> device, when regmap or syscon are not being used. Change existing callers >> to use it as an example to othe

Re: [U-Boot] [PATCH v2 6/6] net: Move CONFIG_E1000 options to Kconfig

2015-08-11 Thread Joe Hershberger
Hi Simon, On Tue, Aug 11, 2015 at 12:19 PM, Simon Glass wrote: > Hi Joe, > > On 11 August 2015 at 09:53, Joe Hershberger wrote: >> Hi Simon, >> >> On Tue, Aug 11, 2015 at 8:39 AM, Simon Glass wrote: >>> Move config for the E1000 Ethernet driver to Kconfig and tidy up affected >>> boards. >>> >>

Re: [U-Boot] [PATCH] zynq: enable CONFIG_NET_RANDOM_ETHADDR

2015-08-11 Thread Joe Hershberger
Hi Masahiro, On Fri, Jul 17, 2015 at 6:26 AM, Masahiro Yamada wrote: > We have to set a MAC address to use network. > Otherwise, the tftpboot command fails with the following message: > > Gem.e000b000 Waiting for PHY auto negotiation to complete done > *** ERROR: `ethaddr' not set > >

Re: [U-Boot] [PATCH] dm: Use dev_get_addr() where possible

2015-08-11 Thread Stephen Warren
On 08/11/2015 08:33 AM, Simon Glass wrote: This is a convenient way for a driver to get the hardware address of a device, when regmap or syscon are not being used. Change existing callers to use it as an example to others. Ah good; I was a little worried about the tiny number of users of dev_g

Re: [U-Boot] [PATCH] tegra: Correct logic for reading pll_misc in clock_start_pll()

2015-08-11 Thread Tom Warren
Simon, > -Original Message- > From: Simon Glass [mailto:s...@google.com] On Behalf Of Simon Glass > Sent: Monday, August 10, 2015 6:15 AM > To: U-Boot Mailing List > Cc: Simon Glass; Tom Warren; Thierry Reding; Masahiro Yamada; Stephen > Warren; Tom Rini; Albert Aribaud; Marcel Ziswiler; S

Re: [U-Boot] LPC32xx changes

2015-08-11 Thread Tom Rini
On Tue, Aug 11, 2015 at 08:06:25PM +0300, Vladimir Zapolskiy wrote: > Hello Tom, > > today I've opened U-boot patchwork and found that almost all my recent > changes sent to U-boot mailing list are assigned to you. Would it be > possible for you to review/apply them? > > As for today the collect

Re: [U-Boot] [PATCH 7/7] net: lpc32xx: eth buffers base config

2015-08-11 Thread Joe Hershberger
Hi Sylvain, On Mon, Jul 27, 2015 at 12:37 PM, wrote: > From: Sylvain Lemieux > > Add support to specify the Ethernet buffer base address; > if none are supply by the board, the default value is use (from existing > code). > > Signed-off-by: Sylvain Lemieux Acked-by: Joe Hershberger

  1   2   3   >