Re: [U-Boot] [PATCH] powerpc/mpc85xx: add setting of clock-frequency for mpic node

2013-02-24 Thread Wang Dongsheng-B40534
Hi Andy, Could you ack this patch? Thanks. > -Original Message- > From: Wang Dongsheng-B40534 > Sent: Thursday, January 31, 2013 12:52 PM > To: u-boot@lists.denx.de > Cc: Wang Dongsheng-B40534 > Subject: [PATCH] powerpc/mpc85xx: add setting of clock-frequency for mpic > node > > Set the

[U-Boot] [PATCH V2 1/2] lcd: implement a callback for splashimage

2013-02-24 Thread Nikita Kiryanov
On some architectures certain values of splashimage will lead to a data abort exception. Document the problem, and implement a callback for splashimage to reject such values. Cc: Anatolij Gustschin Cc: Wolfgang Denk Signed-off-by: Nikita Kiryanov Acked-by: Igor Grinberg --- Changes in V2:

[U-Boot] [PATCH v4 17/22] Roll crc32 into hash infrastructure

2013-02-24 Thread Simon Glass
Add the CRC32 algorithm to the list of available hashes, and make the crc32 command use hash_command(). Add a new crc32_wd_buf() to make this possible, which puts its result in a buffer rather than returning it as a 32-bit value. Note: For some boards the hash command is not enabled, neither are s

[U-Boot] [PATCH v4 18/22] sandbox: config: Enable hash functions and mtest

2013-02-24 Thread Simon Glass
Enable the hash command and sha1/256 hashing for sandbox. Also use a better address for memory testing (since the existing one is set up for linux host memory space). Signed-off-by: Simon Glass --- Changes in v4: None Changes in v3: None Changes in v2: None include/configs/sandbox.h | 9 +++

Re: [U-Boot] [PATCH v2 16/21] hash: Add a flag to support saving hashes in the environment

2013-02-24 Thread Simon Glass
Hi Wolfgang, On Thu, Feb 21, 2013 at 4:04 AM, Wolfgang Denk wrote: > Dear Simon Glass, > > In message <1361379515-23802-17-git-send-email-...@chromium.org> you wrote: >> Some hashing commands permit saving the hash in an environment variable, >> and verifying a hash from there. But the crc32 comm

Re: [U-Boot] [RFC PATCH v2 01/15] Implement autoconf header file

2013-02-24 Thread Simon Glass
Hi Joe, On Sun, Feb 24, 2013 at 11:50 AM, Joe Hershberger wrote: > Hi Simon, > > On Sun, Feb 24, 2013 at 11:25 AM, Simon Glass wrote: >> Add support for generating an autoconf.h header file that can be used in >> the source instead of #ifdef. >> >> For example, instead of: >> >> #ifdef CONFIG_V

Re: [U-Boot] May I join the maintainers of the u-boot blackfin custodian git tree?

2013-02-24 Thread Sonic Zhang
Hi all, On Tue, Feb 19, 2013 at 3:27 PM, Sonic Zhang wrote: > Dear Das U-boot developers and upstream git maintainers, > > I am Sonic Zhang from the Blackfin Linux team in > Analog Devices Inc. Blackfin is one of the high performance general > purpose DSPs, which can run complete OS without MMU

Re: [U-Boot] [PATCH v3 17/22] Roll crc32 into hash infrastructure

2013-02-24 Thread Simon Glass
Hi, On Sun, Feb 24, 2013 at 7:33 PM, Simon Glass wrote: > Add the CRC32 algorithm to the list of available hashes, and make > the crc32 command use hash_command(). Add a new crc32_wd_buf() to > make this possible, which puts its result in a buffer rather than > returning it as a 32-bit value. > >

Re: [U-Boot] [PATCH 1/9 v9] EXYNOS5: TMU: Add driver for Thermal Management Unit

2013-02-24 Thread Minkyu Kang
Dear Aksahy Saraswat, On 21/02/13 18:20, Akshay Saraswat wrote: > Hi Promsoft, > > > > I have done all the changes suggested by you and pushed new patches except > for one. > > As suggested to keep only one among tmu.h and exynos_tmu.h is not possible > because of the following reasons: pl

Re: [U-Boot] [PATCH] SMDK5250: FDT: Retrieve board model via DT

2013-02-24 Thread Simon Glass
On Mon, Feb 18, 2013 at 4:51 AM, Rajeshwari Shinde wrote: > Print out the board model by parsing the device tree file. > > Signed-off-by: Rajeshwari Shinde Acked-by: Simon Glass > --- > board/samsung/smdk5250/smdk5250.c | 11 ++- > 1 files changed, 10 insertions(+), 1 deletions(-) >

Re: [U-Boot] [PATCH 2/2 V2] EXYNOS5: Snow: Add a configuration file

2013-02-24 Thread Minkyu Kang
Dear Rajeshwari, On 21/02/13 15:43, Rajeshwari Shinde wrote: > This patch adds the configuration file for Snow Board and > defines the same in boards.cfg. > > Signed-off-by: Rajeshwari Shinde > --- > Changes in V2: > - Added Maintainer > MAINTAINERS|4 > boards.cfg

Re: [U-Boot] [PATCH 12/20] common: Use new numeric setenv functions

2013-02-24 Thread Simon Glass
Hi Tom, On Sun, Feb 24, 2013 at 12:53 PM, Tom Rini wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 02/24/2013 12:45 PM, Simon Glass wrote: >> Hi Tom, >> >> On Mon, Feb 18, 2013 at 2:08 PM, Tom Rini wrote: >>> On Wed, Dec 26, 2012 at 10:57:05AM -0800, Simon Glass wrote: >>> U

[U-Boot] [PATCH v3 07/22] Use common mtest iteration counting

2013-02-24 Thread Simon Glass
The iteration code is the same for each version of the memory test, so pull it out into the common function. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None common/cmd_mem.c | 123 ++- 1 file changed, 59 insertions(+), 6

[U-Boot] [PATCH v3 17/22] Roll crc32 into hash infrastructure

2013-02-24 Thread Simon Glass
Add the CRC32 algorithm to the list of available hashes, and make the crc32 command use hash_command(). Add a new crc32_wd_buf() to make this possible, which puts its result in a buffer rather than returning it as a 32-bit value. Note: For some boards the hash command is not enabled, neither are s

[U-Boot] [PATCH v3 22/22] hash: Use lower case for hash algorithm names

2013-02-24 Thread Simon Glass
Rather than use strcasecmp() in the hash algorithm search, require the caller to do this first. Most of U-Boot can use lower case anyway, and the hash command can convert to lower case before calling hash_command(). This saves needing strcasecmp() for boards that use hashing but not the hash comman

[U-Boot] [PATCH v3 20/22] sandbox: Update mtest to fix crashes

2013-02-24 Thread Simon Glass
Use map_sysmem() in the memory tester so that it works as expected on sandbox. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None common/cmd_mem.c | 97 ++-- 1 file changed, 52 insertions(+), 45 deletions(-) diff --git a/c

[U-Boot] [PATCH v3 18/22] sandbox: config: Enable hash functions and mtest

2013-02-24 Thread Simon Glass
Enable the hash command and sha1/256 hashing for sandbox. Also use a better address for memory testing (since the existing one is set up for linux host memory space). Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None include/configs/sandbox.h | 9 +++-- 1 file changed,

[U-Boot] [PATCH v3 19/22] Move CONFIG_SYS_MEMTEST_SCRATCH #ifdef to top of file

2013-02-24 Thread Simon Glass
This config effectively has a default value of 0, so add this setting at the top of the code to remove an #ifdef in the C function. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None common/cmd_mem.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a

[U-Boot] [PATCH v3 11/22] Update set_working_fdt_addr() to use setenv_addr()

2013-02-24 Thread Simon Glass
We might as well use this common function instead of repeating the same code. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None common/cmd_fdt.c| 11 ++- common/cmd_nvedit.c | 8 include/common.h| 14 +- 3 files changed, 19 insertions(+

[U-Boot] [PATCH v3 13/22] fs: Use new numeric setenv functions

2013-02-24 Thread Simon Glass
Use setenv_ulong(), setenv_hex() and setenv_addr() in fs/ Signed-off-by: Simon Glass --- Changes in v3: - Change incorrect commit title from drivers: to fs: Changes in v2: None fs/fs.c | 4 +--- fs/ubifs/ubifs.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/

[U-Boot] [PATCH v3 21/22] sandbox: Allow hash functions to work correctly

2013-02-24 Thread Simon Glass
Use map_sysmem() so that hashing is possible on sandbox. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: - Rebase on top of earlier patches common/hash.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/common/hash.c b/common/hash.c

[U-Boot] [PATCH v3 12/22] common: Use new numeric setenv functions

2013-02-24 Thread Simon Glass
Use setenv_ulong(), setenv_hex() and setenv_addr() in common/ Signed-off-by: Simon Glass --- Changes in v3: - Use spaces instead of tabs for indent in cmd_fdoc.c Changes in v2: None common/cmd_bootm.c| 11 +++ common/cmd_cbfs.c | 4 +--- common/cmd_cramfs.c | 4 +--- common

[U-Boot] [PATCH v3 15/22] image: Use crc header file instead of C prototypes

2013-02-24 Thread Simon Glass
We have an existing header which the crc32 definitions, so use it. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None common/image.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/image.c b/common/image.c index ae1a9d3..6afbb40 100644 --- a/co

[U-Boot] [PATCH v3 01/22] Tidy up error checking and fix bug in hash command

2013-02-24 Thread Simon Glass
There are two problems: 1. The argument count needs to be checked before argv is used 2. When verify is not enabled, we need to define a constant zero value Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None common/cmd_hash.c | 4 1 file changed, 4 insertions(+) diff

[U-Boot] [PATCH v3 05/22] sandbox: Change memory commands to use map_physmem

2013-02-24 Thread Simon Glass
Sandbox wants to support commands which use memory. The map_sysmen() call provides this feature, so use this in the memory commands. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None common/cmd_mem.c | 122 +++ 1 file chan

[U-Boot] [PATCH v3 10/22] Reduce casting in mtest

2013-02-24 Thread Simon Glass
Use a ulong for the command arguments, and only cast to an address when needed. This fixes warnings in sandbox where pointers are typically 64 bits long. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None common/cmd_mem.c | 30 ++ 1 file changed,

[U-Boot] [PATCH v3 09/22] Bring mtest putc() into common code

2013-02-24 Thread Simon Glass
If we get a Ctrl-C abort, we always print a newline. Move this repeated code out of the functions and into a single place in the caller. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None common/cmd_mem.c | 32 +--- 1 file changed, 9 insertions(+)

[U-Boot] [PATCH v3 03/22] sandbox: Improve sandbox serial port keyboard interface

2013-02-24 Thread Simon Glass
From: Taylor Hutt Implements the tstc() interface for the serial driver. Multiplexing the console between the serial port and a keyboard uses a polling method of checking if characters are available; this means that the serial console must be non-blocking when attempting to read characters. Sig

[U-Boot] [PATCH v3 08/22] Fix mtest indenting

2013-02-24 Thread Simon Glass
Some of the inner loops are not indented correctly. Fix this. Signed-off-by: Simon Glass --- Changes in v3: - Rebase mtest indent patch on top of mainline to resolve conflicts Changes in v2: None common/cmd_mem.c | 322 +++ 1 file changed, 16

[U-Boot] [PATCH v3 14/22] net: Use new numeric setenv functions

2013-02-24 Thread Simon Glass
Use setenv_ulong(), setenv_hex() and setenv_addr() in net/ Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None drivers/net/fm/fm.c | 4 +--- net/net.c | 8 ++-- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/net/fm/fm.c b/drivers/net/fm/f

[U-Boot] [PATCH v3 06/22] Split out the memory tests into separate functions

2013-02-24 Thread Simon Glass
Half of the code is currently hidden behind an #ifdef. Move the two memory tests into their own functions and use the compiler to eliminate the unused code. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None common/cmd_mem.c | 217 +---

[U-Boot] [PATCH v3 02/22] Update print_buffer() to use const

2013-02-24 Thread Simon Glass
The buffer cannot be changed by this function, so change the buffer pointer to a const. This allows callers with const pointer to use the function without a cast. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None include/common.h | 3 ++- lib/display_options.c | 3 ++-

[U-Boot] [PATCH v3 04/22] sandbox: Add un/map_sysmen() to deal with sandbox's ram_buf

2013-02-24 Thread Simon Glass
Sandbox doesn't actually provide U-Boot access to the machine's physical memory. Instead it provides a RAM buffer of configurable size, and all memory accesses are within that buffer. Sandbox memory starts at 0 and is CONFIG_DRAM_SIZE bytes in size. Allowing access outside this buffer might produce

[U-Boot] [PATCH v3 16/22] hash: Add a flag to support saving hashes in the environment

2013-02-24 Thread Simon Glass
Some hashing commands permit saving the hash in an environment variable, and verifying a hash from there. But the crc32 command does not support this. In order to permit crc32 to use the generic hashing infrastructure, add a flag to select which behaviour to use. Signed-off-by: Simon Glass --- Ch

[U-Boot] [PATCH v3 0/22] Improvements to memory, hashing functions for sandbox

2013-02-24 Thread Simon Glass
This series aims to get all the memory functions running correctly on sandbox. There was some discussion about this a while ago, and a commit was added to show a possible approach: 355a8357 sandbox: Change md command to use map_physmem This commit was subsequently reverted because it used map_ph

Re: [U-Boot] [PATCH v3] mxs: timrot: Add support to i.MX23

2013-02-24 Thread Marek Vasut
Dear Fadil Berisha, > From: Fadil Berisha > > This patch add timer support to i.MX23 and complete bit fields and values > on regs-timrot.h. > Testet on imx23-olinuxino board. > > Signed-off-by: Fadil Berisha Boring nits below, fix them and add my ack in the next version: Acked-by: Marek Vasu

Re: [U-Boot] FDT howto

2013-02-24 Thread Simon Glass
Hi Jagan, On Sun, Feb 24, 2013 at 10:58 AM, Jagan Teki wrote: > Hi Simon, > > On Sun, Feb 24, 2013 at 11:55 PM, Jagan Teki wrote: >> Hi Simon, >> >> On Sun, Feb 24, 2013 at 11:50 PM, Simon Glass wrote: >>> Hi, >>> >>> On Sun, Feb 24, 2013 at 9:55 AM, Jagan Teki >>> wrote: Hi Simon,

Re: [U-Boot] [RFC PATCH v2 15/15] main: Add debug_bootkeys to avoid #ifdefs

2013-02-24 Thread Joe Hershberger
Hi Simon On Sun, Feb 24, 2013 at 11:26 AM, Simon Glass wrote: > Define a simple debug condition at the top of the file, to avoid using > lots of #ifdefs later on. > > Signed-off-by: Simon Glass > --- > Changes in v2: None > > common/main.c | 19 +-- > 1 file changed, 9 insertion

Re: [U-Boot] [RFC PATCH v2 14/15] main: Add debug_parser() to avoid #ifdefs

2013-02-24 Thread Joe Hershberger
Hi Simon, On Sun, Feb 24, 2013 at 11:26 AM, Simon Glass wrote: > Define a simple debug condition at the top of the file, to avoid using > lots of #ifdefs later on. > > Signed-off-by: Simon Glass > --- > Changes in v2: None > > common/main.c | 58 +++--

Re: [U-Boot] [RFC PATCH v2 12/15] main: Use autoconf in main_loop()

2013-02-24 Thread Joe Hershberger
Hi Simon, On Sun, Feb 24, 2013 at 11:26 AM, Simon Glass wrote: > Convert main_loop() over to use autoconf, and add a required prototype > to common.h. > > The do_mdm_init variable is now always defined, but this seems like an > acceptable compromise. > > In fdt_support.h the #ifdef used is CONFIG

Re: [U-Boot] [RFC PATCH v2 11/15] main: Use autoconf in command line reading

2013-02-24 Thread Joe Hershberger
Hi Simon, On Sun, Feb 24, 2013 at 11:26 AM, Simon Glass wrote: > Remove #ifdefs in favour of autoconf for this code. This involves removing > a few unnecessary #ifdefs in headers also. > > We have two versions of the code - one that handles command line editing and > one that is just a simple imp

Re: [U-Boot] [PATCH 12/20] common: Use new numeric setenv functions

2013-02-24 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/24/2013 12:45 PM, Simon Glass wrote: > Hi Tom, > > On Mon, Feb 18, 2013 at 2:08 PM, Tom Rini wrote: >> On Wed, Dec 26, 2012 at 10:57:05AM -0800, Simon Glass wrote: >> >>> Use setenv_ulong(), setenv_hex() and setenv_addr() in common/ >>> >>> S

Re: [U-Boot] [RFC PATCH v2 10/15] main: Use autoconf for parser selection

2013-02-24 Thread Joe Hershberger
Hi Simon, On Sun, Feb 24, 2013 at 11:26 AM, Simon Glass wrote: > Allow parser selection to make use of autoconf instead of #ifdefs. This > requires us to make header includes unconditional, but this is simpler > anyway. > > Signed-off-by: Simon Glass > --- > Changes in v2: None > > common/main.

Re: [U-Boot] [RFC PATCH v2 09/15] main: Use autoconf for boot_delay code

2013-02-24 Thread Joe Hershberger
Hi Simon, On Sun, Feb 24, 2013 at 11:26 AM, Simon Glass wrote: > Convert this function and its children to use autoconf instead of #ifdef. > > Some header files must now be included unconditionally, so remove some of > the #ifdefs from the header section, and put these header files into the > rig

Re: [U-Boot] [RFC PATCH v2 08/15] main: Use get/setenv_ulong()

2013-02-24 Thread Joe Hershberger
Hi Simon. On Sun, Feb 24, 2013 at 11:26 AM, Simon Glass wrote: > These functions are now available, so use them to avoid extra code here. > > Signed-off-by: Simon Glass > --- > Changes in v2: None > > common/main.c | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > Reviewed-by:

Re: [U-Boot] [RFC PATCH v2 07/15] main: Remove CONFIG #ifdefs from the abortboot() code

2013-02-24 Thread Joe Hershberger
Hi Simon, On Sun, Feb 24, 2013 at 11:26 AM, Simon Glass wrote: > Move this code over to using autoconf. We can add the autoconf values to > the delaykey[] array, and move the code that checks for autoconf values into > the loop. > > Also change to using ARRAY_SIZE on delaykey[]. > > Signed-off-by

Re: [U-Boot] [RFC PATCH v2 06/15] main: Use autoconf for boot retry feature

2013-02-24 Thread Joe Hershberger
Hi Simon, On Sun, Feb 24, 2013 at 11:26 AM, Simon Glass wrote: > Change this feature to use autoconf instead of #ifdef. > > Signed-off-by: Simon Glass > --- > Changes in v2: None > > common/main.c | 74 > ++- > 1 file changed, 33 insertio

Re: [U-Boot] [RFC PATCH v2 05/15] main: Move boot_delay code into its own function

2013-02-24 Thread Joe Hershberger
HI Simon, On Sun, Feb 24, 2013 at 11:26 AM, Simon Glass wrote: > Move this code into its own function, since it clutters up main_loop(). > > Signed-off-by: Simon Glass > --- > Changes in v2: None > > common/main.c | 155 > ++ > 1 file cha

Re: [U-Boot] [RFC PATCH v2 04/15] main: Separate out the two abortboot() functions

2013-02-24 Thread Joe Hershberger
Hi Simon, On Sun, Feb 24, 2013 at 11:26 AM, Simon Glass wrote: > There are two implementations of autoboot(). Turn these into two separate > functions, and create a single autoboot() which calls either one or the > other. > > Also it seems that nothing uses autoboot() outside main, so make it sta

Re: [U-Boot] [RFC PATCH v2 03/15] net: Add prototype for update_tftp, and use autoconf

2013-02-24 Thread Joe Hershberger
Hi Simon, On Sun, Feb 24, 2013 at 11:26 AM, Simon Glass wrote: > This function should be declared in net.h. At the same time, let's use > autoconf insteaf of #ifdef for its inclusion. > > Signed-off-by: Simon Glass > --- > Changes in v2: None > > common/cmd_fitupd.c | 3 +-- > common/main.c

Re: [U-Boot] [PATCH 1/2] lcd: implement a callback for splashimage

2013-02-24 Thread Wolfgang Denk
Dear Nikita Kiryanov, In message <1361722763-22953-2-git-send-email-nik...@compulab.co.il> you wrote: > On some architectures certain values of splashimage will lead to > a data abort exception. > > Document the problem, and implement a callback for splashimage to > reject such values. > > Cc: A

Re: [U-Boot] [RFC PATCH v2 01/15] Implement autoconf header file

2013-02-24 Thread Joe Hershberger
Hi Simon, On Sun, Feb 24, 2013 at 11:25 AM, Simon Glass wrote: > Add support for generating an autoconf.h header file that can be used in > the source instead of #ifdef. > > For example, instead of: > > #ifdef CONFIG_VERSION_VARIABLE > setenv("ver", version_string); /* set version varia

Re: [U-Boot] [RFC PATCH v2 02/15] at91: Correct CONFIG_AUTOBOOT_PROMPT definition for pm9263

2013-02-24 Thread Joe Hershberger
Hi Simon, On Sun, Feb 24, 2013 at 11:26 AM, Simon Glass wrote: > This is not currently used, since autoboot is not enabled for this > board, but the string is missing a parameter. Add it. > Why not enable autoboot for this board so that this setting gets testing? > > Signed-off-by: Simon Glass

[U-Boot] [PATCH v3] mxs: timrot: Add support to i.MX23

2013-02-24 Thread Fadil Berisha
From: Fadil Berisha This patch add timer support to i.MX23 and complete bit fields and values on regs-timrot.h. Testet on imx23-olinuxino board. Signed-off-by: Fadil Berisha --- v2 - Updated the struct mxs_timrot_regs so the mapping works for all registers v3 - Revert macro MX28_INCREMENTER_HZ,

Re: [U-Boot] FDT howto

2013-02-24 Thread Jagan Teki
Hi Simon, On Sun, Feb 24, 2013 at 11:55 PM, Jagan Teki wrote: > Hi Simon, > > On Sun, Feb 24, 2013 at 11:50 PM, Simon Glass wrote: >> Hi, >> >> On Sun, Feb 24, 2013 at 9:55 AM, Jagan Teki wrote: >>> Hi Simon, >>> >>> On Sun, Feb 24, 2013 at 11:18 PM, Simon Glass wrote: Hi Jegan,

Re: [U-Boot] FDT howto

2013-02-24 Thread Jagan Teki
Hi Simon, On Sun, Feb 24, 2013 at 11:50 PM, Simon Glass wrote: > Hi, > > On Sun, Feb 24, 2013 at 9:55 AM, Jagan Teki wrote: >> Hi Simon, >> >> On Sun, Feb 24, 2013 at 11:18 PM, Simon Glass wrote: >>> Hi Jegan, >>> >>> On Sun, Feb 24, 2013 at 9:45 AM, Jagan Teki >>> wrote: Hi Simon,

Re: [U-Boot] FDT howto

2013-02-24 Thread Simon Glass
Hi, On Sun, Feb 24, 2013 at 9:55 AM, Jagan Teki wrote: > Hi Simon, > > On Sun, Feb 24, 2013 at 11:18 PM, Simon Glass wrote: >> Hi Jegan, >> >> On Sun, Feb 24, 2013 at 9:45 AM, Jagan Teki wrote: >>> Hi Simon, >>> >>> On Sun, Feb 24, 2013 at 11:08 PM, Simon Glass wrote: Hi Jagan,

[U-Boot] [RFC PATCH v2 0/15] Provide a mechanism to avoid using #ifdef everywhere

2013-02-24 Thread Simon Glass
Many parts of the U-Boot code base are sprinkled with #ifdefs. This makes different boards compile different versions of the source code, meaning that we must build all boards to check for failures. It is easy to misspell an #ifdef and there is not as much checking of this by the compiler. Multiple

Re: [U-Boot] FDT howto

2013-02-24 Thread Jagan Teki
Hi Simon, On Sun, Feb 24, 2013 at 11:18 PM, Simon Glass wrote: > Hi Jegan, > > On Sun, Feb 24, 2013 at 9:45 AM, Jagan Teki wrote: >> Hi Simon, >> >> On Sun, Feb 24, 2013 at 11:08 PM, Simon Glass wrote: >>> Hi Jagan, >>> >>> On Sun, Feb 24, 2013 at 8:19 AM, Jagan Teki >>> wrote: Hi Simon,

Re: [U-Boot] FDT howto

2013-02-24 Thread Jagan Teki
Hi Simon, On Sun, Feb 24, 2013 at 11:08 PM, Simon Glass wrote: > Hi Jagan, > > On Sun, Feb 24, 2013 at 8:19 AM, Jagan Teki wrote: >> Hi Simon, >> >> Thanks for your response, please find my below comments. >> >> On Sun, Feb 24, 2013 at 9:24 PM, Simon Glass wrote: >>> Hi Jagan, >>> >>> On Thu, F

Re: [U-Boot] FDT howto

2013-02-24 Thread Simon Glass
Hi Jegan, On Sun, Feb 24, 2013 at 9:45 AM, Jagan Teki wrote: > Hi Simon, > > On Sun, Feb 24, 2013 at 11:08 PM, Simon Glass wrote: >> Hi Jagan, >> >> On Sun, Feb 24, 2013 at 8:19 AM, Jagan Teki wrote: >>> Hi Simon, >>> >>> Thanks for your response, please find my below comments. >>> >>> On Sun,

Re: [U-Boot] [PATCH 12/20] common: Use new numeric setenv functions

2013-02-24 Thread Simon Glass
Hi Tom, On Mon, Feb 18, 2013 at 2:08 PM, Tom Rini wrote: > On Wed, Dec 26, 2012 at 10:57:05AM -0800, Simon Glass wrote: > >> Use setenv_ulong(), setenv_hex() and setenv_addr() in common/ >> >> Signed-off-by: Simon Glass > [snip] >> diff --git a/common/cmd_fdos.c b/common/cmd_fdos.c >> index fbee

Re: [U-Boot] FDT howto

2013-02-24 Thread Simon Glass
Hi Jagan, On Sun, Feb 24, 2013 at 8:19 AM, Jagan Teki wrote: > Hi Simon, > > Thanks for your response, please find my below comments. > > On Sun, Feb 24, 2013 at 9:24 PM, Simon Glass wrote: >> Hi Jagan, >> >> On Thu, Feb 21, 2013 at 9:03 AM, Jagan Teki wrote: >>> Hi All, >>> >>> I am planning t

[U-Boot] [RFC PATCH v2 09/15] main: Use autoconf for boot_delay code

2013-02-24 Thread Simon Glass
Convert this function and its children to use autoconf instead of #ifdef. Some header files must now be included unconditionally, so remove some of the #ifdefs from the header section, and put these header files into the right order. Signed-off-by: Simon Glass --- Changes in v2: None common/ma

[U-Boot] [RFC PATCH v2 13/15] main: Correct header order

2013-02-24 Thread Simon Glass
The headers are a bit out of order, so fix them. Signed-off-by: Simon Glass --- Changes in v2: None common/main.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/common/main.c b/common/main.c index 40a79b7..905d0c2 100644 --- a/common/main.c +++ b/common/main.c @@ -28,1

[U-Boot] [RFC PATCH v2 06/15] main: Use autoconf for boot retry feature

2013-02-24 Thread Simon Glass
Change this feature to use autoconf instead of #ifdef. Signed-off-by: Simon Glass --- Changes in v2: None common/main.c | 74 ++- 1 file changed, 33 insertions(+), 41 deletions(-) diff --git a/common/main.c b/common/main.c index 0df7992..

Re: [U-Boot] [PATCH 0/11] sandbox: Add filesystem support

2013-02-24 Thread Simon Glass
Hi, On Wed, Dec 26, 2012 at 11:53 AM, Simon Glass wrote: > This series adds support for filesystems to sandbox. While we don't yet have > access to host machine block devices, we can access files on the host through > a new 'host' filesystem type and the new sandbox command 'sb'. > > For example:

[U-Boot] [RFC PATCH v2 11/15] main: Use autoconf in command line reading

2013-02-24 Thread Simon Glass
Remove #ifdefs in favour of autoconf for this code. This involves removing a few unnecessary #ifdefs in headers also. We have two versions of the code - one that handles command line editing and one that is just a simple implementation. Create a new function called readline_into_buffer() which cal

[U-Boot] [RFC PATCH v2 15/15] main: Add debug_bootkeys to avoid #ifdefs

2013-02-24 Thread Simon Glass
Define a simple debug condition at the top of the file, to avoid using lots of #ifdefs later on. Signed-off-by: Simon Glass --- Changes in v2: None common/main.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/common/main.c b/common/main.c index 75a184c.

[U-Boot] [RFC PATCH v2 12/15] main: Use autoconf in main_loop()

2013-02-24 Thread Simon Glass
Convert main_loop() over to use autoconf, and add a required prototype to common.h. The do_mdm_init variable is now always defined, but this seems like an acceptable compromise. In fdt_support.h the #ifdef used is CONFIG_OF_LIBFDT. However, even if this is not defined we want to make the function

[U-Boot] [RFC PATCH v2 04/15] main: Separate out the two abortboot() functions

2013-02-24 Thread Simon Glass
There are two implementations of autoboot(). Turn these into two separate functions, and create a single autoboot() which calls either one or the other. Also it seems that nothing uses autoboot() outside main, so make it static. Signed-off-by: Simon Glass --- Changes in v2: None common/main.c

[U-Boot] [RFC PATCH v2 08/15] main: Use get/setenv_ulong()

2013-02-24 Thread Simon Glass
These functions are now available, so use them to avoid extra code here. Signed-off-by: Simon Glass --- Changes in v2: None common/main.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/common/main.c b/common/main.c index 37e42ca..4f11e58 100644 --- a/common/main.c +

[U-Boot] [RFC PATCH v2 02/15] at91: Correct CONFIG_AUTOBOOT_PROMPT definition for pm9263

2013-02-24 Thread Simon Glass
This is not currently used, since autoboot is not enabled for this board, but the string is missing a parameter. Add it. Signed-off-by: Simon Glass --- Changes in v2: None include/configs/pm9263.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/configs/pm9263.h b/in

[U-Boot] [RFC PATCH v2 05/15] main: Move boot_delay code into its own function

2013-02-24 Thread Simon Glass
Move this code into its own function, since it clutters up main_loop(). Signed-off-by: Simon Glass --- Changes in v2: None common/main.c | 155 ++ 1 file changed, 79 insertions(+), 76 deletions(-) diff --git a/common/main.c b/common/main.

[U-Boot] [RFC PATCH v2 14/15] main: Add debug_parser() to avoid #ifdefs

2013-02-24 Thread Simon Glass
Define a simple debug condition at the top of the file, to avoid using lots of #ifdefs later on. Signed-off-by: Simon Glass --- Changes in v2: None common/main.c | 58 +++--- 1 file changed, 23 insertions(+), 35 deletions(-) diff --git a/comm

[U-Boot] [RFC PATCH v2 10/15] main: Use autoconf for parser selection

2013-02-24 Thread Simon Glass
Allow parser selection to make use of autoconf instead of #ifdefs. This requires us to make header includes unconditional, but this is simpler anyway. Signed-off-by: Simon Glass --- Changes in v2: None common/main.c | 92 +++--- include/hush.

[U-Boot] [RFC PATCH v2 07/15] main: Remove CONFIG #ifdefs from the abortboot() code

2013-02-24 Thread Simon Glass
Move this code over to using autoconf. We can add the autoconf values to the delaykey[] array, and move the code that checks for autoconf values into the loop. Also change to using ARRAY_SIZE on delaykey[]. Signed-off-by: Simon Glass --- Changes in v2: None common/main.c | 86 +

[U-Boot] [RFC PATCH v2 03/15] net: Add prototype for update_tftp, and use autoconf

2013-02-24 Thread Simon Glass
This function should be declared in net.h. At the same time, let's use autoconf insteaf of #ifdef for its inclusion. Signed-off-by: Simon Glass --- Changes in v2: None common/cmd_fitupd.c | 3 +-- common/main.c | 9 ++--- common/update.c | 24 include/ne

[U-Boot] [RFC PATCH v2 01/15] Implement autoconf header file

2013-02-24 Thread Simon Glass
Add support for generating an autoconf.h header file that can be used in the source instead of #ifdef. For example, instead of: #ifdef CONFIG_VERSION_VARIABLE setenv("ver", version_string); /* set version variable */ #endif you can do: if (autoconf_version_variable())

Re: [U-Boot] [PATCH v2] mxs: timrot: Add support to i.MX23

2013-02-24 Thread Marek Vasut
Dear Fadil Berisha, > Dear Marek Vasut > > > I meant MXS_INCREMENTER_HZ macro and such. > > This change is made to respect Otavio's comment related to this patch > http://lists.denx.de/pipermail/u-boot/2013-February/146906.html I did > also changes to local macro MXS_HW_DIGCTL_MICROSECONDS. > >

Re: [U-Boot] [PATCH v2] mxs: timrot: Add support to i.MX23

2013-02-24 Thread Fadil Berisha
Dear Marek Vasut > I meant MXS_INCREMENTER_HZ macro and such. This change is made to respect Otavio's comment related to this patch http://lists.denx.de/pipermail/u-boot/2013-February/146906.html I did also changes to local macro MXS_HW_DIGCTL_MICROSECONDS. Let me know If you want to submit thos

[U-Boot] [PATCH 2/2] cm_t35: prevent splashimage from being set to a bad value

2013-02-24 Thread Nikita Kiryanov
Define CONFIG_SPLASHIMAGE_GUARD to prevent splashimage from being set to a value that will cause U-Boot to hang while displaying a splash screen. Signed-off-by: Nikita Kiryanov Acked-by: Igor Grinberg --- include/configs/cm_t35.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/include

[U-Boot] [PATCH 1/2] lcd: implement a callback for splashimage

2013-02-24 Thread Nikita Kiryanov
On some architectures certain values of splashimage will lead to a data abort exception. Document the problem, and implement a callback for splashimage to reject such values. Cc: Anatolij Gustschin Cc: Wolfgang Denk Signed-off-by: Nikita Kiryanov Acked-by: Igor Grinberg --- README

[U-Boot] [PATCH 0/2] Protect splashimage from improperly aligned addresses

2013-02-24 Thread Nikita Kiryanov
As discussed in the links below, one needs to be careful about choosing an address for a splash image BMP file when working on architectures that can't handle unaligned memory accesses. A bad address may lead to a bricked board, and the safe addresses are not obvious due to the internal structure o

Re: [U-Boot] FDT howto

2013-02-24 Thread Jagan Teki
Hi Simon, Thanks for your response, please find my below comments. On Sun, Feb 24, 2013 at 9:24 PM, Simon Glass wrote: > Hi Jagan, > > On Thu, Feb 21, 2013 at 9:03 AM, Jagan Teki wrote: >> Hi All, >> >> I am planning to use devicetree on u-boot. >> I have an experience to work with devicetree o

Re: [U-Boot] FDT howto

2013-02-24 Thread Simon Glass
Hi Jagan, On Thu, Feb 21, 2013 at 9:03 AM, Jagan Teki wrote: > Hi All, > > I am planning to use devicetree on u-boot. > I have an experience to work with devicetree on Linux. > > For u-boot, I have read doc from doc/README.fdt-control. > I see some dts usages on tegra boards. > > I have lot of co

Re: [U-Boot] [PATCH 4/4] sf: winbond: Add support for W25Q256

2013-02-24 Thread Langer Thomas (LQDE RD ST PON SW)
Hi Jagan, Am 23.02.2013 12:39, schrieb Jagannadha Sutradharudu Teki: > Add support for Winbond W25Q256 SPI flash. > As the other patches are only supporting spansion flashes, this is unrelated and should be resend independent of them. Even if not the full capacity of this flash is usable until t

Re: [U-Boot] [PATCH 3/4] sf: Add extended address access support

2013-02-24 Thread Langer Thomas (LQDE RD ST PON SW)
Hello Jagan, Am 23.02.2013 12:39, schrieb Jagannadha Sutradharudu Teki: > This patch provides support to access an extended addressing > in 3-byte address mode. > > The current implementation in spi_flash supports 3-byte address mode > due to this up to 16MB amount of flash is able to access for

Re: [U-Boot] [PATCH 2/4] sf: Add extended address register reading support

2013-02-24 Thread Langer Thomas (LQDE RD ST PON SW)
Hello Jagan, Am 23.02.2013 12:38, schrieb Jagannadha Sutradharudu Teki: > This patch provides support to read a flash extended address register. > > reading extended/bank address register will give whether the flash is operated > on extended addressing or normal addressing in 3-byte address mode.

Re: [U-Boot] [PATCH 1/4] sf: Add extended address register writing support

2013-02-24 Thread Langer Thomas (LQDE RD ST PON SW)
Hello Jagan, > > diff --git a/drivers/mtd/spi/spi_flash.c b/drivers/mtd/spi/spi_flash.c > index 00aece9..232ccc0 100644 > --- a/drivers/mtd/spi/spi_flash.c > +++ b/drivers/mtd/spi/spi_flash.c > @@ -269,6 +269,47 @@ int spi_flash_cmd_write_status(struct spi_flash *flash, > u8 sr) > return 0

Re: [U-Boot] [PATCH 0/4] sf: Accessing > 16MBytes flashes in existing 3-byte addr mode.

2013-02-24 Thread Langer Thomas (LQDE RD ST PON SW)
Hello Jagan, thanks for your contribution. As there is currently no explicit custodian for sf, I would like to give some comments to your code. Am 23.02.2013 12:38, schrieb Jagannadha Sutradharudu Teki: > The current implementation in spi_flash supports 3-byte address mode > due to this up to 1

Re: [U-Boot] [PATCH v2] mxs: timrot: Add support to i.MX23

2013-02-24 Thread Fadil Berisha
Dear Marek Vasut > Also document that you renamed some macros, even if I'd prefer if you pulled > those out into separate patch to make this easier to review. This is documented in comment for patch version v2: "v2 - Updated the struct mxs_timrot_regs so the mapping works for all registers" Since

Re: [U-Boot] [PATCH v2] mxs: timrot: Add support to i.MX23

2013-02-24 Thread Marek Vasut
Dear Fadil Berisha, > Dear Marek Vasut > > > Also document that you renamed some macros, even if I'd prefer if you > > pulled those out into separate patch to make this easier to review. > > This is documented in comment for patch version v2: > "v2 - Updated the struct mxs_timrot_regs so the map

Re: [U-Boot] uboot 2013.01.01 compile error

2013-02-24 Thread Benoît Thébaudeau
Dear Daniel-D Dax, On Sunday, February 24, 2013 9:10:32 AM, Daniel-D Dax wrote: > Hello,I'm trying to compile the uboot for the smdk6400 board. > but there is an error while compiling. > first I make distclean > then make smdk6400_config > then make > > the error appeared says that > > arm-linux

Re: [U-Boot] [PATCH v2] mxs: timrot: Add support to i.MX23

2013-02-24 Thread Marek Vasut
Dear Fadil Berisha, > This patch add timer support to i.MX23 and complete bit fields and values > on regs-timrot.h. > Testet on imx23-olinuxino board. Also document that you renamed some macros, even if I'd prefer if you pulled those out into separate patch to make this easier to review. Moreov

[U-Boot] uboot 2013.01.01 compile error

2013-02-24 Thread Daniel-D Dax
Hello,I'm trying to compile the uboot for the smdk6400 board. but there is an error while compiling. first I make distclean then make smdk6400_config then make the error appeared says that arm-linux-gnueabi-ld.bfd:u- boot.lds:19: syntax error my working environment is kubuntu 12.10 toolchain ver