Hello Jagan, thanks for your contribution.
As there is currently no explicit custodian for sf, I would like to give some comments to your code. Am 23.02.2013 12:38, schrieb Jagannadha Sutradharudu Teki: > The current implementation in spi_flash supports 3-byte address mode > due to this up to 16MB amount of flash is able to access for those > flashes which has an actual size of > 16MB. > > List of flashes: > S25FL256S > N25Q256 > N25Q256A > W25Q256(not yet mainlined) > > extended/bank address register contains an information to access the > 4th byte addressing hence the flashes which has > 16MB can be accessible. > I don't see a config option described here (and also don't find it in the patches). Please keep in mind that the code size for existing boards should not increase! See http://www.denx.de/wiki/U-Boot/DesignPrinciples , points 1 and 5 The code might fit for your use-case, but has influence on other boards/systems, and this is not acceptable. Please add a config option for this new code and also use the existing options, like CONFIG_SPI_FLASH_SPANSION, in your code. > > Thanks, > Jagan. > Best Regards, Thomas _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
