Re: [U-Boot] unneeded exported function i2c_mux_add_device

Hello Frans, Frans Meulenbroeks wrote: > While grepping some sources I bumped upon i2c_mux_add_device > This one is implemented in cmd_i2c.c and exported through i2c.h. > However no-one outside cmd_i2c.c is using it: > > fr...@linux-suse:~/u-boot> grep -r i2c_mux_add_device . > ./common/cmd_i2c.c

Re: [U-Boot] [PATCH] net, fec_mxc: use mac address stored in env before looking in eeprom

Hello Mike, Mike Frysinger wrote: > On Wednesday 24 March 2010 07:56:28 Heiko Schocher wrote: >> doc/README.enetaddr prescribes, to use a mac address stored in >> environment, before using a mac address stored in some special >> place. > > you're reading things incorrectly, or you didnt read the

Re: [U-Boot] [PATCH 3/4] SPEAr : Network driver support added

Hi Vipin, On Wed, Mar 24, 2010 at 9:48 PM, Vipin KUMAR wrote: > On 3/23/2010 11:09 PM, Ben Warren wrote: > > Hi Vipin, > > Hello Ben, > > > On 3/23/2010 1:30 AM, Vipin KUMAR wrote: > >> SPEAr SoCs support a synopsys network peripheral. This patch adds the > >> support > >> for the same > >> > >>

Re: [U-Boot] The purpose of enabling CONFIG_PCI_BOOTDELAY

On Wednesday 24 March 2010 22:34:59 Andrew Dyer wrote: > >> What is the purpose of CONFIG_PCI_BOOTDELAY? I am using uboot version > > > > Adding a delay so the PCI controllers can come up and stabilize. > > > >> Specifically in my case, all the resets on my board have occurred well > >> before (5

Re: [U-Boot] [PATCH 3/4] SPEAr : Network driver support added

On 3/23/2010 11:09 PM, Ben Warren wrote: > Hi Vipin, Hello Ben, > On 3/23/2010 1:30 AM, Vipin KUMAR wrote: >> SPEAr SoCs support a synopsys network peripheral. This patch adds the >> support >> for the same >> >>Signed-off-by: Vipin Kumar >> --- >> board/spear/spear300/spear300.c |

[U-Boot] [PATCH] DM9000: fix build when debugging is enabled

From: Brent Kandetzki The debug code uses the gcc __func__ define, but tries to use it as a static const string which no longer works. So treat it like a normal printf string argument. Signed-off-by: Brent Kandetzki Signed-off-by: Mike Frysinger --- drivers/net/dm9000x.c |2 +- 1 files c

Re: [U-Boot] The purpose of enabling CONFIG_PCI_BOOTDELAY

On Wed, Mar 24, 2010 at 4:10 PM, Wolfgang Denk wrote: > Dear Mike, > > In message > you > wrote: >> >> What is the purpose of CONFIG_PCI_BOOTDELAY? I am using uboot version > > Adding a delay so the PCI controllers can come up and stabilize. > >> Specifically in my case, all the resets on my bo

Re: [U-Boot] console_buffer

On 3/24/2010 2:08 PM, Wolfgang Denk wrote: > Dear Ben, > > In message<4baa6f5c.5060...@gmail.com> you wrote: > >> ... You'll get more feedback when people don't like what you did, >> but any EE will tell you that negative feedback is the path to stability :) >> > May I add this to

Re: [U-Boot] The purpose of enabling CONFIG_PCI_BOOTDELAY

Dear Mike, In message you wrote: > > What is the purpose of CONFIG_PCI_BOOTDELAY? I am using uboot version Adding a delay so the PCI controllers can come up and stabilize. > Specifically in my case, all the resets on my board have occurred well > before (500 msec) this portion of the code wou

Re: [U-Boot] console_buffer

Dear Ben, In message <4baa6f5c.5060...@gmail.com> you wrote: > > ... You'll get more feedback when people don't like what you did, > but any EE will tell you that negative feedback is the path to stability :) May I add this to my list of signature quotes? Best regards, Wolfgang Denk --

[U-Boot] [review request] cmd_bmp.c: added standard subcommand handling

--- Hi, This is not a formal patch but a review request. Do people feel this patch is desirable and ok? and should I keep it like this, or should I merge do_bmp_info and bmp_info into one func (and similarly for do_bmp_display and bmp_display) and please ignore the superfluous int x = 0, y = 0;

[U-Boot] The purpose of enabling CONFIG_PCI_BOOTDELAY

All, What is the purpose of CONFIG_PCI_BOOTDELAY? I am using uboot version 1.1.4. I know it's old, but in \drivers\pci.c there is a section of code right before pci_init.c is called that can delay the call to pci_init.c. The code is enabled by defining CONFIG_PCI_BOOTDELAY. But why would it be

Re: [U-Boot] [PATCH] net, fec_mxc: use mac address stored in env before looking in eeprom

On Wednesday 24 March 2010 08:52:26 Detlev Zundel wrote: > What Heiko _really_ fixes is that the board has a problem with linux > when no network transfer was done in U-Boot. Looking at the code, this > is quite obvious as this special driver does not program any mac address > into the controller

Re: [U-Boot] [PATCH] net, fec_mxc: use mac address stored in env before looking in eeprom

On Wednesday 24 March 2010 07:56:28 Heiko Schocher wrote: > doc/README.enetaddr prescribes, to use a mac address stored in > environment, before using a mac address stored in some special > place. you're reading things incorrectly, or you didnt read the whole thing. the fec_mxc driver is correct

Re: [U-Boot] console_buffer

Oops. Replied to Ben only not to the list. Here is my reply. Actually did a quick grep -r -w afterwards: there are roughly 475 .c files with extern in it. Guess this is a more widely spread issue. (btw personally I feel that it is a sign of clean programming to declare all exported functions in a

Re: [U-Boot] console_buffer

Hi Frans, On 3/24/2010 12:52 PM, Frans Meulenbroeks wrote: > yet another potential cleanup: > > I see both: > extern char console_buffer[]; > and > extern char console_buffer[CONFIG_SYS_CBSIZE]; > > (and in fact console_buffer is declared as: > charconsole_buffer[CONFIG_SYS_CBSIZE + 1];

[U-Boot] console_buffer

yet another potential cleanup: I see both: extern char console_buffer[]; and extern char console_buffer[CONFIG_SYS_CBSIZE]; (and in fact console_buffer is declared as: charconsole_buffer[CONFIG_SYS_CBSIZE + 1]; /* console I/O buffer */ so with a +1). Questions: is the first or th

Re: [U-Boot] [PATCH] USB storage count

Hi, 2010/3/12 Kim B. Heino : > Here's another USB storage patch. Currently U-Boot handles storage > devices #0 - #4 as valid devices, even if there is none connected. This > patch fixes usb_stor_get_dev() to check detected device count instead > of MAX-define. > > This is very important for ill be

Re: [U-Boot] [PATCH] USB storage probe

Hi, 2010/3/12 Kim B. Heino : > While debugging one ill behaving USB device I found two bugs in USB > storage probe. > > usb_stor_get_info() returns -1 (error), 0 (skip) or 1 (ok). First part > of this patch fixes error case. > > Second part fixes usb_inquiry()'s retry counter handling. Original co

Re: [U-Boot] [PATCH] at91: Get rid of some warnings when building for otc570

> Dear Matthias Fuchs, > > In message <201003241016.20459.matthias.fu...@esd.eu> you wrote: > > The soft-i2c code for AT91 defines I2C_SOFT_DECLARATIONS > > for direct access by dereferencing a pio pointer. > > The OTC570 platform uses the AT91 gpio API so it does not > > need the pio variable. >

[U-Boot] unneeded exported function i2c_mux_add_device

Dear list: While grepping some sources I bumped upon i2c_mux_add_device This one is implemented in cmd_i2c.c and exported through i2c.h. However no-one outside cmd_i2c.c is using it: fr...@linux-suse:~/u-boot> grep -r i2c_mux_add_device . ./common/cmd_i2c.c:int i2c_mux_add_device(I2C_MUX_DEVICE *

[U-Boot] iMX51 Diagnostic LED's how to control

Hello, I am trying to control (turn on and off) the "General-purpose diagnostic LED's" of my iMX51 EVK board programatically using C. I am developing under Linux (u-boot). Any help appreciated. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.de

[U-Boot] Pull request - ColdFire next

Wolfgang, Please pull for next branch. Regards, TsiChung The following changes since commit 859500a2be94bfa77a845b9c8a4c499587035fd5: Wolfgang Denk (1): Merge remote branch 'origin/master' into next are available in the git repository at: git://git.denx.de/u-boot-coldfire.git next

Re: [U-Boot] [PATCH v2] cfi_flash: precision and underflow problem in tout calculation

On 03/24/2010 09:46 PM, Stefan Roese wrote: > Hi Thomas, > > On Wednesday 24 March 2010 01:55:28 Thomas Chou wrote: > >> From: Renato Andreola >> >> With old configuration it could happen tout=0 if CONFIG_SYS_HZ<1000. >> >> Signed-off-by: Alessandro Rubini >> Signed-off-by: Renato Andreola >>

[U-Boot] [PATCH v3] cfi_flash: precision and underflow problem in tout calculation

From: Renato Andreola With old configuration it could happen tout=0 if CONFIG_SYS_HZ<1000. Signed-off-by: Renato Andreola Signed-off-by: Alessandro Rubini Signed-off-by: Thomas Chou --- drivers/mtd/cfi_flash.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drive

Re: [U-Boot] [PATCH] Add support for Indefia Nimbus Cloud Board

Hi Wolfgang, Hi Semih, On Tuesday 23 March 2010 21:01:12 Wolfgang Denk wrote: > > It's not possible to simply disable caching for 0x0 region. It can be > > achieved using paging, but it's more complicated. > > I have three specific questions: > > * Is it technically possible to set up the AVR32

[U-Boot] [PATCH v2] nios2: flush data cache after relocating code in start.S

If we relocate the code, the data cache must be flushed before we jump to the new code. Signed-off-by: Thomas Chou --- cpu/nios2/start.S | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/cpu/nios2/start.S b/cpu/nios2/start.S index 31cd5b0..61784d8 100644 --- a/c

[U-Boot] Please pull u-boot-ppc4xx/master

Hi Wolfgang, please pull this fix into master: The following changes since commit 7027d5622d56ee2292713773044fb6352e431f31: Wolfgang Denk (1): Merge branch 'master' of git://git.denx.de/u-boot-video are available in the git repository at: git://www.denx.de/git/u-boot-ppc4xx.git mast

Re: [U-Boot] [PATCH v2] cfi_flash: precision and underflow problem in tout calculation

Hi Thomas, On Wednesday 24 March 2010 01:55:28 Thomas Chou wrote: > From: Renato Andreola > > With old configuration it could happen tout=0 if CONFIG_SYS_HZ<1000. > > Signed-off-by: Alessandro Rubini > Signed-off-by: Renato Andreola Sorry for nitpicking again, but you need to add your S-o-b

Re: [U-Boot] [PATCH v3] ppc4xx fix unstable 440EPx bootstrap options

Hi Rup, On Wednesday 24 March 2010 12:22:02 Rupjyoti Sarmah wrote: > 440EPx fixed bootstrap options A, B, D, and E sets PLL FWDVA to a value = > 1. This results in the PLLOUTB being greater than the CPU clock frequency > resulting unstable 440EPx operation resulting in various software hang > cond

Re: [U-Boot] [PATCH] net: add opencore 10/100 ethernet mac driver

On 03/24/2010 03:54 PM, Mike Frysinger wrote: > On Wednesday 24 March 2010 02:24:41 Thomas Chou wrote: > >> +static int ethoc_set_mac_address(struct eth_device *dev, void *addr) >> +{ >> +struct ethoc *priv = (void *)dev->priv; >> +u8 *mac = (u8 *) addr; >> + >> +ethoc_write(priv, M

[U-Boot] [PATCH v2] net: add opencore 10/100 ethernet mac driver

This patch ports the opencore 10/100 ethernet mac driver ethoc.c from linux kernel to u-boot. Signed-off-by: Thomas Chou --- drivers/net/Makefile |1 + drivers/net/ethoc.c | 533 ++ include/netdev.h |1 + 3 files changed, 535 insertio

Re: [U-Boot] Pull request: u-boot-video/master

Dear Anatolij Gustschin, In message <20100324114850.68b46...@wker> you wrote: > Dear Wolfgang, > > The following changes since commit 152dda3d94e97ede7af3f9560a59a659384d4585: > Wolfgang Denk (1): > Prepare v2010.03-rc2 > > are available in the git repository at: > > git://git.denx.

Re: [U-Boot] [PATCH] net, fec_mxc: use mac address stored in env before looking in eeprom

Hello stefano, Stefano Babic wrote: > Heiko Schocher wrote: > > Hi Heiko, > >> Signed-off-by: Heiko Schocher >> --- >> drivers/net/fec_mxc.c | 15 +++ >> 1 files changed, 11 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c >> index 5a

Re: [U-Boot] [PATCH] net, fec_mxc: use mac address stored in env before looking in eeprom

Hi Stefano, > Heiko Schocher wrote: > > Hi Heiko, > >> >> Signed-off-by: Heiko Schocher >> --- >> drivers/net/fec_mxc.c | 15 +++ >> 1 files changed, 11 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c >> index 5af9cdb..b5245ec 100644

Re: [U-Boot] [PATCH] net, fec_mxc: use mac address stored in env before looking in eeprom

Heiko Schocher wrote: Hi Heiko, > > Signed-off-by: Heiko Schocher > --- > drivers/net/fec_mxc.c | 15 +++ > 1 files changed, 11 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c > index 5af9cdb..b5245ec 100644 > --- a/drivers/net/fec_mx

[U-Boot] USB storage patch status?

Hello, It's been 12 days. Any comments about my two patches? http://lists.denx.de/pipermail/u-boot/2010-March/068409.html [PATCH] USB storage probe http://lists.denx.de/pipermail/u-boot/2010-March/068417.html [PATCH] USB storage count ___ U-Boot mailin

Re: [U-Boot] [PATCH] ml300: remove support for broken, orphaned board

Wolfgang Denk wrote: > Dear Michal Simek, > > In message <4ba9f871.1080...@monstr.eu> you wrote: >> Wolfgang Denk wrote: >>> The ml300 board has a number of issues, but nobody cares about this >>> long-orphaned board any more. Remove it. > ... >> It is ancient board. >> I agree. > > Maybe you ca

[U-Boot] [PATCH v2] jffs2, suen3: Fix compiler warning

$ ./MAKEALL suen3 jffs2_1pass.c: In function 'get_fl_mem': jffs2_1pass.c:399: warning: unused variable 'id' jffs2_1pass.c: In function 'get_node_mem': jffs2_1pass.c:423: warning: unused variable 'id' Signed-off-by: Heiko Schocher --- - changes since v1: added comment from Wolfgang Denk fixed

Re: [U-Boot] [PATCH] at91: Get rid of some warnings when building for otc570

Dear Matthias Fuchs, In message <201003241016.20459.matthias.fu...@esd.eu> you wrote: > The soft-i2c code for AT91 defines I2C_SOFT_DECLARATIONS > for direct access by dereferencing a pio pointer. > The OTC570 platform uses the AT91 gpio API so it does not > need the pio variable. > > Signed-off-

Re: [U-Boot] [PATCH] jffs2, suen3: Fix compiler warning

Dear Heiko Schocher, In message <4ba9ad21.6020...@denx.de> you wrote: > > $ ./MAKEALL suen3 > jffs2_1pass.c: In function 'get_fl_mem': > jffs2_1pass.c:399: warning: unused variable 'id' > jffs2_1pass.c: In function 'get_node_mem': > jffs2_1pass.c:423: warning: unused variable 'id' > > Signed-off

[U-Boot] [PATCH] net, fec_mxc: use mac address stored in env before looking in eeprom

doc/README.enetaddr prescribes, to use a mac address stored in environment, before using a mac address stored in some special place. This patch fixes this for the fec_mxc driver. Tested on the magnesium board. Signed-off-by: Heiko Schocher --- drivers/net/fec_mxc.c | 15 +++ 1 fil

Re: [U-Boot] [PATCH] ml300: remove support for broken, orphaned board

Dear Michal Simek, In message <4ba9f871.1080...@monstr.eu> you wrote: > Wolfgang Denk wrote: > > The ml300 board has a number of issues, but nobody cares about this > > long-orphaned board any more. Remove it. ... > It is ancient board. > I agree. Maybe you can send a formal Acked-by: then ? Th

Re: [U-Boot] [PATCH] ml300: remove support for broken, orphaned board

Wolfgang Denk wrote: > The ml300 board has a number of issues, but nobody cares about this > long-orphaned board any more. Remove it. > > Signed-off-by: Wolfgang Denk > --- > MAKEALL |1 - > Makefile |3 - > board/xilinx/ml300/M

[U-Boot] [PATCH v3] ppc4xx fix unstable 440EPx bootstrap options

440EPx fixed bootstrap options A, B, D, and E sets PLL FWDVA to a value = 1. This results in the PLLOUTB being greater than the CPU clock frequency resulting unstable 440EPx operation resulting in various software hang conditions. This patch reprograms the FWDVA satisfying the requirement of setti

[U-Boot] [PATCH] ml300: remove support for broken, orphaned board

The ml300 board has a number of issues, but nobody cares about this long-orphaned board any more. Remove it. Signed-off-by: Wolfgang Denk --- MAKEALL |1 - Makefile |3 - board/xilinx/ml300/Makefile | 70 - board

[U-Boot] Pull request: u-boot-video/master

Dear Wolfgang, The following changes since commit 152dda3d94e97ede7af3f9560a59a659384d4585: Wolfgang Denk (1): Prepare v2010.03-rc2 are available in the git repository at: git://git.denx.de/u-boot-video.git master Alessandro Rubini (1): lcd: make 16bpp work common/lcd.c |

Re: [U-Boot] [STATUS] v2010.03-rc2 is out

Dear Alessandro Rubini, In message <20100324075120.ga20...@morgana.gnudd.com> you wrote: > > - ARM: > > > > A few boards are broken or produce tons of warnings: otc570, suen3, > > a320evb, etc. Fixes welcome / needed. > > Nomadik nhk8815 is broken as the timer fix is still missing > (nand w

Re: [U-Boot] [PATCH] lcd: make 16bpp work

On Sat, 13 Mar 2010 17:44:08 +0100 Anatolij Gustschin wrote: > From: Alessandro Rubini > > Support for 16bpp was supposed to be in the code but was not working. > This makes it work and has been tested in the nhk8815 board. > > Signed-off-by: Alessandro Rubini > Acked-by: Andrea Gallo > Sign

Re: [U-Boot] [PATCH] SPI: added support for MX51 to mxc_spi

Liu Hui-R64343 wrote: > Hi, Hi, >> >> static unsigned long spi_bases[] = { >> 0x43fa4000, >> 0x5001, >> 0x53f84000, >> }; > Here hardcode the value in mx31, while in mx51 it use the macro. Which makes > Code style not consistent. yes, agree, the driver already contains

[U-Boot] [PATCH] at91: Get rid of some warnings when building for otc570

The soft-i2c code for AT91 defines I2C_SOFT_DECLARATIONS for direct access by dereferencing a pio pointer. The OTC570 platform uses the AT91 gpio API so it does not need the pio variable. Signed-off-by: Matthias Fuchs --- include/configs/otc570.h |1 + 1 files changed, 1 insertions(+), 0 del

Re: [U-Boot] [PATCH] MPC5200: Add initial support for Matrix Vision mvSMR board

Detlev, > Hi Andre, > > just a few obligatory remarks... > thanks for pointing this out - these are remnants dated from 2006 ... simply overlooked them while concentrating on proper git usage :-) Will wait for some more comments and resubmit v2 tomorrow. Regards, André MATRIX VISION GmbH,

Re: [U-Boot] [PATCH] MPC5200: Add initial support for Matrix Vision mvSMR board

Hi Andre, just a few obligatory remarks... > Add initial support for Matrix Vision mvSMR board based on MPC5200B. > > Signed-off-by: Andre Schwarz > --- > CREDITS |2 +- > MAINTAINERS |1 + > MAKEALL |

[U-Boot] [PATCH] SAMSUNG: serial: modify name from s5pc1xx to s5p

Because of other s5p series SoC will use these serial functions, modify function's name and structure's name. Signed-off-by: Minkyu Kang --- common/serial.c | 16 ++-- drivers/serial/Makefile |2 +- drivers/serial/serial_s5p.c | 205

[U-Boot] [PATCH] SAMSUNG: make s5p common gpio functions

Because of s5pc1xx gpio is same as s5p seires SoC, move gpio functions to drvier/gpio/ and modify structure's name from s5pc1xx_ to s5p_. Signed-off-by: Minkyu Kang --- cpu/arm_cortexa8/s5pc1xx/Makefile |1 - cpu/arm_cortexa8/s5pc1xx/gpio.c | 143 -- drivers/gp

Re: [U-Boot] [PATCH] net: add opencore 10/100 ethernet mac driver

On Wednesday 24 March 2010 02:24:41 Thomas Chou wrote: > +static int ethoc_set_mac_address(struct eth_device *dev, void *addr) > +{ > + struct ethoc *priv = (void *)dev->priv; > + u8 *mac = (u8 *) addr; > + > + ethoc_write(priv, MAC_ADDR0, (mac[2] << 24) | (mac[3] << 16) | > +

Re: [U-Boot] [PATCH] net: add altera triple speeds ethernet mac driver

On Wednesday 24 March 2010 02:32:46 Thomas Chou wrote: > +int altera_tse_init(bd_t *bis, int num_tses) so "num_tses" is the # of devices to allocate ... > + return 1; ... but you always return 1. this should probably be num_tses. > + for (num = 0; num < num_tses; num++) { > +

Re: [U-Boot] [STATUS] v2010.03-rc2 is out

> - ARM: > > A few boards are broken or produce tons of warnings: otc570, suen3, > a320evb, etc. Fixes welcome / needed. Nomadik nhk8815 is broken as the timer fix is still missing (nand write doesn't work reliably, for example saveenv). Shall I repost "Nomadik: fix reset_timer()" ? Also, b