Re: [Twisted-Python] Migration to Git / GitHub

2015-11-14 Thread Craig Rodrigues
On Fri, Nov 13, 2015 at 6:29 PM, Glyph Lefkowitz wrote: > > > We then asked people for money based on this document. So GitHub is more > or less a done deal :-). > > If the plan is GitHub and the project is fine with that, then cool. If there is time, I would recommend that the project take a qu

[Twisted-Python] Suggested plan for GitHub migration

2015-11-17 Thread Craig Rodrigues
On Tue, Nov 17, 2015 at 8:57 AM, Adi Roiban wrote: > > For now, the funds were raised to migrate to GitHub, so we can not use > them to do other things. > > We will stay on Trac for issues... at least for now. > > I have no idea how we can migrate to any issue tracker without losing > data if we

Re: [Twisted-Python] Suggested plan for GitHub migration

2015-12-03 Thread Craig Rodrigues
On Tue, Dec 1, 2015 at 5:01 PM, Glyph Lefkowitz wrote: > > One thing that I'd love to see is a checklist that is kept up-to-date > regarding which parts of this have already happened. > > I worked with Amber and Adi and we have the checklist: https://github.com/twisted-infra/braid/blob/git-migrat

Re: [Twisted-Python] Suggested plan for GitHub migration

2015-12-04 Thread Craig Rodrigues
On Thu, Dec 3, 2015 at 7:07 PM, Glyph Lefkowitz wrote: > The important thing about a "checklist" though, is checking things off - > how will that be kept up to date in sync with what has actually happened? > > The checklist is written using the GitHub flavored markdown syntax for checklists: htt

Re: [Twisted-Python] overview: new review queue venue

2016-05-21 Thread Craig Rodrigues
On Sat, May 21, 2016 at 3:12 PM, Glyph wrote: > Hooray! We're on github now. Next: there's the question of how to deal > with pull requests? > A few people, including myself modified the text with Git instructions: https://twistedmatrix.com/trac/wiki/TwistedDevelopment#SubmittingaPatch The b

Re: [Twisted-Python] overview: new review queue venue

2016-05-21 Thread Craig Rodrigues
On Sat, May 21, 2016 at 11:37 PM, Glyph wrote: > > I realize it can feel like that sometimes, but Google Analytics suggests > the large majority of our visitors (45%) are on Windows. By contrast, > 0.05% are on FreeBSD. Granted, that's a *very *high percentage of > FreeBSD clients for the Inter

Re: [Twisted-Python] overview: new review queue venue

2016-05-22 Thread Craig Rodrigues
On Sat, May 21, 2016 at 6:04 PM, Glyph wrote: > > Right now, we need to manually vet each change before sending it to > buildbots, because they are shared mutable environments that we can't > afford to have running untrusted code automatically. > This is quite useful actually. We would need a t

Re: [Twisted-Python] overview: new review queue venue

2016-05-22 Thread Craig Rodrigues
I submitted this PR, which is now closed: https://github.com/twisted/twisted/pull/62 I don't want to re-open that PR, but I am using that as an example As an example, if I wanted to re-open that, how would I go about doing it? I am not an administrator of the Twisted GitHub project, so on that we

Re: [Twisted-Python] overview: new review queue venue

2016-05-24 Thread Craig Rodrigues
Hi, Thanks for bringing up these points. See: https://twistedmatrix.com/trac/ticket/8352 Feel free to add any thoughts you may have on how to improve this. -- Craig On Tue, May 24, 2016 at 10:37 AM, Jonathan Vanasco wrote: > FWIW, I just noticed that the CONTRIBUTING message wasn't showing u

[Twisted-Python] Need clarification on reviews for Python 3 fixes for Twisted

2016-05-27 Thread Craig Rodrigues
Hi, I have submitted some Python 3 patches for Twisted. 1. PATCHES REVIEWED AND COMMITTED TO TRUNK = Use new syntax for catching exceptions https://twistedmatrix.com/trac/ticket/8344 Use new syntax for raising exceptions https://twistedmatrix.com/tra

Re: [Twisted-Python] Need clarification on reviews for Python 3 fixes for Twisted

2016-06-04 Thread Craig Rodrigues
On Fri, May 27, 2016 at 6:14 AM, Wolfgang Rohdewald < wolfgang@rohdewald.de> wrote: > Am Freitag, 27. Mai 2016, 08:13:10 schrieb Itamar Turner-Trauring: > > This would have been helpful when I tried to port PB to python3. > Instead, that port is now bitrotting. > Can you point me to your atte

Re: [Twisted-Python] Need clarification on reviews for Python 3 fixes for Twisted

2016-06-05 Thread Craig Rodrigues
On Fri, May 27, 2016 at 5:13 AM, Itamar Turner-Trauring wrote: On 05/27/2016 04:19 AM, Craig Rodrigues wrote: > > I think they're fine to accept insofar as: > > 1. There is strong ongoing momentum for the port now, so these changes > makes porting module-by-module easier a

Re: [Twisted-Python] Travis-CI integration work

2016-06-07 Thread Craig Rodrigues
Travis-CI integration for Twisted has reached a milestone! Travis has been set up and is currently in use for Twisted. For pull requests submitted against Twisted: https://github.com/twisted/twisted/pulls the Travis service will build it, and report status in the pull request itself. The build s

[Twisted-Python] Using zope

2016-06-10 Thread Craig Rodrigues
Hi, There are some places in the Twisted code which use zope.interface to do things like: class MyClass: inherits(IMyInterface) That works in Python 2, but the zope.interface library has code to hard fail that line on Python 3. The supported way of doing the same thing on Python 2 and 3 i

[Twisted-Python] Porting PB to python3

2016-06-10 Thread Craig Rodrigues
Hi, I reviewed your branch: https://github.com/wrohdewald/twisted/commits/spread-py3-7598/twisted In my opinion, that branch has two categories of Python 3 porting: Category 1: Minor -> these are "minor" fixos, such as dealing with xrange -> range Category 2: Major -> you have done a lot o

Re: [Twisted-Python] Responding to PRs

2016-06-12 Thread Craig Rodrigues
Hi, I support this approach. I have a few small suggestions. (1) Give the exact link of some reasonable text that you want people to read. The contributor guidelines are accurate, but the text is verbose. It takes a while to get to the text that gives you the actual steps to follow.

[Twisted-Python] Need write access to Twisted

2016-06-16 Thread Craig Rodrigues
Hi, Can someone grant me write access to Twisted? I want to continue with my Python3 porting patches, and help test things directly on the buildbots. Thanks. -- Craig ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix

Re: [Twisted-Python] Need write access to Twisted

2016-06-17 Thread Craig Rodrigues
On Fri, Jun 17, 2016 at 12:23 AM, Glyph wrote: > > I am also +1. I think Craig has demonstrated the utmost respect for the > process and has demonstrated a clear ability to follow it, which is the > main criteria. > > > Thank you. I will do my best to maintain the high standards of the Twisted

[Twisted-Python] Question about twistedchecker failures

2016-06-21 Thread Craig Rodrigues
Hi, Why did this twistedchecker build succeed: https://buildbot.twistedmatrix.com/builders/twistedchecker/builds/341 and this one fail: https://buildbot.twistedmatrix.com/builders/twistedchecker/builds/342 I don't understand what is causing the failure. I looked at: https://github.com/twisted-i

Re: [Twisted-Python] two minor things

2016-06-21 Thread Craig Rodrigues
On Tue, Jun 21, 2016 at 12:07 PM, Glyph wrote: > > 2. The branch-naming convention puts the ticket number at the _end_ of the > branch name. > > For example, foo-1234, not 1234-foo. If we re-add the automation to > recognize branch names and update the 'branch' field in trac, getting this > cons

[Twisted-Python] windows7-64-py3.5 buildbot failure

2016-06-22 Thread Craig Rodrigues
Hi, I notice that this buildbot is failing because it cannot find vcvarsall.bat https://buildbot.twistedmatrix.com/builders/windows7-64-py3.5/builds/174/steps/shell_2/logs/stdio I was able to get a Windows 10 environment going by doing the following: (1) Installing Python 3.5 from https://www.

Re: [Twisted-Python] windows7-64-py3.5 buildbot failure

2016-06-23 Thread Craig Rodrigues
On Thu, Jun 23, 2016 at 1:39 PM, Glyph wrote: > > > On Jun 22, 2016, at 23:14, Craig Rodrigues wrote: > > Can we fix this buildbot at least to the point where we can do that? > > > Since nobody answered, and I'd really rather not spend my vacation > maintaining W

[Twisted-Python] FreeBSD buildbots down?

2016-06-30 Thread Craig Rodrigues
Hi, The FreeBSD buildbots seem to be down since May 26. https://buildbot.twistedmatrix.com/boxes-all Any ideas as to what is wrong? -- Craig ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listi

[Twisted-Python] Fwd: More tests running on Python 3

2016-06-30 Thread Craig Rodrigues
Hi, I looked at these two Travis builds on Linux DATE BUILD = June 3, 2016https://travis-ci.org/twisted/twisted/builds/135219940 June 30, 2016https://travis-ci.org/twisted/twisted/builds/141426367 I noticed: DATE Tests on Python 2.7

Re: [Twisted-Python] Coverage exceptions

2016-06-30 Thread Craig Rodrigues
Hi, The conversation about coverage exceptions came up due to this: https://github.com/twisted/twisted/pull/261 I have that up to 97.87% of patch coverage. I cannot merge it because the codecov integration with GitHub is currently configured to not accept patches which don't have 100% patch cov

[Twisted-Python] Captcha warnings preventing me from submitting changes to Trac ticket

2016-06-30 Thread Craig Rodrigues
Hi, I tried to modify a Trac ticket, but when I tried to submit the changes, I got a Captcha warning that prevented it. When I clicked on the checkbox, "I am not a robot" and tried to re-submit, the Captcha warning re-appeared and blocked the submission. Can someone please fix this? -- Craig ___

[Twisted-Python] Script which uploads coverage results to codecov failed, but reported success?

2016-07-01 Thread Craig Rodrigues
Hi, For this pull request: https://github.com/twisted/twisted/pull/284 This Windows build ran and tried to upload coverage results to codecov: https://buildbot.twistedmatrix.com/builders/windows7-64-py2.7-coverage/builds/623/steps/shell_5/logs/stdio but failed with this: Error: 403 Client Err

Re: [Twisted-Python] Script which uploads coverage results to codecov failed, but reported success?

2016-07-01 Thread Craig Rodrigues
On Fri, Jul 1, 2016 at 11:34 AM, Craig Rodrigues wrote: > > Error: 403 Client Error: Forbidden for url: > https://codecov.s3.amazonaws.com/v4/raw/2016-07-01/BB05435E28F8047E9B3D49B4B7BFA4B3/4a5903d2f0fcab3db7c6ca68ff563e2c859dd5c2/031e0d8f-aadc-47ae-9b69-29ca9d962287.txt?AWSAc

Re: [Twisted-Python] Coverage exceptions

2016-07-03 Thread Craig Rodrigues
On Sun, Jul 3, 2016 at 9:10 AM, Glyph Lefkowitz wrote: > > For now, let's just bite the bullet and require 100% patch coverage from > here on out. If we hit a really nasty case where it really *is* a > significant investment of effort, then maybe we can revisit this discussion > and explore a be

[Twisted-Python] Python 3 code coverage not working?

2016-07-03 Thread Craig Rodrigues
Hi, I submitted this pull request: https://github.com/twisted/twisted/pull/224 and codecov is saying that only 66.67% of the patch is covered because it is not hitting the Python 3 specific block: https://codecov.io/gh/twisted/twisted/compare/502f3a1e2cc125d214b6b7df5b173aa91fc7f966...d286bf22f8b

Re: [Twisted-Python] Python 3 code coverage not working?

2016-07-04 Thread Craig Rodrigues
On Sun, Jul 3, 2016 at 11:00 PM, Adi Roiban wrote: > > > > On 4 July 2016 at 00:43, Craig Rodrigues wrote: > >> Hi, >> >> I submitted this pull request: >> https://github.com/twisted/twisted/pull/224 >> >> and codecov is saying that only

Re: [Twisted-Python] Python 3 code coverage not working?

2016-07-04 Thread Craig Rodrigues
On Mon, Jul 4, 2016 at 3:30 AM, Adi Roiban wrote: > > > Is it possible to add the actual invocation of setup.py to coverage? >> > > > That seems like a hole that the actual invocation of setup.py that does >> the build and install >> > > is not part of the coverage reporting. setup.py is just a

Re: [Twisted-Python] Python 3 code coverage not working?

2016-07-04 Thread Craig Rodrigues
On Sun, Jul 3, 2016 at 11:00 PM, Adi Roiban wrote: > > > Only the modules (including the test modules) from dist3.py are executed > on Python3 > https://github.com/twisted/twisted/blob/trunk/twisted/python/dist3.py > > In the header of that file you can see > > # -*- test-case-name: twisted.pytho

Re: [Twisted-Python] Twisted 16.3.0 Prerelease 2 Announcement

2016-07-04 Thread Craig Rodrigues
On Sun, Jul 3, 2016 at 3:15 AM, Paweł Miech wrote: > HTTP2 support sounds really exciting. > > > Please let me know if you have any issues, as well as if you don't! If > everything works well, that's a good thing for me to know :) > > I played around with this today and found out that the command

Re: [Twisted-Python] Coverage exceptions

2016-07-05 Thread Craig Rodrigues
On Tue, Jul 5, 2016 at 5:18 AM, Adi Roiban wrote: > > > > I have disabled codecov patch coverage for now as I think that codecov.io reporting is buggy. > > For coverage merge protection please see See https://github.com/twisted-infra/braid/issues/213 > I'm still seeing problems with codecov. In

[Twisted-Python] PyPy buildbot, less failed tests

2016-07-11 Thread Craig Rodrigues
I would like to acknowledge the contributions of Ville Skyttä who submitted several patches to close open file descriptors in various Twisted tests. I looked at these two PyPy builds: https://buildbot.twistedmatrix.com/builders/ubuntu16.04-pypy5/builds/207 52 Failed tests (20 failures, 32 errors)

[Twisted-Python] Trial running tests on Windows Python 3

2016-07-11 Thread Craig Rodrigues
I have committed some fixes to trunk, and now trial is running tests on Windows Python 3. This buildbot is one example build with Python 3.5: https://buildbot.twistedmatrix.com/builders/win2012r2-64-py3.5/builds/12 There are some test failures, but a lot of things are passing. One nice thing to

Re: [Twisted-Python] Twisted 16.3.0 Prerelease 2 Announcement

2016-07-11 Thread Craig Rodrigues
On Mon, Jul 11, 2016 at 2:04 PM, Paweł Miech wrote: > 1) They say ciphers should be set to ssl_ciphers > EECDH+CHACHA20:EECDH+AES128:RSA+AES128:EECDH+AES256:RSA+AES256:EECDH+3DES:RSA+3DES:!MD5; > > This long string does not mean much to me, but reading email from Amber > again I see it differs sl

[Twisted-Python] New users cannot subscribe to mailing list

2016-07-15 Thread Craig Rodrigues
Hi, I have talked to two recent contributors to Twisted, and both mentioned to me that they cannot subscribe to the mailing list. The mailing list is essentially unusable to new subscribers. Is anyone working on fixing this? -- Craig ___ Twisted-Python

Re: [Twisted-Python] New users cannot subscribe to mailing list

2016-07-15 Thread Craig Rodrigues
On Fri, Jul 15, 2016 at 2:14 PM, Glyph Lefkowitz wrote: > > > I am aware and I am working on it. The subscription interface has been > disabled because it's a magnet for backscatter spam that was being used in > several nefarious ways, so we can't really turn it back on in its current > state; I

Re: [Twisted-Python] New users cannot subscribe to mailing list

2016-07-15 Thread Craig Rodrigues
On Fri, Jul 15, 2016 at 1:11 PM, Tristan Seligmann wrote: > > I believe this email explains things: > http://twistedmatrix.com/pipermail/twisted-python/2016-March/030233.html > Two comments about that posting: (1) For someone who is not subscribed to the mailing list, that isn't going to help

[Twisted-Python] buildbot.twistedmatrix.com is down a lot

2016-07-16 Thread Craig Rodrigues
In the past few days, buildbot.twistedmatrix.com seems to be down all the time, and requires manual restarts. As I write this, it is down right now. Is there something wrong with the hardware involved with buildbot.twistedmatrix.com? -- Craig ___ Twist

Re: [Twisted-Python] Twisted tests on public CI

2016-07-20 Thread Craig Rodrigues
On Wed, Jul 20, 2016 at 2:36 PM, Glyph Lefkowitz wrote: > > > I am starting to wonder if we could get rid of the entire current buildbot > environment with all its complicated trust issues and just start over with > the parts that we actually want: on-demand, latent FreeBSD and Windows > builders

[Twisted-Python] Windows buildbots and Appveyor

2016-07-20 Thread Craig Rodrigues
The Appveyor setup with Python 2.7 currently does not build any C extensions. This means that IOCP reactor is not currently built and none of the IOCP tests are run in Appveyor. I'm not sure offhand what the fix is, but I notice that quite a few Python projects import this script from Olivier Gris

Re: [Twisted-Python] Windows buildbots and Appveyor

2016-07-20 Thread Craig Rodrigues
On Wed, Jul 20, 2016 at 6:25 PM, Oliver Palmer wrote: > If you or someone else ends up working on this I can attest that his setup > works well and will build C-extensions. I've been using his script > extensively on pywincffi for Python 2.6+ and Python 3.3+ so far without > issues. For referen

Re: [Twisted-Python] Request for help with Twisted bindings in M2Crypto

2016-07-25 Thread Craig Rodrigues
On Mon, Jul 25, 2016 at 2:03 AM, Matěj Cepl wrote: > Hello, > > Would somebody raise up their hand to help me and help Twisted? > > Hi, Earlier this year, I contributed lots of patches to you in M2Crypto to port it to py3k. Now I have shifted efforts to Twisted, where in the past month I have co

Re: [Twisted-Python] Request for help with Twisted bindings in M2Crypto

2016-07-25 Thread Craig Rodrigues
On Mon, Jul 25, 2016 at 2:03 AM, Matěj Cepl wrote: > > 2) Even more pressing is that the Twisted module breaks my tests when > porting to py3k (https://travis-ci.org/mcepl/M2Crypto/jobs/146633964). > Given the opaque and complicated data types in Twisted, I see horribly > complicated task of divi

[Twisted-Python] Fixes for Twisted bindings in M2Crypto

2016-07-26 Thread Craig Rodrigues
On Tue, Jul 26, 2016 at 8:47 AM, Matěj Cepl wrote: > > I believe I have fixed all I can do without actually understanding Twisted > in > https://gitlab.com/mcepl/m2crypto/commit/6cd5f87b31e50016ebb7e44f3f2ae46610bc24e0. > So now, if Twisted is so transparent and perfectly understandable, could >

Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.dist renamed to twisted.python._setup

2016-08-07 Thread Craig Rodrigues
On Sun, Aug 7, 2016 at 4:15 PM, Glyph Lefkowitz wrote: > > On Aug 7, 2016, at 4:19 AM, Adi Roiban wrote: > > Hi, > > I would like to remove twisted.python.dist as a public API without > following the 1 year deprecation processes. > > The module has a comment which informs people not to use it ou

Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.dist renamed to twisted.python._setup

2016-08-07 Thread Craig Rodrigues
On Sun, Aug 7, 2016 at 5:25 PM, Amber "Hawkie" Brown < hawk...@atleastfornow.net> wrote: > > On 8 Aug 2016, at 08:15, Craig Rodrigues wrote: > > > > On Sun, Aug 7, 2016 at 4:15 PM, Glyph Lefkowitz > wrote: > >> >> On Aug 7, 2016, at 4:19 AM

Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.dist renamed to twisted.python._setup

2016-08-07 Thread Craig Rodrigues
On Sun, Aug 7, 2016 at 11:01 PM, Glyph Lefkowitz wrote: > > This is also addressing a real problem. One of the *major* issues with > Twisted is *documentation noise*. Developers trying to use Twisted to > build things frequently complain about this: they look for an API to do > XYZ, and they se

Re: [Twisted-Python] More tests running on Python 3

2016-08-11 Thread Craig Rodrigues
9647 (skips=2008, successes=7639) -- Craig On Thu, Jun 30, 2016 at 3:43 PM, Craig Rodrigues > wrote: > Hi, > > I looked at these two Travis builds on Linux > > DATE BUILD > = > June 3, 2016https://travis-ci.org/twisted/twisted/bu

[Twisted-Python] Please fix the broken buildbots

2016-08-22 Thread Craig Rodrigues
Hi, Someone has made changes in the past few days which have broken many of the buildbots. For example, in this build: https://buildbot.twistedmatrix.com/builders/debian8-py2.7/builds/1548/steps/select/logs/stdio There is this: python -m tox -r -e py27-tests "" in dir /buildslave/debian8-py2.7

Re: [Twisted-Python] Please fix the broken buildbots

2016-08-22 Thread Craig Rodrigues
On Monday, August 22, 2016, Glyph Lefkowitz wrote: > > On Aug 22, 2016, at 5:40 PM, Craig Rodrigues > wrote: > > Hi, > > Someone has made changes in the past few days which have broken > many of the buildbots. For example, in this build: > > https://buildbot.twis

[Twisted-Python] Tests on Windows with Python 3 now passing

2016-08-22 Thread Craig Rodrigues
I have fixed the tests that were failing on Windows with Python 3. If you look at: https://ci.appveyor.com/project/adiroiban/twisted/build/trunk-1008 We now have builds running on Python 3.3, 3.4, and 3.5 on Windows. These builds are also uploading coverage results to codecov.io. I looked at tha

Re: [Twisted-Python] More tests running on Python 3

2016-11-14 Thread Craig Rodrigues
, Aug 11, 2016 at 5:42 AM, Craig Rodrigues wrote: > I looked at latest Travis builds on Linux: > > DATE BUILD > = > August 11, 2016 https://travis-ci.org/twisted/twisted/jobs/151440581 > > > Tests on Python 2.7 &

Re: [Twisted-Python] twisted on Windows with python 3.5?

2016-11-16 Thread Craig Rodrigues
Hi, Over the past 4-5 months or so, I have been doing some major heavy lifting to port large parts of Twisted to Python 3. One of the biggest hurdles I overcame was to port the Twisted IOCP reactor to Python 3. I got that to work. So, I think things are in good shape. However, getting feedback

[Twisted-Python] conch problem with ecdsa-sha2-nistp256 host key?

2016-12-01 Thread Craig Rodrigues
Hi, I filed this bug: https://twistedmatrix.com/trac/ticket/8931 At least for me, conch fails to parse a host key created by OpenSSH in ~/.ssh/known_hosts which is of type ecdsa-sha2-nistp256. Anyone have an idea as to how to fix this? -- Craig ___ Tw

Re: [Twisted-Python] conch problem with ecdsa-sha2-nistp256 host key?

2016-12-01 Thread Craig Rodrigues
r/030819.html > > On Fri, Dec 2, 2016 at 9:11 AM, Craig Rodrigues > wrote: > > Hi, > > > > I filed this bug: > > https://twistedmatrix.com/trac/ticket/8931 > > > > At least for me, conch fails to parse a host key created by OpenSSH > > in

Re: [Twisted-Python] conch problem with ecdsa-sha2-nistp256 host key?

2016-12-02 Thread Craig Rodrigues
On Fri, Dec 2, 2016 at 1:23 AM, Glyph Lefkowitz wrote: > > > Investigating further, I think I've figured it out. Here's a patch that > fixes the problem: > > diff --git a/src/twisted/conch/ssh/keys.py b/src/twisted/conch/ssh/keys.py > index d47db7f..570f524 100644 > --- a/src/twisted/conch/ssh/k

Re: [Twisted-Python] conch problem with ecdsa-sha2-nistp256 host key?

2016-12-02 Thread Craig Rodrigues
On Fri, Dec 2, 2016 at 9:18 AM, Craig Rodrigues wrote: > > Traceback (most recent call last): > > > File "", line 1, in > File "/Users/crodrigues/twisted8/src/twisted/conch/ssh/keys.py", line > 787, in __repr__ > self._keyObject.key_size)]

Re: [Twisted-Python] conch problem with ecdsa-sha2-nistp256 host key?

2016-12-02 Thread Craig Rodrigues
Glyph, I took your fix, and added some fixes of my own for __repr__() printing of EC keys in this branch: https://github.com/twisted/twisted/pull/615 If I run the tests, I get a new failure: trial twisted.conch.test.test_keys.KeyTests.test_fromBlobECDSA Traceback (most recent call last): F

Re: [Twisted-Python] conch problem with ecdsa-sha2-nistp256 host key?

2016-12-03 Thread Craig Rodrigues
On Thu, Dec 1, 2016 at 7:01 PM, Mark Williams wrote: > > I bet the key negotiated by conch is not an ECDSA key but rather an > RSA key. If this is all the case, then I think you've found a key > that LibreSSL supports but your client's libssl (which conch calls > into via cryptography) does not.

Re: [Twisted-Python] conch problem with ecdsa-sha2-nistp256 host key?

2016-12-20 Thread Craig Rodrigues
On Friday, December 2, 2016, Glyph Lefkowitz wrote: > > I think there might be a regression in 16.6.0. > > For every version up to 16.6.0, I can do 'conch twistedmatrix.com' in a > shell and it works fine. > I believe that I have fixed this in trunk. Can you try this with conch in trunk? This wo

Re: [Twisted-Python] conch problem with ecdsa-sha2-nistp256 host key?

2016-12-20 Thread Craig Rodrigues
this point? > > -glyph > > On Dec 20, 2016, at 2:32 PM, Craig Rodrigues > wrote: > > On Friday, December 2, 2016, Glyph Lefkowitz > wrote: >> >> I think there might be a regression in 16.6.0. >> >> For every version up to 16.6.0, I can do 'co

Re: [Twisted-Python] conch problem with ecdsa-sha2-nistp256 host key?

2016-12-20 Thread Craig Rodrigues
s using an RSA host key though. It seems that the hosts I have >> using ECDSA keys (buildbot.twistedmatrix.com, for example) still don't >> work with conch. Is that expected at this point? >> >> -glyph >> >> On Dec 20, 2016, at 2:32 PM, Craig Rodrigues >&

Re: [Twisted-Python] conch problem with ecdsa-sha2-nistp256 host key?

2016-12-20 Thread Craig Rodrigues
On Tue, Dec 20, 2016 at 6:24 PM, Glyph Lefkowitz wrote: > > > > So... is this because buildbot.twistedmatrix.com has an RSA key as well, > and when it offers it, our checking isn't correctly comparing the type > before deciding that it doesn't match, or allowing for multiple keys? I > notice th

Re: [Twisted-Python] conch problem with ecdsa-sha2-nistp256 host key?

2016-12-20 Thread Craig Rodrigues
On Tue, Dec 20, 2016 at 7:32 PM, Craig Rodrigues wrote: > On Tue, Dec 20, 2016 at 6:24 PM, Glyph Lefkowitz > wrote: > >> >> > >> >> So... is this because buildbot.twistedmatrix.com has an RSA key as well, >> and when it offers it, our checking is

Re: [Twisted-Python] conch problem with ecdsa-sha2-nistp256 host key?

2016-12-21 Thread Craig Rodrigues
On Wed, Dec 21, 2016 at 4:46 PM, Glyph Lefkowitz wrote: > > > Can you file a new ticket for each of these? The ordering thing seems > super low priority, but not being able to receive multiple host keys is > definitely a spec violation. > > Thanks for figuring it out, > > Can you try these two p

Re: [Twisted-Python] hmac-sha2-512 - Corrupted MAC on input with OpenSSH

2016-12-28 Thread Craig Rodrigues
Jianchen, Can you provide more details about the server you are writing? I cannot reproduce your problem with the latest Twisted code in trunk. Here is what I did: git clone https://github.com/twisted/twisted twisted-test cd twisted-test python setup.py develop cd docs/conch/examples mkdir ssh

Re: [Twisted-Python] hmac-sha2-512 - Corrupted MAC on input with OpenSSH

2016-12-28 Thread Craig Rodrigues
Hi, Is this what you are saying: Twisted Server + OpenSSH client == WORKS Twisted Server + Xshell client == WORKS OpenSSH Server + SecureCRT client == WORKS Twisted Server + SecureCRT client == FAIL ?? I don't have SecureCRT client, so don't know the solution to this problem. You might want to

Re: [Twisted-Python] hmac-sha2-512 - Corrupted MAC on input with OpenSSH

2016-12-29 Thread Craig Rodrigues
lgorithms well, right ? > > -- > > JianChen > > > At 2016-12-29 16:06:55, "Craig Rodrigues" wrote: > > Abhishek Choudhary pointed out to me that you can reproduce this problem > easily, even with OpenSSH client. > Look at https://twistedmatrix.com/trac/ti

Re: [Twisted-Python] conch problem with ecdsa-sha2-nistp256 host key?

2017-01-21 Thread Craig Rodrigues
On Fri, Jan 20, 2017 at 10:21 PM, Glyph Lefkowitz wrote: > > > I finally got around to trying this, and was baffled as to why the > behavior wasn't different between trunk and trunk-with-merged-PRs; then I > realized the commits from both were already in trunk :-). Seems to work > great now vs.

[Twisted-Python] Problems with inlineCallback, Deferred, yield and Python 3 in buildbot

2017-01-21 Thread Craig Rodrigues
Hi, I have been submitting many patches to get buildbot working on Python 3: http://bit.ly/2jCCMPW I have run into one problem involving inlineCallback, Deferred, and yield which I am having difficulty solving. Can someone help me? If I do the following inside a Python 3 virtualenv to set thin

Re: [Twisted-Python] Problems with inlineCallback, Deferred, yield and Python 3 in buildbot

2017-01-23 Thread Craig Rodrigues
On Sat, Jan 21, 2017 at 8:06 PM, Glyph Lefkowitz wrote: > > On Jan 21, 2017, at 6:15 PM, Craig Rodrigues > wrote: > > If I run the test on Python 2, I don't get the error, and on line 93, > brdicts is a dict. > However, if I run the test on Python 3, brdicts is a

Re: [Twisted-Python] Problems with inlineCallback, Deferred, yield and Python 3 in buildbot

2017-01-24 Thread Craig Rodrigues
On Mon, Jan 23, 2017 at 5:10 PM, Jean-Paul Calderone < exar...@twistedmatrix.com> wrote: > On Mon, Jan 23, 2017 at 7:08 PM, Craig Rodrigues > wrote: > >> >> >> >> I did some more debugging. The callstack is quite deep. :/ >> I used t

Re: [Twisted-Python] Problems with inlineCallback, Deferred, yield and Python 3 in buildbot

2017-01-26 Thread Craig Rodrigues
On Tue, Jan 24, 2017 at 12:48 PM, Craig Rodrigues wrote: > > > On Mon, Jan 23, 2017 at 5:10 PM, Jean-Paul Calderone < > exar...@twistedmatrix.com> wrote: > >> On Mon, Jan 23, 2017 at 7:08 PM, Craig Rodrigues >> wrote: >> >>> >>> >&g

Re: [Twisted-Python] Problems with inlineCallback, Deferred, yield and Python 3 in buildbot

2017-01-26 Thread Craig Rodrigues
On Wed, Jan 25, 2017 at 10:06 AM, Phil Mayers wrote: > > Related, see: > > http://stackoverflow.com/questions/32139885/yield-in-list- > comprehensions-and-generator-expressions > > http://bugs.python.org/issue10544 > > Basically, don't use yield inside comprehensions if you don't want > weirdness

[Twisted-Python] Can't create ticket in Trac

2017-01-27 Thread Craig Rodrigues
Hi, I can't seem to create a ticket in Trac. Can someone look? -- Craig ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] Can't create ticket in Trac

2017-01-27 Thread Craig Rodrigues
On Fri, Jan 27, 2017 at 2:29 PM, Glyph Lefkowitz wrote: > > On Jan 27, 2017, at 2:03 PM, Craig Rodrigues > wrote: > > Hi, > > I can't seem to create a ticket in Trac. Can someone look? > > I can create tickets. What behavior do you see? > > After enteri

Re: [Twisted-Python] "twistd" in Twisted 16.4.0 can't import modules/packages from current working directory

2017-02-12 Thread Craig Rodrigues
On Tue, Feb 7, 2017 at 11:29 AM, Glyph Lefkowitz wrote: > > On Feb 7, 2017, at 6:59 AM, Jean-Paul Calderone > wrote: > > On Fri, Jan 13, 2017 at 1:13 AM, Glyph Lefkowitz > wrote: > >> Thanks for highlighting those. I've put the link in the other direction >> as well. >> >> > Craig seems eager

Re: [Twisted-Python] Removing support for old Python 3 versions

2017-02-20 Thread Craig Rodrigues
On Mon, Feb 20, 2017 at 1:46 PM, Amber Brown wrote: > > With this rationale, I propose that the next version of Twisted (most > likely 17.3) will be the last to support Python 3.3. The question of Python > 3.4 support is something that will need further discussion (where 3.3 just > plain has the

Re: [Twisted-Python] non-merge commits to trunk & "review" keyword

2017-03-07 Thread Craig Rodrigues
On Mon, Mar 6, 2017 at 8:37 PM, Glyph Lefkowitz wrote: > > > Craig, since you're the one who made this merge, can you explain what > happened? Has github's 'merge' button stopped prompting for a commit > message? Failing to wait for the removal of the 'review' keyword was > obviously a mistake,

Re: [Twisted-Python] Minor fixes in the “Customizing twistd logging” section

2017-03-13 Thread Craig Rodrigues
On Mon, Mar 13, 2017 at 12:58 PM, Роман Мещеряков < romanmescherya...@yandex.ru> wrote: > > > Exception occurred: > File "conf.py", line 45, in > from twisted import version as twisted_version_object > ImportError: No module named twisted > > Looks like Twisted needs to be installed in orde

[Twisted-Python] Problem with "dev" version number generated by incremental

2017-03-13 Thread Craig Rodrigues
Hi, I tried to use a "dev" version of Twisted, and ran into some problems with the version number generated by incremental: https://github.com/hawkowl/incremental/issues/29 -- Craig ___ Twisted-Python mailing list Twisted-Python@twistedmatrix.com http:

[Twisted-Python] Minor fixes in the “Customizing twistd logging” section

2017-03-16 Thread Craig Rodrigues
On Thursday, March 16, 2017, Роман Мещеряков > wrote: > > OK, got it. > > Back to the subject of this e-mail, I created ticket #9084 > and attached proposed fix to > it. Of course, there are many newbie questions related to that: > >1. Did I filled

Re: [Twisted-Python] Regarding the SHA 512 support in twisted.

2017-03-27 Thread Craig Rodrigues
On Mon, Mar 27, 2017 at 2:33 AM, jabir Mohammed (jamohamm) < jamoh...@cisco.com> wrote: > > Can somebody help me to plot this fix so that twisted will work fine with > all the other servers out there and even make it comply to the RFC. Thanks > in advance and this will be my first findings on twis

[Twisted-Python] Twisted and Flask or Django

2017-04-15 Thread Craig Rodrigues
Hi, Moshe Zadka recently gave a very good presentation on using Twisted as a WSGI container for Django or Flask apps at the San Francisco Django Meetup: https://rawgit.com/moshez/talks/master/twist-wsgi/twist-wsgi.html The examples in this presentation should be cleaned up and maybe put on the f

Re: [Twisted-Python] Twisted and Flask or Django

2017-04-18 Thread Craig Rodrigues
On Mon, Apr 17, 2017 at 2:10 AM, Hynek Schlawack wrote: > > I have to disagree here BTW. When I started using Twisted as a WSGI > container, I was vexed by its lack of docs (and I’m still confused about > many details). There’s a few blog posts around but none of them reach the > straight-forwa

[Twisted-Python] Buildbot and Python 3

2017-05-12 Thread Craig Rodrigues
Hi, I've shifted efforts to port buildbot to Python 3. In March, we reached a milestone where all of buildbot's unit tests passed on Python 3: https://medium.com/buildbot/buildbot-0-9-5-is-out-1d83626bd95a This effort was possible due to large parts of Twisted (especially Perspective Broker) no

[Twisted-Python] Follow on release to Twisted 17.5.0

2017-06-14 Thread Craig Rodrigues
Hi, Can you do a follow-on release to 17.5.0 which incorporates https://github.com/twisted/twisted/pull/816 Without that fix, e-mail notifications from buildbot are broken in buildbot's master branch. With that fix, e-mail notifications from buildbot now work on Python 2 and Python 3. Thanks. -

Re: [Twisted-Python] Follow on release to Twisted 17.5.0

2017-06-14 Thread Craig Rodrigues
Yes, without this fix it is broken on python 2 also. -- Craig On Wed, Jun 14, 2017 at 2:04 AM, Pierre Tardy wrote: > Oh. they are broken for python2 as well? > > That's would be pretty bad. > > > On Wed, Jun 14, 2017 at 10:36 AM Craig Rodrigues > wrote: > >&g

Re: [Twisted-Python] Notice of future removal of Python 3.3 and 3.4 support in Twisted

2017-06-15 Thread Craig Rodrigues
On Thu, Jun 15, 2017 at 3:33 AM, Amber Hawkie Brown < hawk...@atleastfornow.net> wrote: > > > Our policy says "buildbot builder" explicitly as the basis for support. > Plus, Travis is some Pythons yolo'd onto a random Ubuntu for the purposes > of smoke testing for people without access to our full

Re: [Twisted-Python] lineCallbacks failure message difference between python2 and 3

2017-06-20 Thread Craig Rodrigues
On Tuesday, June 20, 2017, aaron eagerman wrote: > > Is there any way (aside from adding logging at each level to > internet/defer.py:_inlineCallbacks) to get a better error message in py3? > Aaron, Pierre Tardy submitted this patch for precisely the problem you described: https://github.com

[Twisted-Python] How to set up Twisted buildbot VM?

2017-06-22 Thread Craig Rodrigues
Hi, I tried to set up a VM to test changes to Twisted's buildbot. I did this: git clone https://github.com/twisted-infra/braid cd braid vagrant up fab config.vagrant fab config.vagrant base.bootstrap fab config.vagrant buildbot.install I got some errors at this point (see attached log). Any

Re: [Twisted-Python] Twisted ( 17.1.0 ) exception

2017-06-25 Thread Craig Rodrigues
On Sunday, June 25, 2017, Jacky Chuang (莊冠世) wrote: > > File "d:\jacky\buildbot_virtualenv\ > buildbot\lib\site-packages\twisted\internet\_dumbwin32proc.py", line 214, > in doCreate > > command, cmdline, None, None, 1, flags, env, path, > StartupInfo) > >

Re: [Twisted-Python] How to set up Twisted buildbot VM?

2017-06-26 Thread Craig Rodrigues
:44 AM, Craig Rodrigues wrote: > Hi, > > I tried to set up a VM to test changes to Twisted's buildbot. > > I did this: > > > git clone https://github.com/twisted-infra/braid > cd braid > vagrant up > fab config.vagrant > fab config.vagrant base.bootst

Re: [Twisted-Python] buildbot/osx10.10-py2.7 and required builders for merge

2017-07-05 Thread Craig Rodrigues
On Wed, Jul 5, 2017 at 2:29 AM, Adi Roiban wrote: > > Why the OSX build was removed from Travis and forced on buildbot? > > At the time that Glyph did this, the OSX builders on Travis were overloaded from all projects (not just Twisted) and took a long time to run. This slowed down the whole CI

[Twisted-Python] Newer Pypy on buildbot?

2017-07-05 Thread Craig Rodrigues
Hi, This builder: https://buildbot.twistedmatrix.com/builders/ubuntu16.04-pypy5/builds/86/steps/select/logs/stdio seems to now be failing with: cryptography 1.9 is not compatible with PyPy < 5.3. Please upgrade PyPy to use this library. Can someone upgrade pypy on this builder? Thanks. -- Crai

Re: [Twisted-Python] Failure of twisted.test.test_plugin.DeveloperSetupTests.test_freshPyReplacesStalePyc under pypy2

2017-07-12 Thread Craig Rodrigues
On Wed, Jul 12, 2017 at 3:36 PM, Daniel Sutcliffe wrote: > > Am I correct in the fact that Twisted doesn't have Travis-CI builds on > PyPy? > There are two builders which do PyPy: https://buildbot.twistedmatrix.com/builders/ubuntu16.04-pypy5 https://buildbot.twistedmatrix.com/builders/ubuntu16.

  1   2   3   >