Re: [Twisted-Python] "Cleared to Land"?

On Sat, 7 Jul 2018 at 22:45, Glyph wrote: > > > > On Jul 7, 2018, at 12:36 PM, Tom Most wrote: > [snip] > Thanks for driving this to completion, Tom! Much appreciated. > > For future reference though, when landing stuff on trunk, please use this > format exactly: > > https://twistedmatrix.com

Re: [Twisted-Python] "Cleared to Land"?

> On Jul 8, 2018, at 7:44 AM, Adi Roiban wrote: > > On Sat, 7 Jul 2018 at 22:45, Glyph wrote: >> >> >> >> On Jul 7, 2018, at 12:36 PM, Tom Most wrote: >> > > [snip] > >> Thanks for driving this to completion, Tom! Much appreciated. >> >> For future reference though, when landing stuff

Re: [Twisted-Python] "Cleared to Land"?

On Sun, Jul 8, 2018, at 12:06 PM, Glyph wrote: >> On Jul 8, 2018, at 7:44 AM, Adi Roiban wrote: >> >> On Sat, 7 Jul 2018 at 22:45, Glyph wrote: >>> On Jul 7, 2018, at 12:36 PM, Tom Most wrote: >> >> [snip] >> >>> Thanks for driving this to completion, Tom! Much appreciated. >>> >>> For futu

Re: [Twisted-Python] "Cleared to Land"?

On Sun, Jul 8, 2018, at 6:21 PM, Tom Most wrote: > The GitHub UI currently requires this for non-admins, though it can be > bypassed with a manual merge, much like the requirement for a green > build. As a new committer I haven't felt comfortable doing that > bypass, so I spend a lot of time mergin

Re: [Twisted-Python] "Cleared to Land"?

> On Jul 8, 2018, at 6:21 PM, Tom Most wrote: > > On Sun, Jul 8, 2018, at 12:06 PM, Glyph wrote: >>> On Jul 8, 2018, at 7:44 AM, Adi Roiban >> > wrote: >>> >>> On Sat, 7 Jul 2018 at 22:45, Glyph >> > wrote: On Jul 7, 2018, at 12:36 PM