On Sun, Jul 8, 2018, at 6:21 PM, Tom Most wrote: > The GitHub UI currently requires this for non-admins, though it can be > bypassed with a manual merge, much like the requirement for a green > build. As a new committer I haven't felt comfortable doing that > bypass, so I spend a lot of time merging forward and kicking builds to > get a green check mark. Should I be bothering? Particularly for > documentation changes[1]. I'd rather spend that time on work product > than process. Please disregard this. I tried it on #1037[2] but branch protection still applies: $ git push origin trunk Counting objects: 6, done. Delta compression using up to 4 threads. Compressing objects: 100% (5/5), done. Writing objects: 100% (6/6), 610 bytes | 0 bytes/s, done. Total 6 (delta 4), reused 0 (delta 0) remote: Resolving deltas: 100% (4/4), completed with 4 local objects. remote: error: GH006: Protected branch update failed for refs/heads/trunk.remote: error: 3 of 3 required status checks are expected. To g...@github.com:twisted/twisted.git ! [remote rejected] trunk -> trunk (protected branch hook declined) error: failed to push some refs to 'g...@github.com:twisted/twisted.git' ---Tom
Links: 1. https://github.com/twisted/twisted/pull/1037 2. https://github.com/twisted/twisted/pull/1037
_______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
