Re: [Twisted-Python] Defining the review workflow on top of GitHub PR

2017-10-01 Thread Glyph
> On Oct 1, 2017, at 12:06 PM, Craig Rodrigues wrote: > > Rather than write a bot specific to Twisted, why not just adapt the Twisted > project to use a bot written by another project? Personally I don't care either way :-). I was just describing my understanding of the existing plan, not end

Re: [Twisted-Python] Defining the review workflow on top of GitHub PR

2017-10-01 Thread Craig Rodrigues
On Sat, Sep 30, 2017 at 3:14 PM, Adi Roiban wrote: > > > orking on a bot to re-open pull requests when a submitter posts a "please > review" comment: https://github.com/markrwilliams/txghbot Rather than write a bot specific to Twisted, why not just adapt the Twisted project to use a bot writte

Re: [Twisted-Python] Migrating Trac Tickets to GitHub issues

2017-10-01 Thread Glyph
> On Sep 30, 2017, at 2:15 PM, Adi Roiban wrote: > > Hi, > > I would like to re-start the conversation about migrating Trac tickets > to GitHub issues. > > My main reason for doing this is to make it easier for people to > contribute to Twisted. > > In CONTRIBUTING there is this info > > `G

Re: [Twisted-Python] Migrating Trac Tickets to GitHub issues

2017-10-01 Thread Glyph
> On Sep 30, 2017, at 5:30 PM, Craig Rodrigues wrote: > > I think migrating Twisted issues from Trac to GitHub is a good idea, > and will make it easier for people to interact with the project. To be clear, because I am grumpy about a lot of specifics with respect to GH issues: I agree with thi

Re: [Twisted-Python] Migrating Trac Tickets to GitHub issues

2017-10-01 Thread Glyph
> On Oct 1, 2017, at 9:31 AM, Craig Rodrigues wrote: > > > > On Sun, Oct 1, 2017 at 3:30 AM, Amber Brown > wrote: > > > Currently, GitHub Issues don't allow for non-committers to make modifications > to categories, milestones, edit the original ticket des

Re: [Twisted-Python] Defining the review workflow on top of GitHub PR

2017-10-01 Thread Glyph
> On Sep 30, 2017, at 3:14 PM, Adi Roiban wrote: > > I am restarting this discussion > https://twistedmatrix.com/pipermail/twisted-python/2016-May/030333.html > > I am starting a new thread since I want to keep the focus on the > review process / workflow / markers, and not on the things requi

Re: [Twisted-Python] Migrating Trac Tickets to GitHub issues

2017-10-01 Thread Craig Rodrigues
On Sun, Oct 1, 2017 at 3:30 AM, Amber Brown wrote: > > > Currently, GitHub Issues don't allow for non-committers to make > modifications to categories, milestones, edit the original ticket > description, or close tickets. This kinda sucks, because it makes the pool > of triagers smaller, and also

Re: [Twisted-Python] Migrating Trac Tickets to GitHub issues

2017-10-01 Thread Amber Brown
> On 1 Oct 2017, at 8:15 am, Adi Roiban wrote: > > Hi, > > I would like to re-start the conversation about migrating Trac tickets > to GitHub issues. > > My main reason for doing this is to make it easier for people to > contribute to Twisted. > > In CONTRIBUTING there is this info > > `GitH