[trojita] Addressbook interface for qt plugins

2013-06-20 Thread Thomas Lübking
Am Donnerstag, 20. Juni 2013 schrieb Jan Kundrát : > Now I'm confused -- your mail suggests to omit the destructor altogether, and at the same time you quote a document saying that one should always include it. I agree with the quoted document :). The important part here is that there /is/ a virt

Re: [trojita] Addressbook interface for qt plugins

2013-06-20 Thread Pali Rohár
On Wednesday 19 June 2013 12:15:30 Kevin Krammer wrote: > Hi, > > On Wednesday, 2013-06-19, Pali Rohár wrote: > > Hello, > > > > here is new version of interface. I added static function > > formatAddress from > > src/AbookAddressbook/AbookAddressbook.cpp as suggested > > Kevin, removed const fro

Re: [trojita] Addressbook interface for qt plugins

2013-06-19 Thread Kevin Krammer
Hi, On Wednesday, 2013-06-19, Pali Rohár wrote: > Hello, > > here is new version of interface. I added static function formatAddress > from src/AbookAddressbook/AbookAddressbook.cpp as suggested Kevin, removed > const from slot methods and complete() and prettyNamesForAddress() are now > async (wh

Re: [trojita] Addressbook interface for qt plugins

2013-06-19 Thread Pali Rohár
Hello, here is new version of interface. I added static function formatAddress from src/AbookAddressbook/AbookAddressbook.cpp as suggested Kevin, removed const from slot methods and complete() and prettyNamesForAddress() are now async (when done emitting signals). Because qt plugin interface c

Re: [trojita] Addressbook interface for qt plugins

2013-06-18 Thread Kevin Krammer
General observation first: this is a synchronous interface. KDE's data access API for example is asynchronous, so in order to make this truely synchronous you will have to create a secondard thread that works with the asynchronous API and block the calling thread until the secondary thread has

[trojita] Addressbook interface for qt plugins

2013-06-18 Thread Pali Rohár
Hello, I'm sending first version of qt plugin interface for Addressbook. I reused src/Gui/AbstractAddressbook.h and I think that Trojita GUI only needs additional functions for opening addressbook manager (now called from menu: IMAP --> Address Book) and function for opening add/edit window fo