On Wednesday 19 June 2013 12:15:30 Kevin Krammer wrote: > Hi, > > On Wednesday, 2013-06-19, Pali Rohár wrote: > > Hello, > > > > here is new version of interface. I added static function > > formatAddress from > > src/AbookAddressbook/AbookAddressbook.cpp as suggested > > Kevin, removed const from slot methods and complete() and > > prettyNamesForAddress() are now async (when done emitting > > signals). Because qt plugin interface can have only pure > > virtual functions (and no signal/slots) I added factory > > class which will be qt plugin interface. > > That definitely looks a lot better! > > One thing that might be interesting, depending on how the rest > of the code in Trojita dealing with that interface looks > like, is a "job" interface for the completion task (or for > both asynchronous tasks). > > I.e. like QNetworkAccessManager operations, which return a job > object that reports when its finished but also reports data > as it comes in, allows the operation to be cancelled, etc. > > Cheers, > Kevin
Jan, can you comment above? What do you think? -- Pali Rohár pali.ro...@gmail.com
signature.asc
Description: This is a digitally signed message part.
