Re: [trojita] Re: GSoC: comments as of pali-gsoc@v0.3.93-325-g23bc463

2013-08-10 Thread Pali Rohár
On Saturday 10 August 2013 20:25:44 Jan Kundrát wrote: > On Saturday, 10 August 2013 20:16:07 CEST, Pali Rohár wrote: > > Is /plugins/ subdir needed? Is there something other planned > > in lib/trojita? Also Kontact using plugins from > > $PREFIX/lib/kde4/ > > There are two options: > > a) the co

[trojita] Re: GSoC: comments as of pali-gsoc@v0.3.93-325-g23bc463

2013-08-10 Thread Jan Kundrát
On Saturday, 10 August 2013 19:00:34 CEST, Pali Rohár wrote: What about to have two options OFF and AUTO? And write status if feature will be compiled or not (depending on find_package)? Kitware talks about something similar at [1]. I've tried to apply that and the result is available at [2].

[trojita] Re: GSoC: comments as of pali-gsoc@v0.3.93-325-g23bc463

2013-08-10 Thread Jan Kundrát
On Saturday, 10 August 2013 20:16:07 CEST, Pali Rohár wrote: Is /plugins/ subdir needed? Is there something other planned in lib/trojita? Also Kontact using plugins from $PREFIX/lib/kde4/ There are two options: a) the code loads *.so from $PLUGINDIR and $PLUGINDIR contains /trojita/plugins/ i

Re: [trojita] Re: GSoC: comments as of pali-gsoc@v0.3.93-325-g23bc463

2013-08-10 Thread Pali Rohár
On Saturday 10 August 2013 20:06:21 Jan Kundrát wrote: > On Saturday, 10 August 2013 18:44:02 CEST, Pali Rohár wrote: > > libexec? I think there should be executable files, not > > libraries. What about PREFIX/lib/trojita/? (lib instead > > libexec) > > Turns out you're right and even the FHS agre

[trojita] Re: GSoC: comments as of pali-gsoc@v0.3.93-325-g23bc463

2013-08-10 Thread Jan Kundrát
On Saturday, 10 August 2013 18:44:02 CEST, Pali Rohár wrote: libexec? I think there should be executable files, not libraries. What about PREFIX/lib/trojita/? (lib instead libexec) Turns out you're right and even the FHS agrees with you [1] :). So $PREFIX/lib/trojita/plugins be it. Cheers, J

[trojita] Re: GSoC: plugins & loader

2013-08-10 Thread Jan Kundrát
On Saturday, 10 August 2013 18:15:57 CEST, Pali Rohár wrote: I wanted to have trojita mail client as small as possible without too many dependencies & libraries. And this also drop support for static linked plugin(s) into trojita executable (because plugins will need one shared library). So it

Re: [trojita] GSoC: comments as of pali-gsoc@v0.3.93-325-g23bc463

2013-08-10 Thread Pali Rohár
On Saturday 10 August 2013 17:10:00 Jan Kundrát wrote: > Hi, a couple of comments: > > - The tests should be built by default. That's the whole point > of them -- whenever someone compiles Trojita (and > *especially* when someone makes any change), the tests must > be run. > OK. > - The build s

Re: [trojita] GSoC: comments as of pali-gsoc@v0.3.93-325-g23bc463

2013-08-10 Thread Pali Rohár
On Saturday 10 August 2013 17:10:00 Jan Kundrát wrote: > > - The plugin directory must not be something overly generic > like /usr/lib. Please use configure.cmake.in (you might have > to rebase on top of current master for that) and use > something like > "@CMAKE_INSTALL_PREFIX@/libexec/trojita" a

[trojita] Re: GSoC: plugins & loader

2013-08-10 Thread Thomas Lübking
On Samstag, 10. August 2013 18:15:57 CEST, Pali Rohár wrote: On Saturday 10 August 2013 17:48:27 Jan Kundrát wrote: On Saturday, 10 August 2013 17:13:28 CEST, Pali Rohár wrote: ... I wanted to have trojita mail client as small as possible without too many dependencies & libraries. ldd /usr/

[trojita] Re: GSoC: plugins & loader

2013-08-10 Thread Thomas Lübking
On Samstag, 10. August 2013 17:13:28 CEST, Pali Rohár wrote: I think this option is cleaner solution Having core and Plugins operating on a common interface via a common shared library is a clean dependency chain. Whatever you can bring against it, it's for sure not "dirty". I understood you

Re: [trojita] Re: GSoC: plugins & loader

2013-08-10 Thread Pali Rohár
On Saturday 10 August 2013 17:48:27 Jan Kundrát wrote: > On Saturday, 10 August 2013 17:13:28 CEST, Pali Rohár wrote: > > I think this option is cleaner solution as creating some new > > shared library only for exporting symbols to other shared > > plugin libraries... > > Have you read Thiago's re

[trojita] Re: GSoC: plugins & loader

2013-08-10 Thread Jan Kundrát
On Saturday, 10 August 2013 17:13:28 CEST, Pali Rohár wrote: I think this option is cleaner solution as creating some new shared library only for exporting symbols to other shared plugin libraries... Have you read Thiago's response [1] on the qt-interest ML? It seems that the recommended way

[trojita] Re: GSoC: plugins & loader

2013-08-10 Thread Pali Rohár
On Wednesday 17 July 2013 21:42:04 Pali Rohár wrote: > Hello, > > I found problem in current plugin loader & plugins and need > help how to solve it. > > My current code have common "interface" classes for password > and addressbook plugins. Because trojita working only with > pointers of these c

[trojita] GSoC: comments as of pali-gsoc@v0.3.93-325-g23bc463

2013-08-10 Thread Jan Kundrát
Hi, a couple of comments: - The tests should be built by default. That's the whole point of them -- whenever someone compiles Trojita (and *especially* when someone makes any change), the tests must be run. - The build should abort when someone attempts to build with KDE and Qt5 support at t

[trojita] Re: GSoC merge request

2013-08-10 Thread Jan Kundrát
On Wednesday, 7 August 2013 07:46:01 CEST, Pali Rohár wrote: TrojitaPlugin is Kontact plugin and it is not loaded when running standalone Trojita version. Problem with empty application name in kwallet widget is only with standalone version. When Trojita is loaded into Kontact, kwallet widget

Re: [trojita] Re: Another GSoC review

2013-08-10 Thread Pali Rohár
On Monday 05 August 2013 19:00:40 Jan Kundrát wrote: > >> - Why are you employing the singletton (anti)pattern within > >> the PluginLoader? What are the advantages of using it (i.e. > >> a global variable in disguise) over an ordinary member of > >> the MainWindow? > > > > Access to PluginLoader

[trojita] Re: Akonadi plugin

2013-08-10 Thread Pali Rohár
On Saturday 10 August 2013 12:27:02 Pali Rohár wrote: > On Monday 15 July 2013 14:56:55 you wrote: > > Hello, > > > > I wrote akonadi plugin for contacts. But plugin does not > > working on testing machine where is akonadi and nepomuk > > installed and running. Code is here: > > > > http://quickg

[trojita] Re: GSoC merge request

2013-08-10 Thread Jan Kundrát
On Friday, 9 August 2013 16:22:48 CEST, Thomas Lübking wrote: Finally and ultimately and why I tend to call "this some sort of abuse": I've seen such too often (not talking about trojita here, but in general) [snipped code example with forwarding because of the need to add arguments to that fu

[trojita] Re: Another GSoC review

2013-08-10 Thread Jan Kundrát
On Saturday, 10 August 2013 12:42:47 CEST, Pali Rohár wrote: In this case when plugin metadata will be stored separatly, it still does not solve problem when user uninstall (or remove or upgrading ...) plugin together with metadata file. So metadata content needs to be stored in trojita confi

Re: [trojita] Re: Another GSoC review

2013-08-10 Thread Kevin Krammer
On Saturday, 2013-08-10, Pali Rohár wrote: > On Friday 09 August 2013 10:03:10 Kevin Krammer wrote: > > Hmm, speaking of which: separate meta data could also help in the above > > case of plugin getting uninstalled between sessions. > > The program could always cache metadata of the use plugin user

Re: [trojita] Re: Another GSoC review

2013-08-10 Thread Pali Rohár
On Friday 09 August 2013 10:03:10 Kevin Krammer wrote: > On Thursday, 2013-08-08, Pali Rohár wrote: > > On Monday 05 August 2013 16:40:02 Jan Kundrát wrote: > > > - Why do you store the plugin's *description* in settings? I > > > understand the plugin ID, but not the human readable > > > descriptio

[trojita] Re: Akonadi plugin

2013-08-10 Thread Pali Rohár
On Monday 15 July 2013 14:56:55 you wrote: > Hello, > > I wrote akonadi plugin for contacts. But plugin does not working on testing > machine where is akonadi and nepomuk installed and running. Code is here: > > http://quickgit.kde.org/?p=clones/trojita/pali/trojita.git&a=commit&h=b44dd6 > cd553d

Re: [trojita] Re: Another GSoC review

2013-08-10 Thread Kevin Krammer
On Friday, 2013-08-09, Jan Kundrát wrote: > On Thursday, 8 August 2013 17:00:10 CEST, Pali Rohár wrote: > > As Kevin wrote, protection against emitting signals. > > Looking at the code, it seems to me that the only connections are to > ComposeWidget::completionDone which looks like a safe thing, e

Re: [trojita] Re: GSoC: plugins & loader

2013-08-10 Thread Pali Rohár
On Friday 09 August 2013 17:49:23 Jan Kundrát wrote: > On Thursday, 8 August 2013 10:04:10 CEST, Pali Rohár wrote: > > This means that all code which is needed by plugins must be > > moved into shared library. So then trojita will have one > > executable binary and one shared library. Both binaries

Re: [trojita] Re: GSoC: plugins & loader

2013-08-10 Thread Pali Rohár
On Friday 09 August 2013 21:34:08 Thomas Lübking wrote: > On Donnerstag, 8. August 2013 10:04:10 CEST, Pali Rohár wrote: > > On Wednesday 07 August 2013 15:07:39 Jan Kundrát wrote: > >> On Wednesday, 17 July 2013 21:42:04 CEST, Pali Rohár wrote: > >>> My current code have common "interface" classes