On Monday 05 August 2013 19:00:40 Jan Kundrát wrote:
> >> - Why are you employing the singletton (anti)pattern within
> >> the PluginLoader? What are the advantages of using it (i.e.
> >> a global variable in disguise) over an ordinary member of
> >> the MainWindow?
> > 
> > Access to PluginLoader is needed also from other classes,
> > not  only from MainWindow.
> 
> I'd prefer to have this access explicit -- i.e. the other
> places should be  provided with either a pointer to
> MainWindow or to the plugin loader itself. Hiding this into a
> singleton pattern is only making the whole thing less opaque.

Now I renamed PluginLoader to PluginManager, moved to Plugins 
namespace and converted from singleton to normal class. Code is 
in my pali-gsoc branch. So it is not singleton anymore.

-- 
Pali Rohár
pali.ro...@gmail.com

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to