[trojita] Re: GSoC: plugins & loader

2013-08-09 Thread Thomas Lübking
On Donnerstag, 8. August 2013 10:04:10 CEST, Pali Rohár wrote: On Wednesday 07 August 2013 15:07:39 Jan Kundrát wrote: On Wednesday, 17 July 2013 21:42:04 CEST, Pali Rohár wrote: My current code have common "interface" classes for password and addressbook plugins. Because trojita working only w

[trojita] Re: Another GSoC review

2013-08-09 Thread Jan Kundrát
On Thursday, 8 August 2013 17:00:10 CEST, Pali Rohár wrote: As Kevin wrote, protection against emitting signals. Looking at the code, it seems to me that the only connections are to ComposeWidget::completionDone which looks like a safe thing, even if it was called during stop() (is it?). Ja

[trojita] Re: Blogging about the GSoC

2013-08-09 Thread Jan Kundrát
On Thursday, 8 August 2013 11:24:35 CEST, Pali Rohár wrote: I'm not very happy with blogging. It always spend me really lot of time to write something. And I do not have any blog aggregated on planet.kde.org. It is really needed? Hi Pali, I dislike marketing as much as you do, but the sad thin

[trojita] Re: GSoC: plugins & loader

2013-08-09 Thread Jan Kundrát
On Thursday, 8 August 2013 10:04:10 CEST, Pali Rohár wrote: This means that all code which is needed by plugins must be moved into shared library. So then trojita will have one executable binary and one shared library. Both binaries will be needed to run trojita and trojita version without plug

[trojita] Re: GSoC merge request

2013-08-09 Thread Thomas Lübking
On Freitag, 9. August 2013 10:18:02 CEST, Jan Kundrát wrote: Qt5's QTimer contains a special case for QTimer::singleShot(0) (I suspect a lot of stuff would break if it was removed). s/a/the/ - and yes, probably removing the special case wasn't a good idea. I'd like to improve my Qt-fu, so I'm

[trojita] Re: GSoC merge request

2013-08-09 Thread Jan Kundrát
On Thursday, 8 August 2013 19:32:13 CEST, Thomas Lübking wrote: If you want to "skip the event loop" you should ask to "skip the event loop" and not hope "QTimer will skip the event loop" Notice that aside the pointless QTimer dependency, the default timer in Qt5 will be the coarse one, ie. if Q

Re: [trojita] Re: Another GSoC review

2013-08-09 Thread Kevin Krammer
On Thursday, 2013-08-08, Pali Rohár wrote: > On Monday 05 August 2013 16:40:02 Jan Kundrát wrote: > > - Why do you store the plugin's *description* in settings? I > > understand the plugin ID, but not the human readable > > description. Perhaps it's needed -- but if so, a comment > > saying that *