Janco,
True. This has been fixed already.
Thanks for the look. I put that in there to make sure someone
was actually looking at the code. (hehe. just kidding)
-casey
Janco Tanis wrote:
>
> I've a doubt with the code in TagHandlerPoolImpl.getHandler():
>
> // When the stack is empty, cre
I've a doubt with the code in TagHandlerPoolImpl.getHandler():
// When the stack is empty, create a new tag and return it
if (myHandlers.empty()) {
returnValue = (Tag) myHandlerClass.newInstance();
// Pushing it on the stack will cause the next getHandler to re
Thanks Casey!
This looks very promising. How long before you have a
patch for jasper available? I would like to do some
testing of your tag pooling on Jasper in Tomcat 4.0.
Regards,
Glenn
Casey Lucas wrote:
>
> > > Great!
> > >
> > > You will do before/after performance comparisons?
> >
> >
On Wed, 14 Mar 2001, Casey Lucas wrote:
> tag processing took avg of:
> pre tag pooling: 7362 milliseconds
> tag pooling patches (pooling enabled): 1586 milli
> tag pooling patches (pooling disabled): 6494 milli
>
> Yes, I know most pages don't have 1 tags and my
> tests are far from rigorou
> > Great!
> >
> > You will do before/after performance comparisons?
>
> In the process...
Ok, here are some basic numbers.
For simple performance testing I wrote a jsp that
uses an outer tag (BodyTag iteration style) and an
inner tag. I placed timings around the outer tag.
Based on 3.3 (nig
> Great!
>
> You will do before/after performance comparisons?
In the process...
>
> Have you tested your changes with Watchdog?
>
No, not yet. I'm still new to tomcat development but I'll
get familiar with watchdog.
> Which version of the Tomcat source are you working with?
3.3 with jdk
Great!
You will do before/after performance comparisons?
Have you tested your changes with Watchdog?
Which version of the Tomcat source are you working with?
Regards,
Glenn
Casey Lucas wrote:
>
> The attached files and diffs are based on 3.3 (hopefully latest code).
> They add tag pooling f
The attached files and diffs are based on 3.3 (hopefully latest code).
They add tag pooling for tomcat. I hope that some of you will have
time to take a look and provide feedback. I mainly tested with our
application that uses a lot of tags.
To disable pooling, don't include the TagPoolManager
