I've a doubt with the code in TagHandlerPoolImpl.getHandler():
// When the stack is empty, create a new tag and return it
if (myHandlers.empty()) {
returnValue = (Tag) myHandlerClass.newInstance();
// Pushing it on the stack will cause the next getHandler to return the same tag using
pop
// So I guess we need to remove the push over here...
myHandlers.push(returnValue);
} else {
returnValue = (Tag) myHandlers.pop();
}
--
janco
Casey Lucas wrote:
> The attached files and diffs are based on 3.3 (hopefully latest code).
> They add tag pooling for tomcat. I hope that some of you will have
> time to take a look and provide feedback. I mainly tested with our
> application that uses a lot of tags.
>
> To disable pooling, don't include the TagPoolManagerInterceptor
> interceptor. Jasper will still generate pooling code, but pooling
> won't be used at runtime.
>
> Summary of changes:
>
> 1. changed jasper to add tag pool support
>
> files changed:
> org.apache.jasper.compiler.
> JspParseEventListener.java
> TagBeginGenerator.java
> TagEndGenerator.java
>
> files added:
> org.apache.jasper.compiler.
> TagPoolManagerGenerator.java
> TagPoolGenerator.java
>
> 2. added tag pooling classes / interfaces
> files added:
> org.apache.jasper.runtime.
> TagHandlerPool.java
> TagHandlerPoolImpl.java
> TagPoolManager.java
> TagPoolManagerImpl.java
>
> -Casey
>
--
Janco Tanis
------------------------------------------------------------
COAS, Your partner in computer aided services
Nijverheidsweg 34 Tel: +31 (0) 187 49 3222
Postbus 44 Fax: +31 (0) 187 49 2912
3250 AA Stellendam Email: [EMAIL PROTECTED]
