Costin Manolache wrote:
Remy Maucherat wrote:
>>Can you point me to the code doing this extra processing ?
>>
>>I'm a bit confused:
>>- for jsps ( with flush-in-release ) that just can't work, since the
>>flush is already done by the jsp page.
>>- the comment ( or the message ) in forward is pr
I just tested - adding 'removeAttribute' in PageContextImpl after
the error page solves the problem.
The problem was pretty simple:
- exception happens
- jsp error page called and executed
- normal servlet exception handling is now processing the exception
- output is reset by the error handl
On a related note, i just discovered some behavior that may be a bug.
In my case, I have a request filter that buffers the output, so that I
can gzip it and time the internal time.
when a page hits an exception, it correctly forwards to my error page.
but what ends up happening is the buffer is
Remy Maucherat wrote:
>
>> Can you point me to the code doing this extra processing ?
>>
>> I'm a bit confused:
>> - for jsps ( with flush-in-release ) that just can't work, since the
>> flush is already done by the jsp page.
>> - the comment ( or the message ) in forward is probably wrong.
>> - m
Costin Manolache wrote:
Remy Maucherat wrote:
>>In any case, I expect this to have caused some weird behavior
>>for normal forward - since forward doesn't seem to really flush/close
>>as it was supposed to do ( unless response is not facade - does
>>this case ever happen ? ). A bit strange no o
Remy Maucherat wrote:
>> In any case, I expect this to have caused some weird behavior
>> for normal forward - since forward doesn't seem to really flush/close
>> as it was supposed to do ( unless response is not facade - does
>> this case ever happen ? ). A bit strange no other test detected that
Remy Maucherat wrote:
Costin Manolache wrote:
> I'm getting closer - Remy or Kin-Man, I need your help.
> As I expected, the flush() was hiding some other behaviors.
>
> Right now I'm looking at ApplicationDispatcher.doForward().
>
> What happens is:
> - error happens
> - we forward to the err
Costin Manolache wrote:
I'm getting closer - Remy or Kin-Man, I need your help.
As I expected, the flush() was hiding some other behaviors.
Right now I'm looking at ApplicationDispatcher.doForward().
What happens is:
- error happens
- we forward to the error page
- error page executes, put t
I'm getting closer - Remy or Kin-Man, I need your help.
As I expected, the flush() was hiding some other behaviors.
Right now I'm looking at ApplicationDispatcher.doForward().
What happens is:
- error happens
- we forward to the error page
- error page executes, put the data in the out buffer
I get more info on the issue. The error page worked before
because the forward() that was used to redirect to the
error page did commit the buffer.
Right now the control returns to the page with error, where
the buffer seems to be overriden.
I'm still debugging it - if I can't find any simple
Costin Manolache wrote:
I'll work on this ( I'm in the middle of something - as soon as I get
some time, this is on the top of my list ).
>>I reverted tc5 for my own convenience. I didn't revert tomcat_4_branch
>>becuase I thought that you may want hack more there. :-)
Yes, but if it brake
I'll work on this ( I'm in the middle of something - as soon as I get
some time, this is on the top of my list ).
>> I reverted tc5 for my own convenience. I didn't revert tomcat_4_branch
>> becuase I thought that you may want hack more there. :-)
Yes, but if it brakes something... I'll rev
Kin-Man Chung wrote:
>>costin,
>>
>>This fix seems to break errorPage handling in JSP, causing the errorPage
>>example to fail, and a couple of JSP watchdog tests too. I have
reverted
>>your fix.
>>
>>I have not reverted the tomcat_4_branch.
>
>If it breaks something - tomcat_4_branch should be
> X-Trace: main.gmane.org 1036447809 25208 64.84.39.162 (4 Nov 2002 22:10:09
GMT)
> Date: Mon, 04 Nov 2002 14:11:32 -0800
> From: Costin Manolache <[EMAIL PROTECTED]>
> Subject: Re: costin: fix reverted
> To: [EMAIL PROTECTED]
> X-Complaints-to: [EMAIL PROTECTED]
> NN
Kin-Man Chung wrote:
> costin,
>
> This fix seems to break errorPage handling in JSP, causing the errorPage
> example to fail, and a couple of JSP watchdog tests too. I have reverted
> your fix.
>
> I have not reverted the tomcat_4_branch.
If it breaks something - tomcat_4_branch should be the
15 matches
Mail list logo
