Kin-Man Chung wrote:
>>costin,Good, then we *have to* avoid flushing. (better performance from the client side - Coyote makes chunking almost free already, so no gain on the server -, plus we comply better with the spirit of the specification).
>>
>>This fix seems to break errorPage handling in JSP, causing the errorPage
>>example to fail, and a couple of JSP watchdog tests too. I have reverted
>>your fix.
>>
>>I have not reverted the tomcat_4_branch.
>
>If it breaks something - tomcat_4_branch should be the first to revert :-)
>
I reverted tc5 for my own convenience. I didn't revert tomcat_4_branch
becuase I thought that you may want hack more there. :-)
>I think the main question is if releasePageContext is required by the
>spec to flush() ( i.e. commit the message ) or not.
>
The spec is not specific about this. So it is up to the implementation. :-)
It seems like an unwanted Jasper limitation. We should fix it.
>If it is required - then Content-Length just can't be set by the container
>for jsps ( which is not the end of the world :-).
>
>If the spec doesn't require that ( and my reading is that releasePageContext
>doc doesn't in any way imply this as a side effect - the flush() is a very
>different API ) - then I would say the tests are wrong.
>
It's not that the tests are wrong, but that your 'fix' renders any JSP
error page not work at all. When an exception occurs, instead of displaying
the error page, it displays the stack trace of the exception! I don't have
anything against not calling flush() in release, but you'll also need to
make sure that it doesn't break this.
BTW, I agree with Costin, the patch should be reverted first from 4.1.x. As for 5.0.x, it is not in alpha yet on the ASF side, so it would seem more productive if the J2EE patch were selecting a previous version of the patch rather than just reverting it, as it will have to be applied anyway.
Remy
--
To unsubscribe, e-mail: <mailto:tomcat-dev-unsubscribe@;jakarta.apache.org>
For additional commands, e-mail: <mailto:tomcat-dev-help@;jakarta.apache.org>
