Re: TC5 JMX

2003-03-25 Thread Amy Roh
> Amy Roh wrote: > > >> I moved the valve registration in addValve(). > > > > Cool. I think logger and realm registration should be in setLogger and > > setRealm as well so mbeans can get registered correctly. Also, > > deregistration for old mbean should happen when new logger or realm is > > nu

Re: TC5 JMX

2003-03-24 Thread Costin Manolache
Amy Roh wrote: >> I moved the valve registration in addValve(). > > Cool. I think logger and realm registration should be in setLogger and > setRealm as well so mbeans can get registered correctly. Also, > deregistration for old mbean should happen when new logger or realm is > null. +1 :-) F

Re: TC5 JMX

2003-03-24 Thread Amy Roh
> Amy Roh wrote: > > > Costin, > > > > It doesn't seem like mbeans are created appropriately when logger, realm, > > and valve are dynamically added after start. Is the mbean registration > > code listening to those events? > > It should. > > For valve - I think it works now ( I'll make a commit s

Re: TC5 JMX

2003-03-24 Thread Costin Manolache
Amy Roh wrote: > Costin, > > It doesn't seem like mbeans are created appropriately when logger, realm, > and valve are dynamically added after start. Is the mbean registration > code listening to those events? It should. For valve - I think it works now ( I'll make a commit soon with few more