Amy Roh wrote: >> I moved the valve registration in addValve(). > > Cool. I think logger and realm registration should be in setLogger and > setRealm as well so mbeans can get registered correctly. Also, > deregistration for old mbean should happen when new logger or realm is > null.
+1 :-) For the second part - deregistration should happen on stop(). If you are going to implement this ( please ! ), don't worry about the embed use case, I'll fix it if there are problems. >> I got reload() to work - but right now I'm stuck with some problems in >> stop()/start(). >> >> Reload doesn't deal with modified web.xml - and for some reason >> stop()/start() finds some older mappers, something is not cleaning up. >> >> stop() does now remove all mbeans that it created. > > Awesome. :-) Well, I finally got it working ( in standalone ). I had to create a new ServletContext, copy all the settings, then unregister and register again. It's a bit tricky - we have to unregister/register, otherwise the mapper will not work, and what's worse - it's almost impossible to undo all the actions that happen in init/start ( since many are driven by web.xml ). I don't know how start/stop worked before ( or if it worked ), but creating a new context seemes like a reasonable solution and may avoid some leaks or other problems. The negative is that extending StandardContext will become more tricky. I'll probably commit tommorow - I still need to remove a lot of debug statements and test in embeded case. ( I also checked Host.stop - it seems to clean up the JMX, I don't know yet if start() will recreate the same environemnt ). Costin > > Amy > >> >> ( by "now" I mean my work version, I have a number of debug statements >> to remove and I'll check in ). >> >> >> >> Costin >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> For additional commands, e-mail: [EMAIL PROTECTED] >> >> --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
