Re: Logging The Revenge

2005-03-03 Thread Remy Maucherat
Remy Maucherat wrote: Regardless of how it is packaged, you can use log4j simply by putting it there. The system property trick is much harder with the exe. You're not using it though, so it's clearly a SEP ;) I'll provide a default configuration in "build", so that CVS users can try it. Ok, t

Re: Logging The Revenge

2005-03-03 Thread Remy Maucherat
Bill Barker wrote: As a log4j user I'd prefer a separate jar for Juli (so that I can remove her easily :). I'm pretty agnostic as to including it in the default tomcat-5.5.x.tar.gz or as tomcat-logging.tar.gz. In the second case, it should be enough to have tomcat-juli.jar. It's easy enough to h

Re: Logging The Revenge

2005-03-02 Thread Bill Barker
- Original Message - From: "Remy Maucherat" <[EMAIL PROTECTED]> To: "Tomcat Developers List" Sent: Wednesday, March 02, 2005 6:10 PM Subject: Logging The Revenge >Hi, > >As I will rewrite the documentation for java.util.logging, I'd like to >ask the question of how it will be packaged a

Re: Logging

2005-02-19 Thread Remy Maucherat
Bill Barker wrote: Jan Luehe wrote: Remy, Remy Maucherat wrote: Jan Luehe wrote: It's a little risky. We should use the container logger only while the classloader is initialized. It's probably far from perfect ;) Then how about RealmBase.authenticate()? RealmBase.authenticate(String username, St

Re: Logging (was: Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm DataSourceRealm.java JAASCallbackHandler.java JAASMemoryLoginModule.java JDBCRealm.java JNDIRealm.java RealmBase.java UserDatabaseRealm.java)

2005-02-19 Thread Bill Barker
- Original Message - From: "Remy Maucherat" <[EMAIL PROTECTED]> To: "Tomcat Developers List" Sent: Saturday, February 19, 2005 2:55 AM Subject: Logging (was: Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm DataSourceRealm.java JAASCallbackHandler.jav

RE: Logging filter (was RE: [next] What's next ?)

2003-10-02 Thread Shapira, Yoav
Howdy, Thanks for the response wrapper idea and skeleton -- that seems to solve most of the problems we discussed. >For access logging in particular, I'd be concerned about a couple of >things: > >* Filters don't see every request (for example, the authentication > challenges when you're using B

Re: Logging filter (was RE: [next] What's next ?)

2003-10-02 Thread Craig R. McClanahan
Shapira, Yoav wrote: Howdy, --- "Shapira, Yoav" <[EMAIL PROTECTED]> wrote: 1. Convert AccessLogValve to be a servlet specification 2.3 filter, i.e. That sounds wonderful and useful, but there are a few problems here. Filters don't have access to all the information that is needed

Re: Logging filter (was RE: [next] What's next ?)

2003-10-02 Thread Craig R. McClanahan
joe user wrote: --- "Shapira, Yoav" <[EMAIL PROTECTED]> wrote: 1. Convert AccessLogValve to be a servlet specification 2.3 filter, i.e. something portable. We can define it in $CATALINA_HOME/conf/web.xml, commented out by default perhaps, and users can move the definition around as they need

RE: Logging filter (was RE: [next] What's next ?)

2003-10-02 Thread Shapira, Yoav
Howdy, There's already an exposed API for writing tomcat loggers (just implement org.apache.catalina.Logger and configure your logger in server.xml). Let's get off that topic please and stick to the access log filter I was proposing. >I think that many of those values, such as >ContentLength, ar

RE: Logging filter (was RE: [next] What's next ?)

2003-10-02 Thread joe user
--- "Shapira, Yoav" <[EMAIL PROTECTED]> wrote: > That's unfortunate ;( Yes it is. Those methods may not really belong in the Filter interface, though. That's why I think it may be a better idea to start thinking about a real API for more of the core components of the server: logging, classloadi

RE: Logging filter (was RE: [next] What's next ?)

2003-10-02 Thread Shapira, Yoav
Howdy, >--- "Shapira, Yoav" <[EMAIL PROTECTED]> wrote: >> 1. Convert AccessLogValve to be a servlet >> specification 2.3 filter, i.e. > >That sounds wonderful and useful, but there are a few >problems here. Filters don't have access to all the >information that is needed to make a log entry the

Re: [logging] Redirecting System.out to JDK1.4 Logging for tomcat

2002-07-25 Thread Bob Herrmann
On Thu, 2002-07-25 at 07:13, Remy Maucherat wrote: > Bob Herrmann wrote: > > I don't know if anyone else will find this interesting, but I wrote a > > class which redirects System.Out to JDK1.4 Logging. It is Tomcat > > aware and unrolls the stack in a way useful for Tomcat. This might be > > u

Re: [logging] Redirecting System.out to JDK1.4 Logging for tomcat

2002-07-25 Thread Remy Maucherat
Bob Herrmann wrote: > I don't know if anyone else will find this interesting, but I wrote a > class which redirects System.Out to JDK1.4 Logging. It is Tomcat > aware and unrolls the stack in a way useful for Tomcat. This might be > useful if you are embedding Tomcat. > > I changed catalina.sh

Re: [logging] Better support for stack walking

2002-07-23 Thread Bob Herrmann
Hi. This patch to commons logging allow you to specify which methods in the call stack are uninteresting when using the JDK1.4 Logger. In Tomcat this seems to be all methods named "log" and "internalLog." This is based on Costin's idea of uninteresting classes, but seems to work better for meth

Re: [logging] Better support for stack walking

2002-07-23 Thread costinm
> 1. For Log4J at least, the wrapper class is 'given' to the logger > implementation via a constructor argument. No, it is passed on each call. Log4j is the easiest, it has all the support we need. > 1.a. Log.setLogWrapper/setAttribute isn't enough. Putting aside > design/style arguments,

Re: Logging separation

2002-06-27 Thread costinm
On Thu, 27 Jun 2002, Ceki Gülcü wrote: > >I don't know any other way to pass/extract the information. > > If there is an object that keeps track of contexts, you can pass it to > the ContextualRepositorySelector when you instantiate it (the > CRS). The CRS could ask that object to return "the cu

Re: Logging separation

2002-06-27 Thread Ceki Gülcü
At 07:33 27.06.2002 -0700, [EMAIL PROTECTED] wrote: >On Thu, 27 Jun 2002, Ceki Gülcü wrote: > > > Let me just mention that using the TCL to keep track of the context is > > just one possible solution. Is there another place that keeps track of > > what thread is executing what web-application? Rem

Re: Logging separation

2002-06-27 Thread costinm
On Thu, 27 Jun 2002, Ceki Gülcü wrote: > Let me just mention that using the TCL to keep track of the context is > just one possible solution. Is there another place that keeps track of > what thread is executing what web-application? Remember that the > ContextRepositorySelector is implemented wi

Re: Logging separation

2002-06-27 Thread Ceki Gülcü
At 07:03 27.06.2002 -0700, [EMAIL PROTECTED] wrote: > > As an aside, setting the logger in the static init method is almost always > > wrong for a servlet. If the class is living in a jar in lib/apps, then > only > > one logger gets created even if the servlet is used in several webapps. > >+1 >

Re: Logging separation

2002-06-27 Thread costinm
"Ceki Gülcü" <[EMAIL PROTECTED]> > > > To: "Tomcat Developers List" <[EMAIL PROTECTED]> > > > Sent: Wednesday, June 26, 2002 2:57 PM > > > Subject: Re: Logging separation > > > > > > > > > > > > A diff

Re: Logging separation

2002-06-27 Thread Ceki Gülcü
At 15:46 26.06.2002 -0700, Bill Barker wrote: >As an aside, setting the logger in the static init method is almost always >wrong for a servlet. If the class is living in a jar in lib/apps, then only >one logger gets created even if the servlet is used in several webapps. This is an important ob

Re: Logging separation

2002-06-27 Thread Ceki Gülcü
At 15:15 26.06.2002 -0700, [EMAIL PROTECTED] wrote: >On Wed, 26 Jun 2002, Ceki Gülcü wrote: > > > > A difficulty I encountered while implementing the solution outlined in > > http://qos.ch/containers/sc.html is the difference of TCL while the the > > static class initializer of a servlet class is

Re: Logging separation

2002-06-26 Thread Bill Barker
- Original Message - From: <[EMAIL PROTECTED]> To: "Tomcat Developers List" <[EMAIL PROTECTED]> Sent: Wednesday, June 26, 2002 3:33 PM Subject: Re: Logging separation > On Wed, 26 Jun 2002, Bill Barker wrote: > > > This is basically the same as >

RE: Logging separation

2002-06-26 Thread Ignacio J. Ortega
> De: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] > Enviado el: 27 de junio de 2002 0:33 > > any container-sensitive operations. > > Do you think we should set the TCL before calling contextInit or in > ServetHandler.getServlet() ? Just reviewed that code, +1 for this change.. Ceki is talkin

Re: Logging separation

2002-06-26 Thread costinm
lt;[EMAIL PROTECTED]> > Sent: Wednesday, June 26, 2002 2:57 PM > Subject: Re: Logging separation > > > > A difficulty I encountered while implementing the solution outlined in > http://qos.ch/containers/sc.html is the difference of TCL while the the > static class initi

Re: Logging separation

2002-06-26 Thread Bill Barker
essage - From: "Ceki Gülcü" <[EMAIL PROTECTED]> To: "Tomcat Developers List" <[EMAIL PROTECTED]> Sent: Wednesday, June 26, 2002 2:57 PM Subject: Re: Logging separation A difficulty I encountered while implementing the solution outlined in http://qos.ch/containers/

Re: Logging separation

2002-06-26 Thread costinm
On Wed, 26 Jun 2002, Ceki Gülcü wrote: > A difficulty I encountered while implementing the solution outlined in > http://qos.ch/containers/sc.html is the difference of TCL while the the > static class initializer of a servlet class is executed and the TCL while a > servlet is running. There

Re: Logging separation

2002-06-26 Thread Ceki Gülcü
A difficulty I encountered while implementing the solution outlined in http://qos.ch/containers/sc.html is the difference of TCL while the the static class initializer of a servlet class is executed and the TCL while a servlet is running. There are two distinct TCLs. (I've tried this on Tomcat

Re: Logging: more classloader problems.

2002-06-06 Thread Craig R. McClanahan
On Thu, 6 Jun 2002 [EMAIL PROTECTED] wrote: > Date: Thu, 6 Jun 2002 11:08:10 -0700 (PDT) > From: [EMAIL PROTECTED] > Reply-To: Jakarta Commons Developers List <[EMAIL PROTECTED]> > To: Jakarta Commons Developers List <[EMAIL PROTECTED]> > Cc: List Tomcat-Dev <[EMAIL PROTECTED]> > Subject: Logging

Re: Logging: more classloader problems.

2002-06-06 Thread costinm
On Thu, 6 Jun 2002, Geir Magnusson Jr. wrote: > On 6/6/02 2:08 PM, "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote: > > > > > Solution: > > Split commons-logging.jar in commons-logging-api.jar ( only the API and > > the LogFactoryImpl, no adapteer ) and commons-logging-impl.jar. > > :) If you k

Re: Logging - where?

2001-10-02 Thread cmanolache
First, which tomcat ? For 3.3: > 1) Where is logging done? Could you give me pointers to specific > classes/methods I need to modify? The interface is o.a.t.util.log, o.a.t.modules.config.LogSetter will plug the default implementation. Write a new implementation and replace LogSetter, and you

Re: Logging - where?

2001-10-02 Thread Craig R. McClanahan
On Tue, 2 Oct 2001, Deacon Marcus wrote: > Date: Tue, 2 Oct 2001 18:24:07 +0200 > From: Deacon Marcus <[EMAIL PROTECTED]> > Reply-To: [EMAIL PROTECTED] > To: [EMAIL PROTECTED] > Subject: Logging - where? > > Hi, > I seriuosly considering replacing standard logging with custom Log4J-MySQL, > so

Re: Logging Memory Leak 3.2.2-beta2

2001-04-11 Thread cmanolache
Hi, If you want to save us a lot of time, could you get a demo of OptimizeIt or JProbe ( or use -hprof option in java ) and send the result. ( either of those will show you the allocated objects - if there is a leak then you'll see it there, just run 1 requests, GC, repeat few times, and lo

RE: Logging Memory Leak 3.2.2-beta2

2001-04-11 Thread Marc Saegesser
I don't think your seeing a real memory leak. What's happening is that the logging mechanism in Tomcat doesn't actually write log messages to log files when Logger.log() is called. Logger.log() adds a log entry to a queue and returns immediately. A daemon thread then pulls the log entries off t

Re: Logging Issues

2001-03-08 Thread cmanolache
Hi Thomas, It would be great if you can help adding log4j support in tomcat3.3. My only problem ( and I'm very strong about this ) is that I don't like the "only one way to implement something" aproach. Log4j has great features, I like the code - but it's not the solution for all cases. I alre

Re: Logging TC4.0 and measurement

2000-11-08 Thread Remy Maucherat
> Remy, > > I wondered about the impact of logging. > > I'm not personally interested in comparing 3.x and 4.x, just in getting a > database on 4.0. I also wonder if such a comparison might ignore the > feature differences noted in the rant postings last week. > > I am interested in what the thrup