Re: PersistentManagerBase (etc) Patches

2004-12-17 Thread Jess Holle
therefore also planned. I'll certainly provide feedback (and further patches if/where appropriate) as I gain more real world experience with this approach. -- Jess Holle Index: PersistentManagerBase.java === RCS file: /home/cvspubl

Re: PersistentManagerBase (etc) Patches

2004-12-17 Thread Remy Maucherat
Jess Holle wrote: [Yes, the Request change would still be necessary to prevent the chance of requests randomly getting their sessions passivated and recycle after they findSession() but before access().] A session can be passivated at any (bad) time (which will screw up requests), and we already

Re: PersistentManagerBase (etc) Patches

2004-12-16 Thread Jess Holle
Attached are a new PersistentManagerBase patch and a new PersistentSession class. Together these eliminate the need for the changes to ManagerBase and StandardSession (but not to Request, but this change is an innocuous reordering of a couple of lines of code). I've not had a chance to test th

Re: PersistentManagerBase (etc) Patches

2004-12-16 Thread Jess Holle
On further analysis it seems that StandardSession is only constructed by ManagerBase and indirectly from SimpleTcpReplicationManager via the ReplicatedSession subclass. Given that SimpleTcpReplicationManager is mutually exclusive of PersistentManager, it would appear I should move my StandardSe

Re: PersistentManagerBase (etc) Patches

2004-12-16 Thread Jess Holle
Remy Maucherat wrote: Jess Holle wrote: Where have I "faked" robustness? I will not claim I actually achieve it, but I certainly tried, fixed real race condition cases, and don't know of ones I missed. The only race condition that I can possibly imagine is on accessCount, which I think is somet

Re: PersistentManagerBase (etc) Patches

2004-12-16 Thread Jess Holle
Remy Maucherat wrote: Jess Holle wrote: It is not useful without the rest of the changes as without the rest of the changes there are intolerable race conditions. Right. I suppose that's the end of the discussion then, it would be a waste of time to continue. -1 for your patch. If you really fee

Re: PersistentManagerBase (etc) Patches

2004-12-16 Thread Remy Maucherat
Jess Holle wrote: Where have I "faked" robustness? I will not claim I actually achieve it, but I certainly tried, fixed real race condition cases, and don't know of ones I missed. The only race condition that I can possibly imagine is on accessCount, which I think is something quite unimportant

Re: PersistentManagerBase (etc) Patches

2004-12-16 Thread Jess Holle
Remy Maucherat wrote: Jess Holle wrote: Remy Maucherat wrote: I'd appreciate comments as to what's wrong with the patch :-) I am clearly new to this area of Tomcat, but there were clear issues in this area of the code that I cannot ignore if I am to depend on PersistentManager. * Extremely in

Re: PersistentManagerBase (etc) Patches

2004-12-16 Thread Remy Maucherat
Jess Holle wrote: It is not useful without the rest of the changes as without the rest of the changes there are intolerable race conditions. Right. I suppose that's the end of the discussion then, it would be a waste of time to continue. -1 for your patch. If you really feel insecure, then you c

Re: PersistentManagerBase (etc) Patches

2004-12-16 Thread Remy Maucherat
Jess Holle wrote: Remy Maucherat wrote: I'd appreciate comments as to what's wrong with the patch :-) I am clearly new to this area of Tomcat, but there were clear issues in this area of the code that I cannot ignore if I am to depend on PersistentManager. * Extremely inefficient behavior whe

Re: PersistentManagerBase (etc) Patches

2004-12-16 Thread Jess Holle
Jess Holle wrote: Remy Maucherat wrote: Jess Holle wrote: And finally, here are the patches against 5.5.6 (same as HEAD at this moment in this case). Ok, but I still dislike the patch ;) I'd appreciate comments as to what's wrong with the patch :-) Sorry I missed your previous commen

Re: PersistentManagerBase (etc) Patches

2004-12-16 Thread Jess Holle
Remy Maucherat wrote: Jess Holle wrote: And finally, here are the patches against 5.5.6 (same as HEAD at this moment in this case). Ok, but I still dislike the patch ;) I'd appreciate comments as to what's wrong with the patch :-) I am clearly new to this area of Tomcat, but there

Re: PersistentManagerBase (etc) Patches

2004-12-16 Thread Remy Maucherat
Jess Holle wrote: And finally, here are the patches against 5.5.6 (same as HEAD at this moment in this case). Ok, but I still dislike the patch ;) Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail

Re: PersistentManagerBase (etc) Patches

2004-12-16 Thread Jess Holle
And finally, here are the patches against 5.5.6 (same as HEAD at this moment in this case). -- Jess Holle Jess Holle wrote: Here's the patches against 5.5.4 Jess Holle wrote: For those who tried finding through the patches only to find that they did not properly map against CVS (as I

Re: PersistentManagerBase (etc) Patches

2004-12-15 Thread Jess Holle
Here's the patches against 5.5.4 Jess Holle wrote: For those who tried finding through the patches only to find that they did not properly map against CVS (as I just used 'diff -u' in a directory not in a proper CVS tool...), please see the attached patch files against 5.0

Re: PersistentManagerBase (etc) Patches

2004-12-15 Thread Jess Holle
For those who tried finding through the patches only to find that they did not properly map against CVS (as I just used 'diff -u' in a directory not in a proper CVS tool...), please see the attached patch files against 5.0.30 (which were donoe with a proper CVS tool). I have reworke

PersistentManagerBase (etc) Patches

2004-12-13 Thread Jess Holle
RU sorting to passivate oldest sessions first. I also discovered that all passivated sessions are regularly (every minuted by default) read back into memory in their entirety to check if they should be expired. The attached set of patches is intended to address all of these issues -- and seem

Re: PersistentManagerBase (etc) Patches

2004-12-13 Thread Remy Maucherat
and (2) a lack of LRU sorting to passivate oldest sessions first. I also discovered that all passivated sessions are regularly (every minuted by default) read back into memory in their entirety to check if they should be expired. The attached set of patches is intended to address all of th

Re: Patches for apr and webapp module

2004-03-29 Thread jean-frederic clere
. Since the webpage suggested checking the code out from CVS, I went ahead and did that. It seems that those sources may build, but don't run. Attached are some patches I have put together to be checked into CVS by one of the developers of the jakarta-tomcat-connectors. Patched files in

Re: Patches for apr and webapp module

2004-03-29 Thread Walter Truitt
And for apr. -walter *** apr/network_io/unix/sockaddr.c.orig Thu Mar 4 10:17:25 2004 --- apr/network_io/unix/sockaddr.c Mon Mar 29 15:02:06 2004 *** *** 97,102 --- 97,109 } } + APR_DECLARE(apr_status_t) apr_sockaddr_port_get(apr_port_t *port, +

Re: Patches for apr and webapp module

2004-03-29 Thread Walter Truitt
Oh, so the list does not accept attachments. Bummer. Here are the patches inline. This one is for webapp. I will send the apr patch in a separate message. -walter *** webapp/lib/pr_warp_network.c.orig Tue Feb 24 02:59:09 2004 --- webapp/lib/pr_warp_network.cMon Mar 29 10:29:52

Patches for apr and webapp module

2004-03-29 Thread Walter Truitt
ahead and did that. It seems that those sources may build, but don't run. Attached are some patches I have put together to be checked into CVS by one of the developers of the jakarta-tomcat-connectors. Patched files include: webapp/lib/pr_warp_network.c webapp/lib/pr_warp_socketpool.c apr/netwo

Recent Patches - Tab 'Fix'

2004-02-27 Thread NormW
Good afternoon All. Attached are three patches requested by an under-cover tab policeman. No offence intended, but I'm obliged to assist the police in this matter. Norm --- changes.txt.orig Fri Feb 27 20:09:16

Re: Patches for catalina.sh

2003-06-25 Thread Craig R. McClanahan
On Wed, 25 Jun 2003, Ronald Klop wrote: > Date: Wed, 25 Jun 2003 11:29:49 +0200 > From: Ronald Klop <[EMAIL PROTECTED]> > Reply-To: Tomcat Developers List <[EMAIL PROTECTED]> > To: Tomcat Developers List <[EMAIL PROTECTED]> > Subject: Re: Patches for catalina.sh

Re: Patches for catalina.sh

2003-06-25 Thread Ronald Klop
And while your at it can you look at the double '=' in: > + -Djava.security.policy=="$CATALINA_BASE"/conf/catalina.policy \ See: http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20859. Greetings, Ronald. Noel J. Bergman wrote: The attached patches are for catalina.sh

Patches for catalina.sh

2003-06-25 Thread Noel J. Bergman
The attached patches are for catalina.sh under both the jakarta-tomcat-4 and jakarta-catalina modules. They re-synch changes made to one and not the other, and add a default for CATALINA_PID. Tomcat 4 (http://cvs.apache.org/viewcvs.cgi/jakarta-tomcat-4.0/catalina/src/bin/catal ina.sh): - adds

some patches to mod_jk2

2003-06-01 Thread Günter Knauf
in the 'else' except the underscore for snprintf... the same applies with vsnprintf: defined in jk_global.h 265, but nevertheless a ifdef in jk_logger_file.c line 368... if you agree that these are obsolete than I will remove that too and make patches ready which I send you; I will first c

[Tomcat 5] Patches and bug fixes from Tomcat 4 ported

2002-12-08 Thread Glenn Nielsen
I went through all my commits to Tomcat 4 since work on Tomcat 5 started. I have ported all the patches, bug fixes, etc. to Tomcat 5 where appropriate. Glenn -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

patches to remove calls to setenv

2002-12-04 Thread Phil Hanna
er.sh startup-using-launcher.bat startup-using-launcher.sh tool-wrapper-using-launcher.bat tool-wrapper-using-launcher.sh tool-wrapper.bat tool-wrapper.sh The attached zip files contain diff -u patches for all these files. catalina-setenv-diffs.zip Description: catalina-s

[PATCH] jakarta-servletapi-5: Additional XSD file patches

2002-09-24 Thread Mark Roth
Attached is a patch to bring the other Servlet 2.4 XSD files up to date with the JSP patch I submitted on September 19. Files modified: - jsr154/src/share/dtd/j2ee_1_4.xsd - jsr154/src/share/dtd/web-app_2_4.xsd - jsr154/src/share/dtd/xml.xsd -- Mark Roth, Java Software JSP 2.0 Co-Spe

Re: Contributing patches/enhancements?

2002-09-11 Thread Steve Downey
From my experience, it depends if it's a bug or an enhancement. If it's a bug, Bugzilla is your friend. Someone will eventually have to deal with it before a release. Just posting to the mailing list means that it's likely to get lost. And patches for bugs tend to be fairly s

Re: Contributing patches/enhancements?

2002-09-11 Thread Craig R. McClanahan
On Wed, 11 Sep 2002, Eddie Ruvinsky wrote: > Date: Wed, 11 Sep 2002 15:16:19 -0700 (PDT) > From: Eddie Ruvinsky <[EMAIL PROTECTED]> > Reply-To: Tomcat Developers List <[EMAIL PROTECTED]> > To: [EMAIL PROTECTED] > Subject: Contributing patches/enhancements? &g

Contributing patches/enhancements?

2002-09-11 Thread Eddie Ruvinsky
Hello, I have a process question about how I could contribute Tomcat source patches/enhancements? Would I open a Bugzilla and attach a diff text file, then wait for an official Tomcat contributor to review it and add it into the source tree? Thanks, Eddie

Re: JDK version support when coding patches

2002-09-09 Thread Amy Roh
Christopher Todd wrote: > I am working on a patch for Tomcat 4.x, and was wondering if there were any > requirements for supporting older versions of the JDK. Can I code up a > patch that uses classes and/or methods only available in 1.4, or do I have > to support 1.2? Can I write two versions,

JDK version support when coding patches

2002-09-09 Thread Christopher Todd
I am working on a patch for Tomcat 4.x, and was wondering if there were any requirements for supporting older versions of the JDK. Can I code up a patch that uses classes and/or methods only available in 1.4, or do I have to support 1.2? Can I write two versions, one that uses 1.4 APIs, and one

Re: getting patches commited

2002-08-21 Thread Bob Herrmann
On Wed, 2002-08-21 at 11:28, John Trollinger wrote: > If I add a patch to a bug does the patch still have to be submitted as a > patch (via the [patch] subject line) to get into committers hands? No, but posting to the tomcat-dev list is more visible. Your subject line is pretty important also.

getting patches commited

2002-08-21 Thread John Trollinger
If I add a patch to a bug does the patch still have to be submitted as a patch (via the [patch] subject line) to get into committers hands? Thanks, John -- To unsubscribe, e-mail: For additional commands, e-mail:

possible patches to update the ROOT/index.html to be valid HTML 4.01 for Tomcat 3.x and 4.x

2002-03-16 Thread Alf Høgemark
ht="80" alt="Powered by Tomcat"> 140,141c139,140 < Copyright © 1999-2001 Apache Software Foundation < All Rights Reserved --- > Copyright © 1999-2001 Apache Software >Foundation > All Rights Reserved Please note that even after applying this patch for the ROOT/index.jsp page, it is not valid, as it uses the bordercolor attribute on the table element, which seems to be IE feature. It's not part of HTML4.01. I can also produce patches to make the pages valid XHTML1.0, but then some browsers probably get troubles.. Any comments appreciated Alf Hogemark

cvs commit: jakarta-tomcat/proposals/patches/tomcat33a JspInterceptor.java JavaGeneratorTool.java ContextManager.java

2002-03-13 Thread larryi
larryi 02/03/13 19:17:05 Removed: proposals/patches/tomcat33a JspInterceptor.java JavaGeneratorTool.java ContextManager.java Log: Remove extra sources used for Tomcat 3.3a -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional comma

cvs commit: jakarta-tomcat/proposals/patches/tomcat33a JspInterceptor.java JavaGeneratorTool.java ContextManager.java

2002-01-12 Thread larryi
larryi 02/01/12 08:07:44 Modified:proposals/patches/tomcat33a JspInterceptor.java JavaGeneratorTool.java ContextManager.java Log: Patches for Tomcat 3.3a to avoid DOS vulnerability, display "not found" for the vulnerable request, and update the

cvs commit: jakarta-tomcat/proposals/patches/tomcat33a JspInterceptor.java JavaGeneratorTool.java ContextManager.java

2002-01-12 Thread larryi
larryi 02/01/12 08:02:17 Added: proposals/patches/tomcat33a JspInterceptor.java JavaGeneratorTool.java ContextManager.java Log: Add original Tomcat 3.3 sources that need patching for Tomcat 3.3a. Revision ChangesPath 1.1

cvs commit: jakarta-tomcat/proposals/patches/tomcat33a - New directory

2002-01-12 Thread larryi
larryi 02/01/12 08:01:06 jakarta-tomcat/proposals/patches/tomcat33a - New directory -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

cvs commit: jakarta-tomcat/proposals/patches - New directory

2002-01-12 Thread larryi
larryi 02/01/12 08:00:58 jakarta-tomcat/proposals/patches - New directory -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Re: [PATCHES] SSL Sockets

2001-08-14 Thread Pier P. Fumagalli
Christopher Cain at [EMAIL PROTECTED] wrote: > > "Pier P. Fumagalli" wrote: >> >> Err... Warp doesn't (yet) support TLS sockets, but, since you changed the >> signature, I believe it needs to go in :) :) :) > > I figured that you are already answering enough mail on how to build > Warp, so I b

Re: [PATCHES] SSL Sockets

2001-08-13 Thread Christopher Cain
tures out from under you ;-) > Well, FWICS, it seems that the patches are OK... +1 for me... =)

Re: [PATCHES] SSL Sockets

2001-08-13 Thread Pier P. Fumagalli
orrectly handling multiple keystore > entries. > > - Christopher > > P.S. I did the happy "clean-then-build" hoo-ha, so it compiles cleanly against > the full source. Err... Warp doesn't (yet) support TLS sockets, but, since you changed the signature, I believe it needs to go in :) :) :) Well, FWICS, it seems that the patches are OK... +1 for me... Pier

[PATCHES] SSL Sockets

2001-08-13 Thread Christopher Cain
The attached 5-pack is stage one of a three-step process working toward a fix for TC4 Bug #1400: proper handling of a keystore with multiple entries. This round is simply a cleanup of the exception handling/logging. The initial implementation had notes about "FIXME", so I did :-) These may loo

RE: Acceptance of patches

2001-06-12 Thread Larry Isaacs
eases, both of which should contain the fix. See if the problem is fixed and let me know if it is not. Cheers, Larry > -Original Message- > From: Jochen Wiedmann [mailto:[EMAIL PROTECTED]] > Sent: Tuesday, June 12, 2001 9:38 AM > To: [EMAIL PROTECTED] > Subject: Acceptan

Acceptance of patches

2001-06-12 Thread Jochen Wiedmann
Hi, it is quite some weeks since I have posted a patch for a bug that makes TomCat's getWriter().flush() method completely unusable. (Perhaps in standalone method only.) I have also submitted a bug report (#1802). Since then I have never received a reply and the bug report is still in the state

Re: 8 Patches for Win2k, Forte2.0 & JDK1.3.0_01

2001-05-23 Thread Craig R. McClanahan
On Wed, 23 May 2001, Peter Costello wrote: > The following patches were made to get > jakarta-tomcat4.0-b5 to > compile and work properly in an environment using > Win2000, > JDK1.3.0_01 and Forte2.0 IDE. > > Could an active developer please review and check > out/in t

Re: 8 Patches for Win2k, Forte2.0 & JDK1.3.0_01

2001-05-23 Thread Craig R. McClanahan
On Wed, 23 May 2001, Mark.Abbott wrote: > > > Peter Costello wrote: > > > > > > === > > 1) org.apache.catalina.authenticator.FormAuthenticate > > > >The following enhancement allows the IE5.0 browser > > to maintai

Re: 8 Patches for Win2k, Forte2.0 & JDK1.3.0_01

2001-05-23 Thread Mark.Abbott
Peter Costello wrote: > > > === > 1) org.apache.catalina.authenticator.FormAuthenticate > >The following enhancement allows the IE5.0 browser > to maintain the >correct URL in its history list. For example, if >

8 Patches for Win2k, Forte2.0 & JDK1.3.0_01

2001-05-23 Thread Peter Costello
The following patches were made to get jakarta-tomcat4.0-b5 to compile and work properly in an environment using Win2000, JDK1.3.0_01 and Forte2.0 IDE. Could an active developer please review and check out/in the changes

Re: Tomcat 3.2.2 patches

2001-04-24 Thread cmanolache
On Tue, 24 Apr 2001, Marc Saegesser wrote: > Costin, Henri, > > You both asked about some simple patches for Tomcat 3.2.2. There will be > another (hopefully the last) beta release for 3.2.2, so go ahead and commit > those changes. Thanks. > I'm working a bug in Jas

RE: Tomcat 3.2.2 patches

2001-04-24 Thread GOMEZ Henri
I'll commit later the latest mod_jk patches but only those which could be under the 3.2.2 mod_jk. (I couldn't add the fix for tomcat restart case for example) - Henri Gomez ___[_] EMAIL : [EMAIL PROTECTED](. .) PGP KEY : 697ECEDD

Tomcat 3.2.2 patches

2001-04-24 Thread Marc Saegesser
Costin, Henri, You both asked about some simple patches for Tomcat 3.2.2. There will be another (hopefully the last) beta release for 3.2.2, so go ahead and commit those changes. I'm working a bug in Jasper that will certainly require some soak time to make sure nothing else gets b

RE: 5 Patches ...

2001-04-06 Thread Vitayaudom, Victor
Title: RE: 5 Patches ...  Resending with file. Apologize for the err. -Victor -Original Message- From: Vitayaudom, Victor To: '[EMAIL PROTECTED]' Sent: 4/2/01 6:52 PM Subject: 5 Patches ... Please note patch 1 and especially 4. Just helping out.   -Victor patc

Re: 5 Patches ...

2001-04-02 Thread cmanolache
Hi Victor, Could you send the patches too :-) Costin On Mon, 2 Apr 2001, Vitayaudom, Victor wrote: > Please note patch 1 and especially 4. > > Just helping out. > -Victor > > > patchfile1.txt > -- > I'm interested in sending a patches to fix

5 Patches ...

2001-04-02 Thread Vitayaudom, Victor
Title: 5 Patches ... Please note patch 1 and especially 4. Just helping out.   -Victor patchfile1.txt --   I'm interested in sending a patches to fix a problem I'm   encountering. I'm using jasper save myself deployment time by   testing the integrit

Re: Patches in Bugzilla

2001-03-08 Thread Pier P. Fumagalli
Dan Milstein <[EMAIL PROTECTED]> wrote: > I'm having a problem using Bugzilla, and I'm hoping someone can point me > towards an easy solution. > > When people post bug reports, they often include patches in the text of the > description (which is great). However

Patches in Bugzilla

2001-03-06 Thread Dan Milstein
I'm having a problem using Bugzilla, and I'm hoping someone can point me towards an easy solution. When people post bug reports, they often include patches in the text of the description (which is great). However, it's very difficult for me to get those patches into a file so tha

Re: Patches and TC 4.1

2001-01-14 Thread Remy Maucherat
> Remy Maucherat wrote: > I have an issue with 4.1 code (fresh from CVS) at the moment -- the JSP examples > do not run correctly. That is, any JSP page that references a bean class that > is loaded from WEB-INF/classes or WEB-INF/lib fails to find that class. The classpath generation for Jaspe

Re: Patches and TC 4.1

2001-01-13 Thread Craig R. McClanahan
is *much* more confusing to users who expect a binary distribution to be "complete". > > > I will be examining your patches (and Kief's work on session persistence) > over > > the weekend -- look for some commits and/or questions later on. > > I was planning to d

Patches and TC 4.1

2001-01-13 Thread Remy Maucherat
> David Weinrich wrote: > > Now that it's an Apache project, I am +1 for using it ... both here, and as an > implementation of org.apache.catalina.Logger for the general purpose logging > that goes on inside Catalina. +1. Will it be required to build ? > I will be exam

[PATCHES] Catalina Session handling

2001-01-12 Thread Kief Morris
This is the first of two sets of patches relating to sessions. The following set will be my proposed session persistence package, while these are more general and should be considered independently. ManagerBase.java - Fixed a bug where recycled sessions

[PATCHES] Catalina 4.1 Session Persistence

2001-01-12 Thread Kief Morris
These patches are my proposal for session persistence in Catalina 4.1. Please look these over and give me your comments, and commit them if they look OK. The main change is the addition of a PersistentManager class, an optional replacement for StandardManager, providing the following

RE: Ajp13 Patches for Tomcat 3.2

2000-12-15 Thread GOMEZ Henri
More on the patch. It is included in my 3.2.1 RPM since it works nice and corrected the problem. Another bug less in ajp13. Thanks

RE: Ajp13 Patches for Tomcat 3.2

2000-12-14 Thread GOMEZ Henri
Fine patches. Since I've adapted your patch on multiple cookies, we could have a more clean ajp13 on TC 3.2.1 and TC 3.3. I'll apply your patches to the RPM I'll release for 3.2.1 "Pour la plupart des hommes, se corriger consiste à changer de défauts." -- Voltaire

Re: Ajp13 Patches for Tomcat 3.2

2000-12-13 Thread cmanolache
Hi Dan, Did you get your CVS login ? If not, I'll start checking in your patches ( at least to 3.3 ). Costin > All, > > I took some of the Ajp13 work I've been doing on the 3.3 branch and applied it to >the 3.2 sources. The two attached files contain a fix for th

Ajp13 Patches for Tomcat 3.2

2000-12-13 Thread Dan Milstein
All, I took some of the Ajp13 work I've been doing on the 3.3 branch and applied it to the 3.2 sources. The two attached files contain a fix for the file upload bug. As with the 3.3 version, there are some changes to the mod_jk.so source files, so to get the full effect, you'll need to rebui

[PATCH] charset & line terminator (Re: My patches for Tomcat 3.2wrt mutlibyte characters)

2000-12-10 Thread Kazuhiro Kazama
From: Costin Manolache <[EMAIL PROTECTED]> Subject: Re: My patches for Tomcat 3.2 wrt mutlibyte characters Date: Wed, 6 Dec 2000 21:55:45 -0800 (PST) Message-ID: <[EMAIL PROTECTED]> > The least we can do is to detect if the encoding is > compatible with ASCII ( or UNI

More Ajp13 Patches

2000-12-08 Thread Dan Milstein
Okay, I've done some more basic testing of my new code, so here it is. Let me know if you find any problems with it. Here's what I've done: - Fixed a basic problem with the way request data was read, which would have resulted in sporadic failure to get all the request data from the client.

Re: My patches for Tomcat 3.2 wrt mutlibyte characters

2000-12-07 Thread Danno Ferrin
000, Costin Manolache wrote: > > >> One problem I have with the patches ( and I sent a >> reply to Pilho Kim the first time he posted the >> patches) is the impact on performances. >> >> The least we can do is to detect if the encoding is >> compatib

Re: My patches for Tomcat 3.2 wrt mutlibyte characters

2000-12-07 Thread Danno Ferrin
n Wed, 6 Dec 2000, Costin Manolache wrote: > > >> One problem I have with the patches ( and I sent a >> reply to Pilho Kim the first time he posted the >> patches) is the impact on performances. >> >> The least we can do is to detect if the encoding is >> compatib

Re: My patches for Tomcat 3.2 wrt mutlibyte characters

2000-12-07 Thread Craig R. McClanahan
Pilho Kim wrote: > Hi, Costin > > If you want to get Content-Length, > is String.length() valid or not ? > > Tomcat dvelopers, containg you, must know this. > HTTP/1.1 spec (i.e. RFC 2616), Section 14.13: "The Content-Length entity-header field indicates the size of the entity-body, in

Patches for native plugins (3.2.1)

2000-12-07 Thread Mike Anderson
Here are a couple of patches for the native plugins on NetWare. The first one fixes a problem when submitting dating from a form with a POST request. I'd been testing with the latest internal Enterprise Server headers and someone found out that NetWare 5.1 doesn't have some t

Re: My patches for Tomcat 3.2 wrt mutlibyte characters

2000-12-07 Thread Pilho Kim
Hi, Costin If you want to get Content-Length, is String.length() valid or not ? Tomcat dvelopers, containg you, must know this. Kim. On Wed, 6 Dec 2000, Costin Manolache wrote: > One problem I have with the patches ( and I sent a > reply to Pilho Kim the first time he post

Re: My patches for Tomcat 3.2 wrt mutlibyte characters

2000-12-06 Thread Costin Manolache
One problem I have with the patches ( and I sent a reply to Pilho Kim the first time he posted the patches) is the impact on performances. The least we can do is to detect if the encoding is compatible with ASCII ( or UNICODE ) and use the getBytes() only if it isn't. The method has

Re: My patches for Tomcat 3.2 wrt mutlibyte characters

2000-12-06 Thread Kazuhiro Kazama
From: Pilho Kim <[EMAIL PROTECTED]> Subject: Re: My patches for Tomcat 3.2 wrt mutlibyte characters Date: Thu, 7 Dec 2000 11:30:42 +0900 (KST) Message-ID: <[EMAIL PROTECTED]> > This is your big fault. > You should know the real meaning of default in API. > What is the de

Re: My patches for Tomcat 3.2 wrt mutlibyte characters

2000-12-06 Thread Pilho Kim
On Tue, 5 Dec 2000, Kazuhiro Kazama wrote: > From: Pilho Kim <[EMAIL PROTECTED]> > Subject: My patches for Tomcat 3.2 wrt mutlibyte characters > Date: Tue, 5 Dec 2000 09:47:38 +0900 (KST) > Message-ID: <[EMAIL PROTECTED]> > > Try to visit > > > >

Re: Patches

2000-12-06 Thread Craig R. McClanahan
Shahed Ali wrote:  Hello, Where can I get hold of patches to Tomcat and their descriptions ? Also, how can I find out which patches are applied to my installed version of tomcat ?I have downloaded a binary version. ThanksShahed. You can find out about changes to the Tomcat source code as they

Patches

2000-12-06 Thread Shahed Ali
Hello,   Where can I get hold of patches to Tomcat and their descriptions ?   Also, how can I find out which patches are applied to my installed version of tomcat ? I have downloaded a binary version.   Thanks Shahed.

Re: My patches for Tomcat 3.2 wrt mutlibyte characters

2000-12-05 Thread Kazuhiro Kazama
From: Pilho Kim <[EMAIL PROTECTED]> Subject: My patches for Tomcat 3.2 wrt mutlibyte characters Date: Tue, 5 Dec 2000 09:47:38 +0900 (KST) Message-ID: <[EMAIL PROTECTED]> > Try to visit > > http://www.javaclue.org/tomcat/patch32/dopatch.html > > I hope that t

My patches for Tomcat 3.2 wrt mutlibyte characters

2000-12-04 Thread Pilho Kim
Hi, Try to visit http://www.javaclue.org/tomcat/patch32/dopatch.html I hope that those would be adopted in TC 3.2.1. Thanks, Kim

RE: mod_jk patches for TC 3.3

2000-11-10 Thread Nacho
Done for the patches submitted by Henry, Henry you have been voted as committer 2 times AFAIK., What's the problem ? Saludos , Ignacio J. Ortega > -Mensaje original- > De: Larry Isaacs [mailto:[EMAIL PROTECTED]] > Enviado el: viernes 10 de noviembre de 200

RE: mod_jk patches for TC 3.3

2000-11-10 Thread Larry Isaacs
> -Original Message- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] > Sent: Friday, November 10, 2000 12:50 PM > To: [EMAIL PROTECTED] > Subject: RE: mod_jk patches for TC 3.3 > > > > Makefile.linux, mod_jk for apache 1.3 and for jk in common. >

RE: mod_jk patches for TC 3.3

2000-11-10 Thread GOMEZ Henri
pouvoir" -- Lao Tzu >-Original Message- >From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] >Sent: Friday, November 10, 2000 6:50 PM >To: [EMAIL PROTECTED] >Subject: RE: mod_jk patches for TC 3.3 > > >> Makefile.linux, mod_jk for apache 1.3 and for jk in common.

RE: mod_jk patches for TC 3.3

2000-11-10 Thread cmanolache
> Makefile.linux, mod_jk for apache 1.3 and for jk in common. > We must be up to date with stuff from TC 3.2BETA7. > > If Costin or Larry or others commiters could update, it will be nice ;-) Costin can't do anything but XSL until Nov. 20... ( I am lucky a build takes 15 min. so I can read/answe

RE: mod_jk patches for TC 3.3

2000-11-10 Thread GOMEZ Henri
Please find attached a patch file for TC 3.3 mod_jk. Makefile.linux, mod_jk for apache 1.3 and for jk in common. We must be up to date with stuff from TC 3.2BETA7. If Costin or Larry or others commiters could update, it will be nice ;-) "La maîtrise des autres n'est que la force. La maîtrise de

mod_jk patches for TC 3.3

2000-11-10 Thread GOMEZ Henri
Another patch to add to mod_jk in CVS. It seems that mod_jk present is TC 3.3 CVS is an old snapshot of mod_jk. Many bugs fixes in TC 3.2B6 were missing. I'll take care of that and send patches to TC 3.3. --- jakarta-tomcat/src/native/mod_jk/apache1.3/mod_jk.c.origSat Aug 26 03: